labath added a comment.
> > Do you have a suggestion where the parsing code to be, if not in the same
> > directory?
>
>
> The parsing code will end up being used by multiple plugins--the new one
> you're building for Linux and the existing one that's Windows-specific.
I was hoping that w
You added LLDB as a subsriber. I don't know what that is, but the
correct name for the list is "lldb-commits".
pl
On 19 August 2016 at 04:54, Todd Fiala via lldb-commits
wrote:
> Huh, that is totally weird. I wonder what happened there?
>
> On Thu, Aug 18, 2016 at 8:12 PM, Zachary Turner wrote
dvlahovski updated this revision to Diff 68670.
dvlahovski added a comment.
Adding sanity checks whether the data buffer
contains the amound of bytes that we want to read.
All of the functions that were returning llvm::Optional
now return just const something *
and indicate for failure with the r
dvlahovski added a comment.
I'm thinking of doing the following approach regarding the plugin
implementation:
Start writing a new plugin "from scratch", which will be inspired strongly by
ProcessWinMiniDump and also borrowing stuff from ProcessElfCore.
Also my plan is to make a single cross-plat
Author: labath
Date: Fri Aug 19 07:31:49 2016
New Revision: 279232
URL: http://llvm.org/viewvc/llvm-project?rev=279232&view=rev
Log:
Remove the last manually constructed packet from gdb-remote register context +
small refactor
Summary:
The tricky part here was that the exisiting implementation o
This revision was automatically updated to reflect the committed changes.
Closed by commit rL279232: Remove the last manually constructed packet from
gdb-remote register context… (authored by labath).
Changed prior to commit:
https://reviews.llvm.org/D23659?vs=68525&id=68676#toc
Repository:
Author: dvlahovski
Date: Fri Aug 19 07:44:53 2016
New Revision: 279234
URL: http://llvm.org/viewvc/llvm-project?rev=279234&view=rev
Log:
Fixing a Darwing test thats failing on windows
The pexpect import should be make after the skip-if-not-darwin part
because pexpect is not available on Windows
labath added a comment.
Looks good as far as I am concerned. You might want to add a test or two that
makes sure we handle invalid data reasonably. E.g., load only the first X kb of
the minidump (so that the thread list is not present in the loaded block), and
make sure getting a thread list fa
Author: labath
Date: Fri Aug 19 08:14:13 2016
New Revision: 279238
URL: http://llvm.org/viewvc/llvm-project?rev=279238&view=rev
Log:
Fix 32-bit builds after r279232
GetByteSize() of a DataBuffer returns a uint64_t (it probably shouldn't), which
isn't implicitly
convertible to size_t.
Modified:
dvlahovski updated this revision to Diff 68690.
dvlahovski added a comment.
Move creation of ArrayRef after sanity check
Add a test that checks that the thread list is not present in a
truncated minidump file
https://reviews.llvm.org/D23545
Files:
cmake/LLDBDependencies.cmake
source/Plugin
Author: vedantk
Date: Fri Aug 19 13:41:50 2016
New Revision: 279296
URL: http://llvm.org/viewvc/llvm-project?rev=279296&view=rev
Log:
[lldb][cmake] Remove libclang as an lldbBase dependency (NFCI)
It's pulling in all kinds of things it doesn't need (e.g, clang-tidy!).
Eliminating this dependency
Author: kate
Date: Fri Aug 19 15:44:07 2016
New Revision: 279315
URL: http://llvm.org/viewvc/llvm-project?rev=279315&view=rev
Log:
Moved #include for lldb-python.h to a distinct group with a reminder comment
declaring that it must be first. Failure to do so results in build failures
on macOS due
Author: kate
Date: Fri Aug 19 15:46:37 2016
New Revision: 279316
URL: http://llvm.org/viewvc/llvm-project?rev=279316&view=rev
Log:
Reverted premature changes to .clang-format
Removed:
lldb/trunk/packages/Python/lldbsuite/.clang-format
Modified:
lldb/trunk/.clang-format
Modified: lldb/tr
Thanks, Dimitar!
I should have caught that.
On August 19, 2016 at 5:52:52 AM, Dimitar Vlahovski via lldb-commits (
lldb-commits@lists.llvm.org) wrote:
Author: dvlahovski
Date: Fri Aug 19 07:44:53 2016
New Revision: 279234
URL: http://llvm.org/viewvc/llvm-project?rev=279234&view=rev
Log:
Fixing
Author: vedantk
Date: Fri Aug 19 16:00:40 2016
New Revision: 279322
URL: http://llvm.org/viewvc/llvm-project?rev=279322&view=rev
Log:
Revert "[lldb][cmake] Remove libclang as an lldbBase dependency (NFCI)"
This reverts commit r279296. Including LLDBDependencies breaks the
netbsd lldb bot because
zturner added a comment.
Were you still going to change all the `Optionals` to raw pointers (or even
better, `llvm::Errors`)
Comment at: source/Plugins/Process/minidump/MinidumpParser.cpp:21
@@ +20,3 @@
+MinidumpParser::MinidumpParser(const lldb::DataBufferSP &data_buf_sp)
+
Author: lhames
Date: Fri Aug 19 16:27:16 2016
New Revision: 279327
URL: http://llvm.org/viewvc/llvm-project?rev=279327&view=rev
Log:
[lldb] Use OrcMCJITReplacement rather than MCJIT as the underlying JIT for LLDB
expression evaluation.
OrcMCJITReplacement is a reimplementation of MCJIT using ORC
Author: jingham
Date: Fri Aug 19 17:58:26 2016
New Revision: 279345
URL: http://llvm.org/viewvc/llvm-project?rev=279345&view=rev
Log:
Remove a test that depends on knowing all compiler's register allocation
schemes.
This test was using a condition that would compare a variable against the
regis
Author: enrico
Date: Fri Aug 19 19:48:11 2016
New Revision: 279353
URL: http://llvm.org/viewvc/llvm-project?rev=279353&view=rev
Log:
Add logic to the ObjC runtime in LLDB to extract the pointer values of the two
singleton (pairtons?) instances of __NSCFBoolean that represent true and false
This
Author: tfiala
Date: Fri Aug 19 19:54:03 2016
New Revision: 279354
URL: http://llvm.org/viewvc/llvm-project?rev=279354&view=rev
Log:
added Xcode lldb-gtest-for-debugging target
The lldb-gtest target is for CI and runs the tests as
part of the build phase. It does not support debugging
the gtests
20 matches
Mail list logo
