Author: vedantk Date: Fri Aug 19 13:41:50 2016 New Revision: 279296 URL: http://llvm.org/viewvc/llvm-project?rev=279296&view=rev Log: [lldb][cmake] Remove libclang as an lldbBase dependency (NFCI)
It's pulling in all kinds of things it doesn't need (e.g, clang-tidy!). Eliminating this dependency removes 1056 dependencies from the 'CommandObjectFrame.cpp.o' target and 454 dependencies from the 'lldb' target. On my machine, this shaves 7 minutes off of a clean build of lldb. Thanks to Zachary Turner for pointing out some issues with an earlier version of this patch! Differential Revision: https://reviews.llvm.org/D22987 Modified: lldb/trunk/CMakeLists.txt lldb/trunk/cmake/modules/AddLLDB.cmake Modified: lldb/trunk/CMakeLists.txt URL: http://llvm.org/viewvc/llvm-project/lldb/trunk/CMakeLists.txt?rev=279296&r1=279295&r2=279296&view=diff ============================================================================== --- lldb/trunk/CMakeLists.txt (original) +++ lldb/trunk/CMakeLists.txt Fri Aug 19 13:41:50 2016 @@ -1,5 +1,6 @@ cmake_minimum_required(VERSION 3.4.3) +include(cmake/LLDBDependencies.cmake) include(cmake/modules/LLDBStandalone.cmake) include(cmake/modules/LLDBConfig.cmake) include(cmake/modules/AddLLDB.cmake) Modified: lldb/trunk/cmake/modules/AddLLDB.cmake URL: http://llvm.org/viewvc/llvm-project/lldb/trunk/cmake/modules/AddLLDB.cmake?rev=279296&r1=279295&r2=279296&view=diff ============================================================================== --- lldb/trunk/cmake/modules/AddLLDB.cmake (original) +++ lldb/trunk/cmake/modules/AddLLDB.cmake Fri Aug 19 13:41:50 2016 @@ -84,10 +84,7 @@ macro(add_lldb_library name) endif() endif() - # Hack: only some LLDB libraries depend on the clang autogenerated headers, - # but it is simple enough to make all of LLDB depend on some of those - # headers without negatively impacting much of anything. - add_dependencies(${name} libclang) + add_dependencies(${name} ${CLANG_USED_LIBS}) set_target_properties(${name} PROPERTIES FOLDER "lldb libraries") endmacro(add_lldb_library) _______________________________________________ lldb-commits mailing list lldb-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
