Author: spyffe
Date: Fri Mar 18 19:51:43 2016
New Revision: 263864
URL: http://llvm.org/viewvc/llvm-project?rev=263864&view=rev
Log:
Handle any persistent Decl in the Clang expression parser, not just types.
Persistent decls have traditionally only been types. However, we want to
be able to pers
> On Mar 18, 2016, at 2:45 PM, Zachary Turner wrote:
>
> Hi Enrico,
>
> These tests are failing on Windows. They're new tests so not really a
> regression, but do you have any idea what might be wrong? Basically, when
> the test runs, the help po is displaying the full output of "help
> ex
zturner added inline comments.
Comment at: tools/lldb-mi/Platform.h:73
@@ -74,4 +72,3 @@
// CODETAG_IOR_SIGNALS
// signal.h
#define SIGQUIT 3 // Terminal quit signal
amccarth wrote:
> As in the other file, now that we're including , I think the
amccarth accepted this revision.
amccarth added a comment.
This revision is now accepted and ready to land.
looks good
http://reviews.llvm.org/D18287
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/lis
fjricci added a comment.
That makes sense. Will do.
http://reviews.llvm.org/D18228
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
Author: gclayton
Date: Fri Mar 18 15:53:35 2016
New Revision: 263830
URL: http://llvm.org/viewvc/llvm-project?rev=263830&view=rev
Log:
Added a break statement that was needed. Caught by clang's unannotated case
fall through warning.
Modified:
lldb/trunk/tools/lldb-mi/MICmnLLDBDebuggerHandleE
cameron314 added a comment.
No worries. I removed the codepage stuff when I did the last rebase. Another
one coming up shortly!
http://reviews.llvm.org/D17107
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/m
omjavaid added a reviewer: clayborg.
omjavaid added a comment.
I dont have a lot of background in this area of the code. Can you kindly take a
look.
http://reviews.llvm.org/D18059
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lis
Author: jingham
Date: Fri Mar 18 19:53:20 2016
New Revision: 263865
URL: http://llvm.org/viewvc/llvm-project?rev=263865&view=rev
Log:
Use Enrico's new CommandAlias to give better help to the "sif" command.
Modified:
lldb/trunk/source/Interpreter/CommandInterpreter.cpp
Modified: lldb/trunk/so
zturner updated this revision to Diff 51090.
zturner added a comment.
Update with context
http://reviews.llvm.org/D18287
Files:
tools/driver/Driver.cpp
tools/driver/Platform.cpp
tools/driver/Platform.h
tools/lldb-mi/CMakeLists.txt
tools/lldb-mi/Platform.cpp
tools/lldb-mi/Platform.h
Author: jingham
Date: Fri Mar 18 19:21:21 2016
New Revision: 263861
URL: http://llvm.org/viewvc/llvm-project?rev=263861&view=rev
Log:
Fix the project file for the removal of lldb-mi's Platform.cpp.
Modified:
lldb/trunk/lldb.xcodeproj/project.pbxproj
Modified: lldb/trunk/lldb.xcodeproj/projec
cameron314 added a comment.
Cool! I got pulled into something else at work and didn't have time to
investigate the linker error that this led to, sorry. But the patch looks good
to me (not that I know LLDB very well).
Comment at: tools/driver/Driver.cpp:1314
@@ -1313,1 +1313,3
zturner added inline comments.
Comment at: tools/driver/Driver.cpp:1314
@@ -1313,1 +1313,3 @@
+signal(SIGINT, sigint_handler);
+#ifndef _MSC_VER
signal (SIGPIPE, SIG_IGN);
I think `_MSC_VER` is the right check, because the builtin `signal`
implementation
amccarth added a comment.
I like where this is going. Just a couple concerns.
Comment at: tools/driver/Platform.h:15
@@ -14,4 +14,3 @@
// this will stop signal.h being included
#include "lldb/Host/HostGetOpt.h"
delete this comment
cameron314 added a comment.
@zturner: Let me know when you're ready for this patch and I'll rebase it
again, since there's been quite a few more commits.
http://reviews.llvm.org/D17107
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http:
clayborg requested changes to this revision.
clayborg added a comment.
This revision now requires changes to proceed.
Looks great, thanks for catching and fixing this. Can we add a test for this so
we don't regress?
http://reviews.llvm.org/D18228
_
Author: gclayton
Date: Fri Mar 18 15:33:49 2016
New Revision: 263824
URL: http://llvm.org/viewvc/llvm-project?rev=263824&view=rev
Log:
Fixed a bug where DW_AT_start_scope would fall through to DW_AT_artificial in
SymbolFileDWARF::ParseVariableDIE(). This was caught by the clang warning that
catc
zturner added a comment.
The reason I mentioned `UNICODE` is because it's one of the main differences
between pre-patch and post-patch. It works for me pre-patch. What command
line are you passing to CMake? Are you using MSVC 2015 Update 1 or initial
release?
The other difference is that I'
cameron314 added a comment.
Aha, I get the same error now:
fatal error LNK1169: one or more multiply defined symbols found
I'm looking into it!
http://reviews.llvm.org/D17107
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists
cameron314 updated this revision to Diff 50976.
cameron314 added a comment.
Here we go! Rebased to tip (http://reviews.llvm.org/rL263735).
http://reviews.llvm.org/D17107
Files:
lldb/trunk/cmake/modules/LLDBConfig.cmake
lldb/trunk/include/lldb/Host/FileSystem.h
lldb/trunk/include/lldb/Host
clayborg requested changes to this revision.
This revision now requires changes to proceed.
Comment at: source/Host/common/File.cpp:48
@@ -47,3 +47,3 @@
}
-else if (options & File::eOpenOptionWrite)
+else
{
This change isn't neede
zturner created this revision.
zturner added reviewers: amccarth, cameron314.
zturner added a subscriber: lldb-commits.
Windows comes with an extremely limited implementation of `signal` which only
supports a few signal values. Of importance to LLDB is the `SIGINT` value
which invokes a callbac
22 matches
Mail list logo
