cameron314 added a comment.
Cool! I got pulled into something else at work and didn't have time to
investigate the linker error that this led to, sorry. But the patch looks good
to me (not that I know LLDB very well).
================
Comment at: tools/driver/Driver.cpp:1314
@@ -1313,1 +1313,3 @@
+ signal(SIGINT, sigint_handler);
+#ifndef _MSC_VER
signal (SIGPIPE, SIG_IGN);
----------------
Might be slightly more portable to use `_WIN32` to detect the OS platform
instead of detecting the compiler?
================
Comment at: tools/driver/Platform.cpp:93-97
@@ -92,7 @@
- {
- case ( SIGINT ):
- {
- _ctrlHandler = sigFunc;
- SetConsoleCtrlHandler( CtrlHandler, TRUE );
- }
- break;
----------------
It looks like MIDriverMain.cpp was using this. Will it continue to work without
the console control handler?
================
Comment at: tools/driver/Platform.h:15
@@ -14,4 +14,3 @@
// this will stop signal.h being included
#include "lldb/Host/HostGetOpt.h"
----------------
This comment is no longer relevant.
http://reviews.llvm.org/D18287
_______________________________________________
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
