labath added a comment.
A bit late to the party, but anyway... I would change the detection logic here:
Instead of `ALLOW_STATIC_BINDINGS`, have `USE_STATIC_BINDINGS`. If it's set,
don't even bother checking for swig's presence and use the static bindings. If
it's not set, then detect swig, and
Author: slthakur
Date: Thu Nov 19 05:01:21 2015
New Revision: 253555
URL: http://llvm.org/viewvc/llvm-project?rev=253555&view=rev
Log:
[LLDB][MIPS] Fix lldbplatformutil.py Failure
Patch by Nitesh Jain
Summary: This patch check whether first register is readable.
Subscribers: lldb-commits, mohit
sagar closed this revision.
sagar added a comment.
Committed in r253555 on behalf of @nitesh.jain
Repository:
rL LLVM
http://reviews.llvm.org/D14635
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/l
tberghammer created this revision.
tberghammer added reviewers: labath, ovyalov.
tberghammer added a subscriber: lldb-commits.
Herald added subscribers: srhines, danalbert, tberghammer, rengolin, aemerson.
Use thumb instruction set for ldb-server on android arm
This change reduce the size of the
labath accepted this revision.
labath added a comment.
This revision is now accepted and ready to land.
lgtm
http://reviews.llvm.org/D14816
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb
Moot point now, but thanks.
The reason for the flag name is that the prepare_bindings.py script as it
stands will always generate the bindings with swig if a swig is either
specified or allowed to be found in some common places. So the
"USE_STATIC_BINDINGS" would be misleading --- they wouldn't n
tfiala added a subscriber: tfiala.
tfiala added a comment.
Moot point now, but thanks.
The reason for the flag name is that the prepare_bindings.py script as it
stands will always generate the bindings with swig if a swig is either
specified or allowed to be found in some common places. So the
"
ovyalov accepted this revision.
ovyalov added a comment.
LGTM
http://reviews.llvm.org/D14816
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
omjavaid created this revision.
omjavaid added reviewers: tberghammer, clayborg.
omjavaid added a subscriber: lldb-commits.
Herald added subscribers: rengolin, aemerson.
This patch disables forcing -marm (A32 instruction set) while running lldb
testsuite on arm targets.
gcc uses -marm and -mthum
Author: tfiala
Date: Thu Nov 19 10:56:12 2015
New Revision: 253575
URL: http://llvm.org/viewvc/llvm-project?rev=253575&view=rev
Log:
Revert "prepare_bindings.py: enable static bindings"
This reverts commit 40f789f2dc6bb80fd25a33f91e452d081ed9d0ee.
Removed:
lldb/trunk/scripts/Python/static-bi
omjavaid added a subscriber: omjavaid.
omjavaid added a comment.
-mthumb will force T32 instruction set while -marm will force A32.
Best is not to use any of these flags to let the compiler decide best
possible instruction set combination.
http://reviews.llvm.org/D14816
_
-mthumb will force T32 instruction set while -marm will force A32.
Best is not to use any of these flags to let the compiler decide best
possible instruction set combination.
On 19 November 2015 at 20:38, Oleksiy Vyalov via lldb-commits
wrote:
> ovyalov accepted this revision.
> ovyalov added a
tberghammer added a comment.
In http://reviews.llvm.org/D14816#292929, @omjavaid wrote:
> -mthumb will force T32 instruction set while -marm will force A32.
>
> Best is not to use any of these flags to let the compiler decide best
> possible instruction set combination.
I think because we spec
tberghammer added a comment.
Can we create a setup where the test suit is capable of running in all 3 mode
(arm/thumb/mixed)?
I think we should introduce a new architecture called "arm-thumb" (open for
better name suggestions) what run the test suit in mixed mode while running the
test suit wi
clayborg added a comment.
This patch was accepted on November 13th. So yes this is ready to land. Not
sure what you are waiting for?
Repository:
rL LLVM
http://reviews.llvm.org/D14530
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
htt
clayborg added a comment.
Yes, I agree Zach, the caller of SaveCore should verify the process is in a
good state first. The only downside of that is if the windows mini-dumper can
actually make a core file on a running process, we might want to allow this and
make actual SaveCore implementation
zturner added a comment.
In http://reviews.llvm.org/D14793#293007, @clayborg wrote:
> Yes, I agree Zach, the caller of SaveCore should verify the process is in a
> good state first. The only downside of that is if the windows mini-dumper can
> actually make a core file on a running process, we
clayborg resigned from this revision.
clayborg edited reviewers, added: jingham, spyffe; removed: clayborg.
clayborg added a comment.
Resigning as I will let Jim Ingham and Sean Callanan review.
http://reviews.llvm.org/D13350
___
lldb-commits mailin
clayborg added a comment.
OK, then callers of SaveCore should make sure the process is in a good state
before calling the API.
http://reviews.llvm.org/D14793
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/ma
Author: zturner
Date: Thu Nov 19 13:10:54 2015
New Revision: 253589
URL: http://llvm.org/viewvc/llvm-project?rev=253589&view=rev
Log:
Pass -fms-compatibility-version when building test inferiors.
-fms-compatibility-version defaults to VS 2013. When using
VS 2015, this will lead to compilation fa
krytarowski added a comment.
In http://reviews.llvm.org/D14530#293000, @clayborg wrote:
> This patch was accepted on November 13th. So yes this is ready to land. Not
> sure what you are waiting for?
Thank you for your reply. I cannot land them myself as I'm not a committer.
My latest patches
Author: enrico
Date: Thu Nov 19 15:17:56 2015
New Revision: 253599
URL: http://llvm.org/viewvc/llvm-project?rev=253599&view=rev
Log:
Fix an issue where LLDB would not launch argdumper correctly if there were
spaces in the path to it
Modified:
lldb/trunk/source/Host/macosx/Host.mm
lldb/tr
Author: emaste
Date: Thu Nov 19 15:30:22 2015
New Revision: 253601
URL: http://llvm.org/viewvc/llvm-project?rev=253601&view=rev
Log:
Plug-in PlatformNetBSD initializer and terminator
Patch by Kamil Rytarowski
Differential Revision: http://reviews.llvm.org/D14530
Modified:
lldb/trunk/source
This revision was automatically updated to reflect the committed changes.
Closed by commit rL253601: Plug-in PlatformNetBSD initializer and terminator
(authored by emaste).
Changed prior to commit:
http://reviews.llvm.org/D14530?vs=39788&id=40700#toc
Repository:
rL LLVM
http://reviews.llvm.
Author: enrico
Date: Thu Nov 19 15:45:07 2015
New Revision: 253604
URL: http://llvm.org/viewvc/llvm-project?rev=253604&view=rev
Log:
Cleanup work required to get the ASAN tests to run in the new test suite
infrastructure; the tests are now xfailed on Darwin pending investigation
Modified:
ll
Author: enrico
Date: Thu Nov 19 16:28:58 2015
New Revision: 253613
URL: http://llvm.org/viewvc/llvm-project?rev=253613&view=rev
Log:
Fix up LLDB for a change in the way clang represents anonymous unions such that
the 'frame variable' command can still find the members of such union as if
they we
sivachandra created this revision.
sivachandra added reviewers: emaste, krytarowski.
sivachandra added a subscriber: lldb-commits.
This reverts commit 2354cd73101e58540b8b39783df462d06023309f as it
introduced a bunch regressions on the linux bot.
http://reviews.llvm.org/D14844
Files:
source/In
Author: sivachandra
Date: Thu Nov 19 16:58:48 2015
New Revision: 253615
URL: http://llvm.org/viewvc/llvm-project?rev=253615&view=rev
Log:
Revert "Plug-in PlatformNetBSD initializer and terminator"
Summary:
This reverts commit 2354cd73101e58540b8b39783df462d06023309f as it
introduced a bunch regre
Author: gclayton
Date: Thu Nov 19 17:04:09 2015
New Revision: 253616
URL: http://llvm.org/viewvc/llvm-project?rev=253616&view=rev
Log:
Fixed Xcode build by adding the PlatformNetBSD code.
Modified:
lldb/trunk/lldb.xcodeproj/project.pbxproj
Modified: lldb/trunk/lldb.xcodeproj/project.pbxproj
Author: gclayton
Date: Thu Nov 19 17:10:45 2015
New Revision: 253618
URL: http://llvm.org/viewvc/llvm-project?rev=253618&view=rev
Log:
Fix a crasher in SymbolContext::SortTypeList() where something that was
iterating over a std::multimap was actually mutating the list.
Modified:
lldb/trun
This revision was automatically updated to reflect the committed changes.
Closed by commit rL253615: Revert "Plug-in PlatformNetBSD initializer and
terminator" (authored by sivachandra).
Changed prior to commit:
http://reviews.llvm.org/D14844?vs=40708&id=40710#toc
Repository:
rL LLVM
http:/
Author: amccarth
Date: Thu Nov 19 18:11:38 2015
New Revision: 253623
URL: http://llvm.org/viewvc/llvm-project?rev=253623&view=rev
Log:
Make skipIf support the not_in function.
Modified:
lldb/trunk/packages/Python/lldbsuite/test/lldbtest.py
Modified: lldb/trunk/packages/Python/lldbsuite/test/
amccarth marked 5 inline comments as done.
Comment at: include/lldb/API/SBProcess.h:344-346
@@ -343,1 +343,5 @@
+// Save the state of the process in a core file (or mini dump on Windows).
+lldb::SBError
+SaveCore(const char *file_name);
+
clayborg wr
amccarth updated this revision to Diff 40716.
amccarth marked an inline comment as done.
amccarth added a comment.
Addresses some of the comments.
http://reviews.llvm.org/D14793
Files:
include/lldb/API/SBProcess.h
include/lldb/API/SBTarget.h
packages/Python/lldbsuite/test/functionalities/
clayborg requested changes to this revision.
clayborg added a comment.
This revision now requires changes to proceed.
Fix the caps on the error message, remove the new files and inline the code and
this will be ready.
Comment at: source/API/SBProcess.cpp:1445
@@ +1444,3 @@
+
amccarth marked an inline comment as done.
Comment at: source/Plugins/ObjectFile/PECOFF/ObjectFilePECOFF.cpp:159
@@ +158,3 @@
+{
+return SaveMiniDump(process_sp, outfile, error);
+}
clayborg wrote:
> I would rather just have the code from SaveMiniDump inlined
clayborg added a comment.
Ok, so fix the caps and rename the file to be WindowsMiniDump.cpp/.h. I would
rather it not have the "ObjectFilePECOFF" prefix because it would indicated
that it is a new subclass of ObjectFile.
http://reviews.llvm.org/D14793
___
This make the test TestVectorTypesFormatting, which is annotated with
@skipIf(compiler='gcc'), run when using GCC:
http://lab.llvm.org:8011/builders/lldb-x86_64-ubuntu-14.04-cmake/builds/8661/steps/test5/logs/stdio
On Thu, Nov 19, 2015 at 4:11 PM, Adrian McCarthy via lldb-commits
wrote:
> Author:
krytarowski added a comment.
Sorry for problems, I will investigate it.
Repository:
rL LLVM
http://reviews.llvm.org/D14844
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
sivachandra added a comment.
Actually, I do not have time today to do a better job with digging and have to
resort to reverting.
Repository:
rL LLVM
http://reviews.llvm.org/D14844
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://
sivachandra created this revision.
sivachandra added a reviewer: amccarth.
sivachandra added a subscriber: lldb-commits.
This reverts commit 251965377bdfb6227eea42c12a792c059e4e8a4b
as a test marked "skipIf(compiler='gcc')" runs when testing with GCC.
http://reviews.llvm.org/D14852
Files:
pack
This revision was automatically updated to reflect the committed changes.
Closed by commit rL253631: Revert "Make skipIf support the not_in function."
(authored by sivachandra).
Changed prior to commit:
http://reviews.llvm.org/D14852?vs=40728&id=40729#toc
Repository:
rL LLVM
http://reviews.
krytarowski added a comment.
Could you please reference a hyperlink to the breakage? Have we got some
mailing list to monitor it? Jumping over logs in waterfall isn't much
convenient.
Repository:
rL LLVM
http://reviews.llvm.org/D14844
___
lldb-
Author: sivachandra
Date: Thu Nov 19 19:54:24 2015
New Revision: 253631
URL: http://llvm.org/viewvc/llvm-project?rev=253631&view=rev
Log:
Revert "Make skipIf support the not_in function."
Summary:
This reverts commit 251965377bdfb6227eea42c12a792c059e4e8a4b
as a test marked "skipIf(compiler='gcc'
Adrian:
I think the check_list_or_lambda function needs to be renamed to
`check_decorator_attribute`, and it needs to handle values that are neither
lists nor functions. i.e. it needs to handle single values. So I believe
right now check_list_or_lambda does something like this:
def check_list_o
Agreed, when a CL is reverted due to a buildbot breakage, please include a
link to the failing bot in the commit message of the revert.
On Thu, Nov 19, 2015 at 5:57 PM Kamil Rytarowski via lldb-commits <
lldb-commits@lists.llvm.org> wrote:
> krytarowski added a comment.
>
> Could you please refer
mohit.bhakkad created this revision.
mohit.bhakkad added reviewers: bhushan, jaydeep.
mohit.bhakkad added subscribers: lldb-commits, sagar, nitesh.jain.
mohit.bhakkad set the repository for this revision to rL LLVM.
Index for H/W watchpoint regsisters starts from 0, so considering 0 as failure
is
47 matches
Mail list logo
