emaste added inline comments.
Comment at: source/Plugins/Platform/NetBSD/PlatformNetBSD.cpp:1
@@ +1,2 @@
+//===-- PlatformNetBSD.cpp -*- C++ -*-===//
+//
krytarowski wrote:
> labath wrote:
> > krytarowski wrote:
> > > labath wro
On 1 October 2015 at 23:09, Kamil Rytarowski via lldb-commits
wrote:
>
> Yes, please! Better incomplete support in the source trees then once
> almost complete but rotting in a local patch...
I agree - I think it's better to get basic support in as soon as
possible and we can refactor as appropri
-BEGIN PGP SIGNED MESSAGE-
Hash: SHA256
On 02.10.2015 10:07, Ed Maste wrote:
> On 1 October 2015 at 23:09, Kamil Rytarowski via lldb-commits
> wrote:
>>
>> Yes, please! Better incomplete support in the source trees then
>> once almost complete but rotting in a local patch...
>
> I agre
tberghammer created this revision.
tberghammer added a reviewer: labath.
tberghammer added a subscriber: lldb-commits.
Herald added subscribers: rengolin, aemerson.
Fix several issues around .ARM.exidx section handling
* Use .ARM.exidx as a fallback unwind plan for non-call site when the
instru
labath accepted this revision.
labath added a comment.
This revision is now accepted and ready to land.
looks good
http://reviews.llvm.org/D13380
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinf
evgeny777 added inline comments.
Comment at: tools/lldb-mi/MICmnLLDBUtilSBValue.cpp:372
@@ +371,3 @@
+CMIUtilString
+CMICmnLLDBUtilSBValue::GetValueSummary() const
+{
granata.enrico wrote:
> I might be missing something, but how is this going to work when an SBVal
evgeny777 added inline comments.
Comment at: include/lldb/API/SBTypeSummary.h:125
@@ +124,3 @@
+
+bool DoesPrintValue(const lldb::SBValue &value) const;
+
granata.enrico wrote:
> Can you please change this to
>
> bool
> DoesPrintValue (lldb::SBValue value
evgeny777 updated this revision to Diff 36341.
evgeny777 added a comment.
Changed DoesPrintValue() function prototype
http://reviews.llvm.org/D13058
Files:
include/lldb/API/SBTypeSummary.h
source/API/SBTypeSummary.cpp
test/tools/lldb-mi/variable/TestMiGdbSetShowPrint.py
test/tools/lldb-
Author: tberghammer
Date: Fri Oct 2 06:58:26 2015
New Revision: 249119
URL: http://llvm.org/viewvc/llvm-project?rev=249119&view=rev
Log:
Fix several issues around .ARM.exidx section handling
* Use .ARM.exidx as a fallback unwind plan for non-call site when the
instruction emulation based unwin
This revision was automatically updated to reflect the committed changes.
Closed by commit rL249119: Fix several issues around .ARM.exidx section
handling (authored by tberghammer).
Changed prior to commit:
http://reviews.llvm.org/D13380?vs=36338&id=36343#toc
Repository:
rL LLVM
http://revi
Author: tberghammer
Date: Fri Oct 2 07:00:04 2015
New Revision: 249120
URL: http://llvm.org/viewvc/llvm-project?rev=249120&view=rev
Log:
Change expected stop reason in TestInferiorAssert for Android API <= 16
Modified:
lldb/trunk/test/functionalities/inferior-assert/TestInferiorAssert.py
Mo
labath added a comment.
In http://reviews.llvm.org/D13362#258314, @tfiala wrote:
> The OS X one seems to be related to load (not terribly surprising). I'm
> seeing timeouts as I crank up the --threads. But I don't think that's the
> whole story. On the Linux side, I've been cranking down th
tfiala added a comment.
> I think that is a reasonable course of action. Having three threads servicing
> the same process seems wasteful/hard to maintain and has a very big race
> potential.
Yeah I'm not liking how complex this is getting.
I'll have more comments once I address the other i
Hello everyone,
LLVM buildmaster will be restarted after 6 PM Pacific time today.
Sorry for the noise.
Thanks
Galina
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
granata.enrico accepted this revision.
granata.enrico added a comment.
I am not deeply involved in MI internals, so I am going to assume you ran the
test suite, and that you actually verified that types without summaries still
work
In general, once you opt into data formatters, you get a lot mo
Author: spyffe
Date: Fri Oct 2 13:40:30 2015
New Revision: 249167
URL: http://llvm.org/viewvc/llvm-project?rev=249167&view=rev
Log:
Made GetScratchTypeSystemForLanguage return an error if desired.
Also made it not store nullptrs in its TypeSystemMap, so it will retry to make
the AST context if it
dawn added a comment.
> You can use clang-format to follow the LLDB coding style, or just do the
> following:
So we've been telling folks to use clang-format, but it's not working correctly
(my version is clang-format version 3.6.0 (217927)). It's turns:
bool
DoesPrintValue (lldb::SBValu
dawn added a comment.
This patch is good to commit now right? It's not marked "accepted" for some
reason.
http://reviews.llvm.org/D13058
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-
granata.enrico added a comment.
I Thought I had marked it as good to go.
My bad if I have not.
- Enrico
http://reviews.llvm.org/D13058
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-com
I Thought I had marked it as good to go.
My bad if I have not.
- Enrico
Sent from my iPhone
> On Oct 2, 2015, at 1:12 PM, Dawn Perchik wrote:
>
> dawn added a comment.
>
> This patch is good to commit now right? It's not marked "accepted" for some
> reason.
>
>
> http://reviews.llvm.org/D
evgeny777 added a comment.
Thanks for a good point.
MI formatting refactoring will likely come soon as a separate review
http://reviews.llvm.org/D13058
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/l
ki.stfu added a comment.
In http://reviews.llvm.org/D13058#258903, @dawn wrote:
> This patch is good to commit now right? It's not marked "accepted" for some
> reason.
It's not "accepted" because @clayborg rejected this CL and hasn't changed his
decision. But I think he doesn't mind if you w
Author: tfiala
Date: Fri Oct 2 15:51:11 2015
New Revision: 249182
URL: http://llvm.org/viewvc/llvm-project?rev=249182&view=rev
Log:
Fix race on subprocess.Popen return values.
This fixes:
https://llvm.org/bugs/show_bug.cgi?id=25019
Modified:
lldb/trunk/test/test_runner/lib/process_control.p
Author: enrico
Date: Fri Oct 2 15:59:58 2015
New Revision: 249185
URL: http://llvm.org/viewvc/llvm-project?rev=249185&view=rev
Log:
Add hooks that enable NSSet, NSDictionary and NSString formatting to apply to
other types beyond the well-known ones
This is meant to support languages that can do
Author: enrico
Date: Fri Oct 2 16:14:38 2015
New Revision: 249189
URL: http://llvm.org/viewvc/llvm-project?rev=249189&view=rev
Log:
Fix the CMake build
Modified:
lldb/trunk/source/Plugins/Language/ObjC/CMakeLists.txt
Modified: lldb/trunk/source/Plugins/Language/ObjC/CMakeLists.txt
URL:
htt
tfiala abandoned this revision.
tfiala added a comment.
I've fixed:
https://llvm.org/bugs/show_bug.cgi?id=25019
I think for now I am not interested in trying to tackle the intent of this
change as it unduly complicates the timeout detection logic.
I am okay with saying:
"If you run a process ht
zturner added a comment.
Hi Vadim, when I run CMake with this change I get the following output:
[1/1] Re-running CMake...
- Warning: Did not find file Compiler/MSVC-ASM
- Target triple: i686-pc-win32
- Native target architecture is X86
- Threads enabled.
- Doxygen disabled.
- Sphinx disabled.
-
Hi Tamas,
This breaks TestBuiltinTrap on Windows. Do you have any insight about why
this might be happening? That test is not modified at all by this patch
from what I can tell, but a bisect pinpoints this CL as the reason for the
failure.
On Thu, Oct 1, 2015 at 1:05 AM Ed Maste wrote:
> emas
zturner added a comment.
Hi Tamas,
This breaks TestBuiltinTrap on Windows. Do you have any insight about why
this might be happening? That test is not modified at all by this patch
from what I can tell, but a bisect pinpoints this CL as the reason for the
failure.
Repository:
rL LLVM
http:
zturner added a comment.
Actually nevermind, the changed file list was cut off by the email, so I didn't
see that it had been modified. It looks like you just didn't copy over the
`@skipIfWindows` decorator. I can fix that easily, sorry for the noise.
Repository:
rL LLVM
http://reviews.ll
Author: ovyalov
Date: Fri Oct 2 17:37:55 2015
New Revision: 249203
URL: http://llvm.org/viewvc/llvm-project?rev=249203&view=rev
Log:
Fix TestCompDirSymLink.py - remove existing symlink leftovers if previous test
run
was terminated (e.g., due timeout).
Modified:
lldb/trunk/test/functionalit
Author: zturner
Date: Fri Oct 2 17:47:14 2015
New Revision: 249207
URL: http://llvm.org/viewvc/llvm-project?rev=249207&view=rev
Log:
Remove instance reference of static member function.
Modified:
lldb/trunk/source/Plugins/SymbolFile/DWARF/DWARFASTParserClang.cpp
Modified: lldb/trunk/source/
Author: zturner
Date: Fri Oct 2 17:47:37 2015
New Revision: 249209
URL: http://llvm.org/viewvc/llvm-project?rev=249209&view=rev
Log:
Re-disable TestBuiltinTrap on Windows.
This was inadvertently re-enabled as a in r248883.
Modified:
lldb/trunk/test/linux/builtin_trap/TestBuiltinTrap.py
Mod
Author: zturner
Date: Fri Oct 2 17:47:28 2015
New Revision: 249208
URL: http://llvm.org/viewvc/llvm-project?rev=249208&view=rev
Log:
Updated xfail / skip status on a few tests.
TestDiamond and TestSBValueCast were due to a bug in clang. That
bug has been fixed, so xfail is removed. However fix
Author: zturner
Date: Fri Oct 2 17:47:04 2015
New Revision: 249206
URL: http://llvm.org/viewvc/llvm-project?rev=249206&view=rev
Log:
Have a clean(er) shutdown when detaching from a process.
Modified:
lldb/trunk/source/Plugins/Process/Windows/Live/DebuggerThread.cpp
Modified: lldb/trunk/sour
Author: enrico
Date: Fri Oct 2 17:53:32 2015
New Revision: 249210
URL: http://llvm.org/viewvc/llvm-project?rev=249210&view=rev
Log:
Do not attempt to join the remote paths if none exist
Modified:
lldb/trunk/test/lldbtest.py
Modified: lldb/trunk/test/lldbtest.py
URL:
http://llvm.org/viewvc/
zturner created this revision.
zturner added a reviewer: enlight.
zturner added a subscriber: lldb-commits.
Hi Vadim,
Would you mind taking a look at this? My CMake-fu is only level 5, so if you
have any suggestions on how to improve this, let me know.
Note that I'm claiming with this revision
On Fri, Oct 2, 2015 at 5:54 PM Zachary Turner wrote:
>
> Note that I'm claiming with this revision that LLDB itself works with
> Python versions other than 2.7.
s/claiming/*not* claiming/
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http:
enlight added a comment.
That looks fine to me. CMake prints those messages during the configuration
step, at that point the generator expressions haven't been expanded yet. I
could prettify those messages a bit to read: `Found PythonLibs:
C:/Python27_LLDB/x86/libs/python27_d.lib and
C:/Python
Yea that's what I meant. Everything works, but the configuration step is
supposed to print out stuff that people can read at a glance. So
prettifying it would be desirable.
On Fri, Oct 2, 2015 at 10:39 PM Vadim Macagon
wrote:
> enlight added a comment.
>
> That looks fine to me. CMake prints t
40 matches
Mail list logo
