[GitHub] [lucene] javanna commented on a diff in pull request #12019: Clean up vector backward-codecs

javanna commented on code in PR #12019: URL: https://github.com/apache/lucene/pull/12019#discussion_r1052136107 ## lucene/backward-codecs/src/test/org/apache/lucene/backward_codecs/lucene94/Lucene94RWCodec.java: ## @@ -0,0 +1,46 @@ +/* + * Licensed to the Apache Software Foundat

[GitHub] [lucene] benwtrent commented on a diff in pull request #12019: Clean up vector backward-codecs

benwtrent commented on code in PR #12019: URL: https://github.com/apache/lucene/pull/12019#discussion_r1052196141 ## lucene/backward-codecs/src/test/org/apache/lucene/backward_codecs/lucene94/Lucene94RWCodec.java: ## @@ -0,0 +1,46 @@ +/* + * Licensed to the Apache Software Found

[GitHub] [lucene] vsop-479 commented on pull request #11888: [Fix] Binary search the entries when all suffixes have the same length in a leaf block.

vsop-479 commented on PR #11888: URL: https://github.com/apache/lucene/pull/11888#issuecomment-1357671269 @jpountz Is there any progress on this PR? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go t

[GitHub] [lucene] rmuir commented on pull request #11946: add similarity threshold for hnsw

rmuir commented on PR #11946: URL: https://github.com/apache/lucene/pull/11946#issuecomment-1357737816 > * I agree that this kind of thing is valuable in KNN. KNN is unique when compared to sparse retrieval as you always retrieve K results (unless using a restrictive filter). In some cases,

[GitHub] [lucene] rmuir commented on a diff in pull request #12019: Clean up vector backward-codecs

rmuir commented on code in PR #12019: URL: https://github.com/apache/lucene/pull/12019#discussion_r1052301297 ## lucene/backward-codecs/src/test/org/apache/lucene/backward_codecs/lucene94/Lucene94RWCodec.java: ## @@ -0,0 +1,46 @@ +/* + * Licensed to the Apache Software Foundatio

[GitHub] [lucene] epotyom closed pull request #12025: Issue #11582 Update Faceting user guide

epotyom closed pull request #12025: Issue #11582 Update Faceting user guide URL: https://github.com/apache/lucene/pull/12025 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To

[GitHub] [lucene] epotyom commented on pull request #12025: Issue #11582 Update Faceting user guide

epotyom commented on PR #12025: URL: https://github.com/apache/lucene/pull/12025#issuecomment-1357980091 > -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsub

[GitHub] [lucene] epotyom commented on pull request #12025: Issue #11582 Update Faceting user guide

epotyom commented on PR #12025: URL: https://github.com/apache/lucene/pull/12025#issuecomment-1358036804 > From maintenance perspective, I think it would be better to bump the minimum java requirement (e.g. to 19) than to only process the `@snippet` on certain newer JDKs, and produce differ

[GitHub] [lucene] rmuir commented on pull request #12025: Issue #11582 Update Faceting user guide

rmuir commented on PR #12025: URL: https://github.com/apache/lucene/pull/12025#issuecomment-1358049032 I'm not familiar enough with the new snippet support to know. I've only glanced at the JEP. It seemed interesting to me for these cases, but at the same time I don't understand the