epotyom commented on PR #12025: URL: https://github.com/apache/lucene/pull/12025#issuecomment-1358036804
> From maintenance perspective, I think it would be better to bump the minimum java requirement (e.g. to 19) than to only process the `@snippet` on certain newer JDKs, and produce different-looking docs on 17/18. > > A big problem is that github actions etc are using java 17 (the minimum version), so nothing would really be testing the snippets across code changes and they could get broken easily. Thank you for the reply! Do you think it worth changing the minimum requirement just for this change? I can also look into implementing some basic `@snippet` support in java 17 as a [javadoc Taglet](https://docs.oracle.com/javase/8/docs/technotes/guides/javadoc/taglet/overview.html) and we can use it until there are more reasons to change the requirements, what do you think? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org
