thecoop commented on PR #11847:
URL: https://github.com/apache/lucene/pull/11847#issuecomment-1279930290
I am currently reviewing the impact of these changes on performance, GC, and
memory usage to lucene & elasticsearch. If this does show an improvement, I'll
set this PR to ready to review
uschindler commented on PR #11840:
URL: https://github.com/apache/lucene/pull/11840#issuecomment-1279954265
Hi @zhaih,
the problem you describe is exactly why VirtualMethod is there. It allows to
figure out which of both methods was overridden by a subclass at runtime.
I can look into
uschindler commented on PR #11840:
URL: https://github.com/apache/lucene/pull/11840#issuecomment-1279955134
> It seems to me it is a tool detecting whether there's difference in
implementation, but still we are not able to avoid losing IndexSearcher once
we've called a delegated method?
uschindler commented on code in PR #11852:
URL: https://github.com/apache/lucene/pull/11852#discussion_r996473127
##
lucene/luke/src/java/org/apache/lucene/luke/app/web/LukeWebMain.java:
##
@@ -17,31 +17,78 @@
package org.apache.lucene.luke.app.web;
+import java.net.InetSoc