jpountz commented on pull request #692:
URL: https://github.com/apache/lucene/pull/692#issuecomment-1047526553
In my opinion the API as it is today isn't bad. The only thing we might want
to change is to make `DocIdSetBuilder#grow` take a long instead of an int.
Maybe it's a javadocs
jpountz commented on pull request #698:
URL: https://github.com/apache/lucene/pull/698#issuecomment-1047529128
> This is inconsistent with the #grow method where the counter is increased
as it expects grow to be called for documents and no values.
Actually my expectation is that `gro
[
https://issues.apache.org/jira/browse/LUCENE-10424?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17495945#comment-17495945
]
Adrien Grand commented on LUCENE-10424:
---
With the linked pull request, we limit t
iverase commented on pull request #698:
URL: https://github.com/apache/lucene/pull/698#issuecomment-1047575915
> Actually my expectation is that grow() is called with a number of values,
not unique documents.
Then it is wrong that accepts an int and should accept a long? which is wha
Michael Bien created LUCENE-10431:
-
Summary: AssertionError in BooleanQuery.hashCode()
Key: LUCENE-10431
URL: https://issues.apache.org/jira/browse/LUCENE-10431
Project: Lucene - Core
Issue T
mogui commented on a change in pull request #679:
URL: https://github.com/apache/lucene/pull/679#discussion_r811815617
##
File path:
lucene/monitor/src/java/org/apache/lucene/monitor/ReadonlyQueryIndex.java
##
@@ -0,0 +1,100 @@
+/*
+ * Licensed to the Apache Software Foundatio
mogui commented on a change in pull request #679:
URL: https://github.com/apache/lucene/pull/679#discussion_r811817151
##
File path:
lucene/monitor/src/java/org/apache/lucene/monitor/ReadonlyQueryIndex.java
##
@@ -0,0 +1,100 @@
+/*
+ * Licensed to the Apache Software Foundatio
[
https://issues.apache.org/jira/browse/LUCENE-10416?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17496032#comment-17496032
]
ASF subversion and git services commented on LUCENE-10416:
--
Co
[
https://issues.apache.org/jira/browse/LUCENE-10416?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17496034#comment-17496034
]
ASF subversion and git services commented on LUCENE-10416:
--
Co
[
https://issues.apache.org/jira/browse/LUCENE-10416?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Tomoko Uchida updated LUCENE-10416:
---
Fix Version/s: (was: 9.1)
> Update Korean Dictionary for Nori
> ---
[
https://issues.apache.org/jira/browse/LUCENE-10416?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17496038#comment-17496038
]
Tomoko Uchida commented on LUCENE-10416:
I'd revert it from the 9x branch since
mogui commented on a change in pull request #679:
URL: https://github.com/apache/lucene/pull/679#discussion_r811871746
##
File path:
lucene/monitor/src/test/org/apache/lucene/monitor/TestMonitorReadonly.java
##
@@ -0,0 +1,165 @@
+/*
+ * Licensed to the Apache Software Foundati
rmuir commented on pull request #692:
URL: https://github.com/apache/lucene/pull/692#issuecomment-1047729980
> In my opinion the API as it is today isn't bad. The only thing we might
want to change is to make `DocIdSetBuilder#grow` take a long instead of an int.
I've really tried, I
jpountz commented on pull request #692:
URL: https://github.com/apache/lucene/pull/692#issuecomment-1047748712
> Having a grow(long) on something with DocIdSet in its name is beyond bad,
it is terrible.
Would it look better if we gave it a different name that doesn't suggest
that it
rmuir commented on pull request #692:
URL: https://github.com/apache/lucene/pull/692#issuecomment-1047750276
https://user-images.githubusercontent.com/504194/155133007-71ec1d81-a2bd-485d-b7e6-17a10cd78fdf.png";>
I've uploaded a screenshot here of how the only thing using 64-bits is th
rmuir commented on pull request #692:
URL: https://github.com/apache/lucene/pull/692#issuecomment-1047752932
Yeah, there seems to be some disagreement about what the code is actually
doing. Probably because it is too confusing. Recommend (as i did before) to
temporarily remove `counter` an
iverase commented on pull request #692:
URL: https://github.com/apache/lucene/pull/692#issuecomment-1047752116
I don't understand all this discussion. Looking at the cost of a
DocIdSetIterator:
```
/**
* Returns the estimated cost of this {@link DocIdSetIterator}.
*
iverase edited a comment on pull request #692:
URL: https://github.com/apache/lucene/pull/692#issuecomment-1047752116
I don't understand all this discussion. Looking at the cost of a
DocIdSetIterator:
```
/**
* Returns the estimated cost of this {@link DocIdSetIterator}.
iverase commented on pull request #692:
URL: https://github.com/apache/lucene/pull/692#issuecomment-1047786510
If you go a bit higher top in that class:
https://user-images.githubusercontent.com/29038686/155139791-fb87fedb-22a0-44a7-86a6-60b6af84f177.png";>
We are throwing 32 b
rmuir commented on pull request #692:
URL: https://github.com/apache/lucene/pull/692#issuecomment-1047788256
it's fine to do that since only 32 bits are needed.
nothing uses 64-bits here, hence changing the api signature to a `long` is
wrong.
--
This is an automated message from t
rmuir commented on pull request #692:
URL: https://github.com/apache/lucene/pull/692#issuecomment-1047789904
Seriously, let's remove this `counter` and cost estimation. @jpountz tells
me I am wrong, but you can plainly see from the code, this issue is all about
that. Everything else is onl
[
https://issues.apache.org/jira/browse/LUCENE-10424?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17496168#comment-17496168
]
Lu Xugang commented on LUCENE-10424:
??but it actually works with fields that have
[
https://issues.apache.org/jira/browse/LUCENE-10424?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17496168#comment-17496168
]
Lu Xugang edited comment on LUCENE-10424 at 2/22/22, 3:22 PM:
---
mogui commented on a change in pull request #679:
URL: https://github.com/apache/lucene/pull/679#discussion_r811871746
##
File path:
lucene/monitor/src/test/org/apache/lucene/monitor/TestMonitorReadonly.java
##
@@ -0,0 +1,165 @@
+/*
+ * Licensed to the Apache Software Foundati
[
https://issues.apache.org/jira/browse/LUCENE-10412?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Adrien Grand resolved LUCENE-10412.
---
Fix Version/s: 9.1
Resolution: Fixed
> Improve handling of MatchNoDocsQuery in rewri
mogui commented on pull request #679:
URL: https://github.com/apache/lucene/pull/679#issuecomment-1047984458
@romseygeek I should have fixed everything, also added few lines of docs to
explain read-only behaviour.
--
This is an automated message from the Apache Git Service.
To respond to
Andriy Redko created LUCENE-10432:
-
Summary: Add optional 'name' property to
org.apache.lucene.search.Explanation
Key: LUCENE-10432
URL: https://issues.apache.org/jira/browse/LUCENE-10432
Project: Lu
[
https://issues.apache.org/jira/browse/LUCENE-10432?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17496292#comment-17496292
]
Andriy Redko commented on LUCENE-10432:
---
[~jpountz] my apologies for pinging you
andywebb1975 opened a new pull request #2643:
URL: https://github.com/apache/lucene-solr/pull/2643
This is my attempt at resolving
https://issues.apache.org/jira/browse/SOLR-9359 - it's still very
work-in-progress, hence all the debug output etc, but if anyone has thoughts on
it please le
kkewwei created LUCENE-10433:
Summary: we should pass l instead of d to
getFallbackSelector(d).select in RadixSelector.select()
Key: LUCENE-10433
URL: https://issues.apache.org/jira/browse/LUCENE-10433
Pr
[
https://issues.apache.org/jira/browse/LUCENE-10433?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
kkewwei updated LUCENE-10433:
-
Component/s: core/other
> we should pass l instead of d to getFallbackSelector(d).select in
> RadixSel
[
https://issues.apache.org/jira/browse/LUCENE-10433?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
kkewwei resolved LUCENE-10433.
--
Resolution: Resolved
> we should pass l instead of d to getFallbackSelector(d).select in
> RadixSele
jtibshirani opened a new pull request #699:
URL: https://github.com/apache/lucene/pull/699
Before we were using the default Lucene91 codec, so we weren't exercising the
old format.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to
jtibshirani opened a new pull request #700:
URL: https://github.com/apache/lucene/pull/700
The original PR that added kNN filtering support overlooked non-default
codecs.
This follow-up ensures that other codecs work with the new filtering logic:
* Make sure to check the visited nodes
jtibshirani commented on pull request #700:
URL: https://github.com/apache/lucene/pull/700#issuecomment-1048394775
This will fix the nightly test failures. Example repro:
```
./gradlew test --tests TestKnnVectorQuery.testRandomWithFilter
-Dtests.seed=C4BEEB7EDCFB4E6C -Dtests.slow=
Lu Xugang created LUCENE-10434:
--
Summary: Improve handling of DocValuesRangeQuery in rewrite rules
Key: LUCENE-10434
URL: https://issues.apache.org/jira/browse/LUCENE-10434
Project: Lucene - Core
[
https://issues.apache.org/jira/browse/LUCENE-10434?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Lu Xugang resolved LUCENE-10434.
Resolution: Not A Problem
> Improve handling of DocValuesRangeQuery in rewrite rules
> --
[
https://issues.apache.org/jira/browse/LUCENE-10434?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17496460#comment-17496460
]
Lu Xugang commented on LUCENE-10434:
Oh, it seems IndexSearch#rewrite will handle t
LuXugang commented on a change in pull request #677:
URL: https://github.com/apache/lucene/pull/677#discussion_r812597747
##
File path:
lucene/core/src/java/org/apache/lucene/search/DocValuesFieldExistsQuery.java
##
@@ -64,6 +67,24 @@ public void visit(QueryVisitor visitor) {
Lu Xugang created LUCENE-10435:
--
Summary: Break loop early while checking whether
DocValuesFieldExistsQuery can be rewrite to MatchAllDocsQuery
Key: LUCENE-10435
URL: https://issues.apache.org/jira/browse/LUCENE-1043
LuXugang opened a new pull request #701:
URL: https://github.com/apache/lucene/pull/701
In the implementation of Query#rewrite in DocValuesFieldExistsQuery, when
one Segment can't match the condition occurs, maybe we should break loop
directly.
--
This is an automated message fr
41 matches
Mail list logo
