iverase commented on pull request #692:
URL: https://github.com/apache/lucene/pull/692#issuecomment-1047752116


   I don't understand all this discussion. Looking at the cost of a 
DocIdSetIterator:
   
   ```
     /**
      * Returns the estimated cost of this {@link DocIdSetIterator}.
      *
      * <p>This is generally an upper bound of the number of documents this 
iterator might match, but
      * may be a rough heuristic, hardcoded value, or otherwise completely 
inaccurate.
      */
     public abstract long cost();
   ```
   
   Why it is ok a long here?  I think the dance we are doing on the BKD reader 
when wee are visiting more that Integer.MAX_VALUE documents is wrong and should 
be fixed. 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For additional commands, e-mail: issues-h...@lucene.apache.org

Reply via email to