Re: [PATCH][RFC] Make iterating over hash-map elide copying/destructing

On Tue, Jul 10, 2018 at 10:43:20AM +0200, Richard Biener wrote: > > The following makes the hash-map iterator dereference return a pair Value&> rather than a copy of Value. This matches the hash-table iterator > behavior and avoids issues with > > hash_map > Eventually somebodies probably goi

Re: [PATCH][RFC] Make iterating over hash-map elide copying/destructing

On Tue, Jul 10, 2018 at 11:46:54AM +0200, Richard Biener wrote: > On Tue, 10 Jul 2018, Trevor Saunders wrote: > > > On Tue, Jul 10, 2018 at 10:43:20AM +0200, Richard Biener wrote: > > > > > > The following makes the hash-map iterator dereference return a pair >

Re: [PATCH] define auto_vec copy ctor and assignment (PR 90904)

On Wed, Jun 02, 2021 at 10:04:03AM -0600, Martin Sebor via Gcc-patches wrote: > On 6/2/21 12:55 AM, Richard Biener wrote: > > On Tue, Jun 1, 2021 at 9:56 PM Martin Sebor wrote: > > > > > > On 5/27/21 2:53 PM, Jason Merrill wrote: > > > > On 4/27/21 11:52 AM, Martin Sebor via Gcc-patches wrote: >

Re: [PATCH] define auto_vec copy ctor and assignment (PR 90904)

On Mon, Jun 07, 2021 at 10:51:18AM +0200, Richard Biener via Gcc-patches wrote: > On Thu, Jun 3, 2021 at 10:29 AM Trevor Saunders wrote: > > > > On Wed, Jun 02, 2021 at 10:04:03AM -0600, Martin Sebor via Gcc-patches > > wrote: > > > On 6/2/21 12:55 AM, Richard Biene

Re: [PATCH] define auto_vec copy ctor and assignment (PR 90904)

On Mon, Jun 07, 2021 at 04:17:09PM -0600, Martin Sebor wrote: > On 6/3/21 2:29 AM, Trevor Saunders wrote: > > On Wed, Jun 02, 2021 at 10:04:03AM -0600, Martin Sebor via Gcc-patches > > wrote: > > > On 6/2/21 12:55 AM, Richard Biener wrote: > > > > On Tue,

Re: [PATCH] define auto_vec copy ctor and assignment (PR 90904)

On Mon, Jun 07, 2021 at 02:34:26PM -0600, Martin Sebor wrote: > On 6/7/21 2:51 AM, Richard Biener wrote: > > On Thu, Jun 3, 2021 at 10:29 AM Trevor Saunders > > wrote: > > > > > > On Wed, Jun 02, 2021 at 10:04:03AM -0600, Martin Sebor via Gcc-patches > &

[PATCH] Use range based loops to iterate over vec<> in various places

constant_expr): Likewise. * decl.c (wrapup_namespace_globals): Likewise. (cp_finish_decl): Likewise. (cxx_simulate_enum_decl): Likewise. * parser.c (cp_parser_postfix_expression): Likewise. Signed-off-by: Trevor Saunders --- gcc/analyzer/call-string.cc| 18 ++--- gcc/

Re: [PATCH] Use range based loops to iterate over vec<> in various places

On Wed, Jun 09, 2021 at 01:06:44PM +0200, Richard Biener wrote: > On Wed, Jun 9, 2021 at 2:48 AM Trevor Saunders wrote: > > > > Hello, > > > > This makes things a good bit shorter, and reduces complexity by removing > > a bunch of index variables. > > &

[PATCH, pushed] use range based for loops to iterate over vec<>

the index variables should have been deleted as part of the change. Signed-off-by: Trevor Saunders gcc/analyzer/ChangeLog: * call-string.cc (call_string::call_string): Use range based for to iterate over vec<>. (call_string::to_json): Likewise. (call_string

Re: [PATCH 2/4] allow poisoning input_location in ranges it should not be used

On Fri, Jul 02, 2021 at 11:46:46AM -0400, Jason Merrill wrote: > On 7/1/21 6:16 AM, Trevor Saunders wrote: > > On Wed, Jun 30, 2021 at 11:13:23AM -0400, David Malcolm wrote: > > > On Wed, 2021-06-30 at 01:35 -0400, Trevor Saunders wrote: > > > > This makes it possib

Re: [PATCH 2/4] allow poisoning input_location in ranges it should not be used

On Fri, Jul 02, 2021 at 01:20:14PM -0600, Martin Sebor wrote: > On 6/29/21 11:35 PM, Trevor Saunders wrote: > > This makes it possible to assert if input_location is used during the > > lifetime > > of a scope. This will allow us to find places that currently use it withi

[PATCH 1/4] force decls to be allocated through build_decl to initialize them

prior to this commit all calls to build_decl used input_location, even if temporarily until build_decl reset the location to something else that it was told was the proper location. To avoid using the global we need the caller to pass in the location it wants, however that's not possible with mak

[PATCH 2/4] use error_at and warning_at in cfgexpand.c

bootstrapped and regtested on x86_64-linux-gnu, ok? Trev gcc/ChangeLog: * cfgexpand.c (tree_conflicts_with_clobbers_p): Pass location to diagnostics. (expand_asm_stmt): Likewise. --- gcc/cfgexpand.c | 35 ++- 1 file changed, 18 insertions(

[PATCH 3/4] use diagnostic location in diagnostic_report_current_function

It appears that input_location was used here before the diagnostic's location was available, and never updated, when the other part of the header was added that uses it, so this makes it consistent. bootstrapped and regtested on x86_64-linux-gnu, ok? Trev gcc/ChangeLog: * tree-diagnosti

[PATCH 4/4] pass location to md_asm_adjust

So the hook can use it as the location of diagnostics. bootstrapped and regtested on x86_64-linux-gnu, also tested one make all-gcc for each effected cpu, ok? Trev gcc/ChangeLog: * cfgexpand.c (expand_asm_loc): Adjust. (expand_asm_stmt): Likewise. * config/arm/aarch-com

Re: [PATCH 1/4] force decls to be allocated through build_decl to initialize them

On Wed, Jul 14, 2021 at 01:27:54PM +0200, Richard Biener wrote: > On Wed, Jul 14, 2021 at 10:20 AM Trevor Saunders > wrote: > > > > prior to this commit all calls to build_decl used input_location, even if > > temporarily until build_decl reset the location to somethi

[PATCH] add myself to DCO section

fyi, in case I forget to sign off, all my commits this year forwards are under the DCO (as I do not have an assignment). Trev Signed-off-by: Trevor Saunders --- MAINTAINERS | 1 + 1 file changed, 1 insertion(+) diff --git a/MAINTAINERS b/MAINTAINERS index 48cfa3fda1d..7cb63e5f62b 100644 --- a

Re: [PATCH 1/4] force decls to be allocated through build_decl to initialize them

On Thu, Jul 15, 2021 at 10:01:01AM +0200, Richard Biener wrote: > On Thu, Jul 15, 2021 at 4:24 AM Trevor Saunders wrote: > > > > On Wed, Jul 14, 2021 at 01:27:54PM +0200, Richard Biener wrote: > > > On Wed, Jul 14, 2021 at 10:20 AM Trevor Saunders > > > wro

Re: [PATCH] manage dom-walk_data initialization and finalization with constructors and destructors

On Wed, Sep 04, 2013 at 10:32:17AM +0200, Richard Biener wrote: > On Wed, Sep 4, 2013 at 5:16 AM, wrote: > > From: Trevor Saunders > > > > bootstrapped on x86_64-unknown-linux-gnu with same test results as > > unpatched r202185 ok? > > That looks like a not

Re: [PATCH] manage dom-walk_data initialization and finalization with constructors and destructors

On Wed, Sep 18, 2013 at 07:17:35PM +0200, Michael Matz wrote: > > > I'd also like us to not use member privatization in our classes, but > > > that's not in the patch, but if we could agree on that it would be nice. > > Member privatization is quite natural. What specifically do you not like > > a

Re: [PATCH] manage dom-walk_data initialization and finalization with constructors and destructors

On Thu, Sep 19, 2013 at 03:23:21PM +0200, Michael Matz wrote: > > I don't see anything in Trevor's work that requires jumping through > > hoops. > > Me neither, from that perspective it's okay. It's merely that I doubt the > value of any syntactic privatization like it's implemented in C++, you

Re: [PATCH] manage dom-walk_data initialization and finalization with constructors and destructors

On Fri, Sep 20, 2013 at 10:13:27AM +0200, Richard Biener wrote: > On Thu, Sep 19, 2013 at 8:11 PM, Richard Sandiford > wrote: > > Michael Matz writes: > >> What's the benefit of reading and writing such noisy lines? : > >> > >> *out_mode = mode_; > >> mode_ = GET_MODE_WIDER_MODE (mode

ping [PATCH] rewrite stack vectors]

Hi, ping ;) Trev - Forwarded message from tsaund...@mozilla.com - Date: Thu, 10 Oct 2013 14:07:22 -0400 From: tsaund...@mozilla.com To: dnovi...@google.com, gcc-patches@gcc.gnu.org Cc: Trevor Saunders Subject: [PATCH] rewrite stack vectors X-Mailer: git-send-email 1.8.4.rc3 From

Re: [PATCH] rewrite stack vectors

On Fri, Oct 25, 2013 at 03:30:47PM -0400, Diego Novillo wrote: > On 2013-10-10 14:07 , tsaund...@mozilla.com wrote: > >This makes the implementation of stack vectors simpler and easier to use. > >This > >

Re: [PATCH] use stack vectors more

27;t tested it against that rev yet). Trev > > > Thanks. Diego. >From 3e9b030811d3ff4f5605227171d33561ce59453e Mon Sep 17 00:00:00 2001 From: Trevor Saunders Date: Wed, 9 Oct 2013 14:19:29 -0400 Subject: [PATCH] use stack vectors more --- gcc/cp/semantics.c

Re: [PATCH 0/6] Conversion of gimple types to C++ inheritance (v3)

> > It is a start, but it doesnt do the rest of the work that needs doing to > > really take advantage of it... which will be extensive. > > for instance, we should change: > > > >static inline void > > ! gimple_call_set_lhs (gimple gs, tree lhs) > >{ > > - GIMPLE_CHECK (gs, GIMPLE_CALL

Re: [PATCH] pr 65702 - error out for invalid register asms earlier

On Mon, Jan 25, 2016 at 04:42:58PM +0100, Bernd Schmidt wrote: > On 01/25/2016 04:36 PM, tbsaunde+...@tbsaunde.org wrote: > >$subject. To avoid regressions I kept the checks when generating rtl, but I > >believe its impossible for those to trigger now and we can remove the checks. > > > >bootstrap

Re: [PATCH] add basic .gitattributes files to notice whitespace issues

On Fri, Feb 05, 2016 at 10:33:51AM -0500, David Malcolm wrote: > On Thu, 2016-02-04 at 21:00 -0500, tbsaunde+...@tbsaunde.org wrote: > > From: Trevor Saunders > > > > Hi, > > > > We can tell git to highlight whitespace errors in diffs, and if you > > ena

Re: [PATCH] Make C++ use the enum mode attribute

On Sat, Feb 06, 2016 at 08:36:27PM +, Bernd Edlinger wrote: > > Hi Jakub, > > as a follow-up for your c/69669 fix, I'd like to have the enum mode also > honored > in C++ code, because the mode attribute now finally really works in C, but it > is > completely and silently(!) ignored by C++ c

Re: [PATCH] Make C++ use the enum mode attribute

On Mon, Feb 08, 2016 at 01:41:03PM -0800, Mike Stump wrote: > On Feb 6, 2016, at 2:37 PM, Trevor Saunders wrote: > > it is allowed if you do something like > > > > enum X : int; > > > > but it seems really pointless to support setting the size of something

Re: [RFC] Add contrib/fix-ChangeLog.sh

On Mon, Feb 22, 2016 at 11:05:49AM -0700, Jeff Law wrote: > On 02/20/2016 07:12 AM, Tom de Vries wrote: > >On 20/02/16 15:04, Tom de Vries wrote: > >>Hi, > >> > >>this patch adds a script contrib/fix-ChangeLog.sh. > >> > >>It fixes whitespace issues, and shows ChangeLog lines that look > >>suspicio

Re: RFA: MEP: Add newlib-stdint.h to tm_file.

On Tue, Mar 01, 2016 at 11:29:25AM -0700, Jeff Law wrote: > On 03/01/2016 11:26 AM, DJ Delorie wrote: > >>Can we make that official? 64402, 49401 & 24998 go away when MEP is > >>deprecated. > > > >We can, what's the next step? I announced intent in Dec, nobody > >commented or stepped up to take

Re: C++ edge_iterator (was: Re: [SH] PR 53976 - Add RTL pass to eliminate clrt, sett insns)

On Wed, Dec 11, 2013 at 06:47:37PM +0100, Oleg Endo wrote: > On Thu, 2013-11-21 at 00:04 +0100, Steven Bosscher wrote: > > Declaring the edge_iterator inside the for() is not a good argument > > against FOR_EACH_EDGE. Of course, brownie points are up for grabs for > > the brave soul daring enough t

Re: C++ edge_iterator (was: Re: [SH] PR 53976 - Add RTL pass to eliminate clrt, sett insns)

On Sat, Dec 14, 2013 at 10:19:48AM +0100, Richard Biener wrote: > Oleg Endo wrote: > >On Thu, 2013-12-12 at 03:13 -0500, Trevor Saunders wrote: > >> On Wed, Dec 11, 2013 at 06:47:37PM +0100, Oleg Endo wrote: > >> > On Thu, 2013-11-21 at 00:04 +0100, Steven Bosscher

Re: C++ edge_iterator (was: Re: [SH] PR 53976 - Add RTL pass to eliminate clrt, sett insns)

On Fri, Dec 13, 2013 at 10:00:57PM +0100, Oleg Endo wrote: > On Thu, 2013-12-12 at 03:13 -0500, Trevor Saunders wrote: > > On Wed, Dec 11, 2013 at 06:47:37PM +0100, Oleg Endo wrote: > > > On Thu, 2013-11-21 at 00:04 +0100, Steven Bosscher wrote: > > > > Declaring th

Re: C++ edge_iterator (was: Re: [SH] PR 53976 - Add RTL pass to eliminate clrt, sett insns)

On Mon, Dec 16, 2013 at 04:44:00PM +0100, Oleg Endo wrote: > On Mon, 2013-12-16 at 09:57 -0500, Trevor Saunders wrote: > > > > > > BTW, if you look at the patch, I haven't overloaded any ++ operators: >

Re: [patch] remove gate for ipa_inline pass

On Mon, Dec 16, 2013 at 09:13:41AM -0700, Jeff Law wrote: > On 12/13/13 12:42, Aldy Hernandez wrote: > >I'm fixing something completely unrelated, and noticed this... > > > >Perhaps I'm missing something, but why do we need a gate when it always > >returns true? Now that we have this `pass_data' b

[PATCH] merge auto_vec and stack_vec

As discussed in http://gcc.gnu.org/ml/gcc-patches/2013-11/msg02808.html bootstrap + same regression tests as previous rev, ok? 2013-12-19 Trevor saunders gcc/ * vec.h (stack_vec): Convert to a templaate specialization of auto_vec. * config/i386/i386.c, df-scan.c

Re: [PATCH] Allocate all target globals using GC for SWITCHABLE_TARGETs

On Sun, Jan 12, 2014 at 02:23:21PM +0100, Richard Biener wrote: > On Fri, Jan 10, 2014 at 6:37 PM, Richard Henderson wrote: > > On 01/09/2014 03:34 PM, Jakub Jelinek wrote: > >> 2014-01-09 Jakub Jelinek > >> > >> * target-globals.c (save_target_globals): Allocate < 4KB structs > >> using

Re: RFC: Use std::{min,max} instead of MIN/MAX?

On Fri, Jul 10, 2015 at 03:19:10PM +0200, Marek Polacek wrote: > Uros had the idea of using std::min/max instead of our MIN/MAX > macros defined in system.h. I thought I would do this cleanup, > but very soon I ran into a problem of failed template argument > substitution: std::min/max function te

Re: [PATCH] remove some usage of expr_list from read_rtx

On Mon, Jul 13, 2015 at 02:43:46PM +0100, Richard Sandiford wrote: > Nice clean-up :-) > > tbsaunde+...@tbsaunde.org writes: > > @@ -2248,11 +2249,14 @@ process_define_subst (void) > > static void > > rtx_handle_directive (int lineno, const char *rtx_name) > > { > > - rtx queue, x; > > + auto

Re: PR c/16351 Extend Wnonnull for returns_nonnull

On Fri, Jul 24, 2015 at 11:55:23PM +0200, Manuel López-Ibáñez wrote: > On 24 July 2015 at 21:30, Jeff Law wrote: > > On 07/24/2015 07:45 AM, Manuel López-Ibáñez wrote: > >> > >> On 23 July 2015 at 19:43, Jeff Law wrote: > >>> > >>> Warning in the front-ends like this can generate false positives

Re: [PATCH 4/4] define ASM_OUTPUT_LABEL to the name of a function

On Sat, Jul 25, 2015 at 10:59:19AM -0500, Segher Boessenkool wrote: > On Fri, Jul 24, 2015 at 10:37:00PM -0400, tbsaunde+...@tbsaunde.org wrote: > > --- a/gcc/config/pa/pa.c > > +++ b/gcc/config/pa/pa.c > > @@ -9761,6 +9761,18 @@ pa_reloc_rw_mask (void) > >return 3; > > } > > > > +/* Assembl

Re: [PATCH 1/4] convert ASM_OUTPUT_ASCII to a hook

On Fri, Jul 24, 2015 at 08:09:26PM -0700, pins...@gmail.com wrote: > > > > > > On Jul 24, 2015, at 7:36 PM, tbsaunde+...@tbsaunde.org wrote: > > +++ b/gcc/config/arm/arm.c > > @@ -18963,14 +18963,13 @@ int_log2 (HOST_WIDE_INT power) > > #define MAX_ASCII_LEN 51 > > > > void > > -output_ascii_p

Re: [PATCH 0/9] start converting POINTER_SIZE to a hook

On Mon, Jul 27, 2015 at 10:14:41AM -0600, Jeff Law wrote: > On 07/27/2015 03:17 AM, Richard Biener wrote: > >On Mon, Jul 27, 2015 at 5:10 AM, wrote: > >>From: Trevor Saunders > >> > >>Hi, > >> > >>$subject. > >> > >>pa

Re: [PATCH 0/9] start converting POINTER_SIZE to a hook

On Mon, Jul 27, 2015 at 09:05:08PM +0100, Richard Sandiford wrote: > Jeff Law writes: > > On 07/27/2015 03:17 AM, Richard Biener wrote: > >> On Mon, Jul 27, 2015 at 5:10 AM, wrote: > >>> From: Trevor Saunders > >>> > >>> Hi, > >>

Re: [PATCH 4/4] define ASM_OUTPUT_LABEL to the name of a function

On Mon, Jul 27, 2015 at 11:06:58AM +0200, Richard Biener wrote: > On Sat, Jul 25, 2015 at 4:37 AM, wrote: > > From: Trevor Saunders > > > > * config/arc/arc.h, config/bfin/bfin.h, config/frv/frv.h, > > config/ia64/ia64-protos.h, config/ia64

Re: [PATCH 0/9] start converting POINTER_SIZE to a hook

On Tue, Jul 28, 2015 at 09:24:17PM +0100, Richard Sandiford wrote: > Trevor Saunders writes: > > On Mon, Jul 27, 2015 at 09:05:08PM +0100, Richard Sandiford wrote: > >> Alternatively we could have a new target_globals structure that is > >> initialised with the result

Re: [PATCH 0/9] start converting POINTER_SIZE to a hook

On Wed, Jul 29, 2015 at 09:11:21AM +0100, Richard Sandiford wrote: > Trevor Saunders writes: > > On Tue, Jul 28, 2015 at 09:24:17PM +0100, Richard Sandiford wrote: > >> Trevor Saunders writes: > >> > On Mon, Jul 27, 2015 at 09:05:08PM +0100, Richard Sandiford w

Re: [PATCH 4/4] define ASM_OUTPUT_LABEL to the name of a function

On Mon, Jul 27, 2015 at 11:06:58AM +0200, Richard Biener wrote: > On Sat, Jul 25, 2015 at 4:37 AM, wrote: > > From: Trevor Saunders > > > > * config/arc/arc.h, config/bfin/bfin.h, config/frv/frv.h, > > config/ia64/ia64-protos.h, config/ia64

Re: [PATCH 4/4] define ASM_OUTPUT_LABEL to the name of a function

On Wed, Aug 05, 2015 at 01:47:30PM +0200, Richard Biener wrote: > On Wed, Aug 5, 2015 at 12:57 PM, Trevor Saunders > wrote: > > On Mon, Jul 27, 2015 at 11:06:58AM +0200, Richard Biener wrote: > >> On Sat, Jul 25, 2015 at 4:37 AM, wrote: > &g

Re: [PATCH 4/4] define ASM_OUTPUT_LABEL to the name of a function

On Wed, Aug 05, 2015 at 11:34:28AM -0400, David Malcolm wrote: > On Wed, 2015-08-05 at 11:28 -0400, David Malcolm wrote: > > On Wed, 2015-08-05 at 13:47 +0200, Richard Biener wrote: > > > On Wed, Aug 5, 2015 at 12:57 PM, Trevor Saunders > > > wrote: > > >

Re: [PATCH 4/4] define ASM_OUTPUT_LABEL to the name of a function

On Thu, Aug 06, 2015 at 08:36:36PM +0100, Richard Sandiford wrote: > David Malcolm writes: > > On Wed, 2015-08-05 at 16:22 -0400, Trevor Saunders wrote: > >> On Wed, Aug 05, 2015 at 11:34:28AM -0400, David Malcolm wrote: > >> > On Wed, 2015-08-05 at 11:28 -0400, Da

Re: dejagnu version update?

On Wed, Sep 16, 2015 at 10:36:47AM -0600, Jeff Law wrote: > On 09/16/2015 10:25 AM, Ramana Radhakrishnan wrote: > > > > > >On 16/09/15 17:14, Mike Stump wrote: > >>On Sep 16, 2015, at 12:29 AM, Andreas Schwab > >>wrote: > >>>Mike Stump writes: > >>> > The software presently works with 1.4.4 a

Re: (patch,rfc) s/gimple/gimple */

On Wed, Sep 16, 2015 at 03:11:14PM -0400, David Malcolm wrote: > On Wed, 2015-09-16 at 09:16 -0400, Trevor Saunders wrote: > > Hi, > > > > I gave changing from gimple to gimple * a shot last week. It turned out > > to be not too hard. As you might expect the patch

Re: (patch,rfc) s/gimple/gimple */

On Fri, Sep 18, 2015 at 09:32:37AM -0600, Jeff Law wrote: > On 09/18/2015 07:32 AM, Trevor Saunders wrote: > >On Wed, Sep 16, 2015 at 03:11:14PM -0400, David Malcolm wrote: > >>On Wed, 2015-09-16 at 09:16 -0400, Trevor Saunders wrote: > >>>Hi, > >>> >

Re: [PATCH tree-inline] do not say "called from here" with UNKNOWN_LOCATION

On Mon, Sep 21, 2015 at 12:29:36PM +0200, Richard Biener wrote: > On Mon, Sep 21, 2015 at 11:59 AM, Manuel López-Ibáñez > wrote: > > On 21 September 2015 at 10:18, Richard Biener > > wrote: > >> input_location is set from the call stmt: > >> > >> /* FIXME: instantiate_decl isn't called by inlin

Re: [PATCH] Add new hooks ASM_OUTPUT_START_FUNCTION_HEADER ...

On Mon, Sep 21, 2015 at 12:31:58PM +0100, Dominik Vogt wrote: > This patch adds to new backend hooks > ASM_OUTPUT_START_FUNCTION_HEADER and > ASM_OUTPUT_END_FUNCTION_FOOTER that may be defined to emit > assembly code at the very start or end of a function. This > functionality is needed by the pat

Re: (patch,rfc) s/gimple/gimple */

On Mon, Sep 21, 2015 at 08:32:36PM +0100, Richard Sandiford wrote: > Richard Biener writes: > > On Fri, Sep 18, 2015 at 3:32 PM, Trevor Saunders > > wrote: > >> On Wed, Sep 16, 2015 at 03:11:14PM -0400, David Malcolm wrote: > >>> On Wed, 2015-09-16 a

Re: [PATCH] DWARF support for AIX v3

On Tue, Sep 22, 2015 at 03:16:28PM +0200, Richard Biener wrote: > On September 22, 2015 2:38:34 PM GMT+02:00, David Edelsohn > wrote: > >On Tue, Sep 22, 2015 at 4:12 AM, Richard Biener > > wrote: > >> On Mon, Sep 21, 2015 at 5:41 PM, David Edelsohn > >wrote: > >>> Appended is a patch to support

Re: [PATCH] DWARF support for AIX v3

On Tue, Sep 22, 2015 at 10:09:51AM -0400, David Edelsohn wrote: > On Tue, Sep 22, 2015 at 9:54 AM, Trevor Saunders > wrote: > > On Tue, Sep 22, 2015 at 03:16:28PM +0200, Richard Biener wrote: > >> On September 22, 2015 2:38:34 PM GMT+02:00, David Edelsohn > >> wro

Re: [PATCH] PR28901 -Wunused-variable ignores unused const initialised variables

On Thu, Sep 24, 2015 at 06:55:11PM +0200, Bernd Schmidt wrote: > On 09/24/2015 06:11 PM, Steve Ellcey wrote: > >At least one of the warnings in glibc is not justified (in my opinion). > >The header file timezone/private.h defines time_t_min and time_t_max. > >These are not used in any of the timezo

Re: (patch,rfc) s/gimple/gimple */

On Thu, Sep 24, 2015 at 11:31:40AM +0200, Thomas Schwinge wrote: > Hi! > > On Sat, 19 Sep 2015 20:55:35 -0400, Trevor Saunders > wrote: > > On Fri, Sep 18, 2015 at 09:32:37AM -0600, Jeff Law wrote: > > > On 09/18/2015 07:32 AM, Trevor Saunders wrote: > > >

Re: [PATCH] Fix warnings building pdp11 port

On Tue, Sep 29, 2015 at 10:55:46AM -0600, Jeff Law wrote: > The pdp11 port fails to build with the trunk because of a warning. > Essentially VRP determines that the result of using BRANCH_COST is a > constant with the range [0..1]. That's always less than 4, 3 and the > various other magic constan

Re: [patch 0/6] scalar-storage-order merge (2)

On Tue, Oct 13, 2015 at 07:32:08PM +0200, Eric Botcazou wrote: > > My main question about this series is - how generally useful do you > > expect it to be? I know of some different projects that would like > > bi-endian capability, but it looks like this series implements something > > that is a li

Re: [PATCH 2/6] always define SETUP_FRAME_ADDRESSES

On Mon, Oct 12, 2015 at 12:19:08PM +0200, Bernd Schmidt wrote: > On 10/11/2015 02:25 AM, tbsaunde+...@tbsaunde.org wrote: > >From: Trevor Saunders > > > >gcc/ChangeLog: > > > >2015-10-10 Trevor Saunders > > > > * defaults.h (S

Re: Fix prototype for print_insn in rtl.h

On Thu, Oct 15, 2015 at 07:48:18PM +0300, Nikolai Bozhenov wrote: > > On 10/15/2015 07:28 PM, Andrew MacLeod wrote: > >On 10/13/2015 11:32 AM, Jeff Law wrote: > >>On 10/13/2015 02:21 AM, Nikolai Bozhenov wrote: > >>>2015-10-13 Nikolai Bozhenov > >>> > >>> * gcc/rtl.h (print_insn): fix prototy

Re: [PATCH 2/6] always define SETUP_FRAME_ADDRESSES

On Thu, Oct 15, 2015 at 11:47:10AM +0200, Bernd Schmidt wrote: > On 10/15/2015 04:13 AM, Trevor Saunders wrote: > >On Mon, Oct 12, 2015 at 12:19:08PM +0200, Bernd Schmidt wrote: > >>If we go to the trouble of changing this, could we convert macros to target > >>hook

Re: [PATCH] Fix abort in write_eligible_delay

On Thu, Oct 22, 2015 at 01:18:29PM -0600, Jeff Law wrote: > > Various ports are currently failing to build, faulting in > write_eligible_delay. > > This can happen if the target has delay slots defined, but does not have > annul-true or annul-false slots. cris is a reasonable example. > > This

Re: [PATCH 7/9] ENABLE_CHECKING refactoring: middle-end, LTO FE

On Tue, Oct 27, 2015 at 07:06:42PM -0600, Jeff Law wrote: > On 10/26/2015 12:45 PM, Jeff Law wrote: > Don't change the whitespace here. Looks like you probably removed a > page > break. > >>>Not obvious where it got lost as there's no filename in the review > >>>comments :-) > >> > >>Oo

Re: [PATCH 1/5] 2015-01-25 Paul Thomas

On Fri, Oct 30, 2015 at 01:10:32PM +0100, Bernd Schmidt wrote: > On 10/30/2015 12:48 PM, tbsaunde+...@tbsaunde.org wrote: > >From: pault > > > > PR fortran/67171 > > * trans-array.c (structure_alloc_comps): On deallocation of > > class components, reset the vptr to the declared type vt

Re: [PATCH 5/5] remove usage of ADJUST_FIELD_ALIGN in encoding.c

On Fri, Oct 30, 2015 at 01:16:16PM +0100, Richard Biener wrote: > On Fri, Oct 30, 2015 at 1:06 PM, Bernd Schmidt wrote: > > On 10/30/2015 12:48 PM, tbsaunde+...@tbsaunde.org wrote: > >> > >> -#ifdef ADJUST_FIELD_ALIGN > >> - desired_align = ADJUST_FIELD_ALIGN (type, desired_align); > >> +#if defi

Re: [PATCH 5/5] remove usage of ADJUST_FIELD_ALIGN in encoding.c

On Sat, Oct 31, 2015 at 03:02:07PM +0800, Andrew Pinski wrote: > On Fri, Oct 30, 2015 at 9:11 PM, Bernd Schmidt wrote: > > On 10/30/2015 01:47 PM, Richard Biener wrote: > >> > >> On Fri, Oct 30, 2015 at 1:28 PM, Bernd Schmidt > >> wrote: > > > it's not target independent code. Are

Re: [PATCH 4/5] remove usage of BIGGEST_FIELD_ALIGNMENT in encoding.c

On Sat, Oct 31, 2015 at 01:20:45PM +0800, Andrew Pinski wrote: > On Fri, Oct 30, 2015 at 7:48 PM, wrote: > > From: Trevor Saunders > > > > Similar to ROUND_TYPE_ALIGN it seems to make sense to copy the > > information in the target macros to libobjc as an incremental

Re: [PATCH] Better error messages for merge-conflict markers (v3)

On Mon, Nov 02, 2015 at 03:52:13PM -0700, Jeff Law wrote: > On 10/30/2015 09:16 AM, David Malcolm wrote: > >This is a rebased version of this patch from back in April: > > v2: https://gcc.gnu.org/ml/gcc-patches/2015-04/msg00944.html > >which in turn is a rewrite of this one: > > v1: https://gcc

Re: [PATCH] remove unused config/arm/coff.h

On Tue, Nov 03, 2015 at 06:49:20AM -0700, Jeff Law wrote: > On 11/03/2015 04:31 AM, tbsaunde+...@tbsaunde.org wrote: > >From: Trevor Saunders > > > >Hi, > > > >$subject, nothing refers to this header so we might as well remove it. > > > >tested I ca

Re: [PATCH] replace BITS_PER_UNIT with __CHAR_BIT__ in target libs

On Tue, Nov 03, 2015 at 01:20:26PM +, Joseph Myers wrote: > On Mon, 2 Nov 2015, Jeff Law wrote: > > > Based on Bernd's comments, I think this is fine. Any sense of how much work > > there is left to cleanup the runtime's inclusion of gcc's config/ target > > headers? > > See

Re: [PATCH] Fix memory leaks and use a pool_allocator

On Mon, Nov 09, 2015 at 01:11:48PM +0100, Richard Biener wrote: > On Mon, Nov 9, 2015 at 12:22 PM, Martin Liška wrote: > > Hi. > > > > This is follow-up of changes that Richi started on Friday. > > > > Patch can bootstrap on x86_64-linux-pc and regression tests are running. > > > > Ready for trunk

Re: [PATCH 10/12] always define EH_RETURN_HANDLER_RTX

On Mon, Nov 09, 2015 at 11:42:19AM -0700, Jeff Law wrote: > On 11/09/2015 11:27 AM, Bernd Schmidt wrote: > >On 11/09/2015 05:47 PM, tbsaunde+...@tbsaunde.org wrote: > >>From: Trevor Saunders > >> > >>gcc/ChangeLog: > >> > >>2

Re: [PATCH 00/12] misc conditional compilation work

On Mon, Nov 09, 2015 at 10:57:10AM -0700, Jeff Law wrote: > On 11/09/2015 09:47 AM, tbsaunde+...@tbsaunde.org wrote: > >From: Trevor Saunders > > > >Hi, > > > >basically $subject, making some code unconditionally compiled, and changing > >other things

Re: [PATCH 05/12] always define VMS_DEBUGGING_INFO

On Mon, Nov 09, 2015 at 11:44:30AM -0700, Jeff Law wrote: > On 11/09/2015 11:34 AM, Bernd Schmidt wrote: > >In general I think the _DEBUGGING_INFO patches are going to be OK, > >modulo Jeff's comment about stage 1. I think they shouldn't have been > >split - it causes numerous unnecessary extra cha

Re: [PATCH 01/12] reduce conditional compilation for HARD_FRAME_POINTER_IS_ARG_POINTER

On Mon, Nov 09, 2015 at 08:01:28PM +0100, Bernd Schmidt wrote: > On 11/09/2015 05:47 PM, tbsaunde+...@tbsaunde.org wrote: > >+++ b/gcc/dbxout.c > >@@ -3076,10 +3076,8 @@ dbxout_symbol_location (tree decl, tree type, const > >char *suffix, rtx home) > >|| (REG_P (XEXP (home, 0)) > >

Re: [PATCH 11/12] always define HAVE_AS_LEB128

On Mon, Nov 09, 2015 at 07:42:32PM +0100, Bernd Schmidt wrote: > >-#ifdef HAVE_AS_LEB128 > >+#if HAVE_AS_LEB128 > > This patch doesn't seem to actually remove any conditional compilation? I guess, but it does make it possible to incrementally do that which wasn't possible before, and imo is an im

Re: [PATCH 10/12] always define EH_RETURN_HANDLER_RTX

On Mon, Nov 09, 2015 at 12:46:33PM -0700, Jeff Law wrote: > On 11/09/2015 12:38 PM, Bernd Schmidt wrote: > >On 11/09/2015 07:52 PM, Trevor Saunders wrote: > > > >>yeah, that's more or less my thought, and this makes hookization easier > >>since you can now mec

Re: [PATCH 05/12] always define VMS_DEBUGGING_INFO

On Mon, Nov 09, 2015 at 08:37:19PM +0100, Bernd Schmidt wrote: > On 11/09/2015 08:29 PM, Trevor Saunders wrote: > >as I said in 0/12 this did go through config-list.mk, and checking again > >this does build on alpha-dec-vms. > > The question I have is - why does it build on a

Re: [PATCH 10/12] always define EH_RETURN_HANDLER_RTX

On Mon, Nov 09, 2015 at 03:07:21PM -0700, Jeff Law wrote: > On 11/09/2015 02:30 PM, Trevor Saunders wrote: > > > >So in general when I've done cross target things I think I've found more > >bugs with config-list.mk than with a regtest, but the regtest has foun

Re: [PATCH 10/12] always define EH_RETURN_HANDLER_RTX

On Tue, Nov 10, 2015 at 11:02:04PM +0100, Bernd Schmidt wrote: > On 11/09/2015 11:53 PM, Trevor Saunders wrote: > >I don't really know him, but I don't really disagree with where he wants > >to get to. However I think we work fairly different ways, and review > >thi

Re: [PATCH 1/6] Fix memory leak in cilk

> diff --git a/gcc/c-family/cilk.c b/gcc/c-family/cilk.c > index e75e20c..1167b2b 100644 > --- a/gcc/c-family/cilk.c > +++ b/gcc/c-family/cilk.c > @@ -844,6 +844,7 @@ gimplify_cilk_spawn (tree *spawn_p) > call2, build_empty_stmt (EXPR_LOCATION (call1))); >append_to_sta

Re: [PATCH 3/6] Fix memory leaks in IPA devirt

On Mon, Nov 23, 2015 at 02:48:37PM +0100, marxin wrote: > gcc/ChangeLog: > > 2015-11-20 Martin Liska > > * ipa-devirt.c (ipa_devirt): Use auto_vec instead > of a local-scope vec. Release final_warning_records. > --- > gcc/ipa-devirt.c | 5 +++-- > 1 file changed, 3 insertions(+),

Re: [PATCH 01/15] Selftest framework (unittests v4)

On Tue, Nov 24, 2015 at 01:44:34PM -0700, Jeff Law wrote: > On 11/19/2015 11:44 AM, Bernd Schmidt wrote: > >On 11/19/2015 07:08 PM, David Malcolm wrote: > >>gcc_assert terminates the process and no further testing is done, > >>whereas the approach the kit tries to run as much of the testsuite as >

Re: [PATCH 1/2] destroy values as well as keys when removing them from hash maps

On Tue, Dec 01, 2015 at 07:43:35PM +, Richard Sandiford wrote: > tbsaunde+...@tbsaunde.org writes: > > -template > > +template > > template > > inline void > > -simple_hashmap_traits ::remove (T &entry) > > +simple_hashmap_traits ::remove (T &entry) > > { > >H::remove (entry.m_key); >

Re: [PATCH 1/2] destroy values as well as keys when removing them from hash maps

On Wed, Dec 02, 2015 at 09:35:13AM +, Richard Sandiford wrote: > Richard Biener writes: > > On Wed, 2 Dec 2015, Trevor Saunders wrote: > >> On Tue, Dec 01, 2015 at 07:43:35PM +, Richard Sandiford wrote: > >> > tbsaunde+...@tbsaunde.org writes: > >

Re: [RFA] [PATCH] [PR tree-optimization/68619] Avoid direct cfg cleanups in tree-ssa-dom.c [1/3]

On Mon, Dec 07, 2015 at 11:15:33PM -0700, Jeff Law wrote: > > First in the series. This merely refactors code from tree-ssa-sccvn.c into > domwalk.c so that other walkers can use it as they see fit. > > > There's an initialization function which sets all edges to executable. > > There's a test

[PATCH 1/6] auto_vec copy/move improvements

opy a vector copy () can be used. Signed-off-by: Trevor Saunders bootstrapped and regtested on x86_64-linux-gnu, ok? gcc/ChangeLog: * vec.h (vl_ptr>::using_auto_storage): Handle null m_vec. (auto_vec::auto_vec): Define move constructor, and delete copy con

[PATCH 2/6] return auto_vec from cgraph_node::collect_callers

This ensures the callers of collect_callers () take ownership of the vector and free it when appropriate. Signed-off-by: Trevor Saunders bootstrapped and regtested on x86_64-linux-gnu, ok? gcc/ChangeLog: * cgraph.c (cgraph_node::collect_callers): Return auto_vec

[PATCH 3/6] return auto_vec from get_loop_hot_path

This ensures callers take ownership of the returned vector. Signed-off-by: Trevor Saunders bootstrapped and regtested on x86_64-linux-gnu, ok? gcc/ChangeLog: * cfgloop.h (get_loop_hot_path): Return auto_vec. * cfgloopanal.c (get_loop_hot_path): Likewise. * tree-ssa

[PATCH 4/6] return auto_vec from get_dominated_by

Signed-off-by: Trevor Saunders bootstrapped and regtested on x86_64-linux-gnu, ok? gcc/ChangeLog: * dominance.c (get_dominated_by): Return auto_vec. * dominance.h (get_dominated_by): Likewise. * auto-profile.c (afdo_find_equiv_class): Adjust. * cfgloopmanip.c

[PATCH 5/6] make get_domminated_by_region return a auto_vec

This makes it clear the caller owns the vector, and ensures it is cleaned up. Signed-off-by: Trevor Saunders bootstrapped and regtested on x86_64-linux-gnu, ok? gcc/ChangeLog: * dominance.c (get_dominated_by_region): Return auto_vec. * dominance.h (get_dominated_by_region

[PATCH 6/6] return auto_vec from more dominance functions

This ensures the vector gets cleaned up by the caller when appropriate. Signed-off-by: Trevor Saunders bootstrapped and regtested on x86_64-linux-gnu, ok? gcc/ChangeLog: * dominance.c (get_dominated_to_depth): Return auto_vec. * dominance.h (get_dominated_to_depth): Likewise

Re: [PATCH 1/6] auto_vec copy/move improvements

On Tue, Jun 15, 2021 at 08:42:35AM +0200, Richard Biener wrote: > On Tue, Jun 15, 2021 at 8:00 AM Trevor Saunders wrote: > > > > - Unfortunately using_auto_storage () needs to handle m_vec being null. > > - Handle self move of an auto_vec to itself. > > - punt on defi

  1   2   3   4   5   >