On Thu, Oct 22, 2015 at 01:18:29PM -0600, Jeff Law wrote: > > Various ports are currently failing to build, faulting in > write_eligible_delay. > > This can happen if the target has delay slots defined, but does not have > annul-true or annul-false slots. cris is a reasonable example. > > This is most easily addressed by writing out a trivial dummy function if we > don't have annul-true or annul-false slots. > > I've verified this fixes the 47 newly failing targets in config-list.mk and > survives the usual bootstrap & comparison test on x86_64-linux-gnu.
thanks for taking care of this. > +write_dummy_eligible_delay (FILE *outf, const char *kind) > +{ > + /* Write function prelude. */ > + > + fprintf (outf, "int\n"); > + fprintf (outf, "eligible_for_%s (rtx_insn *delay_insn ATTRIBUTE_UNUSED,\n" > + " int slot ATTRIBUTE_UNUSED,\n" > + " rtx_insn *candidate_insn ATTRIBUTE_UNUSED,\n" > + " int flags ATTRIBUTE_UNUSED)\n", > + kind); Couldn't you just leave the arguments unnamed as a simpler way to avoid unused warnings? Trev