Re: [PR fortran/83184] Fix matching code for clist/old-style initializers when encountering assumed-rank declarations

2018-07-17 Thread Fritz Reese
On Tue, Jul 17, 2018, 04:31 Janus Weil wrote: > Did someone actually approve this patch? Apparently it was committed > as r262744 and caused the following regression: > > https://gcc.gnu.org/bugzilla/show_bug.cgi?id=86543 > > Cheers, > Janus > > > > 2018-

Re: [Patch, Fortran] PR 85599: warn about short-circuiting of logical expressions for non-pure functions

2018-07-17 Thread Fritz Reese
On Tue, Jul 17, 2018 at 10:32 AM Janus Weil wrote: > > 2018-07-17 9:52 GMT+02:00 Janus Weil : > >> 2018-07-16 21:50 GMT+02:00 Thomas Koenig : > >>> What I would suggest is to enable -Wfunction-eliminiation with > >>> -Wextra and also use that for your new warning. > >> > >> Thanks for the comments

Re: [Patch, Fortran] PR 85599: warn about short-circuiting of logical expressions for non-pure functions

2018-07-17 Thread Fritz Reese
On Tue, Jul 17, 2018 at 2:36 PM Janus Weil wrote: > > 2018-07-17 19:34 GMT+02:00 Thomas Koenig : > > Am 17.07.2018 um 19:19 schrieb Janus Weil: [...] > > I do hope that things have converged by now and that this will be the > last incarnation of the patch. If there is no more feedback in the > nex

RE: Fwd: DEC Extension Patches: Structure, Union, and Map

2016-03-01 Thread Fritz Reese
Please see the original message: https://gcc.gnu.org/ml/fortran/2016-03/msg2.html I have to send the patches separately, as together they are blocked by the spam filter. This is part 1: --- Fritz Reese From 00eaf54e4cc4bb63bfbcb1ffab97cb9b593f2c6d Mon Sep 17 00:00:00 2001 From: Fritz O

RE: Fwd: DEC Extension Patches: Structure, Union, and Map

2016-03-01 Thread Fritz Reese
Please see the original thread https://gcc.gnu.org/ml/fortran/2016-03/msg2.html. I have to send the patches separately, as together they cause me to be blocked for spamming. This is patch 2: --- Fritz Reese From 2f7077c45fdcf2d05554d9d2e22fc5261bd95661 Mon Sep 17 00:00:00 2001 From: Fritz O

RE: Fwd: DEC Extension Patches: Structure, Union, and Map

2016-03-01 Thread Fritz Reese
Please see the original thread https://gcc.gnu.org/ml/fortran/2016-03/msg2.html. I have to send the patches separately, as together they cause me to be blocked for spamming. This is patch 3: --- Fritz Reese From 93e96b8a9e62c0413e6d9d33c01fa7825ecd9ee4 Mon Sep 17 00:00:00 2001 From: Fritz O

RE: Fwd: DEC Extension Patches: Structure, Union, and Map

2016-03-01 Thread Fritz Reese
Please see the original thread https://gcc.gnu.org/ml/fortran/2016-03/msg2.html. I have to send the patches separately, as together they cause me to be blocked for spamming. This is the big one, patch 4. It is compressed with gzip since it is 150KB uncompressed. --- Fritz Reese 0004-2016

[Patch, fortran] Initializing components of derived type variables

2016-03-04 Thread Fritz Reese
gfc_generate_derived_initializer). I decided to change the old function because their behaviors would be almost identical, and there are only a few calls to the former. The patch is based on trunk. It builds and passes all regression tests on x86-64-gnu-linux. --- Fritz Reese From

Re: PATCH -- Fix degree trignometric functions

2020-03-09 Thread Fritz Reese
values. Modifications are so easy even a lurker can do > them. ... extend the patch to include these changes (unless someone enthusiastic gets around to these mods before I do). I should be able to start on this next week (around 16 March). --- Fritz Reese

Re: [PATCH] Use getentropy() for seeding PRNG

2018-08-13 Thread Fritz Reese
On Fri, Aug 3, 2018 at 9:19 AM Janne Blomqvist wrote: > > The getentropy function, found on Linux, OpenBSD, and recently also > FreeBSD, can be used to get random bytes to initialize the PRNG. It > is similar to the traditional way of reading from /dev/urandom, but > being a system call rather th

Re: [PATCH] Use getentropy() for seeding PRNG

2018-08-14 Thread Fritz Reese
On Mon, Aug 13, 2018 at 4:12 PM Janne Blomqvist wrote: > > On Mon, Aug 13, 2018 at 5:36 PM, Fritz Reese wrote: >> >> On Fri, Aug 3, 2018 at 9:19 AM Janne Blomqvist >> wrote: >> > >> > The getentropy function, found on Linux, OpenBSD, and recently al

Re: [Patch, Fortran] PR 86116: Ambiguous generic interface not recognised

2018-08-14 Thread Fritz Reese
Looks OK to me. On Tue, Aug 14, 2018 at 4:12 AM Janus Weil wrote: > > ping! > > > Am So., 5. Aug. 2018 um 15:23 Uhr schrieb Janus Weil : > > > > Hi all, > > > > the attached patch fixes PR 86116 by splitting up the function > > 'compare_type' into two variants: One that is used for checking > > g

[PATCH, Fortran] Fix PR 82886 - ICE with -finit-derived in gfc_conv_expr

2017-11-10 Thread Fritz Reese
onent initializers. (Of course explicit -finit-* flags will still override this inference). Regression tests pass on x86_64-redhat-linux. OK? --- Fritz Reese >From e70f3917a7b2d35f9baad2f09199c1ccc60a04d4 Mon Sep 17 00:00:00 2001 From: Fritz Reese Date: Fri, 10 Nov 2017 16:10:06 -0500 Subject

Re: [PATCH, Fortran] Fix PR 82886 - ICE with -finit-derived in gfc_conv_expr

2017-11-10 Thread Fritz Reese
My mistake, the patch file should not have the random changes to libiberty/functions.texi. Not sure how that ended up there. --- Fritz Reese On Fri, Nov 10, 2017 at 4:31 PM, Fritz Reese wrote: > All, > > The attached patch fixes the ICE reported in PR 82886. The ICE is due > to c

Re: [PATCH, Fortran] Fix PR 82886 - ICE with -finit-derived in gfc_conv_expr

2017-11-10 Thread Fritz Reese
On Fri, Nov 10, 2017 at 6:40 PM, Steve Kargl wrote: > On Fri, Nov 10, 2017 at 04:35:56PM -0500, Fritz Reese wrote: >> My mistake, the patch file should not have the random changes to >> libiberty/functions.texi. Not sure how that ended up there. >> > >> >

Re: [PATCH] PR fortran/78240 -- kludge of the day

2017-11-13 Thread Fritz Reese
inting me to this issue and allowing me time to review it. The new patch passes all regression tests including its two tests (one for each issue above). OK to commit this one? --- Fritz Reese >From f2b8262a1a366b072493b129d38465ffa3d265bc Mon Sep 17 00:00:00 2001 From: Fritz Reese Date: Mon, 13 Nov

Re: [PATCH] PR fortran/78240 -- kludge of the day

2017-11-14 Thread Fritz Reese
‘x’ at (1) must have constant shape > pr78240.f90:11:19: > >integer x(n)/1/ ! { dg-error "Nonconstant array" } >1 > Error: Nonconstant array section at (1) in DATA statement > [...] ... does anyone know how to tell dejagnu to expect multiple errors on a single line? --- Fritz Reese

Re: [PATCH] PR fortran/78240 -- kludge of the day

2017-11-15 Thread Fritz Reese
On Wed, Nov 15, 2017 at 1:13 PM, Steve Kargl wrote: > On Tue, Nov 14, 2017 at 05:21:41PM -0500, Fritz Reese wrote: >> On Tue, Nov 14, 2017 at 4:58 PM, Janus Weil wrote: >> > Hi guys, >> > >> > I see this new test case failing on x86_64-linux-gnu: >>

[PRs fortran/82972, fortran/83088, fortran/85851] Fix ICE with -finit-derived when using iso_c_binding

2018-06-22 Thread Fritz Reese
Mon Sep 17 00:00:00 2001 From: Fritz Reese Date: Fri, 22 Jun 2018 16:11:02 -0400 Subject: [PATCH] PR fortran/82972 Fix -finit-derived for c_ptr and c_funptr in programs which use iso_c_binding. gcc/fortran/ * expr.c (component_initializer): Assign init expr to c->initi

Re: [PRs fortran/82972, fortran/83088, fortran/85851] Fix ICE with -finit-derived when using iso_c_binding

2018-06-24 Thread Fritz Reese
Thanks for the review. I will commit tomorrow. --- Fritz Reese On Sat, Jun 23, 2018 at 11:57 AM, Steve Kargl wrote: > On Fri, Jun 22, 2018 at 04:46:19PM -0400, Fritz Reese wrote: >> >> In any case, the changelog is here, and the patch is attached. Aside >> from the issue

[PR Fortran/83183] Fix infinite recursion (ICE) with -finit-derived when initializing allocatable BT_DERIVED components

2018-06-25 Thread Fritz Reese
:00 2001 From: Fritz Reese Date: Mon, 25 Jun 2018 17:51:00 -0400 Subject: [PATCH] PR fortran/83183 Fix infinite recursion occurring with -finit-derived generating initializers for allocatable derived-type components. gcc/fortran/ * expr.c (component_initializer): Do not generate initializers w

Re: [PR Fortran/83183] Fix infinite recursion (ICE) with -finit-derived when initializing allocatable BT_DERIVED components

2018-06-27 Thread Fritz Reese
iler's original behavior. This also fixes PR 86325 (mentioned above). The patch is attached. OK for trunk and 7/8-branch? >From e190d59153eaa7fbfcfabc93db31ddda0de3b869 Mon Sep 17 00:00:00 2001 From: Fritz Reese Date: Mon, 25 Jun 2018 17:51:00 -0400 Subject: [PATCH 1/3] PR fortran/83183 PR fortran/86325 F

[PR fortran/83184] Fix matching code for clist/old-style initializers when encountering assumed-rank declarations

2018-06-27 Thread Fritz Reese
The attached patch fixes PR fortran/83184, which is actually two distinct bugs as described in the PR. Passes regtests. The patch is attached. OK for trunk and 7/8-branch? >From 238f0a0e80c93209bb4e62ba2f719f74f5da164f Mon Sep 17 00:00:00 2001 From: Fritz Reese Date: Wed, 27 Jun 2018 16:16

[PR fortran/82865] Fix PDT declarations being parsed as PRINT statements with -fdec

2018-06-27 Thread Fritz Reese
asserted. Passes regression tests as well. The patch is attached. OK for trunk and 7/8-branch? 0dd08cefc2476014487b3eeab059784ab21bb41b Mon Sep 17 00:00:00 2001 From: Fritz Reese Date: Wed, 27 Jun 2018 15:43:45 -0400 Subject: [PATCH 3/3] PR fortran/82865 Do not override PDT declarations from

Re: [PATCH, Fortran] -fno-automatic with -finit-local prevents initialization of automatics in recursive functions

2014-08-29 Thread Fritz Reese
, -finit-local-zero should still initialize automatic variables in RECURSIVE functions. I believe this is a simple fix; to actually follow the specification set forth in the man page, don't treat symbols in a RECURSIVE namespace as if they are saved in resolve.c (apply_default_init_loca

[Patch, Fortran] Component declarations overwrite types of Cray Pointee variables

2014-09-02 Thread Fritz Reese
tabs with spaces so I'm sorry for any whitespace issues. 2014-09-02 Fritz Reese PR fortran/62174 * decl.c (variable_decl): Don't overwrite typespecs of Cray pointees when matching a component declaration. diff --git a/gcc/fortran/decl.c b/gcc/fortran/decl.

Re: PR fortran/87919 patch for -fno-dec-structure

2018-12-03 Thread Fritz Reese
> I think more than enough time passed, do you plan to commit to trunk now? > Note, small adjustment will be needed for the addition of flag_dec_include > in set_dec_flags. Jakub- Sorry, yes. I've had other priorities the past few weeks here, but I just committed r266745 adjusted for -fdec-include

Re: PR fortran/87919 patch for -fno-dec-structure

2018-12-03 Thread Fritz Reese
On Mon, Dec 3, 2018 at 12:12 PM Jakub Jelinek wrote: > > On Mon, Dec 03, 2018 at 04:58:51PM +0100, Jakub Jelinek wrote: > > > but I just committed r266745 adjusted for -fdec-include. > > > > Thanks, though it seems what you've committed in options.c is incomplete. > > In the patch you've posted ea

Re: [PATCH, Fortran] pad char to int conversions with spaces instead of zeros (legacy)

2018-12-04 Thread Fritz Reese
On Tue, Dec 4, 2018 at 10:12 AM Jakub Jelinek wrote: > > Just a couple of random comments. > -fdec-pad-with-spaces option name doesn't look right, because it doesn't say > what the option affects. So perhaps have transfer in the option name? [...] > Wouldn't it be better to allow specifying whate

Re: Fortran patches

2018-12-05 Thread Fritz Reese
On Wed, Dec 5, 2018 at 12:00 AM Steve Kargl wrote: > > I intend to commit the attached patch on Saturday. Thanks for the work. I assume the patch bootstraps and passes regression tests? RE: > PR fortran/88228 > * expr.c (check_null, check_elemental): Work around -fdec and >

Re: Fortran patches

2018-12-06 Thread Fritz Reese
On Wed, Dec 5, 2018 at 7:03 PM Steve Kargl wrote: > > On Wed, Dec 05, 2018 at 04:48:28PM -0500, Fritz Reese wrote: [...] > > RE: > > > PR fortran/88228 > > > * expr.c (check_null, check_elemental): Work around -fdec and > > > initiali

Re: [PATCH, Fortran] pad char to int conversions with spaces instead of zeros (legacy)

2018-12-10 Thread Fritz Reese
> On Mon, Dec 10, 2018 at 02:09:50PM +, Mark Eggleston wrote: > > > > On 06/12/2018 10:20, Mark Eggleston wrote: > > > > Yes. Mark, you'll need to also patch iresolve.c (gfc_resolve_transfer) > > > > to affect non-constant resolution. > > > Thanks for the hint. > > > > I've looked at gfc_resolv

Re: PR fortran/87919 patch for -fno-dec-structure

2018-11-07 Thread Fritz Reese
lue=0 condition. Similarly to the tests Mark provided with -fdec-structure, I've provided new tests for the various facets of -fno-dec, -fno-check-array-temporaries, and -fno-init-local-zero. Below is the changelog. Bootstraps and regtests fine for me on x86_64-redhat-linux. If it looks OK I'l

Re: PR fortran/87919 patch for -fno-dec-structure

2018-11-08 Thread Fritz Reese
On Wed, Nov 7, 2018 at 5:32 PM Jakub Jelinek wrote: > > On Wed, Nov 07, 2018 at 05:05:13PM -0500, Fritz Reese wrote: > > --- a/gcc/fortran/options.c > +++ b/gcc/fortran/options.c > @@ -32,6 +32,20 @@ along with GCC; see the file COPYING3. If not see > > gfc_option_t

Re: PR fortran/87919 patch for -fno-dec-structure

2018-11-12 Thread Fritz Reese
On Thu, Nov 8, 2018 at 12:54 PM Jakub Jelinek wrote: > > On Thu, Nov 08, 2018 at 12:09:33PM -0500, Fritz Reese wrote: > > > What about the > > > /* Allow legacy code without warnings. */ > > > gfc_option.allow_std |= GFC_STD_F95_OBS | GFC_STD_F9

[PATCH, fortran] PR fortran/85982 -- Fix ICE on invalid attributes inside DEC structures

2018-11-12 Thread Fritz Reese
nobody sees any issues this week or so. (Nb. the test case is named dec_structure_28.f90 so as not to conflict with the pending patch for PR fortran/87919 which adds dec_structure_{24-27}.f90.) -- Fritz >From dc5a072017af29ca1e84b85b0e3a1e6af49a6928 Mon Sep 17 00:00:00 2001 From: Fritz Reese D

Re: PR fortran/87919 patch for -fno-dec-structure

2018-11-12 Thread Fritz Reese
On Mon, Nov 12, 2018 at 3:42 PM Jakub Jelinek wrote: > Ok, so I'll ack it for trunk now, but please give the other Fortran > maintainers one day to disagree before committing. > For the release branches, I'd wait two weeks or so before backporting it. > Roger that. I'll happily give it some time.

Re: [PATCH] Fortran include line fixes and -fdec-include support

2018-11-12 Thread Fritz Reese
On Mon, Nov 12, 2018 at 9:51 AM Jakub Jelinek wrote: > > In fortran97.pdf I read: > "Except in a character context, blanks are insignificant and may be used > freely throughout the program." > and while we handle that in most cases, we don't allow spaces in INCLUDE > lines in fixed form, while e.

[PATCH, Fortran] New flag -finit-derived to initialize components of derived types

2016-08-04 Thread Fritz Reese
questions or comments. Bootstraps and passes all tests (including the several shipped with it) on x86_64-redhat-linux. If it is ok for trunk I will commit. --- Fritz Reese 2016-08-04 Fritz Reese gcc/fortran/ * lang.opt, invoke.texi: New flag -finit-derived. * gfortran.h

Ping! Re: [PATCH, Fortran] New flag -finit-derived to initialize components of derived types

2016-08-12 Thread Fritz Reese
https://gcc.gnu.org/ml/fortran/2016-08/msg00014.html On Thu, Aug 4, 2016 at 2:07 PM, Fritz Reese wrote: > ... > To increase usability and compatibility I have thus a patch which > introduces a new flag -finit-derived into GNU Fortran, allowing > initialization of automatic deri

[PATCH, Fortran] Extension: AUTOMATIC/STATIC symbol attributes with -fdec-static

2016-08-17 Thread Fritz Reese
strange consequences in the first place. Furthermore, I have found empirically that other compilers which accept the combination syntactically still specify in documentation that the combination is illegal, and the implementation is unpredictable. So AUTOMATIC + EQUIVALENCE seems like something to be

Re: [PATCH, Fortran] Extension: AUTOMATIC/STATIC symbol attributes with -fdec-static

2016-08-17 Thread Fritz Reese
https://gcc.gnu.org/ml/fortran/2016-08/msg00077.html Minor correction to the previously submitted patch: On Wed, Aug 17, 2016 at 7:20 AM, Fritz Reese wrote: > ... > Note that AUTOMATIC does NOT override -fno-automatic; with the flag, a > warning is produced for variables marked

[committed] Re: Bug in DEC UNION/STRUCT patch

2016-08-23 Thread Fritz Reese
gt; anonymous = true; > > Is the second ISUPPER suppose to have cmp2->name[1]? > > -- > Steve This above is pretty clearly a typo. The attached patch committed as obvious r239706. --- Fritz Reese 2016-08-23 Fritz Reese gcc/fortran/ * interface.c (compare_

[committed] Fix for multiple anonymous structures conflict with -fdec-structure

2016-08-23 Thread Fritz Reese
attached as obvious as r239709 - includes testcase exhibiting the regression. --- Fritz Reese 2016-08-23 Fritz Reese gcc/fortran/ * decl.c (gfc_match_structure_decl): Make gfc_structure_id static. gcc/testsuite/gfortran.dg/ * dec_structure_12.f90: New testcase

Re: [committed] Re: Bug in DEC UNION/STRUCT patch

2016-08-23 Thread Fritz Reese
ms to be harder to exhibit this issue than I would've thought. I'm finding myself reconsidering this piece of the original patch and its implications. In related news, I found and fixed another bug while attempting to exhibit this bug: https://gcc.gnu.org/ml/fortran/2016-08/msg00126.html --- Fritz Reese

Re: Ping! Re: [PATCH, Fortran] New flag -finit-derived to initialize components of derived types

2016-08-23 Thread Fritz Reese
e delay, and > thanks for thinking of our release notes. > > Let me know if you need any help. I would be happy to document my new flags (I have added several) in upcoming release notes or applicable documents - however I do not know where or how. --- Fritz Reese

[PATCH, Fortran] Fix compare logic for anonymous structure types

2016-08-24 Thread Fritz Reese
lly don't know how to exhibit PR 77327 in a DejaGNU testcase, since it is a normally-silent heap-use-after-free which was only found with a memory checker. I would appreciate any advice on this matter so I can include a testcase for it with this commit. --- Fritz Reese diff --git a/gcc/fort

Re: [PATCH, Fortran] Fix compare logic for anonymous structure types

2016-08-24 Thread Fritz Reese
https://gcc.gnu.org/ml/fortran/2016-08/msg00144.html On Wed, Aug 24, 2016 at 5:14 PM, Fritz Reese wrote: > With a few recent notes by others, I have identified that the > comparison logic I used in interface.c (compare_components, > gfc_compare_derived_types) was faulty in a few wa

Re: [PATCH] PR fortran/77372

2016-08-26 Thread Fritz Reese
On Thu, Aug 25, 2016 at 6:13 PM, Steve Kargl wrote: > I plan to commit the following patch on Saturday if > no one objects in the next 40 or so hours. > > 2016-08-25 Steven G. Kargl > > PR fortran/77372 > simplify.c (simplify_ieee_selected_real_kind): Check for NULL > pointers.

[committed] Re: [PATCH, Fortran] Fix compare logic for anonymous structure types

2016-08-29 Thread Fritz Reese
https://gcc.gnu.org/ml/fortran/2016-08/msg00145.html On Wed, Aug 24, 2016 at 5:32 PM, Fritz Reese wrote: > https://gcc.gnu.org/ml/fortran/2016-08/msg00144.html > > On Wed, Aug 24, 2016 at 5:14 PM, Fritz Reese wrote: >> With a few recent notes by others, I have identified that th

Ping! Re: [PATCH, Fortran] Extension: AUTOMATIC/STATIC symbol attributes with -fdec-static

2016-08-29 Thread Fritz Reese
https://gcc.gnu.org/ml/fortran/2016-08/msg00077.html On Wed, Aug 17, 2016 at 7:20 AM, Fritz Reese wrote: > This patch extends the GNU Fortran front-end to add support for > DEC-style AUTOMATIC and STATIC symbol attributes with a new flag > -fdec-static, allowing explicit control of

[committed] Small documentation fix to STRUCTURE

2016-08-30 Thread Fritz Reese
=== --- gcc/fortran/ChangeLog (revision 239861) +++ gcc/fortran/ChangeLog (working copy) @@ -1,3 +1,7 @@ +2016-08-30 Fritz Reese + + * gfortran.texi: Fix typo in STRUCTURE documentation. + 2016-08-29 Fritz Reese Fix, reorganize, and clarify comparisons of anonymous types/components. --- Fritz Reese

Ping**2! Re: [PATCH, Fortran] Extension: AUTOMATIC/STATIC symbol attributes with -fdec-static

2016-09-05 Thread Fritz Reese
https://gcc.gnu.org/ml/fortran/2016-08/msg00173.html On Mon, Aug 29, 2016 at 8:36 AM, Fritz Reese wrote: > > https://gcc.gnu.org/ml/fortran/2016-08/msg00077.html > On Wed, Aug 17, 2016 at 7:20 AM, Fritz Reese wrote: > > This patch extends the GNU Fortran front-end to add supp

Re: Ping**2! Re: [PATCH, Fortran] Extension: AUTOMATIC/STATIC symbol attributes with -fdec-static

2016-09-07 Thread Fritz Reese
@ -7856,7 +7858,7 @@ gfc_match_automatic (void) if (!seen_symbol) { - gfc_error ("Expected var-list in AUTOMATIC statement at %C"); + gfc_error ("Expected entity-list in AUTOMATIC statement at %C"); return MATCH_ERROR; } ... And similar for gfc_match

[PATCH, Fortran] PR71523 - Static variables given automatic initializers with -finit-* and -fmax-stack-var-size

2016-06-13 Thread Fritz Reese
RE: https://gcc.gnu.org/ml/fortran/2016-06/msg00023.html On Thu, Jun 9, 2016 at 2:01 PM, Fritz Reese wrote: > It looks like when -fautomatic and -finit-local-zero are set with > -fmax-stack-var-size=X, an automatic initializer is generated even for > variables larger than X which

[PATCH, Fortran, committed] PR82511: ICE Bad IO basetype (12) on attempted read or write of entire DEC structure

2017-10-16 Thread Fritz Reese
type variable, thus recursing into its final components (across all of its MAPs). --- Fritz Reese From 89ed92f0127b61bc802e43c8f3125f48540d7c27 Mon Sep 17 00:00:00 2001 From: Fritz Reese Date: Mon, 16 Oct 2017 13:27:28 -0400 Subject: [PATCH] Treat UNION components as DT comp. in I/O lists. PR

[PATCH, Fortran] Correctly set -fd-lines-as-comments with -fdec

2017-07-31 Thread Fritz Reese
behavior to work as intended. Any objections for trunk? If not I think it is safe to commit. --- Fritz Reese >From e2761d73e818a5095bcc130ddbafe27022e25ba6 Mon Sep 17 00:00:00 2001 From: Fritz Reese Date: Mon, 31 Jul 2017 12:46:10 -0400 Subject: [PATCH] Correctly set -fd-lines-as-comments with -f

[PATCH, Fortran] Slight cleanup in set_dec_flags

2017-07-31 Thread Fritz Reese
to ensure they are only set with value != 0 is appropriate for clarity and correctness. I plan to commit to trunk soon if there no objections since the patch is trivial and does not effectively change compiler behavior at present. --- Fritz Reese >From 805b4909deb450216c1dc522d834173455bac

[PATCH, Fortran] Support for legacy %FILL fields in STRUCTUREs

2017-07-31 Thread Fritz Reese
e match is performed during parsing in decl.c (variable_decl) by generating a component with an internal anonymous name which is an invalid Fortran identifier to replace any components specified as '%FILL'. Regtests on x86_64-redhat-linux. OK for trunk? ---

Re: [PATCH, Fortran] Correctly set -fd-lines-as-comments with -fdec

2017-08-10 Thread Fritz Reese
Yes I did. Committed, thanks. --- Fritz Reese On Tue, Aug 1, 2017 at 11:11 AM, Thomas Koenig wrote: > Hi Fritz, > >> This is a simple patch. The original intent was for -fdec to set >> -fd-lines-as-comments by default if flag_d_lines was unspecified by >> the

Re: [PATCH, Fortran] Support for legacy %FILL fields in STRUCTUREs

2017-08-10 Thread Fritz Reese
I find them strange too... But as you say, they are needed for old code, and some such code bases are quite large and/or have uncooperative users or maintainers. Committed with %qs throughout, thanks for review. --- Fritz Reese On Tue, Aug 1, 2017 at 11:29 AM, Thomas Koenig wrote: > Hi Fr

[PATCH, Fortran] PR 80668: wrong error message with -finit-derived

2017-05-09 Thread Fritz Reese
\].ubound - parm...dim\\[0\\].lbound\\) \\+ 1, 0> \\* \\(3 - parm...dim\\[1\\].lbound\\), 0, &ii, 0B, 0\\);" 1 FAIL: gfortran.dg/mvbits_7.f90 -O0 (test for warnings, line 28) OK for trunk? --- Fritz Reese 2017-05-09 Fritz Reese PR fortran/80668 gcc/fortran/ChangeLog:

Re: [PATCH, Fortran] PR 80668: wrong error message with -finit-derived

2017-05-09 Thread Fritz Reese
’. (2) Sorry, the comments were meant to show the error that would appear if the testcase is regressed; i.e., the error that appeared in the original PR report. If it is too esoteric I can just remove the comments. Version 2 attached. OK? --- Fritz Reese 2017-05-09 Fritz Reese PR fortr

[PATCH, Fortran] PR 79968: merge similar diagnostics containing -fdec-structure

2017-05-17 Thread Fritz Reese
(Nb. even with the change in diagnostics, the applicable testcases (dec_io_3.f90 and dec_static_3.f90) are not regressed as they match only the "is a DEC extension" portion of the error message.) --- Fritz Reese 2017-05-17 Fritz Reese PR fortran/79968 gcc/fortran/ChangeLog:

Re: [Patch, Fortran] Test for implied sequence in structures in common blocks

2016-09-13 Thread Fritz Reese
hrough the weekend or so to see if any official maintainers have a comment otherwise I wouldn't mind committing it as trivial. --- Fritz Reese On Tue, Sep 13, 2016 at 9:51 AM, Jim MacArthur wrote: > Hi, I'd like to contribute this small test. I have legacy code which uses > STRUCTURE s

Re: [Patch, Fortran] Test for implied sequence in structures in common blocks

2016-09-14 Thread Fritz Reese
Committed revision 240134. --- Fritz Reese On Tue, Sep 13, 2016 at 10:52 AM, Jerry DeLisle wrote: > On 09/13/2016 07:33 AM, Fritz Reese wrote: >> >> Jim, >> >> While the test exhibits no particular regression, IMVHO I don't see >> any reason not to add it.

Ping**3! Re: [PATCH, Fortran] Extension: AUTOMATIC/STATIC symbol attributes with -fdec-static

2016-09-23 Thread Fritz Reese
https://gcc.gnu.org/ml/fortran/2016-08/msg00077.html On Wed, Aug 17, 2016 at 7:20 AM, Fritz Reese wrote: > This patch extends the GNU Fortran front-end to add support for > DEC-style AUTOMATIC and STATIC symbol attributes with a new flag > -fdec-static, allowing explicit control of

Re: Ping**3! Re: [PATCH, Fortran] Extension: AUTOMATIC/STATIC symbol attributes with -fdec-static

2016-09-23 Thread Fritz Reese
Many thanks. :) Committed revision 240458. Next extension coming soon On Fri, Sep 23, 2016 at 3:15 PM Jerry DeLisle wrote: > > On 09/23/2016 06:17 AM, Fritz Reese wrote: > > https://gcc.gnu.org/ml/fortran/2016-08/msg00077.html > > On Wed, Aug 17, 2016 at 7:20 AM,

[PATCH, Fortran] Extension: COTAN and degree-valued trig intrinsics with -fdec-math

2016-09-26 Thread Fritz Reese
very welcome. Barring any, is this OK for trunk? --- Fritz Reese 2016-09-26 Fritz Reese New flag -fdec-math for COTAN and degree trig intrinsics. gcc/fortran/ * lang.opt: New flag -fdec-math. * options.c (set_dec_flags): Enable with -fdec. * invoke.texi, gfor

Re: [PATCH, Fortran] Extension: COTAN and degree-valued trig intrinsics with -fdec-math

2016-09-27 Thread Fritz Reese
Tobias, Many thanks for the comments. I will adjust the patch according to your advice shortly. - Fritz On Mon, Sep 26, 2016, 11:59 Tobias Burnus wrote: > > Fritz Reese wrote: > > Attached is a patch extending the GNU Fortran front-end to support > > some additional math i

[PATCH, Fortran] PR fortran/77782 - ICE in gfc_get_union_type

2016-09-29 Thread Fritz Reese
UNION to be considered equal to a STRUCTURE, thus the union receives the structure's backend declaration. Obviously everything goes haywire from there. Attached is the [obvious] fix. Will commit to trunk soon, barring any concerns from others. --- Fritz Reese [1] https://gcc.gnu.org/bug

[PATCH, Fortran] PR fortran/77764 - ICE in is_anonymous_component

2016-09-29 Thread Fritz Reese
ICE in [1] is due to failure to null-guard map components in gfc_compare_union_types. Attached is [obvious] fix - will commit soon without complaints. --- Fritz Reese [1] https://gcc.gnu.org/bugzilla/show_bug.cgi?id=77764 2016-09-29 Fritz Reese Fix ICE for maps with zero components

[PATCH, Fortran] Fix ICE due to comparison between UNION components

2016-10-02 Thread Fritz Reese
. Will commit soon with no complaints. Maybe this patch will finally get type comparison right for unions. --- Fritz Reese 2016-10-02 Fritz Reese Fix ICE due to comparison between UNION components. * gcc/fortran/interface.c (gfc_compare_types): Don't compare BT_

Re: [PATCH, Fortran] Fix ICE due to comparison between UNION components

2016-10-03 Thread Fritz Reese
On Sun, Oct 2, 2016 at 6:27 PM, Fritz Reese wrote: > All, > > The attached fixes an[other] ICE in the comparison between UNIONs. > This time the ICE is due to a BT_UNION component comparing itself to a > BT_DERIVED component, thus considering their FL_STRUCT and FL_UNION > typ

Fix ICE due to map typespecs with different sized charlens being copied

2016-10-05 Thread Fritz Reese
ding the new if statement to only run for union/structure types. But with all my tests it doesn't seem to result in any concrete differences. The patch does pass all regression tests on x86_64-redhat-linux. I will give it a couple days for the RFC before committing. --- Fritz Reese 201

Re: [PATCH, libgfortran] PR 67585 Handle EINTR

2016-10-07 Thread Fritz Reese
EINTR after the read call, e.g. to terminate nicely with "non async-safe" calls like printf that couldn't be done in the handler. This is discussed as "use case 2" in the PEP you referenced. Python handles this case by explicitly calling user defined signal handlers directly after EINTR and checking the return value from the handler, only trying again if the handler reports success. Not so simple I think with libgfortran. --- Fritz Reese

PING! Re: [PATCH, Fortran] Extension: COTAN and degree-valued trig intrinsics with -fdec-math

2016-10-10 Thread Fritz Reese
https://gcc.gnu.org/ml/fortran/2016-09/msg00163.html [original] https://gcc.gnu.org/ml/fortran/2016-09/msg00183.html [latest] On Wed, Sep 28, 2016 at 4:14 PM, Fritz Reese wrote: > Attached is a patch extending the GNU Fortran front-end to support > some additional math intrinsics, enabled

Re: PING! Re: [PATCH, Fortran] Extension: COTAN and degree-valued trig intrinsics with -fdec-math

2016-10-11 Thread Fritz Reese
mpfr_div_ui (factor->value.real, factor->value.real, 180, GFC_RND_MODE); > ... Good catch, fixed and committed r240989. Many thanks to you and Jerry. --- Fritz Reese

Re: PING! Re: [PATCH, Fortran] Extension: COTAN and degree-valued trig intrinsics with -fdec-math

2016-10-11 Thread Fritz Reese
On Mon, 2016-10-11 08:43 AM, Markus Trippelsdorf wrote: > This patch breaks bootstrap: ... Sorry all!! was in a rush to get in the car this morning and made a hasty commit. Fixed for r241001 (sorry Jerry, I was a little too slow.) --- Fritz Reese

Re: PING! Re: [PATCH, Fortran] Extension: COTAN and degree-valued trig intrinsics with -fdec-math

2016-10-11 Thread Fritz Reese
On Tue, Oct 11, 2016 at 2:44 PM, Fritz Reese wrote: > On Mon, 2016-10-11 08:43 AM, Markus Trippelsdorf > wrote: >> This patch breaks bootstrap: > ... > > Sorry all!! was in a rush to get in the car this morning and made a > hasty commit. Fixed for r241001 (sorry Jerry, I

Re: [PATCH] Fix formatting of the -fdec-math changes

2016-10-11 Thread Fritz Reese
On Tue, Oct 11, 2016 at 3:00 PM, Jakub Jelinek wrote: > On Tue, Oct 11, 2016 at 02:47:34PM -0400, Fritz Reese wrote: >> On Tue, Oct 11, 2016 at 2:44 PM, Fritz Reese wrote: >> > On Mon, 2016-10-11 08:43 AM, Markus Trippelsdorf >> > wrote: >&g

[PATCH, Fortran] Four small DEC extensions

2016-10-12 Thread Fritz Reese
using the LOC() intrinsic. 4. [-fdec-logical-xor] Enable .XOR. as a logical operator. Feel free to comment on/question/approve each patch individually as desired. They are attached as sequential patch files for ease of review. Bootstraps & regtests on x86_64-redhat- linux. OK for trunk? --- F

Re: [PATCH, Fortran] Four small DEC extensions

2016-10-24 Thread Fritz Reese
https://gcc.gnu.org/ml/fortran/2016-10/msg00087.html et. al. > On 12/10/16 13:30, Fritz Reese wrote: >> Here I submit for review four small extensions to the GNU Fortran >> frontend for compatibility with legacy code. I figure it might be a >> nice change of pace from my large

Re: PING! Re: [PATCH, Fortran] Extension: COTAN and degree-valued trig intrinsics with -fdec-math

2016-10-25 Thread Fritz Reese
On Tue, Oct 25, 2016 at 11:37 AM Cesar Philippidis wrote: > > On 10/10/2016 08:06 AM, Fritz Reese wrote: > > > --- a/gcc/fortran/intrinsic.texi > > +++ b/gcc/fortran/intrinsic.texi > > @@ -23,6 +23,9 @@ Some basic guidelines for editing this document: > > @en

Re: [PATCH, Fortran] Four small DEC extensions

2016-10-25 Thread Fritz Reese
On Mon, Oct 24, 2016 at 10:47 PM, Jerry DeLisle wrote: > On 10/24/2016 07:23 AM, Fritz Reese wrote: >> >> https://gcc.gnu.org/ml/fortran/2016-10/msg00087.html et. al. >>> >>> On 12/10/16 13:30, Fritz Reese wrote: >>>> >>>> Here I s

Re: [PATCH, Fortran] Four small DEC extensions

2016-10-25 Thread Fritz Reese
On Tue, Oct 25, 2016 at 11:46 AM, Fritz Reese wrote: ... > Committed r241516, r241517, r241518, r241519. ... and r241520. --- Fritz Reese

[PATCH, Fortran] Fix initialization of UNIONs with -finit-derived

2016-10-25 Thread Fritz Reese
ifies that explicit user-given initializers are not regressed with the implementation. Since this only touches my own UNION and -finit-derived code I aim to commit it in a few days if nobody finds anything wrong with the patch. Bootstraps and regtests on x86_64-redhat-linux. --- Fritz Reese

[PATCH, Fortran] DEC Compatibility: Logical operations on integers become bitwise ops with -fdec

2016-10-25 Thread Fritz Reese
y, but if anyone has a different opinion I can certainly do this with -std=legacy instead of -fdec. Bootstraps and regtests on x86_64-redhat-linux, OK for trunk? --- Fritz Reese From: Fritz Reese Date: Mon, 24 Oct 2016 13:47:38 -0400 Subject: [PATCH] Logical operations on integers become bitw

[PATCH, Fortran] DEC Compatibility: New I/O Specifiers CARRIAGECONTROL, READONLY, SHARE with -fdec

2016-10-25 Thread Fritz Reese
ROL='FORTRAN'. These two bytes still leave plenty of trailing 'pad' for future expansion. Bootstraps and regtests on x86_64-redhat-linux. There's a fair bit to sift through, so feel free to ask for clarification or provide comments/constructive criticism. OK for trunk? --- F

Re: [PATCH, Fortran] DEC Compatibility: New I/O Specifiers CARRIAGECONTROL, READONLY, SHARE with -fdec

2016-10-25 Thread Fritz Reese
On Tue, Oct 25, 2016 at 5:29 PM, Jerry DeLisle wrote: > On 10/25/2016 11:52 AM, Fritz Reese wrote: >> >> All, >> >> Here's the big one. This patch proposes an extension to both the GNU >> Fortran front-end and runtime library (libgfortran) to supp

Re: [PATCH, Fortran] DEC Compatibility: New I/O Specifiers CARRIAGECONTROL, READONLY, SHARE with -fdec

2016-10-26 Thread Fritz Reese
On Tue, Oct 25, 2016 at 11:36 PM, Jerry DeLisle wrote: > On 10/25/2016 11:52 AM, Fritz Reese wrote: >> >> All, >> >> Here's the big one. This patch proposes an extension to both the GNU >> Fortran front-end and runtime library (libgfortran) to supp

Re: [PATCH, Fortran] DEC Compatibility: Logical operations on integers become bitwise ops with -fdec

2016-10-26 Thread Fritz Reese
On Wed, Oct 26, 2016 at 6:16 AM, Andreas Schwab wrote: > On Okt 25 2016, Fritz Reese wrote: > >> * dec_bitwise_ops_1.f90, dec_bitwise_ops_2.f90: New testcases. > > I'm getting these errors on ia64: > > FAIL: gfortran.dg/dec_bitwise_ops_1.f90 -O0 (tes

Re: [PATCH, Fortran] DEC Compatibility: Logical operations on integers become bitwise ops with -fdec

2016-10-26 Thread Fritz Reese
On Wed, Oct 26, 2016 at 6:16 AM, Andreas Schwab wrote: > On Okt 25 2016, Fritz Reese wrote: > >> * dec_bitwise_ops_1.f90, dec_bitwise_ops_2.f90: New testcases. > > I'm getting these errors on ia64: > > FAIL: gfortran.dg/dec_bitwise_ops_1.f90 -O0 (tes

[PATCH, Fortran] DEC Compatibility: Default missing exponents to 0 with -fdec

2016-10-26 Thread Fritz Reese
be backwards-compatible (by design of the IOPARM structures/flags). Bootstraps and regtests on x86_64-redhat-linux. OK for trunk? --- Fritz Reese From: Fritz Reese Date: Wed, 5 Oct 2016 18:27:56 -0400 Subject: [PATCH] Default missing exponents to 0 with -fdec. gcc/fortran/ * gfort

Re: [PATCH, Fortran] DEC Compatibility: Logical operations on integers become bitwise ops with -fdec

2016-10-26 Thread Fritz Reese
On Wed, Oct 26, 2016 at 10:32 AM, Andreas Schwab wrote: > On Okt 26 2016, Fritz Reese wrote: > >> I can't seem to reproduce this on x86-64. Did you fully apply the >> patch? > > I don't have any patches. > Sorry for the confusion, I meant the originally att

Re: [PATCH, Fortran] DEC Compatibility: New I/O Specifiers CARRIAGECONTROL, READONLY, SHARE with -fdec

2016-10-27 Thread Fritz Reese
On Thu, Oct 27, 2016 at 7:02 AM Andreas Schwab wrote: ... > At line 12 of file > /usr/local/gcc/gcc-20161027/gcc/testsuite/gfortran.dg/dec_io_6.f90 (unit = 8) > Fortran runtime error: Cannot open file 'test.txt': No such file or directory > Indeed. From: Fritz Reese Dat

Re: [PATCH, Fortran] DEC Compatibility: New I/O Specifiers CARRIAGECONTROL, READONLY, SHARE with -fdec

2016-10-27 Thread Fritz Reese
On Thu, Oct 27, 2016 at 7:32 AM, Jakub Jelinek wrote: > On Thu, Oct 27, 2016 at 07:25:24AM -0400, Fritz Reese wrote: >> On Thu, Oct 27, 2016 at 7:02 AM Andreas Schwab wrote: >> ... >> > At line 12 of file >> > /usr/local/gcc/gcc-20161027/gcc/testsuite/gfortra

Re: [PATCH, Fortran] DEC Compatibility: Logical operations on integers become bitwise ops with -fdec

2016-10-27 Thread Fritz Reese
How odd. Good catch. --- Fritz Reese On Thu, Oct 27, 2016 at 4:41 AM, Andreas Schwab wrote: > I have filed PR78128, this may be a target bug. > > Andreas. > > -- > Andreas Schwab, SUSE Labs, sch...@suse.de > GPG Key fingerprint = 0196 BAD8 1CE9 1970 F4BE 1748 E4D4 88E3 0EE

Re: [PATCH, Fortran] DEC Compatibility: New I/O Specifiers CARRIAGECONTROL, READONLY, SHARE with -fdec

2016-10-27 Thread Fritz Reese
On Thu, Oct 27, 2016 at 8:16 AM, Jakub Jelinek wrote: > On Thu, Oct 27, 2016 at 07:46:16AM -0400, Fritz Reese wrote: >> > Shouldn't something also remove dec_io_5.txt file if it is created? >> > Shall the (now xfailed, so not implemented yet?) runtime error terminate &

Re: [PATCH, Fortran] DEC Compatibility: New I/O Specifiers CARRIAGECONTROL, READONLY, SHARE with -fdec

2016-10-27 Thread Fritz Reese
On Thu, Oct 27, 2016 at 8:49 AM, Fritz Reese wrote: > From: Fritz Reese > Date: Thu, 27 Oct 2016 08:46:33 -0400 > Subject: [PATCH] Fix some DEC I/O testcases. > > gcc/testsuite/gfortran.dg/ > * dec_io_5.f90: Rename 'test.txt' to 'dec_io_5.tx

  1   2   >