Re: [PATCH] Cleanup: Replace UNSPEC_COPYSIGN with copysign RTL

2023-09-29 Thread David Edelsohn
On Fri, Sep 29, 2023 at 2:09 PM Michael Meissner wrote: > When I first implemented COPYSIGN support in the power7 days, we did not > have a > copysign RTL insn, so I had to use UNSPEC to represent the copysign > instruction. This patch removes those UNSPECs, and it uses the native RTL > copysign

Re: Ping^2 [PATCH V5 1/4] rs6000: build constant via li;rotldi

2023-09-30 Thread David Edelsohn
On Mon, Sep 25, 2023 at 10:52 PM Jiufu Guo wrote: > Hi, > > Gentle ping... > > BR, > Jeff (Jiufu Guo) > This is okay. Thanks, David > > Jiufu Guo via Gcc-patches writes: > > > Hi, > > > > Gentle ping... > > > > BR, > > Jeff (Jiufu Guo) > > > > Jiufu Guo writes: > > > >> Hi, > >> > >> If a c

Re: [PATCH v3] RISC-V:Optimize the MASK opt generation

2023-10-02 Thread David Edelsohn
Wang, The AWK portions of this patch broke bootstrap on AIX. Also, the AWK portions are common code, not RISC-V specific. I don't see anywhere that the common portions of the patch were reviewed or approved by anyone with authority to approve the changes to the AWK files. This patch should not

Re: [PATCH v3] RISC-V:Optimize the MASK opt generation

2023-10-02 Thread David Edelsohn
On Mon, Oct 2, 2023 at 1:59 PM Jeff Law wrote: > > > On 10/2/23 11:20, David Edelsohn wrote: > > Wang, > > > > The AWK portions of this patch broke bootstrap on AIX. > > > > Also, the AWK portions are common code, not RISC-V specific. I don't >

Re: [PATCH v3] RISC-V:Optimize the MASK opt generation

2023-10-03 Thread David Edelsohn
ode) on my linux also some other report it work on freebsd, just wait > review :) > > https://gcc.gnu.org/pipermail/gcc-patches/2023-October/631785.html > > On Tue, Oct 3, 2023 at 2:07 AM Jeff Law wrote: > > > > > > > > On 10/2/23 12:03, Da

Re: [PATCH] rs6000: Make 32 bit stack_protect support prefixed insn [PR111367]

2023-10-03 Thread David Edelsohn
On Wed, Sep 27, 2023 at 1:38 AM Kewen.Lin wrote: > Hi, > > As PR111367 shows, with prefixed insn supported, some of > checkings consider it's able to leverage prefixed insn > for stack protect related load/store, but since we don't > actually change the emitted assembly for 32 bit, it can > cause

Re: [COMMITTED] Return TRUE only when a global value is updated.

2023-10-03 Thread David Edelsohn
This patch caused a bootstrap failure on AIX. during GIMPLE pass: evrp /nasfarm/edelsohn/src/src/libgcc/libgcc2.c: In function '__gcc_bcmp': /nasfarm/edelsohn/src/src/libgcc/libgcc2.c:2910:1: internal compiler error: in get_irange, at value-range-storage.cc:343 2910 | } | ^ 0x11b7f4b7

Re: [COMMITTED] Return TRUE only when a global value is updated.

2023-10-03 Thread David Edelsohn
NAMES handle > pointer ranges different. > > Andrew > > On 10/3/23 11:47, David Edelsohn wrote: > > This patch caused a bootstrap failure on AIX. > > > > during GIMPLE pass: evrp > > > > /nasfarm/edelsohn/src/src/libgcc/libgcc2.c: In function '__gcc_bc

Re: [PATCH v2] Add a GCC Security policy

2023-10-04 Thread David Edelsohn
Hi, Siddhesh Thanks for working on this and fine-tuning the original proposed text. It looks good to me. Minor grammatical nit below. Thanks, David On Thu, Sep 28, 2023 at 7:59 AM Siddhesh Poyarekar wrote: > On 2023-09-28 12:55, Siddhesh Poyarekar wrote: > > Define a security process and exc

Re: [PATCH V5 1/2] rs6000: optimize moving to sf from highpart di

2023-10-05 Thread David Edelsohn
On Thu, Oct 5, 2023 at 12:50 AM Jiufu Guo wrote: > Hi, > > Currently, we have the pattern "movsf_from_si2" which was trying > to support moving high part DI to SF. > > But current pattern only accepts "ashiftrt": > XX:SF=bitcast:SF(subreg(YY:DI>>32),0), but actually "lshiftrt" should > also be ok

Re: [PATCH V5 2/2] rs6000: use mtvsrws to move sf from si p9

2023-10-05 Thread David Edelsohn
On Thu, Oct 5, 2023 at 12:14 AM Jiufu Guo wrote: > Hi, > > As mentioned in PR108338, on p9, we could use mtvsrws to implement > the bitcast from SI to SF (or lowpart DI to SF). > > For example: > *(long long*)buff = di; > float f = *(float*)(buff); > > "sldi 9,3,32 ; mtvsrd 1,9 ; xscvspdpn 1,

Re: [PATCH-2, rs6000] Enable vector mode for memory equality compare [PR111449]

2023-10-09 Thread David Edelsohn
On Sun, Oct 8, 2023 at 10:30 PM HAO CHEN GUI wrote: > Hi, > This patch enables vector mode for memory equality compare by adding > a new expand cbranchv16qi4 and implementing it. Also the corresponding > CC reg and compare code is set in rs6000_generate_compare. With the > patch, 16-byte equali

Re: [PATCH-2, rs6000] Enable vector mode for memory equality compare [PR111449]

2023-10-10 Thread David Edelsohn
On Tue, Oct 10, 2023 at 4:23 AM HAO CHEN GUI wrote: > Hi David, > > Thanks for your review comments. > > 在 2023/10/9 23:42, David Edelsohn 写道: > > #define MOVE_MAX (! TARGET_POWERPC64 ? 4 : 8) > > #define MAX_MOVE_MAX 8 > > +#define MOVE_MAX_P

Re: [PATCH] early outs for functions in rs6000.cc

2023-10-11 Thread David Edelsohn
On Tue, Oct 10, 2023 at 9:29 PM Jiufu Guo wrote: > Hi, > > There are some piece of code like below in rs6000.cc: > > ... > if (xx) >return x; > else if (yy) >return y; > ... //else if chain > else >return d; > > Using early outs would be more preferable for this kind of code. >

Re: [PATCH] PR target/111778 - Fix undefined shifts in PowerPC compiler

2023-10-12 Thread David Edelsohn
On Thu, Oct 12, 2023 at 4:24 AM Michael Meissner wrote: > I was building a cross compiler to PowerPC on my x86_86 workstation with > the > latest version of GCC on October 11th. I could not build the compiler on > the > x86_64 system as it died in building libgcc. I looked into it, and I > disc

Re: [PATCH v2] swap: Fix incorrect lane extraction by vec_extract() [PR106770]

2023-10-18 Thread David Edelsohn
Hi, Surya Thanks for working on this issue and creating a patch. It helps if you explicitly send patches to Segher and me, and copy gcc-patches. +/* Return true if insn is a non-permuting load/store. */ +static bool +non_permuting_mem_insn (swap_web_entry *insn_entry, unsigned int i) +{ + retu

Re: [PATCH v2] swap: Fix incorrect lane extraction by vec_extract() [PR106770]

2023-10-18 Thread David Edelsohn
[Resending from correct email.] Hi, Surya Thanks for working on this issue and creating a patch. It helps if you explicitly send patches to Segher and me, and copy gcc-patches. +/* Return true if insn is a non-permuting load/store. */ +static bool +non_permuting_mem_insn (swap_web_entry *insn_

Re: [PATCH, rs6000] Fix AIX test case failures

2018-07-13 Thread David Edelsohn
On Mon, Jun 25, 2018 at 1:04 PM Segher Boessenkool wrote: > > On Mon, Jun 25, 2018 at 09:53:17AM -0700, Carl Love wrote: > > On Mon, 2018-06-25 at 04:44 -0500, Segher Boessenkool wrote: > > > On Fri, Jun 22, 2018 at 02:55:44PM -0700, Carl Love wrote: > > > > --- a/gcc/testsuite/gcc.target/powerpc/

Re: [PATCH, rs6000] Fix AIX test case failures

2018-07-13 Thread David Edelsohn
On Fri, Jul 13, 2018 at 7:15 PM Carl Love wrote: > > On Fri, 2018-07-13 at 16:00 -0500, Segher Boessenkool wrote: > > On Fri, Jul 13, 2018 at 10:51:24AM -0400, David Edelsohn wrote: > > > On AIX it would be calling divtc3, but AIX defaults to 64 bit long > > > doub

[PATCH, testsuite] Restrict some PPC tests

2018-07-17 Thread David Edelsohn
Two of the powerpc testcases have additional requirements. Fixed thus. Thanks, David * gcc.target/powerpc/pr57150.c: Require longdouble128. * gcc.target/powerpc/pr79916.c: Require dfp. Index: pr79916.c === --- pr79916.c (revision

[PATCH, testsuite] PPC testsuite pr85456.c

2018-07-17 Thread David Edelsohn
And another test that needs to be restricted because it assumes 128 bit long double. Thanks, David * gcc.target/powerpc/pr85456.c: Require longdouble128. Index: pr85456.c === --- pr85456.c (revision 262824) +++ pr85456.c (workin

[PATCH,fixincludes] AIX unistd header

2018-07-23 Thread David Edelsohn
AIX unistd.h defines a static function without a parameter, which justifiably upsets C++ code when the header is included and referenced. This patch to fixincludes adjusts the header to declare the parameter as void. Bootstrapped on powerpc-ibm-aix7.2.0.0 and powerpc64le-linux Thanks, David * in

Re: Build fail on gthr-simple.h targets (Re: AsyncI/O patch committed)

2018-07-26 Thread David Edelsohn
> Ulrich Weigand wrote: > Nicholas Koenig wrote: > >> Hello everyone, >> >> I have committed the async I/O patch as r262978. >> >> The test cases are in libgomp.fortran for now, maybe that can be changed >> later. > > It looks like this broke building libgfortran on spu, and presumably > any p

Re: Build fail on gthr-simple.h targets (Re: AsyncI/O patch committed)

2018-07-27 Thread David Edelsohn
Thomas, Correct, the proposed patch does not fix the build failure on AIX. Please see the information on the GCC Compile Farm wiki page for instructions to bootstrap on gcc119. https://gcc.gnu.org/wiki/CompileFarm#Projects_Ideas - at the bottom of Project ideas. Thanks, David On Fri, Jul 27, 201

Re: [PATCH v3] Control flow redundancy hardening

2023-10-20 Thread David Edelsohn
This patch broke bootstrap on AIX because ASM_GENERATE_INTERNAL_LABEL can embed target-specific functions. Fixed by including tm_p.h. Thanks, David * gimple-harden-control-flow.cc: Include tm_p.h. *diff --git a/gcc/gimple-harden-control-flow.cc b/gcc/gimple-harden-control-flow.cc* *

Re: [PATCH v3] Control flow redundancy hardening

2023-10-20 Thread David Edelsohn
/gimple-harden-control-flow.cc* @@ -23,6 +23,7 @@ along with GCC; see the file COPYING3. If not see #include "system.h" #include "coretypes.h" #include "backend.h" +#include "memmodel.h" #include "tm_p.h" #include "tree.h" #i

Re: [PATCH] PR85678: Change default to -fno-common

2019-10-28 Thread David Edelsohn
>> Has this been bootstrapped and regression tested? > > Yes, it bootstraps OK of course. I ran regression over the weekend, there > are a few minor regressions in lto due to relying on tentative definitions > and a few latent bugs. I'd expect there will be a few similar failures on > other targets

[PATCH] ggc-common.c bootstrap breakage

2019-11-04 Thread David Edelsohn
The change to add malloc.h to ggc-common.c broke bootstrap. system.h must be included before system header files. The following patch fixes this, committed as obvious with concurrence by Richi. Thanks, David * ggc-common.c: Include system.h before malloc.h. Index: ggc-common.c

Re: [RFC c-common PATCH] PR c++/40752 - useless -Wconversion with short +=.

2020-01-24 Thread David Edelsohn
Jason, There is no ChangeLog entry for the testsuite changes. I'm also still trying to determine if Wconversion-pr40752.c requires -fsigned-char option. Thanks, David

Re: [RFC c-common PATCH] PR c++/40752 - useless -Wconversion with short +=.

2020-01-24 Thread David Edelsohn
On Fri, Jan 24, 2020 at 12:00 PM Jason Merrill wrote: > > On 1/24/20 8:45 AM, David Edelsohn wrote: > > There is no ChangeLog entry for the testsuite changes. > > I don't believe in ChangeLog entries for testcases, but I'll add one for > the target-supports.exp cha

Re: SPARC build broken

2019-12-05 Thread David Edelsohn
Sorry. I had to add tm_p.h because Jakub's earlier patch to add output.h to cp-gimplify.c broke AIX. We certainly can add memmodel.h to cp-gimplify.c. Thanks, David On Thu, Dec 5, 2019 at 8:32 AM Joseph Myers wrote: > > The change > > 2019-12-04 David Edelsohn > >

Re: SPARC build broken

2019-12-05 Thread David Edelsohn
Done. r279003. - David On Thu, Dec 5, 2019 at 9:33 AM Jakub Jelinek wrote: > > On Thu, Dec 05, 2019 at 09:25:40AM -0500, David Edelsohn wrote: > > Sorry. I had to add tm_p.h because Jakub's earlier patch to add > > output.h to cp-gimplify.c broke AIX. > > > &

Re: Bountysource campaign for gcc-rust?

2019-12-27 Thread David Edelsohn
> John Paul Adrian Glaubitz wrote: > The programming language Rust has become very popular over the past few years > with many projects rewriting parts of their codebase in that language. While > these rewrites often make the code perform faster and potentially safer, using > Rust makes these

Re: [PATCH] strub: Only unbias stack point for SPARC_STACK_BOUNDARY_HACK [PR113100]

2024-01-17 Thread David Edelsohn
If the fixes remove the failures on AIX, then the patch to disable the tests also can be reverted. Thanks, David On Wed, Jan 17, 2024 at 8:06 PM Alexandre Oliva wrote: > David, > > On Jan 7, 2024, "Kewen.Lin" wrote: > > > As PR113100 shows, the unbiasing introduced by r14-6737 can > > cause

Re: [committed] libstdc++: Implement C++23 header [PR107760]

2023-12-16 Thread David Edelsohn
Hi, Jonathan Unfortunately this patch broke bootstrap on AIX. In file included from /tmp/GCC/gcc/include-fixed/wchar.h:64, from /tmp/GCC/powerpc-ibm-aix7.2.5.0/libstdc++-v3/include/cwchar:44, from /tmp/GCC/powerpc-ibm-aix7.2.5.0/libstdc++-v3/include/bits/postyp

Re: [committed] libstdc++: Implement C++23 header [PR107760]

2023-12-16 Thread David Edelsohn
On Sat, Dec 16, 2023 at 4:44 PM Jakub Jelinek wrote: > On Sat, Dec 16, 2023 at 04:24:13PM -0500, David Edelsohn wrote: > > AIX stdio.h defines fileno as a macro although there is a symbol in libc. > > > > I think that print.cc at least needs to > > > > > &g

Re: [committed] libstdc++: Implement C++23 header [PR107760]

2023-12-16 Thread David Edelsohn
On Sat, Dec 16, 2023 at 7:04 PM Jonathan Wakely wrote: > On Sun, 17 Dec 2023 at 00:02, Jonathan Wakely wrote: > > > > On Sat, 16 Dec 2023 at 23:06, David Edelsohn wrote: > > > > > > On Sat, Dec 16, 2023 at 4:44 PM Jakub Jelinek > wrote: > > >>

Re: [PATCH] libsupc++: try cxa_thread_atexit_impl at runtime

2023-12-05 Thread David Edelsohn
Alex, This patch broke bootstrap on AIX. The stage1 compiler is not able to build a program and stage2 configure fails. Thanks, David

Re: [PATCH] libsupc++: try cxa_thread_atexit_impl at runtime

2023-12-05 Thread David Edelsohn
, 2023 at 11:10 AM David Edelsohn wrote: > Alex, > > This patch broke bootstrap on AIX. The stage1 compiler is not able to > build a program and stage2 configure fails. > > Thanks, David > >

Re: [PATCH v3 0/2] Replace intl/ with out-of-tree GNU gettext

2023-11-14 Thread David Edelsohn
Arsen, Unfortunately this broke bootstrap on AIX. I had not seen this series of patches. David

Re: [PATCH v3 0/2] Replace intl/ with out-of-tree GNU gettext

2023-11-14 Thread David Edelsohn
On Tue, Nov 14, 2023 at 6:09 PM Arsen Arsenović wrote: > Hi David, > > David Edelsohn writes: > > > Arsen, > > > > Unfortunately this broke bootstrap on AIX. > > > > I had not seen this series of patches. > > I've added Bruno to CC as the

Re: [PATCH v3 0/2] Replace intl/ with out-of-tree GNU gettext

2023-11-15 Thread David Edelsohn
On Wed, Nov 15, 2023 at 9:22 AM Arsen Arsenović wrote: > > David Edelsohn writes: > > > GCC had been working on AIX with NLS, using "--with-included-gettext". > > --disable-nls gets past the breakage, but GCC does not build for me on > AIX > > with NLS

Re: building GNU gettext on AIX

2023-11-15 Thread David Edelsohn
id On Wed, Nov 15, 2023 at 7:29 AM Bruno Haible wrote: > [CCing bug-gettext] > > David Edelsohn wrote in > <https://gcc.gnu.org/pipermail/gcc-patches/2023-November/636558.html>: > > The current gettext-0.22.3 fails to build for me on AIX. > > Here are some hints

Re: [PATCH v3 0/2] Replace intl/ with out-of-tree GNU gettext

2023-11-15 Thread David Edelsohn
On Wed, Nov 15, 2023 at 9:22 AM Arsen Arsenović wrote: > > David Edelsohn writes: > > > GCC had been working on AIX with NLS, using "--with-included-gettext". > > --disable-nls gets past the breakage, but GCC does not build for me on > AIX > > with NLS

Re: building GNU gettext on AIX

2023-11-15 Thread David Edelsohn
On Wed, Nov 15, 2023 at 4:22 PM Bruno Haible wrote: > David Edelsohn wrote: > > When I try to configure gettext-0.22.3, I receive the following error: > > > > checking for socklen_t equivalent... configure: error: Cannot find a type > > to use in place of socklen

Re: building GNU gettext on AIX

2023-11-16 Thread David Edelsohn
regression in NLS support in GCC. Thanks, David On Wed, Nov 15, 2023 at 5:39 PM Bruno Haible wrote: > David Edelsohn wrote: > > I am using my own install of GCC for a reason. > > I have built GNU gettext 0.22.3 in various configurations on the AIX 7.1 > and 7.3 machines in the compil

Re: building GNU gettext on AIX

2023-11-16 Thread David Edelsohn
812 D _libintl_setlocale_null_r 824 D _libintl_setlocale_null On Thu, Nov 16, 2023 at 11:00 AM David Edelsohn wrote: > Bruno, > > I have been able to tweak the environment and build gettext and libintl. > With the updated libintl and environment, GCC reliably does

Re: building GNU gettext on AIX

2023-11-16 Thread David Edelsohn
On Thu, Nov 16, 2023 at 11:58 AM Richard Biener wrote: > > > Am 16.11.2023 um 17:00 schrieb David Edelsohn : > >  > Bruno, > > I have been able to tweak the environment and build gettext and libintl. > With the updated libintl and environment, GCC reliably does no

Re: building GNU gettext on AIX

2023-11-16 Thread David Edelsohn
Bruno, The issue appears to be that intl/gnulib-lib/{mbrtowc.c,setlocale_null.c} include pthread.h based on HAVE_PTHREAD_API, which is defined as 1 in intl/config.h build directory despite requesting --disable-pthreads. Thanks, David On Thu, Nov 16, 2023 at 11:35 AM David Edelsohn wrote: >

Re: building GNU gettext on AIX

2023-11-16 Thread David Edelsohn
distributed. Thanks, David On Thu, Nov 16, 2023 at 1:01 PM David Edelsohn wrote: > Bruno, > > The issue appears to be that intl/gnulib-lib/{mbrtowc.c,setlocale_null.c} > include pthread.h based on HAVE_PTHREAD_API, which is defined as 1 in > intl/config.h build directory des

Re: [PATCH v3 0/2] Replace intl/ with out-of-tree GNU gettext

2023-11-16 Thread David Edelsohn
enović > (Gentoo Developer UID) (trust ultimate) created at > 2023-11-16T19:47:16+0100 using EDDSA]] > > > > David Edelsohn writes: > > > >> On Wed, Nov 15, 2023 at 9:22 AM Arsen Arsenović > wrote: > >> > >>> > >>> David Ede

Re: building GNU gettext on AIX

2023-11-16 Thread David Edelsohn
On Thu, Nov 16, 2023 at 1:52 PM Bruno Haible wrote: > David Edelsohn wrote: > > I manually commented out HAVE_PTHREAD_API from config.h and produced a > > libintl.a without references to pthreads. > > Good finding! > > Commenting out HAVE_PTHREAD_API from config.h is a

Re: [PATCH v3 0/2] Replace intl/ with out-of-tree GNU gettext

2023-11-16 Thread David Edelsohn
On Thu, Nov 16, 2023 at 5:22 PM Arsen Arsenović wrote: > > David Edelsohn writes: > > > Don't build with the dependent libraries in tree. Don't build the > > dependent libraries as shared libraries. The libraries are already built > > and in /opt/cfarm,

Re: building GNU gettext on AIX

2023-11-16 Thread David Edelsohn
On Thu, Nov 16, 2023 at 5:47 PM Bruno Haible wrote: > Hi David, > > > the default, distributed libintl library will not allow GCC to be built > > with NLS enabled. > > The problem is this configure test from gettext.m4 > > checking for GNU gettext in libintl... no > > It should say > > checki

Re: [PATCH v3 0/2] Replace intl/ with out-of-tree GNU gettext

2023-11-16 Thread David Edelsohn
On Thu, Nov 16, 2023 at 5:52 PM Arsen Arsenović wrote: > > David Edelsohn writes: > > > On Thu, Nov 16, 2023 at 5:22 PM Arsen Arsenović wrote: > > > >> > >> David Edelsohn writes: > >> > >> > Don't build with the dependent

Re: building GNU gettext on AIX

2023-11-16 Thread David Edelsohn
On Thu, Nov 16, 2023 at 7:07 PM Bruno Haible wrote: > David Edelsohn wrote: > > > ibm-clang links against libpthread.a as well: > > > $ ldd /opt/IBM/openxlC/17.1.1/bin/.ibm-clang.orig > > > /opt/IBM/openxlC/17.1.1/bin/.ibm-clang.orig needs: > &g

Re: [PATCH v3 0/2] Replace intl/ with out-of-tree GNU gettext

2023-11-17 Thread David Edelsohn
On Fri, Nov 17, 2023 at 3:46 AM Arsen Arsenović wrote: > > David Edelsohn writes: > > > On Thu, Nov 16, 2023 at 5:52 PM Arsen Arsenović wrote: > > > > [snip] > >> Sure, but my patch does insert --disable-shared: > >> > >> --8<-

Re: [PATCH v3 0/2] Replace intl/ with out-of-tree GNU gettext

2023-11-17 Thread David Edelsohn
On Fri, Nov 17, 2023 at 10:17 AM Arsen Arsenović wrote: > > David Edelsohn writes: > > > On Fri, Nov 17, 2023 at 3:46 AM Arsen Arsenović wrote: > > > >> > >> David Edelsohn writes: > >> > >> > On Thu, Nov 16, 2023 at 5:52 PM Arsen A

Re: [PATCH v3 0/2] Replace intl/ with out-of-tree GNU gettext

2023-11-19 Thread David Edelsohn
On Sun, Nov 19, 2023 at 5:15 PM Bruno Haible wrote: > David Edelsohn wrote: > > --disable-threads currently does not completely disable threads. Bruno > is > > suggesting --enable-threads=isoc that relies on mtx mutex functions in > libc. > > Unfortunately, as s

Re: [PATCH v3 0/2] Replace intl/ with out-of-tree GNU gettext

2023-11-20 Thread David Edelsohn
ttext itself with the different stages of the compiler, so the appended random number changes. Thanks, David On Mon, Nov 20, 2023 at 4:23 PM Arsen Arsenović wrote: > > David Edelsohn writes: > > > On Sun, Nov 19, 2023 at 5:15 PM Bruno Haible wrote: > > > >> Dav

Re: [PATCH v3 0/2] Replace intl/ with out-of-tree GNU gettext

2023-11-21 Thread David Edelsohn
On Tue, Nov 21, 2023 at 8:51 AM Arsen Arsenović wrote: > > Arsen Arsenović writes: > > > Bruno Haible writes: > > > >> Arsen Arsenović wrote: > >>> Comparing stages 2 and 3 > >>> Bootstrap comparison failure! > >>> gettext/libasprintf/autosprintf.o differs > >>> make[2]: *** [Makefile:2

Re: [RFC 1/2] libbacktrace: add FDPIC support

2024-07-16 Thread David Edelsohn
Hi, Ian I believe that this patch broke bootstrap on AIX: /nasfarm/edelsohn/src/src/libbacktrace/xcoff.c: In function 'xcoff_add': /nasfarm/edelsohn/src/src/libbacktrace/xcoff.c:1309:40: error: incompatible type for argument 2 of 'backtrace_dwarf_add' 1309 | if (!backtrace_dwarf_add (state

CFG edge visualization to path-printing bootstrap failure

2024-05-20 Thread David Edelsohn
Hi, David Unfortunately r15-636-g770657d02c986c causes a bootstrap failure on AIX when building f951 in stage2. cc1 and cc1plus link successfully. There doesn't seem to be a similar failure for powerpc64-linux BE or LE. The failure is ld: 0711-317 ERROR: Undefined symbol: _ZTV29range_label_for_

Re: CFG edge visualization to path-printing bootstrap failure

2024-05-29 Thread David Edelsohn
On Mon, May 20, 2024 at 1:56 PM David Edelsohn wrote: > Hi, David > > Unfortunately r15-636-g770657d02c986c causes a bootstrap failure on AIX > when building f951 in stage2. cc1 and cc1plus link successfully. There > doesn't seem to be a similar failure for powerpc64-lin

Re: Request for testing on non-Linux targets; remove special casing of /usr/lib and /lib from the driver

2024-04-19 Thread David Edelsohn
The patch does not cause failures on AIX. Is it removing explicit references to /lib and /usr/lib? It seems more appropriate for GCC 15. Thanks for alerting me to the patch to test on AIX. AIX is in CFarm. Thanks David On Tue, Apr 16, 2024 at 7:49 PM Andrew Pinski (QUIC) < quic_apin...@quicin

[PATCH, libgfortran] aix: Fix building fat library for AIX

2024-05-06 Thread David Edelsohn
aix: Fix building fat library for AIX With the change in subdirectories, the code for libgfortran fat libraries needs to be adjusted to explicitly reference the subdirectory. AIX creates fat library archives and the compiler itself can be built as either 32 bit or 64 bit appli

Re: [PATCH] testsuite, rs6000: Remove some checks with aix[456]

2024-05-08 Thread David Edelsohn
On Wed, May 8, 2024 at 2:36 AM Kewen.Lin wrote: > Hi, > > Since r12-75-g0745b6fa66c69c aix6 support had been dropped, > so we don't need to check for aix[456].* when testing, this > patch is to remove such checks. > > Regtested on powerpc64-linux-gnu P8/P9 and > powerpc64le-linux-gnu P9 and P10.

Re: [PATCH 00/23] prange: pointer ranges

2024-05-09 Thread David Edelsohn
> Tested and benchmarked on x86-64 Linux. Why aren't these patches being tested on all major architectures, especially those available in the Compile Farm? At least for correctness, if not performance. Thanks, David

Re: [patch] Adjust DECL_NAME of virtual clones

2013-08-20 Thread David Edelsohn
On Tue, Aug 20, 2013 at 4:44 AM, Eric Botcazou wrote: >> Dollar sign is not a valid character in symbols on some platforms, such as >> AIX. > > Sure, but DECL_NAME isn't used for any symbol here, unlike > DECL_ASSEMBLER_NAME. Okay, just wanted to make sure. Thanks, David

Re: [PATCH] Rerun df_analyze after delete_unmarked_insns during DCE

2013-08-21 Thread David Edelsohn
This patch has caused a bootstrap failure for powerpc-aix and probably powerpc64-linux. GCC segfaults and core dumps during stage2 configure. The motivation for this patch seems faulty and I strongly request that it be reverted. PR bootstrap/58206 Thanks, David

Re: powerpc64le multilibs and multiarch dir

2013-08-22 Thread David Edelsohn
On Wed, Aug 21, 2013 at 11:57 PM, Alan Modra wrote: > Index: gcc/config/rs6000/t-linux64 > === > --- gcc/config/rs6000/t-linux64 (revision 201834) > +++ gcc/config/rs6000/t-linux64 (working copy) > @@ -25,8 +25,8 @@ > # it doesn't t

Re: powerpc64le multilibs and multiarch dir

2013-08-23 Thread David Edelsohn
On Thu, Aug 22, 2013 at 7:15 PM, Alan Modra wrote: > Without another tmake file it really is exactly the same as before. > > old, after applying "make" string gunk > MULTILIB_OPTIONS = m64/m32 > MULTILIB_OSDIRNAMES = ../lib64 ../lib > > new > MULTILIB_OPTIONS = m64/m32 > MULTILIB_OSDIRNAMES = m64

Re: Ubsan merged into trunk

2013-08-30 Thread David Edelsohn
This patch / merge broke bootstrap on AIX: In file included from ./tm.h:18:0, from /home/dje/src/src/gcc/function.h:26, from /home/dje/src/src/gcc/basic-block.h:25, from /home/dje/src/src/gcc/cgraph.h:28, from /home/dje/src/src/g

[PATCH,fixincldes] AIX assert.h static_assert

2013-08-31 Thread David Edelsohn
In a recent change to AIX 7, the assert.h header defines static_assert. I presume this was intended not to avoid conflicts with the new C++ keyword. Sigh. However, the definition is not protected from C++, which causes problem if the header is included in C++ code, which it is in libstdc++. This

[PATCH,committed] AIX alias fix

2013-09-03 Thread David Edelsohn
varasm.c do_assemble_alias() calls globalize_decl() before creating an alias for a global symbol. For FUNCTION_DECLs ASM_OUTPUT_DEF_FROM_DECLS on AIX globalizes the code label in addition to the function descriptor globalized by varasm.c. For non-TREE_PUBLIC decls, the alias is declared as .lglobl

[PATCH, committed] check_weak_available for AIX

2013-09-03 Thread David Edelsohn
When objdump is not available, check_weak_available is unhappy on AIX. This hard-codes that AIX supports weak, as is implemented for other OSes. Bootstrapped on powerpc-ibm-aix7.1.0.0 Thanks, David * lib/target-supports.exp (check_weak_available): Return true for AIX. Index: target-sup

[PATCH, committed] Skip undefined weak in testsuite on AIX

2013-09-04 Thread David Edelsohn
AIX does not support undefined weak. Skip those tests in the testsuite. Also, select COFF as AIX file format without requiring objdump. * gcc.dg/attr-weakref-1.c: Skip on AIX. * gcc.dg/torture/pr53922.c: Skip on AIX. * lib/file-format.exp (gcc_target_object_format): AIX is COFF. Bootstrapped on

Re: [PATCH, powerpc] Rework VSX scalar floating point support

2013-09-05 Thread David Edelsohn
Mike, Why does rs6000_init_hard_regno_mode_ok() include #if 0 code? Because the patch affects e500, has this patch been tested in an e500 configuration? The cover message did not make it clear that you are merging SFmode and DFmode patterns using mode iterators. That really should have been a se

Re: [RS6000] powerpc64 -mcmodel=medium large symbol offsets

2013-09-06 Thread David Edelsohn
On Fri, Sep 6, 2013 at 3:13 AM, Alan Modra wrote: > The following testcase taken from the linux kernel is miscompiled on > powerpc64-linux. > > /* -m64 -mcmodel=medium -O -S -fno-section-anchors */ > static int x; > > unsigned long > foo (void) > { > return ((unsigned long) &x) - 0xc

Re: [RS6000] powerpc64 -mcmodel=medium large symbol offsets

2013-09-09 Thread David Edelsohn
On Mon, Sep 9, 2013 at 5:07 AM, Alan Modra wrote: > Revised patch with testcase. This one also fixes a small problem with > reg_or_add_cint_operand in that any 32-bit value is valid for SImode. > Compare with reg_or_sub_cint_operand. > > Bootstrapped and regression tested powerpc64-linux. OK to

Re: [RS6000] Fix PR58330 powerpc64 atomic store split in two

2013-09-09 Thread David Edelsohn
On Mon, Sep 9, 2013 at 8:21 AM, Alan Modra wrote: > This patch prevents the powerpc backend from combining a 64-bit > volatile load or store with a bswap insn when the resulting combined > insn will be implemented as two lwbrx or stwbrx machine insns. > Bootstrapped and regression tested powerpc64

Re: [RS6000] powerpc64 -mcmodel=medium large symbol offsets

2013-09-11 Thread David Edelsohn
On Wed, Sep 11, 2013 at 7:12 AM, Alan Modra wrote: > On Mon, Sep 09, 2013 at 06:37:03PM +0930, Alan Modra wrote: >> gcc/ >> * config/rs6000/predicates.md (add_cint_operand): New. >> (reg_or_add_cint_operand): Use add_cint_operand. >> * config/rs6000/rs6000.md (largetoc_high_plus)

Re: [PATCH], PR target/58452, Fix gcc 4.8/trunk linuxpaired breakage

2013-09-18 Thread David Edelsohn
On Tue, Sep 17, 2013 at 8:03 PM, Michael Meissner wrote: > While doing some work on power8, I wanted to make sure that for existing > systems, I was generating the same code. So I built some code and ran it > through various -mcpu= options. When I built a powerpc-linuxpaired > compiler, the

Re: libtool update for powerpc64le-linux

2013-09-18 Thread David Edelsohn
I guess I can't really expect to gain an approval to import the upstream libtool into gcc. Even *I* don't really trust me, although having looked at it a little I think I could even update libjava/libltdl. So how about just continuing the status quo and applying a libtool patch that is already up

Re: [PATCH] Fix PR58417

2013-09-19 Thread David Edelsohn
This patch has caused 6 new libstdc++ failures on AIX. All look like: /home/dje/src/src/libstdc++-v3/testsuite/ext/random/normal_mv_distribution/cons/default.cc:49:1: internal compiler error: in build_polynomial_chrec, at tree-chrec.h:148 } - David

Re: [PATCH, powerpc] Rework#2 VSX scalar floating point support, patch #1

2013-09-23 Thread David Edelsohn
On Fri, Sep 20, 2013 at 7:32 PM, Michael Meissner wrote: > I am now breaking the patches down to be more bite size. Ultimately, I hope > these patches will provide support to allow scalar floating point to occupy > the > Altivec (upper) registers if the ISA allows it (ISA 2.06 for DFmode, ISA 2.

Re: [PATCH, powerpc] Rework#2 VSX scalar floating point support, patch #2

2013-09-23 Thread David Edelsohn
On Mon, Sep 23, 2013 at 4:06 PM, Michael Meissner wrote: > This patch is an infrastructure patch that combines the 3 reload helper > function arrays into a single array of structures. All machines generate the > same code with this patch (and no regressions were found in bootstrap/make > check).

Re: [PATCH, powerpc] Rework#2 VSX scalar floating point support, patch #3

2013-09-25 Thread David Edelsohn
On Tue, Sep 24, 2013 at 4:33 PM, Michael Meissner wrote: > This patch adds the initial support for putting DI, DF, and SF values in the > upper registers (traditional Altivec registers) using the -mupper-regs-df and > -mupper-regs-sf patches. Those switches will not be enabled by default until >

[PATCH, committed] Update t-rs6000 for automatic dependencies

2013-09-26 Thread David Edelsohn
All of the rs6000-specific dependencies are included and discovered automatically. Bootstrapped on powerpc-ibm-aix7.1.0.0. David * config/rs6000/t-rs6000 (rs6000.o): Remove. (rs6000-c.o): Use COMPILE and POSTCOMPILE. Index: config/rs6000/t-rs6000

Re: [PATCH, powerpc] Rework#2 VSX scalar floating point support, patch #3

2013-09-26 Thread David Edelsohn
On Thu, Sep 26, 2013 at 4:51 PM, Michael Meissner wrote: > I discovered that I was setting the wv/wu constraints incorrectly to > ALTIVEC_REGS, which leads to reload failures in some cases. > > Is this patch ok to apply along with the previous patch assuming it bootstraps > and has no regressions

Re: [PATCH, powerpc] Rework#2 VSX scalar floating point support, patch #4

2013-10-01 Thread David Edelsohn
On Tue, Oct 1, 2013 at 1:52 PM, Michael Meissner wrote: > This patch moves most of the VSX DFmode operations from vsx.md to rs6000.md to > use the traditional floating point instructions (f*) instead of the VSX scalar > instructions (xs*) if all of the registers come from the traditional floating

[PATCH] Disable updating VRSAVE everywhere except Darwin

2012-09-28 Thread David Edelsohn
The following proposed patch disables setting, saving and restoring the VRSAVE register on all targets except Darwin. VRSAVE was removed from the AIX ABI and was suppose to have been removed from the PPC SVR4 ABI. All recent versions of the Linux kernel set and maintain VRSAVE itself, as a proces

Re: [PATCH] Disable updating VRSAVE everywhere except Darwin

2012-09-29 Thread David Edelsohn
On Sat, Sep 29, 2012 at 11:08 AM, Segher Boessenkool wrote: >> The following proposed patch disables setting, saving and restoring >> the VRSAVE register on all targets except Darwin. >> >> VRSAVE was removed from the AIX ABI and was suppose to have been >> removed from the PPC SVR4 ABI. All rece

[PATCH,fixincludes] Wrap fcntl.h on AIX

2012-09-29 Thread David Edelsohn
AIX fcntl.h redefines "open", which conflicts with g++ fstream header. This patch wraps fcntl.h to use aliases in the same way that stdio.h currently is wrapped. Okay? Thanks, David * inclhack.def (AAB_aix_fcntl): New fix. * fixincl.x: Regenerate. * tests/base/fcntl.h [AAB_AIX_FCNTL_CHECK]: New

Re: [PATCH,fixincludes] Wrap fcntl.h on AIX

2012-09-29 Thread David Edelsohn
On Sat, Sep 29, 2012 at 2:00 PM, Bruce Korb wrote: > Does "make check" complain if a replacement/wrap fix doesn't have a test? > If so, I'll be fixing it when I have time -- towards the end of October. > (The patch I sent a few days ago ought to do it, but I've not fully tested > yet.) > Anyway,

Re: [PATCH rs6000 testsuite] Fix a couple tests for VSX scalar instructions

2012-10-01 Thread David Edelsohn
On Mon, Oct 1, 2012 at 6:03 PM, Pat Haugen wrote: > This patch fixes a couple failures that occur if the testsuite is run with > -mvsx and the VSX scalar sqrt instructions are generated. Ok for trunk? > > -Pat > > > testsuite/ChangeLog: > 2012-10-01 Pat Haugen > > * gcc.target/powerpc/pr

Re: [PATCH] Rs6000 infrastructure cleanup (switches), revised patch #2d

2012-10-02 Thread David Edelsohn
On Mon, Oct 1, 2012 at 7:11 PM, Michael Meissner wrote: > 2012-10-01 Michael Meissner > > * config/rs6000/rs6000.c (rs6000_option_override_internal): If > -mcpu= is not specified and the compiler is not configured > using --with-cpu=, use the bits from the TARGET_DEFAULT

Re: [Fortran, (RFC) patch] PR49110/51055 Assignment to alloc. deferred-length character vars

2012-10-03 Thread David Edelsohn
Tobias, Sorry to return to this patch so long after the discussion, but I have been investigating testsuite failures on AIX and this patch introduced a number of Fortran failures. + if (sym->module) + name = gfc_get_string (".__%s_MOD_%s", sym->module, sym->name); + else + n

Re: [PATCH] rs6000: Remove 'A' output modifier

2012-10-03 Thread David Edelsohn
On Wed, Oct 3, 2012 at 6:28 PM, Segher Boessenkool wrote: > It was used for old POWER only, which has been removed. > > Tested etc.; okay to apply? > > > Segher > > > 2012-10-04 Segher Boessenkool > > gcc/ > * config/rs6000/rs6000.c (print_operand) ['A']: Delete. Okay. Thanks, David

Re: [Fortran, (RFC) patch] PR49110/51055 Assignment to alloc. deferred-length character vars

2012-10-03 Thread David Edelsohn
ules about reserved identifiers. Thanks, David On Wed, Oct 3, 2012 at 5:00 PM, Tobias Burnus wrote: > David, > > > David Edelsohn wrote: >> >> I am not sure why you chose a period and how best to correct this. > > > Well, in principle any name which the user cannot en

  1   2   3   4   5   6   7   8   9   10   >