Hi, Surya
Thanks for working on this issue and creating a patch.
It helps if you explicitly send patches to Segher and me, and copy gcc-patches.
+/* Return true if insn is a non-permuting load/store. */
+static bool
+non_permuting_mem_insn (swap_web_entry *insn_entry, unsigned int i)
+{
+ return (insn_entry[i].special_handling == SH_NOSWAP_LD ||
+ insn_entry[i].special_handling == SH_NOSWAP_ST);
+}
The logical operator || should be at the beginning of the line, not
the end. That also ensures correct formatting and indentation. The
|| should be under the "i" of insn on the line above.
It also generally simplifies review to have the ChangeLog in the same
order as changes in the file. The order of the files relative to the
patch may not be the same, but the ChangeLog entries should be in
sequential order relative to the file.
This patch is okay with the logical operator formatting change.
Thanks, David
