That fixed it, thanks! Attached is the latest patch (Florian, I will
send you the regenerated Makefile.in and configure separately).
Please review and let me know if this is OK to commit!
-- Caroline
cmt...@google.com
2013-08-20 Caroline Tice
* Makefile.am (DEFS): Add "@DEFS@
Ok, committed (with the space fix).
-- Caroline Tice
cmt...@google.com
On Tue, Aug 20, 2013 at 12:43 PM, Florian Weimer wrote:
> On 08/20/2013 09:15 PM, Caroline Tice wrote:
>>
>> That fixed it, thanks! Attached is the latest patch (Florian, I will
>> send you the regene
Ping? Ping?
On Wed, Aug 14, 2013 at 12:14 PM, Caroline Tice wrote:
> Ping?
>
> On Thu, Aug 8, 2013 at 3:16 PM, Caroline Tice wrote:
>> This patch replaces the fixed sized array that was holding vtable
>> pointers for a particular class hierarchy with a vector, allowing fo
I was not aware that the links required Javascript. Can anybody tell
me how to fix them so that they don't?
-- Caroline Tice
cmt...@google.com
On Thu, Aug 22, 2013 at 9:58 AM, Joseph S. Myers
wrote:
> On Mon, 12 Aug 2013, Caroline Tice wrote:
>
>> I have finished my first pa
I believe I have figured this out and fixed the problem. If you are
still seeing the issue, please let me know.
-- Caroline Tice
cmt...@google.com
On Thu, Aug 22, 2013 at 10:07 AM, Caroline Tice wrote:
> I was not aware that the links required Javascript. Can anybody tell
> me how to fi
Thank you for pointing out my error. I will commit the following patch.
-- Caroline Tice
cmt...@google.com
2013-08-26 Caroline Tice
* MAINTAINERS: Correct earliers update: Move myself from libvtv
"Various Reviewers" to libvtv "Various Maintainers".
PING!
Could somebody please, pretty please review this patch? It's not very
big or complex, and it's been out there for three weeks nowIs
there something else I need to do for this?
-- Caroline Tice
cmt...@google.com
On Wed, Aug 21, 2013 at 1:30 PM, Caroline Tice wrote:
&g
On Wed, Aug 28, 2013 at 10:30 AM, Diego Novillo wrote:
> On 2013-08-28 12:59 , Caroline Tice wrote:
>
>> static void
>> -output_set_info (tree record_type, tree *vtbl_ptr_array, int array_size)
>> +output_set_info (tree record_type, vec *vtbl_ptr_array)
>
>
Okay, w
, which does all of this, and let me
know if it is ok to commit.
-- Caroline Tice
cmt...@google.com
gcc ChangeLog:
2013-08-28 Caroline Tice
* doc/install.texi: Add documentation for the --enable-vtable-verify
and the --disable-libvtv configure options.
libvtv ChangeLog:
2013-08
Ping? Could somebody please review this for me?
-- Caroline Tice
cmt...@google.com
On Wed, Aug 28, 2013 at 2:15 PM, Caroline Tice wrote:
> Discussion on this topic seems to have petered out. I have removed
> references to ENABLE_VTABLE_VERIFY from libvtv, as requested. I
> cannot re
Ping? Could somebody please review this for me?
-- Caroline Tice
cmt...@google.com
On Fri, Aug 30, 2013 at 2:55 PM, Caroline Tice wrote:
> The attached patch fixes most of the libvtv testsuite tests to run in
> the dejagnu test harness. There are still a few tests that I haven't
all my
regular vtable verification tests. Is this patch ok to commit?
-- Caroline Tice
cmt...@google.com
2013-09-04 Caroline Tice
PR c++/58300
* vtable-class-hierarchy.c (vtv_generate_init_routine): In
preinit case, move call to assemble_vtv_preinit_initializer to
On Fri, Sep 6, 2013 at 6:47 AM, Diego Novillo wrote:
> On 2013-08-28 17:15 , Caroline Tice wrote:
>
>> # Least ordering for dependencies mean linking w/o libstdc++ for as
>> # long as the development of libvtv does not absolutely require it.
>> Ind
I believe I have addressed all the issues with the Vtable Verification
feature. I have updated the announcement patch, and have attached the
updated patch. Is this OK to commit?
-- Caroline Tice
cmt...@google.com
On Thu, Aug 8, 2013 at 9:00 AM, Richard Earnshaw wrote:
> On 07/08/13 18
The patch looks good to me, but somebody else needs to approve it.
-- Caroline Tice
cmt...@google.com
On Mon, Sep 9, 2013 at 11:48 AM, H.J. Lu wrote:
> configure.tgt in libvtv only recognizes canonical targets. This patch
> moves the VTV_SUPPORTED check after AC_CANONICAL_SYSTEM for t
On Tue, Sep 10, 2013 at 9:10 AM, Jakub Jelinek wrote:
> On Tue, Sep 10, 2013 at 08:55:35AM -0700, Caroline Tice wrote:
>> Based on the errors you are reporting, my guess is that you did not
>> configure with --enable-vtable-verifiy. The testsuite in libvtv will
>
> I'
On Tue, Sep 10, 2013 at 3:17 AM, Jakub Jelinek wrote:
> On Mon, Sep 09, 2013 at 01:56:29PM -0700, Caroline Tice wrote:
>> The patch looks good to me, but somebody else needs to approve it.
>
> Why? You are listed as libvtv maintainer, the patch is fully contained in
> libvtv, t
problem.
-- Caroline
cmt...@google.com
On Tue, Sep 10, 2013 at 9:17 AM, Caroline Tice wrote:
> On Tue, Sep 10, 2013 at 9:10 AM, Jakub Jelinek wrote:
>> On Tue, Sep 10, 2013 at 08:55:35AM -0700, Caroline Tice wrote:
>>> Based on the errors you are reporting, my guess i
though I am the libvtv maintainer, I would
appreciate someone else reviewing this patch too, as a sanity check.
-- Caroline Tice
cmt...@google.com
2013-09-11 Caroline Tice
* Makefile.am: Re-instante ENABLE_VTABLE_VERIFY checks, to make
sure testsuite is not run if libstdc++ and
On Wed, Sep 11, 2013 at 12:07 PM, H.J. Lu wrote:
> On Wed, Sep 11, 2013 at 11:22 AM, Caroline Tice wrote:
>> This patch should fix the issues that people were having with the
>> libvtv testsuite being run (and failing) when GCC was not configured
>> with --enable-vtable-v
On Wed, Sep 11, 2013 at 12:35 PM, H.J. Lu wrote:
> On Wed, Sep 11, 2013 at 12:27 PM, Caroline Tice wrote:
>>
>>> 2. Why does libvtv/configure.ac have
>>>
>>> echo 'MULTISUBDIR =' >> $ac_file
>>> ml_norecursion=yes
>>>
Yes, that patch is ok.
-- Caroline Tice
cmt...@google.com
On Thu, Sep 12, 2013 at 3:56 AM, Alexander Ivchenko wrote:
> Hi,
>
> We currently have build problem in Android ndk for trunk:
>
> toolchain/gcc/gcc-4.9/libvtv/vtv_rts.cc:124:22: fatal error:
> execinfo.h: No such
(Putting into plain test for gcc-patches list).
On Mon, Sep 23, 2013 at 11:42 AM, Caroline Tice wrote:
>
> Ping?
>
>
> On Thu, Sep 12, 2013 at 10:44 AM, Caroline Tice wrote:
>>
>> On Wed, Sep 11, 2013 at 12:35 PM, H.J. Lu wrote:
>> > On Wed, Sep 11, 2013 at
The following patch updates where libvtv installs its header files
(fixing PR 58441). This is a trivial change, and affects only libvtv,
so I am going to go ahead and commit it.
-- Caroline Tice
cmt...@google.com
2013-09-24 Caroline Tice
* Makefile.am: Change libvtv_includedir to the
with this patch, both with and
without vtable verification enabled, and have run the regression
testsuites, both with and without vtable verification enabled, with no
regressions. I have only tested this on Linux.
Is this patch OK to commit?
-- Caroline Tice
cmt...@google.com
gcc ChangeLog:
2013
and I have verified that
it fixes the problem. Is this ok to commit?
-- Caroline Tice
cmt...@google.com
ChangeLogs:
libvtv/ChangeLog
2015-07-28 Caroline Tice
PR 66521
* Makefile.am: Update to match latest tree.
* Makefile.in: Regenerate.
* testsuite/lib/l
Guide, off the wiki page (https://gcc.gnu.org/wiki/vtv). If
you're already read that and have further questions, let me know...
-- Caroline
cmt...@google.com
On Mon, Oct 19, 2015 at 4:39 PM, Caroline Tice wrote:
> It looks good to me, but I can only approve the files that go into libvt
r
gcc-5_branch and gcc-4_9-branch).
-- Caroline Tice
cmt...@google.com
gcc/ChangeLog:
2015-10-23 Caroline Tice
(from Richard Biener)
* tree.c (int_cst_hasher::hash): Replace XOR with more efficient
call to iterative_hash_host_wide_int.
Index: gcc/t
Here is my promised backport to the GCC 5 branch, for the patch below
that went into ToT last week. As with the previous patch, I've
verified that it fixes the problem, bootstraps and has no new
regression test failures. Is this ok to commit to the gcc-5-branch?
-- Caroline Tic
Here is my promised backport to the GCC 4.9 branch, for the patch below
that went into ToT last week. As with the previous patch, I've
verified that it fixes the problem, bootstraps and has no new
regression test failures. Is this ok to commit to the gcc-4_9-branch?
-- Caroline Tic
Here is my promised backport to the GCC 5 branch, for the patch below
that went into ToT last week. As with the previous patch, I've
verified that it fixes the problem, bootstraps and has no new
regression test failures. Is this ok to commit to the gcc-5-branch?
-- Caroline Tic
Here is my promised backport to the GCC 4.9 branch, for the patch below
that went into ToT last week. As with the previous patch, I've
verified that it fixes the problem, bootstraps and has no new
regression test failures. Is this ok to commit to the gcc-4_9-branch?
-- Caroline Tic
(Trying this again; the mailer daemon rejected my first message)
All of the patch looks good to me, but I can only approve the libvtv
portion (which I do). Someone else will need to approve the rest.
-- Caroline Tice
cmt...@google.com
On Tue, Nov 24, 2015 at 2:24 AM, Rainer Orth
wrote
happened
yet. Should I go ahead and commit that patch, or should I wait for
the author to do that?
-- Caroline Tice
cmt...@google.clom
On Tue, Apr 28, 2015 at 10:10 AM, David Edelsohn wrote:
> Caroline,
>
> Your patch has broken bootstrap on AIX and probably other platforms.
>
> /n
Thank you!
-- Caroline Tice
cmt...@google.com
On Tue, Apr 28, 2015 at 10:16 AM, David Edelsohn wrote:
> I just committed the patch for Dominique.
>
> - David
>
>
> On Tue, Apr 28, 2015 at 1:12 PM, Caroline Tice wrote:
>> Yes, this is already mentioned in PR 65910
platforms, so I would need some help, if anyone would be interested in
helping me?
-- Caroline Tice
cmt...@google.com
ChangeLog (gcc):
2015-04-29 Caroline Tice
Revert patch from 2015-04-27
* final.c (final_scan_insn): Remove code to output
cold_function_name as a function
Thank you; I will work with your suggestions and try to get a new
patch done soon.
-- Caroline Tice
cmt...@google.com
On Wed, Apr 29, 2015 at 11:34 AM, Uros Bizjak wrote:
> On Wed, Apr 29, 2015 at 7:47 PM, Uros Bizjak wrote:
>> On Wed, Apr 29, 2015 at 7:38 PM, Caroline Tice wrote
?
-- Caroline Tice
cmt...@google.com
ChangeLog (gcc):
2015-04-29 Caroline Tice
PR 65929
* config/elfos.h (ASM_DECLARE_COLD_FUNCTION_NAME): New macro definition.
(ASM_DECLARE_COLD_FUNCTION_SIZE): New macro definition.
* final.c (final_scan_insn): Use
Done. Here is the updated patch (with ChangeLog entries). Only
change was to update tm.texi.in.
The bootstrap passed. Is the patch ok to commit?
-- Caroline
cmt...@google.com
ChangeLog (gcc):
2015-04-30 Caroline Tice
PR 65929
* config/elfos.h (ASM_DECLARE_COLD_FUNCTION_NAME): New macro
What is the correct way to regenerate doc/tm.texi?
-- Caroline
On Thu, Apr 30, 2015 at 12:24 PM, H.J. Lu wrote:
> On Thu, Apr 30, 2015 at 10:38 AM, Richard Henderson wrote:
>> On 04/30/2015 09:26 AM, Caroline Tice wrote:
>>> 2015-04-30 Caroline Tice
>>>
>>
It took me a while to get a test case I'm happy with, so I'm
re-submitting the whole patch for approval.
2015-03-27 Caroline Tice
* final.c (final_scan_insn): Change 'cold_function_name' to
'cold_partition_name' and make it a global variable; a
I am fine with waiting until stage 1. When that is likely to be?
-- Caroline Tice
cmt...@google.com
On Mon, Mar 30, 2015 at 10:19 PM, Jeff Law wrote:
> On 03/27/2015 10:44 AM, Caroline Tice wrote:
>>
>> It took me a while to get a test case I'm happy with, so I'm
&
I would appreciate it if you would do it.
-- Caroline Tice
cmt...@google.com
On Fri, Apr 10, 2015 at 4:55 PM, Gerald Pfeifer wrote:
> On Sun, 8 Sep 2013, Caroline Tice wrote:
>> I believe I have addressed all the issues with the Vtable Verification
>> feature. I have updated t
Since all the pieces of this patch have been approved, I will commit
it later today (since Patrick does not have commit privileges).
-- Caroline Tice
cmt...@google.com
On Wed, Jan 28, 2015 at 3:31 AM, Patrick Wollgast
wrote:
> Ping.
>
> https://gcc.gnu.org/ml/gcc-patches/2015-01
I (sadly) committed this patch in two pieces, one last night and one
this morning. In the commit last night, I had forgotten to commit the
Makefile.in and configure files that got generated by autoconf and
automake. Did you sync your sources before or after the second
commit?
-- Caroline Tice
running test
testsuite with no regressions.
Is this ok to commit?
-- Caroline Tice
ctic...@gmail.com
gcc/ChangeLog:
2016-10-27 Caroline Tice
* config/i386/pmm_malloc.h (posix_memalign): Add ifdefs to only
decorate the declaration with 'throw()' if __GLIBC__ is defi
by bootstrapping and running the entire
testsuite with no regressions. Is this OK to commit?
-- Caroline Tice
cmt...@google.com
Index: libstdc++-v3/acinclude.m4
===
--- libstdc++-v3/acinclude.m4 (revision 226760)
+++ libstdc++-v3
I forgot the ChangeLog enty; here it is:
libstdc++-v3/ChangeLog:
2015-08-11 Caroline Tice
PR 66521, Contributed by Eric Gallager
* acinclude.m4 (VTV_CXXLINKFLAGS): Make this variable OS-specific, and
fix the rpath flag to work properly for darwin.
* configure
-- Forwarded message --
From: Caroline Tice
Date: Wed, Aug 26, 2015 at 12:50 PM
Subject: Re: [libvtv] Fix formatting errors
To: Jeff Law
Cc: Rainer Orth , GCC Patches
As far as I know vtv is working just fine...is there something I don't
know about?
-- Carolin
d by bootstrapping the compiler, running the
dejagnu testsuite with no regressions, and checked as shown above that
it fixes the original problem. Is this patch OK to commit to ToT?
-- Caroline Tice
cmt...@google.com
2014-12-05 Caroline Tice
* final.c (final_scan_insn): Change 'cold_func
rotect.
> * libvtv/vtv_malloc.cc
> Added extern "C" to the prototype of mprotect.
> * libvtv/vtv_malloc.h
> Exchanged call to TerminateProcess with call to abort in __fortify_fail.
> * libvtv/vtv_rts.cc
The changes in libvtv all look good to me (approved).
-
Most likely use-after-free issues, but any memory use bug lays the
program open to these attacks.
-- Caroline Tice
cmt...@google.com
On Thu, Nov 8, 2012 at 1:36 AM, Florian Weimer wrote:
> On 11/05/2012 06:48 PM, Caroline Tice wrote:
>
>> As requested, I have split the original pa
Trying to send again; gcc_patches list bounced original message.
-- Forwarded message --
From: Caroline Tice
Date: Fri, May 24, 2013 at 9:15 AM
Subject: Re: [PATCH, updated] Vtable pointer verification, C++ front
end changes (patch 1 of 3)
To: Jason Merrill
Cc: Diego Novillo
On Wed, Mar 13, 2013 at 10:48 AM, Diego Novillo wrote:
>
> On 2013-02-25 14:27 , Caroline Tice wrote:
>
>> Index: libgcc/Makefile.in
>> ===
>> --- libgcc/Makefile.in(revision 196266)
>> +++ li
First attempt to send this failed.
On Fri, Sep 12, 2014 at 3:41 PM, Caroline Tice wrote:
>
> Hi Patrick,
>
> Mostly your patch looks OK to me, though there are a couple of serious issues
> (mentioned below). Most of my comments are for formatting stuff. Once you
> have
-hierarchy.c
gcc/varasm.c
libgcc/Makefile.in
libgcc/config.host
libiberty/obstack.c
libstdc++-v3/acinclude.m4
libstdc++-v3/libsupc++/Makefile.am
libstdc++-v3/libsupc++/vtv_stubs.cc
-- Caroline Tice
cmt...@google.com
On Thu, Sep 18, 2014 at 3:23 PM, Patrick Wollgast
wrote:
> Added Benjamin
On Tue, Jun 4, 2013 at 10:20 AM, Jason Merrill wrote:
> On 05/24/2013 12:15 PM, Caroline Tice wrote:
>>
>> Changes to g++spec.c only affect the g++ driver, not the gcc
>> driver. Are you sure this is what you want? Can't you handle
>> this
on on this feature
at last year's GNU Tools Cauldron. This work has been ongoing since
GCC 4.7 and is now ready to merge into trunk for the GCC 4.9.0
release.
I would like permission to merge this in (and or information on the
best way to proceed from here). Thanks.
-- Caroline Tice
cmt...@google.com
I was talking with Diego, and he suggested the possibility of putting
the log files in the same directory that the gcc dump files go, i.e.
the one specified by dump_base_name. Do you think that would be
acceptable?
-- Caroline Tice
cmt...@google.com
On Tue, Aug 6, 2013 at 12:12 PM, Ian Lance
Actually, I think that was dump_dir_name.
-- Caroline
On Tue, Aug 6, 2013 at 1:12 PM, Caroline Tice wrote:
> I was talking with Diego, and he suggested the possibility of putting
> the log files in the same directory that the gcc dump files go, i.e.
> the one specified by dump_base_
I have made all the requested changes. I am in the process of
bootstrapping and running the regressions one last time. Assuming the
bootstrapping & regression tests pass, is this ok to commit?
-- Caroline
cmt...@google.com
On Tue, Aug 6, 2013 at 2:45 PM, Diego Novillo wrote:
> On Tue, Aug 6,
e/build it.
I'll get another patch out to fix the problem as soon as I can.
-- Caroline Tice
cmt...@google.com
On Wed, Aug 7, 2013 at 5:29 AM, Dominique Dhumieres wrote:
> Revision 201555 breaks boostrap on x86_64-apple-darwin10:
>
> ...
> Checking multilib configuration for libv
As requested, here is the patch to announce the vtable verification
feature on the main gcc.gnu.org web page. Is this ok to commit?
-- Caroline Tice
cmt...@google.com
wwwdocs.patch
Description: Binary data
Hi Iain,
Thanks for the pointer (I had noticed this but I appreciate the help!).
I do not know of anyone working on a Darwin port for this at this time.
-- Caroline Tice
cmt...@google.com
On Wed, Aug 7, 2013 at 10:31 AM, Iain Sandoe wrote:
> hi Caroline,
>
> A (very) quick look sugg
+ gcc_patches list
On Wed, Aug 7, 2013 at 2:56 PM, Caroline Tice wrote:
> No, it was not intended. How do I undo that?
>
> -- Caroline
> cmt...@google.com
>
> On Wed, Aug 7, 2013 at 2:54 PM, David Edelsohn wrote:
>> Caroline,
>>
>> When libvtv w
Thank you!
-- Caroline
On Wed, Aug 7, 2013 at 3:09 PM, Paolo Carlini wrote:
> .. I removed it.
>
> Thanks,
> Paolo.
On Thu, Aug 8, 2013 at 5:55 AM, Ramana Radhakrishnan wrote:
> On 08/06/13 22:39, Benjamin De Kosnik wrote:
>>
>>
+# Filter out unsupported systems.
+case "${target}" in
+ x86_64-*-linux* | i?86-*-linux*)
+ VTV_SUPPORTED=yes
+ ;;
+ powerpc*-*-linux*)
+ ;;
+
On Thu, Aug 8, 2013 at 3:27 AM, Rainer Orth
wrote:
> Caroline,
>
> your libgcc ChangeLog entries are all broken: they lack the initial "* "
> as can easily be seen in Emacs' Change Log Mode.
>
> Please fix.
>
Wow, I'm really sorry about that! I don't know how that happened.
I'll fix it immediat
The attached patch adds documentation for the --enable-vtable-verify
configure option to install.texi. Is this ok to commit?
-- Caroline TIce
cmt...@google.com
2013-08-08 Caroline Tice
* doc/install.texi: Add documentation for the --enable-vtable-verify
configure option
o added the uid and pid to the log file names.
Is this patch OK to commit?
-- Caroline Tice
cmt...@google.com
2013-08-08 Caroline Tice
* vtv_utils.cc : Include stdlib.h
(log_dirs): Remove file static constant.
(__vtv_open_log): Increase size of log file name. Add th
this patch OK to commit?
-- Caroline Tice
cmt...@google.com
2013-08-08 Caroline Tice
* vtable-class-hierarchy.c: Remove unnecessary include statements.
(MAX_SET_SIZE): Remove unnecessary constant.
(register_construction_vtables): Make vtable_ptr_array parameter
On Wed, Aug 7, 2013 at 6:03 PM, Joseph S. Myers wrote:
> Looking at the patch as committed, there seems to be some confusion about
> the nature of the --enable-vtable-verify configure option.
Yes, there is a bit.
>
> It's documented only for libstdc++. Now, I still consider the existence
> of s
On Thu, Aug 8, 2013 at 3:26 PM, Mike Stump wrote:
> On Aug 8, 2013, at 3:09 PM, Caroline Tice wrote:
>> This patch changes where the logging file mechanism in libvtv tries to
>> write its log files. Instead of trying to use /tmp, it now first
>> looks for an environment v
ug 8, 2013 at 4:33 PM, Jason Merrill wrote:
> On 08/08/2013 06:34 PM, Caroline Tice wrote:
>>
>> Actually if you ever want to use the feature with your compiler you
>> should build your compiler with --enable-vtable-verify. This will, as
>> you noted, insert calls i
I would like to make the following changes to the MAINTAINERS file.
May I commit this?
-- Caroline Tice
cmt...@google.com
2013-08-10 Caroline Tice
* MAINTAINERS: Add myself as libvtv maintainer. Correct my email
address in the Write After Approval section.
maintainers.patch
Description
commit?
-- Caroline Tice
cmt...@google.com
2013-08-10 Caroline Tice
* configure.ac: Add check for __secure_getenv and secure_getenv.
* configure: Regenerate.
* vtv_utils.cc : Include stdlib.h
(HAVE_SECURE_GETENV): Add checks and definitions for secure_getenv.
(log_dirs): Remove file static
On Mon, Aug 12, 2013 at 4:15 AM, Florian Weimer wrote:
> On 08/12/2013 12:39 AM, Caroline Tice wrote:
>>
>> On Sun, Aug 11, 2013 at 1:04 PM, Florian Weimer
>> wrote:
>>>
>>> On 08/11/2013 01:08 AM, Caroline Tice wrote:
>>>>
>>>>
>
Ping? Is this one of those I can commit without waiting for approval?
-- Caroline Tice
cmt...@google.com
On Sat, Aug 10, 2013 at 1:16 PM, Caroline Tice wrote:
> I would like to make the following changes to the MAINTAINERS file.
> May I commit this?
>
> -- Caroline Tice
> cm
On Thu, Aug 8, 2013 at 9:34 AM, Caroline Tice wrote:
> On Thu, Aug 8, 2013 at 3:27 AM, Rainer Orth
> wrote:
>> Caroline,
>>
>
>> As an aside, I had a very quick look at libvtv to determine what's
>> required for a port to a non-Linux platform. It would be
On Mon, Aug 12, 2013 at 10:07 AM, Caroline Tice wrote:
> On Mon, Aug 12, 2013 at 4:15 AM, Florian Weimer wrote:
>> On 08/12/2013 12:39 AM, Caroline Tice wrote:
>>>
>>> On Sun, Aug 11, 2013 at 1:04 PM, Florian Weimer
>>> wrote:
>>>>
le-verify is necessary in libstdc++,
because you definitely want to be able to control whether or not
libstdc++ is built with its virtual calls verifiable. What do other
people believe is the right thing to do here?
-- Caroline Tice
cmt...@google.com
Ping?
On Thu, Aug 8, 2013 at 3:16 PM, Caroline Tice wrote:
> This patch replaces the fixed sized array that was holding vtable
> pointers for a particular class hierarchy with a vector, allowing for
> dynamic resizing. It also fixes issues with the warning diagnostics.
> I am in th
lease review the patch and let me know if this is OK to commit. Thanks!
-- Caroline Tice
cmt...@google.com
2013-08-16 Caroline Tice
* configure.ac: Add check for __secure_getenv and secure_getenv.
* configure: Regenerate.
* vtv_utils.cc : Include stdlib.h
(HAVE_SECURE_GETENV): Add check
ing the #ifdef
HAVE___SECURE_GETENV check, and just force it to try to use
__secure_getenv, the program works properly, and the readelf -s
libvtv.so | grep getenv shows __secure_getenv as the function.
WHAT am I doing wrong? Help?
-- Caroline Tice
cmt...@google.com
On Mon, Aug 19, 2013 at 9:37 AM, F
changes and let me know if they will be ok to
commit once stage 1 opens.
-- Caroline Tice
cmt...@google.com
2013-02-25 Caroline Tice
* config/abi/pre/gnu.ver: Add vtable verification runtime functions to
the list of globally visible symbols.
* acinclude.m4: Add
On Mon, Feb 25, 2013 at 1:14 PM, Jonathan Wakely wrote:
> On 25 February 2013 19:52, Caroline Tice wrote:
>> I got too excited about being done and forgot to attach the patch. :-(
>> Sorry. Here it is.
>
> Some comments follow, mostly from reading the comments to underst
Ping?
-- Caroline Tice
cmt...@google.com
On Mon, Feb 25, 2013 at 11:24 AM, Caroline Tice wrote:
> Here are the latest changes to the vtable pointer verification patches
> (again there are 3 patches: c++ front end, main gcc, and c++ runtime
> library). I think these address all t
Ping?
-- Caroline
cmt...@google.com
On Mon, Feb 25, 2013 at 11:27 AM, Caroline Tice wrote:
> Here are the latest changes to the vtable pointer verification patches
> (again there are 3 patches: c++ front end, main gcc, and c++ runtime
> library). I think these address all the review
Hello,
I just created a new branch, based on GCC 4.7, for migrating the
vtable verification work to GCC. 4.7. I've announced the new branch
on the gcc mailing list. This patch updates the web patch docs to
mention the new branch.
-- Caroline Tice
cmt...@google.com
wwwdocs.patch
Descri
cmt...@google.com
On Wed, Jan 30, 2013 at 2:09 AM, Florian Weimer wrote:
> On 11/01/2012 09:07 PM, Caroline Tice wrote:
>>
>> We have been developing a new security hardening feature for GCC that
>> is designed to detect and handle (during program execution) when a
>
On Wed, Jan 30, 2013 at 9:26 AM, Jason Merrill wrote:
> I'm also touching on the middle-end and library changes, but would
> appreciate a more thorough review from others in those areas.
>
> On 01/23/2013 05:25 PM, Caroline Tice wrote:
>>
>> Index: gcc/cp/g++spec.c
&g
Hello,
I just created a new branch (and announced it on the gcc mailing
list). This patch updates the web page docs to briefly describe the
new branch.
-- Caroline Tice
cmt...@google.com
? my-patch.txt
? htdocs/svn.html.~1.168.~
Index: htdocs/svn.html
On Tue, Sep 27, 2022 at 3:04 AM Lulu Cheng wrote:
>
> v1 - > v2:
>
> 1. When the macro __loongarch_lp64 is defined, the VTV_PAGE_SIZE is set to
> 64K.
> 2. In the vtv_malloc.cc file __vtv_malloc_init function, it does not check
>whether VTV_PAGE_SIZE is equal to the system page size, if the m
.
-- Caroline Tice
cmt...@google.com
On Tue, Sep 27, 2022 at 3:04 AM Lulu Cheng wrote:
>
> v1 - > v2:
>
> 1. When the macro __loongarch_lp64 is defined, the VTV_PAGE_SIZE is set to
> 64K.
> 2. In the vtv_malloc.cc file __vtv_malloc_init function, it does not check
>whether V
On Tue, Oct 11, 2022 at 7:52 PM Lulu Cheng wrote:
>
> 在 2022/10/12 上午4:57, Caroline Tice 写道:
>
> I think that if VTV_PAGE_SIZE is not set to the actual size being used by
> the system, it could result in some unexpected failures. I believe the
> right thing to do in this ca
to avoid the binutils patch being overwritten/lost.
I tested this by running the regression testsuite; there were no regressions.
Is this ok to commit?
-- Caroline Tice
cmt...@google.com
include/ChangeLog
2020-09-09 Caroline Tice
* dwarf2.h (enum dwarf_sect_v5): A new enum section
atch to the person who reported the bug,
and they verified that the patch fixes their issue.
Is this ok to commit?
-- Caroline Tice
cmt...@google.com
libstdc++-v3/ChangeLog
2021-03-10 Caroline Tice
PR libstdc++/99172
* Makefile.in: Regenerate.
* acinc
Adding the libstdc++ mailing list to the patch.
-- Caroline
cmt...@google.com
On Wed, Mar 10, 2021 at 8:50 PM Caroline Tice wrote:
>
> This patch is to fix PR 99172.
>
> Currently when GCC is configured with --enable-vtable-verify, the
> libstdc++-v3 Makefiles add "-fvta
I have updated the patch as you suggested, to filter the
"-fvtable-verify=std" out of AM_CXXFLAGS, and I have verified that it
passes the testsuite with no regressions and fixes the reported bug.
Is this OK to commit now?
-- Caroline Tice
cmt...@google.com
libstdc++-v3/ChangeLog
fvtable-verify=std:vtv_end.o%s} \
+ fvtable-verify=std:vtv_end.o%s}} \
%{static:crtend.o%s; \
shared|static-pie|" PIE_SPEC ":crtendS.o%s; \
:crtend.o%s} " \
ChangeLog entry:
2019-08-12 Caroline Tice
PR other/91396
* config/gnu-user.h (GNU_USER_TARGE
1 - 100 of 106 matches
Mail list logo
