Re: [PATCH] Fix LTO ICEs due to invalid self-referencing fortran character length VAR_DECL chains (PR fortran/88902)

2019-01-19 Thread Tobias Burnus
Hi Jakub, Jakub Jelinek wrote: As the testcase shows, gfc_get_symbol_decl can be called multiple times and we can add the same length multiple times to current or parent function. As addition of a VAR_DECL to those is done by chaining it into the DECL_CHAIN linked list, adding the same VAR_DECL

[PATCH] Fix -Wattribute-alias option

2019-01-19 Thread Bernd Edlinger
Hi, the command line option -Wattribute-alias (w/o the "=1") is currently broken, and only -Wno-attribute-alias is still working, but what is worse, is that the #pragma GCC diagnostic fails to recognize the string "-Wattribute-alias", as it used to do in gcc-8, which breaks the linux warning suppr

Re: [PATCH] String contents hash map key example

2019-01-19 Thread Richard Sandiford
Michael Ploujnikov writes: > I thought it would be useful to others who are new to the GCC codebase > to have an example of how to hash keys based on string contents rather > than pointer addresses (the fact that some hash maps key based on > semi-reliable pointers (due to ggc_mark_stringpool) int

Re: [wwwdocs] Mention AMD GCN on the website

2019-01-19 Thread Gerald Pfeifer
On Thu, 17 Jan 2019, Andrew Stubbs wrote: > How's this? Note the typo in the patch for the main page

[PATCH v2] rs6000: Add missing prototypes for vec_ld/vec_st

2019-01-19 Thread Kewen.Lin
Hi Jakub, Thanks for catching! Hi Segher, Thanks for your suggestion, I just had a testing on BE machine and found the vector double related codes also need to be separated to vsx case. The case has been updated as below, is it OK for trunk? Thanks for your time in advance! gcc/testsuite/C

[patch, fortran] Fix contiguous dummy arguments

2019-01-19 Thread Thomas Koenig
Hello world, the attached patch fixes handling of contiguous dummy arguments when the actual arguments are not contiguous. The patch to trans-expr.c itself was written by Paul and attached to the PR. I just added the test case. Regression-testing revealed some failing scan-tree tests due to dif

Re: [Patch, Fortran] PR 37835 -fno-automatic does not work for derived types with default initalizer

2019-01-19 Thread Thomas Koenig
Hi Dominique, The patch for gcc/fortran/resolve.c is the modernized version of Paul’s patch in comment 4. It causes some regressions due to "Duplicate SAVE » warnings. They are silenced by the patch for gcc/fortran/symbol.c unless -pedantic is used as documented in the change for gcc/fortran/i

[PATCH] i386: Move Intel intrinsics head files to

2019-01-19 Thread H.J. Lu
According to Intel Intrinsics Guide: https://software.intel.com/sites/landingpage/IntrinsicsGuide/ Intel intrinsics should be available by including . This patch moves remaining Intel intrinsics head files from to . OK for trunk? H.J. --- PR target/71659 * config/i386/adxintri

Re: [PATCH] avoid issuing -Warray-bounds during folding (PR 88800)

2019-01-19 Thread Jeff Law
On 1/18/19 4:43 PM, Martin Sebor wrote: > On 1/18/19 2:35 AM, Christophe Lyon wrote: >> Hi Martin, >> >> >> On Thu, 17 Jan 2019 at 02:51, Martin Sebor wrote: >>> >>> On 1/16/19 6:14 PM, Jeff Law wrote: On 1/15/19 8:21 AM, Martin Sebor wrote: > On 1/15/19 4:07 AM, Richard Biener wrote: >>>

Re: [RFC][AArch64] Add support for system register based stack protector canary access

2019-01-19 Thread Jakub Jelinek
On Mon, Dec 03, 2018 at 09:55:36AM +, Ramana Radhakrishnan wrote: > 2018-11-23 Ramana Radhakrishnan > > * config/aarch64/aarch64-opts.h (enum stack_protector_guard): New > * config/aarch64/aarch64.c (aarch64_override_options_internal): > Handle > and put in error

Re: [patch, fortran] Fix contiguous dummy arguments

2019-01-19 Thread Jerry DeLisle
On 1/19/19 7:05 AM, Thomas Koenig wrote: Hello world, the attached patch fixes handling of contiguous dummy arguments when the actual arguments are not contiguous. The patch to trans-expr.c itself was written by Paul and attached to the PR. I just added the test case.  Regression-testing reveal

[PATCH] PR fortran/77960 -- inpute-item can't be function

2019-01-19 Thread Steve Kargl
The attached patch has been tested on x86_64-*-freebsd. PR fortran/77960 uses a procedure pointer to expose the bug, but it applied to any external subprogram. So, the patch checks for the external attribute. OK to commit? 2019-01-19 Steven G. Kargl PR fortran/77960 * io.c (m

Re: [PATCH] PR fortran/77960 -- inpute-item can't be function

2019-01-19 Thread Thomas Koenig
Hi Steve, The attached patch has been tested on x86_64-*-freebsd. PR fortran/77960 uses a procedure pointer to expose the bug, but it applied to any external subprogram. So, the patch checks for the external attribute. OK to commit? OK, and thanks. Regards Thomas

Re: [Patch, Fortran] PR 37835 -fno-automatic does not work for derived types with default initalizer

2019-01-19 Thread Dominique d'Humières
Thanks for the review, committed as r268098. Dominique > Le 19 janv. 2019 à 16:50, Thomas Koenig a écrit : > > Hi Dominique, > >> The patch for gcc/fortran/resolve.c is the modernized version of Paul’s >> patch in comment 4. >> It causes some regressions due to "Duplicate SAVE » warnings. >>

Re: [PATCH v2] rs6000: Add missing prototypes for vec_ld/vec_st

2019-01-19 Thread Segher Boessenkool
Hi Kewen, On Sat, Jan 19, 2019 at 09:27:38PM +0800, Kewen.Lin wrote: > Thanks for your suggestion, I just had a testing on BE machine and found the > vector double related codes also need to be separated to vsx case. The case > has been updated as below, is it OK for trunk? Yes, this is fine.

Re: Patch ping (Re: [PATCH] Fortran include line fixes and -fdec-include support)

2019-01-19 Thread Gerald Pfeifer
Hej Jakub, hej Fortran hackers, On Wed, 21 Nov 2018, Jakub Jelinek wrote: > Like this? Ok for trunk/wwwdocs? > > 2018-11-21 Jakub Jelinek > > * invoke.texi (-fdec-include): Document. how about the refinement below? Gerald Index: gcc-9/changes.html ===

Re: Patch ping (Re: [PATCH] Fortran include line fixes and -fdec-include support)

2019-01-19 Thread Jakub Jelinek
On Sat, Jan 19, 2019 at 11:49:34PM +0100, Gerald Pfeifer wrote: > Hej Jakub, hej Fortran hackers, > > On Wed, 21 Nov 2018, Jakub Jelinek wrote: > > Like this? Ok for trunk/wwwdocs? > > > > 2018-11-21 Jakub Jelinek > > > > * invoke.texi (-fdec-include): Document. > > how about the refine

[PATCH] Use __builtin_is_constant_evaluated some more (PR libstdc++/86590)

2019-01-19 Thread Jakub Jelinek
Hi! The following patch uses __builtin_is_constant_evaluated for __constant_string_p and __constant_char_array_p - in constexpr contexts, all the strings or arrays should be constant, and by doing it this way the compiler should be able to optimize better the callers of these inline functions alre

Re: [PATCH][GCC][DOC] Remove obsolete arm and aarch64 CPU names from invoke.texi

2019-01-19 Thread Gerald Pfeifer
On Thu, 10 Jan 2019, Sam Tebbs wrote: >> I believe this should also be covered in the GCC 9 release notes >> at https://gcc.gnu.org/gcc-9/changes.html ? > Sorry for the late reply. My email filters seem to have stumbled a bit > so I didn't pick this up until now. Would you suggest adding something

Re: [PATCH] PR target/85596 Add --with-multilib-list doc for aarch64

2019-01-19 Thread Gerald Pfeifer
On Thu, 17 Jan 2019, Christophe Lyon wrote: > Ping? I think that kind of patch is OK for stage4? Yes, documentation patches are (essentially) always okay. Gerald

Re: [committed] v2: Machine-readable diagnostic output (PR other/19165)

2019-01-19 Thread Gerald Pfeifer
On Thu, 15 Nov 2018, David Malcolm wrote: > Changed in v2: > * added test coverage > * improved docs > * pass orig_diag_kind to the finalizer callback > > Successfully bootstrapped & regrtested on x86_64-pc-linux-gnu. > Committed to trunk as r266186. Mind adding something to the release notes at