Re: [PATCH] fix a couple of bugs in const string folding (PR 86532)

2018-07-22 Thread Bernd Edlinger
On 07/21/18 00:15, Martin Sebor wrote: > On 07/20/2018 08:51 AM, Bernd Edlinger wrote: >> Martin, >> >> when I look at tree-ssa-forwprop.c: >> >>    str1 = string_constant (src1, &off1); >>    if (str1 == NULL_TREE) >> break; >>    if (!tree_fits

Re: [wwwdocs] Mention LTO link-time issue fixed in gcc 8.2

2018-07-22 Thread Gerald Pfeifer
On Sat, 21 Jul 2018, Gerald Pfeifer wrote: > Thanks, Jan, this looks fine to me. Oops, I missed closing an ; just followed up on your commit to fix that. Gerald Index: changes.html === RCS file: /cvs/gcc/wwwdocs/htdocs/gcc-8/change

Re: [PATCH 1/4] Clean up of new format of -falign-FOO.

2018-07-22 Thread Gerald Pfeifer
On Wed, 18 Jul 2018, Martin Sebor wrote: > I'm seeing lots of warnings for this file: > > /ssd/src/gcc/svn/gcc/align.h:53:32: warning: extended initializer lists only > available with -std=c++11 or -std=gnu++11 With clang version 3.4 (system compiler on FreeBSD 10.x) this is even a hard error and

Re: [PATCH 8/8] Enhance documentation of gcov.

2018-07-22 Thread Gerald Pfeifer
On Fri, 28 Apr 2017, Martin Sebor wrote: >> 2017-04-27 Martin Liska >> >> * doc/gcov.texi: Enhance documentation of gcov. > Since I started picking on this change set I might as well keep > at it ;) Just a tiny nit: the sentence is missing a preposition: > > depending on whether a bas

Re: [PATCH] fix a couple of bugs in const string folding (PR 86532)

2018-07-22 Thread Bernd Edlinger
On 07/21/18 01:58, Martin Sebor wrote: > On 07/20/2018 03:11 PM, Bernd Edlinger wrote: >> I think I have found a valid test case where the latest patch >> does generate invalid code: > > This is due to another bug in string_constant() that's latent > on trunk but that's exposed by the patch.  Trun

New Swedish PO file for 'gcc' (version 8.1.0)

2018-07-22 Thread Translation Project Robot
Hello, gentle maintainer. This is a message from the Translation Project robot. A revised PO file for textual domain 'gcc' has been submitted by the Swedish team of translators. The file is available at: http://translationproject.org/latest/gcc/sv.po (This file, 'gcc-8.1.0.sv.po', has just

Re: [PATCH 1/4] Clean up of new format of -falign-FOO.

2018-07-22 Thread Gerald Pfeifer
On Sun, 22 Jul 2018, Gerald Pfeifer wrote: > With clang version 3.4 (system compiler on FreeBSD 10.x) this is > even a hard error and GCC failed to build. So thanks for fixing > this, Martin! Unfortunately it appears there was another bootstrap failure hidden behind that one: In file included f

Re: [PATCH 1/4] Clean up of new format of -falign-FOO.

2018-07-22 Thread Rainer Orth
Hi Gerald, > On Sun, 22 Jul 2018, Gerald Pfeifer wrote: >> With clang version 3.4 (system compiler on FreeBSD 10.x) this is >> even a hard error and GCC failed to build. So thanks for fixing >> this, Martin! > > Unfortunately it appears there was another bootstrap failure hidden > behind that one

[PATCH] Avoid out of scope access in hsa-dump.c

2018-07-22 Thread Bernd Edlinger
Hi, this fixes an use of a buffer after the block scope in hsa-dump.c: "buf" is assigned to "name" and used after the scope ends in a fprintf. I have not done any real checks, except boot-strapping with all languages. Is it OK for trunk? Thanks Bernd. 2018-07-22 Bernd Edlinger hsa-dump.c (

[C++ PATCH] Avoid code generation changes with -Wnonnull-compare vs. -Wno-nonnull-compare (PR c++/86569)

2018-07-22 Thread Jakub Jelinek
Hi! A couple of -fcompare-debug=-Wsomething PRs have been filed recently, this fixes one of them. Changing code generation based on TREE_NO_WARNING flag which usually gets set only in the warning code, or on warn_* option is undesirable. This patch prevents that kind of folding regardless of the

Re: [C++ PATCH] Avoid code generation changes with -Wnonnull-compare vs. -Wno-nonnull-compare (PR c++/86569)

2018-07-22 Thread Richard Biener
On July 22, 2018 9:15:50 PM GMT+02:00, Jakub Jelinek wrote: >Hi! > >A couple of -fcompare-debug=-Wsomething PRs have been filed recently, >this >fixes one of them. Changing code generation based on TREE_NO_WARNING >flag >which usually gets set only in the warning code, or on warn_* option is >und

[C++ PATCH] Implement P0595R1 - so far as __builtin_is_constant_evaluated rather than std::is_constant_evaluated magic builtin

2018-07-22 Thread Jakub Jelinek
Hi! As part of the PR86590 discussions that the current libstdc++ __constant_string is extremely costly, because we don't fold the __builtin_constant_p in the loop early enough and because Richard doesn't want __builtin_early_constant_p, this patch is an attempt to implement P0595R1 as a builtin (

Re: [PATCH] specify large command line option arguments (PR 82063)

2018-07-22 Thread Martin Sebor
On 07/21/2018 06:42 PM, H.J. Lu wrote: On Fri, Jul 20, 2018 at 1:57 PM, Martin Sebor wrote: On 07/19/2018 04:31 PM, Jeff Law wrote: On 06/24/2018 03:05 PM, Martin Sebor wrote: Storing integer command line option arguments in type int limits options such as -Wlarger-than= or -Walloca-larger-

Re: [PATCH] fix a couple of bugs in const string folding (PR 86532)

2018-07-22 Thread Martin Sebor
On 07/22/2018 02:00 AM, Bernd Edlinger wrote: On 07/21/18 00:15, Martin Sebor wrote: On 07/20/2018 08:51 AM, Bernd Edlinger wrote: Martin, when I look at tree-ssa-forwprop.c: str1 = string_constant (src1, &off1); if (str1 == NULL_TREE) break;

Re: [PATCH] fix a couple of bugs in const string folding (PR 86532)

2018-07-22 Thread Martin Sebor
On 07/22/2018 03:03 AM, Bernd Edlinger wrote: On 07/21/18 01:58, Martin Sebor wrote: On 07/20/2018 03:11 PM, Bernd Edlinger wrote: I think I have found a valid test case where the latest patch does generate invalid code: This is due to another bug in string_constant() that's latent on trunk b

Re: [PATCH] fix a couple of bugs in const string folding (PR 86532)

2018-07-22 Thread Martin Sebor
On 07/22/2018 04:47 PM, Martin Sebor wrote: On 07/22/2018 02:00 AM, Bernd Edlinger wrote: On 07/21/18 00:15, Martin Sebor wrote: On 07/20/2018 08:51 AM, Bernd Edlinger wrote: Martin, when I look at tree-ssa-forwprop.c: str1 = string_constant (src1, &off1); if (s