Re: [PATCH, Libatomic, Darwin] Initial libatomic port for *darwin*.

2014-11-14 Thread Richard Henderson
On 11/13/2014 09:34 PM, Iain Sandoe wrote: >> Um, surely not LOCK_SIZE, but CACHELINE_SIZE. It's the granularity of the >> target region that's at issue, not the size of the lock itself. > > The algorithm I've used is intentionally different from the pthreads-based > posix one... All that would

Re: [PATCH, Pointer Bounds Checker, Builtins instrumentation 2/5] Instrument builtin calls

2014-11-14 Thread Ilya Enkovich
2014-11-14 9:49 GMT+03:00 Jeff Law : > On 11/06/14 05:10, Ilya Enkovich wrote: >> >> Hi, >> >> This patch enables instrumentation of chosen builtin calls. >> >> Thanks, >> Ilya >> -- >> 2014-11-06 Ilya Enkovich >> >> * ipa-chkp.c (chkp_versioning): Clone builtin functions. >> (ch

[AArch64, Patch] Add range-check for Symbol + offset addressing.

2014-11-14 Thread Tejas Belagod
Hi, Following the discussion here https://gcc.gnu.org/ml/gcc-patches/2014-09/msg02237.html, this has been tracked down to a range-checking bug with symbol + offset style addressing with adrp where we allowed any arbitrary offset and this would cause truncation of final addresses when relocat

Re: [PATCH, Libatomic, Darwin] Initial libatomic port for *darwin*.

2014-11-14 Thread Iain Sandoe
Hello Richard, On 14 Nov 2014, at 08:01, Richard Henderson wrote: > On 11/13/2014 09:34 PM, Iain Sandoe wrote: >>> Um, surely not LOCK_SIZE, but CACHELINE_SIZE. It's the granularity of the >>> target region that's at issue, not the size of the lock itself. >> >> The algorithm I've used is inten

Re: [AArch64, Patch] Add range-check for Symbol + offset addressing.

2014-11-14 Thread Andrew Pinski
On Fri, Nov 14, 2014 at 12:12 AM, Tejas Belagod wrote: > > Hi, > > Following the discussion here > https://gcc.gnu.org/ml/gcc-patches/2014-09/msg02237.html, this has been > tracked down to a range-checking bug with symbol + offset style addressing > with adrp where we allowed any arbitrary offset

Re: [PATCH, Pointer Bounds Checker, Builtins instrumentation 1/5] Builtin codes and decls

2014-11-14 Thread Ilya Enkovich
2014-11-14 9:43 GMT+03:00 Jeff Law : > On 11/06/14 04:48, Ilya Enkovich wrote: >> >> -- >> 2014-11-06 Ilya Enkovich >> >> * tree-core.h (built_in_class): Add builtin codes to be used >> by Pointer Bounds Checker for instrumented builtin functions. >> * tree-streamer-in.c:

Re: [PATCH, Libatomic, Darwin] Initial libatomic port for *darwin*.

2014-11-14 Thread Richard Henderson
On 11/14/2014 09:12 AM, Iain Sandoe wrote: > my locks are only 4 bytes [whereas they are > rounded-up-to-n-cachlines(sizeof(pthreads mutext)) for the posix > implementation]. > The items that they are locking are of arbitrary size (at least up to one > page). > > hmmm .. there's something I'm n

The nvptx port

2014-11-14 Thread Jakub Jelinek
Hi! I have some questions about nvptx: 1) you've said that alloca isn't supported, but it seems to be wired up and uses the %alloca documented in the PTX manual, what is the issue with that? %alloca not being actually implemented by the current PTX assembler or translator? Or some lo

Re: [patch] OpenACC fortran front end

2014-11-14 Thread Jakub Jelinek
On Fri, Nov 14, 2014 at 08:56:53AM +0100, Thomas Schwinge wrote: > Hi! > > On Thu, 13 Nov 2014 17:44:40 -0800, Cesar Philippidis > wrote: > > On 11/13/2014 08:43 AM, Jakub Jelinek wrote: > > > Can you please avoid the TODOs in the source? If it is not the right > > > thing, either do something

[PATCH] Merge predicate iteration from match-and-simplify

2014-11-14 Thread Richard Biener
This merges a genmatch IL feature from the branch. Bootstrapped and tested on x86_64-unknown-linux-gnu, applied. Richard. 2014-11-14 Richard Biener * genmatch.c (add_operator): Allow CONSTRUCTOR. (dt_node::gen_kids): Handle CONSTRUCTOR not as GENERIC. (parser::parse_

Re: [PATCH] -fsanitize=unreachable overhaul (PR sanitizer/63839)

2014-11-14 Thread Richard Biener
On Thu, 13 Nov 2014, Marek Polacek wrote: > As Richi pointed in the pr audit trail, instrumenting via folding is > bad. In this case we changed __builtin_unreachable, created by the > inliner, into BUILT_IN_UBSAN_HANDLE_BUILTIN_UNREACHABLE which requires > VOPS, which is a no-no in folding. So t

Re: [PATCH] Remove doubled ECF_LEAF

2014-11-14 Thread Richard Biener
On Thu, 13 Nov 2014, Marek Polacek wrote: > Bootstrapped/regtested on power8-linux, ok for trunk? Looks obvious ;) Thanks, Richard. > 2014-11-13 Marek Polacek > > * tree.c (build_common_builtin_nodes): Remove doubled ECF_LEAF. > > diff --git gcc/tree.c gcc/tree.c > index cf37a19..5c6

Re: [PATCH, Libatomic, Darwin] Initial libatomic port for *darwin*.

2014-11-14 Thread Iain Sandoe
On 14 Nov 2014, at 08:25, Richard Henderson wrote: > On 11/14/2014 09:12 AM, Iain Sandoe wrote: >> my locks are only 4 bytes [whereas they are >> rounded-up-to-n-cachlines(sizeof(pthreads mutext)) for the posix >> implementation]. >> The items that they are locking are of arbitrary size (at lea

Re: LTO streaming of TARGET_OPTIMIZE_NODE

2014-11-14 Thread Richard Biener
On Fri, 14 Nov 2014, Jan Hubicka wrote: > Hi, > here is upated version with bitfields and also tested on PPC64-linux/aix. > I hacked configury to use system awk instead of gawk, so the changes are > hopefully safe. > > OK? Ok. Thanks, Richard. > Honza > > * optc-save-gen.awk: Output cl

Re: [AArch64, Patch] Add range-check for Symbol + offset addressing.

2014-11-14 Thread Tejas Belagod
On 14/11/14 08:19, Andrew Pinski wrote: On Fri, Nov 14, 2014 at 12:12 AM, Tejas Belagod wrote: Hi, Following the discussion here https://gcc.gnu.org/ml/gcc-patches/2014-09/msg02237.html, this has been tracked down to a range-checking bug with symbol + offset style addressing with adrp where w

Re: [Ping] [PATCH, 1/10] two hooks for conditional compare (ccmp)

2014-11-14 Thread Marcus Shawcroft
On 29 October 2014 10:28, Zhenqiang Chen wrote: > > >> -Original Message- >> From: Richard Henderson [mailto:r...@redhat.com] >> Sent: Monday, October 27, 2014 10:56 PM >> To: Zhenqiang Chen >> Cc: gcc-patches@gcc.gnu.org >> Subject: Re: [Ping] [PATCH, 1/10] two hooks for conditional compa

Re: [AArch64, Patch] Add range-check for Symbol + offset addressing.

2014-11-14 Thread Marcus Shawcroft
On 14 November 2014 08:19, Andrew Pinski wrote: > On Fri, Nov 14, 2014 at 12:12 AM, Tejas Belagod wrote: >> >> Hi, >> >> Following the discussion here >> https://gcc.gnu.org/ml/gcc-patches/2014-09/msg02237.html, this has been >> tracked down to a range-checking bug with symbol + offset style addr

Re: [AArch64, Patch] Add range-check for Symbol + offset addressing.

2014-11-14 Thread pinskia
> On Nov 14, 2014, at 12:54 AM, Marcus Shawcroft > wrote: > >> On 14 November 2014 08:19, Andrew Pinski wrote: >>> On Fri, Nov 14, 2014 at 12:12 AM, Tejas Belagod >>> wrote: >>> >>> Hi, >>> >>> Following the discussion here >>> https://gcc.gnu.org/ml/gcc-patches/2014-09/msg02237.html, t

Re: [PATCH 1/3] [AARCH64] Add macro fusion support for cmp/b.X for ThunderX

2014-11-14 Thread Kyrill Tkachov
Hi Andrew, On 14/11/14 00:56, Andrew Pinski wrote: In ThunderX, any 1 cycle arthemantic instruction that produces the flags register, will be fused with a branch. This patch depends on https://gcc.gnu.org/ml/gcc-patches/2014-11/msg01508.html. Note I know bit 1 is going is already going to be us

Re: [Patch AArch64] Fix PR 63724 - Improve immediate generation

2014-11-14 Thread Marcus Shawcroft
On 12 November 2014 16:46, Ramana Radhakrishnan wrote: > v2 , based on Richard's suggestion as well as fixing a bug that I hit in > some more testing at O1. aarch64_internal_mov_immediate should not generate > a temporary for subtarget when not actually "generating" code. > > Tested again on aarc

Re: [patch] OpenACC fortran front end

2014-11-14 Thread Thomas Schwinge
Hi! On Fri, 14 Nov 2014 09:33:13 +0100, Jakub Jelinek wrote: > On Fri, Nov 14, 2014 at 08:56:53AM +0100, Thomas Schwinge wrote: > > On Thu, 13 Nov 2014 17:44:40 -0800, Cesar Philippidis > > wrote: > > > On 11/13/2014 08:43 AM, Jakub Jelinek wrote: > > > > Can you please avoid the TODOs in the s

[PATCH][21/n] Merge from match-and-simplify, more binary patterns

2014-11-14 Thread Richard Biener
The following patch merges binary patterns from the branch that are exercised by fold_stmt and gimple_fold_stmt_to_constant in the process of removing the dispatch of fold_binary from those. I filed PR63862 for a C frontend bug which I noticed because of fixing a fold bug which happily looked thr

Re: [Committed] Fix bug 61997

2014-11-14 Thread Marcus Shawcroft
On 11 November 2014 23:39, Andrew Pinski wrote: > Hi, > The problem here is that aarch64-builtins.c contains gty markers but > does not include gt-aarch64-builtins.h and is not included in the > target_gtfiles list in config.gcc. So sometimes the builtins get > garbage collected when they shoul

Re: [patch, aarch64] additional bics patterns

2014-11-14 Thread Richard Earnshaw
On 13/11/14 17:42, Sandra Loosemore wrote: > On 11/13/2014 10:27 AM, Richard Earnshaw wrote: >> On 13/11/14 17:05, Ramana Radhakrishnan wrote: >>> On Thu, Nov 13, 2014 at 4:55 PM, Sandra Loosemore >>> wrote: This patch to the AArch64 back end adds a couple of additional bics patterns >>

Re: [patch, aarch64] additional bics patterns

2014-11-14 Thread Richard Earnshaw
On 13/11/14 22:44, Sandra Loosemore wrote: > On 11/13/2014 10:47 AM, Andrew Pinski wrote: >> On Thu, Nov 13, 2014 at 9:42 AM, Sandra Loosemore >> wrote: >>> On 11/13/2014 10:27 AM, Richard Earnshaw wrote: On 13/11/14 17:05, Ramana Radhakrishnan wrote: > > On Thu, Nov 13, 2014 at

Re: [PATCH 1/3] [AARCH64] Add macro fusion support for cmp/b.X for ThunderX

2014-11-14 Thread Andrew Pinski
On Fri, Nov 14, 2014 at 1:08 AM, Kyrill Tkachov wrote: > Hi Andrew, > > > On 14/11/14 00:56, Andrew Pinski wrote: >> >> In ThunderX, any 1 cycle arthemantic instruction that produces the flags >> register, will be fused with a branch. This patch depends on >> https://gcc.gnu.org/ml/gcc-patches/20

Re: The nvptx port

2014-11-14 Thread Jakub Jelinek
On Fri, Nov 14, 2014 at 09:29:48AM +0100, Jakub Jelinek wrote: > I have some questions about nvptx: Oh, and 5) I have noticed gcc doesn't generate the .uni suffixes anywhere, while llvm generates them; are those appropriate only when a function is guaranteed to be run unconditionally from th

[Patch, ARM]Fix pattern that is missed for Thumb-1 UAL

2014-11-14 Thread Terry Guo
Hi there, Attached patch intends to fix a pattern that is found still non-UAL when do gcc thumb-1 bootstrap. A test case is reduced and attached. Tested with gcc regression test on pre-v6 thumb1 and v6 thumb1. No regression. Multilib can be built for both of them. Is it OK to trunk? BR, Terry gc

Re: [PATCH] plugin event for C/C++ function definitions

2014-11-14 Thread Richard Biener
On Thu, Nov 13, 2014 at 6:42 PM, Andres Tiraboschi wrote: > Hi, this patch adds a new plugin event PLUGIN_START_FUNCTION and > PLUGIN_FINISH_FUNCTION that are invoked at start_function and finish_function > respectively in the C and C++ frontends. > PLUGIN_START_FUNCTION is called before parsing

Re: [PATCH 2/4] New data structure for cgraph_summary introduced.

2014-11-14 Thread Richard Biener
On Thu, Nov 13, 2014 at 4:50 PM, Jan Hubicka wrote: >> gcc/ChangeLog: >> >> 2014-11-12 Martin Liska >> >> * Makefile.in: New object file is added. >> * cgraph.h (symbol_table::allocate_cgraph_symbol): Summary UID >> is filled up. >> * cgraph_summary.c: New file. >>

Re: PATCH: PR bootstrap/63784: [5 Regression] profiledbootstrap failure with bootstrap-lto

2014-11-14 Thread Richard Biener
On Fri, Nov 14, 2014 at 12:15 AM, H.J. Lu wrote: > On Tue, Nov 11, 2014 at 8:02 AM, H.J. Lu wrote: >> On Mon, Nov 10, 2014 at 11:42 AM, H.J. Lu wrote: >>> On Mon, Nov 10, 2014 at 5:44 AM, Richard Biener >>> wrote: On Mon, Nov 10, 2014 at 2:43 PM, Jakub Jelinek wrote: > On Mon, Nov 10,

"openacc" Bugzilla keyword (was: [patch] OpenACC fortran front end)

2014-11-14 Thread Thomas Schwinge
Hi! On Fri, 14 Nov 2014 10:21:47 +0100, I wrote: > created. Committed to gomp-4_0-branch in r217549: commit 4a4f1ca48781ac08d2d51ba1a08210d8c8ca7528 Author: tschwinge Date: Fri Nov 14 10:19:53 2014 + libgomp documentation, R

Re: [PATCH, Libatomic, Darwin] Initial libatomic port for *darwin*.

2014-11-14 Thread Richard Henderson
On 11/14/2014 09:44 AM, Iain Sandoe wrote: > or do you think that a scheme to lock variable-sized chunks cannot work? It certainly can't work while > +void > +libat_lock_1 (void *ptr) > +{ > + LockLock (&locks[addr_hash (ptr, 1)]); > +} doesn't have the true size. r~

Re: bitmap fix for current

2014-11-14 Thread Richard Biener
On Fri, Nov 14, 2014 at 2:10 AM, Jeff Law wrote: > On 11/13/14 12:37, Mike Stump wrote: >> >> I was doing a merge, and it failed to even compile the runtime >> libraries due to checking in bitmap. bitmap goes to remove set bits >> from the bitmap (the second hunk in a two hunk set), and it fails

Re: [PATCH] Add a way to mark regions of code which assume that the GC won't run

2014-11-14 Thread Richard Biener
On Fri, Nov 14, 2014 at 2:19 AM, Jeff Law wrote: > On 11/13/14 08:28, David Malcolm wrote: > It was pointed out to me on IRC that I could instead use RAII for this, so here's an alternative version of the patch that puts it in a class, so that you can put: auto_assert_

Re: OpenACC middle end changes

2014-11-14 Thread Jakub Jelinek
On Fri, Nov 14, 2014 at 11:28:15AM +0100, Richard Biener wrote: > > This patch is based on the last merge of trunk into gomp-4_0-branch, > > 9be82689 (trunk r216846, 2014-10-29), and still includes an old version > > of the offloading patches, as currently present on gomp-4_0-branch. > > We're alre

[RFC: AArch64] Parametrically set defaults for function and jump alignment

2014-11-14 Thread James Greenhalgh
Hi, We currently do not set any interesting default values for jump and function alignment in AArch64. I've made the formula for these values derive from the issue rate of the processor as so: jumps: 4 * processor issue-rate (rounded down to nearest power of two) functions: 4 * processor iss

Re: [PATCH 5/5] use vec in lto_tree_ref_table

2014-11-14 Thread Richard Biener
On Thu, Nov 13, 2014 at 6:55 AM, wrote: > From: Trevor Saunders > > Hi, > > gengtype fails to create valid user marking functions for this type, which is > fixed by using vec here (which seems cleaner anyway). > > bootstrapped + regtested powerpc64-linux (gcc 110 since gcc20 died) ok? Ok. Than

Re: libsanitizer merge from upstream r221802

2014-11-14 Thread Christophe Lyon
On 13 November 2014 21:44, Konstantin Serebryany wrote: > On Thu, Nov 13, 2014 at 1:16 AM, Jakub Jelinek wrote: >> On Wed, Nov 12, 2014 at 05:35:48PM -0800, Konstantin Serebryany wrote: >>> Here is one more merge of libsanitizer (last one was in Sept). >>> >>> Tested on x86_64 Ubuntu 14.04 like t

Re: [RFC: AArch64] Parametrically set defaults for function and jump alignment

2014-11-14 Thread Andrew Pinski
On Fri, Nov 14, 2014 at 2:35 AM, James Greenhalgh wrote: > > Hi, > > We currently do not set any interesting default values for jump and function > alignment in AArch64. I've made the formula for these values derive from > the issue rate of the processor as so: > > jumps: 4 * processor issue-rat

[PATCH 0/3][AArch64]More intrinsics/builtins improvements

2014-11-14 Thread Alan Lawrence
These three are logically independent, but all on a common theme, and I've tested them all together by bootstrapped + check-gcc on aarch64-none-elf cross-tested check-gcc on aarch64_be-none-elf Ok for trunk?

Re: Follow-up to PR51471

2014-11-14 Thread Eric Botcazou
> I wonder how many other problems of this nature are lurking in reorg.c. > For example steal_delay_list_from_{target,fallthrough} or the code > which searches for arithmetic at the branch target, and puts the > opposite insn in a delay slot. Right, and the latter has already been dealt with by Ri

[PATCH 1/3][AArch64]Replace __builtin_aarch64_createv1df with a cast, cleanup

2014-11-14 Thread Alan Lawrence
Now that float64x1_t is a vector, casting to it from a unit64_t causes the bit pattern to be reinterpreted, just as vcreate_f64 should. (Previously when float64x1_t was still a scalar, casting caused a conversion.) Hence, replace the __builtin with a cast. None of the other variants of the aarch

Re: [PATCH][sched-deps] Remove needless check for modified_in_p when trying to fuse two non-conditional jump insns

2014-11-14 Thread Kyrill Tkachov
On 14/11/14 05:17, Jeff Law wrote: On 11/13/14 07:09, Kyrill Tkachov wrote: I've updated the documentation for the hook. The testcase I was looking at involves fusing the AArch64 adrp+add instructions and depends on the backend implementation of the matching code, under review currently at htt

Re: [PATCH, trivial][AArch64] Fix mode iterator for *aarch64_simd_ld1r pattern

2014-11-14 Thread Marcus Shawcroft
On 13 November 2014 06:14, Yangfei (Felix) wrote: > Hi, > > We find that the VALLDI mode iterator used in *aarch64_simd_ld1r > pattern is not appropriate. > The reason is that it's impossible to get a new operand of DImode by > vec_duplicating an operand of the same mode. > So this patch j

[PATCH 2/3][AArch64] Extend aarch64_simd_vec_set pattern, replace asm for vld1_lane

2014-11-14 Thread Alan Lawrence
The vld1_lane intrinsic is currently implemented using inline asm. This patch replaces that with a load and a straightforward use of vset_lane (this gives us correct bigendian lane-flipping in a simple manner). Naively this would produce assembler along the lines of (for vld1_lane_u8):

[PATCH 3/3][AArch64]Replace temporary assembler for vld1_dup

2014-11-14 Thread Alan Lawrence
This patch replaces the inline asm for vld1_dup intrinsics with a vdup_n_ and a load from the pointer. The existing *aarch64_simd_ld1r insn, combiner, etc., are quite capable of generating the expected single ld1r instruction from this. (I've verified by inspecting assembler output.) gcc/Chang

Re: [PATCH 8/9] Negative numbers added for sreal class.

2014-11-14 Thread Richard Biener
On Thu, Nov 13, 2014 at 1:35 PM, mliska wrote: > gcc/ChangeLog: > > 2014-11-13 Martin Liska > > * predict.c (propagate_freq): More elegant sreal API is used. > (estimate_bb_frequencies): New static constants defined by sreal > replace precomputed ones. > * sreal.

Re: [RFC: AArch64] Parametrically set defaults for function and jump alignment

2014-11-14 Thread James Greenhalgh
On Fri, Nov 14, 2014 at 10:42:27AM +, Andrew Pinski wrote: > On Fri, Nov 14, 2014 at 2:35 AM, James Greenhalgh > wrote: > > > > Hi, > > > > We currently do not set any interesting default values for jump and function > > alignment in AArch64. I've made the formula for these values derive from

Re: [PATCH 2/3] [AARCH64] Add scheduler for ThunderX

2014-11-14 Thread Marcus Shawcroft
On 14 November 2014 00:56, Andrew Pinski wrote: > This adds the schedule model for ThunderX. There are a few TODOs in that > not all of the SIMD is model currently. Also the idea of a simple > shift/extend is not modeled and all cases where there is a shift/extend > is considered as non simple an

Re: system.h vs. C++ STL headers again

2014-11-14 Thread Richard Biener
On Fri, Nov 14, 2014 at 8:18 AM, Jakub Jelinek wrote: > On Tue, Nov 11, 2014 at 11:46:55AM +0100, Richard Biener wrote: >> > BTW: There are lots of places where std::swap can be used, a nice >> > search-and-replace task for someone to start with gcc development. ;) >> >> Agreed ;) Note that we ha

Re: [changes.html] Document -fdiagnostics-color= default changes

2014-11-14 Thread Richard Biener
On Fri, Nov 14, 2014 at 8:42 AM, Jakub Jelinek wrote: > On Thu, Nov 13, 2014 at 05:54:46PM -0700, Jeff Law wrote: >> On 11/12/14 15:33, Jakub Jelinek wrote: >> >This patch makes the -fdiagnostics-color= default configurable, and >> >changes the default (if no configure option is specified for it)

Re: [PATCH] -fsanitize=unreachable overhaul (PR sanitizer/63839)

2014-11-14 Thread Marek Polacek
On Fri, Nov 14, 2014 at 09:36:40AM +0100, Richard Biener wrote: > So please leave existing non-cold things as non-cold. > > > Bootstrapped/regtested on power8-linux, ok for trunk? > > Ok with that change. Thanks, this is the version with the builtins.def hunk dropped. Applying to trunk. 2014-1

Re: system.h vs. C++ STL headers again

2014-11-14 Thread Jakub Jelinek
On Fri, Nov 14, 2014 at 11:57:57AM +0100, Richard Biener wrote: > > ? There are also some comments about stdarg.h and stdio.h ordering, > > dunno what it comes from and if it is still relevant when we require > > C++ compiler. > > I think we should simply discourage people from using sstream for

Re: [RFC: AArch64] Parametrically set defaults for function and jump alignment

2014-11-14 Thread Marcus Shawcroft
On 14 November 2014 10:50, James Greenhalgh wrote: > On Fri, Nov 14, 2014 at 10:42:27AM +, Andrew Pinski wrote: >> On Fri, Nov 14, 2014 at 2:35 AM, James Greenhalgh >> wrote: >> > >> > Hi, >> > >> > We currently do not set any interesting default values for jump and >> > function >> > alignm

Re: The nvptx port

2014-11-14 Thread Bernd Schmidt
Hi Jakub, I have some questions about nvptx: 1) you've said that alloca isn't supported, but it seems to be wired up and uses the %alloca documented in the PTX manual, what is the issue with that? %alloca not being actually implemented by the current PTX assembler or translator? Y

Re: [arm][patch] fix arm_neon_ok check on !arm_arch7

2014-11-14 Thread Andrew Stubbs
On 07/11/14 10:35, Andrew Stubbs wrote: if armv6 never co-exist with NEON, personally I think your original patch is better because TARGET_NEON generally will be used when all options are processed. any way, this needs gate keeper's approval. Ping, Richard. Ping.

Re: system.h vs. C++ STL headers again

2014-11-14 Thread Richard Biener
On Fri, Nov 14, 2014 at 12:03 PM, Jakub Jelinek wrote: > On Fri, Nov 14, 2014 at 11:57:57AM +0100, Richard Biener wrote: >> > ? There are also some comments about stdarg.h and stdio.h ordering, >> > dunno what it comes from and if it is still relevant when we require >> > C++ compiler. >> >> I th

Re: [Patch ARM-AArch64/testsuite] More Neon intrinsics executable tests

2014-11-14 Thread Marcus Shawcroft
On 12 November 2014 13:11, Christophe Lyon wrote: > Hi, > > The attached patch adds a few more tests to the recently added > advsimd-intrinsics series. > > OK for trunk? > > Christophe. > > 2014-11-12 Christophe Lyon > > * gcc.target/aarch64/advsimd-intrinsics/vcls.c: New test. > * gcc.

Re: The nvptx port

2014-11-14 Thread Bernd Schmidt
On 11/14/2014 11:01 AM, Jakub Jelinek wrote: On Fri, Nov 14, 2014 at 09:29:48AM +0100, Jakub Jelinek wrote: I have some questions about nvptx: Oh, and 5) I have noticed gcc doesn't generate the .uni suffixes anywhere, while llvm generates them; are those appropriate only when a function

Re: [PATCH] Optimize ASAN_CHECK checks

2014-11-14 Thread Dodji Seketeli
Jakub Jelinek writes: > On Wed, Nov 12, 2014 at 02:09:59PM +0300, Yury Gribov wrote: > > >For asan you're right, we can have addresses of decls there etc. > > >If you have spare cycles, feel free to take over the patch and adjust it. > > > > I guess I'd wait when this gets to trunk? > > Ok, in

Re: system.h vs. C++ STL headers again

2014-11-14 Thread Bernd Schmidt
On 11/14/2014 12:03 PM, Jakub Jelinek wrote: On Fri, Nov 14, 2014 at 11:57:57AM +0100, Richard Biener wrote: ? There are also some comments about stdarg.h and stdio.h ordering, dunno what it comes from and if it is still relevant when we require C++ compiler. I think we should simply discoura

Re: libsanitizer merge from upstream r221802

2014-11-14 Thread Uros Bizjak
Hello! > Here is one more merge of libsanitizer (last one was in Sept). > > Tested on x86_64 Ubuntu 14.04 like this: > rm -rf */{*/,}libsanitizer && make -j 50 > make -j 40 -C gcc check-g{cc,++} > RUNTESTFLAGS='--target_board=unix\{-m32,-m64\} asan.exp' && \ > make -j 40 -C gcc check-g{cc,++} > RU

Re: [RFC: AArch64] Parametrically set defaults for function and jump alignment

2014-11-14 Thread Ramana Radhakrishnan
On Fri, Nov 14, 2014 at 11:11 AM, Marcus Shawcroft wrote: > On 14 November 2014 10:50, James Greenhalgh wrote: >> On Fri, Nov 14, 2014 at 10:42:27AM +, Andrew Pinski wrote: >>> On Fri, Nov 14, 2014 at 2:35 AM, James Greenhalgh >>> wrote: >>> > >>> > Hi, >>> > >>> > We currently do not set an

Re: The nvptx port

2014-11-14 Thread Jakub Jelinek
On Fri, Nov 14, 2014 at 12:09:03PM +0100, Bernd Schmidt wrote: > >I have some questions about nvptx: > >1) you've said that alloca isn't supported, but it seems > >to be wired up and uses the %alloca documented in the PTX > >manual, what is the issue with that? %alloca not being actually >

Re: system.h vs. C++ STL headers again

2014-11-14 Thread Jakub Jelinek
On Fri, Nov 14, 2014 at 12:27:52PM +0100, Bernd Schmidt wrote: > On 11/14/2014 12:03 PM, Jakub Jelinek wrote: > >On Fri, Nov 14, 2014 at 11:57:57AM +0100, Richard Biener wrote: > >>>? There are also some comments about stdarg.h and stdio.h ordering, > >>>dunno what it comes from and if it is still

Re: [PATCH] Peg down -(-A) -> A transformation

2014-11-14 Thread Marek Polacek
On Wed, Nov 12, 2014 at 11:53:19AM +0100, Richard Biener wrote: > Err - please adjust fold_negate_expr instead. Like this? (It's not best that for -trapv/-fsanitize=s-i-o we don't emit compile-time warning "integer overflow in expression" for -INT_MIN, because the warning relies on the folding.)

Re: [PATCH] Peg down -(-A) -> A transformation

2014-11-14 Thread Richard Biener
On Fri, 14 Nov 2014, Marek Polacek wrote: > On Wed, Nov 12, 2014 at 11:53:19AM +0100, Richard Biener wrote: > > Err - please adjust fold_negate_expr instead. > > Like this? > > (It's not best that for -trapv/-fsanitize=s-i-o we don't emit > compile-time warning "integer overflow in expression" f

Re: [PATCH] Optimize ASAN_CHECK checks

2014-11-14 Thread Jakub Jelinek
On Fri, Nov 14, 2014 at 12:25:37PM +0100, Dodji Seketeli wrote: > > + /* True if there is a block with HAS_FREEING_CALL_P flag set > > + on any a path between imm(BB) and BB. */ > > s/a//. > > Also, I'd rather say "on any path between an immediate dominator of > BB, denoted imm(BB), and BB"

[gomp4] Merge trunk r217483 (2014-11-13) into gomp-4_0-branch

2014-11-14 Thread Thomas Schwinge
Hi! In r217554, I have committed a merge from trunk r217483 (2014-11-13) into gomp-4_0-branch. This is just before the first "offloading" commit in trunk, so this revision of gomp-4_0-branch can now serve as a basis for merging the gomp-4_0-branch changes with the offloading changes, which are th

Re: [Patch ARM-AArch64/testsuite] More Neon intrinsics executable tests

2014-11-14 Thread Christophe Lyon
On 14 November 2014 12:17, Marcus Shawcroft wrote: > On 12 November 2014 13:11, Christophe Lyon wrote: >> Hi, >> >> The attached patch adds a few more tests to the recently added >> advsimd-intrinsics series. >> >> OK for trunk? >> >> Christophe. >> >> 2014-11-12 Christophe Lyon >> >> * gc

[patch] Fix mangling of ABI-tagged std::wstring

2014-11-14 Thread Jonathan Wakely
Jason approved this yesterday on IRC. Tested powerpc64-linux, committed to trunk. commit 9a8efcc0e2068abb51aaf513b4a7ed262454cd1e Author: Jonathan Wakely Date: Fri Nov 14 11:00:24 2014 + gcc/cp: * mangle.c (find_substitution): Look for abi_tag on class templates. gcc/tes

Re: [PATCH] Optimize ASAN_CHECK checks

2014-11-14 Thread Dodji Seketeli
Jakub Jelinek writes: >> I am not sure, but I am wondering if we shouldn't save the previous uid >> of 'stmt' here before setting it, and then restore it before getting out >> of this function. > > No, gimple uids are AFAIK undefined at the start of passes, passes that use > them are supposed to

Re: [PATCH] Optimize ASAN_CHECK checks

2014-11-14 Thread Jakub Jelinek
On Fri, Nov 14, 2014 at 01:06:52PM +0100, Dodji Seketeli wrote: > Jakub Jelinek writes: > > >> I am not sure, but I am wondering if we shouldn't save the previous uid > >> of 'stmt' here before setting it, and then restore it before getting out > >> of this function. > > > > No, gimple uids are A

[changes.html] Document -fdiagnostics-color= default changes

2014-11-14 Thread Manuel López-Ibáñez
> > C family > > +The -fdiagnostics-color= option default is now > +configurable at GCC configury time using > +--with-diagnostics-color=, can default to > +auto - the new default unless configured otherwise, > +where diagnostics is colorized by default when emitted to term

Re: The nvptx port

2014-11-14 Thread Bernd Schmidt
I'm adding Thomas and Cesar to the Cc list, they may have more insight into CUDA library questions as I haven't really looked into that part all that much. On 11/14/2014 12:39 PM, Jakub Jelinek wrote: On Fri, Nov 14, 2014 at 12:09:03PM +0100, Bernd Schmidt wrote: I have some questions about n

Re: [changes.html] Document -fdiagnostics-color= default changes

2014-11-14 Thread Jakub Jelinek
On Fri, Nov 14, 2014 at 01:14:02PM +0100, Manuel López-Ibáñez wrote: > > > > C family > > > > +The -fdiagnostics-color= option default is now > > +configurable at GCC configury time using > > +--with-diagnostics-color=, can default to > > +auto - the new default unless configur

[patch] Define new std::ios_base::failure with abi_tag("cxx11")

2014-11-14 Thread Jonathan Wakely
This adds system_error support to iostreams, including the required base class changes to std::ios_base::failure. The abi_tag is used to make it a distinct type. This changes the type of I/O exceptions thrown by the library but exceptions are very rarely used with iostreams. Tested powerpc64-lin

Re: [PATCH] Optimize ASAN_CHECK checks

2014-11-14 Thread Richard Biener
On Fri, 14 Nov 2014, Jakub Jelinek wrote: > On Fri, Nov 14, 2014 at 01:06:52PM +0100, Dodji Seketeli wrote: > > Jakub Jelinek writes: > > > > >> I am not sure, but I am wondering if we shouldn't save the previous uid > > >> of 'stmt' here before setting it, and then restore it before getting out

[PATCH] Fix patch mangling with --inline option in mklog

2014-11-14 Thread Tom de Vries
Diego, I noticed that a patch processed with mklog --inline got mangled. In mklog, first we read the .diff file into array diff_lines. Then, in the case of --inline, at the end we expect diff_lines still to contain the .diff file. That's not the case however, and that causes the mangling. T

Re: [PATCH 2/9] New template fibonacci_heap class introduced.

2014-11-14 Thread Florian Weimer
On 11/13/2014 09:06 PM, mliska wrote: + Insert: O(2) amortized. O(1) actual. This does not make much sense. Typo? -- Florian Weimer / Red Hat Product Security

Re: [PATCH 0/4][Vectorizer] Reductions: replace VEC_RSHIFT_EXPR with VEC_PERM_EXPR

2014-11-14 Thread Alan Lawrence
Ah, I didn't realize Loongson was little-endian only. In that case (with mid-end reductions-via-shifts changes pushed) I don't think I have actually broken anything, or at least, no MIPS platform that exists :). However, yes, that would seem a safe bet (and simpler than my linked patch that pr

Re: [PATCH] Optimize ASAN_CHECK checks

2014-11-14 Thread Jakub Jelinek
On Fri, Nov 14, 2014 at 01:16:36PM +0100, Richard Biener wrote: > > That would be indeed nice (similarly for other stuff that we expect to be > > undefined on pass boundaries, or expect to be in certain state at pass > > boundaries; in the former case set before uses, and don't care about what > >

Re: The nvptx port

2014-11-14 Thread Jakub Jelinek
On Fri, Nov 14, 2014 at 01:12:40PM +0100, Bernd Schmidt wrote: > >:(. So what other option one has to implement something like TLS, even > >using inline asm or similar? There is %tid, so perhaps indexing some array > >with %tid? > > That ought to work. For performance you'd want that array in .s

[PATCH] Fix gimple_fold_stmt_to_constant regression

2014-11-14 Thread Richard Biener
Following up https://gcc.gnu.org/ml/gcc-patches/2014-10/msg01233.html and fixing the regressions this caused as soon as I removed the dispatch to fold_unary (and more regressions it would have caused if I managed to finish the idea to also remove the dispatches to fold_binary and fold_ternary...)

Re: The nvptx port

2014-11-14 Thread Bernd Schmidt
On 11/14/2014 01:36 PM, Jakub Jelinek wrote: Any way to query those limits? Size of .shared memory, number of threads in warp, number of warps, etc.? I'd have to google most of that. There seems to be a WARP_SZ constant available in ptx to get the size of the warp. In OpenACC, are all work

Re: Add used_by_single_function flag for static variables

2014-11-14 Thread Bernhard Reutner-Fischer
On 14 November 2014 00:44, Jan Hubicka wrote: >> Honza, >> >> On 23 June 2014 06:24, Jan Hubicka wrote: >> >> > --- lto-cgraph.c(revision 211881) >> > +++ lto-cgraph.c(working copy) >> > @@ -614,6 +614,7 @@ lto_output_varpool_node (struct lto_simp >> > /* in_other_partit

[match-and-simplify] Merge from trunk

2014-11-14 Thread Richard Biener
Brings back the last stage1 merge. I'll followup on the trunk status of match-and-simplify on monday - development will now continue on the branch. Richard. 2014-11-14 Richard Biener Merge from trunk r217546 through r217560. Brings back next merge piece.

[PATCH] Add force option to find_best_rename_reg in regrename pass

2014-11-14 Thread Thomas Preud'homme
We are planning to introduce a new optimization in aarch64 backend, similar to the FP load balancing pass in the LLVM project [1]. This pass would be core specific and involve doing some register renaming. An RFC version of this patch should be posted later today. As part of this pass, we want t

Re: [C++ Patch] Add maybe_constant_folded_value

2014-11-14 Thread Paolo Carlini
Hi, On 11/14/2014 03:35 AM, Jason Merrill wrote: On 11/13/2014 04:31 PM, Paolo Carlini wrote: I think this should be replaced with fold_ if (processing_template_decl) in build_enumerator. Ok. The value can be NULL_TREE, thus in a straightforward change (per the below) I have to check for that,

Re: [C++ Patch] Add maybe_constant_folded_value

2014-11-14 Thread Jason Merrill
On 11/14/2014 08:46 AM, Paolo Carlini wrote: +/* Like maybe_constant_value but first fully constant fold the argument. */ "but first fully instantiate the argument." OK with that change, thanks. Jason

Re: [PATCH 2/4] New data structure for cgraph_summary introduced.

2014-11-14 Thread Martin Liška
On 11/13/2014 04:50 PM, Jan Hubicka wrote: gcc/ChangeLog: 2014-11-12 Martin Liska * Makefile.in: New object file is added. * cgraph.h (symbol_table::allocate_cgraph_symbol): Summary UID is filled up. * cgraph_summary.c: New file. * cgraph_summary.h: Ne

Re: [PATCH 4/4] Data structure is used for inline_summary struct.

2014-11-14 Thread Martin Liška
On 11/13/2014 05:04 PM, Jan Hubicka wrote: + if (!inline_summary_summary) +inline_summary_summary = (inline_summary_cgraph_summary *) inline_summary_cgraph_summary::create_ggc (symtab); Hehe, this is funny naming scheme. Peraps inline_summary_d and inline_summary_t for the data and type?

Re: libsanitizer merge from upstream r221802

2014-11-14 Thread Uros Bizjak
On Fri, Nov 14, 2014 at 12:31 PM, Uros Bizjak wrote: >> Here is one more merge of libsanitizer (last one was in Sept). >> >> Tested on x86_64 Ubuntu 14.04 like this: >> rm -rf */{*/,}libsanitizer && make -j 50 >> make -j 40 -C gcc check-g{cc,++} >> RUNTESTFLAGS='--target_board=unix\{-m32,-m64\} a

Re: [Patch, ARM]Fix pattern that is missed for Thumb-1 UAL

2014-11-14 Thread Ramana Radhakrishnan
On 14/11/14 10:02, Terry Guo wrote: Hi there, Attached patch intends to fix a pattern that is found still non-UAL when do gcc thumb-1 bootstrap. A test case is reduced and attached. Tested with gcc regression test on pre-v6 thumb1 and v6 thumb1. No regression. Multilib can be built for both of

Re: libsanitizer merge from upstream r221802

2014-11-14 Thread Jakub Jelinek
On Fri, Nov 14, 2014 at 03:11:16PM +0100, Uros Bizjak wrote: > The missing definition in system's /usr/include/linux/types.h is protected > with: > > typedef __u16 __bitwise __le16; > typedef __u16 __bitwise __be16; > typedef __u32 __bitwise __le32; > typedef __u32 __bitwise __be32; > #if defined

[PATCH][AArch64] Adjust generic move costs

2014-11-14 Thread Wilco Dijkstra
Hi, This patch adjusts the generic move costs to better reflect the INT<->FP move costs used in the various core specific cost tables. The intention of these generic costs is that they provide reasonable performance across a range of cores without unduly pessimizing any one specific core. This

Re: PATCH: Don't assume modern glibc for x86 Android targets

2014-11-14 Thread H.J. Lu
On Thu, Nov 13, 2014 at 09:32:07PM -0800, H.J. Lu wrote: > For i[34567]86-*-linux* and x86_64-*-linux* targets, config.gcc assumes > modern glibc and set default_gnu_indirect_function to yes. That is wrong > for i[34567]86-*-linux-android* and x86_64-*-linux-android* targets. > This patch fixes it

Re: [PATCH] DW_AT_APPLE_* DWARF extensions.

2014-11-14 Thread Andrew Burgess
* Jakub Jelinek [2014-11-13 14:13:42 +0100]: > On Thu, Nov 13, 2014 at 01:21:21PM +0100, Andrew Burgess wrote: > > I had a look around and couldn't find anything helpful. The best I > > can offer would be the current path within the llvm source code where > > these are defined. Would that be su

Re: [PATCH 7/8] Model cache auto-prefetcher in scheduler

2014-11-14 Thread Maxim Kuvyrkov
On Nov 14, 2014, at 4:57 AM, Vladimir Makarov wrote: > On 2014-10-21 12:06 AM, Maxim Kuvyrkov wrote: > ... > I'd prefer symbolic constants for dont_delay. Also the address can contains > other parts, e.g. index for some targets. It is not necessary to change the > code but a comment would be

  1   2   3   >