Re: [committed] Fix #pragma omp simd with local address taken variables (PR c/59984)

2014-02-09 Thread Dominique Dhumieres
Jakub, The test gcc.dg/vect/pr59984.c fails on targets using an as that does not support avx instructions (e.g., darwin). TIA Dominique

Re: [Patch, fortran] PR34928 - Extension: volatile common blocks

2014-02-09 Thread Tobias Burnus
Janus Weil wrote: 2014-02-08 22:47 GMT+01:00 Steve Kargl : I suppose we can fix that issue. I forget the procedure on getting 'write after approval' access. >From http://gcc.gnu.org/svnwrite.html#policies: Towards the top is the following link: https://sourceware.org/cgi-bin/pdw/ps_form.cg

Re: [Patch, fortran] PR59026 - ELEMENTAL procedure with VALUE arguments emits wrong code

2014-02-09 Thread Richard Biener
On February 8, 2014 6:48:08 PM GMT+01:00, Paul Richard Thomas wrote: >Dear All, > >This is another corner of a corner case that is not a regression but >fixes a wrong-code-on-valid. > >At present, an actual argument of an elemental procedure with the >VALUE attribute is not passed by value. The

Re: [Patch, fortran] PR57522 - [F03] ASSOCIATE construct creates array descriptor with incorrect stride for derived type array component

2014-02-09 Thread Richard Biener
On February 8, 2014 5:08:52 PM GMT+01:00, Paul Richard Thomas wrote: >Dear All, > >I am aware that we are in stage 4 but this wrong-code-on-valid PR is >confined to a corner of a corner and so I am certain that it can be >safely applied - OK, Richie? Ok with me. Richard. >This patch follows th

[MIPS] Update libstdc++-v3 baseline symbols

2014-02-09 Thread Richard Sandiford
David Edelsohn writes: >> On Sun, Jan 26, 2014 at 11:12 AM, Richard Sandiford > wrote: >> [adding libstdc++@] >> >> Bill Schmidt writes: >>> It was recently pointed out to me that our new powerpc64le-linux-gnu >>> target does not yet have a corresponding directory in libstdc >>> ++-v3/config/abi

Re: [PATCH, fortran/52879] RANDOM_SEED revisited

2014-02-09 Thread Dominique Dhumieres
Steve, First, it is needed to remove the line mpz_t put_size, get_size; in gcc/fortran/check.c, otherwise compiling the file with -Werror (default) fails. Second, the patch breaks the interface of RANDOM_SEED(GET/PUT...) as shown for gfortran.dg/random_seed_1.f90 and the original test in pr52

print quotes around )

2014-02-09 Thread Prathamesh Kulkarni
A trivial fix to print quotes around ) in libcpp/macro.c OK for trunk ? * macro.c (parse_params): print quote around ) in call to cpp_error() in case CPP_EOF Index: libcpp/macro.c === --- libcpp/macro.c(revision 207627) +++ libcp

{GRAPHITE] Replacement of isl_int by isl_val

2014-02-09 Thread Mircea Namolaru
Patch for replacement of the isl_int (obsolete) by isl_val. No regressions for c/c++/fortran on x86-64 Linux.2014-02-09 Mircea Namolaru Replacement of isl-int by isl_val * graphite-clast-to-gimple.c: include isl/val.h, isl/val_gmp.h (compute_bounds_for_param): use

Re: print quotes around )

2014-02-09 Thread Prathamesh Kulkarni
On Sun, Feb 9, 2014 at 8:31 PM, Prathamesh Kulkarni wrote: > A trivial fix to print quotes around ) in libcpp/macro.c > OK for trunk ? Will not work for if pfile->cb.error callback does not recognize %< and %> (maybe clients other than c, c++ front-ends ?). So we cannot include %< and %> in the er

Re: [MIPS] Update libstdc++-v3 baseline symbols

2014-02-09 Thread Jonathan Wakely
On 09/02/14 14:19 +, Richard Sandiford wrote: Thanks. I finally got around to doing this for mips64-linux-gnu, as below. It looks like the current symbols were taken in the middle of the 3.4.11 window so the only changes were to add new symbols to that and future versions. 32/ logically fo

Re: [PATCH, fortran/52879] RANDOM_SEED revisited

2014-02-09 Thread Steve Kargl
On Sun, Feb 09, 2014 at 03:31:09PM +0100, Dominique Dhumieres wrote: > Steve, > > First, it is needed to remove the line > > mpz_t put_size, get_size; > > in gcc/fortran/check.c, otherwise compiling the file with -Werror > (default) fails. OK. > Second, the patch breaks the interface of RAND

Re: [Patch, fortran] PR59026 - ELEMENTAL procedure with VALUE arguments emits wrong code

2014-02-09 Thread Paul Richard Thomas
Dear All, Committed as revision 207645 - thanks for review and RM OK. Cheers Paul On 9 February 2014 13:55, Richard Biener wrote: > On February 8, 2014 6:48:08 PM GMT+01:00, Paul Richard Thomas > wrote: >>Dear All, >> >>This is another corner of a corner case that is not a regression but >>f

Use "[warning enabled by default]" for default warnings

2014-02-09 Thread Richard Sandiford
We print "[-Wfoo]" after a warning that was enabled by the -Wfoo option, which is pretty clear. But for warnings that have no -W option we just print "[enabled by default]", which leads to the question of _what_ is enabled by default. As shown by: http://gcc.gnu.org/ml/gcc/2014-01/msg00234.ht

[Ada] Use "[warning enabled by default]" for default warnings

2014-02-09 Thread Richard Sandiford
This switches Ada from using [enabled by default] to [warning enabled by default] for consistency with: http://gcc.gnu.org/ml/gcc-patches/2014-02/msg00549.html Tested on x86_64-linux-gnu. OK if the above patch goes in? Thanks, Richard gcc/ada/ * erroutc.adb (Output_Msg_Text): Use "[

Re: Use "[warning enabled by default]" for default warnings

2014-02-09 Thread Robert Dewar
On 2/9/2014 3:00 PM, Richard Sandiford wrote: We print "[-Wfoo]" after a warning that was enabled by the -Wfoo option, which is pretty clear. But for warnings that have no -W option we just print "[enabled by default]", which leads to the question of _what_ is enabled by default. As shown by:

Re: [Ada] Use "[warning enabled by default]" for default warnings

2014-02-09 Thread Robert Dewar
On 2/9/2014 3:03 PM, Richard Sandiford wrote: This switches Ada from using [enabled by default] to [warning enabled by default] for consistency with: http://gcc.gnu.org/ml/gcc-patches/2014-02/msg00549.html Tested on x86_64-linux-gnu. OK if the above patch goes in? I would say hold off on

Re: Use "[warning enabled by default]" for default warnings

2014-02-09 Thread Arnaud Charlet
> IMO the natural assumption is that gnu++11 is enabled by default, which is > how Lars also read it. > > There seemed to be support for using "warning enabled by default" instead, > so this patch does that. Tested on x86_64-linux-gnu. OK to install? > > I'll post an Ada patch separately. FWIW

Re: [Ada] Use "[warning enabled by default]" for default warnings

2014-02-09 Thread Arnaud Charlet
> This switches Ada from using [enabled by default] to [warning enabled > by default] for consistency with: > > http://gcc.gnu.org/ml/gcc-patches/2014-02/msg00549.html > > Tested on x86_64-linux-gnu. OK if the above patch goes in? As I just mentioned, this isn't OK at first sight. Arno

Re: [Ada] Use "[warning enabled by default]" for default warnings

2014-02-09 Thread Richard Sandiford
Robert Dewar writes: > On 2/9/2014 3:03 PM, Richard Sandiford wrote: >> This switches Ada from using [enabled by default] to [warning enabled >> by default] for consistency with: >> >>http://gcc.gnu.org/ml/gcc-patches/2014-02/msg00549.html >> >> Tested on x86_64-linux-gnu. OK if the above pat

Re: Use "[warning enabled by default]" for default warnings

2014-02-09 Thread Robert Dewar
On 2/9/2014 3:09 PM, Arnaud Charlet wrote: IMO the natural assumption is that gnu++11 is enabled by default, which is how Lars also read it. There seemed to be support for using "warning enabled by default" instead, so this patch does that. Tested on x86_64-linux-gnu. OK to install? I'll post

Re: [Ada] Use "[warning enabled by default]" for default warnings

2014-02-09 Thread Robert Dewar
On 2/9/2014 3:10 PM, Richard Sandiford wrote: Which testsuite do you mean? I did test this with Ada enabled and there were no regressions. If you mean an external testsuite then I certainly don't mind holding off the Ada part. I hope the non-Ada part could still go in without it though. I m

Re: {GRAPHITE] Replacement of isl_int by isl_val

2014-02-09 Thread Tobias Grosser
On 02/09/2014 04:47 PM, Mircea Namolaru wrote: Patch for replacement of the isl_int (obsolete) by isl_val. No regressions for c/c++/fortran on x86-64 Linux. Hi Mircae, thanks a lot for looking into this. Just for people not aware of the idea of this patch. Cloog recently upgraded to t

Re: Use "[warning enabled by default]" for default warnings

2014-02-09 Thread Richard Sandiford
Robert Dewar writes: > On 2/9/2014 3:09 PM, Arnaud Charlet wrote: >>> IMO the natural assumption is that gnu++11 is enabled by default, which is >>> how Lars also read it. >>> >>> There seemed to be support for using "warning enabled by default" instead, >>> so this patch does that. Tested on x86

Re: Use "[warning enabled by default]" for default warnings

2014-02-09 Thread Robert Dewar
On 2/9/2014 3:23 PM, Richard Sandiford wrote: can't we just reword the one warning where there is an ambiguity to avoid the confusion, rather than creating such an earthquake, which as Arno says, really has zero advantages to Ada programmers, and clear disadvantages .. to me [enabled by default]

Re: [Patch, fortran] PR57522 - [F03] ASSOCIATE construct creates array descriptor with incorrect stride for derived type array component

2014-02-09 Thread Paul Richard Thomas
Dear All, Committed as revision 207646. Thanks for the review and RM OK. Cheers Paul On 9 February 2014 13:56, Richard Biener wrote: > On February 8, 2014 5:08:52 PM GMT+01:00, Paul Richard Thomas > wrote: >>Dear All, >> >>I am aware that we are in stage 4 but this wrong-code-on-valid PR i

Re: [PATCH 1/6] [GOMP4] OpenACC 1.0+ support in fortran front-end

2014-02-09 Thread Tobias Burnus
Ilmir Usmanov wrote: OpenACC 1.0 support to fortran FE -- core. --- a/gcc/fortran/dump-parse-tree.c +++ b/gcc/fortran/dump-parse-tree.c @@ -1031,9 +1031,22 @@ show_omp_node (int level, gfc_code *c) { gfc_omp_clauses *omp_clauses = NULL; const char *name = NULL; + bool is_oacc = fal

Re: [PATCH 2/6] [GOMP4] OpenACC 1.0+ support in fortran front-end

2014-02-09 Thread Tobias Burnus
Ilmir Usmanov wrote: OpenACC 1.0 fortran FE support -- matching and resolving. + return MATCH_ERROR; +} + +static match +match_oacc_clause_gang (gfc_omp_clauses *cp) +{ For consistency, can you add another empty line before the function? +#define OMP_CLAUSE_SEQ (1ll

Re: [PATCH 3/6] [GOMP4] OpenACC 1.0+ support in fortran front-end

2014-02-09 Thread Tobias Burnus
Ilmir Usmanov wrote: OpenACC 1.0 fortran FE support -- translation to GENERIC. +static tree +gfc_trans_oacc_loop (gfc_code *, gfc_omp_clauses *) +{ + gfc_error ("Unimplemented"); + return NULL_TREE; +} I think that should be a bit more explicit: First, there should be a location ("%L"

Re: [PATCH 5/6] [GOMP4] OpenACC 1.0+ support in fortran front-end

2014-02-09 Thread Tobias Burnus
Some general questions to the patch set: * I miss "-fopenacc". Is the support already in the branch? I assume that part is then in c-family/c.opt fortran/lang.opt? * Documentation: Do you also need to update fortran/gfortran.texi and/or fortran/invoke.texi? (I assume that -fopenacc is already

Re: {GRAPHITE] Replacement of isl_int by isl_val

2014-02-09 Thread Tobias Burnus
Tobias Grosser wrote: On 02/09/2014 04:47 PM, Mircea Namolaru wrote: Patch for replacement of the isl_int (obsolete) by isl_val. Just for people not aware of the idea of this patch. Cloog recently upgraded to the latest version of isl (isl-0.12.2) and with this release isl deprecated the is

[PATCH, WWW] [AVX-512] Add news about AVX-512.

2014-02-09 Thread Kirill Yukhin
Hello, This patch adds news about AVX-512 to GCC main page and entry to 4.9's changes.html. Is it ok? PS: I am not native speaker, any corrections are welcome! -- Thanks, K Index: htdocs/index.html === RCS file: /cvs/gcc/wwwdocs/ht

Re: [patch] Fix array overflow in gcc.dg/vect/no-vfa-vect-depend-2.c

2014-02-09 Thread Paul Pluzhnikov
Ping? On Tue, Feb 4, 2014 at 5:08 PM, Paul Pluzhnikov wrote: > +cc jakub > > On Tue, Feb 4, 2014 at 4:59 PM, Paul Pluzhnikov > wrote: >> Greetings, >> >> The gcc.dg/vect/no-vfa-vect-depend-2.c failed for us, when linked with >> gold, but not when linked with BFD ld. >> >> The problem appears to

Re: [RFA][rtl-optimization/52714] Do not allow combine to create invalid RTL

2014-02-09 Thread Jeff Law
On 02/08/14 03:44, Eric Botcazou wrote: This is then combined into: newpat = (parallel [ (set (pc) (pc)) (set (reg/v/f:SI 34 [ stack ]) (reg/f:SI 15 %sp)) ]) This isn't a recognized insn, and it needs to be split. Since it's just a parallel

[RFA][middle-end/52306] Fix reload from creating invalid RTL

2014-02-09 Thread Jeff Law
As mentioned in the PR, we emit_input_reload_insns has this little optimization: /* If we are reloading a pseudo-register that was set by the previous insn, see if we can get rid of that pseudo-register entirely by redirecting the previous insn into our reload register. */ When th