Re: [PATCH v3] Re: avoid useless if-before-free tests

2011-04-15 Thread Janne Blomqvist
On Thu, Mar 24, 2011 at 18:51, Jim Meyering wrote: > Janne Blomqvist wrote: >> On Tue, Mar 8, 2011 at 19:53, Jim Meyering wrote: >>> Relative to v2, I've added libgo/ to the list of exempt directories and >>> added >>> this recently discussed gfc_free patch, at the request of Tobias Burnus. >>>

[PATCH] Improve combining of conditionals

2011-04-15 Thread Maxim Kuvyrkov
This patch fixes the problem with substituting expressions into IF_THEN_ELSE during combining. Without this patch combining of conditionals inside IF_THEN_ELSE is seriously inhibited. The problem this patch fixes is that combine_simplify_rtx() prefers to return an expression (say, ) even when

Re: [PATCH v3] Re: avoid useless if-before-free tests

2011-04-15 Thread Jim Meyering
Janne Blomqvist wrote: > On Thu, Mar 24, 2011 at 18:51, Jim Meyering wrote: >> Janne Blomqvist wrote: >>> On Tue, Mar 8, 2011 at 19:53, Jim Meyering wrote: Relative to v2, I've added libgo/ to the list of exempt directories and added this recently discussed gfc_free patch, at the

Re: [PATCH][RFC] Make called function type explicit, make function pointer type conversions useless

2011-04-15 Thread Eric Botcazou
> 2011-04-14 Eric Botcazou > > * cfgexpand.c (expand_call_stmt): Rematerialize the original function > type if this is not a builtin function. Hum, using fold_convert seems to be more appropriate here. Bootstrapped/regtested on i586-suse-linux, applied as obvious. 2011-04-15 Eri

[PATCH] doubled words

2011-04-15 Thread Jim Meyering
Signed-off-by: Jim Meyering --- While most of these are in comments, the corrections in gcc/tree-cfg.c and gcc/config/sh/constraints.md are in strings. The former at least is marked for translation, and hence appears in every .po file. gcc/config/alpha/vms-unwind.h |4 ++-- gcc/config/

Re: [PATCH v3] Re: avoid useless if-before-free tests

2011-04-15 Thread Janne Blomqvist
On Fri, Apr 15, 2011 at 10:54, Jim Meyering wrote: > Janne Blomqvist wrote: > >> On Thu, Mar 24, 2011 at 18:51, Jim Meyering wrote: >>> Janne Blomqvist wrote: On Tue, Mar 8, 2011 at 19:53, Jim Meyering wrote: > Relative to v2, I've added libgo/ to the list of exempt directories and >>>

Re: [PATCH v3] Re: avoid useless if-before-free tests

2011-04-15 Thread Jim Meyering
Janne Blomqvist wrote: > On Fri, Apr 15, 2011 at 10:54, Jim Meyering wrote: >> Janne Blomqvist wrote: >> >>> On Thu, Mar 24, 2011 at 18:51, Jim Meyering wrote: Janne Blomqvist wrote: > On Tue, Mar 8, 2011 at 19:53, Jim Meyering wrote: >> Relative to v2, I've added libgo/ to the list

Fix minor issues in gimplify.c

2011-04-15 Thread Eric Botcazou
Long lines, superfluous 's' and missing head comment. No functional changes. There is one function left without head comment: gimplify_adjust_omp_clauses. Jakub, when you have a few minutes, would you mind adding one? TIA. Tested on i586-suse-linux, applied on the mainline as obvious. 2011-04

Re: [lto/pph] Do not pack more bits than requested (issue4415044)

2011-04-15 Thread Richard Guenther
On Thu, 14 Apr 2011, Diego Novillo wrote: > On Thu, Apr 14, 2011 at 15:28, Jakub Jelinek wrote: > > > If bitpack_word_t has BITS_PER_BITPACK_WORD bits, then for > > nbits = BITS_PER_BITPACK_WORD this will be undefined. > > Use say > > mask = ((bitpack_word_t) 2 << (nbits - 1)) - 1; > > or someth

Re: [PATCH] Improve combining of conditionals

2011-04-15 Thread Eric Botcazou
> The patch was successfully tested on {i686, arm, mips}-linux, both GCC > testsuites and SPEC2000 runs. For all targets there was no observable code > difference in SPEC2000 benchmarks, so the example does not trigger very > often. Still, it speeds up CoreMark by about 1%. > > OK for trunk? Yes

Re: [PATCH][RFC] Make called function type explicit, make function pointer type conversions useless

2011-04-15 Thread Richard Guenther
On Thu, 14 Apr 2011, Eric Botcazou wrote: > > I have the following, the gimple_call_chain check is to prevent > > Ada bootstrap from failing. > > On x86? Yes, though maybe because I had get_callee_fndecl patched to not strip conversions. > > I suppose your patch is ok, maybe with simply not wra

Re: [Patch,testsuite,avr]: add -finline-limit=0 to pr41885.c options

2011-04-15 Thread Richard Guenther
On Thu, Apr 14, 2011 at 8:14 PM, Denis Chertykov wrote: > 2011/4/14 Georg-Johann Lay : >> This patchlet adds -finline-limit=0 to dg-options in >> >> testsuite/gcc.target/avr/torture/pr41885.c >> >> because otherwise optimizers will fold all tests and actually no test >> function is called when opt

Re: More of ipa-inline housekeeping

2011-04-15 Thread Jan Hubicka
> > > > I fixed this on the and added sanity check that the fields are initialized. > > This has shown problem with early inliner iteration fixed thusly and fact > > that > > early inliner is attempting to compute overall growth at a time the inline > > parameters are not computed for functions no

Re: More of ipa-inline housekeeping

2011-04-15 Thread Richard Guenther
2011/4/15 Jan Hubicka : >> > >> > I fixed this on the and added sanity check that the fields are initialized. >> > This has shown problem with early inliner iteration fixed thusly and fact >> > that >> > early inliner is attempting to compute overall growth at a time the inline >> > parameters are

[committed] Fix pr46084.c testcase (PR target/48614)

2011-04-15 Thread Jakub Jelinek
Hi! This testcase doesn't use avx-check.h and is dg-do run testcase, as it is compiled with -mavx whenever it emits any AVX instructions, it won't be able to run on any older CPUs. Fixed thusly, committed to trunk/4.6. 2011-04-15 Jakub Jelinek PR target/48614 * gcc.target/i38

Re: [PATCH] Improve combining of conditionals

2011-04-15 Thread Steven Bosscher
On Fri, Apr 15, 2011 at 11:04 AM, Eric Botcazou wrote: > @@ -4938,11 +4938,13 @@ find_split_point (rtx *loc, rtx insn, bool set_src) > >    IN_DEST is nonzero if we are processing the SET_DEST of a SET. > > +   IN_COND is nonzero if we are on top level of the condition. > > "...we are at the top l

Re: [PATCH] Improve combining of conditionals

2011-04-15 Thread Maxim Kuvyrkov
On Apr 15, 2011, at 2:38 PM, Steven Bosscher wrote: > On Fri, Apr 15, 2011 at 11:04 AM, Eric Botcazou wrote: >> @@ -4938,11 +4938,13 @@ find_split_point (rtx *loc, rtx insn, bool set_src) >> >>IN_DEST is nonzero if we are processing the SET_DEST of a SET. >> >> + IN_COND is nonzero if we

Re: [PATCH] Improve combining of conditionals

2011-04-15 Thread Eric Botcazou
> And make IN_COND a bool instead of an int? I had the same initial reaction but then came to the same conclusion as Maxim. -- Eric Botcazou

Re: [patch][ARM] Fix 16-bit -> 64-bit multiply and accumulate

2011-04-15 Thread Andrew Stubbs
Ping. On 25/03/11 16:19, Andrew Stubbs wrote: On 28/01/11 15:20, Richard Earnshaw wrote: On Fri, 2011-01-28 at 15:13 +, Andrew Stubbs wrote: On 28/01/11 14:12, Richard Earnshaw wrote: So what happens to a variation of your testcase: long long foolong (long long x, short *a, short *b) {

[ping] 3 unreviewed patches

2011-04-15 Thread Eric Botcazou
Fix annoying gcov filename handling: http://gcc.gnu.org/ml/gcc-patches/2011-03/msg01380.html (rs6000) Fix thinko in output_profile_hook: http://gcc.gnu.org/ml/gcc-patches/2011-03/msg01624.html Introduce -Wstack-usage: http://gcc.gnu.org/ml/gcc-patches/2011-03/msg01992.html Thanks in advanc

Re: More of ipa-inline housekeeping

2011-04-15 Thread Jan Hubicka
> 2011/4/15 Jan Hubicka : > >> > > >> > I fixed this on the and added sanity check that the fields are > >> > initialized. > >> > This has shown problem with early inliner iteration fixed thusly and > >> > fact that > >> > early inliner is attempting to compute overall growth at a time the > >>

Re: [Patch,testsuite,avr]: add -finline-limit=0 to pr41885.c options

2011-04-15 Thread Georg-Johann Lay
Richard Guenther schrieb: > On Thu, Apr 14, 2011 at 8:14 PM, Denis Chertykov wrote: >> 2011/4/14 Georg-Johann Lay : >>> This patchlet adds -finline-limit=0 to dg-options in >>> >>> testsuite/gcc.target/avr/torture/pr41885.c >>> >>> because otherwise optimizers will fold all tests and actually no t

Re: [PATCH] Improve combining of conditionals

2011-04-15 Thread Eric Botcazou
> The problem this patch fixes is that combine_simplify_rtx() prefers to > return an expression (say, ) even when a comparison is > prefered (say, ). Expressions are not recognized as > valid conditions of if_then_else for most targets, so combiner misses a > potential optimization. This patch ma

Re: PATCH: PR middle-end/48608: Alignment adjust of local variables is lost

2011-04-15 Thread Michael Matz
Hi, On Thu, 14 Apr 2011, H.J. Lu wrote: > >> > +  if (align > DECL_ALIGN (decl)) > >> > +    DECL_ALIGN (decl) = align; > >> > >> Shouldn't this unconditionally set DECL_ALIGN in case > >> LOCAL_DECL_ALINGMENT returns something smaller? > > > > Decreasing alignment of DECLs points to a problem el

Re: Implement stack arrays even for unknown sizes

2011-04-15 Thread Michael Matz
Hi, On Thu, 14 Apr 2011, Dominique Dhumieres wrote: > I have forgotten to mentionned that I have a variant of fatigue > in which I have done the inlining manually along with few other > optimizations and the timing for it is > > [macbook] lin/test% gfc -Ofast fatigue_v8.f90 > [macbook] lin/test%

Re: [Patch, libfortran] Replace sprintf() with snprintf()

2011-04-15 Thread Jerry DeLisle
On 04/14/2011 11:53 PM, Janne Blomqvist wrote: Hi, as is well known, sprintf() is prone to buffer overflow, hence snprintf(). libgfortran uses snprintf() in some places, but not everywhere. Rather than analyzing every sprintf() call for a potential overflow, the attached patch takes the dogmatic

Re: [PATCH] Improve combining of conditionals

2011-04-15 Thread Maxim Kuvyrkov
On Apr 15, 2011, at 3:34 PM, Eric Botcazou wrote: >> The problem this patch fixes is that combine_simplify_rtx() prefers to >> return an expression (say, ) even when a comparison is >> prefered (say, ). Expressions are not recognized as >> valid conditions of if_then_else for most targets, so com

Re: [7/9] Testsuite: remove vect_{extract_even_odd,strided}_wide

2011-04-15 Thread Richard Guenther
On Tue, Apr 12, 2011 at 4:14 PM, Richard Sandiford wrote: > We have separate vect_extract_even_odd and vect_extract_even_odd_wide > target selectors, and separate vect_strided and vect_strided_wide > selectors.  The comment suggests that "wide" is for 32+ bits, > but we often use the non-wide form

Re: [8/9] Testsuite: split tests for strided accesses

2011-04-15 Thread Richard Guenther
On Tue, Apr 12, 2011 at 4:19 PM, Richard Sandiford wrote: > The next patch introduces separate vect_stridedN target selectors > for each tested stride factor N.  At the moment, some tests contain > several independent loops that have different stride factors. > It's easier to make the next change

Re: [10/9] Add tests for stride-3 accesses

2011-04-15 Thread Richard Guenther
On Tue, Apr 12, 2011 at 4:34 PM, Richard Sandiford wrote: > This patch adds a test for stride-3 accesses.  I didn't add any > particularly complicated cases because I think the testsuite already > covers the interaction between the strided loads & stores and other > operations pretty well.  Let me

[Committed] S/390: Fix popcount expanders

2011-04-15 Thread Andreas Krebbel
Hi, the attached patch fixes a problem with the population count expanders on s390. For operand 2 a scratch register is allocated in the preparation code of the expander. Nevertheless there has been a match_operand for operand 2. It should be just a match_dup instead. Fixed with the attached p

Re: [lto/pph] Do not pack more bits than requested (issue4415044)

2011-04-15 Thread Diego Novillo
On Fri, Apr 15, 2011 at 04:56, Richard Guenther wrote: >> @@ -518,7 +518,8 @@ pack_ts_type_value_fields (struct bitpack_d *bp, tree >> expr) >>    bp_pack_value (bp, TYPE_USER_ALIGN (expr), 1); >>    bp_pack_value (bp, TYPE_READONLY (expr), 1); >>    bp_pack_value (bp, TYPE_ALIGN (expr), HOST_BI

Re: [lto/pph] Do not pack more bits than requested (issue4415044)

2011-04-15 Thread Richard Guenther
On Fri, 15 Apr 2011, Diego Novillo wrote: > On Fri, Apr 15, 2011 at 04:56, Richard Guenther wrote: > > >> @@ -518,7 +518,8 @@ pack_ts_type_value_fields (struct bitpack_d *bp, tree > >> expr) > >>    bp_pack_value (bp, TYPE_USER_ALIGN (expr), 1); > >>    bp_pack_value (bp, TYPE_READONLY (expr),

PATCH: PR target/48612: [4.7 Regression] vminps instruction is generated with -ftree-vectorize

2011-04-15 Thread H.J. Lu
Hi, This patch is approved in PR. I checked it in. H.J. --- Index: ChangeLog === --- ChangeLog (revision 172490) +++ ChangeLog (working copy) @@ -1,3 +1,9 @@ +2011-04-15 H.J. Lu + + PR target/48612 + * config/i38

[PATCH 0/4] Devirtualization fix and improvements

2011-04-15 Thread Martin Jambor
Hi, the following set of patches is a bunch of early fixups and improvements to the current devirtualization mechanism which are semi-related but are meant to be applied on top of each other. One nice thing about them is that they improve SPEC 2006 473.astar by over 3% with LTO. More comments ab

[PATCH 1/4] Remove usesess and wrong code from ipa_analyze_virtual_call_uses

2011-04-15 Thread Martin Jambor
Hi, ipa_analyze_virtual_call_uses contains code that was meant to deal with situation where OBJ_TYPE_REF_OBJECT is a (number of) COMPONENT_REFs on top of a dereferenced default definition SSA_NAME of a parameter. The code is useless because that never happens in the IL, if an ancestor object of a

[PATCH 3/4] Simple relaxation of dynamic type change detection routine

2011-04-15 Thread Martin Jambor
Hi, in order to speed up astar, I had to persuade the function that decides whether a statement potentially modifies the dynamic type of an object by storing a new value to the VMT pointer to consider the following statement harmless (all types are integers of some sort): MEM[(i32 *)b2arp_3(D) +

[PATCH 4/4] Devirtualization based on global objects

2011-04-15 Thread Martin Jambor
Hi, this is the patch that actually speeds up astar (together with the previous one). It implements devirtualization based on global objects. In the past we have refrained from doing this because in general it is difficult to say whether the object is currently being constructed and so it might

[PATCH 2/4] Handle calls to ancestor objects in IPA-CP devirtualization

2011-04-15 Thread Martin Jambor
Hi, early inlining can create virtual calls based on the part of an object that represents an ancestor. This patch makes ipa-prop analysis able to recognize such calls and store the required offset along with such calls (the field is already there for similar purposes of indirect inlining). The

Re: [lto/pph] Do not pack more bits than requested (issue4415044)

2011-04-15 Thread Diego Novillo
On Fri, Apr 15, 2011 at 08:49, Richard Guenther wrote: > On Fri, 15 Apr 2011, Diego Novillo wrote: > >> On Fri, Apr 15, 2011 at 04:56, Richard Guenther wrote: >> >> >> @@ -518,7 +518,8 @@ pack_ts_type_value_fields (struct bitpack_d *bp, tree >> >> expr) >> >>    bp_pack_value (bp, TYPE_USER_ALIG

Re: [6/9] NEON vec_load_lanes and vec_store_lanes patterns

2011-04-15 Thread Richard Earnshaw
On Tue, 2011-04-12 at 15:01 +0100, Richard Sandiford wrote: > This patch adds vec_load_lanes and vec_store_lanes patterns for NEON. > They feed directly into the corresponding intrinsic patterns. > > Tested on x86_64-linux-gnu and arm-linux-gnueabi. OK to install? > > Richard > > > gcc/ >

[PATCH] factor asm op chaining out from stmt.c:expand_asm_stmt

2011-04-15 Thread Nathan Froyd
There are several cut-and-pasted loops in expand_asm_stmt that could be parameterized by the functions used to access the particular operands. The patch below does that. Tested on x86_64-unknown-linux-gnu. OK to commit? -Nathan * stmt.c (chain_asm_ops): New function. (expand_as

Re: [PATCH v3] Re: avoid useless if-before-free tests

2011-04-15 Thread Tom Tromey
> "Janne" == Janne Blomqvist writes: Jim> Can someone add me to the gcc group?  That would help. Jim> I already have ssh access to sourceware.org. Janne> I'm not sure if I'm considered to be well-established Janne> enough, so could someone help Jim out here, please? I added Jim to the gcc g

[PATCH] refactor gimple asm memory clobber checking

2011-04-15 Thread Nathan Froyd
There are a couple places that check GIMPLE_ASMs for clobbering memory; this patch centralizes the logic in gimple.c. Tested on x86_64-unknown-linux-gnu. OK to commit? -Nathan * gimple.h (gimple_asm_clobbers_memory_p): Declare. * gimple.c (gimple_asm_clobbers_memory_p): Define.

Re: [patch, ARM] Fix PR48325, support POST_INC/PRE_DEC for NEON struct modes

2011-04-15 Thread Richard Earnshaw
On Thu, 2011-03-31 at 22:57 +0800, Chung-Lin Tang wrote: > This PR doesn't exactly trigger currently on trunk; a REG_DEAD note that > occurs in trunk, but not in the 4.5-based compilers which this bug was > reported for, currently blocks auto-inc-dec from doing its job, and just > happens to avoid

Re: [PATCH, ARM] PR47855 Compute attr "length" for some thumb2 insns, 2/3

2011-04-15 Thread Richard Earnshaw
On Thu, 2011-04-14 at 21:19 +0800, Carrot Wei wrote: > On Fri, Apr 8, 2011 at 6:51 PM, Ramana Radhakrishnan > wrote: > > On 08/04/11 10:57, Carrot Wei wrote: > >> > >> Hi > >> > >> This is the second part of the fixing for > >> > >> http://gcc.gnu.org/bugzilla/show_bug.cgi?id=47855 > >> > >> This

Re: Implement stack arrays even for unknown sizes

2011-04-15 Thread Dominique Dhumieres
Michael, > Yes, this is due to the DECL_EXPR statement which is rendered by the > dumper just the same as a normal decl. The testcase looks for exactly one > such decl, but with -fstack-arrays there are exactly two for each such > array. The testsuite is run without -fstack-arrays, so I dont'

[PATCH] Fix PR48290

2011-04-15 Thread Richard Guenther
This fixes the remaining part of PR48290, copyprop not properly propagating constant copies across PHI nodes. On the way this patch needs to fix some present issues with the code inhibiting various kinds of propagation (but not removing those two that look completely bogus). Bootstrapped and tes

[PATCH] Fix PR48286

2011-04-15 Thread Richard Guenther
This makes us avoid 323. Tested on x86_64-unknown-linux-gnu/-m32, committed. Richard. 2011-04-15 Richard Guenther PR testsuite/48286 * gfortran.dg/cray_pointers_8.f90: Use -ffloat-store. gcc/testsuite/gfortran.dg/cray_pointers_8.f90 Index: gcc/testsuite/gfortran.dg/cray_poi

Re: [PATCH] factor asm op chaining out from stmt.c:expand_asm_stmt

2011-04-15 Thread Richard Guenther
On Fri, Apr 15, 2011 at 3:19 PM, Nathan Froyd wrote: > There are several cut-and-pasted loops in expand_asm_stmt that could be > parameterized by the functions used to access the particular operands. > The patch below does that. > > Tested on x86_64-unknown-linux-gnu.  OK to commit? Hmm, it doesn

Re: [PATCH] refactor gimple asm memory clobber checking

2011-04-15 Thread Richard Guenther
On Fri, Apr 15, 2011 at 3:20 PM, Nathan Froyd wrote: > There are a couple places that check GIMPLE_ASMs for clobbering memory; > this patch centralizes the logic in gimple.c. > > Tested on x86_64-unknown-linux-gnu.  OK to commit? Ok. Thanks, Richard. > -Nathan > >        * gimple.h (gimple_asm_

patch pings

2011-04-15 Thread Jeff Law
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 http://gcc.gnu.org/ml/gcc-patches/2011-03/msg01060.html http://gcc.gnu.org/ml/gcc-patches/2011-03/msg02247.html -BEGIN PGP SIGNATURE- Version: GnuPG v1.4.11 (GNU/Linux) Comment: Using GnuPG with Fedora - http://enigmail.mozdev.org/ iQEcBAEBAg

Re: Implement stack arrays even for unknown sizes

2011-04-15 Thread Michael Matz
Hi, On Fri, 15 Apr 2011, Dominique Dhumieres wrote: > Michael, > > > Yes, this is due to the DECL_EXPR statement which is rendered by the > > dumper just the same as a normal decl. The testcase looks for exactly one > > such decl, but with -fstack-arrays there are exactly two for each such >

Re: [PATCH 1/4] Remove usesess and wrong code from ipa_analyze_virtual_call_uses

2011-04-15 Thread Richard Guenther
On Fri, 15 Apr 2011, Martin Jambor wrote: > Hi, > > ipa_analyze_virtual_call_uses contains code that was meant to deal > with situation where OBJ_TYPE_REF_OBJECT is a (number of) > COMPONENT_REFs on top of a dereferenced default definition SSA_NAME of > a parameter. > > The code is useless becau

Re: More of ipa-inline housekeeping

2011-04-15 Thread Dominique Dhumieres
AFAICT revision 172430 fixed the original problem in pr45810: gfc -Ofast -fwhole-program fatigue.f90 : 6.301u 0.003s 0:06.30 gfc -Ofast -fwhole-program -flto fatigue.f90 : 6.263u 0.003s 0:06.26 However if I play with --param max-inline-insns-auto=*, I get gfc -Ofast -fwhole-program --param

Re: Implement stack arrays even for unknown sizes

2011-04-15 Thread Jerry DeLisle
On 04/15/2011 07:28 AM, Michael Matz wrote: --- snip --- I'll make the DECL_EXPR conditional on the size being variable. As Tobias already okayed the patch I'm planning to check in the slightly modified variant as below, after a new round of testing. Thats A-OK Thanks, Jerry

Re: More of ipa-inline housekeeping

2011-04-15 Thread Dominique Dhumieres
I have forgotten to say that the 125 and 516 thresholds are for x86_64-apple-darwin10. On powerpc-apple-darwin9 they are repsectively 172 and 638. Dominique

[PATCH, SMS] Avoid unfreed memory when SMS fails

2011-04-15 Thread Revital Eres
Hello, This patch fixes the scenario where SMS fails to schedule a loop and continue to the next one without freeing data structures allocated while scheduling the first loop. Bootstrap and regtested on ppc64-redhat-linux. OK for mainline? Thanks, Revital Changelog: * modulo-sched.c (sms_sche

[PATCH, SMS] Free sccs field

2011-04-15 Thread Revital Eres
Hello, The attached patch adds missing free operation for storage allocated while calculating SCCs. Bootstrap and regtested on ppc64-redhat-linux. OK for mainline? Thanks, Revital Changelog: * ddg.c (free_ddg_all_sccs): Free sccs field in struct ddg_all_sccs. Index: ddg.c ===

Re: [PATCH 2/4] Handle calls to ancestor objects in IPA-CP devirtualization

2011-04-15 Thread Richard Guenther
On Fri, 15 Apr 2011, Martin Jambor wrote: > Hi, > > early inlining can create virtual calls based on the part of an object > that represents an ancestor. This patch makes ipa-prop analysis able > to recognize such calls and store the required offset along with such > calls (the field is already

[PATCH, SMS] New flag to apply SMS when SC equals 1

2011-04-15 Thread Revital Eres
Hello, The attached patch introduces a new flag to allow applying SMS when stage count (SC) also equals 1. Currently, SMS is applied only when SC greater than 1 as stage count of 1 means that there is no interleaving between iterations and the scheduling passes do the job in this case. The new fla

Re: [PATCH 3/4] Simple relaxation of dynamic type change detection routine

2011-04-15 Thread Richard Guenther
On Fri, 15 Apr 2011, Martin Jambor wrote: > Hi, > > in order to speed up astar, I had to persuade the function that > decides whether a statement potentially modifies the dynamic type of > an object by storing a new value to the VMT pointer to consider the > following statement harmless (all type

Re: [PATCH 4/4] Devirtualization based on global objects

2011-04-15 Thread Richard Guenther
On Fri, 15 Apr 2011, Martin Jambor wrote: > Hi, > > this is the patch that actually speeds up astar (together with the > previous one). It implements devirtualization based on global > objects. In the past we have refrained from doing this because in > general it is difficult to say whether the

Re: [PATCH, SMS] Avoid unfreed memory when SMS fails

2011-04-15 Thread Richard Guenther
On Fri, Apr 15, 2011 at 5:26 PM, Revital Eres wrote: > Hello, > > This patch fixes the scenario where SMS fails to > schedule a loop and continue to the next one without > freeing data structures allocated while scheduling > the first loop. > > Bootstrap and regtested on ppc64-redhat-linux. > > OK

Re: [PATCH, SMS] Free sccs field

2011-04-15 Thread Richard Guenther
On Fri, Apr 15, 2011 at 5:27 PM, Revital Eres wrote: > Hello, > > The attached patch adds missing free operation for storage > allocated while calculating SCCs. > > Bootstrap and regtested on ppc64-redhat-linux. > > OK for mainline? Ok. Thanks, Richard. > Thanks, > Revital > > Changelog: > >  

Re: [PATCH, SMS] New flag to apply SMS when SC equals 1

2011-04-15 Thread Richard Guenther
On Fri, Apr 15, 2011 at 5:28 PM, Revital Eres wrote: > Hello, > > The attached patch introduces a new flag to allow applying SMS when > stage count (SC) also equals 1. > Currently, SMS is applied only when SC greater than 1 as stage count > of 1 means that there is no interleaving between iteratio

Re: [PATCH, SMS] Free sccs field

2011-04-15 Thread Nathan Froyd
On Fri, Apr 15, 2011 at 06:27:05PM +0300, Revital Eres wrote: > + if (all_sccs->sccs) > +free (all_sccs->sccs); No need to check for non-NULL prior to free'ing. -Nathan

Re: [Patch, Fortran] PR 18918: Build + install libcaf_single.a

2011-04-15 Thread Janne Blomqvist
On Wed, Apr 13, 2011 at 17:08, Tobias Burnus wrote: > Hello all, hi Ralf and Jorge, > > The attached patch causes libgfortran/ also to build > libgfortran/caf/single.c, which will be installed as > $PREFIX/.../target-triplet/gcc-version/libcaf_single.a. > > Build and tested on x86-64-linux. > OK f

Re: [PATCH 3/6] Allow jumps in epilogues

2011-04-15 Thread Bernd Schmidt
On 04/13/2011 02:38 PM, Bernd Schmidt wrote: > This still requires the i386 output_set_got which I think I can cope > with [...] Patch below, to be applied on top of all the others. Only lightly tested so far beyond standard (fairly useless) regression tests, by comparing generated assembly before

[patch, libgfortran] PR48589 Invalid G0/G0.d editing for NaN/infinity

2011-04-15 Thread Jerry DeLisle
Hi, I plan to commit the following simple and obvious patch. Regression tested on x86-64-linux-gnu. I will apply the test case in the PR to the testsuite. Regards, Jerry 2011-04-15 Jerry DeLisle PR libgfortran/48589 * io/write_float.def (write_infnan): Set width properly

Re: patch pings

2011-04-15 Thread Bernd Schmidt
On 04/15/2011 04:18 PM, Jeff Law wrote: > http://gcc.gnu.org/ml/gcc-patches/2011-03/msg02247.html I don't know. I sympathize with the goal, but I'm not too happy about the structure of this patch. Doesn't this do the scan once for every reload in an insn? It seems to me like the loop (or rather,

Re: FDO usability patch -- cfg and lineno checksum

2011-04-15 Thread Xinliang David Li
Resent in plain text mode .. David On Fri, Apr 15, 2011 at 9:28 AM, Xinliang David Li wrote: > > Honza, do you have a chance to take a look at it? > Thanks, > > David > > On Wed, Apr 13, 2011 at 3:25 PM, Xinliang David Li wrote: >> >> Hi,  in current FDO implementation, the source file version

Re: [PATCH] Improve combining of conditionals

2011-04-15 Thread Mike Stump
On Apr 15, 2011, at 3:44 AM, Eric Botcazou wrote: >> And make IN_COND a bool instead of an int? > > I had the same initial reaction but then came to the same conclusion as Maxim. If it can be bool, it should be bool.

Re: [PATCH, SMS] Free sccs field

2011-04-15 Thread Revital Eres
Hello, On 15 April 2011 18:53, Nathan Froyd wrote: > On Fri, Apr 15, 2011 at 06:27:05PM +0300, Revital Eres wrote: >> +  if (all_sccs->sccs) >> +    free (all_sccs->sccs); > > No need to check for non-NULL prior to free'ing. OK, I'll commit the patch without the check then. (after re-testing) T

Re: [build] Allow building libobjc_gc on Tru64 UNIX, Darwin

2011-04-15 Thread Rainer Orth
Nicola, >> Ok for mainline if both pass? > > Yes. > > [and by the way, I think you're fixing PR libobjc/32037 in the process. :-)] indeed, thanks for checking. Testing revealed that I'd been lazy with quoting. I'm including the patch I've installed, which encloses OBJC_BOEHM_GC in configure.ac

[v3] Handle NOTY in extract_symvers.pl

2011-04-15 Thread Rainer Orth
While testing the close-to-final version of my COMDAT-group-with-Sun as patch [build, c++, lto] Support COMDAT group with Sun as (PR target/40483) http://gcc.gnu.org/ml/gcc-patches/2010-05/msg01365.html http://gcc.gnu.org/ml/gcc-patches/2010-06/msg00600.html which only awa

Re: [PATCH] doubled words

2011-04-15 Thread Mike Stump
On Apr 15, 2011, at 1:18 AM, Jim Meyering wrote: > While most of these are in comments, the corrections > in gcc/tree-cfg.c and gcc/config/sh/constraints.md are in strings. > The former at least is marked for translation, and hence appears > in every .po file. I think these are obvious. >

[libjava, testsuite] Link jni tests with -liconv on Tru64 UNIX

2011-04-15 Thread Rainer Orth
While checking Tru64 UNIX libjava testsuite results, I noticed that the libjava.jni/invocation/PR16923.c execution test was failing like this: 277710:./PR16923: /sbin/loader: Error: libgcj.so.12: symbol "iconv" unresolved 277710:./PR16923: /sbin/loader: Fatal Error: Load of "./PR16923" failed: Un

Re: [PATCH] Fix PR46399 - missing mode promotion for libcall args - updated

2011-04-15 Thread Bernd Schmidt
On 03/03/2011 05:32 PM, Andreas Krebbel wrote: > [PATCH] Fix PR46399 - missing mode promotion for libcall args > http://gcc.gnu.org/ml/gcc-patches/2011-02/msg01595.html > > after removing the FUNCTION_VALUE target macro with: > > [Committed] S/390: Remove deprecated target macro FUNCTION_VALUE >

ObjC: rewritten checks for duplicate instance variables (for improved speed and improved error messages)

2011-04-15 Thread Nicola Pero
This patch rewrites the check for duplicate instance variables done by the Objective-C (and Objective-C++) compiler. The new code has many advantages: * it avoids copying all the instance variables into a temporary tree chain in the way that the all code was doing (according to some notes

[PATCH, PR 48601] cgraph_get_create_node in emultls.c

2011-04-15 Thread Martin Jambor
Hi, lower_emutls_function_body in emultls.c should use cgraph_get_create_node to create call graph nodes if need be because it is introducing TLS builtin decls into IL. I have bootstrapped and tested this on x86_64-linux (where the bug does not happen) and in bugzilla it has been confirmed it fix

Re: [PATCH] Improve combining of conditionals

2011-04-15 Thread Eric Botcazou
> If it can be bool, it should be bool. Rather basic principle IMO. Consistency is of much greater value. -- Eric Botcazou

Re: [Patch,AVR]: FIX ICE in optabs due to bad rotate expander.

2011-04-15 Thread Georg-Johann Lay
Denis Chertykov schrieb: > 2011/4/14 Georg-Johann Lay : >> Denis Chertykov schrieb: >>> 2011/4/14 Georg-Johann Lay : The "rotl3" expanders (mode \in {HI,SI,DI}) violates synopsis by using 4 operands instead of 3. This runs in ICE in top of optabs.c:maybe_gen_insn. The right

[wwwdocs] Shuffle entries in the footer and remove margin at the bottom

2011-04-15 Thread Gerald Pfeifer
This concludes this mini project. :-) Committed and the pages on gcc.gnu.org regenerated; www.gnu.org will follow over night. Gerald Index: style.mhtml === RCS file: /cvs/gcc/wwwdocs/htdocs/style.mhtml,v retrieving revision 1.115 d

Re: [PATCH v3] Re: avoid useless if-before-free tests

2011-04-15 Thread Jim Meyering
> I added Jim to the gcc group. Thanks, Tom.

Re: [PATCH] Improve combining of conditionals

2011-04-15 Thread Mike Stump
On Apr 15, 2011, at 10:22 AM, Eric Botcazou wrote: >> If it can be bool, it should be bool. > > Rather basic principle IMO. Consistency is of much greater value. Yes, and consistency is had by upgrading existing int uses that should be bool to bool as they are spotted :-) I prefer doing t

Re: ObjC: rewritten checks for duplicate instance variables (for improved speed and improved error messages)

2011-04-15 Thread Mike Stump
On Apr 15, 2011, at 10:19 AM, Nicola Pero wrote: > This patch rewrites the check for duplicate instance variables > done by the Objective-C (and Objective-C++) compiler. > Ok to commit ? Ok.

Use ASM_COMMENT_START

2011-04-15 Thread Xinliang David Li
The following is a trivial patch to remove hard coded '#' usage. Ok for trunk? Thanks, David 2011-04-15 Xinliang David Li * final.c (dump_basic_block_info): Use ASM_COMMENT_START. Index: final.c === --- final.c (revis

Re: Use ASM_COMMENT_START

2011-04-15 Thread Diego Novillo
On Fri, Apr 15, 2011 at 14:11, Xinliang David Li wrote: > 2011-04-15  Xinliang David Li   > >        * final.c (dump_basic_block_info): Use ASM_COMMENT_START. OK. Diego.

[pph] Clean positive tests. (issue4423044)

2011-04-15 Thread Lawrence Crowl
This patch cleans up positive tests. First, stop on first failure so as to avoid littering the logfile. Second, change the extensions of the generated assembly files to .s-pph and .s+pph to be clear on the provenence of each file. Index: gcc/testsuite/ChangeLog.pph 2011-04-15 Lawrence Crowl

Re: [PATCH] sel-sched: Fix erroneous re-use of pointer to last insn in a BB (PR 48235)

2011-04-15 Thread Steve Ellcey
Vladimir and Dmitry, The new test you added, gcc.dg/pr48235.c, is failing on IA64 because it gets this excess message: cc1: note: -freorder-blocks-and-partition does not work on this architecture Could you modify the test to either filter out this message or not use the -freorder-blocks-and-par

ObjC: get rid of another unnecessary, temporary copy of instance variables

2011-04-15 Thread Nicola Pero
This patch for the Objective-C compiler gets rid of another case where we'd create a temporary tree chain with a copy of all the instance variables of a class just to do a simple check on them. The check is the one to check the scope of the instance variable that is being accessed; without this pa

FDO usability trivial patch to fix div by zero error with insane profile

2011-04-15 Thread Xinliang David Li
This is a trivial patch to deal with bad profile data (from multi-threaded programs) that leads to divide by zero error. Ok for trunk? Thanks, David 2011-04-15 Xinliang David Li * ipa-inline.c (cgraph_decide_recursive_inlining): Fix div by zero error with insane profile. I

Re: FDO usability trivial patch to fix div by zero error with insane profile

2011-04-15 Thread Diego Novillo
On Fri, Apr 15, 2011 at 15:20, Xinliang David Li wrote: > This is a trivial patch to deal with bad profile data (from > multi-threaded programs) that leads to divide by zero error. > > Ok for trunk? > > Thanks, > > David > > > > 2011-04-15  Xinliang David Li   > >        * ipa-inline.c (cgraph_dec

Re: Remember/restore ALLOCA_FOR_VAR_P over tuples

2011-04-15 Thread Michael Matz
Hi, On Thu, 14 Apr 2011, Michael Matz wrote: > > Btw, I don't remember why I chose ALLOCA_FOR_VAR_P over > > CALL_ALLOCA_FOR_VAR_P but, given the name of the GIMPLE flag and > > predicate, it's probably time to change it. > > Good idea, I'll rename it before checking in. r172516, for referenc

[PATCH] Prefer simplify_gen_* over gen_* in expand_debug_expr

2011-04-15 Thread Jakub Jelinek
Hi! On IRC richi mentioned yesterday that when gcc.dg/guality/asm-1.c testcase is compiled with g++ instead of gcc, it fails. Apparently that is because of slightly different ARRAY_REF in the code, which for g++ leads into (sign_extend:DI (zero_extend:SI (something:HI))) in DEBUG_INSN (as opposed

Re: FDO usability trivial patch to fix div by zero error with insane profile

2011-04-15 Thread Xinliang David Li
There is no way to get a test case that can produce the problem in a deterministic way. There is really not much for Honza to review though :) David On Fri, Apr 15, 2011 at 12:52 PM, Diego Novillo wrote: > On Fri, Apr 15, 2011 at 15:20, Xinliang David Li wrote: >> This is a trivial patch to de

Re: ObjC: get rid of another unnecessary, temporary copy of instance variables

2011-04-15 Thread Mike Stump
On Apr 15, 2011, at 11:52 AM, Nicola Pero wrote: > This patch for the Objective-C compiler gets rid of another case where > we'd create a temporary tree chain with a copy of all the instance variables > of a class just to do a simple check on them. > Ok to commit ? Ok.

Re: [PATCH] Prefer simplify_gen_* over gen_* in expand_debug_expr

2011-04-15 Thread Richard Guenther
On Fri, Apr 15, 2011 at 10:21 PM, Jakub Jelinek wrote: > Hi! > > On IRC richi mentioned yesterday that when gcc.dg/guality/asm-1.c > testcase is compiled with g++ instead of gcc, it fails. > Apparently that is because of slightly different ARRAY_REF > in the code, which for g++ leads into > (sign_

Re: FDO usability trivial patch to fix div by zero error with insane profile

2011-04-15 Thread Diego Novillo
On Fri, Apr 15, 2011 at 16:21, Xinliang David Li wrote: > There is no way to get a test case that can produce the problem in a > deterministic way.  There is really not much for Honza to review > though :) The check may be needed somewhere else, you may be papering over the real issue. I don't t

  1   2   >