Re: [PATCH] lib: Fix unused parameter warning in lib/error.c

2021-09-09 Thread Mark Wielaard
Hi Colin (CC Saleem who introduced this new error replacement function), On Wed, 2021-09-08 at 11:21 -0700, Colin Cross via Elfutils-devel wrote: > Mark the errnum parameter with __attribute__((unused)). Thanks, that is interesting. But I think this is an actual bug in the code. Rereviewing the

[PATCH v2] findtextrel: do not use unbound alloca

2021-09-09 Thread Dmitry V. Levin
This fixes the following compilation warning: findtextrel.c:184:1: warning: stack usage might be unbounded [-Wstack-usage=] Signed-off-by: Dmitry V. Levin --- v1 introduced a memory leak, so in v2 I rearranged the code a bit to make clear the new code does not introduce any memory leaks. sr

[Bug debuginfod/28325] New: create new debuginfod.service.8 man page

2021-09-09 Thread fche at redhat dot com via Elfutils-devel
https://sourceware.org/bugzilla/show_bug.cgi?id=28325 Bug ID: 28325 Summary: create new debuginfod.service.8 man page Product: elfutils Version: unspecified Status: NEW Severity: normal Priority: P2 Component: de

Buildbot failure in Wildebeest Builder on whole buildset

2021-09-09 Thread buildbot
The Buildbot has detected a new failure on builder elfutils-centos-x86_64 while building elfutils. Full details are available at: https://builder.wildebeest.org/buildbot/#builders/1/builds/823 Buildbot URL: https://builder.wildebeest.org/buildbot/ Worker for this Build: centos-x86_64 Build

Re: [PATCH v2] findtextrel: do not use unbound alloca

2021-09-09 Thread Mark Wielaard
Hi Dmitry, On Thu, 2021-09-09 at 14:31 +0300, Dmitry V. Levin wrote: > This fixes the following compilation warning: > > findtextrel.c:184:1: warning: stack usage might be unbounded [- > Wstack-usage=] > > Signed-off-by: Dmitry V. Levin > --- > > v1 introduced a memory leak, so in v2 I rearra

[COMMITTED] tests: Cleanup error handling and don't share cache between servers/client

2021-09-09 Thread Mark Wielaard
There were still three tests that shared a cache between the servers and client that queried those servers. Give them all separate caches. Also the error handler for debuginfod tests wasn't called when a command inside a function failed. Since testrun is a function, there would be no metrics or er

Re: [Bug debuginfod/28034] client-side %-escape url characters

2021-09-09 Thread Noah Sanci via Elfutils-devel
Hello, The attached patch %-escapes debuginfod url characters, then unescapes only '/' characters. Previously characters such as '+' were not escaped and caused improper escaping further on in handler_cb. https://sourceware.org/bugzilla/show_bug.cgi?id=28034. On Wed, Sep 8, 2021 at 9:38 AM Mark W

Re: [COMMITTED] tests: Cleanup error handling and don't share cache between servers/client

2021-09-09 Thread Mark Wielaard
Hi, On Thu, Sep 09, 2021 at 06:58:10PM +0200, Mark Wielaard wrote: > Also the error handler for debuginfod tests wasn't called when a > command inside a function failed. Since testrun is a function, there > would be no metrics or error log files listed if the testrun command > failed. Making it ha

Buildbot failure in Wildebeest Builder on whole buildset

2021-09-09 Thread buildbot
The Buildbot has detected a new failure on builder elfutils-debian-i386 while building elfutils. Full details are available at: https://builder.wildebeest.org/buildbot/#builders/4/builds/818 Buildbot URL: https://builder.wildebeest.org/buildbot/ Worker for this Build: debian-i386 Build Reas

Buildbot failure in Wildebeest Builder on whole buildset

2021-09-09 Thread buildbot
The Buildbot has detected a new failure on builder elfutils-debian-amd64 while building elfutils. Full details are available at: https://builder.wildebeest.org/buildbot/#builders/2/builds/819 Buildbot URL: https://builder.wildebeest.org/buildbot/ Worker for this Build: debian-amd64 Build Re

Buildbot failure in Wildebeest Builder on whole buildset

2021-09-09 Thread buildbot
The Buildbot has detected a new failure on builder elfutils-centos-x86_64 while building elfutils. Full details are available at: https://builder.wildebeest.org/buildbot/#builders/1/builds/829 Buildbot URL: https://builder.wildebeest.org/buildbot/ Worker for this Build: centos-x86_64 Build