Hi Dmitry, On Thu, 2021-09-09 at 14:31 +0300, Dmitry V. Levin wrote: > This fixes the following compilation warning: > > findtextrel.c:184:1: warning: stack usage might be unbounded [- > Wstack-usage=] > > Signed-off-by: Dmitry V. Levin <l...@altlinux.org> > --- > > v1 introduced a memory leak, so in v2 I rearranged the code a bit > to make clear the new code does not introduce any memory leaks.
Sorry I missed that in my original review. But yes, in the original you only freed on error. Now always. Did the testsuite catch it with configure --enable-valgrind ? Looks good, please apply. Thanks, Mark >
