Re: [PATCH] Add -D_FORTIFY_SOURCE=2 to CFLAGS if possible.

2017-02-14 Thread Mark Wielaard
On Thu, 2017-02-09 at 21:13 +0100, Mark Wielaard wrote: > Some distros now add -D_FORTIFY_SOURCE=2 by default and we have missed > some issues in the past caught by it. Add it to CFLAGS if possible. > The configure check will make sure that it doesn't conflict with any > other CFLAGS already define

Re: [PATCH 3/4] Optionally allow unknown symbols in the backtrace tests

2017-02-14 Thread Mark Wielaard
On Mon, 2017-02-13 at 11:01 +0100, Ulf Hermann wrote: > Thanks for pointing out the issues. I will track down the white space problem. > > > I could reconstruct it from that pastebin. But it was a bit of a > > struggle, some parts didn't apply as is because tabs seemed to be turned > > into spaces

Re: [PATCH 3/4] Optionally allow unknown symbols in the backtrace tests

2017-02-14 Thread Ulf Hermann
I didn't know about perfparse. I assume that is this code base: http://code.qt.io/cgit/qt-creator/perfparser.git/ Very nice. Yes. I'm also trying to port this to windows. So, I have lots of changes to make the code more portable: https://codereview.qt-project.org/#/c/184401/ and the 50 chang

[PATCH] Move color handling into a separate header

2017-02-14 Thread Ulf Hermann
We only need it in nm.c and objdump.c, but it pulls in argp as dependency. By dropping it from libeu.h, the libraries can be compiled without argp. Signed-off-by: Ulf Hermann --- lib/ChangeLog | 7 +++ lib/Makefile.am | 2 +- lib/color.c | 2 +- lib/color.h | 63 +++

Re: [PATCH] Add -D_FORTIFY_SOURCE=2 to CFLAGS if possible.

2017-02-14 Thread Mike Frysinger
On 09 Feb 2017 21:13, Mark Wielaard wrote: > +# See if we can add -D_FORTIFY_SOURCE=2. Don't do it if it is already > +# (differently) defined or if it generates warnings/errors because we > +# don't use the right optimisation level (string.h will warn about that). > +AC_MSG_CHECKING([whether to ad