geode-core dependencies for maven pom

2018-12-06 Thread Kirk Lund
Can someone please point me at the right place to review and alter the dependencies for geode-core that are being published for its maven pom? Also, are there any tests involving the dependencies of the geode-core maven pom?

Re: geode-core dependencies for maven pom

2018-12-06 Thread Kirk Lund
Is this the only file controlling and testing the dependencies for the geode-core maven pom that we publish? geode-core/src/test/resources/expected-pom.xml On Thu, Dec 6, 2018 at 9:52 AM Kirk Lund wrote: > Can someone please point me at the right place to review and alter > the dependencies for

Re: geode-core dependencies for maven pom

2018-12-06 Thread Jacob Barrett
That file is only for testing that the contents are as expected. The POM is generated from dependencies and transitive dependencies specified in the various Gradle files. > On Dec 6, 2018, at 9:55 AM, Kirk Lund wrote: > > Is this the only file controlling and testing the dependencies for the >

Re: geode-core dependencies for maven pom

2018-12-06 Thread Kirk Lund
The geode-core maven pom is missing "spring-shell" -- where can I go to add in "spring-shell" as a required dependency? That's the code or gradle or xml that I want to look at. On Thu, Dec 6, 2018 at 9:57 AM Jacob Barrett wrote: > That file is only for testing that the contents are as expected.

Re: geode-core dependencies for maven pom

2018-12-06 Thread Kirk Lund
Is the presence of "ext.optional = true" for spring-shell in geode-core/build.gradle the reason it's missing from the geode-core maven pom? compile('org.springframework.shell:spring-shell:' + project.'spring-shell.version') { exclude module: 'aopalliance' exclude module: 'asm' exclud

Re: geode-core dependencies for maven pom

2018-12-06 Thread Jacob Barrett
It should be in the POM as optional. > On Dec 6, 2018, at 10:17 AM, Kirk Lund wrote: > > Is the presence of "ext.optional = true" for spring-shell in > geode-core/build.gradle the reason it's missing from the geode-core maven > pom? > > compile('org.springframework.shell:spring-shell:' + > pr

Re: [VOTE] Apache Geode 1.8.0 RC2

2018-12-06 Thread Dan Smith
The native source distribution tarball seems to have a lot of files that aren't in source control. See attached: -Dan On Wed, Dec 5, 2018 at 6:19 PM Alexander Murmann wrote: > Hi Apache Geode community, > > Below you find all the information for the the second release candidate of > Geode 1.8.0

Re: [VOTE] Apache Geode 1.8.0 RC2

2018-12-06 Thread Jacob Barrett
Looks like someone executed CMake in the source directory. > On Dec 6, 2018, at 10:34 AM, Dan Smith wrote: > > The native source distribution tarball seems to have a lot of files that > aren't in source control. See attached: > > -Dan > >> On Wed, Dec 5, 2018 at 6:19 PM Alexander Murmann wr

Re: geode-core dependencies for maven pom

2018-12-06 Thread Kirk Lund
I disagree 100%. It is required for the main use of geode-core which is to create a Cache. Client Cache is something that came later. If you want it a dependency to be optional for Client Caches then please create a geode-client module that generates a pom without this dependency or move the depend

Re: geode-core dependencies for maven pom

2018-12-06 Thread Jacob Barrett
You misunderstood my reply. You were saying it was missing from the Pom and I was saying that it should be in the Pom but marked optional. Whether it should be optional or not in the Pom isn’t really a concern I have. I plan on correcting this nasty stuff with a BOM. See modules PR. > On Dec 6,

Re: [VOTE] Apache Geode 1.8.0 RC2

2018-12-06 Thread Alexander Murmann
Thanks again for catching this! This should now be fixed. On Thu, Dec 6, 2018 at 10:42 AM Jacob Barrett wrote: > Looks like someone executed CMake in the source directory. > > > On Dec 6, 2018, at 10:34 AM, Dan Smith wrote: > > > > The native source distribution tarball seems to have a lot of f

Failing to get resources from Maven in CI

2018-12-06 Thread Helena Bales
Hello, It looks like we are still having some problems with Maven in CI. I got the following error in the pre-checkin for this PR (the first commit). Since I didn't change any dependencies, I would expect the image to already have all the dependencies, a

Re: Failing to get resources from Maven in CI

2018-12-06 Thread Jacob Barrett
Given that this seems to be an ongoing problem with bintray I think it is time we put a local caching repository in our CI network. The native project ran into this same issue for months at one point. Depending on where in the internet you live the bintray host you get can be flakey. For native

Re: [VOTE] Apache Geode 1.8.0 RC2

2018-12-06 Thread Nabarun Nag
+1 on the basis of the below tests. -- Verified SHAs -- Verified signatures. -- Build apache-geode, apache-geode-examples, apache-geode-native -- Ran the examples -- start gfsh, start server, create region, do a put, verify using query. --Verified commit IDs with the release tags. We should creat