Re: Review Request 59692: GEODE-2925: add target for resource operation for finer grained security

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/59692/ --- (Updated June 12, 2017, 2:44 p.m.) Review request for geode, Emily Yeh, Jared S

Re: [VOTE] Using Pull Requests over Review Board

-1 It places an unnecessary burden on committers and git history is the definitive record of changes to the code so github pr history isn't really very useful. Also, Review Board is a much better tool for reviewing code than a github PR. On 6/11/17 9:51 AM, Jacob Barrett wrote: After a fe

Re: Review Request 59961: GEODE-3048: Introduce a rule to identify tests that require GEODE_HOME

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/59961/#review177620 --- Ship it! geode-assembly/src/test/java/org/apache/geode/test/du

Build failed in Jenkins: Geode-nightly #864

See -- [...truncated 96.86 KB...] :geode-cq:assemble :geode-cq:compileTestJavaNote: Some input files use or override a deprecated API. Note: Recompile with -Xlint:deprecation for details. No

Re: release 1.2

Got it, thanks! Anthony > On Jun 10, 2017, at 7:15 PM, Udo Kohlmeyer wrote: > > I thought we had moved GEODE-3052 to a later release, given that we have a > work around for this. > > --Udo > > > On 6/10/17 10:15, Anthony Baker wrote: >> Status update: >> >> We have 2 issues left: GEODE-30

Re: Build failed in Jenkins: Geode-nightly #864

I've created a ticket for the failing wan test: GEODE-3066 On Mon, Jun 12, 2017 at 8:34 AM Apache Jenkins Server < jenk...@builds.apache.org> wrote: > See > >

Re: [VOTE] Using Pull Requests over Review Board

+0 Proposal as written says "...for changes that would require peer review before committing...". If this means that minor changes (in my case, typo repairs are the common case) can be checked in without going through a PR process, I can go with the group decision. Still see no compelling need to r

RE: release 1.2

Hi All, We really think fix done for GEODE-3023 should be considered for 1.2 version as well. Especially since similar fix(GEODE-2898) has been already made it to 1.2 version. So shipping a partial/incomplete fix in 1.2 version for the same kind of problem does not really provide value, and sti

Re: Review Request 59961: GEODE-3048: Introduce a rule to identify tests that require GEODE_HOME

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/59961/#review177640 --- Ship it! Ship It! - Kirk Lund On June 9, 2017, 11:35 p.m., J

Re: Review Request 59692: GEODE-2925: add target for resource operation for finer grained security

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/59692/#review177641 --- I recommend pulling out the changes to SecurityService creation. T

Re: Review Request 59692: GEODE-2925: add target for resource operation for finer grained security

> On June 12, 2017, 5 p.m., Kirk Lund wrote: > > I recommend pulling out the changes to SecurityService creation. The > > changes I have on the feature branch prevent a Locator from allowing > > unsecured joins before the Locator creates its Cache. Sounds good. I will rebase my change on top o

Review Request 60010: GEODE-3062: replace SecurityService after loading cluster config

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60010/ --- Review request for geode, Emily Yeh, Jinmei Liao, Jared Stewart, Ken Howe, and P

Re: Review Request 60010: GEODE-3062: replace SecurityService after loading cluster config

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60010/#review177650 --- Ship it! Ship It! - Jinmei Liao On June 12, 2017, 5:40 p.m.,

Re: [VOTE] Using Pull Requests over Review Board

+1 On using PR. I feel using github PR is more convenient because of the following reasons a. Commit messages are automatically made into the header and description in PR, whereas in reviewboard, you upload the patch and do all the writing - manually. It feels redundant. b. After changing the cod

[GitHub] geode pull request #568: GEODE-290: Removed deprecated methods from Launcher...

Github user asfgit closed the pull request at: https://github.com/apache/geode/pull/568 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabl

[GitHub] geode pull request #574: GEODE-3066: Test tweaks to stabilize it.

GitHub user nabarunnag opened a pull request: https://github.com/apache/geode/pull/574 GEODE-3066: Test tweaks to stabilize it. * Regions created before senders and receivers are started. * Added a listener to slow down the puts so that when the remote region is destroye

[GitHub] geode pull request #571: GEODE-2601: Fixing banner being logged twice during...

Github user YehEmily commented on a diff in the pull request: https://github.com/apache/geode/pull/571#discussion_r121498978 --- Diff: geode-core/src/main/java/org/apache/geode/distributed/internal/InternalLocator.java --- @@ -478,9 +478,8 @@ private InternalLocator(int port, File

[GitHub] geode pull request #571: GEODE-2601: Fixing banner being logged twice during...

Github user YehEmily commented on a diff in the pull request: https://github.com/apache/geode/pull/571#discussion_r121499647 --- Diff: geode-core/src/main/java/org/apache/geode/internal/logging/LogWriterFactory.java --- @@ -87,19 +87,19 @@ public static InternalLogWriter createLo

[GitHub] geode pull request #571: GEODE-2601: Fixing banner being logged twice during...

Github user YehEmily closed the pull request at: https://github.com/apache/geode/pull/571 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is ena

Review Request 60025: GEODE-3060: Introduce JUnit rule for testing the fully-assembled GFSH

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60025/ --- Review request for geode, Emily Yeh, Jared Stewart, Ken Howe, Kirk Lund, and Pat

Re: Review Request 60010: GEODE-3062: replace SecurityService after loading cluster config

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60010/#review177668 --- geode-core/src/main/java/org/apache/geode/internal/cache/GemFireC

Review Request 60028: GEODE-2632: consolidate different types of SecurityService

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60028/ --- Review request for geode, Emily Yeh, Jared Stewart, Ken Howe, Kirk Lund, and Pat

Re: Review Request 60025: GEODE-3060: Introduce JUnit rule for testing the fully-assembled GFSH

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60025/#review177670 --- geode-assembly/src/test/java/org/apache/geode/management/internal

[GitHub] geode issue #574: GEODE-3066: Test tweaks to stabilize it.

Github user nabarunnag commented on the issue: https://github.com/apache/geode/pull/574 @jhuynh1 , Last when we experimented with this function in WANTestBase tests, the listener is destroyed once the vm is closed, which I believe that happens at the end of each test. --- If your p

Errored: apache/geode#2843 (develop - f85d216)

Build Update for apache/geode - Build: #2843 Status: Errored Duration: 4 minutes and 25 seconds Commit: f85d216 (develop) Author: Jinmei Liao Message: GEODE-2928: get rid of the isGfshVM static variable * consolidate the availability indicators * remove the is

Re: Errored: apache/geode#2843 (develop - f85d216)

my bad. This should be fixed now. On Mon, Jun 12, 2017 at 2:07 PM, Travis CI wrote: > Build Update for apache/geode > - > > Build: #2843 > Status: Errored > > Duration: 4 minutes and 25 seconds > Commit: f85d216 (develop) > Author: Jinmei Liao > Message: GEODE

Review Request 60030: GEODE-2925: finer security for disk management

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60030/ --- Review request for geode, Emily Yeh, Jared Stewart, Ken Howe, Kirk Lund, and Pat

Re: Review Request 59961: GEODE-3048: Introduce a rule to identify tests that require GEODE_HOME

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/59961/#review177671 --- Ship it! Ship It! - Emily Yeh On June 9, 2017, 11:35 p.m., J

[GitHub] geode pull request #574: GEODE-3066: Test tweaks to stabilize it.

Github user asfgit closed the pull request at: https://github.com/apache/geode/pull/574 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabl

Re: Review Request 59961: GEODE-3048: Introduce a rule to identify tests that require GEODE_HOME

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/59961/ --- (Updated June 12, 2017, 9:19 p.m.) Review request for geode, Emily Yeh, Jared S

Re: Review Request 59961: GEODE-3048: Introduce a rule to identify tests that require GEODE_HOME

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/59961/#review177674 --- Ship it! Ship It! - Jinmei Liao On June 12, 2017, 9:19 p.m.,

Re: Review Request 60025: GEODE-3060: Introduce JUnit rule for testing the fully-assembled GFSH

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60025/ --- (Updated June 12, 2017, 9:50 p.m.) Review request for geode, Emily Yeh, Jared S

Re: Review Request 60025: GEODE-3060: Introduce JUnit rule for testing the fully-assembled GFSH

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60025/#review177679 --- Ship it! Ship It! - Jinmei Liao On June 12, 2017, 9:50 p.m.,

[Spring CI] Spring Data GemFire > Nightly-ApacheGeode > #583 was SUCCESSFUL (with 1868 tests)

--- Spring Data GemFire > Nightly-ApacheGeode > #583 was successful. --- Scheduled 1870 tests in total. https://build.spring.io/browse/SGF-NAG-583/ -- This

[GitHub] geode pull request #575: GEODE-3048: Editing tests requiring Gradle test run...

GitHub user YehEmily opened a pull request: https://github.com/apache/geode/pull/575 GEODE-3048: Editing tests requiring Gradle test runner to fail descriptively in IntelliJ Thank you for submitting a contribution to Apache Geode. In order to streamline the review of the co

[GitHub] geode issue #575: GEODE-3048: Editing tests requiring Gradle test runner to ...

Github user YehEmily commented on the issue: https://github.com/apache/geode/pull/575 Precheckin in progress! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes s

Re: [VOTE] Using Pull Requests over Review Board

0 for PR - I feel that both have their benefits and downsides. * +1 for PR: As Naba stated, the integration is simplified and using Intellij there is even support to create a PR. Single system to rule them all. * -1 for PR: I fear that given the huge amount of incoming PR's we might lo

[GitHub] geode pull request #576: Geode 2920, 2921, 2922, 2924

GitHub user PurelyApplied opened a pull request: https://github.com/apache/geode/pull/576 Geode 2920, 2921, 2922, 2924 This PR is intended for initial review, not to be actively considered for acceptance. Sufficient testing is still required and `develop` shifted enough today that

[GitHub] geode issue #573: GEODE-2622: Fix test failures caused by upgrade to Mockito...

Github user kirklund commented on the issue: https://github.com/apache/geode/pull/573 I just pulled this in to feature/GEODE-2558. I changed the git commit message to: GEODE-2622: Fix GMSMembershipManagerJUnitTest use of Mockito 2.7.11 - Fix 4 test failures in GMSMemb

Re: [VOTE] Using Pull Requests over Review Board

We can always set up a bit of automation so that committers are notified if a PR sits unattended for a period of time. --Jens On Mon, Jun 12, 2017 at 4:20 PM, Udo Kohlmeyer wrote: > 0 for PR - I feel that both have their benefits and downsides. > > * +1 for PR: As Naba stated, the integration

[GitHub] geode issue #573: GEODE-2622: Fix test failures caused by upgrade to Mockito...

Github user kirklund commented on the issue: https://github.com/apache/geode/pull/573 Your PR is safely committed to feature/GEODE-2558. I also rebased feature/GEODE-2558 on develop. Normally asfgit (an Apache bot) would close this PR but it won't do that until I merge feature/GEODE-2

[GitHub] geode pull request #577: Feature/geode 3049

GitHub user nreich opened a pull request: https://github.com/apache/geode/pull/577 Feature/geode 3049 This request attempts to add logging for when the last copy of a bucket in a PartitionedRegion is lost (we already log on loss of consistency and on every drop in number of copies,

Build failed in Jenkins: Geode-nightly #865

See Changes: [jiliao] GEODE-2925: add target for resource operation for finer grained security [dbarnes] Update geode-book README instructions [klund] GEODE-290: Remove deprecated methods from launcher classes [j