----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60025/#review177670 -----------------------------------------------------------
geode-assembly/src/test/java/org/apache/geode/management/internal/cli/commands/StatusLocatorRealGfshTest.java Lines 30 (patched) <https://reviews.apache.org/r/60025/#comment251353> would be a good idea for that GEODE_HOME rule to provide this. geode-assembly/src/test/java/org/apache/geode/test/dunit/rules/gfsh/GfshRule.java Lines 28 (patched) <https://reviews.apache.org/r/60025/#comment251351> would be a good idea to provide a javadoc for this. geode-assembly/src/test/java/org/apache/geode/test/dunit/rules/gfsh/GfshRule.java Lines 29 (patched) <https://reviews.apache.org/r/60025/#comment251352> would the user of this rule also require that GEODE_HOME rule you wrote as well? Can this rule implies that rule so that user doesn't need to have both rules in place? - Jinmei Liao On June 12, 2017, 7:53 p.m., Jared Stewart wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/60025/ > ----------------------------------------------------------- > > (Updated June 12, 2017, 7:53 p.m.) > > > Review request for geode, Emily Yeh, Jared Stewart, Ken Howe, Kirk Lund, and > Patrick Rhomberg. > > > Repository: geode > > > Description > ------- > > GEODE-3060: Introduce JUnit rule for testing the fully-assembled GFSH > > > Diffs > ----- > > > geode-assembly/src/test/java/org/apache/geode/management/internal/cli/commands/StatusLocatorRealGfshTest.java > PRE-CREATION > > geode-assembly/src/test/java/org/apache/geode/test/dunit/rules/gfsh/GfshRule.java > PRE-CREATION > > geode-assembly/src/test/java/org/apache/geode/test/dunit/rules/gfsh/GfshScript.java > PRE-CREATION > > > Diff: https://reviews.apache.org/r/60025/diff/1/ > > > Testing > ------- > > Precheckin started (still running) > > > Thanks, > > Jared Stewart > >
