[PATCH] D40481: [libclang] Fix cursors for arguments of Subscript and Call operators

yvvan accepted this revision. yvvan added a comment. This revision is now accepted and ready to land. Let's proceed with this one. I really see that it's going to be useful. https://reviews.llvm.org/D40481 ___ cfe-commits mailing list cfe-commits@li

[PATCH] D40481: [libclang] Fix cursors for arguments of Subscript and Call operators

This revision was automatically updated to reflect the committed changes. Closed by commit rL340521: [libclang] Fix cursors for arguments of Subscript and Call operators (authored by yvvan, committed by ). Herald added a subscriber: llvm-commits. Changed prior to commit: https://reviews.llvm.or

[PATCH] D41537: Optionally add code completion results for arrow instead of dot

yvvan marked 3 inline comments as done. yvvan added a comment. I have some failing tests... So I will update the diff a bit later (Friday most likely) Comment at: include/clang/Sema/CodeCompleteConsumer.h:564 + + /// \brief For this completion result correction is required. +

[PATCH] D41537: Optionally add code completion results for arrow instead of dot

yvvan updated this revision to Diff 146289. yvvan marked 3 inline comments as done. yvvan added a comment. Only keep small completion fixit-s in CodeCompletionResults. Change libclang calls to overcome that and not use CXCompletionString https://reviews.llvm.org/D41537 Files: include/clang-c/

[PATCH] D41537: Optionally add code completion results for arrow instead of dot

yvvan added a comment. ping I hope this review won't take forever :) https://reviews.llvm.org/D41537 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D41537: Optionally add code completion results for arrow instead of dot

yvvan added a comment. In https://reviews.llvm.org/D41537#1097763, @ilya-biryukov wrote: > I should've suggested splitting the change into two earlier. Next time I will do that from the beginning :) Comment at: tools/libclang/CIndexCodeCompletion.cpp:309 + /// before that r

[PATCH] D46862: Optionally add code completion results for arrow instead of dot (libclang)

yvvan created this revision. yvvan added reviewers: ilya-biryukov, klimek, bkramer, arphaman. Follow up for https://reviews.llvm.org/D41537 - libclang part is extracted into this review https://reviews.llvm.org/D46862 Files: include/clang-c/Index.h test/Index/complete-arrow-dot.cpp tools

[PATCH] D41537: Optionally add code completion results for arrow instead of dot

yvvan updated this revision to Diff 146749. yvvan marked 2 inline comments as done. yvvan added a comment. Only C++ part, libclang part has moved to https://reviews.llvm.org/D46862 https://reviews.llvm.org/D41537 Files: include/clang/Basic/DiagnosticSemaKinds.td include/clang/Sema/CodeCompl

[PATCH] D41537: Optionally add code completion results for arrow instead of dot

yvvan added inline comments. Comment at: lib/Sema/SemaCodeComplete.cpp:4118 + : diag::err_typecheck_member_reference_suggestion; + Diag(OpLoc, DiagID) << ConvertedBaseType << IsArrow + << Base->getSourceRange() << FixIt;

[PATCH] D41537: Optionally add code completion results for arrow instead of dot

yvvan added a comment. I will add more tests... Comment at: test/SemaCXX/member-expr.cpp:193 +Cl0* c; +return c.a; // expected-error {{member reference type 'PR15045::Cl0 *' is a pointer; did you mean to use '->'?}} + } ilya-biryukov wrote: > Is this

[PATCH] D41537: Optionally add code completion results for arrow instead of dot

yvvan updated this revision to Diff 147039. yvvan marked 4 inline comments as done. yvvan added a comment. Append PrintingCodeCompleteConsumer and CompilerInvocation options, add CodeCompletion tests. https://reviews.llvm.org/D41537 Files: include/clang/Driver/CC1Options.td include/clang/S

[PATCH] D46862: Optionally add code completion results for arrow instead of dot (libclang)

yvvan updated this revision to Diff 147042. yvvan added a comment. The base revision has changed - some minor changes were also required here. https://reviews.llvm.org/D46862 Files: include/clang-c/Index.h test/Index/complete-arrow-dot.cpp tools/c-index-test/c-index-test.c tools/libclan

[PATCH] D46050: [Frontend] Avoid running plugins during code completion parse

This revision was automatically updated to reflect the committed changes. Closed by commit rL332469: [Frontend] Avoid running plugins during code completion parse (authored by yvvan, committed by ). Herald added a subscriber: llvm-commits. Changed prior to commit: https://reviews.llvm.org/D4605

[PATCH] D46050: [Frontend] Avoid running plugins during code completion parse

This revision was automatically updated to reflect the committed changes. Closed by commit rC332469: [Frontend] Avoid running plugins during code completion parse (authored by yvvan, committed by ). Changed prior to commit: https://reviews.llvm.org/D46050?vs=146999&id=147077#toc Repository:

[PATCH] D45815: [libclang] Allow skipping function bodies in preamble only

This revision was automatically updated to reflect the committed changes. Closed by commit rC332578: [libclang] Allow skipping function bodies in preamble only (authored by yvvan, committed by ). Changed prior to commit: https://reviews.llvm.org/D45815?vs=145648&id=147253#toc Repository: rC

[PATCH] D40481: [libclang] Fix cursors for arguments of Subscript and Call operators

yvvan added a comment. Tests run fine but the solution feels like a workaround. Nevertheless if we are sure that extending the subscript/call operator range does not work properly or breaks too many other things than it's probably fine to have this workaround. https://reviews.llvm.org/D40481

[PATCH] D41537: Optionally add code completion results for arrow instead of dot

yvvan added inline comments. Comment at: lib/Sema/CodeCompleteConsumer.cpp:559 +const char *Begin = +SemaRef.SourceMgr.getCharacterData(FixIt.RemoveRange.getBegin()); +const char *End = ilya-biryukov wrote: > Unfortunately, that might

[PATCH] D41537: Optionally add code completion results for arrow instead of dot

yvvan added inline comments. Comment at: lib/Sema/SemaCodeComplete.cpp:4109 + if (CodeCompleter->includeFixIts()) { +const SourceRange OpRange(OpLoc, OpLoc.getLocWithOffset(IsArrow ? 2 : 1)); +CompletionSucceded = ilya-biryukov wrote: > yvvan wrote: > >

[PATCH] D41537: Optionally add code completion results for arrow instead of dot

yvvan updated this revision to Diff 148164. yvvan marked 4 inline comments as done. https://reviews.llvm.org/D41537 Files: include/clang/Driver/CC1Options.td include/clang/Sema/CodeCompleteConsumer.h include/clang/Sema/CodeCompleteOptions.h include/clang/Sema/Sema.h lib/Frontend/ASTUnit

[PATCH] D46862: [libclang] Optionally add code completion results for arrow instead of dot

yvvan updated this revision to Diff 148177. yvvan added a comment. Output range of token being replaced instead of it's text As a side-effect introduce a call to get a Token starting from specified location. https://reviews.llvm.org/D46862 Files: include/clang-c/Index.h test/Index/complet

[PATCH] D41537: Optionally add code completion results for arrow instead of dot

yvvan marked 4 inline comments as done. yvvan added inline comments. Comment at: lib/Sema/SemaCodeComplete.cpp:4148 + + CompletionSucceded |= DoCompletion(Base, IsArrow, None); + ilya-biryukov wrote: > NIT: maybe swap the two cases to do the non-fixit ones first

[PATCH] D41537: Optionally add code completion results for arrow instead of dot

yvvan marked an inline comment as done. yvvan added inline comments. Comment at: lib/Sema/SemaCodeComplete.cpp:4148 + + CompletionSucceded |= DoCompletion(Base, IsArrow, None); + yvvan wrote: > ilya-biryukov wrote: > > NIT: maybe swap the two cases to do the non

[PATCH] D41537: Optionally add code completion results for arrow instead of dot

yvvan updated this revision to Diff 148553. yvvan added a comment. NIT-s addressed https://reviews.llvm.org/D41537 Files: include/clang/Driver/CC1Options.td include/clang/Sema/CodeCompleteConsumer.h include/clang/Sema/CodeCompleteOptions.h include/clang/Sema/Sema.h lib/Frontend/ASTUni

[PATCH] D46862: [libclang] Optionally add code completion results for arrow instead of dot

yvvan updated this revision to Diff 148559. yvvan added a comment. Update according to c++ part changes https://reviews.llvm.org/D46862 Files: include/clang-c/Index.h test/Index/complete-arrow-dot.cpp tools/c-index-test/c-index-test.c tools/libclang/CIndex.cpp tools/libclang/CIndexCod

[PATCH] D41537: Optionally add code completion results for arrow instead of dot

This revision was automatically updated to reflect the committed changes. Closed by commit rL333272: Optionally add code completion results for arrow instead of dot (authored by yvvan, committed by ). Herald added a subscriber: llvm-commits. Changed prior to commit: https://reviews.llvm.org/D41

[PATCH] D47460: Treat files as volatile by default

yvvan created this revision. yvvan added reviewers: ilya-biryukov, nik, klimek, bkramer. Prevent accidental memory mapping for main file which sometimes happens through FileSystem::getBufferForFile https://reviews.llvm.org/D47460 Files: include/clang/Basic/VirtualFileSystem.h Index: includ

[PATCH] D47460: Treat files as volatile by default

yvvan added a comment. The precise path which leads here is yet unclear for me (it requires much more time to research) but changing this specific default value to true fixes main file from being memory mapped and therefore being blocked (on Windows) I assume it comes from FileManager::getBuffer

[PATCH] D46862: [libclang] Optionally add code completion results for arrow instead of dot

yvvan updated this revision to Diff 149049. yvvan marked 6 inline comments as done. yvvan added a comment. Address review comments https://reviews.llvm.org/D46862 Files: include/clang-c/Index.h include/clang/Sema/CodeCompleteConsumer.h test/Index/complete-arrow-dot.cpp tools/c-index-tes

[PATCH] D46862: [libclang] Optionally add code completion results for arrow instead of dot

yvvan added inline comments. Comment at: include/clang-c/Index.h:5264 + * FixIts that *must* be applied before inserting the text for the + * corresponding completion item. + * nik wrote: > * Please use proper documentation style, e.g. make use of "\brief", "\par

[PATCH] D36390: Fix overloaded static functions in SemaCodeComplete

yvvan added a comment. ping 3 https://reviews.llvm.org/D36390 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D38618: Do not add a colon chunk to the code completion of class inheritance access modifiers

yvvan created this revision. With enabled CINDEXTEST_CODE_COMPLETE_PATTERNS env option (which enables IncludeCodePatterns in completion options) code completion after colon currently suggests access modifiers with 2 completion chunks which is incorrect. Example: class A : B { } Currently we ge

[PATCH] D38618: Do not add a colon chunk to the code completion of class inheritance access modifiers

yvvan updated this revision to Diff 117988. yvvan added a comment. Fix according to the review comment https://reviews.llvm.org/D38618 Files: include/clang/Sema/Scope.h lib/Parse/ParseDeclCXX.cpp lib/Sema/SemaCodeComplete.cpp test/Index/complete-super.cpp Index: test/Index/complete-su

[PATCH] D38618: Do not add a colon chunk to the code completion of class inheritance access modifiers

yvvan updated this revision to Diff 119273. yvvan added a comment. Rebased to update ScopeFlags. Rereview please https://reviews.llvm.org/D38618 Files: include/clang/Sema/Scope.h lib/Parse/ParseDeclCXX.cpp lib/Sema/SemaCodeComplete.cpp test/Index/complete-super.cpp Index: test/Index/c

[PATCH] D38618: Do not add a colon chunk to the code completion of class inheritance access modifiers

yvvan added a comment. ping https://reviews.llvm.org/D38618 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D51281: [libclang] Return the proper pointee type for 'auto' deduced to pointer

yvvan created this revision. yvvan added reviewers: erikjv, arphaman, michaelwu. Currently the resulting type is always invalid in such case. https://reviews.llvm.org/D51281 Files: tools/libclang/CXType.cpp Index: tools/libclang/CXType.cpp ===

[PATCH] D51281: [libclang] Return the proper pointee type for 'auto' deduced to pointer

yvvan added a comment. You are completely right! Thanks! I did not think that -test-print-type also checks for the pointee. https://reviews.llvm.org/D51281 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman

[PATCH] D51281: [libclang] Return the proper pointee type for 'auto' deduced to pointer

yvvan updated this revision to Diff 164151. yvvan added a comment. Comments addressed https://reviews.llvm.org/D51281 Files: test/Index/print-type.cpp tools/libclang/CXType.cpp Index: tools/libclang/CXType.cpp === --- tools/l

[PATCH] D51281: [libclang] Return the proper pointee type for 'auto' deduced to pointer

This revision was automatically updated to reflect the committed changes. Closed by commit rL341656: [libclang] Return the proper pointee type for 'auto' deduced to pointer (authored by yvvan, committed by ). Herald added a subscriber: llvm-commits. Changed prior to commit: https://reviews.llvm

[PATCH] D49010: YAML output for index-while-building

yvvan added a comment. @ilya-biryukov I would name this revision "for test purpose". It works at some extent with the current clangd version and can be used by someone else. But since we had a discussion about YAML being a temporary solution I never planned to commit this revision. So yes, I t

[PATCH] D49794: [libclang] Allow skipping warnings from all included files

yvvan created this revision. yvvan added reviewers: ilya-biryukov, bkramer, akyrtzi, malaperle. Updated clone for https://reviews.llvm.org/D48116 by Nikolai, now also adds the clang driver flag and the test for it. If clang has plugins they are also affected by this filtering. Depending on the i

[PATCH] D49063: [libclang 1/8] Add support for ObjCObjectType

yvvan added a comment. I'm mostly fine with your set of patches. Let me double check and we can get it in. https://reviews.llvm.org/D49063 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-co

[PATCH] D49794: [libclang] Allow skipping warnings from all included files

yvvan updated this revision to Diff 158211. yvvan added a comment. Restore missing tests https://reviews.llvm.org/D49794 Files: include/clang-c/Index.h include/clang/Basic/Diagnostic.h include/clang/Basic/DiagnosticOptions.def include/clang/Driver/Options.td lib/Basic/DiagnosticIDs.cp

[PATCH] D49794: [libclang] Allow skipping warnings from all included files

yvvan added a comment. I already mentioned in the review inherited by this one that this way covers also loaded plugins with different consumers. So let's assume that driver loads clang-tidy and some other plugins and runs over each file in the project. It makes sense not to include clang-tidy d

[PATCH] D49794: [libclang] Allow skipping warnings from all included files

yvvan added a comment. And we already saw, that -isystem is not the best choice for that. And by the way - clang-tidy has this filtering in consumer which does not exist in it's plugin-mode so it spits all system diagnostics all the time... https://reviews.llvm.org/D49794 __

[PATCH] D49794: [libclang] Allow skipping warnings from all included files

yvvan added a comment. Anyways, if c++ part does not seem relevant I'm fine if we only have libclang part from https://reviews.llvm.org/D48116. BTW I don't remember if you answered something to my suggestion of adding flag -ithird-party as an alternative to -isystem which does not lock files an

[PATCH] D49794: [libclang] Allow skipping warnings from all included files

yvvan added a comment. In https://reviews.llvm.org/D49794#1182272, @ilya-biryukov wrote: > In https://reviews.llvm.org/D49794#1182220, @yvvan wrote: > > > And we already saw, that -isystem is not the best choice for that. > > > Are you referring to the file-locking on Windows? > Any other reaso

[PATCH] D42895: [libclang] Add `CXSymbolRole role` to CXIdxEntityRefInfo

yvvan added a comment. I feel quite ok about this patch. Can you please add unit-tests? Repository: rC Clang https://reviews.llvm.org/D42895 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/c

[PATCH] D41537: Optionally add code completion results for arrow instead of dot

yvvan added a comment. ping... https://reviews.llvm.org/D41537 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D42895: [libclang] Add `CXSymbolRole role` to CXIdxEntityRefInfo

yvvan added reviewers: ilya-biryukov, bkramer, arphaman. yvvan added a comment. Looks ok-ish, I haven't built it though. Also I don't have much exp with indexing part of libclang. Adding more reviewers. Repository: rC Clang https://reviews.llvm.org/D42895 _

[PATCH] D41005: Reuse preamble even if an unsaved file does not exist

yvvan added a comment. In https://reviews.llvm.org/D41005#1001854, @cameron314 wrote: > @yvvan: The clang frontend tests (`PCHPreambleTest` and friends) are disabled > on Windows in the makefile (I think because the VFS tests depend on > linux-like paths). So running the tests on Windows withou

[PATCH] D41537: Optionally add code completion results for arrow instead of dot

yvvan added a comment. ping https://reviews.llvm.org/D41537 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D41537: Optionally add code completion results for arrow instead of dot

yvvan added a comment. I've already added hints in this patch and it also do not add extra completions unless the flag IncludeCorrections is set. So this will not force editors to use corrections. Did you mean that you think it's good to have extra fixit hints even if this flag is not set? h

[PATCH] D41537: Optionally add code completion results for arrow instead of dot

yvvan added a comment. Or is your idea is to return the char sequence instead to use this correction in some universal way? https://reviews.llvm.org/D41537 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailma

[PATCH] D33493: Speed up preamble loading, reduce global completion cache calls

yvvan created this revision. On Windows loading preamble and caching global completion takes a while. This is the way to improve it. Please comment if I misuse something. https://reviews.llvm.org/D33493 Files: include/clang/Frontend/ASTUnit.h lib/Frontend/ASTUnit.cpp Index: lib/Frontend/A

[PATCH] D33493: Speed up preamble loading, reduce global completion cache calls

yvvan updated this revision to Diff 100075. yvvan added a comment. fix member variable name, add comments https://reviews.llvm.org/D33493 Files: include/clang/Frontend/ASTUnit.h lib/Frontend/ASTUnit.cpp Index: lib/Frontend/ASTUnit.cpp ==

[PATCH] D33493: Speed up preamble loading, reduce global completion cache calls

yvvan updated this revision to Diff 100605. yvvan added a comment. diff with -U https://reviews.llvm.org/D33493 Files: include/clang/Frontend/ASTUnit.h lib/Frontend/ASTUnit.cpp Index: lib/Frontend/ASTUnit.cpp === --- lib/

[PATCH] D33644: Add default values for function parameter chunks

yvvan created this revision. Append optional chunks with their default values. For example: before - "int i", after - "int i = 10". This change affects only simple types. https://reviews.llvm.org/D33644 Files: lib/Sema/SemaCodeComplete.cpp Index: lib/Sema/SemaCodeComplete.cpp =

[PATCH] D33644: Add default values for function parameter chunks

yvvan updated this revision to Diff 100705. yvvan edited the summary of this revision. yvvan added a comment. Support for non-simple types. Drop results with macros. https://reviews.llvm.org/D33644 Files: lib/Sema/SemaCodeComplete.cpp Index: lib/Sema/SemaCodeComplete.cpp ===

[PATCH] D33644: Add default values for function parameter chunks

yvvan added a comment. Waiting for review... https://reviews.llvm.org/D33644 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D33493: Speed up preamble loading, reduce global completion cache calls

yvvan updated this revision to Diff 101533. yvvan added a comment. Remove global completion cache part because it's probably not always valid. https://reviews.llvm.org/D33493 Files: include/clang/Frontend/ASTUnit.h lib/Frontend/ASTUnit.cpp Index: lib/Frontend/ASTUnit.cpp =

[PATCH] D33493: Speed up preamble loading

yvvan added a comment. In https://reviews.llvm.org/D33493#774264, @arphaman wrote: > Can you use a local map in `TranslateStoredDiagnostics` instead of storing > one in the `ASTUnit`, or do you need to keep it around? The whole purpose is to use it between different TranslateStoredDiagnostics

[PATCH] D33493: Speed up preamble loading

yvvan added inline comments. Comment at: include/clang/Frontend/ASTUnit.h:192 + /// of that loading + std::map SrcLocCache; + arphaman wrote: > You can use an `llvm::StringMap` instead. I will change that Comment at: lib/Frontend/ASTUnit.cpp:

[PATCH] D33493: Speed up preamble loading

yvvan updated this revision to Diff 101865. yvvan added a comment. Improve commentary. Use StringMap https://reviews.llvm.org/D33493 Files: include/clang/Frontend/ASTUnit.h lib/Frontend/ASTUnit.cpp Index: lib/Frontend/ASTUnit.cpp ===

[PATCH] D33493: Speed up preamble loading

yvvan updated this revision to Diff 101995. yvvan added a comment. "what kind of performance benefits do you get for the preamble load times?" In cases where many windows headers are included preamble loading takes almost the half of reparse time. With this fix time to load preamble goes towards

[PATCH] D33644: Add default values for function parameter chunks

yvvan added a comment. Can someone check my review please? https://reviews.llvm.org/D33644 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D34098: Allow to set incremental processing from CIndex

yvvan created this revision. Make possible to parse translation Unit in CIndex with incremental processing turned on. 1. Why to do that? - Reparse with that option takes less time. 2. What's the affected area? - I don't know. Can someone explain me what incremental processing is and what I loos

[PATCH] D33644: Add default values for function parameter chunks

yvvan added a comment. Anyone? :) https://reviews.llvm.org/D33644 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D33644: Add default values for function parameter chunks

yvvan added a comment. In https://reviews.llvm.org/D33644#780188, @klimek wrote: > Can you give a bit more background what this is trying to do? Sure :) Currently default value string does not contain default value itself. This change fixes it and adds the default value to the string. https:

[PATCH] D33644: Add default values for function parameter chunks

yvvan added inline comments. Comment at: lib/Sema/SemaCodeComplete.cpp:2411-2417 + const SourceLocation StartLoc = SrcRange.getBegin(); + const SourceLocation EndLoc = SrcRange.getEnd(); + if (StartLoc != SM.getExpansionLoc(StartLoc) || EndLoc != SM.getExpansionLoc(EndLoc)) +

[PATCH] D33644: Add default values for function parameter chunks

yvvan added inline comments. Comment at: lib/Sema/SemaCodeComplete.cpp:2453 std::string PlaceholderStr = FormatFunctionParameter(Policy, Param); +if (Param->hasDefaultArg() && PlaceholderStr.find("=") == std::string::npos) { +std::string DefaultValue = -

[PATCH] D33644: Add default values for function parameter chunks

yvvan updated this revision to Diff 102800. yvvan added a comment. Use Lexer::getSourceText https://reviews.llvm.org/D33644 Files: lib/Sema/SemaCodeComplete.cpp Index: lib/Sema/SemaCodeComplete.cpp === --- lib/Sema/SemaCodeComp

[PATCH] D34279: Fix release_40 build with MSVC (VS 2015)

yvvan created this revision. I currently have narrowing conversion error without that fix. I try building with 64 and 32 bit compilers - both reproduce that error. https://reviews.llvm.org/D34279 Files: include/llvm/Target/TargetOpcodes.h Index: include/llvm/Target/TargetOpcodes.h =

[PATCH] D34279: Fix release_40 build with MSVC (VS 2015)

yvvan added a comment. error list https://reviews.llvm.org/D34279 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-c

[PATCH] D34279: Fix release_40 build with MSVC (VS 2015)

yvvan added a comment. I also did not have any local patches applied - just checked out release_40 branch for llvm and clang. I believe I also don't have warnings as errors enabled. At least I've checked for the extra flags and did not find such. I'll search once again if I have /WX somewhere i

[PATCH] D34279: Fix release_40 build with MSVC (VS 2015)

yvvan added a comment. I've checked once again. Werror is disabled and no /WX flag is used. So this is a compiler error in case of msvc even without these flags. https://reviews.llvm.org/D34279 ___ cfe-commits mailing list cfe-commits@lists.llvm.or

[PATCH] D34279: Fix release_40 build with MSVC (VS 2015)

yvvan added a comment. btw my cl version is 19.00.24215.1 (MS VS 2015 Update 3). Do you use the same one? https://reviews.llvm.org/D34279 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-com

[PATCH] D33644: Add default values for function parameter chunks

yvvan added inline comments. Comment at: lib/Sema/SemaCodeComplete.cpp:2453 std::string PlaceholderStr = FormatFunctionParameter(Policy, Param); +if (Param->hasDefaultArg() && PlaceholderStr.find("=") == std::string::npos) { +std::string DefaultValue = -

[PATCH] D33644: Add default values for function parameter chunks

yvvan updated this revision to Diff 103016. yvvan added a comment. Do not evaluate numbers. Check for != "=" is needed not to mess with invalid default arguments or their types (without it I get "const Bar& bar = =" when Bar is not defined) https://reviews.llvm.org/D33644 Files: lib/Sema/Sem

[PATCH] D34279: Fix release_40 build with MSVC (VS 2015)

yvvan added a comment. In https://reviews.llvm.org/D34279#784089, @hans wrote: > I have 19.00.24210, so slightly earlier I suppose, but I believe we use > Update 3 on our Chromium buildbots, and they seem happy. > > Can you paste the full error message? The part I see in your screenshot > doesn

[PATCH] D34279: Fix release_40 build with MSVC (VS 2015)

yvvan added a comment. I've tried once again to make a clean build and it worked... :) And I can't imagine what kind of configuration issue could it be because I always use quite the same one :) https://reviews.llvm.org/D34279 ___ cfe-commits maili

[PATCH] D41537: Optionally add code completion results for arrow instead of dot

yvvan created this revision. yvvan added reviewers: klimek, bkramer, arphaman, ilya-biryukov, erikjv. Currently getting such completions requires source correction, reparsing and calling completion again. And if it shows no results and rollback is required then it costs one more reparse. With th

[PATCH] D41005: Reuse preamble even if an unsaved file does not exist

yvvan added a comment. No regression in tests on Windows with and without extra patch ([PATCH] Use file path instead of uniqueID) Repository: rC Clang https://reviews.llvm.org/D41005 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http:/

[PATCH] D40072: [libclang] Support querying whether a declaration is invalid

This revision was automatically updated to reflect the committed changes. Closed by commit rC321697: [libclang] Support querying whether a declaration is invalid (authored by yvvan, committed by ). Changed prior to commit: https://reviews.llvm.org/D40072?vs=128491&id=128497#toc Repository: r

[PATCH] D40561: [libclang] Fix cursors for functions with trailing return type

This revision was automatically updated to reflect the committed changes. Closed by commit rC321698: [libclang] Fix cursors for functions with trailing return type (authored by yvvan, committed by ). Changed prior to commit: https://reviews.llvm.org/D40561?vs=124576&id=128499#toc Repository:

[PATCH] D41537: Optionally add code completion results for arrow instead of dot

yvvan updated this revision to Diff 128509. yvvan added a comment. Update CIndex minor version, add call to libclang.exports https://reviews.llvm.org/D41537 Files: include/clang-c/Index.h include/clang/Sema/CodeCompleteConsumer.h include/clang/Sema/CodeCompleteOptions.h lib/Frontend/AST

[PATCH] D41537: Optionally add code completion results for arrow instead of dot

yvvan added a comment. ping https://reviews.llvm.org/D41537 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D35200: Don't use mmap on Windows

yvvan abandoned this revision. yvvan added a comment. It was the wrong direction https://reviews.llvm.org/D35200 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D41537: Optionally add code completion results for arrow instead of dot

yvvan updated this revision to Diff 138139. yvvan added a comment. Return possibly required corrections in the string form https://reviews.llvm.org/D41537 Files: include/clang-c/Index.h include/clang/Basic/DiagnosticSemaKinds.td include/clang/Sema/CodeCompleteConsumer.h include/clang/Se

[PATCH] D44426: Fix llvm + clang build with Intel compiler

yvvan created this revision. yvvan added reviewers: bkramer, klimek. Herald added subscribers: JDevlieghere, nhaehnle, arsenm. Herald added a reviewer: deadalnix. I've tested it on Windows with 64-bit icl These are mostly workarounds for https://software.intel.com/en-us/comment/1919743 , https:

[PATCH] D41537: Optionally add code completion results for arrow instead of dot

yvvan added a comment. Ping https://reviews.llvm.org/D41537 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D44426: Fix llvm + clang build with Intel compiler

yvvan added a comment. @nhaehnle And that's the problem. There's no build machine for intel compiler and nobody cares. And if somebody like me want to build it - there's no solution rather than searching for workarounds yourself. This patch is not that complex in the end as you see so it should

[PATCH] D47460: Treat files as volatile by default

yvvan added a comment. Memory mapping locks the file on Windows. That means that in the addressed case it locks main file which we are editing. After that happens many tools struggle to do something with this file, for example git. It's the quickest solution, probably not the best. Better one wo

[PATCH] D47460: Treat files as volatile by default

yvvan updated this revision to Diff 149249. yvvan added a comment. This is the proper fix. When we get a buffer for main file we should use the UserFilesAreVolatile flag to specify if memory mapping needs to occur or not. https://reviews.llvm.org/D47460 Files: lib/Frontend/ASTUnit.cpp Inde

[PATCH] D47460: [Frontend] Honor UserFilesAreVolatile flag getting file buffer in ASTUnit

yvvan added a comment. In https://reviews.llvm.org/D47460#1118694, @ilya-biryukov wrote: > Is it plausible to add a unit-test for this? i think I can add a unit-test for it since we have the 'getBufferKind' method in MemoryBuffer. https://reviews.llvm.org/D47460 __

[PATCH] D47460: [Frontend] Honor UserFilesAreVolatile flag getting file buffer in ASTUnit

yvvan updated this revision to Diff 149683. yvvan added a comment. I could not properly test getMainBufferWithPrecompiledPreamble because it's private and requires some extra context to be called. But there's another getBufferForFile call in ASTUnit which has similar symptoms and might cause wr

[PATCH] D47460: [Frontend] Honor UserFilesAreVolatile flag getting file buffer in ASTUnit

yvvan updated this revision to Diff 149684. yvvan added a comment. fix indentation in unit-test https://reviews.llvm.org/D47460 Files: include/clang/Basic/FileManager.h lib/Basic/FileManager.cpp lib/Frontend/ASTUnit.cpp unittests/Frontend/ASTUnitTest.cpp Index: unittests/Frontend/ASTUn

[PATCH] D47460: [Frontend] Honor UserFilesAreVolatile flag getting file buffer in ASTUnit

yvvan updated this revision to Diff 149697. yvvan added a comment. Use fixture in unit-test https://reviews.llvm.org/D47460 Files: include/clang/Basic/FileManager.h lib/Basic/FileManager.cpp lib/Frontend/ASTUnit.cpp unittests/Frontend/ASTUnitTest.cpp Index: unittests/Frontend/ASTUnitTe

[PATCH] D47460: [Frontend] Honor UserFilesAreVolatile flag getting file buffer in ASTUnit

This revision was automatically updated to reflect the committed changes. Closed by commit rL334070: [Frontend] Honor UserFilesAreVolatile flag getting file buffer in ASTUnit (authored by yvvan, committed by ). Herald added a subscriber: llvm-commits. Changed prior to commit: https://reviews.ll

[PATCH] D46862: [libclang] Optionally add code completion results for arrow instead of dot

yvvan updated this revision to Diff 150291. yvvan marked 8 inline comments as done. yvvan added a comment. Address review comments https://reviews.llvm.org/D46862 Files: include/clang-c/Index.h include/clang/Sema/CodeCompleteConsumer.h test/Index/complete-arrow-dot.cpp tools/c-index-tes

[PATCH] D48116: [libclang] Allow skipping warnings from all included files

yvvan added a comment. Cool! That's actually quite a small change with big outcome! Comment at: include/clang/Basic/Diagnostic.h:216 + // Suppress warnings from all included files. + bool SuppressWarningsFromIncludedFiles = false; Probably mention that it a

  1   2   3   >