[PATCH] D126880: [clang-tidy] Add cppcoreguidelines-avoid-const-or-ref-data-members check

dfrib added inline comments. Comment at: clang-tools-extra/test/clang-tidy/checkers/cppcoreguidelines-avoid-const-or-ref-data-members.cpp:25 + +struct RefMember { + int &r; Differentiate between lvalue reference and rvalue reference members using these terms i

[PATCH] D126818: Itanium ABI: Implement mangling for constrained friends

dfrib added a comment. In D126818#3935740 , @rjmccall wrote: > I'm too often slow to actually apply edits to the ABI document. There's been > plenty of time for feedback on this one; go ahead and act like it's accepted. CWG 2596 was discussed at Kona a

[PATCH] D126818: Itanium ABI: Implement mangling for constrained friends

dfrib added a comment. In D126818#3941036 , @erichkeane wrote: > In D126818#3940898 , @dfrib wrote: > >> In D126818#3935740 , @rjmccall >> wrote: >> >>> I'm too often sl

[PATCH] D126818: Itanium ABI: Implement mangling for constrained friends

dfrib added a comment. In D126818#3941201 , @erichkeane wrote: > [...] particularly since the suggested wording says the opposite of what I > THOUGHT the discussion was doing at the end? > [...] We might find ourselves wanting to hold off until CWG come