Re: [PATCH] D37826: Refine generation of TBAA information in clang

2017-09-27 Thread Daniel Berlin via cfe-commits
(As i mentioned to hal offline, i'm too slammed to help here) On Wed, Sep 27, 2017 at 8:47 AM, Ivan A. Kosarev via Phabricator < revi...@reviews.llvm.org> wrote: > kosarev added a comment. > > Colleagues, please let me know if I can do anything else to help with > reviewing the patch. Thanks. > >

Re: [PATCH] D36836: [clang-tidy] Implement sonarsource-function-cognitive-complexity check

2017-11-21 Thread Daniel Berlin via cfe-commits
Yes, unfortnuately, i just have no time these days with my new role. Sorry. I'm trying to keep up with reviews where i can, but i'm prioritizing those that are absolutely blocked on me (and trying to hand those off). On Tue, Nov 21, 2017 at 11:11 AM, Roman Lebedev via Phabricator < revi...@revie

Re: [PATCH] D32199: [TBAASan] A TBAA Sanitizer (Clang)

2017-05-01 Thread Daniel Berlin via cfe-commits
On Fri, Apr 21, 2017 at 4:03 AM, Hal Finkel via Phabricator < revi...@reviews.llvm.org> wrote: > hfinkel added a comment. > > In https://reviews.llvm.org/D32199#732737, @rsmith wrote: > > > In https://reviews.llvm.org/D32199#732189, @hfinkel wrote: > > > > > In https://reviews.llvm.org/D32199#7314

Re: [PATCH] D32199: [TBAASan] A TBAA Sanitizer (Clang)

2017-05-01 Thread Daniel Berlin via cfe-commits
On Mon, May 1, 2017 at 12:16 PM, Hal Finkel wrote: > > On 05/01/2017 12:49 PM, Daniel Berlin wrote: > > > > On Fri, Apr 21, 2017 at 4:03 AM, Hal Finkel via Phabricator < > revi...@reviews.llvm.org> wrote: > >> hfinkel added a comment. >> >> In https://reviews.llvm.org/D32199#732737, @rsmith wrote

Re: [PATCH] D32199: [TBAASan] A TBAA Sanitizer (Clang)

2017-05-01 Thread Daniel Berlin via cfe-commits
> > >> >> > So you believe that you can index into an object randomly by pointer > arithmetic and pull out a different field? > > For starters, this is illegal because you don't know where the padding > bytes are. > You cannot assume that X.a + 1 == X.b > "Implementation alignment requirements mig

Re: [PATCH] D32199: [TBAASan] A TBAA Sanitizer (Clang)

2017-05-01 Thread Daniel Berlin via cfe-commits
On Mon, May 1, 2017 at 2:07 PM, John McCall wrote: > On Mon, May 1, 2017 at 3:31 PM, Daniel Berlin wrote: > >> So you believe that you can index into an object randomly by pointer arithmetic and pull out a different field? >>> >>> For starters, this is illegal because you don't know w

Re: [PATCH] D32199: [TBAASan] A TBAA Sanitizer (Clang)

2017-05-01 Thread Daniel Berlin via cfe-commits
On Mon, May 1, 2017 at 3:09 PM, Daniel Berlin wrote: > > > On Mon, May 1, 2017 at 2:07 PM, John McCall wrote: > >> On Mon, May 1, 2017 at 3:31 PM, Daniel Berlin >> wrote: >> >>> So you believe that you can index into an object randomly by pointer > arithmetic and pull out a different field?

Re: [PATCH] D32199: [TBAASan] A TBAA Sanitizer (Clang)

2017-05-01 Thread Daniel Berlin via cfe-commits
On Mon, May 1, 2017 at 3:58 PM, John McCall wrote: > On Mon, May 1, 2017 at 6:40 PM, Daniel Berlin wrote: > >> On Mon, May 1, 2017 at 3:09 PM, Daniel Berlin >> wrote: >> >>> On Mon, May 1, 2017 at 2:07 PM, John McCall wrote: >>> On Mon, May 1, 2017 at 3:31 PM, Daniel Berlin wrote: >

Re: [PATCH] D13446: [PATCH] Add checker discouraging definition of variadic function definitions in C++

2015-10-09 Thread Daniel Berlin via cfe-commits
dberlin added a subscriber: dberlin. Comment at: docs/clang-tidy/checks/cert-variadic-function-def.rst:13 @@ +12,2 @@ +`DCL50-CPP. Do not define a C-style variadic function +

Re: [PATCH] D13446: [PATCH] Add checker discouraging definition of variadic function definitions in C++

2015-11-03 Thread Daniel Berlin via cfe-commits
Apologies, I will try to take a look today On Tue, Nov 3, 2015, 10:05 AM Aaron Ballman wrote: > On Tue, Nov 3, 2015 at 7:19 AM, Alexander Kornienko > wrote: > > On Fri, Oct 9, 2015 at 12:13 PM, Aaron Ballman > > wrote: > >> > >> On Fri, Oct 9, 2015 at 3:09 PM, Daniel Berlin > wrote: > >> > db

Re: [PATCH] D22463: [RFC] Moving to GitHub Proposal: NOT DECISION!

2016-07-25 Thread Daniel Berlin via cfe-commits
On Mon, Jul 25, 2016 at 1:03 PM, Vlad Dovlekaev via llvm-commits < llvm-comm...@lists.llvm.org> wrote: > vladisld added a comment. > > In https://reviews.llvm.org/D22463#494828, @jlebar wrote: > > > I think the general feeling is that most of us (myself included) would > rather not learn a new too

Re: [PATCH] D15087: [PATCH] Add CERT license clarification

2015-12-08 Thread Daniel Berlin via cfe-commits
dberlin added a comment. The license looks fine to me http://reviews.llvm.org/D15087 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits