alexfh added a comment.
Some initial comments, mostly style-related. It takes some time to get used to
the coding style used in LLVM/Clang. One notable thing: though we use `auto`
sometimes, we don't use the almost-always-auto style. Please see the inline
comments for specific cases.
alexfh added inline comments.
Comment at: clang-tidy/readability/IdentifierNamingCheck.cpp:87
@@ +86,3 @@
+ auto const fromString = [](StringRef Str) {
+if (Str.equals("any") || Str.equals("aNy_CasE"))
+ return AnyCase;
berenm wrote:
> alexfh wrote:
> >
Author: alexfh
Date: Fri Aug 10 06:59:33 2018
New Revision: 339433
URL: http://llvm.org/viewvc/llvm-project?rev=339433&view=rev
Log:
[clang-tidy: modernize] modernize-redundant-void-arg crashes when a function
body is in a macro
Fixes https://bugs.llvm.org/show_bug.cgi?id=28406
Patch by IdrissR
Author: alexfh
Date: Wed May 9 05:27:21 2018
New Revision: 331870
URL: http://llvm.org/viewvc/llvm-project?rev=331870&view=rev
Log:
Fixes issue introduced by r331556.
Closes bug: https://bugs.llvm.org/show_bug.cgi?id=37357
Patch by Rafael Stahl!
Differential revision: https://reviews.llvm.org/
Author: alexfh
Date: Thu May 17 07:04:27 2018
New Revision: 332609
URL: http://llvm.org/viewvc/llvm-project?rev=332609&view=rev
Log:
[clang-tidy] Add a flag to enable alpha checkers
Summary: The alpha checkers can already be enabled using the clang driver, this
allows them to be enabled using th
Author: alexfh
Date: Wed Oct 4 03:24:36 2017
New Revision: 314895
URL: http://llvm.org/viewvc/llvm-project?rev=314895&view=rev
Log:
Fix assertion failure in thread safety analysis (PR34800).
Summary:
Fix an assertion failure (http://llvm.org/PR34800) and clean up unused code
relevant to the fix
On 6 Oct 2017 14:59, "Aaron Ballman via cfe-commits" <
cfe-commits@lists.llvm.org> wrote:
Author: aaronballman
Date: Fri Oct 6 05:57:28 2017
New Revision: 315057
URL: http://llvm.org/viewvc/llvm-project?rev=315057&view=rev
Log:
Fix nested namespaces in google-readability-nested-namespace-comment
This revision might be the cause of
https://bugs.llvm.org/show_bug.cgi?id=34869. I'm still working on a reduced
test case.
On Sat, Sep 30, 2017 at 2:03 AM, George Karpenkov via cfe-commits <
cfe-commits@lists.llvm.org> wrote:
> Author: george.karpenkov
> Date: Fri Sep 29 17:03:22 2017
> New Revis
ation()
@ 0x1032a43160
clang::tooling::ToolInvocation::runInvocation()
@ 0x1031306 1840 clang::tooling::ToolInvocation::run()
@ 0x1033c30 1664 clang::tooling::ClangTool::run()
On Sat, Oct 7, 2017 at 12:56 PM, Alexander Kornienko
wrote:
> This
On Fri, Oct 6, 2017 at 3:27 PM, Aaron Ballman via cfe-commits <
cfe-commits@lists.llvm.org> wrote:
> Author: aaronballman
> Date: Fri Oct 6 06:27:59 2017
> New Revision: 315060
>
> URL: http://llvm.org/viewvc/llvm-project?rev=315060&view=rev
> Log:
> Renaming a test to start with the name of the
Author: alexfh
Date: Thu Oct 12 03:41:22 2017
New Revision: 315574
URL: http://llvm.org/viewvc/llvm-project?rev=315574&view=rev
Log:
Fix the google-readability-namespace-comments-cxx17 test after r315060.
Restore the file extension. Make the namespace longer than the
ShortNamespaceLines so that t
spaceLines option value, so the check didn't trigger. Fixed
in r315574 (but would be nice, if this kind of stuff was detected before
commit).
However, this is not the end of problems with this check. It started
causing assertion failures on some of our code after the recent changes
(r315
On Fri, Oct 6, 2017 at 2:57 PM, Aaron Ballman via cfe-commits <
cfe-commits@lists.llvm.org> wrote:
> Author: aaronballman
> Date: Fri Oct 6 05:57:28 2017
> New Revision: 315057
>
> URL: http://llvm.org/viewvc/llvm-project?rev=315057&view=rev
> Log:
> Fix nested namespaces in google-readability-ne
Author: alexfh
Date: Thu Oct 12 07:25:16 2017
New Revision: 315580
URL: http://llvm.org/viewvc/llvm-project?rev=315580&view=rev
Log:
Revert "Fix nested namespaces in google-readability-nested-namespace-comments."
This reverts r315057. The revision introduces assertion failures:
assertion failed a
Reverted in r315580.
On Thu, Oct 12, 2017 at 4:03 PM, Aaron Ballman
wrote:
> On Thu, Oct 12, 2017 at 10:01 AM, Alexander Kornienko
> wrote:
> >
> > On Fri, Oct 6, 2017 at 2:57 PM, Aaron Ballman via cfe-commits
> > wrote:
> >>
> >> Author: aaronb
Author: alexfh
Date: Fri Oct 13 07:11:14 2017
New Revision: 315682
URL: http://llvm.org/viewvc/llvm-project?rev=315682&view=rev
Log:
[clang-tidy] Add a regression test for google-readability-namespace-comments
Add a regression test for the google-readability-namespace-comments bug
introduced in r
On Sat, Oct 14, 2017 at 5:59 PM, Benjamin Kramer via cfe-commits <
cfe-commits@lists.llvm.org> wrote:
> Author: d0k
> Date: Sat Oct 14 08:59:34 2017
> New Revision: 315811
>
> URL: http://llvm.org/viewvc/llvm-project?rev=315811&view=rev
> Log:
> Re-land r315787, "[Sema] Warn about unused variables
able to come up with a test case that triggers
> the assert though :(
>
> On Thu, Oct 19, 2017 at 5:45 PM, Alexander Kornienko
> wrote:
> >
> >
> > On Sat, Oct 14, 2017 at 5:59 PM, Benjamin Kramer via cfe-commits
> > wrote:
> >>
> >> Author: d0k
&
ose track; "pinging" is normal (see
> http://llvm.org/docs/DeveloperPolicy.html#code-reviews). And sometimes
> it's helpful to CC reviewers in the area; adding Alexander Kornienko.
>
> -Eli
>
>
> On 10/17/2017 12:03 PM, Antoni Boucher wrote:
>
>> Sin
Thanks! This should be enough for the tools, however I would also remove
all other spaces inside the argument comments for consistency with the rest
of LLVM code. Currently different ways of putting spaces inside the
argument comments are used in LLVM as follows:
1. /*Name=*/ - in 78 files (this
Let's not forget to regenerate LibASTMatchersReference.html (see
clang/docs/tools/dump_ast_matchers.py).
On Mon, Jul 23, 2018 at 5:59 PM Jonas Toth via cfe-commits <
cfe-commits@lists.llvm.org> wrote:
> Author: jonastoth
> Date: Mon Jul 23 08:59:27 2018
> New Revision: 337703
>
> URL: http://llvm
Author: alexfh
Date: Thu Jul 26 06:13:54 2018
New Revision: 338025
URL: http://llvm.org/viewvc/llvm-project?rev=338025&view=rev
Log:
[clang-tidy] Fix llvm.org/PR38315 (support type aliases in
modernize-shrink-to-fit)
Modified:
clang-tools-extra/trunk/clang-tidy/modernize/ShrinkToFitCheck.cpp
On Mon, Jul 30, 2018 at 5:44 PM Reka Kovacs via cfe-commits <
cfe-commits@lists.llvm.org> wrote:
> Author: rkovacs
> Date: Mon Jul 30 08:43:45 2018
> New Revision: 338259
>
> URL: http://llvm.org/viewvc/llvm-project?rev=338259&view=rev
> Log:
> [analyzer] Add support for more invalidating function
On Fri, Aug 3, 2018 at 12:20 AM Reka Kovacs via cfe-commits <
cfe-commits@lists.llvm.org> wrote:
> Author: rkovacs
> Date: Thu Aug 2 15:19:57 2018
> New Revision: 338775
>
> URL: http://llvm.org/viewvc/llvm-project?rev=338775&view=rev
> Log:
> [analyzer] Add a safety check to InnerPointerChecker.
k for the
> CXXRecordDecl. I hope that fixes the crashes.
>
> Alexander Kornienko ezt írta (időpont: 2018. aug. 2.,
> Cs, 11:07):
>
>>
>>
>> On Mon, Jul 30, 2018 at 5:44 PM Reka Kovacs via cfe-commits <
>> cfe-commits@lists.llvm.org> wrote:
>>
&g
On Thu, Aug 2, 2018 at 4:03 AM George Karpenkov via cfe-commits <
cfe-commits@lists.llvm.org> wrote:
> Author: george.karpenkov
> Date: Wed Aug 1 19:02:40 2018
> New Revision: 338667
>
> URL: http://llvm.org/viewvc/llvm-project?rev=338667&view=rev
> Log:
> [analyzer] Extend NoStoreFuncVisitor to
On 25 May 2017 19:22, "Eugene Zelenko via cfe-commits" <
cfe-commits@lists.llvm.org> wrote:
Author: eugenezelenko
Date: Thu May 25 12:22:29 2017
New Revision: 303884
URL: http://llvm.org/viewvc/llvm-project?rev=303884&view=rev
Log:
[Documentation] Mention hicpp check group in Clang-tidy main docu
Author: alexfh
Date: Mon May 29 08:59:27 2017
New Revision: 304154
URL: http://llvm.org/viewvc/llvm-project?rev=304154&view=rev
Log:
[clang-tidy] Use getLocalOrGlobal for the StrictMode option
Modified:
clang-tools-extra/trunk/clang-tidy/misc/SuspiciousEnumUsageCheck.cpp
clang-tools-extr
Author: alexfh
Date: Wed May 31 09:35:50 2017
New Revision: 304302
URL: http://llvm.org/viewvc/llvm-project?rev=304302&view=rev
Log:
Enable the ARM Neon intrinsics test by default.
The test being marked 'REQUIRES: long-tests' doesn't make sense. It's not the
first time the test is broken without
Author: alexfh
Date: Thu Jun 1 06:41:21 2017
New Revision: 304408
URL: http://llvm.org/viewvc/llvm-project?rev=304408&view=rev
Log:
Make the clang-cl test less restrictive.
Make the test less restrictive to allow directory layout used in our test setup.
Modified:
cfe/trunk/test/Driver/cl-in
Author: alexfh
Date: Fri Jun 2 12:36:32 2017
New Revision: 304570
URL: http://llvm.org/viewvc/llvm-project?rev=304570&view=rev
Log:
[clang-tidy] check for __func__/__FUNCTION__ in lambdas
Add a clang-tidy check for using func__/FUNCTION__ inside lambdas. This
evaluates to the string operator(),
Author: alexfh
Date: Fri Jun 2 13:44:32 2017
New Revision: 304581
URL: http://llvm.org/viewvc/llvm-project?rev=304581&view=rev
Log:
Fix formatting in docs.
Modified:
clang-tools-extra/trunk/docs/ReleaseNotes.rst
Modified: clang-tools-extra/trunk/docs/ReleaseNotes.rst
URL:
http://llvm.org/v
Author: alexfh
Date: Fri Jun 2 13:47:50 2017
New Revision: 304583
URL: http://llvm.org/viewvc/llvm-project?rev=304583&view=rev
Log:
[clang-tidy] Add `const` to operator() to fix a warning.
Modified:
clang-tools-extra/trunk/clang-tidy/misc/LambdaFunctionNameCheck.h
Modified: clang-tools-extr
gt; On Fri, Jun 2, 2017 at 11:48 AM Alexander Kornienko via cfe-commits <
> cfe-commits@lists.llvm.org> wrote:
>
>> Author: alexfh
>> Date: Fri Jun 2 13:47:50 2017
>> New Revision: 304583
>>
>> URL: http://llvm.org/viewvc/llvm-project?rev=304583&view
Author: alexfh
Date: Tue Jun 6 12:49:45 2017
New Revision: 304811
URL: http://llvm.org/viewvc/llvm-project?rev=304811&view=rev
Log:
[clang-tidy] misc-inaccurate-erase: support call by pointer
+ replace matchesName calls with more efficient alternatives.
Modified:
clang-tools-extra/trunk/cla
Author: alexfh
Date: Wed Jun 7 03:25:51 2017
New Revision: 304879
URL: http://llvm.org/viewvc/llvm-project?rev=304879&view=rev
Log:
[clang-tidy] Make misc-inaccurate-erase work with real C++11 containers.
The check failed to match iterator->const_iterator conversion that is happening
at least wh
Author: alexfh
Date: Thu Jun 8 09:04:16 2017
New Revision: 304977
URL: http://llvm.org/viewvc/llvm-project?rev=304977&view=rev
Log:
[clang-tidy] New checker to replace dynamic exception specifications
Summary:
New checker to replace dynamic exception
specifications
This is an alternative to D18
x86_
> 64-scei-ps4-windows10pro-fast
>
> Please have a look at this?
>
> Thanks
>
> Galina
>
> On Thu, Jun 8, 2017 at 7:04 AM, Alexander Kornienko via cfe-commits <
> cfe-commits@lists.llvm.org> wrote:
>
>> Author: alexfh
>> Date: Thu Jun 8 09:04:16
Author: alexfh
Date: Thu Jun 8 17:25:23 2017
New Revision: 305024
URL: http://llvm.org/viewvc/llvm-project?rev=305024&view=rev
Log:
[clang-tidy] Use -fexceptions explicitly in the tests that need exceptions.
This should fix relevant buildbot breakages.
Modified:
clang-tools-extra/trunk/test
Author: alexfh
Date: Fri Jun 9 02:34:58 2017
New Revision: 305057
URL: http://llvm.org/viewvc/llvm-project?rev=305057&view=rev
Log:
Revert "[clang-tidy] When" -fno-exceptions is used", this warning is better to
be suppressed."
This reverts commit r304949.
https://reviews.llvm.org/D34002#775830
Fixes committed in r305024 and r305057.
On Fri, Jun 9, 2017 at 12:07 AM, Alexander Kornienko
wrote:
> It looks like the buildbots have exceptions turned off by default, so the
> tests need to use `-fexceptions` explicitly. Testing a fix...
>
> On Thu, Jun 8, 2017 at 11:26 PM, Gali
There was a recent bug report related to this check. Could you take a look?
http://llvm.org/PR35803
On Fri, Dec 22, 2017 at 5:52 PM, Julie Hockett via cfe-commits <
cfe-commits@lists.llvm.org> wrote:
> Author: juliehockett
> Date: Fri Dec 22 08:52:25 2017
> New Revision: 321363
>
> URL: http://ll
Yes, would be nice to include this into 6.0.
On Wed, Jan 3, 2018 at 11:16 PM, Aaron Ballman
wrote:
> Hans, I'd like to nominate this patch for the 6.0 branch. It fixes a
> failing assertion with new functionality; without this fix, anyone
> enabling this check and including a STL header that tra
Author: alexfh
Date: Tue Jan 9 07:05:13 2018
New Revision: 322082
URL: http://llvm.org/viewvc/llvm-project?rev=322082&view=rev
Log:
Explicitly specify output file.
Otherwise the test fails when LLVM sources are on a read-only partition.
Modified:
cfe/trunk/test/CodeGen/x86-cf-protection.c
Author: alexfh
Date: Thu Jan 11 05:00:28 2018
New Revision: 322274
URL: http://llvm.org/viewvc/llvm-project?rev=322274&view=rev
Log:
[clang-tidy] Fix google-readability-namespace-comments handling of C++17 nested
namespaces
Summary:
Fixes bug 34701
When we encounter a namespace find the locatio
Author: alexfh
Date: Wed Feb 28 02:30:25 2018
New Revision: 326314
URL: http://llvm.org/viewvc/llvm-project?rev=326314&view=rev
Log:
[clang-tidy] Add a test for readability-implicit-bool-conversion with bitfields.
Modified:
clang-tools-extra/trunk/test/clang-tidy/readability-implicit-bool-co
Author: alexfh
Date: Wed Feb 28 04:21:38 2018
New Revision: 326321
URL: http://llvm.org/viewvc/llvm-project?rev=326321&view=rev
Log:
[clang-tidy] Fix 'add_new_check.py --udpate-docs'
Modified:
clang-tools-extra/trunk/clang-tidy/add_new_check.py
Modified: clang-tools-extra/trunk/clang-tidy/ad
Author: alexfh
Date: Wed Feb 28 06:47:20 2018
New Revision: 326327
URL: http://llvm.org/viewvc/llvm-project?rev=326327&view=rev
Log:
Rename a few checks from misc- to bugprone-.
Summary:
rename_check.py {misc,bugprone}-forwarding-reference-overload
rename_check.py {misc,bugprone}-macro-repeated-s
Author: alexfh
Date: Wed Feb 28 15:30:29 2018
New Revision: 326384
URL: http://llvm.org/viewvc/llvm-project?rev=326384&view=rev
Log:
Rename more checks from misc- to bugprone-.
Summary:
clang-tidy/rename_check.py {misc,bugprone}-string-integer-assignment
clang-tidy/rename_check.py {misc,bugprone}
Author: alexfh
Date: Wed Feb 28 15:47:15 2018
New Revision: 326386
URL: http://llvm.org/viewvc/llvm-project?rev=326386&view=rev
Log:
[clang-tidy] Another batch of checks to rename from misc- to bugprone-.
Summary:
clang-tidy/rename_check.py {misc,bugprone}-suspicious-semicolon
clang-tidy/rename_c
On Mon, Mar 5, 2018 at 11:05 PM George Karpenkov via cfe-commits <
cfe-commits@lists.llvm.org> wrote:
> Author: george.karpenkov
> Date: Mon Mar 5 14:03:32 2018
> New Revision: 326746
>
> URL: http://llvm.org/viewvc/llvm-project?rev=326746&view=rev
> Log:
> [analyzer] AST-matching checker to dete
Author: alexfh
Date: Tue Mar 6 02:40:11 2018
New Revision: 326772
URL: http://llvm.org/viewvc/llvm-project?rev=326772&view=rev
Log:
Move test/gcdasyncsemaphorechecker_test.m to a subdirectory
Added:
cfe/trunk/test/Analysis/gcdasyncsemaphorechecker_test.m
- copied, changed from r326767,
On Tue, Mar 6, 2018 at 11:03 AM Alexander Kornienko
wrote:
> On Mon, Mar 5, 2018 at 11:05 PM George Karpenkov via cfe-commits <
> cfe-commits@lists.llvm.org> wrote:
>
>> Author: george.karpenkov
>> Date: Mon Mar 5 14:03:32 2018
>> New Revision
Author: alexfh
Date: Thu Mar 15 01:25:39 2018
New Revision: 327606
URL: http://llvm.org/viewvc/llvm-project?rev=327606&view=rev
Log:
[clang-tidy] rename_check.py {misc,bugprone}-macro-parentheses
Added:
clang-tools-extra/trunk/clang-tidy/bugprone/MacroParenthesesCheck.cpp
- copied, chan
Author: alexfh
Date: Thu Mar 15 01:26:58 2018
New Revision: 327609
URL: http://llvm.org/viewvc/llvm-project?rev=327609&view=rev
Log:
Fixed filename in a comment. NFC
Modified:
clang-tools-extra/trunk/clang-tidy/bugprone/IncorrectRoundingsCheck.h
Modified: clang-tools-extra/trunk/clang-tidy/b
Author: alexfh
Date: Thu Mar 15 01:26:47 2018
New Revision: 327608
URL: http://llvm.org/viewvc/llvm-project?rev=327608&view=rev
Log:
[clang-tidy] rename_check.py misc-sizeof-container bugprone-sizeof-container
Added:
clang-tools-extra/trunk/clang-tidy/bugprone/SizeofContainerCheck.cpp
-
Author: alexfh
Date: Thu Mar 15 01:26:19 2018
New Revision: 327607
URL: http://llvm.org/viewvc/llvm-project?rev=327607&view=rev
Log:
[clang-tidy] rename_check.py misc-sizeof-expression bugprone-sizeof-expression
Added:
clang-tools-extra/trunk/clang-tidy/bugprone/SizeofExpressionCheck.cpp
Author: alexfh
Date: Thu Mar 15 01:27:42 2018
New Revision: 327610
URL: http://llvm.org/viewvc/llvm-project?rev=327610&view=rev
Log:
[clang-tidy] rename_check.py misc-unused-raii bugprone-unused-raii
--check_class_name=UnusedRAIICheck
Added:
clang-tools-extra/trunk/clang-tidy/bugprone/Unused
Author: alexfh
Date: Mon Mar 19 06:02:32 2018
New Revision: 327833
URL: http://llvm.org/viewvc/llvm-project?rev=327833&view=rev
Log:
[clang-tidy] New check bugprone-unused-return-value
Summary:
Detects function calls where the return value is unused.
Checked functions can be configured.
Reviewe
Author: alexfh
Date: Mon Jun 11 05:46:48 2018
New Revision: 334400
URL: http://llvm.org/viewvc/llvm-project?rev=334400&view=rev
Log:
Add support for arrays in performance-implicit-conversion-in-loop
Summary:
Add support for arrays (and structure that use naked pointers for their
iterator, like s
This commit seems to have introduced
https://bugs.llvm.org/show_bug.cgi?id=37769. Could you take a look?
On Fri, Apr 20, 2018 at 1:33 AM Artem Dergachev via cfe-commits <
cfe-commits@lists.llvm.org> wrote:
> Author: dergachev
> Date: Thu Apr 19 16:30:15 2018
> New Revision: 330382
>
> URL: http:/
Author: alexfh
Date: Thu Jun 21 09:14:27 2018
New Revision: 335252
URL: http://llvm.org/viewvc/llvm-project?rev=335252&view=rev
Log:
[clang-tidy] Remove the google-readability-redundant-smartptr-get alias
I don't remember why I added it, but it's definitely not needed, since the check
doesn't hav
Author: alexfh
Date: Tue Oct 9 08:58:18 2018
New Revision: 344058
URL: http://llvm.org/viewvc/llvm-project?rev=344058&view=rev
Log:
[clang-tidy] Fix handling of parens around new expressions in make_
checks.
Summary:
Extra parentheses around a new expression result in incorrect code
after apply
Author: alexfh
Date: Tue Oct 23 09:48:16 2018
New Revision: 345049
URL: http://llvm.org/viewvc/llvm-project?rev=345049&view=rev
Log:
[clang-tidy] Add a separate section for NOLINT(NEXTLINE)? doc.
Modified:
clang-tools-extra/trunk/docs/clang-tidy/index.rst
Modified: clang-tools-extra/trunk/do
Author: alexfh
Date: Tue Jan 15 07:34:26 2019
New Revision: 351196
URL: http://llvm.org/viewvc/llvm-project?rev=351196&view=rev
Log:
Reduce ASTMatchers stack footprint. Addresses http://llvm.org/PR38851
The BoundNodesTreeBuilder class is used both directly and indirectly as a local
variable in ma
Author: alexfh
Date: Mon Jan 21 08:26:54 2019
New Revision: 351751
URL: http://llvm.org/viewvc/llvm-project?rev=351751&view=rev
Log:
[clang-tidy] Work around http://llvm.org/PR40392
The readability-else-after-return check should be smarter about cases where the
variable defined in the condition i
Author: alexfh
Date: Tue Jan 22 04:59:34 2019
New Revision: 351814
URL: http://llvm.org/viewvc/llvm-project?rev=351814&view=rev
Log:
[clang-tidy] Fix whitespace in docs. NFC
Actually, just testing commits via monorepo ;)
Modified:
clang-tools-extra/trunk/docs/clang-tidy/index.rst
Modified:
Author: alexfh
Date: Fri Nov 2 08:03:43 2018
New Revision: 345979
URL: http://llvm.org/viewvc/llvm-project?rev=345979&view=rev
Log:
[clang-tidy] .reset(new X) -> make_unique() in a comment. NFC
Modified:
clang-tools-extra/trunk/clang-tidy/utils/IncludeInserter.h
Modified: clang-tools-extra/
Author: alexfh
Date: Fri Nov 2 08:29:37 2018
New Revision: 345984
URL: http://llvm.org/viewvc/llvm-project?rev=345984&view=rev
Log:
[clang-tidy] Fixed code sample in a comment. NFC
Modified:
clang-tools-extra/trunk/clang-tidy/utils/IncludeInserter.h
Modified: clang-tools-extra/trunk/clang-t
Author: alexfh
Date: Fri Nov 16 06:57:51 2018
New Revision: 347053
URL: http://llvm.org/viewvc/llvm-project?rev=347053&view=rev
Log:
[clang-tidy] Expanded a test NFC
Expanded the readability-inconsistent-declaration-parameter-name-macros.cpp to
check notes and added a test with pasted tokens.
Mo
Author: alexfh
Date: Tue Nov 20 17:06:32 2018
New Revision: 347371
URL: http://llvm.org/viewvc/llvm-project?rev=347371&view=rev
Log:
Implement YAML serialization of notes in clang::tooling::Diagnostic.
Modified:
cfe/trunk/include/clang/Tooling/DiagnosticsYaml.h
cfe/trunk/unittests/Tooling
Author: alexfh
Date: Tue Nov 20 17:08:46 2018
New Revision: 347372
URL: http://llvm.org/viewvc/llvm-project?rev=347372&view=rev
Log:
clang::tooling::Diagnostic: Don't store offset in the scratch space.
These offsets are useless (and even harmful in certain cases) in exported
diagnostics. The test
Author: alexfh
Date: Tue Nov 20 17:11:18 2018
New Revision: 347373
URL: http://llvm.org/viewvc/llvm-project?rev=347373&view=rev
Log:
[clang-tidy] Add a test for proper handling of locations in scratch space.
This test examines the behavior change of clang::tooling::Diagnostic in r347372.
Added:
Author: alexfh
Date: Thu Nov 22 08:10:18 2018
New Revision: 347470
URL: http://llvm.org/viewvc/llvm-project?rev=347470&view=rev
Log:
[clang-tidy] Ignore template instantiations in modernize-use-using
The test I'm adding passes without the change due to the deduplication logic in
ClangTidyDiagnost
Author: alexfh
Date: Fri Nov 23 06:30:14 2018
New Revision: 347495
URL: http://llvm.org/viewvc/llvm-project?rev=347495&view=rev
Log:
[clang-tidy] Ignore matches in template instantiations (cert-dcl21-cpp)
The test fails with a local modification to
clang-tidy/ClangTidyDiagnosticConsumer.cpp to in
Author: alexfh
Date: Sat Nov 24 18:41:01 2018
New Revision: 347520
URL: http://llvm.org/viewvc/llvm-project?rev=347520&view=rev
Log:
A bit of AST matcher cleanup, NFC.
Removed the uses of the allOf() matcher inside node matchers that are implicit
allOf(). Replaced uses of allOf() with the explici
On Sun, Nov 25, 2018 at 1:52 PM Aaron Ballman
wrote:
> On Sat, Nov 24, 2018 at 9:43 PM Alexander Kornienko via cfe-commits
> wrote:
> >
> > Author: alexfh
> > Date: Sat Nov 24 18:41:01 2018
> > New Revision: 347520
> >
> > URL: http://llvm.org/viewv
Author: alexfh
Date: Mon Nov 26 03:11:52 2018
New Revision: 347546
URL: http://llvm.org/viewvc/llvm-project?rev=347546&view=rev
Log:
[clang-tidy] PrintStackTraceOnErrorSignal
Modified:
clang-tools-extra/trunk/clang-tidy/tool/ClangTidyMain.cpp
Modified: clang-tools-extra/trunk/clang-tidy/tool
Author: alexfh
Date: Tue Nov 27 02:53:44 2018
New Revision: 347652
URL: http://llvm.org/viewvc/llvm-project?rev=347652&view=rev
Log:
[clang-tidy] Avoid inconsistent notes in readability-container-size-empty
When a warning is issued in a template instantiation, the check would previously
use templ
Author: alexfh
Date: Tue Nov 27 02:53:38 2018
New Revision: 347651
URL: http://llvm.org/viewvc/llvm-project?rev=347651&view=rev
Log:
[clang-tidy] Minor fixes in a test
Use CHECK-FIXES where it was intended instead of CHECK-MESSAGES. Fixed compiler
warnings to pacify YouCompleteMe.
Modified:
then never initialized before being used. The build recovered after the
> revert landed in
> http://lab.llvm.org:8011/builders/sanitizer-x86_64-linux-fast/builds/29894
>
> On Mon, Feb 25, 2019 at 8:07 AM Alexander Kornienko via cfe-commits <
> cfe-commits@lists.llvm.org> wro
Author: alexfh
Date: Mon Feb 25 14:22:09 2019
New Revision: 354827
URL: http://llvm.org/viewvc/llvm-project?rev=354827&view=rev
Log:
Reapply "Make static counters in ASTContext non-static." with fixes.
This reverts commit e50038e4dc53caee1acc811362ac0b15e00ef5eb.
Modified:
cfe/trunk/include/
Done. r354827 should be better.
On Mon, Feb 25, 2019 at 11:18 PM Alexander Kornienko
wrote:
> Thank you for taking care of this! That's a bug indeed. Will recommit with
> a fix.
>
> On Mon, Feb 25, 2019 at 9:25 PM Vlad Tsyrklevich
> wrote:
>
>> I've rever
Author: alexfh
Date: Tue Mar 5 06:09:57 2019
New Revision: 355401
URL: http://llvm.org/viewvc/llvm-project?rev=355401&view=rev
Log:
[clang-tidy] Fix bugprone-string-constructor crash
Modified:
clang-tools-extra/trunk/clang-tidy/bugprone/StringConstructorCheck.cpp
clang-tools-extra/trunk/
On Fri, Mar 15, 2019 at 1:21 AM Artem Dergachev via cfe-commits <
cfe-commits@lists.llvm.org> wrote:
> Author: dergachev
> Date: Thu Mar 14 17:22:59 2019
> New Revision: 356222
>
> URL: http://llvm.org/viewvc/llvm-project?rev=356222&view=rev
> Log:
> [analyzer] Support C++17 aggregates with bases
g::tooling::ToolInvocation::run()
@ 0x559906a9ef22 clang::tooling::ClangTool::run()
@ 0x559906207ecf clang::tidy::runClangTidy()
@ 0x559902d47c45 main
On Tue, Mar 19, 2019 at 1:14 AM Alexander Kornienko
wrote:
> On Fri, Mar 15, 2019 at 1:21 AM Artem Dergachev via cfe-commits <
Filed this as https://bugs.llvm.org/show_bug.cgi?id=41142. Any hope for a
prompt fix here?
On Tue, Mar 19, 2019 at 5:34 PM Alexander Kornienko
wrote:
> A reduced test case:
> $ cat test-RegionStoreManager__bindStruct.cc
> struct a {};
> class b : a {};
> b c() { b d{c()}; }
&
'd
> love to try to reincarnate
>
> http://green.lab.llvm.org/green/view/Experimental/job/StaticAnalyzerBenchmarks/
> with those.
>
> On 3/19/19 9:37 AM, Alexander Kornienko wrote:
> > Filed this as https://bugs.llvm.org/show_bug.cgi?id=41142. Any hope
> > for a
ctor.
>
> Indeed, thanks! And, as usual, more bugs on top of that.
> (https://reviews.llvm.org/D59573)
>
> On 3/19/19 11:00 AM, Alexander Kornienko wrote:
> > just adding -std=c++17 on existing code (LLVM, for example ;) could
> > help uncover some of the issues
>
> H
Author: alexfh
Date: Fri Mar 22 06:42:48 2019
New Revision: 356750
URL: http://llvm.org/viewvc/llvm-project?rev=356750&view=rev
Log:
[clang-tidy] Expand modular headers for PPCallbacks
Summary:
Add a way to expand modular headers for PPCallbacks. Checks can opt-in for this
expansion by overriding
Author: alexfh
Date: Fri Mar 22 08:07:18 2019
New Revision: 356756
URL: http://llvm.org/viewvc/llvm-project?rev=356756&view=rev
Log:
[clang-tidy] Fix a compiler warning.
Rename the Preprocessor field to fix the
declaration of ‘std::unique_ptr
clang::tooling::ExpandModularHeadersPPCallbacks::P
Author: alexfh
Date: Fri Mar 22 11:16:51 2019
New Revision: 356788
URL: http://llvm.org/viewvc/llvm-project?rev=356788&view=rev
Log:
[clangd] Call the new ClangTidyCheck::registerPPCallbacks overload
Modified:
clang-tools-extra/trunk/clangd/ClangdUnit.cpp
Modified: clang-tools-extra/trunk/cl
Author: alexfh
Date: Fri Mar 22 11:37:45 2019
New Revision: 356792
URL: http://llvm.org/viewvc/llvm-project?rev=356792&view=rev
Log:
[clang-tidy] anyOf(hasName(..), hasName(..)) -> hasAnyName
+ a minor style fix
Modified:
clang-tools-extra/trunk/clang-tidy/cert/SetLongJmpCheck.cpp
clang-
Author: alexfh
Date: Fri Mar 22 11:52:10 2019
New Revision: 356795
URL: http://llvm.org/viewvc/llvm-project?rev=356795&view=rev
Log:
Fix clang-move test.
Modified:
clang-tools-extra/trunk/unittests/clang-move/ClangMoveTests.cpp
Modified: clang-tools-extra/trunk/unittests/clang-move/ClangMove
Author: alexfh
Date: Fri Mar 22 11:58:12 2019
New Revision: 356796
URL: http://llvm.org/viewvc/llvm-project?rev=356796&view=rev
Log:
[clang-tidy] Move all checks to the new registerPPCallbacks API
Modified:
clang-tools-extra/trunk/clang-tidy/abseil/StringFindStartswithCheck.cpp
clang-tool
Author: alexfh
Date: Mon Mar 25 05:36:30 2019
New Revision: 356890
URL: http://llvm.org/viewvc/llvm-project?rev=356890&view=rev
Log:
[clang-tidy] Separate the check-facing interface
Summary:
Move ClangTidyCheck to a separate header/.cpp
Switch checks to #include "ClangTidyCheck.h"
Mention ClangTi
Author: alexfh
Date: Mon Mar 25 07:46:51 2019
New Revision: 356902
URL: http://llvm.org/viewvc/llvm-project?rev=356902&view=rev
Log:
[clang-tidy] ClangTidy.h -> ClangTidyCheck.h
Modified:
clang-tools-extra/trunk/clang-tidy/add_new_check.py
Modified: clang-tools-extra/trunk/clang-tidy/add_new
Author: alexfh
Date: Fri Mar 29 13:55:29 2019
New Revision: 357312
URL: http://llvm.org/viewvc/llvm-project?rev=357312&view=rev
Log:
[clang-tidy] Fix PR28406
Fix the crash resulting from a careless use of getLocWithOffset. At the
beginning of a macro expansion it produces an invalid SourceLocatio
On Tue, Apr 2, 2019 at 10:53 AM Mikael Holmén via Phabricator <
revi...@reviews.llvm.org> wrote:
> uabelho added a comment.
>
> Hi,
>
> I noticed that with this commit I get a whole bunch (~40) of warnings like
> the below when compiling with gcc 7.4:
>
> [10/16] Building CXX object
> tools/clan
Author: alexfh
Date: Tue Apr 2 04:31:56 2019
New Revision: 357468
URL: http://llvm.org/viewvc/llvm-project?rev=357468&view=rev
Log:
[clang-tidy] make getLangOpts return a const ref
Modified:
clang-tools-extra/trunk/clang-tidy/ClangTidyCheck.h
Modified: clang-tools-extra/trunk/clang-tidy/Cla
1 - 100 of 2996 matches
Mail list logo
