Author: alexfh
Date: Thu Mar 15 01:26:19 2018
New Revision: 327607
URL: http://llvm.org/viewvc/llvm-project?rev=327607&view=rev
Log:
[clang-tidy] rename_check.py misc-sizeof-expression bugprone-sizeof-expression
Added:
clang-tools-extra/trunk/clang-tidy/bugprone/SizeofExpressionCheck.cpp
- copied, changed from r327606,
clang-tools-extra/trunk/clang-tidy/misc/SizeofExpressionCheck.cpp
clang-tools-extra/trunk/clang-tidy/bugprone/SizeofExpressionCheck.h
- copied, changed from r327606,
clang-tools-extra/trunk/clang-tidy/misc/SizeofExpressionCheck.h
clang-tools-extra/trunk/docs/clang-tidy/checks/bugprone-sizeof-expression.rst
- copied, changed from r327606,
clang-tools-extra/trunk/docs/clang-tidy/checks/misc-sizeof-expression.rst
clang-tools-extra/trunk/test/clang-tidy/bugprone-sizeof-expression.cpp
- copied, changed from r327606,
clang-tools-extra/trunk/test/clang-tidy/misc-sizeof-expression.cpp
Removed:
clang-tools-extra/trunk/clang-tidy/misc/SizeofExpressionCheck.cpp
clang-tools-extra/trunk/clang-tidy/misc/SizeofExpressionCheck.h
clang-tools-extra/trunk/docs/clang-tidy/checks/misc-sizeof-expression.rst
clang-tools-extra/trunk/test/clang-tidy/misc-sizeof-expression.cpp
Modified:
clang-tools-extra/trunk/clang-tidy/bugprone/BugproneTidyModule.cpp
clang-tools-extra/trunk/clang-tidy/bugprone/CMakeLists.txt
clang-tools-extra/trunk/clang-tidy/misc/CMakeLists.txt
clang-tools-extra/trunk/clang-tidy/misc/MiscTidyModule.cpp
clang-tools-extra/trunk/docs/ReleaseNotes.rst
clang-tools-extra/trunk/docs/clang-tidy/checks/list.rst
Modified: clang-tools-extra/trunk/clang-tidy/bugprone/BugproneTidyModule.cpp
URL:
http://llvm.org/viewvc/llvm-project/clang-tools-extra/trunk/clang-tidy/bugprone/BugproneTidyModule.cpp?rev=327607&r1=327606&r2=327607&view=diff
==============================================================================
--- clang-tools-extra/trunk/clang-tidy/bugprone/BugproneTidyModule.cpp
(original)
+++ clang-tools-extra/trunk/clang-tidy/bugprone/BugproneTidyModule.cpp Thu Mar
15 01:26:19 2018
@@ -28,6 +28,7 @@
#include "MisplacedWideningCastCheck.h"
#include "MoveForwardingReferenceCheck.h"
#include "MultipleStatementMacroCheck.h"
+#include "SizeofExpressionCheck.h"
#include "StringConstructorCheck.h"
#include "StringIntegerAssignmentCheck.h"
#include "StringLiteralWithEmbeddedNulCheck.h"
@@ -86,6 +87,8 @@ public:
"bugprone-move-forwarding-reference");
CheckFactories.registerCheck<MultipleStatementMacroCheck>(
"bugprone-multiple-statement-macro");
+ CheckFactories.registerCheck<SizeofExpressionCheck>(
+ "bugprone-sizeof-expression");
CheckFactories.registerCheck<StringConstructorCheck>(
"bugprone-string-constructor");
CheckFactories.registerCheck<StringIntegerAssignmentCheck>(
Modified: clang-tools-extra/trunk/clang-tidy/bugprone/CMakeLists.txt
URL:
http://llvm.org/viewvc/llvm-project/clang-tools-extra/trunk/clang-tidy/bugprone/CMakeLists.txt?rev=327607&r1=327606&r2=327607&view=diff
==============================================================================
--- clang-tools-extra/trunk/clang-tidy/bugprone/CMakeLists.txt (original)
+++ clang-tools-extra/trunk/clang-tidy/bugprone/CMakeLists.txt Thu Mar 15
01:26:19 2018
@@ -20,6 +20,7 @@ add_clang_library(clangTidyBugproneModul
MisplacedWideningCastCheck.cpp
MoveForwardingReferenceCheck.cpp
MultipleStatementMacroCheck.cpp
+ SizeofExpressionCheck.cpp
StringConstructorCheck.cpp
StringIntegerAssignmentCheck.cpp
StringLiteralWithEmbeddedNulCheck.cpp
Copied: clang-tools-extra/trunk/clang-tidy/bugprone/SizeofExpressionCheck.cpp
(from r327606,
clang-tools-extra/trunk/clang-tidy/misc/SizeofExpressionCheck.cpp)
URL:
http://llvm.org/viewvc/llvm-project/clang-tools-extra/trunk/clang-tidy/bugprone/SizeofExpressionCheck.cpp?p2=clang-tools-extra/trunk/clang-tidy/bugprone/SizeofExpressionCheck.cpp&p1=clang-tools-extra/trunk/clang-tidy/misc/SizeofExpressionCheck.cpp&r1=327606&r2=327607&rev=327607&view=diff
==============================================================================
--- clang-tools-extra/trunk/clang-tidy/misc/SizeofExpressionCheck.cpp (original)
+++ clang-tools-extra/trunk/clang-tidy/bugprone/SizeofExpressionCheck.cpp Thu
Mar 15 01:26:19 2018
@@ -16,7 +16,7 @@ using namespace clang::ast_matchers;
namespace clang {
namespace tidy {
-namespace misc {
+namespace bugprone {
namespace {
@@ -260,6 +260,6 @@ void SizeofExpressionCheck::check(const
}
}
-} // namespace misc
+} // namespace bugprone
} // namespace tidy
} // namespace clang
Copied: clang-tools-extra/trunk/clang-tidy/bugprone/SizeofExpressionCheck.h
(from r327606, clang-tools-extra/trunk/clang-tidy/misc/SizeofExpressionCheck.h)
URL:
http://llvm.org/viewvc/llvm-project/clang-tools-extra/trunk/clang-tidy/bugprone/SizeofExpressionCheck.h?p2=clang-tools-extra/trunk/clang-tidy/bugprone/SizeofExpressionCheck.h&p1=clang-tools-extra/trunk/clang-tidy/misc/SizeofExpressionCheck.h&r1=327606&r2=327607&rev=327607&view=diff
==============================================================================
--- clang-tools-extra/trunk/clang-tidy/misc/SizeofExpressionCheck.h (original)
+++ clang-tools-extra/trunk/clang-tidy/bugprone/SizeofExpressionCheck.h Thu Mar
15 01:26:19 2018
@@ -7,19 +7,19 @@
//
//===----------------------------------------------------------------------===//
-#ifndef LLVM_CLANG_TOOLS_EXTRA_CLANG_TIDY_MISC_SIZEOF_EXPRESSION_H
-#define LLVM_CLANG_TOOLS_EXTRA_CLANG_TIDY_MISC_SIZEOF_EXPRESSION_H
+#ifndef LLVM_CLANG_TOOLS_EXTRA_CLANG_TIDY_BUGPRONE_SIZEOFEXPRESSIONCHECK_H
+#define LLVM_CLANG_TOOLS_EXTRA_CLANG_TIDY_BUGPRONE_SIZEOFEXPRESSIONCHECK_H
#include "../ClangTidy.h"
namespace clang {
namespace tidy {
-namespace misc {
+namespace bugprone {
/// Find suspicious usages of sizeof expression.
///
/// For the user-facing documentation see:
-/// http://clang.llvm.org/extra/clang-tidy/checks/misc-sizeof-expression.html
+///
http://clang.llvm.org/extra/clang-tidy/checks/bugprone-sizeof-expression.html
class SizeofExpressionCheck : public ClangTidyCheck {
public:
SizeofExpressionCheck(StringRef Name, ClangTidyContext *Context);
@@ -33,8 +33,8 @@ private:
const bool WarnOnSizeOfCompareToConstant;
};
-} // namespace misc
+} // namespace bugprone
} // namespace tidy
} // namespace clang
-#endif // LLVM_CLANG_TOOLS_EXTRA_CLANG_TIDY_MISC_SIZEOF_EXPRESSION_H
+#endif // LLVM_CLANG_TOOLS_EXTRA_CLANG_TIDY_BUGPRONE_SIZEOFEXPRESSIONCHECK_H
Modified: clang-tools-extra/trunk/clang-tidy/misc/CMakeLists.txt
URL:
http://llvm.org/viewvc/llvm-project/clang-tools-extra/trunk/clang-tidy/misc/CMakeLists.txt?rev=327607&r1=327606&r2=327607&view=diff
==============================================================================
--- clang-tools-extra/trunk/clang-tidy/misc/CMakeLists.txt (original)
+++ clang-tools-extra/trunk/clang-tidy/misc/CMakeLists.txt Thu Mar 15 01:26:19
2018
@@ -9,7 +9,6 @@ add_clang_library(clangTidyMiscModule
NonCopyableObjects.cpp
RedundantExpressionCheck.cpp
SizeofContainerCheck.cpp
- SizeofExpressionCheck.cpp
StaticAssertCheck.cpp
ThrowByValueCatchByReferenceCheck.cpp
UniqueptrResetReleaseCheck.cpp
Modified: clang-tools-extra/trunk/clang-tidy/misc/MiscTidyModule.cpp
URL:
http://llvm.org/viewvc/llvm-project/clang-tools-extra/trunk/clang-tidy/misc/MiscTidyModule.cpp?rev=327607&r1=327606&r2=327607&view=diff
==============================================================================
--- clang-tools-extra/trunk/clang-tidy/misc/MiscTidyModule.cpp (original)
+++ clang-tools-extra/trunk/clang-tidy/misc/MiscTidyModule.cpp Thu Mar 15
01:26:19 2018
@@ -16,7 +16,6 @@
#include "NonCopyableObjects.h"
#include "RedundantExpressionCheck.h"
#include "SizeofContainerCheck.h"
-#include "SizeofExpressionCheck.h"
#include "StaticAssertCheck.h"
#include "ThrowByValueCatchByReferenceCheck.h"
#include "UnconventionalAssignOperatorCheck.h"
@@ -45,8 +44,6 @@ public:
CheckFactories.registerCheck<RedundantExpressionCheck>(
"misc-redundant-expression");
CheckFactories.registerCheck<SizeofContainerCheck>("misc-sizeof-container");
- CheckFactories.registerCheck<SizeofExpressionCheck>(
- "misc-sizeof-expression");
CheckFactories.registerCheck<StaticAssertCheck>("misc-static-assert");
CheckFactories.registerCheck<ThrowByValueCatchByReferenceCheck>(
"misc-throw-by-value-catch-by-reference");
Removed: clang-tools-extra/trunk/clang-tidy/misc/SizeofExpressionCheck.cpp
URL:
http://llvm.org/viewvc/llvm-project/clang-tools-extra/trunk/clang-tidy/misc/SizeofExpressionCheck.cpp?rev=327606&view=auto
==============================================================================
--- clang-tools-extra/trunk/clang-tidy/misc/SizeofExpressionCheck.cpp (original)
+++ clang-tools-extra/trunk/clang-tidy/misc/SizeofExpressionCheck.cpp (removed)
@@ -1,265 +0,0 @@
-//===--- SizeofExpressionCheck.cpp -
clang-tidy----------------------------===//
-//
-// The LLVM Compiler Infrastructure
-//
-// This file is distributed under the University of Illinois Open Source
-// License. See LICENSE.TXT for details.
-//
-//===----------------------------------------------------------------------===//
-
-#include "SizeofExpressionCheck.h"
-#include "../utils/Matchers.h"
-#include "clang/AST/ASTContext.h"
-#include "clang/ASTMatchers/ASTMatchFinder.h"
-
-using namespace clang::ast_matchers;
-
-namespace clang {
-namespace tidy {
-namespace misc {
-
-namespace {
-
-AST_MATCHER_P(IntegerLiteral, isBiggerThan, unsigned, N) {
- return Node.getValue().getZExtValue() > N;
-}
-
-AST_MATCHER_P2(Expr, hasSizeOfDescendant, int, Depth,
- ast_matchers::internal::Matcher<Expr>, InnerMatcher) {
- if (Depth < 0)
- return false;
-
- const Expr *E = Node.IgnoreParenImpCasts();
- if (InnerMatcher.matches(*E, Finder, Builder))
- return true;
-
- if (const auto *CE = dyn_cast<CastExpr>(E)) {
- const auto M = hasSizeOfDescendant(Depth - 1, InnerMatcher);
- return M.matches(*CE->getSubExpr(), Finder, Builder);
- } else if (const auto *UE = dyn_cast<UnaryOperator>(E)) {
- const auto M = hasSizeOfDescendant(Depth - 1, InnerMatcher);
- return M.matches(*UE->getSubExpr(), Finder, Builder);
- } else if (const auto *BE = dyn_cast<BinaryOperator>(E)) {
- const auto LHS = hasSizeOfDescendant(Depth - 1, InnerMatcher);
- const auto RHS = hasSizeOfDescendant(Depth - 1, InnerMatcher);
- return LHS.matches(*BE->getLHS(), Finder, Builder) ||
- RHS.matches(*BE->getRHS(), Finder, Builder);
- }
-
- return false;
-}
-
-CharUnits getSizeOfType(const ASTContext &Ctx, const Type *Ty) {
- if (!Ty || Ty->isIncompleteType() || Ty->isDependentType() ||
- isa<DependentSizedArrayType>(Ty) || !Ty->isConstantSizeType())
- return CharUnits::Zero();
- return Ctx.getTypeSizeInChars(Ty);
-}
-
-} // namespace
-
-SizeofExpressionCheck::SizeofExpressionCheck(StringRef Name,
- ClangTidyContext *Context)
- : ClangTidyCheck(Name, Context),
- WarnOnSizeOfConstant(Options.get("WarnOnSizeOfConstant", 1) != 0),
- WarnOnSizeOfThis(Options.get("WarnOnSizeOfThis", 1) != 0),
- WarnOnSizeOfCompareToConstant(
- Options.get("WarnOnSizeOfCompareToConstant", 1) != 0) {}
-
-void SizeofExpressionCheck::storeOptions(ClangTidyOptions::OptionMap &Opts) {
- Options.store(Opts, "WarnOnSizeOfConstant", WarnOnSizeOfConstant);
- Options.store(Opts, "WarnOnSizeOfThis", WarnOnSizeOfThis);
- Options.store(Opts, "WarnOnSizeOfCompareToConstant",
- WarnOnSizeOfCompareToConstant);
-}
-
-void SizeofExpressionCheck::registerMatchers(MatchFinder *Finder) {
- const auto IntegerExpr = ignoringParenImpCasts(integerLiteral());
- const auto ConstantExpr = expr(ignoringParenImpCasts(
- anyOf(integerLiteral(), unaryOperator(hasUnaryOperand(IntegerExpr)),
- binaryOperator(hasLHS(IntegerExpr), hasRHS(IntegerExpr)))));
- const auto SizeOfExpr =
- expr(anyOf(sizeOfExpr(has(type())), sizeOfExpr(has(expr()))));
- const auto SizeOfZero = expr(
- sizeOfExpr(has(ignoringParenImpCasts(expr(integerLiteral(equals(0)))))));
-
- // Detect expression like: sizeof(ARRAYLEN);
- // Note: The expression 'sizeof(sizeof(0))' is a portable trick used to know
- // the sizeof size_t.
- if (WarnOnSizeOfConstant) {
- Finder->addMatcher(
- expr(sizeOfExpr(has(ignoringParenImpCasts(ConstantExpr))),
- unless(SizeOfZero))
- .bind("sizeof-constant"),
- this);
- }
-
- // Detect expression like: sizeof(this);
- if (WarnOnSizeOfThis) {
- Finder->addMatcher(
- expr(sizeOfExpr(has(ignoringParenImpCasts(expr(cxxThisExpr())))))
- .bind("sizeof-this"),
- this);
- }
-
- // Detect sizeof(kPtr) where kPtr is 'const char* kPtr = "abc"';
- const auto CharPtrType = pointerType(pointee(isAnyCharacter()));
- const auto ConstStrLiteralDecl =
- varDecl(isDefinition(), hasType(qualType(hasCanonicalType(CharPtrType))),
- hasInitializer(ignoringParenImpCasts(stringLiteral())));
- Finder->addMatcher(expr(sizeOfExpr(has(ignoringParenImpCasts(expr(
- hasType(qualType(hasCanonicalType(CharPtrType))),
- ignoringParenImpCasts(declRefExpr(
- hasDeclaration(ConstStrLiteralDecl))))))))
- .bind("sizeof-charp"),
- this);
-
- // Detect sizeof(ptr) where ptr points to an aggregate (i.e. sizeof(&S)).
- const auto ArrayExpr = expr(ignoringParenImpCasts(
- expr(hasType(qualType(hasCanonicalType(arrayType()))))));
- const auto ArrayCastExpr = expr(anyOf(
- unaryOperator(hasUnaryOperand(ArrayExpr), unless(hasOperatorName("*"))),
- binaryOperator(hasEitherOperand(ArrayExpr)),
- castExpr(hasSourceExpression(ArrayExpr))));
- const auto PointerToArrayExpr = expr(ignoringParenImpCasts(expr(
-
hasType(qualType(hasCanonicalType(pointerType(pointee(arrayType()))))))));
-
- const auto StructAddrOfExpr =
- unaryOperator(hasOperatorName("&"),
- hasUnaryOperand(ignoringParenImpCasts(expr(
- hasType(qualType(hasCanonicalType(recordType())))))));
-
- Finder->addMatcher(
- expr(sizeOfExpr(has(expr(ignoringParenImpCasts(
- anyOf(ArrayCastExpr, PointerToArrayExpr, StructAddrOfExpr))))))
- .bind("sizeof-pointer-to-aggregate"),
- this);
-
- // Detect expression like: sizeof(epxr) <= k for a suspicious constant 'k'.
- if (WarnOnSizeOfCompareToConstant) {
- Finder->addMatcher(
- binaryOperator(matchers::isRelationalOperator(),
- hasEitherOperand(ignoringParenImpCasts(SizeOfExpr)),
- hasEitherOperand(ignoringParenImpCasts(
- anyOf(integerLiteral(equals(0)),
- integerLiteral(isBiggerThan(0x80000))))))
- .bind("sizeof-compare-constant"),
- this);
- }
-
- // Detect expression like: sizeof(expr, expr); most likely an error.
- Finder->addMatcher(expr(sizeOfExpr(has(expr(ignoringParenImpCasts(
- binaryOperator(hasOperatorName(",")))))))
- .bind("sizeof-comma-expr"),
- this);
-
- // Detect sizeof(...) /sizeof(...));
- const auto ElemType =
- arrayType(hasElementType(recordType().bind("elem-type")));
- const auto ElemPtrType = pointerType(pointee(type().bind("elem-ptr-type")));
- const auto NumType = qualType(hasCanonicalType(
- type(anyOf(ElemType, ElemPtrType, type())).bind("num-type")));
- const auto DenomType = qualType(hasCanonicalType(type().bind("denom-type")));
-
- Finder->addMatcher(
- binaryOperator(hasOperatorName("/"),
- hasLHS(expr(ignoringParenImpCasts(
- anyOf(sizeOfExpr(has(NumType)),
- sizeOfExpr(has(expr(hasType(NumType)))))))),
- hasRHS(expr(ignoringParenImpCasts(
- anyOf(sizeOfExpr(has(DenomType)),
- sizeOfExpr(has(expr(hasType(DenomType)))))))))
- .bind("sizeof-divide-expr"),
- this);
-
- // Detect expression like: sizeof(...) * sizeof(...)); most likely an error.
- Finder->addMatcher(binaryOperator(hasOperatorName("*"),
- hasLHS(ignoringParenImpCasts(SizeOfExpr)),
- hasRHS(ignoringParenImpCasts(SizeOfExpr)))
- .bind("sizeof-multiply-sizeof"),
- this);
-
- Finder->addMatcher(
- binaryOperator(hasOperatorName("*"),
- hasEitherOperand(ignoringParenImpCasts(SizeOfExpr)),
- hasEitherOperand(ignoringParenImpCasts(binaryOperator(
- hasOperatorName("*"),
-
hasEitherOperand(ignoringParenImpCasts(SizeOfExpr))))))
- .bind("sizeof-multiply-sizeof"),
- this);
-
- // Detect strange double-sizeof expression like: sizeof(sizeof(...));
- // Note: The expression 'sizeof(sizeof(0))' is accepted.
- Finder->addMatcher(
- expr(sizeOfExpr(has(ignoringParenImpCasts(expr(
- hasSizeOfDescendant(8, expr(SizeOfExpr,
unless(SizeOfZero))))))))
- .bind("sizeof-sizeof-expr"),
- this);
-}
-
-void SizeofExpressionCheck::check(const MatchFinder::MatchResult &Result) {
- const ASTContext &Ctx = *Result.Context;
-
- if (const auto *E = Result.Nodes.getNodeAs<Expr>("sizeof-constant")) {
- diag(E->getLocStart(),
- "suspicious usage of 'sizeof(K)'; did you mean 'K'?");
- } else if (const auto *E = Result.Nodes.getNodeAs<Expr>("sizeof-this")) {
- diag(E->getLocStart(),
- "suspicious usage of 'sizeof(this)'; did you mean 'sizeof(*this)'");
- } else if (const auto *E = Result.Nodes.getNodeAs<Expr>("sizeof-charp")) {
- diag(E->getLocStart(),
- "suspicious usage of 'sizeof(char*)'; do you mean 'strlen'?");
- } else if (const auto *E =
- Result.Nodes.getNodeAs<Expr>("sizeof-pointer-to-aggregate")) {
- diag(E->getLocStart(),
- "suspicious usage of 'sizeof(A*)'; pointer to aggregate");
- } else if (const auto *E =
- Result.Nodes.getNodeAs<Expr>("sizeof-compare-constant")) {
- diag(E->getLocStart(),
- "suspicious comparison of 'sizeof(expr)' to a constant");
- } else if (const auto *E =
- Result.Nodes.getNodeAs<Expr>("sizeof-comma-expr")) {
- diag(E->getLocStart(), "suspicious usage of 'sizeof(..., ...)'");
- } else if (const auto *E =
- Result.Nodes.getNodeAs<Expr>("sizeof-divide-expr")) {
- const auto *NumTy = Result.Nodes.getNodeAs<Type>("num-type");
- const auto *DenomTy = Result.Nodes.getNodeAs<Type>("denom-type");
- const auto *ElementTy = Result.Nodes.getNodeAs<Type>("elem-type");
- const auto *PointedTy = Result.Nodes.getNodeAs<Type>("elem-ptr-type");
-
- CharUnits NumeratorSize = getSizeOfType(Ctx, NumTy);
- CharUnits DenominatorSize = getSizeOfType(Ctx, DenomTy);
- CharUnits ElementSize = getSizeOfType(Ctx, ElementTy);
-
- if (DenominatorSize > CharUnits::Zero() &&
- !NumeratorSize.isMultipleOf(DenominatorSize)) {
- diag(E->getLocStart(), "suspicious usage of 'sizeof(...)/sizeof(...)';"
- " numerator is not a multiple of denominator");
- } else if (ElementSize > CharUnits::Zero() &&
- DenominatorSize > CharUnits::Zero() &&
- ElementSize != DenominatorSize) {
- diag(E->getLocStart(), "suspicious usage of 'sizeof(...)/sizeof(...)';"
- " numerator is not a multiple of denominator");
- } else if (NumTy && DenomTy && NumTy == DenomTy) {
- diag(E->getLocStart(),
- "suspicious usage of sizeof pointer 'sizeof(T)/sizeof(T)'");
- } else if (PointedTy && DenomTy && PointedTy == DenomTy) {
- diag(E->getLocStart(),
- "suspicious usage of sizeof pointer 'sizeof(T*)/sizeof(T)'");
- } else if (NumTy && DenomTy && NumTy->isPointerType() &&
- DenomTy->isPointerType()) {
- diag(E->getLocStart(),
- "suspicious usage of sizeof pointer 'sizeof(P*)/sizeof(Q*)'");
- }
- } else if (const auto *E =
- Result.Nodes.getNodeAs<Expr>("sizeof-sizeof-expr")) {
- diag(E->getLocStart(), "suspicious usage of 'sizeof(sizeof(...))'");
- } else if (const auto *E =
- Result.Nodes.getNodeAs<Expr>("sizeof-multiply-sizeof")) {
- diag(E->getLocStart(), "suspicious 'sizeof' by 'sizeof' multiplication");
- }
-}
-
-} // namespace misc
-} // namespace tidy
-} // namespace clang
Removed: clang-tools-extra/trunk/clang-tidy/misc/SizeofExpressionCheck.h
URL:
http://llvm.org/viewvc/llvm-project/clang-tools-extra/trunk/clang-tidy/misc/SizeofExpressionCheck.h?rev=327606&view=auto
==============================================================================
--- clang-tools-extra/trunk/clang-tidy/misc/SizeofExpressionCheck.h (original)
+++ clang-tools-extra/trunk/clang-tidy/misc/SizeofExpressionCheck.h (removed)
@@ -1,40 +0,0 @@
-//===--- SizeofExpressionCheck.h - clang-tidy--------------------*- C++
-*-===//
-//
-// The LLVM Compiler Infrastructure
-//
-// This file is distributed under the University of Illinois Open Source
-// License. See LICENSE.TXT for details.
-//
-//===----------------------------------------------------------------------===//
-
-#ifndef LLVM_CLANG_TOOLS_EXTRA_CLANG_TIDY_MISC_SIZEOF_EXPRESSION_H
-#define LLVM_CLANG_TOOLS_EXTRA_CLANG_TIDY_MISC_SIZEOF_EXPRESSION_H
-
-#include "../ClangTidy.h"
-
-namespace clang {
-namespace tidy {
-namespace misc {
-
-/// Find suspicious usages of sizeof expression.
-///
-/// For the user-facing documentation see:
-/// http://clang.llvm.org/extra/clang-tidy/checks/misc-sizeof-expression.html
-class SizeofExpressionCheck : public ClangTidyCheck {
-public:
- SizeofExpressionCheck(StringRef Name, ClangTidyContext *Context);
- void storeOptions(ClangTidyOptions::OptionMap &Opts) override;
- void registerMatchers(ast_matchers::MatchFinder *Finder) override;
- void check(const ast_matchers::MatchFinder::MatchResult &Result) override;
-
-private:
- const bool WarnOnSizeOfConstant;
- const bool WarnOnSizeOfThis;
- const bool WarnOnSizeOfCompareToConstant;
-};
-
-} // namespace misc
-} // namespace tidy
-} // namespace clang
-
-#endif // LLVM_CLANG_TOOLS_EXTRA_CLANG_TIDY_MISC_SIZEOF_EXPRESSION_H
Modified: clang-tools-extra/trunk/docs/ReleaseNotes.rst
URL:
http://llvm.org/viewvc/llvm-project/clang-tools-extra/trunk/docs/ReleaseNotes.rst?rev=327607&r1=327606&r2=327607&view=diff
==============================================================================
--- clang-tools-extra/trunk/docs/ReleaseNotes.rst (original)
+++ clang-tools-extra/trunk/docs/ReleaseNotes.rst Thu Mar 15 01:26:19 2018
@@ -137,6 +137,9 @@ Improvements to clang-tidy
- The 'misc-misplaced-widening-cast' check was renamed to
`bugprone-misplaced-widening-cast
<http://clang.llvm.org/extra/clang-tidy/checks/bugprone-misplaced-widening-cast.html>`_
+- The 'misc-sizeof-expression' check was renamed to `bugprone-sizeof-expression
+
<http://clang.llvm.org/extra/clang-tidy/checks/bugprone-sizeof-expression.html>`_
+
- The 'misc-string-compare' check was renamed to `readability-string-compare
<http://clang.llvm.org/extra/clang-tidy/checks/readability-string-compare.html>`_
Copied:
clang-tools-extra/trunk/docs/clang-tidy/checks/bugprone-sizeof-expression.rst
(from r327606,
clang-tools-extra/trunk/docs/clang-tidy/checks/misc-sizeof-expression.rst)
URL:
http://llvm.org/viewvc/llvm-project/clang-tools-extra/trunk/docs/clang-tidy/checks/bugprone-sizeof-expression.rst?p2=clang-tools-extra/trunk/docs/clang-tidy/checks/bugprone-sizeof-expression.rst&p1=clang-tools-extra/trunk/docs/clang-tidy/checks/misc-sizeof-expression.rst&r1=327606&r2=327607&rev=327607&view=diff
==============================================================================
--- clang-tools-extra/trunk/docs/clang-tidy/checks/misc-sizeof-expression.rst
(original)
+++
clang-tools-extra/trunk/docs/clang-tidy/checks/bugprone-sizeof-expression.rst
Thu Mar 15 01:26:19 2018
@@ -1,7 +1,7 @@
-.. title:: clang-tidy - misc-sizeof-expression
+.. title:: clang-tidy - bugprone-sizeof-expression
-misc-sizeof-expression
-======================
+bugprone-sizeof-expression
+==========================
The check finds usages of ``sizeof`` expressions which are most likely errors.
Modified: clang-tools-extra/trunk/docs/clang-tidy/checks/list.rst
URL:
http://llvm.org/viewvc/llvm-project/clang-tools-extra/trunk/docs/clang-tidy/checks/list.rst?rev=327607&r1=327606&r2=327607&view=diff
==============================================================================
--- clang-tools-extra/trunk/docs/clang-tidy/checks/list.rst (original)
+++ clang-tools-extra/trunk/docs/clang-tidy/checks/list.rst Thu Mar 15 01:26:19
2018
@@ -36,6 +36,7 @@ Clang-Tidy Checks
bugprone-misplaced-widening-cast
bugprone-move-forwarding-reference
bugprone-multiple-statement-macro
+ bugprone-sizeof-expression
bugprone-string-constructor
bugprone-string-integer-assignment
bugprone-string-literal-with-embedded-nul
@@ -146,7 +147,6 @@ Clang-Tidy Checks
misc-non-copyable-objects
misc-redundant-expression
misc-sizeof-container
- misc-sizeof-expression
misc-static-assert
misc-throw-by-value-catch-by-reference
misc-unconventional-assign-operator
Removed:
clang-tools-extra/trunk/docs/clang-tidy/checks/misc-sizeof-expression.rst
URL:
http://llvm.org/viewvc/llvm-project/clang-tools-extra/trunk/docs/clang-tidy/checks/misc-sizeof-expression.rst?rev=327606&view=auto
==============================================================================
--- clang-tools-extra/trunk/docs/clang-tidy/checks/misc-sizeof-expression.rst
(original)
+++ clang-tools-extra/trunk/docs/clang-tidy/checks/misc-sizeof-expression.rst
(removed)
@@ -1,154 +0,0 @@
-.. title:: clang-tidy - misc-sizeof-expression
-
-misc-sizeof-expression
-======================
-
-The check finds usages of ``sizeof`` expressions which are most likely errors.
-
-The ``sizeof`` operator yields the size (in bytes) of its operand, which may be
-an expression or the parenthesized name of a type. Misuse of this operator may
-be leading to errors and possible software vulnerabilities.
-
-Suspicious usage of 'sizeof(K)'
--------------------------------
-
-A common mistake is to query the ``sizeof`` of an integer literal. This is
-equivalent to query the size of its type (probably ``int``). The intent of the
-programmer was probably to simply get the integer and not its size.
-
-.. code-block:: c++
-
- #define BUFLEN 42
- char buf[BUFLEN];
- memset(buf, 0, sizeof(BUFLEN)); // sizeof(42) ==> sizeof(int)
-
-Suspicious usage of 'sizeof(this)'
-----------------------------------
-
-The ``this`` keyword is evaluated to a pointer to an object of a given type.
-The expression ``sizeof(this)`` is returning the size of a pointer. The
-programmer most likely wanted the size of the object and not the size of the
-pointer.
-
-.. code-block:: c++
-
- class Point {
- [...]
- size_t size() { return sizeof(this); } // should probably be sizeof(*this)
- [...]
- };
-
-Suspicious usage of 'sizeof(char*)'
------------------------------------
-
-There is a subtle difference between declaring a string literal with
-``char* A = ""`` and ``char A[] = ""``. The first case has the type ``char*``
-instead of the aggregate type ``char[]``. Using ``sizeof`` on an object
declared
-with ``char*`` type is returning the size of a pointer instead of the number of
-characters (bytes) in the string literal.
-
-.. code-block:: c++
-
- const char* kMessage = "Hello World!"; // const char kMessage[] = "...";
- void getMessage(char* buf) {
- memcpy(buf, kMessage, sizeof(kMessage)); // sizeof(char*)
- }
-
-Suspicious usage of 'sizeof(A*)'
---------------------------------
-
-A common mistake is to compute the size of a pointer instead of its pointee.
-These cases may occur because of explicit cast or implicit conversion.
-
-.. code-block:: c++
-
- int A[10];
- memset(A, 0, sizeof(A + 0));
-
- struct Point point;
- memset(point, 0, sizeof(&point));
-
-Suspicious usage of 'sizeof(...)/sizeof(...)'
----------------------------------------------
-
-Dividing ``sizeof`` expressions is typically used to retrieve the number of
-elements of an aggregate. This check warns on incompatible or suspicious cases.
-
-In the following example, the entity has 10-bytes and is incompatible with the
-type ``int`` which has 4 bytes.
-
-.. code-block:: c++
-
- char buf[] = { 0, 1, 2, 3, 4, 5, 6, 7, 8, 9 }; // sizeof(buf) => 10
- void getMessage(char* dst) {
- memcpy(dst, buf, sizeof(buf) / sizeof(int)); // sizeof(int) => 4
[incompatible sizes]
- }
-
-In the following example, the expression ``sizeof(Values)`` is returning the
-size of ``char*``. One can easily be fooled by its declaration, but in
parameter
-declaration the size '10' is ignored and the function is receiving a ``char*``.
-
-.. code-block:: c++
-
- char OrderedValues[10] = { 0, 1, 2, 3, 4, 5, 6, 7, 8, 9 };
- return CompareArray(char Values[10]) {
- return memcmp(OrderedValues, Values, sizeof(Values)) == 0; //
sizeof(Values) ==> sizeof(char*) [implicit cast to char*]
- }
-
-Suspicious 'sizeof' by 'sizeof' expression
-------------------------------------------
-
-Multiplying ``sizeof`` expressions typically makes no sense and is probably a
-logic error. In the following example, the programmer used ``*`` instead of
-``/``.
-
-.. code-block:: c++
-
- const char kMessage[] = "Hello World!";
- void getMessage(char* buf) {
- memcpy(buf, kMessage, sizeof(kMessage) * sizeof(char)); //
sizeof(kMessage) / sizeof(char)
- }
-
-This check may trigger on code using the arraysize macro. The following code is
-working correctly but should be simplified by using only the ``sizeof``
-operator.
-
-.. code-block:: c++
-
- extern Object objects[100];
- void InitializeObjects() {
- memset(objects, 0, arraysize(objects) * sizeof(Object)); //
sizeof(objects)
- }
-
-Suspicious usage of 'sizeof(sizeof(...))'
------------------------------------------
-
-Getting the ``sizeof`` of a ``sizeof`` makes no sense and is typically an error
-hidden through macros.
-
-.. code-block:: c++
-
- #define INT_SZ sizeof(int)
- int buf[] = { 42 };
- void getInt(int* dst) {
- memcpy(dst, buf, sizeof(INT_SZ)); // sizeof(sizeof(int)) is suspicious.
- }
-
-Options
--------
-
-.. option:: WarnOnSizeOfConstant
-
- When non-zero, the check will warn on an expression like
- ``sizeof(CONSTANT)``. Default is `1`.
-
-.. option:: WarnOnSizeOfThis
-
- When non-zero, the check will warn on an expression like ``sizeof(this)``.
- Default is `1`.
-
-.. option:: WarnOnSizeOfCompareToConstant
-
- When non-zero, the check will warn on an expression like
- ``sizeof(epxr) <= k`` for a suspicious constant `k` while `k` is `0` or
- greater than `0x8000`. Default is `1`.
Copied: clang-tools-extra/trunk/test/clang-tidy/bugprone-sizeof-expression.cpp
(from r327606,
clang-tools-extra/trunk/test/clang-tidy/misc-sizeof-expression.cpp)
URL:
http://llvm.org/viewvc/llvm-project/clang-tools-extra/trunk/test/clang-tidy/bugprone-sizeof-expression.cpp?p2=clang-tools-extra/trunk/test/clang-tidy/bugprone-sizeof-expression.cpp&p1=clang-tools-extra/trunk/test/clang-tidy/misc-sizeof-expression.cpp&r1=327606&r2=327607&rev=327607&view=diff
==============================================================================
--- clang-tools-extra/trunk/test/clang-tidy/misc-sizeof-expression.cpp
(original)
+++ clang-tools-extra/trunk/test/clang-tidy/bugprone-sizeof-expression.cpp Thu
Mar 15 01:26:19 2018
@@ -1,4 +1,4 @@
-// RUN: %check_clang_tidy %s misc-sizeof-expression %t
+// RUN: %check_clang_tidy %s bugprone-sizeof-expression %t
class C {
int size() { return sizeof(this); }
Removed: clang-tools-extra/trunk/test/clang-tidy/misc-sizeof-expression.cpp
URL:
http://llvm.org/viewvc/llvm-project/clang-tools-extra/trunk/test/clang-tidy/misc-sizeof-expression.cpp?rev=327606&view=auto
==============================================================================
--- clang-tools-extra/trunk/test/clang-tidy/misc-sizeof-expression.cpp
(original)
+++ clang-tools-extra/trunk/test/clang-tidy/misc-sizeof-expression.cpp (removed)
@@ -1,186 +0,0 @@
-// RUN: %check_clang_tidy %s misc-sizeof-expression %t
-
-class C {
- int size() { return sizeof(this); }
- // CHECK-MESSAGES: :[[@LINE-1]]:23: warning: suspicious usage of
'sizeof(this)'
-};
-
-#define LEN 8
-
-int X;
-extern int A[10];
-extern short B[10];
-
-#pragma pack(1)
-struct S { char a, b, c; };
-
-int Test1(const char* ptr) {
- int sum = 0;
- sum += sizeof(LEN);
- // CHECK-MESSAGES: :[[@LINE-1]]:10: warning: suspicious usage of 'sizeof(K)'
- sum += sizeof(LEN + 1);
- // CHECK-MESSAGES: :[[@LINE-1]]:10: warning: suspicious usage of 'sizeof(K)'
- sum += sizeof(sum, LEN);
- // CHECK-MESSAGES: :[[@LINE-1]]:10: warning: suspicious usage of
'sizeof(..., ...)'
- sum += sizeof(sizeof(X));
- // CHECK-MESSAGES: :[[@LINE-1]]:10: warning: suspicious usage of
'sizeof(sizeof(...))'
- sum += sizeof(LEN + sizeof(X));
- // CHECK-MESSAGES: :[[@LINE-1]]:10: warning: suspicious usage of
'sizeof(sizeof(...))'
- sum += sizeof(LEN + LEN + sizeof(X));
- // CHECK-MESSAGES: :[[@LINE-1]]:10: warning: suspicious usage of
'sizeof(sizeof(...))'
- sum += sizeof(LEN + (LEN + sizeof(X)));
- // CHECK-MESSAGES: :[[@LINE-1]]:10: warning: suspicious usage of
'sizeof(sizeof(...))'
- sum += sizeof(LEN + -sizeof(X));
- // CHECK-MESSAGES: :[[@LINE-1]]:10: warning: suspicious usage of
'sizeof(sizeof(...))'
- sum += sizeof(LEN + - + -sizeof(X));
- // CHECK-MESSAGES: :[[@LINE-1]]:10: warning: suspicious usage of
'sizeof(sizeof(...))'
- sum += sizeof(char) / sizeof(char);
- // CHECK-MESSAGES: :[[@LINE-1]]:10: warning: suspicious usage of sizeof
pointer 'sizeof(T)/sizeof(T)'
- sum += sizeof(A) / sizeof(S);
- // CHECK-MESSAGES: :[[@LINE-1]]:10: warning: suspicious usage of
'sizeof(...)/sizeof(...)'; numerator is not a multiple of denominator
- sum += sizeof(char) / sizeof(int);
- // CHECK-MESSAGES: :[[@LINE-1]]:10: warning: suspicious usage of
'sizeof(...)/sizeof(...)'; numerator is not a multiple of denominator
- sum += sizeof(char) / sizeof(A);
- // CHECK-MESSAGES: :[[@LINE-1]]:10: warning: suspicious usage of
'sizeof(...)/sizeof(...)'; numerator is not a multiple of denominator
- sum += sizeof(B[0]) / sizeof(A);
- // CHECK-MESSAGES: :[[@LINE-1]]:10: warning: suspicious usage of
'sizeof(...)/sizeof(...)'; numerator is not a multiple of denominator
- sum += sizeof(ptr) / sizeof(char);
- // CHECK-MESSAGES: :[[@LINE-1]]:10: warning: suspicious usage of sizeof
pointer 'sizeof(T*)/sizeof(T)'
- sum += sizeof(ptr) / sizeof(ptr[0]);
- // CHECK-MESSAGES: :[[@LINE-1]]:10: warning: suspicious usage of sizeof
pointer 'sizeof(T*)/sizeof(T)'
- sum += sizeof(ptr) / sizeof(char*);
- // CHECK-MESSAGES: :[[@LINE-1]]:10: warning: suspicious usage of sizeof
pointer 'sizeof(P*)/sizeof(Q*)'
- sum += sizeof(ptr) / sizeof(void*);
- // CHECK-MESSAGES: :[[@LINE-1]]:10: warning: suspicious usage of sizeof
pointer 'sizeof(P*)/sizeof(Q*)'
- sum += sizeof(ptr) / sizeof(const void volatile*);
- // CHECK-MESSAGES: :[[@LINE-1]]:10: warning: suspicious usage of sizeof
pointer 'sizeof(P*)/sizeof(Q*)'
- sum += sizeof(ptr) / sizeof(char);
- // CHECK-MESSAGES: :[[@LINE-1]]:10: warning: suspicious usage of sizeof
pointer 'sizeof(T*)/sizeof(T)'
- sum += sizeof(ptr) / sizeof(ptr[0]);
- // CHECK-MESSAGES: :[[@LINE-1]]:10: warning: suspicious usage of sizeof
pointer 'sizeof(T*)/sizeof(T)'
- sum += sizeof(int) * sizeof(char);
- // CHECK-MESSAGES: :[[@LINE-1]]:10: warning: suspicious 'sizeof' by 'sizeof'
multiplication
- sum += sizeof(ptr) * sizeof(ptr[0]);
- // CHECK-MESSAGES: :[[@LINE-1]]:10: warning: suspicious 'sizeof' by 'sizeof'
multiplication
- sum += sizeof(int) * (2 * sizeof(char));
- // CHECK-MESSAGES: :[[@LINE-1]]:10: warning: suspicious 'sizeof' by 'sizeof'
multiplication
- sum += (2 * sizeof(char)) * sizeof(int);
- // CHECK-MESSAGES: :[[@LINE-1]]:10: warning: suspicious 'sizeof' by 'sizeof'
multiplication
- if (sizeof(A) < 0x100000) sum += 42;
- // CHECK-MESSAGES: :[[@LINE-1]]:7: warning: suspicious comparison of
'sizeof(expr)' to a constant
- if (sizeof(A) <= 0xFFFFFFFEU) sum += 42;
- // CHECK-MESSAGES: :[[@LINE-1]]:7: warning: suspicious comparison of
'sizeof(expr)' to a constant
- return sum;
-}
-
-typedef char MyChar;
-typedef const MyChar MyConstChar;
-
-int CE0 = sizeof sizeof(char);
-// CHECK-MESSAGES: :[[@LINE-1]]:11: warning: suspicious usage of
'sizeof(sizeof(...))'
-int CE1 = sizeof +sizeof(char);
-// CHECK-MESSAGES: :[[@LINE-1]]:11: warning: suspicious usage of
'sizeof(sizeof(...))'
-int CE2 = sizeof sizeof(const char*);
-// CHECK-MESSAGES: :[[@LINE-1]]:11: warning: suspicious usage of
'sizeof(sizeof(...))'
-int CE3 = sizeof sizeof(const volatile char* const*);
-// CHECK-MESSAGES: :[[@LINE-1]]:11: warning: suspicious usage of
'sizeof(sizeof(...))'
-int CE4 = sizeof sizeof(MyConstChar);
-// CHECK-MESSAGES: :[[@LINE-1]]:11: warning: suspicious usage of
'sizeof(sizeof(...))'
-
-int Test2(MyConstChar* A) {
- int sum = 0;
- sum += sizeof(MyConstChar) / sizeof(char);
- // CHECK-MESSAGES: :[[@LINE-1]]:10: warning: suspicious usage of sizeof
pointer 'sizeof(T)/sizeof(T)'
- sum += sizeof(MyConstChar) / sizeof(MyChar);
- // CHECK-MESSAGES: :[[@LINE-1]]:10: warning: suspicious usage of sizeof
pointer 'sizeof(T)/sizeof(T)'
- sum += sizeof(A[0]) / sizeof(char);
- // CHECK-MESSAGES: :[[@LINE-1]]:10: warning: suspicious usage of sizeof
pointer 'sizeof(T)/sizeof(T)'
- return sum;
-}
-
-template <int T>
-int Foo() { int A[T]; return sizeof(T); }
-// CHECK-MESSAGES: :[[@LINE-1]]:30: warning: suspicious usage of 'sizeof(K)'
-template <typename T>
-int Bar() { T A[5]; return sizeof(A[0]) / sizeof(T); }
-// CHECK-MESSAGES: :[[@LINE-1]]:28: warning: suspicious usage of sizeof
pointer 'sizeof(T)/sizeof(T)'
-int Test3() { return Foo<42>() + Bar<char>(); }
-
-static const char* kABC = "abc";
-static const wchar_t* kDEF = L"def";
-int Test4(const char A[10]) {
- int sum = 0;
- sum += sizeof(kABC);
- // CHECK-MESSAGES: :[[@LINE-1]]:10: warning: suspicious usage of
'sizeof(char*)'
- sum += sizeof(kDEF);
- // CHECK-MESSAGES: :[[@LINE-1]]:10: warning: suspicious usage of
'sizeof(char*)'
- return sum;
-}
-
-int Test5() {
- typedef int Array10[10];
-
- struct MyStruct {
- Array10 arr;
- Array10* ptr;
- };
- typedef const MyStruct TMyStruct;
-
- static TMyStruct kGlocalMyStruct = {};
- static TMyStruct volatile * kGlocalMyStructPtr = &kGlocalMyStruct;
-
- MyStruct S;
- Array10 A10;
-
- int sum = 0;
- sum += sizeof(&S.arr);
- // CHECK-MESSAGES: :[[@LINE-1]]:10: warning: suspicious usage of
'sizeof(A*)'; pointer to aggregate
- sum += sizeof(&kGlocalMyStruct.arr);
- // CHECK-MESSAGES: :[[@LINE-1]]:10: warning: suspicious usage of
'sizeof(A*)'; pointer to aggregate
- sum += sizeof(&kGlocalMyStructPtr->arr);
- // CHECK-MESSAGES: :[[@LINE-1]]:10: warning: suspicious usage of
'sizeof(A*)'; pointer to aggregate
- sum += sizeof(S.arr + 0);
- // CHECK-MESSAGES: :[[@LINE-1]]:10: warning: suspicious usage of
'sizeof(A*)'; pointer to aggregate
- sum += sizeof(+ S.arr);
- // CHECK-MESSAGES: :[[@LINE-1]]:10: warning: suspicious usage of
'sizeof(A*)'; pointer to aggregate
- sum += sizeof((int*)S.arr);
- // CHECK-MESSAGES: :[[@LINE-1]]:10: warning: suspicious usage of
'sizeof(A*)'; pointer to aggregate
-
- sum += sizeof(S.ptr);
- // CHECK-MESSAGES: :[[@LINE-1]]:10: warning: suspicious usage of
'sizeof(A*)'; pointer to aggregate
- sum += sizeof(kGlocalMyStruct.ptr);
- // CHECK-MESSAGES: :[[@LINE-1]]:10: warning: suspicious usage of
'sizeof(A*)'; pointer to aggregate
- sum += sizeof(kGlocalMyStructPtr->ptr);
- // CHECK-MESSAGES: :[[@LINE-1]]:10: warning: suspicious usage of
'sizeof(A*)'; pointer to aggregate
-
- sum += sizeof(&kGlocalMyStruct);
- // CHECK-MESSAGES: :[[@LINE-1]]:10: warning: suspicious usage of
'sizeof(A*)'; pointer to aggregate
- sum += sizeof(&S);
- // CHECK-MESSAGES: :[[@LINE-1]]:10: warning: suspicious usage of
'sizeof(A*)'; pointer to aggregate
- sum += sizeof(&A10);
- // CHECK-MESSAGES: :[[@LINE-1]]:10: warning: suspicious usage of
'sizeof(A*)'; pointer to aggregate
-
- return sum;
-}
-
-int ValidExpressions() {
- int A[] = {1, 2, 3, 4};
- static const char str[] = "hello";
- static const char* ptr[] { "aaa", "bbb", "ccc" };
- int sum = 0;
- if (sizeof(A) < 10)
- sum += sizeof(A);
- sum += sizeof(int);
- sum += sizeof(A[sizeof(A) / sizeof(int)]);
- sum += sizeof(&A[sizeof(A) / sizeof(int)]);
- sum += sizeof(sizeof(0)); // Special case: sizeof size_t.
- sum += sizeof(void*);
- sum += sizeof(void const *);
- sum += sizeof(void const *) / 4;
- sum += sizeof(str);
- sum += sizeof(str) / sizeof(char);
- sum += sizeof(str) / sizeof(str[0]);
- sum += sizeof(ptr) / sizeof(ptr[0]);
- sum += sizeof(ptr) / sizeof(*(ptr));
- return sum;
-}
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
