[libunwind] [libunwind] [SEH] Implement parsing of aarch64 pdata/xdata (PR #137949)

2025-05-01 Thread Martin Storsjö via cfe-commits
@@ -2018,6 +2018,52 @@ bool UnwindCursor::getInfoFromSEH(pint_t pc) { _info.handler = 0; } } +#elif defined(_LIBUNWIND_TARGET_AARCH64) + if (unwindEntry->Flag != 0) { // Packed unwind info +_info.end_ip = _info.start_ip + unwindEntry->FunctionLength * 4; +/

[clang] [llvm] [mlir] [AMDGPU] Add a new amdgcn.load.to.lds intrinsic (PR #137425)

2025-05-01 Thread Krzysztof Drewniak via cfe-commits
https://github.com/krzysz00 updated https://github.com/llvm/llvm-project/pull/137425 Rate limit · GitHub body { background-color: #f6f8fa; color: #24292e; font-family: -apple-system,BlinkMacSystemFont,Segoe UI,Helvetica,Arial,sans-

[clang] [C] Allow __attribute__((nonstring)) on multidimensional arrays (PR #138133)

2025-05-01 Thread Nathan Chancellor via cfe-commits
https://github.com/nathanchance approved this pull request. Thanks, this appears to resolve the warning in the one place that I know needs it. https://github.com/llvm/llvm-project/pull/138133 ___ cfe-commits mailing list cfe-commits@lists.llvm.org htt

[clang] [CIR] Upstream cir.call with scalar arguments (PR #136810)

2025-05-01 Thread Andy Kaylor via cfe-commits
https://github.com/andykaylor approved this pull request. lgtm https://github.com/llvm/llvm-project/pull/136810 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang-tools-extra] [clang-tidy] Return error code on config parse error (PR #136167)

2025-05-01 Thread Galen Elias via cfe-commits
@@ -266,7 +266,7 @@ ClangTidyOptions ClangTidyContext::getOptionsForFile(StringRef File) const { // Merge options on top of getDefaults() as a safeguard against options with // unset values. return ClangTidyOptions::getDefaults().merge( - OptionsProvider->getOptions

[clang] [OpenACC] Implement better dupe catching for device_type clauses (PR #138196)

2025-05-01 Thread Erich Keane via cfe-commits
https://github.com/erichkeane created https://github.com/llvm/llvm-project/pull/138196 Previously we just checked duplicates for a handful of clauses between active device_type clauses. However, after looking into the implementation for 'collapse', I discovered that duplicate device_type iden

[clang] [OpenACC] Implement better dupe catching for device_type clauses (PR #138196)

2025-05-01 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang Author: Erich Keane (erichkeane) Changes Previously we just checked duplicates for a handful of clauses between active device_type clauses. However, after looking into the implementation for 'collapse', I discovered that duplicate device_type id

[clang] [lldb] [llvm] [mlir] [NFC][Support] Add llvm::uninitialized_copy (PR #138174)

2025-05-01 Thread Rahul Joshi via cfe-commits
https://github.com/jurahul updated https://github.com/llvm/llvm-project/pull/138174 >From de1b49fc6b8819b591e48b81634567ceeffe5089 Mon Sep 17 00:00:00 2001 From: Rahul Joshi Date: Wed, 30 Apr 2025 23:47:37 -0700 Subject: [PATCH] [NFC][Support] Add llvm::uninitialized_copy Add `llvm::uninitiali

[clang] [CIR] Upstream local initialization for VectorType (PR #138107)

2025-05-01 Thread Andy Kaylor via cfe-commits
@@ -1584,6 +1586,47 @@ mlir::Value ScalarExprEmitter::VisitMemberExpr(MemberExpr *e) { return emitLoadOfLValue(e); } +mlir::Value ScalarExprEmitter::VisitInitListExpr(InitListExpr *e) { + const unsigned numInitElements = e->getNumInits(); + + if (e->hadArrayRangeDesignato

[clang] a76936f - [CIR] Upstream support for range-based for loops (#138176)

2025-05-01 Thread via cfe-commits
Author: Andy Kaylor Date: 2025-05-01T14:47:20-07:00 New Revision: a76936f1c01c7cadbce8ea6553af758d0f614b6a URL: https://github.com/llvm/llvm-project/commit/a76936f1c01c7cadbce8ea6553af758d0f614b6a DIFF: https://github.com/llvm/llvm-project/commit/a76936f1c01c7cadbce8ea6553af758d0f614b6a.diff L

[clang] [llvm] [HLSL][DXIL] Implement `refract` intrinsic (PR #136026)

2025-05-01 Thread via cfe-commits
https://github.com/raoanag updated https://github.com/llvm/llvm-project/pull/136026 >From 6ce233acf415d2d48eca8f75d69b678c8877aa84 Mon Sep 17 00:00:00 2001 From: Anagha Rajendra Rao Date: Wed, 16 Apr 2025 11:47:27 -0700 Subject: [PATCH 1/6] Refract implementation --- clang/test/CodeGenHLSL/bu

[clang] [C] Add -Wjump-bypasses-init (PR #138009)

2025-05-01 Thread Shafik Yaghmour via cfe-commits
@@ -0,0 +1,31 @@ +// RUN: %clang_cc1 -fsyntax-only -verify=c,both -Wjump-bypasses-init %s +// RUN: %clang_cc1 -fsyntax-only -verify=c,both -Wc++-compat %s +// RUN: %clang_cc1 -fsyntax-only -verify=good %s +// RUN: %clang_cc1 -fsyntax-only -verify=cxx,both -x c++ %s +// good-no-dia

[clang] [C] Add -Wjump-bypasses-init (PR #138009)

2025-05-01 Thread Shafik Yaghmour via cfe-commits
@@ -0,0 +1,31 @@ +// RUN: %clang_cc1 -fsyntax-only -verify=c,both -Wjump-bypasses-init %s +// RUN: %clang_cc1 -fsyntax-only -verify=c,both -Wc++-compat %s +// RUN: %clang_cc1 -fsyntax-only -verify=good %s +// RUN: %clang_cc1 -fsyntax-only -verify=cxx,both -x c++ %s +// good-no-dia

[clang] [lldb] [llvm] [mlir] [NFC][Support] Add llvm::uninitialized_copy (PR #138174)

2025-05-01 Thread Rahul Joshi via cfe-commits
https://github.com/jurahul updated https://github.com/llvm/llvm-project/pull/138174 >From fbe3ca0c2e4d195149f5e3e6b8d32797cf47b9df Mon Sep 17 00:00:00 2001 From: Rahul Joshi Date: Wed, 30 Apr 2025 23:47:37 -0700 Subject: [PATCH] [NFC][Support] Add llvm::uninitialized_copy Add `llvm::uninitiali

[clang] [llvm] [HLSL][DXIL] Implement `refract` intrinsic (PR #136026)

2025-05-01 Thread via cfe-commits
@@ -69,6 +69,49 @@ bool SemaSPIRV::CheckSPIRVBuiltinFunctionCall(unsigned BuiltinID, TheCall->setType(RetTy); break; } + case SPIRV::BI__builtin_spirv_refract: { +if (SemaRef.checkArgCount(TheCall, 3)) + return true; + +ExprResult A = TheCall->getArg(0)

[clang] [C] Add -Wduplicate-decl-specifier to -Wc++-compat (PR #138012)

2025-05-01 Thread Shafik Yaghmour via cfe-commits
@@ -0,0 +1,17 @@ +// RUN: %clang_cc1 -fsyntax-only -verify -Wduplicate-decl-specifier %s +// RUN: %clang_cc1 -fsyntax-only -verify -Wc++-compat %s +// RUN: %clang_cc1 -fsyntax-only -verify -Wno-duplicate-decl-specifier -Wc++-compat %s +// RUN: %clang_cc1 -fsyntax-only -verify=goo

[clang] [CIR] Refactor global variable emission and initialization (PR #138222)

2025-05-01 Thread Andy Kaylor via cfe-commits
https://github.com/andykaylor created https://github.com/llvm/llvm-project/pull/138222 When global variable support was initially upstreamed, we took some shortcuts and only implemented the minimum support for simple variables and constant initializers. This change refactors the code that cre

[clang] [HLSL] Implement the `ldexp` intrinsic (PR #138182)

2025-05-01 Thread Sarah Spall via cfe-commits
@@ -303,6 +303,48 @@ fmod(__detail::HLSL_FIXED_VECTOR X, return __detail::fmod_vec_impl(X, Y); } +//===--===// +// ldexp builtins +//===--=

[clang] [HLSL] Implement the `ldexp` intrinsic (PR #138182)

2025-05-01 Thread Sarah Spall via cfe-commits
@@ -0,0 +1,39 @@ +// RUN: %clang_cc1 -finclude-default-header -triple dxil-pc-shadermodel6.6-library %s -fnative-half-type -emit-llvm-only -disable-llvm-passes -verify + +float test_double_inputs(double p0, double p1) { + return ldexp(p0, p1); + // expected-error@-1 {{no matc

[clang] [HLSL] Implement the `ldexp` intrinsic (PR #138182)

2025-05-01 Thread Sarah Spall via cfe-commits
@@ -0,0 +1,49 @@ +// RUN: %clang_cc1 -finclude-default-header -x hlsl -triple dxil-pc-shadermodel6.3-library %s -fnative-half-type -emit-llvm -disable-llvm-passes -o - | FileCheck %s spall wrote: A lot of the builtins that support half and float have tests with

[clang] [CIR] Refactor global variable emission and initialization (PR #138222)

2025-05-01 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang Author: Andy Kaylor (andykaylor) Changes When global variable support was initially upstreamed, we took some shortcuts and only implemented the minimum support for simple variables and constant initializers. This change refactors the code that c

[clang] [CIR] Upstream lowering of conditional operators to TernaryOp (PR #138156)

2025-05-01 Thread Andy Kaylor via cfe-commits
@@ -948,6 +950,165 @@ void CIRGenFunction::emitIgnoredExpr(const Expr *e) { emitLValue(e); } +// Handle the case where the condition is a constant evaluatable simple integer, +// which means we don't have to separately handle the true/false blocks. +static std::optional han

[clang] [CIR] Upstream lowering of conditional operators to TernaryOp (PR #138156)

2025-05-01 Thread Andy Kaylor via cfe-commits
@@ -642,12 +798,97 @@ class CIRGenFunction : public CIRGenTypeCache { void emitNullabilityCheck(LValue lhs, mlir::Value rhs, clang::SourceLocation loc); + /// An object to manage conditionally-evaluated expressions. + class ConditionalEvaluation

[clang] [HLSL] Implement the `ldexp` intrinsic (PR #138182)

2025-05-01 Thread Deric C. via cfe-commits
@@ -0,0 +1,39 @@ +// RUN: %clang_cc1 -finclude-default-header -triple dxil-pc-shadermodel6.6-library %s -fnative-half-type -emit-llvm-only -disable-llvm-passes -verify + +float test_double_inputs(double p0, double p1) { + return ldexp(p0, p1); + // expected-error@-1 {{no matc

[clang] [HLSL] Implement the `ldexp` intrinsic (PR #138182)

2025-05-01 Thread Deric C. via cfe-commits
@@ -0,0 +1,49 @@ +// RUN: %clang_cc1 -finclude-default-header -x hlsl -triple dxil-pc-shadermodel6.3-library %s -fnative-half-type -emit-llvm -disable-llvm-passes -o - | FileCheck %s Icohedron wrote: Yea, to be consistent if nothing else. https://github.com/ll

[clang] [HLSL] Implement the `ldexp` intrinsic (PR #138182)

2025-05-01 Thread Deric C. via cfe-commits
https://github.com/Icohedron requested changes to this pull request. @spall pointed out some good changes that should be made https://github.com/llvm/llvm-project/pull/138182 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.or

[clang] [CIR] Upstream lowering of conditional operators to TernaryOp (PR #138156)

2025-05-01 Thread Andy Kaylor via cfe-commits
@@ -948,6 +950,165 @@ void CIRGenFunction::emitIgnoredExpr(const Expr *e) { emitLValue(e); } +// Handle the case where the condition is a constant evaluatable simple integer, +// which means we don't have to separately handle the true/false blocks. +static std::optional han

[clang] [CIR] Upstream lowering of conditional operators to TernaryOp (PR #138156)

2025-05-01 Thread Andy Kaylor via cfe-commits
@@ -272,6 +272,22 @@ class CIRBaseBuilderTy : public mlir::OpBuilder { return createCast(loc, cir::CastKind::bitcast, src, newTy); } + // TODO(cir): the following function was introduced to keep in sync with LLVM andykaylor wrote: This probably made se

[clang] [CIR] Upstream lowering of conditional operators to TernaryOp (PR #138156)

2025-05-01 Thread Andy Kaylor via cfe-commits
@@ -1658,6 +1828,170 @@ mlir::Value ScalarExprEmitter::VisitUnaryExprOrTypeTraitExpr( cgf.cgm.UInt64Ty, e->EvaluateKnownConstInt(cgf.getContext(; } +/// Return true if the specified expression is cheap enough and side-effect-free +/// enough to evaluate un

[clang] [CIR] Upstream lowering of conditional operators to TernaryOp (PR #138156)

2025-05-01 Thread Andy Kaylor via cfe-commits
@@ -948,6 +950,165 @@ void CIRGenFunction::emitIgnoredExpr(const Expr *e) { emitLValue(e); } +// Handle the case where the condition is a constant evaluatable simple integer, +// which means we don't have to separately handle the true/false blocks. +static std::optional han

[clang] [CIR] Upstream lowering of conditional operators to TernaryOp (PR #138156)

2025-05-01 Thread Andy Kaylor via cfe-commits
@@ -875,6 +877,174 @@ class ScalarExprEmitter : public StmtVisitor { // NOTE: We don't need to EnsureInsertPoint() like LLVM codegen. return Visit(e->getRHS()); } + + mlir::Value VisitBinLAnd(const clang::BinaryOperator *e) { +if (e->getType()->isVectorType()) {

[clang] [CIR] Upstream lowering of conditional operators to TernaryOp (PR #138156)

2025-05-01 Thread Andy Kaylor via cfe-commits
https://github.com/andykaylor commented: Could you break this up a bit more? Maybe cut it back to just the code needed for the logical operators? https://github.com/llvm/llvm-project/pull/138156 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[clang] [CIR] Upstream lowering of conditional operators to TernaryOp (PR #138156)

2025-05-01 Thread Andy Kaylor via cfe-commits
@@ -948,6 +950,165 @@ void CIRGenFunction::emitIgnoredExpr(const Expr *e) { emitLValue(e); } +// Handle the case where the condition is a constant evaluatable simple integer, +// which means we don't have to separately handle the true/false blocks. +static std::optional han

[clang] [CIR] Upstream lowering of conditional operators to TernaryOp (PR #138156)

2025-05-01 Thread Andy Kaylor via cfe-commits
https://github.com/andykaylor edited https://github.com/llvm/llvm-project/pull/138156 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [CIR] Upstream lowering of conditional operators to TernaryOp (PR #138156)

2025-05-01 Thread Andy Kaylor via cfe-commits
@@ -948,6 +950,165 @@ void CIRGenFunction::emitIgnoredExpr(const Expr *e) { emitLValue(e); } +// Handle the case where the condition is a constant evaluatable simple integer, +// which means we don't have to separately handle the true/false blocks. +static std::optional han

[clang] [clang-format] Add AlignAfterOpenBracketOptions (PR #108332)

2025-05-01 Thread Gedare Bloom via cfe-commits
gedare wrote: > Why would `AlignAfterControlStatement` have anything to do with > `AlignAfterOpenBracket`, which is for arguments of function/macro calls? > Unfortunately, `AlignAfterOpenBracket` is not just for arguments of function/macro calls. It affects parentheses of control statements a

[clang] 1b1e360 - [NFC][clang] No sharedlibs for UEFI (#137872)

2025-05-01 Thread via cfe-commits
Author: Prabhu Rajasekaran Date: 2025-05-01T15:49:32-07:00 New Revision: 1b1e360b76d31fcd09b93b8c05be8a93dfea432b URL: https://github.com/llvm/llvm-project/commit/1b1e360b76d31fcd09b93b8c05be8a93dfea432b DIFF: https://github.com/llvm/llvm-project/commit/1b1e360b76d31fcd09b93b8c05be8a93dfea432b.

[clang] [NFC][clang] No sharedlibs for UEFI (PR #137872)

2025-05-01 Thread Prabhu Rajasekaran via cfe-commits
https://github.com/Prabhuk closed https://github.com/llvm/llvm-project/pull/137872 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [C] Add -Wjump-bypasses-init (PR #138009)

2025-05-01 Thread Shafik Yaghmour via cfe-commits
@@ -6561,18 +6561,28 @@ def ext_goto_into_protected_scope : ExtWarn< def warn_cxx98_compat_goto_into_protected_scope : Warning< "jump from this goto statement to its label is incompatible with C++98">, InGroup, DefaultIgnore; +def warn_cpp_compat_goto_into_protected_scope :

[clang] [clang][lex] Fix lexing malformed pragma within include directive (PR #138165)

2025-05-01 Thread via cfe-commits
github-actions[bot] wrote: :warning: C/C++ code formatter, clang-format found issues in your code. :warning: You can test this locally with the following command: ``bash git-clang-format --diff HEAD~1 HEAD --extensions cpp -- clang/lib/Lex/Pragma.cpp `` View the diff

[clang] [clang][lex] Fix lexing malformed pragma within include directive (PR #138165)

2025-05-01 Thread Shafik Yaghmour via cfe-commits
https://github.com/shafik commented: Thank you for the fix, this needs a test and release note. Release notes for clang are in `clang/docs/ReleaseNotes.rst`. I am not sure what the right file for testing is though @AaronBallman https://github.com/llvm/llvm-project/pull/138165 ___

[clang] [libclang/python] Add tests for equality operators. (PR #138132)

2025-05-01 Thread Jannick Kremer via cfe-commits
https://github.com/DeinAlptraum updated https://github.com/llvm/llvm-project/pull/138132 >From 74cf17d76918c465aa24e391e15546ab030483f2 Mon Sep 17 00:00:00 2001 From: Jannick Kremer Date: Thu, 1 May 2025 22:42:56 +0900 Subject: [PATCH 1/2] [libclang/python] Add tests for equality operators. Ad

[clang] [libclang/python] Add tests for equality operators. (PR #138132)

2025-05-01 Thread Jannick Kremer via cfe-commits
@@ -16,6 +16,8 @@ from .util import get_cursor, get_tu +INPUTS_DIR = os.path.join(os.path.dirname(__file__), "INPUTS") DeinAlptraum wrote: Yes, I changed these to use `pathlib.Path` instead https://github.com/llvm/llvm-project/pull/138132 __

[clang] 44c4b4c - [CIR] Upstream cir.call with scalar arguments (#136810)

2025-05-01 Thread via cfe-commits
Author: Sirui Mu Date: 2025-05-02T10:04:48+08:00 New Revision: 44c4b4cef9d13ef91a771c45664dde643009f996 URL: https://github.com/llvm/llvm-project/commit/44c4b4cef9d13ef91a771c45664dde643009f996 DIFF: https://github.com/llvm/llvm-project/commit/44c4b4cef9d13ef91a771c45664dde643009f996.diff LOG:

[clang] [CIR] Upstream cir.call with scalar arguments (PR #136810)

2025-05-01 Thread Sirui Mu via cfe-commits
https://github.com/Lancern closed https://github.com/llvm/llvm-project/pull/136810 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [libclang/python] Add typing annotations for the Cursor class (PR #138103)

2025-05-01 Thread Jannick Kremer via cfe-commits
https://github.com/DeinAlptraum created https://github.com/llvm/llvm-project/pull/138103 None >From d03f89a960e4fd57be2c37ee4c0cd59b5c784316 Mon Sep 17 00:00:00 2001 From: Jannick Kremer Date: Thu, 1 May 2025 18:37:43 +0900 Subject: [PATCH] [libclang/python] Add typing annotations for the Curs

[clang] [libclang/python] Add typing annotations for the Cursor class (PR #138103)

2025-05-01 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang Author: Jannick Kremer (DeinAlptraum) Changes --- Patch is 22.11 KiB, truncated to 20.00 KiB below, full version: https://github.com/llvm/llvm-project/pull/138103.diff 1 Files Affected: - (modified) clang/bindings/python/clang/cindex.py (+80

[clang] [llvm] [clang] Add scoped enum support to `StreamingDiagnostic` (PR #138089)

2025-05-01 Thread Vlad Serebrennikov via cfe-commits
@@ -1429,6 +1429,22 @@ operator<<(const StreamingDiagnostic &DB, T *DC) { return DB; } +// Convert scope enums to their underlying type, so that we don't have +// clutter the emitting code with `llvm::to_underlying()`. +// We also need to disable implicit conversion for the

[clang] [Clang][Cygwin] Disable shared libs on Cygwin by default (PR #138119)

2025-05-01 Thread Mateusz Mikuła via cfe-commits
https://github.com/mati865 created https://github.com/llvm/llvm-project/pull/138119 This change follows MinGW decisions, otherwise build with GCC fail with: ``` FAILED: bin/msys-clang-cpp-21.0git.dll lib/libclang-cpp.dll.a ... /usr/lib/gcc/x86_64-pc-msys/13.3.0/../../../../x86_64-pc-msys/bin/ld:

[clang] [Clang][Cygwin] Remove erroneous _WIN32 define and clean up Cygwin code (PR #138120)

2025-05-01 Thread Mateusz Mikuła via cfe-commits
https://github.com/mati865 created https://github.com/llvm/llvm-project/pull/138120 With this define present and building with Clang the build fails: ``` In file included from /h/projects/llvm-project/clang/tools/libclang/CIndexer.cpp:36: In file included from /usr/include/w32api/windows.h:69:

[clang] [C] Add -Wtentative-definition-compat (PR #137967)

2025-05-01 Thread Aaron Ballman via cfe-commits
https://github.com/AaronBallman updated https://github.com/llvm/llvm-project/pull/137967 >From b685a553da0b3f9ecf019ceddb1052de60a9a4e6 Mon Sep 17 00:00:00 2001 From: Aaron Ballman Date: Wed, 30 Apr 2025 10:11:17 -0400 Subject: [PATCH] [C] Add -Wtentative-definition-compat This adds a new diag

[clang] [Clang] incorrect assertion when checking template template parameter of a lambda (PR #138121)

2025-05-01 Thread via cfe-commits
https://github.com/cor3ntin created https://github.com/llvm/llvm-project/pull/138121 When a lambda is used in an alias declaration, we were trying to refer to its call operator. However, that could happen before (or during) the call operator is defined. So we should not assume a lambda always

[clang] [Clang] incorrect assertion when checking template template parameter of a lambda (PR #138121)

2025-05-01 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang Author: cor3ntin (cor3ntin) Changes When a lambda is used in an alias declaration, we were trying to refer to its call operator. However, that could happen before (or during) the call operator is defined. So we should not assume a lambda always

[clang] Fix missing initializer for inline static template member with auto caused by delayed template instantiation. (PR #138122)

2025-05-01 Thread via cfe-commits
https://github.com/dty2 created https://github.com/llvm/llvm-project/pull/138122 Try to fix missing initializer for inline static template member with auto caused by delayed template instantiation. Bug Fix: [Bug 135032](https://github.com/llvm/llvm-project/issues/135032) Problem Description: Du

[clang] Fix missing initializer for inline static template member with auto caused by delayed template instantiation. (PR #138122)

2025-05-01 Thread via cfe-commits
github-actions[bot] wrote: :warning: C/C++ code formatter, clang-format found issues in your code. :warning: You can test this locally with the following command: ``bash git-clang-format --diff HEAD~1 HEAD --extensions cpp -- clang/lib/Sema/SemaTemplateInstantiateDecl.cpp clang

[clang] [Clang] Warning as error for fold expressions over comparison operators (PR #136836)

2025-05-01 Thread via cfe-commits
@@ -132,3 +132,30 @@ bool f(); template void g(bool = (f() || ...)); } + + +namespace comparison_warning { + struct S { +bool operator<(const S&) const; +bool operator<(int) const; +bool operator==(const S&) const; + }; + + template + void f(T... ts) { +(v

[clang] [Clang] Warning as error for fold expressions over comparison operators (PR #136836)

2025-05-01 Thread Younan Zhang via cfe-commits
@@ -132,3 +132,30 @@ bool f(); template void g(bool = (f() || ...)); } + + +namespace comparison_warning { + struct S { +bool operator<(const S&) const; +bool operator<(int) const; +bool operator==(const S&) const; + }; + + template + void f(T... ts) { +(v

[clang] [Clang][CodeGen] Add workaround for old glibc `__PTR_ALIGN` macro (PR #137851)

2025-05-01 Thread Yingwei Zheng via cfe-commits
https://github.com/dtcxzyw updated https://github.com/llvm/llvm-project/pull/137851 >From f1db3a540ec1383451955efab62b64ed8d180349 Mon Sep 17 00:00:00 2001 From: Yingwei Zheng Date: Wed, 30 Apr 2025 01:26:41 +0800 Subject: [PATCH 1/5] [Clang][CodeGen] Check `isUnderlyingBasePointerConstantNull

[clang] [llvm] [clang] Add scoped enum support to `StreamingDiagnostic` (PR #138089)

2025-05-01 Thread LLVM Continuous Integration via cfe-commits
llvm-ci wrote: LLVM Buildbot has detected a new failure on builder `clangd-ubuntu-tsan` running on `clangd-ubuntu-clang` while building `clang,llvm` at step 5 "build-clangd-clangd-index-server-clangd-indexer". Full details are available at: https://lab.llvm.org/buildbot/#/builders/134/builds/

[clang] [CIR] Upstream cir.call with scalar arguments (PR #136810)

2025-05-01 Thread Sirui Mu via cfe-commits
https://github.com/Lancern updated https://github.com/llvm/llvm-project/pull/136810 >From e5e7bd931dd409546d04237bd61eab67d6ba6451 Mon Sep 17 00:00:00 2001 From: Sirui Mu Date: Fri, 2 May 2025 00:31:08 +0800 Subject: [PATCH] [CIR] Upstream cir.call with scalar arguments --- .../CIR/Dialect/Bu

[clang] [llvm] [mlir] [AMDGPU] Generalize global.load.lds to buffer fat pointers (PR #134911)

2025-05-01 Thread Matt Arsenault via cfe-commits
arsenm wrote: Close in favor of #137425? https://github.com/llvm/llvm-project/pull/134911 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [CIR] Upstream cir.call with scalar arguments (PR #136810)

2025-05-01 Thread Sirui Mu via cfe-commits
@@ -446,8 +446,31 @@ OpFoldResult cir::CastOp::fold(FoldAdaptor adaptor) { // CallOp //===--===// +mlir::Operation::operand_iterator cir::CallOp::arg_operand_begin() { + assert(!cir::MissingFeatures::opCallI

[clang] [CIR] Upstream cir.call with scalar arguments (PR #136810)

2025-05-01 Thread Sirui Mu via cfe-commits
@@ -21,9 +21,24 @@ let cppNamespace = "::cir" in { // The CIRCallOpInterface must be used instead of CallOpInterface when looking // at arguments and other bits of CallOp. This creates a level of abstraction // that's useful for handling indirect calls and other details.

[clang] [CIR] Upstream cir.call with scalar arguments (PR #136810)

2025-05-01 Thread Sirui Mu via cfe-commits
@@ -1516,6 +1520,41 @@ class CIR_CallOpBase extra_traits = []> !listconcat(extra_traits, [DeclareOpInterfaceMethods, DeclareOpInterfaceMethods])> { + let extraClassDeclaration = [{ +/// Get the argument operands to the c

[clang] [Clang][SYCL] Add initial set of Intel OffloadArch values (PR #138158)

2025-05-01 Thread Justin Cai via cfe-commits
https://github.com/jzc updated https://github.com/llvm/llvm-project/pull/138158 >From f1b0e2cbe8229ba00956e0eac58f97d71995b0dd Mon Sep 17 00:00:00 2001 From: "Cai, Justin" Date: Mon, 14 Apr 2025 21:30:39 + Subject: [PATCH 1/2] [Clang][SYCL] Add initial set of Intel OffloadArch values --- c

[clang] [CIR] Upstream cir.call with scalar arguments (PR #136810)

2025-05-01 Thread Sirui Mu via cfe-commits
Lancern wrote: Rebased onto the latest `main`. Will land later if no one have more comments. https://github.com/llvm/llvm-project/pull/136810 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-co

[clang] 334e05b - [nfc] Fix formatting in clang release notes (#138172)

2025-05-01 Thread via cfe-commits
Author: Alan Zhao Date: 2025-05-01T10:58:29-07:00 New Revision: 334e05b4b78a5de6efdcb23f208f3453a5b364a0 URL: https://github.com/llvm/llvm-project/commit/334e05b4b78a5de6efdcb23f208f3453a5b364a0 DIFF: https://github.com/llvm/llvm-project/commit/334e05b4b78a5de6efdcb23f208f3453a5b364a0.diff LOG

[clang] [nfc] Fix formatting in clang release notes (PR #138172)

2025-05-01 Thread Arthur Eubanks via cfe-commits
https://github.com/aeubanks approved this pull request. https://github.com/llvm/llvm-project/pull/138172 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [nfc] Fix formatting in clang release notes (PR #138172)

2025-05-01 Thread Alan Zhao via cfe-commits
https://github.com/alanzhao1 created https://github.com/llvm/llvm-project/pull/138172 `-ftime-report` was supposed to be an inline code section, which requires two backticks instead of one. >From da4f614cb810cb668c53ba1806802b8b01e4960b Mon Sep 17 00:00:00 2001 From: Alan Zhao Date: Thu, 1 Ma

[clang] [llvm] [mlir] [AMDGPU] Generalize global.load.lds to buffer fat pointers (PR #134911)

2025-05-01 Thread Krzysztof Drewniak via cfe-commits
krzysz00 wrote: Closing in favor of #137425 https://github.com/llvm/llvm-project/pull/134911 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [llvm] [mlir] [AMDGPU] Generalize global.load.lds to buffer fat pointers (PR #134911)

2025-05-01 Thread Krzysztof Drewniak via cfe-commits
https://github.com/krzysz00 closed https://github.com/llvm/llvm-project/pull/134911 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [OpenMP 6.0 ]Codegen for Reduction over private variables with reduction clause (PR #134709)

2025-05-01 Thread CHANDRA GHALE via cfe-commits
https://github.com/chandraghale updated https://github.com/llvm/llvm-project/pull/134709 >From a05af192052de8503fb4945bfb853b3f2c14e4c9 Mon Sep 17 00:00:00 2001 From: Chandra Ghale Date: Mon, 7 Apr 2025 13:58:25 -0500 Subject: [PATCH 1/6] Codegen for Reduction over private variables with reduc

[clang] [nfc] Fix formatting in clang release notes (PR #138172)

2025-05-01 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang Author: Alan Zhao (alanzhao1) Changes `-ftime-report` was supposed to be an inline code section, which requires two backticks instead of one. --- Full diff: https://github.com/llvm/llvm-project/pull/138172.diff 1 Files Affected: - (modified) c

[clang] [nfc] Fix formatting in clang release notes (PR #138172)

2025-05-01 Thread Alan Zhao via cfe-commits
https://github.com/alanzhao1 closed https://github.com/llvm/llvm-project/pull/138172 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [OpenMP 6.0 ]Codegen for Reduction over private variables with reduction clause (PR #134709)

2025-05-01 Thread CHANDRA GHALE via cfe-commits
https://github.com/chandraghale updated https://github.com/llvm/llvm-project/pull/134709 >From a05af192052de8503fb4945bfb853b3f2c14e4c9 Mon Sep 17 00:00:00 2001 From: Chandra Ghale Date: Mon, 7 Apr 2025 13:58:25 -0500 Subject: [PATCH 1/7] Codegen for Reduction over private variables with reduc

[clang] bc9aa0f - [C] Add -Wtentative-definition-compat (#137967)

2025-05-01 Thread via cfe-commits
Author: Aaron Ballman Date: 2025-05-01T07:31:48-04:00 New Revision: bc9aa0f4c4c6ad9dd6207097478f4e461a8fe5cb URL: https://github.com/llvm/llvm-project/commit/bc9aa0f4c4c6ad9dd6207097478f4e461a8fe5cb DIFF: https://github.com/llvm/llvm-project/commit/bc9aa0f4c4c6ad9dd6207097478f4e461a8fe5cb.diff

[clang] [C] Add -Wtentative-definition-compat (PR #137967)

2025-05-01 Thread Aaron Ballman via cfe-commits
https://github.com/AaronBallman closed https://github.com/llvm/llvm-project/pull/137967 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang-tools-extra] 212f245 - [include-cleaner] rename enabled flags to `disable-*` (#132991)

2025-05-01 Thread via cfe-commits
Author: Mohamed Emad Date: 2025-05-01T07:21:50-04:00 New Revision: 212f2456fcde822fad37bfa4e69ced1a51a4c19d URL: https://github.com/llvm/llvm-project/commit/212f2456fcde822fad37bfa4e69ced1a51a4c19d DIFF: https://github.com/llvm/llvm-project/commit/212f2456fcde822fad37bfa4e69ced1a51a4c19d.diff

[clang] [OpenMP 6.0 ]Codegen for Reduction over private variables with reduction clause (PR #134709)

2025-05-01 Thread CHANDRA GHALE via cfe-commits
chandraghale wrote: Refactored code to look up the expression and handle UDR, emitting it as is. updated the lit test. https://github.com/llvm/llvm-project/pull/134709 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi

[clang-tools-extra] [include-cleaner] rename enabled flags to `disable-*` (PR #132991)

2025-05-01 Thread Aaron Ballman via cfe-commits
https://github.com/AaronBallman closed https://github.com/llvm/llvm-project/pull/132991 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [llvm] [LLVM][Clang][Cygwin] Fix building Clang for Cygwin (PR #134494)

2025-05-01 Thread Mateusz Mikuła via cfe-commits
https://github.com/mati865 updated https://github.com/llvm/llvm-project/pull/134494 From b7a5fab29b810f72f2ffa65fb0945abd302c2411 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Mateusz=20Miku=C5=82a?= Date: Sat, 5 Apr 2025 13:18:35 +0200 Subject: [PATCH 1/4] [LLVM][Cygwin] Fix Signals compatibility w

[clang] 75d1cce - Add missing RUN lines to test

2025-05-01 Thread Aaron Ballman via cfe-commits
Author: Aaron Ballman Date: 2025-05-01T07:25:28-04:00 New Revision: 75d1cceb948666af9b2cb26fc3933d4176a2806d URL: https://github.com/llvm/llvm-project/commit/75d1cceb948666af9b2cb26fc3933d4176a2806d DIFF: https://github.com/llvm/llvm-project/commit/75d1cceb948666af9b2cb26fc3933d4176a2806d.diff

[clang] [llvm] [LLVM][Clang][Cygwin] Fix building Clang for Cygwin (PR #134494)

2025-05-01 Thread Mateusz Mikuła via cfe-commits
https://github.com/mati865 converted_to_draft https://github.com/llvm/llvm-project/pull/134494 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[libclc] [libclc] Support the generic address space (PR #137183)

2025-05-01 Thread Matt Arsenault via cfe-commits
@@ -23,4 +23,20 @@ #define _CLC_DEF __attribute__((always_inline)) #endif +#if __OPENCL_C_VERSION__ == CL_VERSION_2_0 || \ +(__OPENCL_C_VERSION__ >= CL_VERSION_3_0 && \ + defined(__opencl_c_generic_addr

[clang] [Clang][Cygwin] Fix symbol visibility definition (PR #138118)

2025-05-01 Thread Mateusz Mikuła via cfe-commits
https://github.com/mati865 created https://github.com/llvm/llvm-project/pull/138118 Currently building for Cygwin hits this error: ``` In file included from /h/projects/llvm-project/clang/lib/Basic/Attributes.cpp:17: /h/projects/llvm-project/clang/include/clang/Basic/ParsedAttrInfo.h:180:73: e

[clang] [flang] [llvm] [TargetVerifier][AMDGPU] Add TargetVerifier. (PR #123609)

2025-05-01 Thread via cfe-commits
https://github.com/jofrn updated https://github.com/llvm/llvm-project/pull/123609 Rate limit · GitHub body { background-color: #f6f8fa; color: #24292e; font-family: -apple-system,BlinkMacSystemFont,Segoe UI,Helvetica,Arial,sans-ser

[clang] [CIR] Upstream pointer arithmetic support (PR #138041)

2025-05-01 Thread Henrich Lauko via cfe-commits
https://github.com/xlauko approved this pull request. lgtm, besides Erich's comments https://github.com/llvm/llvm-project/pull/138041 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [CIR] Upstream pointer arithmetic support (PR #138041)

2025-05-01 Thread Henrich Lauko via cfe-commits
https://github.com/xlauko edited https://github.com/llvm/llvm-project/pull/138041 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [CIR] Upstream pointer arithmetic support (PR #138041)

2025-05-01 Thread Henrich Lauko via cfe-commits
@@ -185,6 +185,15 @@ class CIRGenBuilderTy : public cir::CIRBaseBuilderTy { } bool isInt(mlir::Type i) { return mlir::isa(i); } + // + // Constant creation helpers + // - + // + cir::ConstantOp getSInt32(int32_t c, mlir::Location loc) { +au

[clang] [Clang] Do not warn for serialized builtin or command-line definitions (PR #137306)

2025-05-01 Thread Juan Manuel Martinez Caamaño via cfe-commits
https://github.com/jmmartinez closed https://github.com/llvm/llvm-project/pull/137306 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Clang] Do not warn for serialized builtin or command-line definitions (PR #137306)

2025-05-01 Thread Juan Manuel Martinez Caamaño via cfe-commits
jmmartinez wrote: Thanks ! https://github.com/llvm/llvm-project/pull/137306 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] 0d3d2f6 - [Clang] Do not warn for serialized builtin or command-line definitions (#137306)

2025-05-01 Thread via cfe-commits
Author: Juan Manuel Martinez Caamaño Date: 2025-05-01T09:55:46+02:00 New Revision: 0d3d2f639c42b22fc1b9453c7b834dbb0f16c0dc URL: https://github.com/llvm/llvm-project/commit/0d3d2f639c42b22fc1b9453c7b834dbb0f16c0dc DIFF: https://github.com/llvm/llvm-project/commit/0d3d2f639c42b22fc1b9453c7b834db

[clang] [Clang][NFC] Use std::move to avoid copy (PR #138073)

2025-05-01 Thread via cfe-commits
https://github.com/cor3ntin approved this pull request. https://github.com/llvm/llvm-project/pull/138073 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Clang] Warning as error for fold expressions over comparison operators (PR #136836)

2025-05-01 Thread Younan Zhang via cfe-commits
https://github.com/zyn0217 approved this pull request. Okay, let's go ahead as is. Though I feel it's unfortunate that the warnings for left fold and right fold are scattered - maybe we could clean them up in future Thanks for working on this. https://github.com/llvm/llvm-project/pull/136836

[clang] [libclang/python] Add some logical typing changes. (PR #138074)

2025-05-01 Thread Jannick Kremer via cfe-commits
DeinAlptraum wrote: Which parts do you mean? The `__eq__` operators for other objects? https://github.com/llvm/llvm-project/pull/138074 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Clang][Cygwin] Fix symbol visibility definition (PR #138118)

2025-05-01 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang Author: Mateusz Mikuła (mati865) Changes Currently building for Cygwin hits this error: ``` In file included from /h/projects/llvm-project/clang/lib/Basic/Attributes.cpp:17: /h/projects/llvm-project/clang/include/clang/Basic/ParsedAttrInfo.h:180:7

[clang] [C] Add -Wjump-bypasses-init (PR #138009)

2025-05-01 Thread Eli Friedman via cfe-commits
https://github.com/efriedma-quic approved this pull request. Please add a test for the new indirect goto diagnostic. Otherwise LGTM https://github.com/llvm/llvm-project/pull/138009 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.

[clang] [llvm] [clang][amdgpu] Add builtins for raw/struct buffer lds load (PR #137678)

2025-05-01 Thread Krzysztof Drewniak via cfe-commits
krzysz00 wrote: > It does, we should have a consistent set of buffer builtins To specify what I _think_ the proposed rewrite is, it's auto-upgrading or otherwise transforming ```llvm %r = call T llvm.amdgcn.{raw,struct}.buffer.*(<4 x i32> %rsrc, ...) ``` into ```llvm %rsrc.int = bitcast <4 x i3

[clang-tools-extra] [llvm] [clang-doc] Adds a mustache backend (PR #133161)

2025-05-01 Thread Paul Kirth via cfe-commits
ilovepi wrote: @PeterChou1 I've uploaded a patch set w/ the relevant changes from this patch. Some of the details were split into standalone patches, but I'd appreciate if you could help both review and test those patches. It would also be nice if you could share any testing corpus or lit test

[clang] [Clang][OpenCL][AMDGPU] OpenCL Kernel stubs should be assigned alwaysinline attribute (PR #137769)

2025-05-01 Thread Matt Arsenault via cfe-commits
arsenm wrote: Apparently the inliner has an arbitrary size threshold even for single uses. I don't see the point of that, we should probably remove that https://github.com/llvm/llvm-project/pull/137769 ___ cfe-commits mailing list cfe-commits@lists.l

  1   2   3   4   5   6   >