[clang] 4aff3f6 - [clang][Interp] Fix assignment operator call eval order (#101845)

2024-08-04 Thread via cfe-commits
Author: Timm Baeder Date: 2024-08-04T09:23:58+02:00 New Revision: 4aff3f6967eba11aced705e2772f3ad86f2adeef URL: https://github.com/llvm/llvm-project/commit/4aff3f6967eba11aced705e2772f3ad86f2adeef DIFF: https://github.com/llvm/llvm-project/commit/4aff3f6967eba11aced705e2772f3ad86f2adeef.diff L

[clang] [clang][Interp] Fix assignment operator call eval order (PR #101845)

2024-08-04 Thread Timm Baeder via cfe-commits
https://github.com/tbaederr closed https://github.com/llvm/llvm-project/pull/101845 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang][Interp] Fix assignment operator call eval order (PR #101845)

2024-08-04 Thread Thorsten Schütt via cfe-commits
tschuett wrote: No review? https://github.com/llvm/llvm-project/pull/101845 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Clang][CodeGen] Add `[[clang::asm_dialect]]` attribute (PR #101871)

2024-08-04 Thread Mital Ashok via cfe-commits
https://github.com/MitalAshok created https://github.com/llvm/llvm-project/pull/101871 This attribute applies to `GCCAsmStmt` statements or functions. If a function is declared with this, it is effectively the default for all `GCCAsmStmt`s contained in the function. Takes one string argument:

[clang] [Clang][CodeGen] Add `[[clang::asm_dialect]]` attribute (PR #101871)

2024-08-04 Thread via cfe-commits
github-actions[bot] wrote: :warning: C/C++ code formatter, clang-format found issues in your code. :warning: You can test this locally with the following command: ``bash git-clang-format --diff d07fdf9779f7dead2828cfb18bafbd9a2c085920 2e544ca9628cdaa4ef8875494f2b5948c7623d21 --e

[clang] [Clang][CodeGen] Add `[[clang::asm_dialect]]` attribute (PR #101871)

2024-08-04 Thread Mital Ashok via cfe-commits
https://github.com/MitalAshok updated https://github.com/llvm/llvm-project/pull/101871 >From 321934e1fc59908cbcd7fac4992e2b85357899d4 Mon Sep 17 00:00:00 2001 From: Mital Ashok Date: Sun, 4 Aug 2024 09:09:19 +0100 Subject: [PATCH] [Clang][CodeGen] Add `[[clang::asm_dialect]]` attribute --- cl

[clang] [Clang] Remove __is_nullptr (PR #99038)

2024-08-04 Thread Nikolas Klauser via cfe-commits
https://github.com/philnik777 updated https://github.com/llvm/llvm-project/pull/99038 >From fbc9ebb3900e69f2485111cfdc6b7a7dfd3e6ebe Mon Sep 17 00:00:00 2001 From: Nikolas Klauser Date: Tue, 16 Jul 2024 14:53:30 +0200 Subject: [PATCH 1/2] [Clang] Remove __is_nullptr --- clang/docs/LanguageExt

[clang] eccc648 - [Clang] Remove __is_nullptr (#99038)

2024-08-04 Thread via cfe-commits
Author: Nikolas Klauser Date: 2024-08-04T10:34:04+02:00 New Revision: eccc6487c1fc5925ea2e595b5b07a31976c3232e URL: https://github.com/llvm/llvm-project/commit/eccc6487c1fc5925ea2e595b5b07a31976c3232e DIFF: https://github.com/llvm/llvm-project/commit/eccc6487c1fc5925ea2e595b5b07a31976c3232e.dif

[clang] [Clang] Remove __is_nullptr (PR #99038)

2024-08-04 Thread Nikolas Klauser via cfe-commits
https://github.com/philnik777 closed https://github.com/llvm/llvm-project/pull/99038 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [libcxx] Reapply "[Clang] Implement resolution for CWG1835 (#92957, #98547)" (PR #100425)

2024-08-04 Thread via cfe-commits
cor3ntin wrote: There is now https://cplusplus.github.io/CWG/issues/2920.html https://github.com/llvm/llvm-project/pull/100425 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Clang][CodeGen] Add `[[clang::asm_dialect]]` attribute (PR #101871)

2024-08-04 Thread Mital Ashok via cfe-commits
https://github.com/MitalAshok updated https://github.com/llvm/llvm-project/pull/101871 >From 7f8c82071c9cc324acd7f2a79539392e74838545 Mon Sep 17 00:00:00 2001 From: Mital Ashok Date: Sun, 4 Aug 2024 09:09:19 +0100 Subject: [PATCH] [Clang][CodeGen] Add `[[clang::asm_dialect]]` attribute --- cl

[clang] [llvm] [X86][AVX10.2] Support YMM rounding new instructions (PR #101825)

2024-08-04 Thread Shengchen Kan via cfe-commits
https://github.com/KanRobert approved this pull request. https://github.com/llvm/llvm-project/pull/101825 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Clang] Implement C++26’s P2893R3 ‘Variadic friends’ (PR #101448)

2024-08-04 Thread via cfe-commits
https://github.com/cor3ntin edited https://github.com/llvm/llvm-project/pull/101448 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Clang] Implement C++26’s P2893R3 ‘Variadic friends’ (PR #101448)

2024-08-04 Thread via cfe-commits
https://github.com/cor3ntin commented: Looks generally good from a cursory review. I think we want to add tests for modules / in the test/PCH directory. We probably want that as an extension indeed, no reason not to We probably want a separate PR to add the pack indexing macro. I did not add it

[clang] [Clang] Implement C++26’s P2893R3 ‘Variadic friends’ (PR #101448)

2024-08-04 Thread via cfe-commits
@@ -1442,8 +1442,49 @@ Decl *TemplateDeclInstantiator::VisitFriendDecl(FriendDecl *D) { if (D->isUnsupportedFriend()) { InstTy = Ty; } else { - InstTy = SemaRef.SubstType(Ty, TemplateArgs, - D->getLocation(), DeclarationName()

[libunwind] [libunwind] Add GCS support for AArch64 (PR #99335)

2024-08-04 Thread Tobias Hieta via cfe-commits
tru wrote: This seems to add a new feature, is it really relevant for a backport? https://github.com/llvm/llvm-project/pull/99335 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Clang][CodeGen] Add `[[clang::asm_dialect]]` attribute (PR #101871)

2024-08-04 Thread Mital Ashok via cfe-commits
https://github.com/MitalAshok updated https://github.com/llvm/llvm-project/pull/101871 >From 6dd98b5c255580909a9f38baa1bbdc257e5d60d2 Mon Sep 17 00:00:00 2001 From: Mital Ashok Date: Sun, 4 Aug 2024 09:09:19 +0100 Subject: [PATCH] [Clang][CodeGen] Add `[[clang::asm_dialect]]` attribute --- cl

[clang] [clang] Implement `__builtin_is_implicit_lifetime()` (PR #101807)

2024-08-04 Thread via cfe-commits
https://github.com/cor3ntin commented: Generally looks good but can you add tests for non aggregate with non elligible constructors and destructors ? (ie a class template with `requires false` on various destructor/constructor?) (or better yet a class template that takes a bool NTTP aso you can

[clang] [Clang] strengthen checks for 'main' function to meet [basic.start.main] p2 requirements (PR #101853)

2024-08-04 Thread Mital Ashok via cfe-commits
@@ -990,6 +990,9 @@ def warn_main_redefined : Warning<"variable named 'main' with external linkage " "has undefined behavior">, InGroup; def ext_main_used : Extension< "referring to 'main' within an expression is a Clang extension">, InGroup; +def err_invalid_linkage_

[clang] [Clang] strengthen checks for 'main' function to meet [basic.start.main] p2 requirements (PR #101853)

2024-08-04 Thread Mital Ashok via cfe-commits
@@ -0,0 +1,29 @@ +// RUN: %clang_cc1 -fsyntax-only -verify -pedantic-errors %s + +namespace c { + extern "C" void main(); // expected-error {{invalid linkage specification 'extern "C"'}} +} +extern "C" { + int main(); // expected-error {{invalid linkage specification 'extern "C

[clang] [Clang] SFINAE on mismatching pack length during constraint satisfaction checking (PR #101879)

2024-08-04 Thread via cfe-commits
https://github.com/cor3ntin created https://github.com/llvm/llvm-project/pull/101879 If a fold expanded constraint would expand packs of different size, it is not a valid pack expansion and it is not satisfied. This should not produce an error. Fixes #99430 >From 665047d94935c71230322bb4a5951

[clang] [Clang] SFINAE on mismatching pack length during constraint satisfaction checking (PR #101879)

2024-08-04 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang Author: cor3ntin (cor3ntin) Changes If a fold expanded constraint would expand packs of different size, it is not a valid pack expansion and it is not satisfied. This should not produce an error. Fixes #99430 --- Full diff: https://github.com/ll

[clang] [Clang] SFINAE on mismatching pack length during constraint satisfaction checking (PR #101879)

2024-08-04 Thread via cfe-commits
cor3ntin wrote: The intent is for this to be backported to 19 (therefore no changelog) https://github.com/llvm/llvm-project/pull/101879 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang] concepts: perform parameter mapping substitution in correct context (PR #101745)

2024-08-04 Thread via cfe-commits
https://github.com/cor3ntin approved this pull request. LGTM, thanks! Do we want to backport to clang 19? that seems reasonable https://github.com/llvm/llvm-project/pull/101745 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.

[clang] [clang] Implement `__builtin_is_implicit_lifetime()` (PR #101807)

2024-08-04 Thread Mital Ashok via cfe-commits
@@ -5637,6 +5638,27 @@ static bool EvaluateUnaryTypeTrait(Sema &Self, TypeTrait UTT, return false; case UTT_IsTriviallyEqualityComparable: return isTriviallyEqualityComparableType(Self, T, KeyLoc); + case UTT_IsImplicitLifetime: { +DiagnoseVLAInCXXTypeTrait(Self

[clang] [clang] Implement `__builtin_is_implicit_lifetime()` (PR #101807)

2024-08-04 Thread Mital Ashok via cfe-commits
@@ -5637,6 +5638,27 @@ static bool EvaluateUnaryTypeTrait(Sema &Self, TypeTrait UTT, return false; case UTT_IsTriviallyEqualityComparable: return isTriviallyEqualityComparableType(Self, T, KeyLoc); + case UTT_IsImplicitLifetime: { +DiagnoseVLAInCXXTypeTrait(Self

[clang] [clang] Implement `__builtin_is_implicit_lifetime()` (PR #101807)

2024-08-04 Thread Mital Ashok via cfe-commits
@@ -86,6 +86,9 @@ C++23 Feature Support C++2c Feature Support ^ +- Add ``__builtin_is_implicit_lifetime`` intrinsic, which supports MitalAshok wrote: Why is this called `__builtin_is_implicit_lifetime` instead of `__is_implicit_lifetime`

[clang] [clang] Implement `__builtin_is_implicit_lifetime()` (PR #101807)

2024-08-04 Thread Mital Ashok via cfe-commits
@@ -5637,6 +5638,27 @@ static bool EvaluateUnaryTypeTrait(Sema &Self, TypeTrait UTT, return false; case UTT_IsTriviallyEqualityComparable: return isTriviallyEqualityComparableType(Self, T, KeyLoc); + case UTT_IsImplicitLifetime: { +DiagnoseVLAInCXXTypeTrait(Self

[clang] [clang] Implement `__builtin_is_implicit_lifetime()` (PR #101807)

2024-08-04 Thread via cfe-commits
@@ -86,6 +86,9 @@ C++23 Feature Support C++2c Feature Support ^ +- Add ``__builtin_is_implicit_lifetime`` intrinsic, which supports cor3ntin wrote: CF https://github.com/llvm/llvm-project/issues/98310#issuecomment-2248326726 https://githu

[clang] [Clang] SFINAE on mismatching pack length during constraint satisfaction checking (PR #101879)

2024-08-04 Thread Vlad Serebrennikov via cfe-commits
https://github.com/Endilll commented: LGTM https://github.com/llvm/llvm-project/pull/101879 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Clang] SFINAE on mismatching pack length during constraint satisfaction checking (PR #101879)

2024-08-04 Thread Vlad Serebrennikov via cfe-commits
Endilll wrote: > The intent is for this to be backported to 19 (therefore no changelog) Yes, this is very important to backport. https://github.com/llvm/llvm-project/pull/101879 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llv

[clang] [clang-tools-extra] [clangd] show lambda name instead of operator() in signature help (PR #101857)

2024-08-04 Thread Vlad Serebrennikov via cfe-commits
https://github.com/Endilll commented: `Sema.h` changes LGTM https://github.com/llvm/llvm-project/pull/101857 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang] Implement `__builtin_is_implicit_lifetime()` (PR #101807)

2024-08-04 Thread Vlad Serebrennikov via cfe-commits
@@ -86,6 +86,9 @@ C++23 Feature Support C++2c Feature Support ^ +- Add ``__builtin_is_implicit_lifetime`` intrinsic, which supports Endilll wrote: See #98310 https://github.com/llvm/llvm-project/pull/101807 ___

[clang] [llvm] [LV] Support generating masks for switch terminators. (PR #99808)

2024-08-04 Thread Florian Hahn via cfe-commits
@@ -7842,6 +7853,61 @@ VPValue *VPRecipeBuilder::createEdgeMask(BasicBlock *Src, BasicBlock *Dst) { VPValue *SrcMask = getBlockInMask(Src); + if (auto *SI = dyn_cast(Src->getTerminator())) { +assert(!OrigLoop->isLoopExiting(Src) && + all_of(successors(Src),

[clang] [llvm] [LV] Support generating masks for switch terminators. (PR #99808)

2024-08-04 Thread Florian Hahn via cfe-commits
@@ -7842,6 +7853,61 @@ VPValue *VPRecipeBuilder::createEdgeMask(BasicBlock *Src, BasicBlock *Dst) { VPValue *SrcMask = getBlockInMask(Src); + if (auto *SI = dyn_cast(Src->getTerminator())) { +assert(!OrigLoop->isLoopExiting(Src) && + all_of(successors(Src),

[clang] [llvm] [LV] Support generating masks for switch terminators. (PR #99808)

2024-08-04 Thread Florian Hahn via cfe-commits
@@ -7842,6 +7853,61 @@ VPValue *VPRecipeBuilder::createEdgeMask(BasicBlock *Src, BasicBlock *Dst) { VPValue *SrcMask = getBlockInMask(Src); + if (auto *SI = dyn_cast(Src->getTerminator())) { +assert(!OrigLoop->isLoopExiting(Src) && + all_of(successors(Src),

[clang] [llvm] [LV] Support generating masks for switch terminators. (PR #99808)

2024-08-04 Thread Florian Hahn via cfe-commits
@@ -7842,6 +7853,61 @@ VPValue *VPRecipeBuilder::createEdgeMask(BasicBlock *Src, BasicBlock *Dst) { VPValue *SrcMask = getBlockInMask(Src); + if (auto *SI = dyn_cast(Src->getTerminator())) { +assert(!OrigLoop->isLoopExiting(Src) && + all_of(successors(Src),

[clang] [llvm] [LV] Support generating masks for switch terminators. (PR #99808)

2024-08-04 Thread Florian Hahn via cfe-commits
@@ -7842,6 +7853,61 @@ VPValue *VPRecipeBuilder::createEdgeMask(BasicBlock *Src, BasicBlock *Dst) { VPValue *SrcMask = getBlockInMask(Src); + if (auto *SI = dyn_cast(Src->getTerminator())) { +assert(!OrigLoop->isLoopExiting(Src) && + all_of(successors(Src),

[clang] [clang-format] Add PackParameters enum option to replace BinPackParameters. (PR #101882)

2024-08-04 Thread via cfe-commits
https://github.com/VolatileAcorn created https://github.com/llvm/llvm-project/pull/101882 Deprecated the BinPackParameters boolean option in favor or PackParameters enum option in order to provide a BreakAlways setting. Related issues that have requested this feature #51833 #23796 #53190 Part

[clang] [clang-format] Add PackParameters enum option to replace BinPackParameters. (PR #101882)

2024-08-04 Thread via cfe-commits
github-actions[bot] wrote: Thank you for submitting a Pull Request (PR) to the LLVM Project! This PR will be automatically labeled and the relevant teams will be notified. If you wish to, you can add reviewers by using the "Reviewers" section on this page. If this is not working for you, it

[clang] [clang-format] Add PackParameters enum option to replace BinPackParameters. (PR #101882)

2024-08-04 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang Author: None (VolatileAcorn) Changes Deprecated the BinPackParameters boolean option in favor or PackParameters enum option in order to provide a BreakAlways setting. Related issues that have requested this feature #51833 #23796 #53190 Partially

[libunwind] [libunwind] Add GCS support for AArch64 (PR #99335)

2024-08-04 Thread John Brawn via cfe-commits
john-brawn-arm wrote: > LGTM. Sorry for the delay. > > Q: Is there a way to play with the GCS feature in a VM? Do you have setup > instructions? https://git.yoctoproject.org/meta-arm/log/?h=testing/gcs is a demonstration embedded linux that support GCS, including an emulator capable of runnin

[libunwind] [libunwind] Add GCS support for AArch64 (PR #99335)

2024-08-04 Thread John Brawn via cfe-commits
https://github.com/john-brawn-arm updated https://github.com/llvm/llvm-project/pull/99335 >From e0f71863bd2f797c9208bdfc559bb69ade5a653a Mon Sep 17 00:00:00 2001 From: John Brawn Date: Wed, 17 Jul 2024 15:18:46 +0100 Subject: [PATCH 1/4] [libunwind] Add GCS support for AArch64 AArch64 GCS (Gua

[libunwind] b32aac4 - [libunwind] Add GCS support for AArch64 (#99335)

2024-08-04 Thread via cfe-commits
Author: John Brawn Date: 2024-08-04T13:27:12+01:00 New Revision: b32aac4358c1f6639de7c453656cd74fbab75d71 URL: https://github.com/llvm/llvm-project/commit/b32aac4358c1f6639de7c453656cd74fbab75d71 DIFF: https://github.com/llvm/llvm-project/commit/b32aac4358c1f6639de7c453656cd74fbab75d71.diff LO

[libunwind] [libunwind] Add GCS support for AArch64 (PR #99335)

2024-08-04 Thread John Brawn via cfe-commits
https://github.com/john-brawn-arm closed https://github.com/llvm/llvm-project/pull/99335 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[libunwind] [libunwind] Add GCS support for AArch64 (PR #99335)

2024-08-04 Thread John Brawn via cfe-commits
john-brawn-arm wrote: > This seems to add a new feature, is it really relevant for a backport? This is the last piece of work to enable GCS in the LLVM toolchain (clang and lld support went in a while ago), and I was hoping to get everything in to LLVM 19. It would be rather annoying to have t

[clang] [clang] concepts: perform parameter mapping substitution in correct context (PR #101745)

2024-08-04 Thread Matheus Izvekov via cfe-commits
mizvekov wrote: I think this is simple enough that we could backport. https://github.com/llvm/llvm-project/pull/101745 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[libunwind] [libunwind] Add GCS support for AArch64 (PR #99335)

2024-08-04 Thread John Brawn via cfe-commits
john-brawn-arm wrote: /cherry-pick b32aac4358c1f6639de7c453656cd74fbab75d71 https://github.com/llvm/llvm-project/pull/99335 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[libunwind] [libunwind] Add GCS support for AArch64 (PR #99335)

2024-08-04 Thread via cfe-commits
llvmbot wrote: /pull-request llvm/llvm-project#101888 https://github.com/llvm/llvm-project/pull/99335 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [llvm] [X86][AVX10.2] Support YMM rounding new instructions (PR #101825)

2024-08-04 Thread Phoebe Wang via cfe-commits
https://github.com/phoebewang closed https://github.com/llvm/llvm-project/pull/101825 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang][Interp] Fix assignment operator call eval order (PR #101845)

2024-08-04 Thread Timm Baeder via cfe-commits
tbaederr wrote: I have post-review powers for changes in `Interp/`. https://github.com/llvm/llvm-project/pull/101845 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Clang][Sema][OpenMP] Allow `num_teams` to accept multiple expressions (PR #99732)

2024-08-04 Thread Johannes Doerfert via cfe-commits
@@ -11357,8 +11358,13 @@ void OMPClauseReader::VisitOMPAllocateClause(OMPAllocateClause *C) { void OMPClauseReader::VisitOMPNumTeamsClause(OMPNumTeamsClause *C) { VisitOMPClauseWithPreInit(C); - C->setNumTeams(Record.readSubExpr()); C->setLParenLoc(Record.readSourceLoca

[clang] [Clang][Sema][OpenMP] Allow `num_teams` to accept multiple expressions (PR #99732)

2024-08-04 Thread Johannes Doerfert via cfe-commits
https://github.com/jdoerfert edited https://github.com/llvm/llvm-project/pull/99732 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Clang][Sema][OpenMP] Allow `num_teams` to accept multiple expressions (PR #99732)

2024-08-04 Thread Johannes Doerfert via cfe-commits
https://github.com/jdoerfert commented: I think this is almost ready. Only missing thing is the >3 argument check and test. https://github.com/llvm/llvm-project/pull/99732 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/

[clang] [Clang][Sema][OpenMP] Allow `num_teams` to accept multiple expressions (PR #99732)

2024-08-04 Thread Johannes Doerfert via cfe-commits
@@ -11639,6 +11639,7 @@ def warn_omp_unterminated_declare_target : Warning< InGroup; def err_ompx_bare_no_grid : Error< "'ompx_bare' clauses requires explicit grid size via 'num_teams' and 'thread_limit' clauses">; +def err_omp_multi_expr_not_allowed: Error<"only one expre

[clang] [Clang][Sema][OpenMP] Allow `num_teams` to accept multiple expressions (PR #99732)

2024-08-04 Thread Johannes Doerfert via cfe-commits
@@ -13004,13 +13004,34 @@ StmtResult SemaOpenMP::ActOnOpenMPTargetUpdateDirective( Clauses, AStmt); } +// This checks whether num_teams clause only has one expression. +static bool checkNumTeamsClauseSingleExpr(SemaBase &SemaRef,

[clang] [clang] Construct SmallVector with ArrayRef (NFC) (PR #101898)

2024-08-04 Thread Kazu Hirata via cfe-commits
https://github.com/kazutakahirata created https://github.com/llvm/llvm-project/pull/101898 None >From 55a8255278f68b66aa532d2923f7dc3ada28a340 Mon Sep 17 00:00:00 2001 From: Kazu Hirata Date: Sun, 4 Aug 2024 10:19:51 -0700 Subject: [PATCH] [clang] Construct SmallVector with ArrayRef (NFC) ---

[clang] [clang] Construct SmallVector with ArrayRef (NFC) (PR #101898)

2024-08-04 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang Author: Kazu Hirata (kazutakahirata) Changes --- Full diff: https://github.com/llvm/llvm-project/pull/101898.diff 17 Files Affected: - (modified) clang/include/clang/AST/ASTConcept.h (+2-3) - (modified) clang/include/clang/Index/DeclOccurrenc

[clang] [clang] Construct SmallVector with ArrayRef (NFC) (PR #101898)

2024-08-04 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang-codegen @llvm/pr-subscribers-clang-modules @llvm/pr-subscribers-clang-format Author: Kazu Hirata (kazutakahirata) Changes --- Full diff: https://github.com/llvm/llvm-project/pull/101898.diff 17 Files Affected: - (modified) clang/include/clang/

[clang] [RISCV] Allow YAML file to control multilib selection (PR #98856)

2024-08-04 Thread Sam Elliott via cfe-commits
@@ -258,6 +259,13 @@ static void getARMMultilibFlags(const Driver &D, } } +static void getRISCVMultilibFlags(const Driver &D, const llvm::Triple &Triple, + const llvm::opt::ArgList &Args, + Multilib::flags_lis

[clang] [clang-format] Add PackParameters enum option to replace BinPackParameters. (PR #101882)

2024-08-04 Thread Björn Schäpers via cfe-commits
@@ -1918,11 +1901,12 @@ void ContinuationIndenter::moveStatePastScopeOpener(LineState &State, // for backwards compatibility. bool ObjCBinPackProtocolList = (Style.ObjCBinPackProtocolList == FormatStyle::BPS_Auto && - Style.BinPackParameters) || +

[clang] [clang-format] Add PackParameters enum option to replace BinPackParameters. (PR #101882)

2024-08-04 Thread Björn Schäpers via cfe-commits
@@ -1918,11 +1901,12 @@ void ContinuationIndenter::moveStatePastScopeOpener(LineState &State, // for backwards compatibility. bool ObjCBinPackProtocolList = (Style.ObjCBinPackProtocolList == FormatStyle::BPS_Auto && - Style.BinPackParameters) || +

[clang] [clang-format] Add PackParameters enum option to replace BinPackParameters. (PR #101882)

2024-08-04 Thread Björn Schäpers via cfe-commits
@@ -1174,6 +1192,18 @@ template <> struct MappingTraits { Style.PackConstructorInitializers = FormatStyle::PCIS_CurrentLine; } +// If BinPackParameters was specified but PackParameters was not, initialize +// the latter from the former for backwards compat

[clang] [clang-format] Add PackParameters enum option to replace BinPackParameters. (PR #101882)

2024-08-04 Thread Björn Schäpers via cfe-commits
@@ -5458,6 +5458,14 @@ bool TokenAnnotator::mustBreakBefore(const AnnotatedLine &Line, return true; } + // Ignores the first parameter as this will be handled separately by + // BreakFunctionDefinitionParameters or AlignAfterOpenBracket. + if ((FormatStyle::PPS_Break

[clang] [clang-format] Add PackParameters enum option to replace BinPackParameters. (PR #101882)

2024-08-04 Thread Björn Schäpers via cfe-commits
@@ -456,6 +455,21 @@ TEST(ConfigParseTest, ParsesConfiguration) { "AllowAllConstructorInitializersOnNextLine: false", PackConstructorInitializers, FormatStyle::PCIS_CurrentLine); + Style.PackParameters = FormatStyle::PPS_BinPack; + CHECK_PARSE("Pa

[clang] [clang-format] Add PackParameters enum option to replace BinPackParameters. (PR #101882)

2024-08-04 Thread Björn Schäpers via cfe-commits
@@ -1174,6 +1192,18 @@ template <> struct MappingTraits { Style.PackConstructorInitializers = FormatStyle::PCIS_CurrentLine; } +// If BinPackParameters was specified but PackParameters was not, initialize +// the latter from the former for backwards compat

[clang] [clang-format] Add PackParameters enum option to replace BinPackParameters. (PR #101882)

2024-08-04 Thread Björn Schäpers via cfe-commits
@@ -411,7 +393,8 @@ bool ContinuationIndenter::mustBreak(const LineState &State) { // sets BreakBeforeParameter to avoid bin packing and this creates a // completely unnecessary line break after a template type that isn't // line-wrapped. -(Prev

[clang] [clang][Interp] reinterpret casts aren't always fatal (PR #101900)

2024-08-04 Thread Timm Baeder via cfe-commits
https://github.com/tbaederr created https://github.com/llvm/llvm-project/pull/101900 The current interpreter emits the diagnostic and continues, so do the same. >From c10fedb826c41c2f640814428d996b8bfd3f2867 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Timm=20B=C3=A4der?= Date: Sun, 4 Aug 2024 19:

[clang] [clang][Interp] reinterpret casts aren't always fatal (PR #101900)

2024-08-04 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang Author: Timm Baeder (tbaederr) Changes The current interpreter emits the diagnostic and continues, so do the same. --- Full diff: https://github.com/llvm/llvm-project/pull/101900.diff 4 Files Affected: - (modified) clang/lib/AST/Interp/Compiler

[libunwind] [libunwind] Add GCS support for AArch64 (PR #99335)

2024-08-04 Thread Nico Weber via cfe-commits
nico wrote: Looks like this breaks building on Android: https://ci.chromium.org/ui/p/chromium/builders/try/android-arm64-rel/680348/overview https://github.com/llvm/llvm-project/pull/99335 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https:

[clang] [llvm] Partialmaptype (PR #101903)

2024-08-04 Thread via cfe-commits
https://github.com/jyu2-git created https://github.com/llvm/llvm-project/pull/101903 None >From 1a1cb6b459688a7e0a7f22c2b4a32dbe8cae77cc Mon Sep 17 00:00:00 2001 From: Jennifer Yu Date: Fri, 2 Aug 2024 17:41:24 -0700 Subject: [PATCH 1/2] Test faild with amd. Add unspport. This is relate #101

[clang] [clang-format] Add PackParameters enum option to replace BinPackParameters. (PR #101882)

2024-08-04 Thread via cfe-commits
https://github.com/VolatileAcorn updated https://github.com/llvm/llvm-project/pull/101882 >From 923a4ef21edf87c004d8940202331f204e8a8d83 Mon Sep 17 00:00:00 2001 From: Tom Pottage Date: Fri, 2 Aug 2024 20:26:47 +0100 Subject: [PATCH] [clang-format] Add PackParameters option to replace BinPackP

[clang] [Clang][Sema][OpenMP] Allow `num_teams` to accept multiple expressions (PR #99732)

2024-08-04 Thread Shilei Tian via cfe-commits
@@ -11357,8 +11358,13 @@ void OMPClauseReader::VisitOMPAllocateClause(OMPAllocateClause *C) { void OMPClauseReader::VisitOMPNumTeamsClause(OMPNumTeamsClause *C) { VisitOMPClauseWithPreInit(C); - C->setNumTeams(Record.readSubExpr()); C->setLParenLoc(Record.readSourceLoca

[clang] [Clang][Sema][OpenMP] Allow `num_teams` to accept multiple expressions (PR #99732)

2024-08-04 Thread Shilei Tian via cfe-commits
@@ -13004,13 +13004,34 @@ StmtResult SemaOpenMP::ActOnOpenMPTargetUpdateDirective( Clauses, AStmt); } +// This checks whether num_teams clause only has one expression. +static bool checkNumTeamsClauseSingleExpr(SemaBase &SemaRef,

[clang] [Clang][Sema][OpenMP] Allow `num_teams` to accept multiple expressions (PR #99732)

2024-08-04 Thread Shilei Tian via cfe-commits
https://github.com/shiltian edited https://github.com/llvm/llvm-project/pull/99732 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Clang] strengthen checks for 'main' function to meet [basic.start.main] p2 requirements (PR #101853)

2024-08-04 Thread Oleksandr T. via cfe-commits
https://github.com/a-tarasyuk updated https://github.com/llvm/llvm-project/pull/101853 >From 3f8050482f54138c8a836e67e45131d5e9ccf5cc Mon Sep 17 00:00:00 2001 From: Oleksandr T Date: Sun, 4 Aug 2024 00:45:49 +0300 Subject: [PATCH] [Clang] strengthen checks for 'main' function to meet [basic.st

[clang] [clang] concepts: perform parameter mapping substitution in correct context (PR #101745)

2024-08-04 Thread Matheus Izvekov via cfe-commits
https://github.com/mizvekov updated https://github.com/llvm/llvm-project/pull/101745 >From 56c022ef412d311a82a34ae2add05457e53d31ec Mon Sep 17 00:00:00 2001 From: Matheus Izvekov Date: Fri, 2 Aug 2024 16:53:11 -0300 Subject: [PATCH] [clang] concepts: perform parameter mapping subsitution in co

[clang] [clang-format] Add PackParameters enum option to replace BinPackParameters. (PR #101882)

2024-08-04 Thread via cfe-commits
https://github.com/mydeveloperday commented: Why change the name? https://github.com/llvm/llvm-project/pull/101882 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Clang] strengthen checks for 'main' function to meet [basic.start.main] p2 requirements (PR #101853)

2024-08-04 Thread Oleksandr T. via cfe-commits
https://github.com/a-tarasyuk ready_for_review https://github.com/llvm/llvm-project/pull/101853 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Clang] strengthen checks for 'main' function to meet [basic.start.main] p2 requirements (PR #101853)

2024-08-04 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang Author: Oleksandr T. (a-tarasyuk) Changes Fixes #101512 --- Full diff: https://github.com/llvm/llvm-project/pull/101853.diff 8 Files Affected: - (modified) clang/docs/ReleaseNotes.rst (+2) - (modified) clang/include/clang/AST/DeclBase.h (+2)

[clang] [Clang] strengthen checks for 'main' function to meet [basic.start.main] p2 requirements (PR #101853)

2024-08-04 Thread Oleksandr T. via cfe-commits
@@ -990,6 +990,9 @@ def warn_main_redefined : Warning<"variable named 'main' with external linkage " "has undefined behavior">, InGroup; def ext_main_used : Extension< "referring to 'main' within an expression is a Clang extension">, InGroup; +def err_invalid_linkage_

[clang] [Clang] strengthen checks for 'main' function to meet [basic.start.main] p2 requirements (PR #101853)

2024-08-04 Thread Oleksandr T. via cfe-commits
@@ -0,0 +1,29 @@ +// RUN: %clang_cc1 -fsyntax-only -verify -pedantic-errors %s + +namespace c { + extern "C" void main(); // expected-error {{invalid linkage specification 'extern "C"'}} +} +extern "C" { + int main(); // expected-error {{invalid linkage specification 'extern "C

[clang] [clang-format] Add PackParameters enum option to replace BinPackParameters. (PR #101882)

2024-08-04 Thread via cfe-commits
VolatileAcorn wrote: Sorry, I incorrectly assumed that I needed to create a new option if I was changing an option from a bool to an enum. I can change this back to have the same name and add the true / false cases to the enumeration parsing function. https://github.com/llvm/llvm-project/pull/

[clang] [clang] concepts: perform parameter mapping substitution in correct context (PR #101745)

2024-08-04 Thread Matheus Izvekov via cfe-commits
https://github.com/mizvekov closed https://github.com/llvm/llvm-project/pull/101745 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] 9e9d98a - [clang] concepts: perform parameter mapping substitution in correct context (#101745)

2024-08-04 Thread via cfe-commits
Author: Matheus Izvekov Date: 2024-08-04T19:00:54-03:00 New Revision: 9e9d98aaf503171e2cb229e89966ec1c0adf3804 URL: https://github.com/llvm/llvm-project/commit/9e9d98aaf503171e2cb229e89966ec1c0adf3804 DIFF: https://github.com/llvm/llvm-project/commit/9e9d98aaf503171e2cb229e89966ec1c0adf3804.dif

[clang] [clang] remove unneeded template deduction canonicalizations (PR #101594)

2024-08-04 Thread Matheus Izvekov via cfe-commits
https://github.com/mizvekov edited https://github.com/llvm/llvm-project/pull/101594 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang] remove unneeded template deduction canonicalizations (PR #101594)

2024-08-04 Thread Matheus Izvekov via cfe-commits
https://github.com/mizvekov updated https://github.com/llvm/llvm-project/pull/101594 >From fd9bdcc17821be3d22e0787759cbdd6b077dbd90 Mon Sep 17 00:00:00 2001 From: Matheus Izvekov Date: Thu, 1 Aug 2024 19:18:52 -0300 Subject: [PATCH] [clang] remove unneeded template deduction canonicalizations

[clang-tools-extra] [clangd] support the zig c++ compiler wrapper (PR #100759)

2024-08-04 Thread via cfe-commits
duk-37 wrote: This is a simple and nice change. Improving the developer experience and having things "just work" is always good. https://github.com/llvm/llvm-project/pull/100759 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llv

[clang] 8a26c6d - [clang] remove unneeded template deduction canonicalizations (#101594)

2024-08-04 Thread via cfe-commits
Author: Matheus Izvekov Date: 2024-08-04T19:47:02-03:00 New Revision: 8a26c6d9d4ca18b9906f3ec13d52fc0b2952a5f7 URL: https://github.com/llvm/llvm-project/commit/8a26c6d9d4ca18b9906f3ec13d52fc0b2952a5f7 DIFF: https://github.com/llvm/llvm-project/commit/8a26c6d9d4ca18b9906f3ec13d52fc0b2952a5f7.dif

[clang] [clang] remove unneeded template deduction canonicalizations (PR #101594)

2024-08-04 Thread Matheus Izvekov via cfe-commits
https://github.com/mizvekov closed https://github.com/llvm/llvm-project/pull/101594 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [libcxx] [clang] Reland: Instantiate concepts with sugared template arguments (PR #101782)

2024-08-04 Thread Matheus Izvekov via cfe-commits
https://github.com/mizvekov edited https://github.com/llvm/llvm-project/pull/101782 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [libcxx] [clang] Reland: Instantiate concepts with sugared template arguments (PR #101782)

2024-08-04 Thread Matheus Izvekov via cfe-commits
https://github.com/mizvekov updated https://github.com/llvm/llvm-project/pull/101782 >From 6a172a93121fdbeb0e58b33ec3140f150ecb524a Mon Sep 17 00:00:00 2001 From: Matheus Izvekov Date: Sun, 23 Oct 2022 11:37:20 +0200 Subject: [PATCH] [clang] Reland: Instantiate concepts with sugared template a

[clang] [Fuchsia][CMake] Check correct triple to set -mcpu (PR #101910)

2024-08-04 Thread Petr Hosek via cfe-commits
https://github.com/petrhosek created https://github.com/llvm/llvm-project/pull/101910 We use armv8m.main-none-eabi now, not armv8m.main-unknown-eabi. >From e039c097f997cb95f2f3725c4efa6420c8ed48c0 Mon Sep 17 00:00:00 2001 From: Petr Hosek Date: Sun, 4 Aug 2024 16:30:35 -0700 Subject: [PATCH] [

[clang] [Fuchsia][CMake] Check correct triple to set -mcpu (PR #101910)

2024-08-04 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang Author: Petr Hosek (petrhosek) Changes We use armv8m.main-none-eabi now, not armv8m.main-unknown-eabi. --- Full diff: https://github.com/llvm/llvm-project/pull/101910.diff 1 Files Affected: - (modified) clang/cmake/caches/Fuchsia-stage2.cmake (

[clang] [Fuchsia][CMake] Check correct triple to set -mcpu (PR #101910)

2024-08-04 Thread via cfe-commits
https://github.com/PiJoules approved this pull request. https://github.com/llvm/llvm-project/pull/101910 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] 22c06aa - [Fuchsia][CMake] Check correct triple to set -mcpu (#101910)

2024-08-04 Thread via cfe-commits
Author: Petr Hosek Date: 2024-08-04T16:35:56-07:00 New Revision: 22c06aa5e94e30fb1333ecaf46ce33c65d148634 URL: https://github.com/llvm/llvm-project/commit/22c06aa5e94e30fb1333ecaf46ce33c65d148634 DIFF: https://github.com/llvm/llvm-project/commit/22c06aa5e94e30fb1333ecaf46ce33c65d148634.diff LO

[clang] [Fuchsia][CMake] Check correct triple to set -mcpu (PR #101910)

2024-08-04 Thread Petr Hosek via cfe-commits
https://github.com/petrhosek closed https://github.com/llvm/llvm-project/pull/101910 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [libcxx] [clang] Reland: Instantiate concepts with sugared template arguments (PR #101782)

2024-08-04 Thread Matheus Izvekov via cfe-commits
mizvekov wrote: Since this is relanding of patch that has been previously reviewed, with no notable changes except rebase and canonicalization when indexing the satisfaction cache, I am going to go ahead and merge. https://github.com/llvm/llvm-project/pull/101782 __

[clang] 7483711 - [clang] Reland: Instantiate concepts with sugared template arguments (#101782)

2024-08-04 Thread via cfe-commits
Author: Matheus Izvekov Date: 2024-08-04T22:11:11-03:00 New Revision: 748371183ae769bfb485f1e7466a864bf1db93d5 URL: https://github.com/llvm/llvm-project/commit/748371183ae769bfb485f1e7466a864bf1db93d5 DIFF: https://github.com/llvm/llvm-project/commit/748371183ae769bfb485f1e7466a864bf1db93d5.dif

[clang] [libcxx] [clang] Reland: Instantiate concepts with sugared template arguments (PR #101782)

2024-08-04 Thread Matheus Izvekov via cfe-commits
https://github.com/mizvekov closed https://github.com/llvm/llvm-project/pull/101782 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

  1   2   >