[clang] [Cygwin] Cygwin driver (PR #74933)

2023-12-13 Thread Martin Storsjö via cfe-commits
mstorsjo wrote: > > @carlo-bramini has spent some effort on using Clang in Cygwin environments > > before, so as far as I know, it does work in general from before. So this > > change, which adds an entirely new driver for Cygwin environments, would > > need to be explained why it does that (I

[clang] [CMake] Include opt-viewer in Fuchsia toolchain (PR #75296)

2023-12-13 Thread Petr Hosek via cfe-commits
https://github.com/petrhosek created https://github.com/llvm/llvm-project/pull/75296 This is necessary for visualization of optimization remarks. >From a35caa1369eabff183eb192fd4ad7566e55c8ea6 Mon Sep 17 00:00:00 2001 From: Petr Hosek Date: Wed, 13 Dec 2023 08:03:37 + Subject: [PATCH] [CMa

[clang] [CMake] Include opt-viewer in Fuchsia toolchain (PR #75296)

2023-12-13 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang Author: Petr Hosek (petrhosek) Changes This is necessary for visualization of optimization remarks. --- Full diff: https://github.com/llvm/llvm-project/pull/75296.diff 1 Files Affected: - (modified) clang/cmake/caches/Fuchsia-stage2.cmake (+1)

[clang] [clang] Add per-global code model attribute (PR #72078)

2023-12-13 Thread via cfe-commits
https://github.com/heiher updated https://github.com/llvm/llvm-project/pull/72078 >From e3863873ab817dacf8680763bb42d91f005fe5ea Mon Sep 17 00:00:00 2001 From: WANG Rui Date: Fri, 10 Nov 2023 21:07:48 -0600 Subject: [PATCH 1/7] [clang] Add per-global code model attribute This patch adds a per-

[clang] [clang] Add per-global code model attribute (PR #72078)

2023-12-13 Thread via cfe-commits
@@ -3408,6 +3408,8 @@ def warn_objc_redundant_literal_use : Warning< def err_attr_tlsmodel_arg : Error<"tls_model must be \"global-dynamic\", " "\"local-dynamic\", \"initial-exec\" or \"local-exec\"">; +def err_attr_codemodel_arg : Error<"code_model '%0' is not yet supported

[clang] [clang] Parse attribute [[gnu::no_stack_protector]] (PR #75289)

2023-12-13 Thread Yingchi Long via cfe-commits
https://github.com/inclyc requested changes to this pull request. The PR contains functional change so please add test & assertions under `clang/test` https://github.com/llvm/llvm-project/pull/75289 ___ cfe-commits mailing list cfe-commits@lists.llvm.

[clang] [clang] Add per-global code model attribute (PR #72078)

2023-12-13 Thread WÁNG Xuěruì via cfe-commits
https://github.com/xen0n commented: Overall this seems fine, thanks! But I'm not sure if reporting a more generic "the model attribute is not supported on this target" for non-LoongArch would be better: it doesn't give the false impression that the target doesn't support the specified code mod

[clang] [clang] Add per-global code model attribute (PR #72078)

2023-12-13 Thread WÁNG Xuěruì via cfe-commits
@@ -3408,6 +3408,8 @@ def warn_objc_redundant_literal_use : Warning< def err_attr_tlsmodel_arg : Error<"tls_model must be \"global-dynamic\", " "\"local-dynamic\", \"initial-exec\" or \"local-exec\"">; +def err_attr_codemodel_arg : Error<"code_model '%0' is not supported on

[clang] [clang] Add per-global code model attribute (PR #72078)

2023-12-13 Thread WÁNG Xuěruì via cfe-commits
https://github.com/xen0n edited https://github.com/llvm/llvm-project/pull/72078 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[llvm] [clang] [RISCV] Add MC layer support for Zicfiss. (PR #66043)

2023-12-13 Thread Yeting Kuo via cfe-commits
https://github.com/yetingk updated https://github.com/llvm/llvm-project/pull/66043 >From 01222b781e3a0a925d2cdf793c54c7d6050f82af Mon Sep 17 00:00:00 2001 From: Yeting Kuo Date: Tue, 12 Sep 2023 12:28:00 +0800 Subject: [PATCH] [RISCV] Add MC layer support for Zicfiss. The patch adds the instru

[clang] [RISCV][RFC] BareMetal multilibs YAML usage (PR #75191)

2023-12-13 Thread Petr Hosek via cfe-commits
petrhosek wrote: Regarding `-f[no-]exceptions` handling, see https://discourse.llvm.org/t/rfc-multilib/67494/32. https://github.com/llvm/llvm-project/pull/75191 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mai

[flang] [lldb] [clang-tools-extra] [clang] [mlir] [llvm] [compiler-rt] [Profile] Add binary profile correlation for code coverage. (PR #69493)

2023-12-13 Thread Petr Hosek via cfe-commits
https://github.com/petrhosek approved this pull request. https://github.com/llvm/llvm-project/pull/69493 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang] Add per-global code model attribute (PR #72078)

2023-12-13 Thread via cfe-commits
https://github.com/heiher updated https://github.com/llvm/llvm-project/pull/72078 >From e3863873ab817dacf8680763bb42d91f005fe5ea Mon Sep 17 00:00:00 2001 From: WANG Rui Date: Fri, 10 Nov 2023 21:07:48 -0600 Subject: [PATCH 1/8] [clang] Add per-global code model attribute This patch adds a per-

[clang] [clang] Add per-global code model attribute (PR #72078)

2023-12-13 Thread via cfe-commits
@@ -3408,6 +3408,8 @@ def warn_objc_redundant_literal_use : Warning< def err_attr_tlsmodel_arg : Error<"tls_model must be \"global-dynamic\", " "\"local-dynamic\", \"initial-exec\" or \"local-exec\"">; +def err_attr_codemodel_arg : Error<"code_model '%0' is not supported on

[clang] [clang][ASTImporter] skip TemplateTypeParmDecl in VisitTypeAliasTemplateDecl (PR #74919)

2023-12-13 Thread Qizhi Hu via cfe-commits
jcsxky wrote: > The `VisitTypeAliasTemplateDecl` function should be re-designed to check for > structural equivalence at import. The following test does not pass because an > existing `TypeAliasTemplateDecl` declaration with the same name is always > found and returned, without check for struc

[clang] [llvm] [RISCV] Add MC layer support for Zicfiss. (PR #66043)

2023-12-13 Thread Yeting Kuo via cfe-commits
yetingk wrote: Rebase and ping. https://github.com/llvm/llvm-project/pull/66043 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang] Add per-global code model attribute (PR #72078)

2023-12-13 Thread via cfe-commits
https://github.com/heiher updated https://github.com/llvm/llvm-project/pull/72078 >From e3863873ab817dacf8680763bb42d91f005fe5ea Mon Sep 17 00:00:00 2001 From: WANG Rui Date: Fri, 10 Nov 2023 21:07:48 -0600 Subject: [PATCH 1/9] [clang] Add per-global code model attribute This patch adds a per-

[clang] [Clang][SVE2.1] Make a part of the name optional for `svwhileXX` builtins with predicate-as-counter (PR #75200)

2023-12-13 Thread via cfe-commits
@@ -1950,19 +1950,17 @@ let TargetGuard = "sve2p1|sme2" in { //FIXME: Replace IsStreamingCompatible with IsStreamingOrHasSVE2p1 when available def SVPEXT_SINGLE : SInst<"svpext_lane_{d}", "P}i", "QcQsQiQl", MergeNone, "aarch64_sve_pext", [IsStreamingCompatible], [ImmCheck<1, I

[clang] [clang] Add per-global code model attribute (PR #72078)

2023-12-13 Thread via cfe-commits
heiher wrote: > Overall this seems fine, thanks! > > But I'm not sure if reporting a more generic "the model attribute is not > supported on this target" for non-LoongArch would be better: it doesn't give > the false impression that the target doesn't support the specified code model. In my o

[clang] ed2d497 - [Clang][AArch64] Add fix vector types to header into SVE (#73258)

2023-12-13 Thread via cfe-commits
Author: CarolineConcatto Date: 2023-12-13T08:59:41Z New Revision: ed2d497291f0de330e27109ce21375b41597b4a4 URL: https://github.com/llvm/llvm-project/commit/ed2d497291f0de330e27109ce21375b41597b4a4 DIFF: https://github.com/llvm/llvm-project/commit/ed2d497291f0de330e27109ce21375b41597b4a4.diff L

[clang] [llvm] [clang-tools-extra] [Clang][AArch64] Add fix vector types to header into SVE (PR #73258)

2023-12-13 Thread via cfe-commits
https://github.com/CarolineConcatto closed https://github.com/llvm/llvm-project/pull/73258 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang][Interp] Don't diagnose undefined functions when checking... (PR #75051)

2023-12-13 Thread via cfe-commits
https://github.com/cor3ntin edited https://github.com/llvm/llvm-project/pull/75051 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang][Interp] Don't diagnose undefined functions when checking... (PR #75051)

2023-12-13 Thread via cfe-commits
https://github.com/cor3ntin approved this pull request. LGTM modulo typo https://github.com/llvm/llvm-project/pull/75051 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang][Interp] Don't diagnose undefined functions when checking... (PR #75051)

2023-12-13 Thread via cfe-commits
@@ -371,13 +366,21 @@ bool CheckCallable(InterpState &S, CodePtr OpPC, const Function *F) { // FIXME: If DiagDecl is an implicitly-declared special member function // or an inheriting constructor, we should be much more explicit about why // it's not constex

[clang] [clang][ASTImporter] Import AlignValueAttr correctly. (PR #75308)

2023-12-13 Thread Balázs Kéri via cfe-commits
https://github.com/balazske created https://github.com/llvm/llvm-project/pull/75308 Expression of attribute `align_value` was not imported. Import of the attribute is corrected, a test for it is added, other related tests with FIXME are updated. Fixes #75054. From 2e6fe315bdebea705d84b4152a83

[clang] [clang][ASTImporter] Import AlignValueAttr correctly. (PR #75308)

2023-12-13 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang Author: Balázs Kéri (balazske) Changes Expression of attribute `align_value` was not imported. Import of the attribute is corrected, a test for it is added, other related tests with FIXME are updated. Fixes #75054. --- Full diff: https://github.

[clang] [Clang] Eagerly instantiate used constexpr function upon definition. (PR #73463)

2023-12-13 Thread Sam McCall via cfe-commits
@@ -4836,6 +4837,16 @@ ASTFileSignature ASTWriter::WriteASTCore(Sema &SemaRef, StringRef isysroot, assert(SemaRef.PendingLocalImplicitInstantiations.empty() && "There are local ones at end of translation unit!"); + // Build a record containing all pending instanti

[clang] [OpenACC] Add 'clause' parsing infrastructure plus a few clauses (PR #75052)

2023-12-13 Thread via cfe-commits
@@ -69,6 +69,29 @@ OpenACCDirectiveKindEx getOpenACCDirectiveKind(Token Tok) { .Default(OpenACCDirectiveKindEx::Invalid); } +// Translate single-token string representations to the OpenCC Clause Kind. +OpenACCClauseKind getOpenACCClauseKind(Token Tok) { + // auto is a k

[clang] [OpenACC] Add 'clause' parsing infrastructure plus a few clauses (PR #75052)

2023-12-13 Thread via cfe-commits
@@ -208,6 +233,10 @@ OpenACCDirectiveKind ParseOpenACCDirectiveKind(Parser &P) { // introspect on the spelling before then. if (FirstTok.isNot(tok::identifier)) { P.Diag(FirstTok, diag::err_acc_missing_directive); + +if (!FirstTok.isAnnotation()) + P.ConsumeAny

[clang] [OpenACC] Add 'clause' parsing infrastructure plus a few clauses (PR #75052)

2023-12-13 Thread via cfe-commits
@@ -262,12 +291,52 @@ OpenACCDirectiveKind ParseOpenACCDirectiveKind(Parser &P) { return DirKind; } +bool ParseOpenACCClause(Parser &P) { cor3ntin wrote: Can you add a description of the grammar? https://github.com/llvm/llvm-project/pull/75052 ___

[clang] [OpenACC] Add 'clause' parsing infrastructure plus a few clauses (PR #75052)

2023-12-13 Thread via cfe-commits
@@ -69,6 +69,29 @@ OpenACCDirectiveKindEx getOpenACCDirectiveKind(Token Tok) { .Default(OpenACCDirectiveKindEx::Invalid); } +// Translate single-token string representations to the OpenCC Clause Kind. +OpenACCClauseKind getOpenACCClauseKind(Token Tok) {

[clang] [clang][ASTImporter] skip TemplateTypeParmDecl in VisitTypeAliasTemplateDecl (PR #74919)

2023-12-13 Thread Qizhi Hu via cfe-commits
jcsxky wrote: > The problem may be related to the fact that template parameter declarations > can have the `TranslationUnitDecl` as parent until the template (with these > parameters) is finally created. In the temporary phase the object > (`TemplateTypeParmDecl`) is found with lookup if it ha

[clang] [AArch64][SME] Warn when using a streaming builtin from a non-streaming function (PR #74064)

2023-12-13 Thread Sander de Smalen via cfe-commits
@@ -1694,6 +1697,61 @@ void SVEEmitter::createSMERangeChecks(raw_ostream &OS) { OS << "#endif\n\n"; } +void SVEEmitter::createStreamingAttrs(raw_ostream &OS, ACLEKind Kind) { + std::vector RV = Records.getAllDerivedDefinitions("Inst"); + SmallVector, 128> Defs; + for (aut

[clang] [AArch64][SME] Warn when using a streaming builtin from a non-streaming function (PR #74064)

2023-12-13 Thread Sander de Smalen via cfe-commits
@@ -3168,9 +3167,60 @@ static void checkArmStreamingBuiltin(Sema &S, CallExpr *TheCall, << TheCall->getSourceRange() << "streaming compatible"; return; } + + if (FnType == ArmNonStreaming && BuiltinType == ArmStreaming) { +S.Diag(TheCall->getBeginLoc(), dia

[clang] [AArch64][SME] Warn when using a streaming builtin from a non-streaming function (PR #74064)

2023-12-13 Thread Sander de Smalen via cfe-commits
@@ -3168,9 +3167,60 @@ static void checkArmStreamingBuiltin(Sema &S, CallExpr *TheCall, << TheCall->getSourceRange() << "streaming compatible"; return; } + + if (FnType == ArmNonStreaming && BuiltinType == ArmStreaming) { +S.Diag(TheCall->getBeginLoc(), dia

[clang] d36f72b - [clang][Sema][NFC] Add a boolean parameter comment

2023-12-13 Thread Timm Bäder via cfe-commits
Author: Timm Bäder Date: 2023-12-13T11:11:39+01:00 New Revision: d36f72b4187c3d934fd0558d174ad0c5ecafe140 URL: https://github.com/llvm/llvm-project/commit/d36f72b4187c3d934fd0558d174ad0c5ecafe140 DIFF: https://github.com/llvm/llvm-project/commit/d36f72b4187c3d934fd0558d174ad0c5ecafe140.diff LO

[clang] [clang][Interp] Don't diagnose undefined functions when checking... (PR #75051)

2023-12-13 Thread Timm Baeder via cfe-commits
https://github.com/tbaederr updated https://github.com/llvm/llvm-project/pull/75051 >From b98a9d3a203bbcf56e81c7be7e2c011088095713 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Timm=20B=C3=A4der?= Date: Mon, 11 Dec 2023 15:08:32 +0100 Subject: [PATCH] [clang][Interp] Don't diagnose undefined functio

[llvm] [clang] [ValueTracking] Add dominating condition support in computeKnownBits() (PR #73662)

2023-12-13 Thread Nikita Popov via cfe-commits
nikic wrote: @eddyz87 Right, this is exactly the change I have been working on, see https://github.com/llvm/llvm-project/pull/75311. Unfortunately, it doesn't actually fix the BPF case, because that one involves a loop, and LVI is currently terrible at handling those. (Basically, even though t

[llvm] [clang] [LVI] Support using block values when handling conditions (PR #75311)

2023-12-13 Thread Nikita Popov via cfe-commits
https://github.com/nikic updated https://github.com/llvm/llvm-project/pull/75311 >From 0b4f9e03bf84ffc0a24bc609879c96db9b1d2833 Mon Sep 17 00:00:00 2001 From: Nikita Popov Date: Tue, 12 Dec 2023 15:55:29 +0100 Subject: [PATCH 1/2] [LVI] Support using block values when handling conditions Curren

[llvm] [clang] [LVI] Support using block values when handling conditions (PR #75311)

2023-12-13 Thread Nikita Popov via cfe-commits
https://github.com/nikic edited https://github.com/llvm/llvm-project/pull/75311 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang][ASTImporter] skip TemplateTypeParmDecl in VisitTypeAliasTemplateDecl (PR #74919)

2023-12-13 Thread Balázs Kéri via cfe-commits
balazske wrote: `VisitTypeAliasTemplateDecl` looks wrong and some fix should be made, this PR is good for the fix. This import function is different from the others because `ConflictingDecls` is populated when an object with different type is found, but this is the correct way. I think that `T

[clang] [llvm] [lld] [mlir] [libcxx] [compiler-rt] [lldb] [libc] [clang-tools-extra] [MLIR][LLVM] Add Continuous Loop Peeling transform to SCF (PR #71555)

2023-12-13 Thread via cfe-commits
https://github.com/muneebkhan85 updated https://github.com/llvm/llvm-project/pull/71555 >From 7bb2f9793b2a2cccbaa401f6e2ac850b587f2b59 Mon Sep 17 00:00:00 2001 From: Muneeb Khan Date: Tue, 7 Nov 2023 23:52:17 +0800 Subject: [PATCH 1/7] [MLIR][LLVM] Add Continuous Loop Peeling transform to SCF

[clang] effd47e - [Clang][AArch64] Add REQUIRES to new test

2023-12-13 Thread Jay Foad via cfe-commits
Author: Jay Foad Date: 2023-12-13T10:49:52Z New Revision: effd47ed45e3badd756103346a7c3b9e1e939e5e URL: https://github.com/llvm/llvm-project/commit/effd47ed45e3badd756103346a7c3b9e1e939e5e DIFF: https://github.com/llvm/llvm-project/commit/effd47ed45e3badd756103346a7c3b9e1e939e5e.diff LOG: [Cla

[llvm] [clang] [clang-tools-extra] [Clang][AArch64] Add fix vector types to header into SVE (PR #73258)

2023-12-13 Thread Jay Foad via cfe-commits
@@ -0,0 +1,134 @@ +// NOTE: Assertions have been autogenerated by utils/update_cc_test_checks.py UTC_ARGS: --version 3 + +// RUN: %clang_cc1 -DSVE_HEADER -triple aarch64 -target-feature +sve -emit-llvm -O2 -o - %s | opt -S -passes=mem2reg,sroa | FileCheck %s +// RUN: %clang_cc1

[clang] [clang][dataflow] Strengthen pointer comparison. (PR #75170)

2023-12-13 Thread via cfe-commits
https://github.com/martinboehme updated https://github.com/llvm/llvm-project/pull/75170 >From 32fe6eb51c43e423e50178509a8020d392cd3a42 Mon Sep 17 00:00:00 2001 From: Martin Braenne Date: Wed, 13 Dec 2023 10:46:43 + Subject: [PATCH 1/2] [clang][dataflow] Strengthen pointer comparison. - In

[clang] [clang][dataflow] Strengthen pointer comparison. (PR #75170)

2023-12-13 Thread via cfe-commits
@@ -3893,6 +3893,66 @@ TEST(TransferTest, BooleanInequality) { }); } +TEST(TransferTest, PointerEquality) { martinboehme wrote: Good point -- done. https://github.com/llvm/llvm-project/pull/75170 ___ cfe-comm

[clang] [clang][dataflow] Strengthen pointer comparison. (PR #75170)

2023-12-13 Thread via cfe-commits
@@ -152,6 +153,47 @@ TEST_F(EnvironmentTest, JoinRecords) { } } +TEST_F(EnvironmentTest, DifferentReferenceLocInJoin) { martinboehme wrote: Agree. The original test case was minimized from a failing assertion, but it would likely be fiddly to try and recre

[clang] [clang][dataflow] Strengthen pointer comparison. (PR #75170)

2023-12-13 Thread via cfe-commits
martinboehme wrote: > An alternative approach would be to do [hash > consing](https://en.wikipedia.org/wiki/Hash_consing). Since pointer values > are completely determined by the pointee (for some definition of the pointee, > e.g., we might have `void*` and `int*` pointers pointing to the same

[clang] [llvm] [clang-tools-extra] [Clang][AArch64] Add fix vector types to header into SVE (PR #73258)

2023-12-13 Thread via cfe-commits
@@ -0,0 +1,134 @@ +// NOTE: Assertions have been autogenerated by utils/update_cc_test_checks.py UTC_ARGS: --version 3 + +// RUN: %clang_cc1 -DSVE_HEADER -triple aarch64 -target-feature +sve -emit-llvm -O2 -o - %s | opt -S -passes=mem2reg,sroa | FileCheck %s +// RUN: %clang_cc1

[lld] [clang-tools-extra] [lldb] [libcxx] [mlir] [openmp] [flang] [libcxxabi] [clang] [llvm] [libc] [compiler-rt] [libc++] Fix `take_view::__sentinel`'s `operator==` (PR #74655)

2023-12-13 Thread via cfe-commits
huixie90 wrote: Hi, could you please apply clang-format to the lines you changed and I am going to merge it after that https://github.com/llvm/llvm-project/pull/74655 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-b

[clang] a897700 - [clang][Interp] Don't diagnose undefined functions when checking... (#75051)

2023-12-13 Thread via cfe-commits
Author: Timm Baeder Date: 2023-12-13T12:14:53+01:00 New Revision: a8977005b64986139e92b5a43e44cfac2bf81677 URL: https://github.com/llvm/llvm-project/commit/a8977005b64986139e92b5a43e44cfac2bf81677 DIFF: https://github.com/llvm/llvm-project/commit/a8977005b64986139e92b5a43e44cfac2bf81677.diff L

[clang] [clang][Interp] Don't diagnose undefined functions when checking... (PR #75051)

2023-12-13 Thread Timm Baeder via cfe-commits
https://github.com/tbaederr closed https://github.com/llvm/llvm-project/pull/75051 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [AArch64][SME] Warn when using a streaming builtin from a non-streaming function (PR #74064)

2023-12-13 Thread Sam Tebbs via cfe-commits
@@ -1694,6 +1697,61 @@ void SVEEmitter::createSMERangeChecks(raw_ostream &OS) { OS << "#endif\n\n"; } +void SVEEmitter::createStreamingAttrs(raw_ostream &OS, ACLEKind Kind) { + std::vector RV = Records.getAllDerivedDefinitions("Inst"); + SmallVector, 128> Defs; + for (aut

[clang] [AArch64][SME] Warn when using a streaming builtin from a non-streaming function (PR #74064)

2023-12-13 Thread Sam Tebbs via cfe-commits
@@ -3168,9 +3167,60 @@ static void checkArmStreamingBuiltin(Sema &S, CallExpr *TheCall, << TheCall->getSourceRange() << "streaming compatible"; return; } + + if (FnType == ArmNonStreaming && BuiltinType == ArmStreaming) { +S.Diag(TheCall->getBeginLoc(), dia

[clang] [llvm] [clang-tools-extra] [AArch64] Add an AArch64 pass for loop idiom transformations (PR #72273)

2023-12-13 Thread David Green via cfe-commits
@@ -0,0 +1,839 @@ +//===- AArch64LoopIdiomTransform.cpp - Loop idiom recognition -===// +// +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. +// See https://llvm.org/LICENSE.txt for license information. +// SPDX-License-Identifier: Ap

[clang] [clang-tools-extra] [llvm] [AArch64] Add an AArch64 pass for loop idiom transformations (PR #72273)

2023-12-13 Thread David Green via cfe-commits
@@ -0,0 +1,839 @@ +//===- AArch64LoopIdiomTransform.cpp - Loop idiom recognition -===// +// +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. +// See https://llvm.org/LICENSE.txt for license information. +// SPDX-License-Identifier: Ap

[clang-tools-extra] [clang] [llvm] [AArch64] Add an AArch64 pass for loop idiom transformations (PR #72273)

2023-12-13 Thread David Green via cfe-commits
@@ -0,0 +1,839 @@ +//===- AArch64LoopIdiomTransform.cpp - Loop idiom recognition -===// +// +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. +// See https://llvm.org/LICENSE.txt for license information. +// SPDX-License-Identifier: Ap

[clang] [llvm] [clang-tools-extra] [AArch64] Add an AArch64 pass for loop idiom transformations (PR #72273)

2023-12-13 Thread David Green via cfe-commits
@@ -0,0 +1,839 @@ +//===- AArch64LoopIdiomTransform.cpp - Loop idiom recognition -===// +// +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. +// See https://llvm.org/LICENSE.txt for license information. +// SPDX-License-Identifier: Ap

[clang-tools-extra] [clang] [llvm] [AArch64] Add an AArch64 pass for loop idiom transformations (PR #72273)

2023-12-13 Thread David Green via cfe-commits
@@ -0,0 +1,839 @@ +//===- AArch64LoopIdiomTransform.cpp - Loop idiom recognition -===// +// +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. +// See https://llvm.org/LICENSE.txt for license information. +// SPDX-License-Identifier: Ap

[llvm] [clang] [clang-tools-extra] [AArch64] Add an AArch64 pass for loop idiom transformations (PR #72273)

2023-12-13 Thread David Green via cfe-commits
@@ -0,0 +1,839 @@ +//===- AArch64LoopIdiomTransform.cpp - Loop idiom recognition -===// +// +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. +// See https://llvm.org/LICENSE.txt for license information. +// SPDX-License-Identifier: Ap

[llvm] [clang] [ValueTracking] Add dominating condition support in computeKnownBits() (PR #73662)

2023-12-13 Thread via cfe-commits
joanahalili wrote: heads-up, we are seeing some performance regressions due to this patch 8about 6-7%! We will add more details about this soon. https://github.com/llvm/llvm-project/pull/73662 ___ cfe-commits mailing list cfe-commits@lists.llvm.org ht

[llvm] [clang] [clang-tools-extra] [Clang][AArch64] Add fix vector types to header into SVE (PR #73258)

2023-12-13 Thread David Spickett via cfe-commits
DavidSpickett wrote: I think this caused a test suite program to fail to build: ``` cd /home/tcwg-buildbot/worker/clang-aarch64-global-isel/test/sandbox/build/SingleSource/UnitTests && /home/tcwg-buildbot/worker/clang-aarch64-global-isel/stage1.install/bin/llvm-size --format=sysv /home/tcwg-

[llvm] [clang] [AMDGPU] Add an option to disable unsafe uses of atomic xor (PR #69229)

2023-12-13 Thread Pierre-Andre Saulais via cfe-commits
https://github.com/pasaulais edited https://github.com/llvm/llvm-project/pull/69229 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[llvm] [clang] [clang-tools-extra] [Clang][AArch64] Add fix vector types to header into SVE (PR #73258)

2023-12-13 Thread David Spickett via cfe-commits
DavidSpickett wrote: Actually this may be https://github.com/llvm/llvm-test-suite/pull/59, which landed in the test suite just now as well, but is not listed as a change there (which is a known issue with buildbot). https://github.com/llvm/llvm-project/pull/73258 __

[clang] [AArch64][SME2] Add SQRSHRN, UQRSHRN, SQRSHRUN builtins for SME2, SVE2p1 (PR #75325)

2023-12-13 Thread Dinar Temirbulatov via cfe-commits
https://github.com/dtemirbulatov created https://github.com/llvm/llvm-project/pull/75325 Add SQRSHRN, UQRSHRN, SQRSHRUN builtins for SME2, SVE2p1. >From 83d1e213a5dce7621f8f87668a4ab1f15306fc5b Mon Sep 17 00:00:00 2001 From: Dinar Temirbulatov Date: Wed, 13 Dec 2023 11:28:06 + Subject: [PA

[clang] [AArch64][SME2] Add SQRSHRN, UQRSHRN, SQRSHRUN builtins for SME2, SVE2p1 (PR #75325)

2023-12-13 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang Author: Dinar Temirbulatov (dtemirbulatov) Changes Add SQRSHRN, UQRSHRN, SQRSHRUN builtins for SME2, SVE2p1. --- Full diff: https://github.com/llvm/llvm-project/pull/75325.diff 2 Files Affected: - (modified) clang/include/clang/Basic/arm_sve.td

[clang-tools-extra] [flang] [llvm] [libc] [libunwind] [lldb] [openmp] [libcxxabi] [libcxx] [mlir] [compiler-rt] [clang] [lld] [C23] Implement N3018: The constexpr specifier for object definitions (PR

2023-12-13 Thread Mariya Podchishchaeva via cfe-commits
Fznamznon wrote: Adding more reviewers since Aaron is on vacation... https://github.com/llvm/llvm-project/pull/73099 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [AArch64][SME2] Add builtins for SQDMULH (PR #75326)

2023-12-13 Thread Dinar Temirbulatov via cfe-commits
https://github.com/dtemirbulatov created https://github.com/llvm/llvm-project/pull/75326 Patch by: Kerry McLaughlin >From 2b0d280b59e244600ebc4b8373ab5494b88942df Mon Sep 17 00:00:00 2001 From: Dinar Temirbulatov Date: Wed, 13 Dec 2023 12:00:11 + Subject: [PATCH] [AArch64][SME2] Add built

[clang] [AArch64][SME2] Add builtins for SQDMULH (PR #75326)

2023-12-13 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang Author: Dinar Temirbulatov (dtemirbulatov) Changes Patch by: Kerry McLaughlin --- Patch is 66.51 KiB, truncated to 20.00 KiB below, full version: https://github.com/llvm/llvm-project/pull/75326.diff 2 Files Affected:

[clang] [llvm] [clang][RISCV] Change default abi with f extension but without d extension (PR #73489)

2023-12-13 Thread Alex Bradbury via cfe-commits
https://github.com/asb approved this pull request. LGTM https://github.com/llvm/llvm-project/pull/73489 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[openmp] [clang-tools-extra] [libcxx] [mlir] [clang] [compiler-rt] [lldb] [llvm] [libcxxabi] [flang] [MachineCopyPropagation] When the source of PreviousCopy is undef, we cannot replace sub register (

2023-12-13 Thread David Green via cfe-commits
davemgreen wrote: Thanks. It sounds like there are not a lot of code changes, which is a good sign. I didn't expect the debug problems though. I'll try and take a look at the patch. Perhaps you are right that we need a new method for the debug info to use. https://github.com/llvm/llvm-project

[clang] [libc] [flang] [openmp] [mlir] [libcxx] [llvm] [lld] [libcxxabi] [compiler-rt] [clang-tools-extra] [lldb] [libc++] Fix `take_view::__sentinel`'s `operator==` (PR #74655)

2023-12-13 Thread Jakub Mazurkiewicz via cfe-commits
https://github.com/JMazurkiewicz updated https://github.com/llvm/llvm-project/pull/74655 >From b3de573887cdd86fd6ce168bdcc6d729d73b13b2 Mon Sep 17 00:00:00 2001 From: Jakub Mazurkiewicz Date: Wed, 6 Dec 2023 14:03:51 +0100 Subject: [PATCH 01/12] [libc++] Fix `take_view::__sentinel`'s `operator=

[clang] [clang-format] Fix parsing of `operator<() {}` (PR #75144)

2023-12-13 Thread via cfe-commits
https://github.com/XDeme updated https://github.com/llvm/llvm-project/pull/75144 >From dddc20d967498c739baedb8d67303a28596f09e0 Mon Sep 17 00:00:00 2001 From: XDeme Date: Tue, 12 Dec 2023 03:06:56 -0300 Subject: [PATCH 1/3] Fix operator<() parsing --- clang/lib/Format/TokenAnnotator.cpp

[clang] [clang] Report narrowing conversions with const references (PR #75332)

2023-12-13 Thread Mariya Podchishchaeva via cfe-commits
https://github.com/Fznamznon created https://github.com/llvm/llvm-project/pull/75332 Fixes https://github.com/llvm/llvm-project/issues/63151 >From d0a7276eb8014693656d3d931616d56ffe46730c Mon Sep 17 00:00:00 2001 From: "Podchishchaeva, Mariya" Date: Wed, 13 Dec 2023 04:25:12 -0800 Subject: [PA

[clang] [clang] Report narrowing conversions with const references (PR #75332)

2023-12-13 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang Author: Mariya Podchishchaeva (Fznamznon) Changes Fixes https://github.com/llvm/llvm-project/issues/63151 --- Full diff: https://github.com/llvm/llvm-project/pull/75332.diff 3 Files Affected: - (modified) clang/docs/ReleaseNotes.rst (+3) - (mo

[clang] ab380c2 - [SystemZ][z/OS] Complete EBCDIC I/O support (#75212)

2023-12-13 Thread via cfe-commits
Author: Abhina Sree Date: 2023-12-13T07:46:02-05:00 New Revision: ab380c287a42c0701cd86ae2932c0cb125b9a294 URL: https://github.com/llvm/llvm-project/commit/ab380c287a42c0701cd86ae2932c0cb125b9a294 DIFF: https://github.com/llvm/llvm-project/commit/ab380c287a42c0701cd86ae2932c0cb125b9a294.diff L

[clang] [llvm] [SystemZ][z/OS] Complete EBCDIC I/O support (PR #75212)

2023-12-13 Thread Abhina Sree via cfe-commits
https://github.com/abhina-sree closed https://github.com/llvm/llvm-project/pull/75212 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang] Report narrowing conversions with const references (PR #75332)

2023-12-13 Thread via cfe-commits
github-actions[bot] wrote: :warning: C/C++ code formatter, clang-format found issues in your code. :warning: You can test this locally with the following command: ``bash git-clang-format --diff e418988175c2dee9d7c7976cf822b41aaf321c26 d0a7276eb8014693656d3d931616d56ffe46730c --

[clang] [clang] Report narrowing conversions with const references (PR #75332)

2023-12-13 Thread Mariya Podchishchaeva via cfe-commits
Fznamznon wrote: Formatting trouble is intentional. https://github.com/llvm/llvm-project/pull/75332 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [libcxx] [llvm] [lld] [compiler-rt] [flang] [libc] [lldb] [clang-tools-extra] [AMDGPU] Update IEEE and DX10_CLAMP for GFX12 (PR #75030)

2023-12-13 Thread Piotr Sobczak via cfe-commits
https://github.com/piotrAMD closed https://github.com/llvm/llvm-project/pull/75030 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [libcxx] [llvm] [openmp] [libcxxabi] [compiler-rt] [flang] [mlir] [lldb] [clang-tools-extra] [MachineCopyPropagation] When the source of PreviousCopy is undef, we cannot replace sub register (

2023-12-13 Thread via cfe-commits
DianQK wrote: > I'll try and take a look at the patch. Perhaps you are right that we need a > new method for the debug info to use. Based on https://github.com/llvm/llvm-project/blob/fd8fa31c55a3413f643443ecf3301441428ce513/llvm/docs/InstrRefDebugInfo.md?plain=1#L125-L127, perhaps we could ad

[clang] [clang] Parse attribute [[gnu::no_stack_protector]] (PR #75289)

2023-12-13 Thread Sirui Mu via cfe-commits
https://github.com/Lancern updated https://github.com/llvm/llvm-project/pull/75289 >From d8de529580101ba68dc1c981aec8711aa0c58da4 Mon Sep 17 00:00:00 2001 From: Sirui Mu Date: Wed, 13 Dec 2023 06:51:09 + Subject: [PATCH 1/2] [clang] Parse attribute [[gnu::no_stack_protector]] This commit a

[lld] [libc] [clang] [llvm] [lldb] [mlir] [clang-tools-extra] [libcxx] [compiler-rt] [MLIR][LLVM] Add Continuous Loop Peeling transform to SCF (PR #71555)

2023-12-13 Thread via cfe-commits
https://github.com/muneebkhan85 edited https://github.com/llvm/llvm-project/pull/71555 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [llvm] [LLVM][IR] Replace ConstantInt's specialisation of getType() with getIntegerType(). (PR #75217)

2023-12-13 Thread Nikita Popov via cfe-commits
nikic wrote: > Most all the recommended changes assume the code paths will work equally well > for vector types as they do for scalar types. Can we be so sure this is the > case? This is why I opted to keep the casting assertions with the exception > of a few places where I could be sure the c

[clang] [clang] Parse attribute [[gnu::no_stack_protector]] (PR #75289)

2023-12-13 Thread Yingchi Long via cfe-commits
https://github.com/inclyc approved this pull request. https://github.com/llvm/llvm-project/pull/75289 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang] Parse attribute [[gnu::no_stack_protector]] (PR #75289)

2023-12-13 Thread Yingchi Long via cfe-commits
@@ -0,0 +1,4 @@ +// RUN: %clang_cc1 -fsyntax-only -verify -std=c23 %s inclyc wrote: the file name `gnu-attributes.c` is too "generic", perhaps better place these files under `clang/test/Sema/attr-no-stack-protector.c` and `clang/test/SemaCXX/attr-no-stack-prote

[clang] [clang] Parse attribute [[gnu::no_stack_protector]] (PR #75289)

2023-12-13 Thread Yingchi Long via cfe-commits
https://github.com/inclyc edited https://github.com/llvm/llvm-project/pull/75289 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[lld] [libc] [clang] [flang] [llvm] [lldb] [clang-tools-extra] [libcxx] [mlir] [compiler-rt] [AMDGPU] Min/max changes for GFX12 (PR #75214)

2023-12-13 Thread Piotr Sobczak via cfe-commits
https://github.com/piotrAMD closed https://github.com/llvm/llvm-project/pull/75214 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang-tools-extra] [flang] [clang] [llvm] [flang] GETLOG runtime and extension implementation: get login username (PR #74628)

2023-12-13 Thread Yi Wu via cfe-commits
yi-wu-arm wrote: Hi @jeanPerier Sorry to throw a ping. I have changed the structure and implementation of `getlog`, it now does the following: On Linux: use `getlogin_r`, if fail get from environment variable. On Windows: get from environment variable to avoid linking to library `Advapi32.lib`

[clang] [llvm] [SystemZ][z/OS] Add missing strnlen function for z/OS to fix build failures (PR #75339)

2023-12-13 Thread Abhina Sree via cfe-commits
https://github.com/abhina-sree created https://github.com/llvm/llvm-project/pull/75339 This patch adds strnlen to the zOSSupport.h file to fix build failures in multiple files. >From 1b234e926dc6396fe4053f3c3463ed36e5d58778 Mon Sep 17 00:00:00 2001 From: Abhina Sreeskantharajan Date: Wed, 13

[clang] [llvm] [SystemZ][z/OS] Add missing strnlen function for z/OS to fix build failures (PR #75339)

2023-12-13 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang Author: Abhina Sree (abhina-sree) Changes This patch adds strnlen to the zOSSupport.h file to fix build failures in multiple files. --- Full diff: https://github.com/llvm/llvm-project/pull/75339.diff 11 Files Affected: - (modified) clang/lib/L

[clang] [llvm] [SystemZ][z/OS] Add missing strnlen function for z/OS to fix build failures (PR #75339)

2023-12-13 Thread Fanbo Meng via cfe-commits
https://github.com/fanbo-meng approved this pull request. LGTM https://github.com/llvm/llvm-project/pull/75339 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [llvm] [SystemZ][z/OS] Add missing strnlen function for z/OS to fix build failures (PR #75339)

2023-12-13 Thread via cfe-commits
github-actions[bot] wrote: :warning: C/C++ code formatter, clang-format found issues in your code. :warning: You can test this locally with the following command: ``bash git-clang-format --diff c2d3188d5dcb8158d9b8fa2a85f984fc621c7044 1b234e926dc6396fe4053f3c3463ed36e5d58778 --

[clang] [llvm] [SystemZ][z/OS] Add missing strnlen function for z/OS to fix build failures (PR #75339)

2023-12-13 Thread Abhina Sree via cfe-commits
https://github.com/abhina-sree updated https://github.com/llvm/llvm-project/pull/75339 >From 1b234e926dc6396fe4053f3c3463ed36e5d58778 Mon Sep 17 00:00:00 2001 From: Abhina Sreeskantharajan Date: Wed, 13 Dec 2023 08:35:52 -0500 Subject: [PATCH 1/2] fix strnlen build failure for z/OS --- clang/

[clang] [AArch64][SME2] Add SQRSHRN, UQRSHRN, SQRSHRUN builtins for SME2, SVE2p1 (PR #75325)

2023-12-13 Thread via cfe-commits
https://github.com/CarolineConcatto approved this pull request. https://github.com/llvm/llvm-project/pull/75325 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Clang][SVE2.1] Make a part of the name optional for `svwhileXX` builtins with predicate-as-counter (PR #75200)

2023-12-13 Thread Momchil Velikov via cfe-commits
https://github.com/momchil-velikov updated https://github.com/llvm/llvm-project/pull/75200 >From bb881371fb036819a1d6489a9779e2c5ac7e7d3c Mon Sep 17 00:00:00 2001 From: Momchil Velikov Date: Tue, 12 Dec 2023 15:08:33 + Subject: [PATCH 1/2] [Clang][SVE2.1] Make the part of the name optional

[clang] [Clang][SVE2.1] Make a part of the name optional for `svwhileXX` builtins with predicate-as-counter (PR #75200)

2023-12-13 Thread Momchil Velikov via cfe-commits
@@ -1950,19 +1950,17 @@ let TargetGuard = "sve2p1|sme2" in { //FIXME: Replace IsStreamingCompatible with IsStreamingOrHasSVE2p1 when available def SVPEXT_SINGLE : SInst<"svpext_lane_{d}", "P}i", "QcQsQiQl", MergeNone, "aarch64_sve_pext", [IsStreamingCompatible], [ImmCheck<1, I

[clang] [clang][ASTImporter] Improve import of friend class templates. (PR #74627)

2023-12-13 Thread Balázs Kéri via cfe-commits
https://github.com/balazske updated https://github.com/llvm/llvm-project/pull/74627 From cbcb81ebdbc49e3bd11b6f716ac14658a729b787 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Bal=C3=A1zs=20K=C3=A9ri?= Date: Tue, 5 Dec 2023 15:23:37 +0100 Subject: [PATCH 1/3] [clang][ASTImporter] Improve import of f

[clang] [clang-format] Fix parsing of `operator<() {}` (PR #75144)

2023-12-13 Thread via cfe-commits
XDeme wrote: Thanks for reviewing. If the patch is ok, could you land this patch for me? I don't have commit access. https://github.com/llvm/llvm-project/pull/75144 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin

[clang] [llvm] [SystemZ][z/OS] Add missing strnlen function for z/OS to fix build failures (PR #75339)

2023-12-13 Thread Abhina Sree via cfe-commits
https://github.com/abhina-sree updated https://github.com/llvm/llvm-project/pull/75339 >From 71695feb1770ff939c6571de98c965d87e03ad29 Mon Sep 17 00:00:00 2001 From: Abhina Sreeskantharajan Date: Wed, 13 Dec 2023 08:35:52 -0500 Subject: [PATCH 1/2] fix strnlen build failure for z/OS --- clang/

  1   2   3   4   >