[PATCH] D153536: [Clang] Implement P2169 A nice placeholder with no name

cor3ntin added a comment. From yesterday's C++ clang WG meeting - We can land this now - We need to track the debugger issue - We should mention the lack of debugging support in the release notes - We should strive to improve the situation in the 18 time frame but it would not be blocker as few

[clang] ab5ebe4 - [NFC][Clang][Test] Fix warning-as-error

Author: Michael Platings Date: 2023-08-03T08:26:25+01:00 New Revision: ab5ebe4b2088ba3a22a7922cd8bd827a7cedc3a4 URL: https://github.com/llvm/llvm-project/commit/ab5ebe4b2088ba3a22a7922cd8bd827a7cedc3a4 DIFF: https://github.com/llvm/llvm-project/commit/ab5ebe4b2088ba3a22a7922cd8bd827a7cedc3a4.di

[PATCH] D155824: [LoongArch] Support -march=native and -mtune=

SixWeining updated this revision to Diff 546730. SixWeining edited the summary of this revision. SixWeining added a comment. - work with `-fno-integrated-cc1` - add mingsing `"`s in macros Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D155824/new/ h

[PATCH] D155456: [RISCV] Support -m[no-]strict-align options

kito-cheng accepted this revision. kito-cheng added a comment. This revision is now accepted and ready to land. LGTM Comment at: clang/test/Driver/riscv-features.c:41 +// DEFAULT: "-target-feature" "-unaligned-scalar-mem" +// DEFAULT-NOT: "-target-feature" "+unaligned-scalar-me

[PATCH] D155370: [CodeComplete] Improve FunctionCanBeCall

zyounan planned changes to this revision. zyounan added a comment. In D155370#4552967 , @nridge wrote: > I was thinking of functions with different names (with a common prefix) and > different signatures, where the signature could be a useful piece of >

[PATCH] D156223: [RISCV] Resolve a few bugs in RISCVVIntrinsicUtils.cpp

kito-cheng accepted this revision. kito-cheng added a comment. This revision is now accepted and ready to land. LGTM Comment at: clang/lib/Sema/SemaRISCVVectorLookup.cpp:136 case Invalid: + case Undefined: llvm_unreachable("Unhandled type."); 4vtomat w

[PATCH] D156221: [RISCV] Support overloaded version ntlh intrinsic function

kito-cheng accepted this revision. kito-cheng added a comment. This revision is now accepted and ready to land. LGTM, and the change seems like is fewer than my exception :) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D156221/new/ https://reviews.

[PATCH] D155824: [LoongArch] Support -march=native and -mtune=

xen0n added inline comments. Comment at: clang/lib/Driver/ToolChains/Arch/LoongArch.cpp:199-204 + // Handle CPU name is 'native'. + if (CPU == "native") { +CPU = llvm::sys::getHostCPUName(); +if (CPU == "generic") + CPU = llvm::LoongArch::getDefaultArch(Triple.isLo

[PATCH] D125788: [flang][driver] Rename `flang-new` as `flang`

awarzynski added a subscriber: everythingfunctional. awarzynski added a comment. In D125788#4556324 , @MaskRay wrote: > If you continue this work, consider landing this rename in multiple phases, > e.g. > > - Use lit substitutions instead of `flang-new`

[PATCH] D156861: [Driver] Remove references to Solaris 12

ro added a comment. In D156861#4555280 , @MaskRay wrote: > While you are modifying the lines `static const char ...[]` should look > better than `static const char *const SolarisX86Triples[]` While this would certainly avoid the ugly formatting, it does

[PATCH] D156971: [clang-format] Handle "// clang-format on" for SeparateDefinitionBlocks

owenpan created this revision. Herald added projects: All, clang, clang-format. Herald added a subscriber: cfe-commits. Herald added reviewers: rymiel, HazardyKnusperkeks, MyDeveloperDay. owenpan requested review of this revision. Fixes https://github.com/llvm/llvm-project/issues/63393. Reposito

[PATCH] D127762: [Clang][AArch64] Add/implement ACLE keywords for SME.

rsandifo-arm added a comment. Thanks for dropping the attribute requirements down to TargetAArch64. But the offsetting requirement was that something somewhere (CodeGen?) must raise an error if code requires SME and SME isn't present. I think that means: 1. SME is not enabled for an `__arm_st

[clang] d0dc887 - [Driver] Remove references to Solaris 12

Author: Rainer Orth Date: 2023-08-03T09:54:25+02:00 New Revision: d0dc887d7ed285688004c75de3784cfe94febd34 URL: https://github.com/llvm/llvm-project/commit/d0dc887d7ed285688004c75de3784cfe94febd34 DIFF: https://github.com/llvm/llvm-project/commit/d0dc887d7ed285688004c75de3784cfe94febd34.diff L

[PATCH] D156861: [Driver] Remove references to Solaris 12

This revision was automatically updated to reflect the committed changes. Closed by commit rGd0dc887d7ed2: [Driver] Remove references to Solaris 12 (authored by ro). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D156861/new/ https://reviews.llvm.org/

[PATCH] D156787: [analyzer][attr] Add docs to ownership_* attributes

steakhal added inline comments. Comment at: clang/test/Analysis/malloc-annotations.c:151-155 +void af6(void) { + int *p = my_malloc(12); + my_hold(p); + *p = 4; +} Please, consider elaborating on this test with some comments, as it's not clear to me at first

[clang] e68ffa3 - [Driver] Make test work on targets that have no OpenMP library configured

Author: Benjamin Kramer Date: 2023-08-03T09:59:49+02:00 New Revision: e68ffa373f7f3e61de4e030d126f9968679cdfdc URL: https://github.com/llvm/llvm-project/commit/e68ffa373f7f3e61de4e030d126f9968679cdfdc DIFF: https://github.com/llvm/llvm-project/commit/e68ffa373f7f3e61de4e030d126f9968679cdfdc.dif

[PATCH] D156221: [RISCV] Support overloaded version ntlh intrinsic function

eopXD added inline comments. Comment at: clang/test/CodeGen/RISCV/ntlh-intrinsics/riscv32-zihintntl.c:218 // CHECK: !8 = !{i32 5} \ No newline at end of file Nit: new line here? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://review

[PATCH] D155824: [LoongArch] Support -march=native and -mtune=

SixWeining updated this revision to Diff 546742. SixWeining marked an inline comment as done. SixWeining added a comment. Add a common helper for `-m{arch,tune}=native` handling. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D155824/new/ https://rev

[PATCH] D155824: [LoongArch] Support -march=native and -mtune=

SixWeining added inline comments. Comment at: clang/lib/Driver/ToolChains/Arch/LoongArch.cpp:199-204 + // Handle CPU name is 'native'. + if (CPU == "native") { +CPU = llvm::sys::getHostCPUName(); +if (CPU == "generic") + CPU = llvm::LoongArch::getDefaultArch(Triple

[PATCH] D156724: [StaticAnalyzer] Fix incorrect link to "note" diagnostics in HTML output

steakhal accepted this revision. steakhal added a comment. This revision is now accepted and ready to land. Looks correct. Please merge it. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D156724/new/ https://reviews.llvm.org/D156724

[PATCH] D138810: [RISCV] Support vector crypto extension C intrinsics

4vtomat updated this revision to Diff 546746. 4vtomat added a comment. This update does a few things: 1. Update test cases based on rvv-intrinsic-doc. 2. Add checks for "zvknh[a|b]" instructions. 3. Rename and restructure the function from CheckInvalidEGW to CheckInvalidVLENandLMUL. Repository

[clang] f3ce925 - [RISCV] Resolve a few bugs in RISCVVIntrinsicUtils.cpp

Author: 4vtomat Date: 2023-08-03T01:48:23-07:00 New Revision: f3ce925083d2214289c73b8f21590ac32beef03d URL: https://github.com/llvm/llvm-project/commit/f3ce925083d2214289c73b8f21590ac32beef03d DIFF: https://github.com/llvm/llvm-project/commit/f3ce925083d2214289c73b8f21590ac32beef03d.diff LOG:

[PATCH] D156223: [RISCV] Resolve a few bugs in RISCVVIntrinsicUtils.cpp

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGf3ce925083d2: [RISCV] Resolve a few bugs in RISCVVIntrinsicUtils.cpp (authored by 4vtomat). Repository: rG LLVM Github Monorepo CHANGES SINCE LAS

[clang] 962dede - [NFC][clang] Fix static analyzer concerns

Author: Podchishchaeva, Mariya Date: 2023-08-03T01:52:26-07:00 New Revision: 962deded6c30193175b4d96d6397e29bf6c238e9 URL: https://github.com/llvm/llvm-project/commit/962deded6c30193175b4d96d6397e29bf6c238e9 DIFF: https://github.com/llvm/llvm-project/commit/962deded6c30193175b4d96d6397e29bf6c23

[PATCH] D156904: [NFC][clang] Fix static analyzer concerns

This revision was automatically updated to reflect the committed changes. Closed by commit rG962deded6c30: [NFC][clang] Fix static analyzer concerns (authored by Fznamznon). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D156904/new/ https://reviews.l

[PATCH] D156221: [RISCV] Support overloaded version ntlh intrinsic function

BeMg updated this revision to Diff 546753. BeMg added a comment. Add new line Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D156221/new/ https://reviews.llvm.org/D156221 Files: clang/lib/CodeGen/CGBuiltin.cpp clang/lib/Headers/riscv_ntlh.h cl

[clang] c4bb3e0 - [NFC][clang] Fix static analyzer concerns

Author: Podchishchaeva, Mariya Date: 2023-08-03T02:00:17-07:00 New Revision: c4bb3e073548cf436d5fa0406e3ae75e94684dec URL: https://github.com/llvm/llvm-project/commit/c4bb3e073548cf436d5fa0406e3ae75e94684dec DIFF: https://github.com/llvm/llvm-project/commit/c4bb3e073548cf436d5fa0406e3ae75e94684

[PATCH] D156900: [NFC][clang] Fix static analyzer concerns

This revision was automatically updated to reflect the committed changes. Closed by commit rGc4bb3e073548: [NFC][clang] Fix static analyzer concerns (authored by Fznamznon). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D156900/new/ https://reviews.l

[PATCH] D156724: [StaticAnalyzer] Fix incorrect link to "note" diagnostics in HTML output

gruuprasad added a comment. @steakhal, ok, this is my first contribution, I don't have the commit access yet. Can you please merge this? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D156724/new/ https://reviews.llvm.org/D156724 _

[PATCH] D156724: [StaticAnalyzer] Fix incorrect link to "note" diagnostics in HTML output

steakhal added a comment. In D156724#4556774 , @gruuprasad wrote: > @steakhal, ok, this is my first contribution, I don't have the commit access > yet. > Can you please merge this? What should be the commit author? Repository: rG LLVM Github Monor

[PATCH] D112921: [clang] Enable sized deallocation by default in C++14 onwards

wangpc updated this revision to Diff 546760. wangpc added a comment. Rebase. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D112921/new/ https://reviews.llvm.org/D112921 Files: clang-tools-extra/clangd/unittests/FindTargetTests.cpp clang-tools-e

[PATCH] D155456: [RISCV] Support -m[no-]strict-align options

wangpc added a comment. Thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D155456/new/ https://reviews.llvm.org/D155456 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/c

[PATCH] D156724: [StaticAnalyzer] Fix incorrect link to "note" diagnostics in HTML output

gruuprasad added a comment. Email:gruupras...@gmail.com GitHub username: gruuprasad Either of these fine. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D156724/new/ https://reviews.llvm.org/D156724 ___ cf

[PATCH] D156975: [NFC][clang] Fix static analyzer concerns

Fznamznon created this revision. Herald added subscribers: manas, ASDenysPetrov, dkrupp, donat.nagy, Szelethus, a.sidorin, baloghadamsoftware. Herald added a project: All. Fznamznon requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. A bunch o

[PATCH] D155824: [LoongArch] Support -march=native and -mtune=

SixWeining updated this revision to Diff 546766. SixWeining added a comment. rename the common helper to `postProcessTargetCPUString` Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D155824/new/ https://reviews.llvm.org/D155824 Files: clang/lib/Bas

[PATCH] D155456: [RISCV] Support -m[no-]strict-align options

wangpc updated this revision to Diff 546772. wangpc added a comment. Rebase since `ReleaseNotes.rst` is changed. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D155456/new/ https://reviews.llvm.org/D155456 Files: clang/docs/ReleaseNotes.rst clan

[clang] e73ae74 - [analyzer] Fix incorrect link to "note" diagnostics in HTML output

Author: Guruprasad Hegde Date: 2023-08-03T11:44:05+02:00 New Revision: e73ae745b0d660d3974c04b2281575f325971338 URL: https://github.com/llvm/llvm-project/commit/e73ae745b0d660d3974c04b2281575f325971338 DIFF: https://github.com/llvm/llvm-project/commit/e73ae745b0d660d3974c04b2281575f325971338.di

[PATCH] D156724: [StaticAnalyzer] Fix incorrect link to "note" diagnostics in HTML output

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGe73ae745b0d6: [analyzer] Fix incorrect link to "note" diagnostics in HTML output (authored by gruuprasad, committed by steakhal). Repository: rG

[PATCH] D155610: [Clang][ExprConstant] Print integer instead of character on static assertion failure

hazohelet updated this revision to Diff 546782. hazohelet added a comment. Address comments from Corentin - Use default `pushEscapedString` escaping (``) instead of UCN representation `\u0001` - Convert multi-byte characters (`wchar_t`, `char16_t`, `char32_t`) to UTF-8 and prints them. - Added

[clang] 23ce536 - [RISCV] Support -m[no-]strict-align options

Author: wangpc Date: 2023-08-03T18:11:41+08:00 New Revision: 23ce5368409c760f3dd49d0f17f34772b0b869d8 URL: https://github.com/llvm/llvm-project/commit/23ce5368409c760f3dd49d0f17f34772b0b869d8 DIFF: https://github.com/llvm/llvm-project/commit/23ce5368409c760f3dd49d0f17f34772b0b869d8.diff LOG: [

[PATCH] D155456: [RISCV] Support -m[no-]strict-align options

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG23ce5368409c: [RISCV] Support -m[no-]strict-align options (authored by wangpc). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION h

[clang] c7cacb2 - Fix __cfi_check not aligned to 4k on relocatable files with no executable code

Author: Yi Kong Date: 2023-08-03T19:53:54+09:00 New Revision: c7cacb2f6efe07fa4a1129bb7e2389312670b84a URL: https://github.com/llvm/llvm-project/commit/c7cacb2f6efe07fa4a1129bb7e2389312670b84a DIFF: https://github.com/llvm/llvm-project/commit/c7cacb2f6efe07fa4a1129bb7e2389312670b84a.diff LOG:

[PATCH] D155736: Fix __cfi_check not aligned to 4k on relocatable files with no executable code

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGc7cacb2f6efe: Fix __cfi_check not aligned to 4k on relocatable files with no executable code (authored by kongyi). Herald added a project: clang. Her

[PATCH] D155610: [Clang][ExprConstant] Print integer instead of character on static assertion failure

cor3ntin added a comment. This is starting to look pretty good! I'm happy with the general direction, my only concern is that printing a prefix does not seem useful - we are trying to display the value, not how it was produced. Comment at: clang/lib/Sema/SemaDeclCXX.cpp:16839

[PATCH] D156320: [FLang] Add support for Rpass flag

victorkingi updated this revision to Diff 546798. victorkingi added a comment. rpass flag now prints remarks when requested but does not display the passName used, i.e [-Rpass=inline] Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D156320/new/ https:

[PATCH] D156989: FloatingPointMode: Use -1 for "Dynamic"

arsenm created this revision. arsenm added reviewers: sepavloff, rjmccall, kpn, cameron.mcinally, uweigand, scanon, jcranmer-intel, foad. Herald added subscribers: StephenFan, tpr. Herald added a project: All. arsenm requested review of this revision. Herald added a subscriber: wdng. Herald added

[PATCH] D155736: Fix __cfi_check not aligned to 4k on relocatable files with no executable code

ro added a comment. It seems this patch broke the Solaris/amd64 buildbot : FAIL: Clang::cfi-check-fail.c Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D155736/new/ https://reviews.llvm.or

[PATCH] D156400: [clang][Interp] Implement __builtin_offsetof

cor3ntin added inline comments. Comment at: clang/lib/AST/Interp/Interp.h:1901 +inline bool OffsetOf(InterpState &S, CodePtr OpPC, const OffsetOfExpr *E) { + std::vector ArrayIndices; + for (unsigned I = 0; I != E->getNumExpressions(); ++I) Might be useful to u

[PATCH] D156400: [clang][Interp] Implement __builtin_offsetof

cor3ntin added inline comments. Comment at: clang/lib/AST/Interp/ByteCodeExprGen.cpp:1536-1537 + // Cast to Sint64. + if (IndexT != PT_Sint64) { +if (!this->emitCast(IndexT, PT_Sint64, E)) + return false; Shouldn't that be size_t? CHA

[PATCH] D156989: FloatingPointMode: Use -1 for "Dynamic"

foad added inline comments. Comment at: llvm/include/llvm/ADT/FloatingPointMode.h:39 + // Special values. + Invalid = -2, + Lost the `///<` comment here. Comment at: llvm/include/llvm/ADT/FloatingPointMode.h:41 + + ///< Denotes mode unknown

[PATCH] D155736: Fix __cfi_check not aligned to 4k on relocatable files with no executable code

thakis added a comment. Looks like this breaks check-clang: http://45.33.8.238/linux/114361/step_7.txt Please take a look and revert for now if it takes a while to fix. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D155736/new/ https://reviews.llvm

[clang] 9f72df7 - Fixing a formatting mistake; NFC

Author: Aaron Ballman Date: 2023-08-03T08:07:59-04:00 New Revision: 9f72df7e30f074b46b18d3de267450236e4e37ea URL: https://github.com/llvm/llvm-project/commit/9f72df7e30f074b46b18d3de267450236e4e37ea DIFF: https://github.com/llvm/llvm-project/commit/9f72df7e30f074b46b18d3de267450236e4e37ea.diff

[PATCH] D156704: [clang][HeaderSearch] Treat framework headers as System for suggestPath

kadircet added inline comments. Comment at: clang/lib/Lex/HeaderSearch.cpp:1939 std::string HeaderSearch::suggestPathToFileForDiagnostics( llvm::StringRef File, llvm::StringRef WorkingDir, llvm::StringRef MainFile, sorry I guess my suggestion get distorte

[PATCH] D153954: [clang][analyzer] Fix empty enum handling in EnumCastOutOfRange checker

donat.nagy accepted this revision. donat.nagy added a comment. This revision is now accepted and ready to land. LGTM, with a little bikeshedding ;-) Comment at: clang/test/Analysis/enum-cast-out-of-range.cpp:203 + +enum class empty_unfixed {}; + Consider using

[PATCH] D156400: [clang][Interp] Implement __builtin_offsetof

cor3ntin added inline comments. Comment at: clang/lib/AST/Interp/Interp.h:1902 + std::vector ArrayIndices; + for (unsigned I = 0; I != E->getNumExpressions(); ++I) +ArrayIndices.emplace_back(S.Stk.pop()); can you use size_t here? It's already a bug nest but

[PATCH] D156743: clang/OpenCL: Add inline implementations of sqrt in builtin header

arsenm updated this revision to Diff 546814. arsenm marked an inline comment as done. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D156743/new/ https://reviews.llvm.org/D156743 Files: clang/lib/Headers/opencl-c-base.h clang/lib/Headers/opencl-c.h clang/lib/Sema/OpenCLBuiltins.td

[PATCH] D156743: clang/OpenCL: Add inline implementations of sqrt in builtin header

arsenm added inline comments. Comment at: clang/lib/Headers/opencl-c-base.h:832 + +inline float __ovld __cnfn sqrt(float __x) { + return __builtin_elementwise_sqrt(__x); svenvh wrote: > Anastasia wrote: > > Is this a generic implementation enough? Would some tar

[PATCH] D156989: FloatingPointMode: Use -1 for "Dynamic"

arsenm updated this revision to Diff 546815. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D156989/new/ https://reviews.llvm.org/D156989 Files: clang/include/clang/Basic/FPOptions.def clang/include/clang/Basic/LangOptions.h clang/lib/AST/JSONNodeDumper.cpp clang/lib/AST/TextNodeDu

[PATCH] D156993: [clang] Error on substitution failure within lambda body inside a requires-expression

Fznamznon created this revision. Herald added a project: All. Fznamznon requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Per CWG 2672 substitution failure within the body of a lambda inside a requires-expression should be a hard error. Fixe

[PATCH] D156320: [FLang] Add support for Rpass flag

victorkingi updated this revision to Diff 546819. victorkingi added a comment. added test file optimization-remark.f90 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D156320/new/ https://reviews.llvm.org/D156320 Files: clang/include/clang/Driver/O

[PATCH] D156794: [clang][Interp] Lazily visit unknown global declarations

tbaeder added inline comments. Comment at: clang/lib/AST/Interp/ByteCodeExprGen.cpp:2172-2173 + // Lazily visit global declarations we haven't seen yet. + // This happens in C. + if (const auto *VD = dyn_cast(D); aaron.ballman wrote: > Do we want to assert/l

[PATCH] D156993: [clang] Error on substitution failure within lambda body inside a requires-expression

cor3ntin accepted this revision. cor3ntin added a comment. This revision is now accepted and ready to land. Thanks for the PR! Can you add a test in `dr26xx` ? Also, i think the intent is that only the body is in the immediate context. maybe we need a test like cpp requires { decl

[PATCH] D156993: [clang] Error on substitution failure within lambda body inside a requires-expression

cor3ntin requested changes to this revision. cor3ntin added a comment. This revision now requires changes to proceed. Oups, I did not meant to accept that, sorry! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D156993/new/ https://reviews.llvm.org/D1

[PATCH] D153954: [clang][analyzer] Fix empty enum handling in EnumCastOutOfRange checker

steakhal accepted this revision. steakhal added a comment. LGTM Comment at: clang/test/Analysis/enum-cast-out-of-range.cpp:203 + +enum class empty_unfixed {}; + donat.nagy wrote: > Consider using "specified" and "unspecified" instead of "fixed" and > "unfixed"

[PATCH] D156312: [analyzer] Upstream BitwiseShiftChecker

steakhal added inline comments. Comment at: clang/docs/analyzer/checkers.rst:35 +core.BitwiseShift (C, C++) +""" + Comment at: clang/docs/analyzer/checkers.rst:44-50 +Moreover, if the pedantic mode is activated by +

[PATCH] D153954: [clang][analyzer] Fix empty enum handling in EnumCastOutOfRange checker

donat.nagy added inline comments. Comment at: clang/test/Analysis/enum-cast-out-of-range.cpp:203 + +enum class empty_unfixed {}; + steakhal wrote: > donat.nagy wrote: > > Consider using "specified" and "unspecified" instead of "fixed" and > > "unfixed", because

[PATCH] D156794: [clang][Interp] Lazily visit unknown global declarations

cor3ntin added inline comments. Comment at: clang/lib/AST/Interp/ByteCodeExprGen.cpp:2172-2173 + // Lazily visit global declarations we haven't seen yet. + // This happens in C. + if (const auto *VD = dyn_cast(D); tbaeder wrote: > aaron.ballman wrote: > > Do

[clang] a093598 - Revert "Fix __cfi_check not aligned to 4k on relocatable files with no executable code"

Author: Yi Kong Date: 2023-08-03T22:03:43+09:00 New Revision: a093598e50e7b252205f1164751ac9c74874e254 URL: https://github.com/llvm/llvm-project/commit/a093598e50e7b252205f1164751ac9c74874e254 DIFF: https://github.com/llvm/llvm-project/commit/a093598e50e7b252205f1164751ac9c74874e254.diff LOG:

[PATCH] D156312: [analyzer] Upstream BitwiseShiftChecker

donat.nagy marked an inline comment as done. donat.nagy added a comment. @steakhal Thanks for the review! I answered some of your questions; and I'll handle the rest soon. Comment at: clang/lib/StaticAnalyzer/Checkers/BitwiseShiftChecker.cpp:150 + SVB.evalBinOp(State, Co

[PATCH] D156896: [NFC][clang] Fix static analyzer concerns

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. LGTM, though I find the whole `OwnsAction` business to be a code smell. I think it'd be somewhat involved trying to address that though, so these changes are reasonable. Reposi

[PATCH] D156975: [NFC][clang] Fix static analyzer concerns

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. LGTM! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D156975/new/ https://reviews.llvm.org/D156975

[PATCH] D156320: [FLang] Add support for Rpass flag

victorkingi updated this revision to Diff 546826. victorkingi added a comment. added frontend forwarding test for Rpass flags Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D156320/new/ https://reviews.llvm.org/D156320 Files: clang/include/clang/D

[PATCH] D156320: [FLang] Add support for Rpass flag

victorkingi updated this revision to Diff 546831. victorkingi added a comment. removed unused header includes Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D156320/new/ https://reviews.llvm.org/D156320 Files: clang/include/clang/Driver/Options.td

[PATCH] D156993: [clang] Error on substitution failure within lambda body inside a requires-expression

Fznamznon updated this revision to Diff 546837. Fznamznon added a comment. Rebase, apply feedback Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D156993/new/ https://reviews.llvm.org/D156993 Files: clang/docs/ReleaseNotes.rst clang/lib/Sema/Sema

[PATCH] D156993: [clang] Error on substitution failure within lambda body inside a requires-expression

Fznamznon added a comment. > Can you add a test in dr26xx ? Sure, done. Hope I updated cxx_dr_status in the right way. The script wasn't happy until I added "open" to the test comment. > maybe we need a test like Because I think the intent is for that to work Seems to be working if I got it ri

[PATCH] D155610: [Clang][Sema] Fix display of characters on static assertion failure

hazohelet updated this revision to Diff 546832. hazohelet marked 2 inline comments as done. hazohelet retitled this revision from "[Clang][ExprConstant] Print integer instead of character on static assertion failure" to "[Clang][Sema] Fix display of characters on static assertion failure". hazohe

[PATCH] D156866: [Clang][LoongArch] Use the ClangBuiltin class to automatically generate support for CBE and CFE

SixWeining added a comment. LGTM except a nit. Comment at: clang/lib/CodeGen/CGBuiltin.cpp:20447 - -Value *CodeGenFunction::EmitLoongArchBuiltinExpr(unsigned BuiltinID, - const CallExpr *E) { The declaration in `c

[PATCH] D156234: [clang][deps] add support for dependency scanning with cc1 command line

cpsughrue updated this revision to Diff 546861. cpsughrue added a comment. Fixing failed test on Windows CI CHANGES SINCE LAST ACTION https://reviews.llvm.org/D156234/new/ https://reviews.llvm.org/D156234 Files: clang/lib/Tooling/DependencyScanning/DependencyScanningWorker.cpp clang/test

[PATCH] D142660: [AIX] supporting -X options for llvm-ranlib in AIX OS

DiggerLin updated this revision to Diff 546867. DiggerLin marked 2 inline comments as done. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D142660/new/ https://reviews.llvm.org/D142660 Files: clang/lib/Driver/OffloadBundler.cpp clang/test/lit.cfg.

[PATCH] D154581: [clang][Interp] Track existing InitMaps in InterpState

tbaeder updated this revision to Diff 546872. tbaeder added a comment. 1. Use a `shared_ptr` for the initmaps. 2. However, we allocate them into the `Block`, therefore can't forget to call the Block's dtor. 3. To distinguish between Blocks we've already deallocated (via a `destroy` op), add an

[PATCH] D154262: [clang][Interp] LambdaThisCaptures

tbaeder added a comment. Ping Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D154262/new/ https://reviews.llvm.org/D154262 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi

[PATCH] D156453: [clang][Interp] Create only globals when initializing a global variable

tbaeder added a comment. Ping Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D156453/new/ https://reviews.llvm.org/D156453 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi

[PATCH] D144457: [clang][Interp] Handle global composite temporaries

tbaeder added a comment. Ping Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D144457/new/ https://reviews.llvm.org/D144457 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi

[PATCH] D155387: [Clang] Fix member lookup so that we don't ignore ambiguous lookups in some cases

hctim added a comment. Hi folks, I found an issue with building Android using this patch. I've reduced it down to the following problem where the evaluation of the `std::visit` is believed to be non-exhaustive, but it seems like it is? Would you mind taking a look? Admittedly, my knowledge in

[PATCH] D157007: [clang][ExtractAPI] Add support for C++ classes with fix

evelez7 created this revision. evelez7 added a reviewer: dang. Herald added a reviewer: ributzka. Herald added a subscriber: ChuanqiXu. Herald added a project: All. evelez7 requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Reintroduce D153557

[PATCH] D156172: [clang][CodeGen] Emit annotations for function declarations.

efriedma added a comment. I'm happy with this approach. Comment at: clang/lib/CodeGen/CodeGenModule.cpp:4327 +if (D && D->hasAttr() && isa(Entry)) + DeferredAnnotations[cast(Entry)] = cast(D); + This doesn't quite seem sufficient... I'd expect you'd wa

[PATCH] D157007: [clang][ExtractAPI] Add support for C++ classes with fix

evelez7 added inline comments. Comment at: clang/lib/ExtractAPI/DeclarationFragments.cpp:612 + if (isa(Method)) { +Name = Method->getNameAsString(); +if (dyn_cast(Method)->isExplicit()) Minor change is here. Since `Name` is now an `std::string`, a cast t

[PATCH] D156794: [clang][Interp] Lazily visit unknown global declarations

tbaeder updated this revision to Diff 546882. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D156794/new/ https://reviews.llvm.org/D156794 Files: clang/lib/AST/Interp/ByteCodeExprGen.cpp clang/test/AST/Interp/c.c Index: clang/test/AST/Interp/c.c ==

[PATCH] D156799: Update generic scheduling to use A510 scheduling model

harviniriawan updated this revision to Diff 546884. harviniriawan marked 23 inline comments as done. Herald added a project: clang. Herald added a subscriber: cfe-commits. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D156799/new/ https://reviews.llvm

[PATCH] D156799: Update generic scheduling to use A510 scheduling model

harviniriawan added inline comments. Comment at: llvm/test/CodeGen/AArch64/stack-guard-sysreg.ll:1 -; RUN: split-file %s %t ; RUN: cat %t/main.ll %t/a.ll > %t/a2.ll ; RUN: cat %t/main.ll %t/b.ll > %t/b2.ll dmgreen wrote: > Can you explain this one? Are the two

[PATCH] D140828: [C++] Implement "Deducing this" (P0847R7)

Zingam added a comment. In D140828#4544438 , @cor3ntin wrote: > In D140828#4544433 , @Zingam wrote: > >> Is this going to land soon? There is a libc++ paper I'm interested in that >> relies on "deducing this" and

[clang] f887cb1 - [NFC][clang] Fix static analyzer concerns

Author: Podchishchaeva, Mariya Date: 2023-08-03T08:36:49-07:00 New Revision: f887cb10acc9fb21e389703062398adf1331232f URL: https://github.com/llvm/llvm-project/commit/f887cb10acc9fb21e389703062398adf1331232f DIFF: https://github.com/llvm/llvm-project/commit/f887cb10acc9fb21e389703062398adf13312

[PATCH] D156896: [NFC][clang] Fix static analyzer concerns

This revision was automatically updated to reflect the committed changes. Closed by commit rGf887cb10acc9: [NFC][clang] Fix static analyzer concerns (authored by Fznamznon). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D156896/new/ https://reviews.l

[clang] 25d6f9d - [NFC][clang] Fix static analyzer concerns

Author: Podchishchaeva, Mariya Date: 2023-08-03T08:37:58-07:00 New Revision: 25d6f9ddc1913de1094fa610ce77288f337771a2 URL: https://github.com/llvm/llvm-project/commit/25d6f9ddc1913de1094fa610ce77288f337771a2 DIFF: https://github.com/llvm/llvm-project/commit/25d6f9ddc1913de1094fa610ce77288f33777

[PATCH] D155610: [Clang][Sema] Fix display of characters on static assertion failure

hazohelet added a comment. One concern from my side is that some unicode characters like `U+FEFF` (I added in test) are invisible, but it may not be a big concern because we also display integer representation in parens. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D155610/new/ https:

[PATCH] D156975: [NFC][clang] Fix static analyzer concerns

This revision was automatically updated to reflect the committed changes. Closed by commit rG25d6f9ddc191: [NFC][clang] Fix static analyzer concerns (authored by Fznamznon). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D156975/new/ https://reviews.l

[PATCH] D153536: [Clang] Implement P2169 A nice placeholder with no name

aaron.ballman added a comment. In D153536#4556485 , @cor3ntin wrote: > From yesterday's C++ clang WG meeting > > - We can land this now > - We need to track the debugger issue > - We should mention the lack of debugging support in the release notes > - We

[PATCH] D155610: [Clang][Sema] Fix display of characters on static assertion failure

cor3ntin added a comment. In D155610#4557930 , @hazohelet wrote: > One concern from my side is that some unicode characters like `U+FEFF` (I > added in test) are invisible, but it may not be a big concern because we also > display integer representation

[PATCH] D154576: [RISCV] RISCV vector calling convention (1/2)

aaron.ballman added a comment. The clang bits LGTM, but I'll leave final sign-off to the LLVM reviewers. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D154576/new/ https://reviews.llvm.org/D154576 ___ cfe

[PATCH] D155610: [Clang][Sema] Fix display of characters on static assertion failure

cor3ntin added inline comments. Comment at: clang/docs/ReleaseNotes.rst:103-137 +- When describing the failure of static assertion of `==` expression, clang prints the integer + representation of the value as well as its character representation when + the user-provided expres

  1   2   3   >