donat.nagy added inline comments.
================
Comment at: clang/test/Analysis/enum-cast-out-of-range.cpp:203
+
+enum class empty_unfixed {};
+
----------------
steakhal wrote:
> donat.nagy wrote:
> > Consider using "specified" and "unspecified" instead of "fixed" and
> > "unfixed", because the rest of the test file uses them and in my opinion
> > "unfixed" looks strange in this context. (I know that e.g.
> > https://en.cppreference.com/w/cpp/language/enum speaks about "fixed"
> > underlying context, but it doesn't use "unfixed".)
> How about calling it "plain" or "common"?
"plain" is also a good alternative for "unfixed" (although it would still be
inconsistent with the earlier cases); but "common" is confusing, because in
addition to the "plain, regular, normal" meaning it can also mean "mutual;
shared by more than one <something>".
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D153954/new/
https://reviews.llvm.org/D153954
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
