[PATCH] D144620: [clang][driver] Handle '-mrelax' and '-mno-relax' for AVR

MaskRay added inline comments. Comment at: clang/lib/Driver/ToolChains/AVR.cpp:549 +// '-mrelax' is default unless '-mno-relax' is specified. +if (Args.hasFlag(options::OPT_mrelax, options::OPT_mno_relax, true)) + CmdArgs.push_back("--relax"); If the

[PATCH] D124351: [Clang] Implement Change scope of lambda trailing-return-type

cor3ntin updated this revision to Diff 499754. cor3ntin added a comment. Address Aaron's comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D124351/new/ https://reviews.llvm.org/D124351 Files: clang/docs/ReleaseNotes.rst clang/include/clang

[PATCH] D144179: [Clang] Added functionality to provide config file name via env variable

MaskRay added a comment. This looks like introducing a footgun (when something behaves differently from an upstream Clang, it would be difficult for toolchain maintainers to know why). Why can't your user specify `CLANG_CONFIG_FILE_SYSTEM_DIR`? Repository: rG LLVM Github Monorepo CHANGES SIN

[PATCH] D144622: [clang[[ASTImporter] Import TemplateName correctly

balazske created this revision. Herald added subscribers: steakhal, martong, gamesh411, Szelethus, dkrupp. Herald added a reviewer: a.sidorin. Herald added a reviewer: shafik. Herald added a project: All. balazske requested review of this revision. Herald added a project: clang. Herald added a subs

[PATCH] D144579: [include-cleaner] Check macros against stdlib database

hokein accepted this revision. hokein added a comment. This revision is now accepted and ready to land. thanks, good catch! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D144579/new/ https://reviews.llvm.org/D144579

[PATCH] D144620: [clang][driver] Handle '-mrelax' and '-mno-relax' for AVR

benshi001 updated this revision to Diff 499757. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D144620/new/ https://reviews.llvm.org/D144620 Files: clang/lib/Driver/ToolChains/AVR.cpp clang/test/Driver/avr-ld.c clang/test/Driver/avr-toolchain.c

[clang-tools-extra] 961e32c - [include-cleaner] Check macros against stdlib database

Author: Kadir Cetinkaya Date: 2023-02-23T09:34:37+01:00 New Revision: 961e32c587cb2289e8c2873848b660a153ed5618 URL: https://github.com/llvm/llvm-project/commit/961e32c587cb2289e8c2873848b660a153ed5618 DIFF: https://github.com/llvm/llvm-project/commit/961e32c587cb2289e8c2873848b660a153ed5618.dif

[PATCH] D144579: [include-cleaner] Check macros against stdlib database

This revision was automatically updated to reflect the committed changes. Closed by commit rG961e32c587cb: [include-cleaner] Check macros against stdlib database (authored by kadircet). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D144579/new/ https

[PATCH] D142905: [Driver] Change multilib selection algorithm

phosek added inline comments. Comment at: clang/include/clang/Driver/Multilib.h:41 + flag_set Flags; + arg_list PrintArgs; This is just a suggestion, but GCC documentation refers to these as either "options" or "switches", not "args" so I think it might be h

[PATCH] D143496: [clangd] Add support for missing includes analysis.

kadircet added inline comments. Comment at: clang-tools-extra/clangd/IncludeCleaner.cpp:291 } for (auto &Filter : Cfg.Diagnostics.Includes.IgnoreHeader) { // Convert the path to Unix slashes and try to match against the filter. can you also change the

[clang-tools-extra] 279b498 - [include-cleaner] Always treat constructor calls as implicit

Author: Kadir Cetinkaya Date: 2023-02-23T10:00:50+01:00 New Revision: 279b4985ed4f62eb8e9a71e79379c2adfa8d8b99 URL: https://github.com/llvm/llvm-project/commit/279b4985ed4f62eb8e9a71e79379c2adfa8d8b99 DIFF: https://github.com/llvm/llvm-project/commit/279b4985ed4f62eb8e9a71e79379c2adfa8d8b99.dif

[PATCH] D144582: [include-cleaner] Always treat constructor calls as implicit

This revision was automatically updated to reflect the committed changes. Closed by commit rG279b4985ed4f: [include-cleaner] Always treat constructor calls as implicit (authored by kadircet). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D144582/new/

[clang-tools-extra] 48027f0 - [include-cleaner] Dont pass llvm::StringRef to gtest APIs

Author: Kadir Cetinkaya Date: 2023-02-23T10:04:03+01:00 New Revision: 48027f03f2d5fef884ebe118c42f800b90fae2f9 URL: https://github.com/llvm/llvm-project/commit/48027f03f2d5fef884ebe118c42f800b90fae2f9 DIFF: https://github.com/llvm/llvm-project/commit/48027f03f2d5fef884ebe118c42f800b90fae2f9.dif

[clang] 74565c3 - [Modules] Don't check [temp.friend]p9 in ASTContext::isSameEntity

Author: Chuanqi Xu Date: 2023-02-23T17:09:38+08:00 New Revision: 74565c3add6d683559618973863e78a5e6836e48 URL: https://github.com/llvm/llvm-project/commit/74565c3add6d683559618973863e78a5e6836e48 DIFF: https://github.com/llvm/llvm-project/commit/74565c3add6d683559618973863e78a5e6836e48.diff LO

[PATCH] D144457: [clang][Interp] Handle global composite temporaries

tbaeder added a comment. Thinking about this some more, the new `Pointer::toRValue()` is probably just the same thing we're already doing in `EvalEmitter::emtiRetValue()`. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D144457/new/ https://reviews.l

[PATCH] D144599: [clangd/index/remote]NFC: Adapt code to newer grpc/protobuf versions

kadircet accepted this revision. kadircet added a comment. This revision is now accepted and ready to land. thanks, indeed the protobuf version used by grpc-1.36.3 has these available, https://github.com/protocolbuffers/protobuf/blob/19fb89416f3fdc2d6668f3738f444885575285bc/src/google/protobuf/st

[PATCH] D143436: [clangd] Move standard options adaptor to CommandMangler

DmitryPolukhin updated this revision to Diff 499766. DmitryPolukhin added a comment. Failing tests seems to be just flacky, I was not able to reprocuce any issue with them locally in stress runs and under ASan and TSan Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://r

[clang-tools-extra] cbcb3ee - [Tooling/Inclusion] Handle std::get symbol.

Author: Haojian Wu Date: 2023-02-23T10:26:26+01:00 New Revision: cbcb3eef70def3509bdffd4fe1ebfb6422afeaa2 URL: https://github.com/llvm/llvm-project/commit/cbcb3eef70def3509bdffd4fe1ebfb6422afeaa2 DIFF: https://github.com/llvm/llvm-project/commit/cbcb3eef70def3509bdffd4fe1ebfb6422afeaa2.diff LO

[PATCH] D144484: [Tooling/Inclusion] Handle std::get symbol.

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGcbcb3eef70de: [Tooling/Inclusion] Handle std::get symbol. (authored by hokein). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION h

[PATCH] D144599: [clangd/index/remote]NFC: Adapt code to newer grpc/protobuf versions

kuganv added a comment. > if you don't mind me asking, are you deliberately building remote-index > components? i.e. do you have an internal remote-index server/deployment ? > Asking as it'd be great to know that we've adoption here, outside of > ourselves. > > OTOH, if you're not actually us

[PATCH] D142914: [MLIR][OpenMP] Added OMPIRBuilder support for Target Data directives.

kiranchandramohan added a comment. In D142914#4145224 , @TIFitis wrote: > In D142914#4144475 , > @kiranchandramohan wrote: > >> Please add tests for the MLIR portion. > > Can you please tell me where to add these

[PATCH] D144626: [C++20] [Modules] Provide OriginalTrailingRequiresClause for serializer to perform ODR-Checking correctly

ChuanqiXu created this revision. ChuanqiXu added reviewers: erichkeane, cor3ntin, royjacobson, clang-language-wg. ChuanqiXu added a project: clang-modules. Herald added a project: All. ChuanqiXu requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits

[PATCH] D144170: [clang-format] Add simple macro replacements in formatting.

klimek updated this revision to Diff 499771. klimek marked 9 inline comments as done. klimek added a comment. Address reviewer comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D144170/new/ https://reviews.llvm.org/D144170 Files: clang/incl

[PATCH] D144170: [clang-format] Add simple macro replacements in formatting.

klimek added inline comments. Comment at: clang/lib/Format/ContinuationIndenter.cpp:744 + // Align following lines within parenthesis / brackets if configured. + // For a line of macro parents, the commas that follow the opening parenthesis + // in the line come after the ope

[PATCH] D144269: [Analyzer] Show "taint originated here" note of alpha.security.taint.TaintPropagation checker at the correct place

dkrupp added a comment. @steakhal, @NoQ thanks for your reviews. Please note that I am not extending `TaintBugVisitor`. On the contrary I removed it. Instead I use NoteTag to generate the "Taint Originated here" text (see GenericTaintChecker.cpp:156). I can also add additional NoteTags for ge

[PATCH] D144627: [Clang] Fix a crash when taking the address of a consteval lambda

cor3ntin created this revision. Herald added a project: All. cor3ntin requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. The `_invoke` function of lambdas was not respecting the constexpr/consteval specifier of the call operator, so it was pos

[PATCH] D144627: [Clang] Fix a crash when taking the address of a consteval lambda

cor3ntin updated this revision to Diff 499773. cor3ntin added a comment. Release notes + formatting Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D144627/new/ https://reviews.llvm.org/D144627 Files: clang/docs/ReleaseNotes.rst clang/include/cla

[PATCH] D144170: [clang-format] Add simple macro replacements in formatting.

klimek updated this revision to Diff 499777. klimek added a comment. Add comment. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D144170/new/ https://reviews.llvm.org/D144170 Files: clang/include/clang/Format/Format.h clang/lib/Format/Continuati

[PATCH] D144634: [Clang][OpenMP] Support for Code Generation of loop bind clause

koops created this revision. koops added reviewers: soumitra, RitanyaB, dreachem, ABataev, jdoerfert, sandoval, tianshilei1992. Herald added subscribers: guansong, yaxunl. Herald added a project: All. koops requested review of this revision. Herald added subscribers: cfe-commits, sstefan1. Herald

[PATCH] D143052: [CMake] Replace llvm_check_linker_flag and llvm_check_compiler_linker_flag

DavidSpickett accepted this revision. DavidSpickett added a comment. https://cmake.org/cmake/help/v3.18/module/CheckLinkerFlag.html Looks equivalent to me, good timing. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D143052/new/ https://reviews.llvm

[PATCH] D144634: [Clang][OpenMP] Support for Code Generation of loop bind clause

koops added a comment. bind(thread) is not working at present. I have uploaded this patch to obtain feedback mainly on this. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D144634/new/ https://reviews.llvm.org/D144634 __

[PATCH] D142905: [Driver] Change multilib selection algorithm

michaelplatings updated this revision to Diff 499791. michaelplatings marked 2 inline comments as done. michaelplatings added a comment. - Rename args to options as suggested by @phosek - Add more comments to hopefully make the difference between flags and options clearer. Repository: rG LLVM

[PATCH] D142905: [Driver] Change multilib selection algorithm

michaelplatings added inline comments. Comment at: clang/include/clang/Driver/Multilib.h:41 + flag_set Flags; + arg_list PrintArgs; phosek wrote: > This is just a suggestion, but GCC documentation refers to these as either > "options" or "switches", not "arg

[PATCH] D144170: [clang-format] Add simple macro replacements in formatting.

sammccall added a comment. Thanks, this all looks good, at least as far as I understand it! The two-passes-over-the-whole-file approach is easier for me to follow, too. Mostly just comment nits, but I have one annoying question left about using macros with the wrong arity - I thought this was j

[PATCH] D141569: [clang-tidy] Implement CppCoreGuideline F.18

PiotrZSL added a comment. One more thing I noticed, this check can be in conflict with performance-move-const-arg. warning: std::move of the variable 'xyz' of the trivially-copyable type 'types::xyz' has no effect; remove std::move() [performance-move-const-arg] so would be nice to make sure

[PATCH] D142934: clang: Use ptrmask for pointer alignment

arsenm updated this revision to Diff 499797. arsenm added a comment. Test updates CHANGES SINCE LAST ACTION https://reviews.llvm.org/D142934/new/ https://reviews.llvm.org/D142934 Files: clang/lib/CodeGen/TargetInfo.cpp clang/test/CodeGen/PowerPC/ppc-varargs-struct.c clang/test/CodeGen/

[PATCH] D142934: clang: Use ptrmask for pointer alignment

arsenm updated this revision to Diff 499798. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D142934/new/ https://reviews.llvm.org/D142934 Files: clang/lib/CodeGen/TargetInfo.cpp clang/test/CodeGen/PowerPC/ppc-varargs-struct.c clang/test/CodeGen/arm-abi-vector.c clang/test/CodeGen/a

[PATCH] D142934: clang: Use ptrmask for pointer alignment

arsenm updated this revision to Diff 499799. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D142934/new/ https://reviews.llvm.org/D142934 Files: clang/lib/CodeGen/TargetInfo.cpp clang/test/CodeGen/PowerPC/ppc-varargs-struct.c clang/test/CodeGen/arm-abi-vector.c clang/test/CodeGen/a

[PATCH] D141215: [clang-repl][WIP] Implement pretty printing

junaire updated this revision to Diff 499801. junaire added a comment. Update tests. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D141215/new/ https://reviews.llvm.org/D141215 Files: clang/include/clang/Interpreter/Interpreter.h clang/include/

[PATCH] D140992: clang: Add __builtin_elementwise_fma

arsenm marked an inline comment as done. arsenm added inline comments. Comment at: clang/lib/Sema/SemaChecking.cpp:2615 QualType ArgTy = TheCall->getArg(0)->getType(); -QualType EltTy = ArgTy; - -if (auto *VecTy = EltTy->getAs()) - EltTy = VecTy->getElementType(

[PATCH] D141215: [clang-repl][WIP] Implement pretty printing

junaire updated this revision to Diff 499804. junaire added a comment. Rename the interface. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D141215/new/ https://reviews.llvm.org/D141215 Files: clang/include/clang/Interpreter/Interpreter.h clang/

[PATCH] D140992: clang: Add __builtin_elementwise_fma

arsenm updated this revision to Diff 499805. arsenm added a comment. Loop merge, documentation CHANGES SINCE LAST ACTION https://reviews.llvm.org/D140992/new/ https://reviews.llvm.org/D140992 Files: clang/docs/LanguageExtensions.rst clang/include/clang/Basic/Builtins.def clang/include/

[PATCH] D144638: [lit] Detect Consistent File Access Times

lenary created this revision. Herald added subscribers: pmatos, asb, ormris, steven_wu, delcypher, hiraditya, sbc100, emaste. Herald added a reviewer: alexander-shaposhnikov. Herald added a reviewer: jhenderson. Herald added projects: lld-macho, All. Herald added a reviewer: lld-macho. lenary requ

[PATCH] D144638: [lit] Detect Consistent File Access Times

lenary added reviewers: simonwallis2, mgorny. lenary added a subscriber: mgorny. lenary added a comment. Adding more reviewers. @mgorny you disabled some tests on NetBSD in the past for the same reason (rG92dc7dce4a6f117a497ced1650bc48e5b658f0ea

[PATCH] D144638: [lit] Detect Consistent File Access Times

jhenderson added a comment. This looks reasonable to me, with the caveat that I don't know a huge amount about how the different OSes access time systems work. One question though: if your antivirus was causing flakiness (as opposed to outright always-fails), won't it just move that flakiness i

[PATCH] D143984: [DebugMetadata] Simplify handling subprogram's retainedNodes field. NFCI (1/7)

jmmartinez added inline comments. Comment at: llvm/lib/IR/DIBuilder.cpp:789 + return createLocalVariable( + VMContext, getSubprogramNodesTrackingVector(Scope), Scope, Name, + /* ArgNo */ 0, File, LineNo, Ty, AlwaysPreserve, Flags, AlignInBits); krisb w

[PATCH] D144572: [C++20] Stop claiming full support for consteval (for the moment!)

aaron.ballman added a comment. In D144572#4145634 , @royjacobson wrote: > In D144572#4145614 , @cor3ntin > wrote: > >> @aaron.ballman is the plan to backport that to clang 16? I think it probably >> should. >>

[clang] e328d68 - [C++20] Stop claiming full support for consteval (for the moment!)

Author: Aaron Ballman Date: 2023-02-23T07:41:35-05:00 New Revision: e328d68d5ba1fe365c36655b8ae287928da6d3ed URL: https://github.com/llvm/llvm-project/commit/e328d68d5ba1fe365c36655b8ae287928da6d3ed DIFF: https://github.com/llvm/llvm-project/commit/e328d68d5ba1fe365c36655b8ae287928da6d3ed.diff

[PATCH] D144572: [C++20] Stop claiming full support for consteval (for the moment!)

This revision was automatically updated to reflect the committed changes. Closed by commit rGe328d68d5ba1: [C++20] Stop claiming full support for consteval (for the moment!) (authored by aaron.ballman). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D1

[PATCH] D140562: [clang][ASTImporter] Improve import of InjectedClassNameType.

donat.nagy accepted this revision. donat.nagy added a comment. This revision is now accepted and ready to land. We reviewed this commit together with @gamesh411 and it looks good to us; we see that it eliminates a possibility where a type object could "acquire" multiple aliases. Repository:

[PATCH] D144613: [RISCV] Properly diagnose mixing RVV scalable vectors with GNU vectors.

c-rhodes accepted this revision. c-rhodes added a comment. This revision is now accepted and ready to land. One minor nit but otherwise LGTM Comment at: clang/lib/Sema/SemaExpr.cpp:10769-10770 // Expressions containing GNU and SVE (fixed or sizeless) vectors are invalid

[PATCH] D144218: [Clang] [AVR] Fix USHRT_MAX for 16-bit int.

aaron.ballman added inline comments. Comment at: clang/lib/Headers/limits.h:55 #define UCHAR_MAX (__SCHAR_MAX__*2 +1) -#define USHRT_MAX (__SHRT_MAX__ *2 +1) +#define USHRT_MAX (__SHRT_MAX__ * 2U + 1U) #define UINT_MAX (__INT_MAX__ *2U +1U) mysterymath wrot

[PATCH] D144586: [PS4/PS5] Specify no or

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. LGTM, thanks for double-checking on the atomics question! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D144586/new/ https://reviews.llvm.org/D144586 ___

[PATCH] D143840: [clang] Add the check of membership for the issue #58674 and improve the lookup process

joanahalili added a comment. Heads up: We are experiencing a series of clang crashes because of this commit. What we already have so far: Unhandled DeclRefExpr UNREACHABLE executed at clang/lib/CodeGen/CGExpr.cpp:2958! We are now working on a reproducer. Repository: rG LLVM Github Monor

[PATCH] D144269: [Analyzer] Show "taint originated here" note of alpha.security.taint.TaintPropagation checker at the correct place

Szelethus added a comment. In D144269#4143066 , @NoQ wrote: > The challenging part with note tags is how do you figure out whether your bug > report is taint-related. The traditional solution is to check the `BugType` > but in this case an indeterminate

[PATCH] D144641: [clangd] Set diag data before emitting

kadircet created this revision. kadircet added a reviewer: hokein. Herald added a subscriber: arphaman. Herald added a project: All. kadircet requested review of this revision. Herald added subscribers: cfe-commits, MaskRay, ilya-biryukov. Herald added a project: clang-tools-extra. Also fixes a be

[PATCH] D144627: [Clang] Fix a crash when taking the address of a consteval lambda

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. LGTM with a minor cleanup. Comment at: clang/lib/Sema/SemaExpr.cpp:17976-17983 auto *FD = cast(DR->getDecl()); -SemaRef.Diag(DR->getBeginLoc(), diag::e

[PATCH] D144616: Skip generating this[:1] map info for non-member variable.

ABataev accepted this revision. ABataev added a comment. This revision is now accepted and ready to land. LG Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D144616/new/ https://reviews.llvm.org/D144616 ___

[PATCH] D141569: [clang-tidy] Implement CppCoreGuideline F.18

ccotter added a comment. Trivial types should not be passed by rvalue reference, but by value per the diagram under http://isocpp.github.io/CppCoreGuidelines/CppCoreGuidelines#fcall-parameter-passing. I feel like adding an option to opt-out of this is missing the point of this check, and rvalu

[PATCH] D142934: clang: Use ptrmask for pointer alignment

arichardson added a comment. The `__builtin_align_{up,down}` code generation could also make use of this IIRC. I think the reason I didn't do this initially was concerns about ptrmask not being optimized as well. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D142934/new/ https://review

[PATCH] D144638: [lit] Detect Consistent File Access Times

lenary added a comment. In D144638#4147133 , @jhenderson wrote: > This looks reasonable to me, with the caveat that I don't know a huge amount > about how the different OSes access time systems work. One question though: > if your antivirus was causing

[PATCH] D142932: Multilib YAML parsing

michaelplatings updated this revision to Diff 499824. michaelplatings added a comment. PrintArgs -> PrintOptions Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D142932/new/ https://reviews.llvm.org/D142932 Files: clang/include/clang/Driver/Multili

[PATCH] D144190: [AIX][clang] Storage Locations for Constant Pointers

qiongsiwu1 added a comment. Gentle ping for review. Thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D144190/new/ https://reviews.llvm.org/D144190 ___ cfe-commits mailing list cfe-commits@lists.llvm.

[PATCH] D124351: [Clang] Implement Change scope of lambda trailing-return-type

aaron.ballman accepted this revision. aaron.ballman added a comment. LGTM Comment at: clang/test/SemaCXX/lambda-expressions.cpp:675-676 +StringLiteral(const char (&array)[N]) +__attribute__((enable_if(__builtin_strlen(array) == 2, + "invalid str

[PATCH] D144447: [Clang] Teach buildFMulAdd to peek through fneg to find fmul.

kpn accepted this revision. kpn added a comment. This revision is now accepted and ready to land. LGTM. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D17/new/ https://reviews.llvm.org/D17 ___ cfe-

[clang] 34abc5b - [Clang] Fix a crash when taking the address of a consteval lambda

Author: Corentin Jabot Date: 2023-02-23T15:26:37+01:00 New Revision: 34abc5b75d9d995ded56a9534c230300b06f1439 URL: https://github.com/llvm/llvm-project/commit/34abc5b75d9d995ded56a9534c230300b06f1439 DIFF: https://github.com/llvm/llvm-project/commit/34abc5b75d9d995ded56a9534c230300b06f1439.diff

[PATCH] D144627: [Clang] Fix a crash when taking the address of a consteval lambda

This revision was automatically updated to reflect the committed changes. Closed by commit rG34abc5b75d9d: [Clang] Fix a crash when taking the address of a consteval lambda (authored by cor3ntin). Changed prior to commit: https://reviews.llvm.org/D144627?vs=499773&id=499831#toc Repository: r

[PATCH] D144285: [Clang] Implement CWG2518 - static_assert(false)

aaron.ballman added a comment. In D144285#4135807 , @erichkeane wrote: > In D144285#4135775 , @Endill wrote: > >> Thank you for the patch. >> Any plans to backport this to 16.x branch? > > I would not really want

[PATCH] D144285: [Clang] Implement CWG2518 - static_assert(false)

cor3ntin added inline comments. Comment at: clang/lib/Sema/SemaDeclCXX.cpp:16824-16841 if (InnerCond && isa(InnerCond)) { // Drill down into concept specialization expressions to see why they // weren't satisfied. Diag(StaticAssertLoc, diag::err_

[clang] 3b6c883 - Revert "[Clang] Implement fix for DR2628"

Author: Tobias Hieta Date: 2023-02-23T16:07:35+01:00 New Revision: 3b6c88331bcd0531d627fe27de5dbd0ac3165300 URL: https://github.com/llvm/llvm-project/commit/3b6c88331bcd0531d627fe27de5dbd0ac3165300 DIFF: https://github.com/llvm/llvm-project/commit/3b6c88331bcd0531d627fe27de5dbd0ac3165300.diff

[PATCH] D144586: [PS4/PS5] Specify no or

This revision was automatically updated to reflect the committed changes. Closed by commit rG32d441bfb4f3: [PS4/PS5] Specify no or (authored by probinson). Herald added a project: clang. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llv

[clang] 32d441b - [PS4/PS5] Specify no or

Author: Paul Robinson Date: 2023-02-23T07:09:30-08:00 New Revision: 32d441bfb4f302e02736dc922b0388c7594fd90e URL: https://github.com/llvm/llvm-project/commit/32d441bfb4f302e02736dc922b0388c7594fd90e DIFF: https://github.com/llvm/llvm-project/commit/32d441bfb4f302e02736dc922b0388c7594fd90e.diff

[PATCH] D144115: [clang] Extend pragma dump to support expressions

aaron.ballman added a comment. Thanks for this! You should add test coverage for the changes, especially around things like dependent expressions, ADL use, etc. Also, the changes need a release note and the new functionality should be explicitly documented. Comment at: clang/

[clang-tools-extra] 981e3a3 - [clangd] Set diag data before emitting

Author: Kadir Cetinkaya Date: 2023-02-23T16:10:11+01:00 New Revision: 981e3a35a14541afc6fa338abf3f31895b80eed9 URL: https://github.com/llvm/llvm-project/commit/981e3a35a14541afc6fa338abf3f31895b80eed9 DIFF: https://github.com/llvm/llvm-project/commit/981e3a35a14541afc6fa338abf3f31895b80eed9.dif

[PATCH] D144641: [clangd] Set diag data before emitting

This revision was automatically updated to reflect the committed changes. Closed by commit rG981e3a35a145: [clangd] Set diag data before emitting (authored by kadircet). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D144641/new/ https://reviews.llvm.

[PATCH] D144004: [DebugMetadata][DwarfDebug] Fix DWARF emisson of function-local imported entities (3/7)

krisb updated this revision to Diff 499848. krisb marked 2 inline comments as done. krisb added a comment. Apply review comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D144004/new/ https://reviews.llvm.org/D144004 Files: clang/test/CodeGe

[PATCH] D144004: [DebugMetadata][DwarfDebug] Fix DWARF emisson of function-local imported entities (3/7)

krisb added inline comments. Comment at: llvm/test/DebugInfo/Generic/split-dwarf-local-import3.ll:17-36 +; CHECK: DW_TAG_subprogram +; CHECK: DW_AT_name("foo") +; CHECK: DW_TAG_imported_declaration +; CHECK: NULL + +; CHECK: DW_TAG_base_type +; CHECK:

[PATCH] D144638: [lit] Detect Consistent File Access Times

int3 added inline comments. Comment at: llvm/utils/lit/lit/llvm/config.py:165 +# +# This check hopefully detects both cases, and disables tests that require +# consistent atime. lenary wrote: > jhenderson wrote: > > Is "hopefully" really needed here?

[PATCH] D144646: [Tooling][Inclusions] Add c-header and global namespace alternatives for size_t

kadircet created this revision. kadircet added a reviewer: hokein. Herald added a project: All. kadircet requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D144646 Files: clang

[PATCH] D141690: [clang] fix consteval ctor code generation assert

luken-google abandoned this revision. luken-google added a comment. seems to have fixed itself.. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D141690/new/ https://reviews.llvm.org/D141690 ___ cfe-commits

[PATCH] D144273: [clang][ASTImporter] Add VaList declaration to lookup table.

donat.nagy added a comment. @gamesh411 and I tried to understand the consequences of this change. We think it might be problematic that calling `ASTContext::getVaListTagDecl` [1] creates the VaList declaration (and on certain platforms, the declaration of `std`) even in the cases when these dec

[PATCH] D143418: [libclang] Add API to set preferred temp dir path

aaron.ballman added a comment. In D143418#4131156 , @vedgy wrote: > In D143418#4125756 , @aaron.ballman > wrote: > >>> 3. `clang_createIndex()` initializes global options based on environment >>> variable values

[PATCH] D143840: [clang] Add the check of membership for the issue #58674 and improve the lookup process

joanahalili added a comment. In D143840#4147234 , @joanahalili wrote: > Heads up: We are experiencing a series of clang crashes because of this > commit. > > What we already have so far: > > Unhandled DeclRefExpr > UNREACHABLE executed at clang/lib/

[PATCH] D143840: [clang] Add the check of membership for the issue #58674 and improve the lookup process

alexfh added a comment. In D143840#4147582 , @joanahalili wrote: > In D143840#4147234 , @joanahalili > wrote: > >> Heads up: We are experiencing a series of clang crashes because of this >> commit. >> >> What w

[PATCH] D143996: [clang-tidy][doc] Remove unused variable

carlosgalvezp added a comment. @bjosv Are you able to land the land yourself, or should we do it for you? If so, please provide user and email for Github attribution. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D143996/new/ https://reviews.llvm.org/D143996 ___

[clang] 25d23b1 - [Clang][NFC] Remove pointless defines from test command lines

Author: John Brawn Date: 2023-02-23T16:18:24Z New Revision: 25d23b1970ea023d83d462402fd43038b41c13a3 URL: https://github.com/llvm/llvm-project/commit/25d23b1970ea023d83d462402fd43038b41c13a3 DIFF: https://github.com/llvm/llvm-project/commit/25d23b1970ea023d83d462402fd43038b41c13a3.diff LOG: [C

[PATCH] D144216: [clang-tidy] Extract string header from redundant-string-cstr checker

carlosgalvezp added a comment. In D144216#4135395 , @mikecrowe wrote: >> If you're suggesting that I could use the new header to replace >> declarations of basic_string etc. in other tests then I think that would be >> possible with some careful checki

[PATCH] D140992: clang: Add __builtin_elementwise_fma

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. LGTM! Comment at: clang/lib/Sema/SemaChecking.cpp:17761-17766 + for (int I = 0; I < 3; ++I) { +ExprResult Converted = UsualUnaryConversions(TheCall->getArg

[clang] 1812e13 - Revert "[clang] Add the check of membership for the issue #58674 and improve the lookup process"

Author: Alexander Kornienko Date: 2023-02-23T17:31:04+01:00 New Revision: 1812e13a3d6be9a838672ff74b3d9d383f5a83b5 URL: https://github.com/llvm/llvm-project/commit/1812e13a3d6be9a838672ff74b3d9d383f5a83b5 DIFF: https://github.com/llvm/llvm-project/commit/1812e13a3d6be9a838672ff74b3d9d383f5a83b5

[PATCH] D143496: [clangd] Add support for missing includes analysis.

VitaNuo updated this revision to Diff 499879. VitaNuo marked 18 inline comments as done. VitaNuo added a comment. Address review comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D143496/new/ https://reviews.llvm.org/D143496 Files: clang-to

[PATCH] D143496: [clangd] Add support for missing includes analysis.

VitaNuo added a comment. Thanks for the comments! Comment at: clang-tools-extra/clangd/IncludeCleaner.cpp:408 + +bool isFilteredByConfig(const Config &Cfg, llvm::StringRef HeaderSpelling) { + for (auto &Filter : Cfg.Diagnostics.Includes.IgnoreHeader) { kadirce

[PATCH] D143996: [clang-tidy][doc] Remove unused variable

bjosv added a comment. @carlosgalvezp Sorry, I should have mentioned that I don't have push rights and that this is my first contribution. My GitHub user is: bjosv and email: bjorn.a.svens...@est.tech Thanks. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D143996/new/ https://reviews

[clang] dbf149c - [RISCV] Properly diagnose mixing RVV scalable vectors with GNU vectors.

Author: Craig Topper Date: 2023-02-23T09:00:32-08:00 New Revision: dbf149c91b7bdf08b2d4dd94ab76f3209af4c6d4 URL: https://github.com/llvm/llvm-project/commit/dbf149c91b7bdf08b2d4dd94ab76f3209af4c6d4 DIFF: https://github.com/llvm/llvm-project/commit/dbf149c91b7bdf08b2d4dd94ab76f3209af4c6d4.diff

[PATCH] D144613: [RISCV] Properly diagnose mixing RVV scalable vectors with GNU vectors.

This revision was automatically updated to reflect the committed changes. Closed by commit rGdbf149c91b7b: [RISCV] Properly diagnose mixing RVV scalable vectors with GNU vectors. (authored by craig.topper). Changed prior to commit: https://reviews.llvm.org/D144613?vs=499711&id=499882#toc Repos

[clang] 83cd4be - [Clang] Teach buildFMulAdd to peek through fneg to find fmul.

Author: Craig Topper Date: 2023-02-23T09:05:59-08:00 New Revision: 83cd4bea015feb5729871832784c424b0743a803 URL: https://github.com/llvm/llvm-project/commit/83cd4bea015feb5729871832784c424b0743a803 DIFF: https://github.com/llvm/llvm-project/commit/83cd4bea015feb5729871832784c424b0743a803.diff

[PATCH] D144447: [Clang] Teach buildFMulAdd to peek through fneg to find fmul.

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG83cd4bea015f: [Clang] Teach buildFMulAdd to peek through fneg to find fmul. (authored by craig.topper). Repository: rG LLVM Github Monorepo CHANG

[PATCH] D144651: [Serialization] Place command line defines in the correct file

john.brawn created this revision. john.brawn added reviewers: mstorsjo, jansvoboda11, DHowett-MSFT, sammccall. Herald added a project: All. john.brawn requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Fix two problems happening during deseria

[PATCH] D144626: [C++20] [Modules] Provide OriginalTrailingRequiresClause for serializer to perform ODR-Checking correctly

erichkeane added a comment. I think the problem is more that we are modifying the expression in the AST. I don't think now that we have the 'deferred concepts instantiation' that we should be storing/saving the updated requires clause back to the AST, right? We should be re-evaluating it (wit

[PATCH] D143496: [clangd] Add support for missing includes analysis.

VitaNuo updated this revision to Diff 499886. VitaNuo added a comment. Upload once again. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D143496/new/ https://reviews.llvm.org/D143496 Files: clang-tools-extra/clangd/Config.h clang-tools-extra/cla

[PATCH] D144626: [C++20] [Modules] Provide OriginalTrailingRequiresClause for serializer to perform ODR-Checking correctly

erichkeane added a comment. Woops, I just saw my fixme :D I forgot we needed to do that for comparison of constraints. That said I dont think you need to store it, I think we can just pick up the 'original' one from the primary template. I did work at one point to make sure that the get-inst

  1   2   >