[clang] abe997b - [CMake][Fuchsia] Switch to lld on Apple platforms

Author: Petr Hosek Date: 2022-03-22T01:06:30-07:00 New Revision: abe997bb2dd61188784954ae866352740629985d URL: https://github.com/llvm/llvm-project/commit/abe997bb2dd61188784954ae866352740629985d DIFF: https://github.com/llvm/llvm-project/commit/abe997bb2dd61188784954ae866352740629985d.diff LO

[PATCH] D122047: [CMake][Fuchsia] Switch to lld on Apple platforms

This revision was automatically updated to reflect the committed changes. Closed by commit rGabe997bb2dd6: [CMake][Fuchsia] Switch to lld on Apple platforms (authored by phosek). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D122047/new/ https://revi

[PATCH] D118493: Set rpath on openmp executables

JonChesterfield added a comment. It lets applications run with the libomp and libomptarget built with the toolchain. For users, they don't have to be root. For compiler devs, we test our work instead of whatever the distro had installed. There's no info at that link. What's 'broken rpath'? If t

[PATCH] D122119: [C++20][Modules] Adjust handling of exports of namespaces and using-decls.

iains marked 2 inline comments as done. iains added subscribers: vsapsai, dblaikie. iains added a comment. So the adjustment to the error message is something I am 50/50 about (IMO it makes some messages more useful, but maybe not needed in others). Without the change we get "cannot export rede

[PATCH] D118996: [clang-tidy] Support C++14 in bugprone-signal-handler.

balazske added inline comments. Herald added a project: All. Comment at: clang-tools-extra/clang-tidy/bugprone/SignalHandlerCheck.cpp:153 +diag(HandlerLambda->getBeginLoc(), + "lambda function is not allowed as signal handler (until C++17)") +<< HandlerLambda-

[clang] 2ddd57a - [clang][dataflow] Model the behavior of optional and std swap

Author: Stanislav Gatev Date: 2022-03-22T08:35:34Z New Revision: 2ddd57ae1ec42c4aad8e70645cff82c877a94e3f URL: https://github.com/llvm/llvm-project/commit/2ddd57ae1ec42c4aad8e70645cff82c877a94e3f DIFF: https://github.com/llvm/llvm-project/commit/2ddd57ae1ec42c4aad8e70645cff82c877a94e3f.diff LO

[PATCH] D122129: [clang][dataflow] Model the behavior of optional and std swap

This revision was automatically updated to reflect the committed changes. Closed by commit rG2ddd57ae1ec4: [clang][dataflow] Model the behavior of optional and std swap (authored by sgatev). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D122129/new/

[clang] a9656bd - [CodeGen][OpenMP] Make EmitLoadOfPointer() type consistent

Author: Nikita Popov Date: 2022-03-22T09:37:48+01:00 New Revision: a9656bd1bc3792b81ad5a7277bdf7d8159b3b924 URL: https://github.com/llvm/llvm-project/commit/a9656bd1bc3792b81ad5a7277bdf7d8159b3b924 DIFF: https://github.com/llvm/llvm-project/commit/a9656bd1bc3792b81ad5a7277bdf7d8159b3b924.diff

[clang] 767ec88 - [CodeGen] Avoid deprecated Address ctor in EmitLoadOfPointer()

Author: Nikita Popov Date: 2022-03-22T09:42:31+01:00 New Revision: 767ec883e37510a247ea5695921876ef67cf5b3f URL: https://github.com/llvm/llvm-project/commit/767ec883e37510a247ea5695921876ef67cf5b3f DIFF: https://github.com/llvm/llvm-project/commit/767ec883e37510a247ea5695921876ef67cf5b3f.diff

[PATCH] D122199: [NFC][Clang][OpaquePtr] Remove calls to Address::deprecated in TargetInfo.cpp

nikic accepted this revision. nikic added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D122199/new/ https://reviews.llvm.org/D122199 ___ c

[PATCH] D122215: [WebAssembly] Initial support for reference types in clang

pmatos created this revision. pmatos added reviewers: tlively, asb. Herald added subscribers: StephenFan, wingo, dexonsmith, ecnelises, arphaman, martong, sunfish, hiraditya, jgravelle-google, sbc100, dschuff. Herald added a reviewer: shafik. Herald added a reviewer: aaron.ballman. Herald added a

[PATCH] D122215: [WebAssembly] Initial support for reference types in clang

pmatos planned changes to this revision. pmatos added a comment. Test `wasm-funcref.c` still fails as type attribute `funcref` semantics are not yet implemented. Not ready to land yet. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D122215/new/ http

[PATCH] D118493: Set rpath on openmp executables

JonChesterfield added a subscriber: estewart08. JonChesterfield added a comment. @estewart08 Fedora are rejecting some uses of rpath (and probably runpath). I can't find a corresponding page for redhat. This may become a problem for our aomp/rocm builds. Repository: rG LLVM Github Monorepo

[PATCH] D121824: [clang] Do not crash on arrow operator on dependent type.

hokein accepted this revision. hokein added a comment. This revision is now accepted and ready to land. Thanks, looks good! please update the description of the patch accordingly (saying we invalidate the vardecl) Comment at: clang/test/SemaCXX/arrow-operator.cpp:79 +void foo

[clang] b8f0e12 - [CodeGen] Remove some uses of deprecated Address constructor

Author: Nikita Popov Date: 2022-03-22T10:02:35+01:00 New Revision: b8f0e12847f5df0792c816c995bc67759aea669e URL: https://github.com/llvm/llvm-project/commit/b8f0e12847f5df0792c816c995bc67759aea669e DIFF: https://github.com/llvm/llvm-project/commit/b8f0e12847f5df0792c816c995bc67759aea669e.diff

[PATCH] D122119: [C++20][Modules] Adjust handling of exports of namespaces and using-decls.

ChuanqiXu added a comment. In D122119#3398823 , @iains wrote: > So the adjustment to the error message is something I am 50/50 about (IMO it > makes some messages more useful, but maybe not needed in others). > > Without the change we get > "cannot expo

[clang-tools-extra] 3e7a8aa - [clang-tidy] Don't try to build CTTestTidyModule for Windows with dylibs

Author: Martin Storsjö Date: 2022-03-22T11:08:32+02:00 New Revision: 3e7a8aab759a9bdf90f35a60ea6e96ec64e36cb9 URL: https://github.com/llvm/llvm-project/commit/3e7a8aab759a9bdf90f35a60ea6e96ec64e36cb9 DIFF: https://github.com/llvm/llvm-project/commit/3e7a8aab759a9bdf90f35a60ea6e96ec64e36cb9.diff

[PATCH] D121687: [clang-tidy] Don't try to build CTTestTidyModule for Windows with dylibs

This revision was automatically updated to reflect the committed changes. Closed by commit rG3e7a8aab759a: [clang-tidy] Don't try to build CTTestTidyModule for Windows with dylibs (authored by mstorsjo). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D

[PATCH] D122119: [C++20][Modules] Adjust handling of exports of namespaces and using-decls.

iains marked 2 inline comments as done. iains added a comment. In D122119#3398949 , @ChuanqiXu wrote: > In D122119#3398823 , @iains wrote: > >> So the adjustment to the error message is something I am 50/50 about

[clang] f42b195 - [CodeGen][RISCV] Avoid deprecated address constructor

Author: Nikita Popov Date: 2022-03-22T10:15:19+01:00 New Revision: f42b1954a0e85fadd421d5e345cb8343c410b34d URL: https://github.com/llvm/llvm-project/commit/f42b1954a0e85fadd421d5e345cb8343c410b34d DIFF: https://github.com/llvm/llvm-project/commit/f42b1954a0e85fadd421d5e345cb8343c410b34d.diff

[clang] 9ab18cc - [RISCV] Add policy operand for masked vid and viota IR intrinsics.

Author: Zakk Chen Date: 2022-03-22T02:32:31-07:00 New Revision: 9ab18cc535379c3442bf52e21fbe21c92eb0fd60 URL: https://github.com/llvm/llvm-project/commit/9ab18cc535379c3442bf52e21fbe21c92eb0fd60 DIFF: https://github.com/llvm/llvm-project/commit/9ab18cc535379c3442bf52e21fbe21c92eb0fd60.diff LOG

[PATCH] D120227: [RISCV] Add policy operand for masked vid and viota IR intrinsics.

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG9ab18cc53537: [RISCV] Add policy operand for masked vid and viota IR intrinsics. (authored by khchen). Herald added subscribers: s, StephenFan, arich

[PATCH] D122150: [clang][analyzer] Add checker for bad use of 'errno'.

balazske added reviewers: martong, steakhal, NoQ. balazske added a comment. Herald added a subscriber: rnkovacs. This checker is made to add a partial support for CERT rule ERR30-C . One part of the rule is "check errno

[PATCH] D121756: [clang-format] Clean up code looking for if statements

MyDeveloperDay added a comment. > It turned out this patch does change behavior. i.e. now your function is considering more things, the formatted code is different, do you think the new formatting is more correct? (I mean it feels like it should be right? assuming we want to consider whiles in

[clang-tools-extra] 1579090 - Reland "[pseudo] Split greatergreater token."

Author: Haojian Wu Date: 2022-03-22T10:27:52+01:00 New Revision: 1579090141c5cc061f3a0b62cd92bd93802ddcf7 URL: https://github.com/llvm/llvm-project/commit/1579090141c5cc061f3a0b62cd92bd93802ddcf7 DIFF: https://github.com/llvm/llvm-project/commit/1579090141c5cc061f3a0b62cd92bd93802ddcf7.diff LO

[PATCH] D121756: [clang-format] Clean up code looking for if statements

MyDeveloperDay added a comment. In D121756#3398165 , @sstwcw wrote: > It turned out this patch does change behavior. > > - while ( > - FormatTok->isOneOf(tok::identifier, tok::kw_requires, > tok::coloncolon)) { > + while (FormatTok->isOneOf(

[PATCH] D121370: [clang-format] SortIncludes should support "@import" lines in Objective-C

kwk added a comment. @MyDeveloperDay can you please have another look now that the patch has additional tests and most comments that still apply have been addressed? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D121370/new/ https://reviews.llvm.or

[PATCH] D121756: [clang-format] Clean up code looking for if statements

MyDeveloperDay added a comment. FWIW I'm not a fan of the `while( \n` case, so assuming this fix, fixes that then that would be good I think. - while ( - FormatTok->isOneOf(tok::identifier, tok::kw_requires, tok::coloncolon)) { + while (FormatTok->isOneOf(tok::identifier, tok::kw_r

[PATCH] D122139: [pseudo] Introduce parse forest.

hokein updated this revision to Diff 417225. hokein marked 7 inline comments as done. hokein added a comment. address review comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D122139/new/ https://reviews.llvm.org/D122139 Files: clang-tools-

[PATCH] D122143: [clang][dataflow] Add support for disabling warnings on smart pointers.

sgatev accepted this revision. sgatev added inline comments. This revision is now accepted and ready to land. Comment at: clang/include/clang/Analysis/FlowSensitive/Models/UncheckedOptionalAccessModel.h:31 +struct UncheckedOptionalAccessModelOptions { + /// Ignore optionals rea

[PATCH] D121756: [clang-format] Clean up code looking for if statements

owenpan requested changes to this revision. owenpan added inline comments. Comment at: clang/lib/Format/ContinuationIndenter.cpp:749 + if (Current.isNot(tok::comment) && + Previous.isConditionLParen(/*IncludeSpecial=*/true)) { // Treat the condition inside an if as if

[clang] 51ba13b - [CGStmtOpenMP] Remove uses of deprecated Address constructor

Author: Nikita Popov Date: 2022-03-22T11:00:08+01:00 New Revision: 51ba13b1aea3d6e04310b80b6bcfc641049b9890 URL: https://github.com/llvm/llvm-project/commit/51ba13b1aea3d6e04310b80b6bcfc641049b9890 DIFF: https://github.com/llvm/llvm-project/commit/51ba13b1aea3d6e04310b80b6bcfc641049b9890.diff

[PATCH] D120824: [clang][ASTImporter] Fix a bug when importing CXXDefaultInitExpr.

balazske added a comment. Ping I had a question about if the lit-test is needed with the new unit tests (that contain essentially similar code). But if there is no answer I will commit it with all tests, more test is always better. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTI

[PATCH] D118935: [SYCL] Disallow explicit casts between mismatching address spaces

Fznamznon added a comment. > I misread what was done with addrspace_cast, that new operator only allows > conversions that are otherwise also allowed. Based on that, this change does > actually align with what was done for OpenCL mode, it does not restrict > anything that is allowed in OpenCL m

[PATCH] D122160: [clang][extract-api] Refactor ExtractAPI and improve docs

dang accepted this revision. dang added a comment. This revision is now accepted and ready to land. LGTM once the last few bits of feedback I left are considered. Comment at: clang/include/clang/ExtractAPI/API.h:139 + /// Create and add a global variable record into the API

[PATCH] D122215: [WebAssembly] Initial support for reference types in clang

asb added inline comments. Comment at: clang/test/CodeGen/WebAssembly/wasm-externref.c:1 +// RUN: %clang_cc1 -triple wasm32-unknown-unknown -target-feature +reference-types -o - -emit-llvm %s | FileCheck %s + It might be worth using update_cc_test_checks.py for

[PATCH] D121201: [clang] Merge the SourceRange into ParsedAttributes

tbaeder updated this revision to Diff 417235. tbaeder marked 5 inline comments as done. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D121201/new/ https://reviews.llvm.org/D121201 Files: clang/include/clang/Parse/Parser.h clang/include/clang/Sema/DeclSpec.h clang/include/clang/Sema/

[PATCH] D121201: [clang] Merge the SourceRange into ParsedAttributes

tbaeder added inline comments. Comment at: clang/include/clang/Sema/DeclSpec.h:2516-2521 + void takeAttributes(ParsedAttributes &attrs) { Attrs.takeAllFrom(attrs); -if (!lastLoc.isInvalid()) - SetRangeEnd(lastLoc); +if (attrs.Range.getEnd().isValid()) +

[PATCH] D118935: [SYCL] Disallow explicit casts between mismatching address spaces

keryell added a comment. Yes, your comment idea looks good and helpful to me. Thanks. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D118935/new/ https://reviews.llvm.org/D118935 ___ cfe-commits mailing li

[clang] 73777b4 - [Debugify] Optimize debugify original mode

Author: Djordje Todorovic Date: 2022-03-22T12:14:00+01:00 New Revision: 73777b4c35a390617cce0f6b4516e98fe5a88df1 URL: https://github.com/llvm/llvm-project/commit/73777b4c35a390617cce0f6b4516e98fe5a88df1 DIFF: https://github.com/llvm/llvm-project/commit/73777b4c35a390617cce0f6b4516e98fe5a88df1.d

[PATCH] D115622: [Debugify] Optimize debugify original mode

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG73777b4c35a3: [Debugify] Optimize debugify original mode (authored by djtodoro). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D121873: [clang][extract-api] Add enum support

dang added inline comments. Comment at: clang/include/clang/ExtractAPI/API.h:33 +namespace { + I still think this belongs in `APISet`. It belongs there because it defines unique pointers that are specifically tied to the lifetime of `APISet`. Any other thing

[PATCH] D122143: [clang][dataflow] Add support for disabling warnings on smart pointers.

ymandel updated this revision to Diff 417243. ymandel marked an inline comment as done. ymandel added a comment. Addressed comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D122143/new/ https://reviews.llvm.org/D122143 Files: clang/include/

[PATCH] D122143: [clang][dataflow] Add support for disabling warnings on smart pointers.

ymandel marked 4 inline comments as done. ymandel added inline comments. Comment at: clang/include/clang/Analysis/FlowSensitive/Models/UncheckedOptionalAccessModel.h:31 +struct UncheckedOptionalAccessModelOptions { + /// Ignore optionals reachable by derefencing a smart pointer

[PATCH] D121824: [clang] Do not crash on arrow operator on dependent type.

sammccall added a comment. I reduced something very similar recently as https://github.com/clangd/clangd/issues/1073 This patch does not fix it, but looks closely related, want to take a look? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D121824/n

[PATCH] D122008: [flang][driver] Add support for generating executables

rovka accepted this revision. rovka added a comment. This revision is now accepted and ready to land. LGTM :) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D122008/new/ https://reviews.llvm.org/D122008 __

[clang] 9858884 - [analyzer] Refactor makeNull to makeNullWithWidth (NFC)

Author: Vince Bridgers Date: 2022-03-22T07:35:13-05:00 New Revision: 985888411da9c62aea7b0b41f93eb75ad31587a6 URL: https://github.com/llvm/llvm-project/commit/985888411da9c62aea7b0b41f93eb75ad31587a6 DIFF: https://github.com/llvm/llvm-project/commit/985888411da9c62aea7b0b41f93eb75ad31587a6.diff

[PATCH] D119601: [analyzer] Refactor makeNull to makeNullWithWidth (NFC)

This revision was automatically updated to reflect the committed changes. Closed by commit rG985888411da9: [analyzer] Refactor makeNull to makeNullWithWidth (NFC) (authored by vabridgers, committed by einvbri ). Repository: rG LLVM Github Monorepo CHANGES SINCE

[PATCH] D122224: Allow -Wno-gnu to silence GNU extensions related to pointer arithmetic

aaron.ballman created this revision. aaron.ballman added reviewers: nickdesaulniers, andrew.w.kaylor, eli.friedman, erichkeane. Herald added a project: All. aaron.ballman requested review of this revision. Herald added a project: clang. These diagnostics were added to a diagnostic group, but that

[PATCH] D122150: [clang][analyzer] Add checker for bad use of 'errno'.

steakhal requested changes to this revision. steakhal added a comment. This revision now requires changes to proceed. I'm liking it. We need to improve the diagnostics and the user-facing docs as well. Comment at: clang/include/clang/StaticAnalyzer/Checkers/Checkers.td:545 +

[PATCH] D119017: [clang] roll-forward "[clang] Mark `trivial_abi` types as "trivially relocatable"".

aaron.ballman added a comment. Hello, @devin.jeanpierre! I'm wondering if we should revert this while you investigate the fix, or do you think you'll have this solved sometime today? Thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D119017/new

[PATCH] D111400: [Clang][C++2b] P2242R3: Non-literal variables [...] in constexpr

erichkeane added a comment. 1 request for a test, and 1 hope that @aaron.ballman will help bikeshed (or just say its fine!), but otherwise LGTM. Comment at: clang/include/clang/Basic/DiagnosticASTKinds.td:69 +def note_constexpr_static_local : Note< + "control flows through th

[PATCH] D111400: [Clang][C++2b] P2242R3: Non-literal variables [...] in constexpr

aaron.ballman accepted this revision. aaron.ballman added a comment. I don't spot anything overly concerning in this patch, I believe it LGTM as well. Comment at: clang/test/CXX/dcl.dcl/dcl.spec/dcl.constexpr/p3-2b.cpp:38 + if (!b) +NonLiteral n; +} huber

[PATCH] D111400: [Clang][C++2b] P2242R3: Non-literal variables [...] in constexpr

aaron.ballman added inline comments. Comment at: clang/include/clang/Basic/DiagnosticASTKinds.td:69 +def note_constexpr_static_local : Note< + "control flows through the declaration of a %select{static|thread_local}0 variable">; def note_constexpr_subobject_declared_here : Not

[PATCH] D111400: [Clang][C++2b] P2242R3: Non-literal variables [...] in constexpr

erichkeane added inline comments. Comment at: clang/include/clang/Basic/DiagnosticASTKinds.td:69 +def note_constexpr_static_local : Note< + "control flows through the declaration of a %select{static|thread_local}0 variable">; def note_constexpr_subobject_declared_here : Note<

[clang] 5856f30 - [LTO] Add configuartion option to use default optimization pipeline

Author: Joseph Huber Date: 2022-03-22T09:28:45-04:00 New Revision: 5856f30b5ae06153ff4a7d3db73ff8d9a05b4144 URL: https://github.com/llvm/llvm-project/commit/5856f30b5ae06153ff4a7d3db73ff8d9a05b4144 DIFF: https://github.com/llvm/llvm-project/commit/5856f30b5ae06153ff4a7d3db73ff8d9a05b4144.diff

[PATCH] D122133: [LTO] Add configuartion option to use default optimization pipeline

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG5856f30b5ae0: [LTO] Add configuartion option to use default optimization pipeline (authored by jhuber6). Repository: rG LLVM Github Monorepo CHAN

[PATCH] D121451: [clang-format] Add space to comments starting with '#'.

curdeius added a comment. In D121451#3395801 , @krasimir wrote: > This makes me think that we should really consider not adding indent if the > first character is punctuation WAI, with rationale: That was the case before this patch. > - comments starti

[PATCH] D121916: [clang-format] [doc] Add script to automatically update help output in ClangFormat.rst.

curdeius added a comment. If nobody is against this patch. I'll land it soon, probably tomorrow. Comment at: clang/docs/tools/dump_format_help.py:29 +def get_help_output(): +args = ["clang-format", "--help"] +cmd = subprocess.Popen(args, stdout=subprocess.PIPE,

[PATCH] D122179: Serialize PragmaAssumeNonNullLoc to support preambles

sammccall added inline comments. Comment at: clang-tools-extra/clangd/unittests/DiagnosticsTests.cpp:748 +TEST(DiagnosticsTest, PreambleWithPragmaAssumeNonnull) { + Annotations Header(R"cpp( This test seems to have a lot of extraneous elements. The following

[PATCH] D121451: [clang-format] Add space to comments starting with '#'.

krasimir added a comment. > So I'd rather keep the old behaviour for # in Proto but not in C-like > languages. Is that acceptable? Sounds good. I'll work on a patch doing that. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D121451/new/ https://rev

[PATCH] D121450: [clang-format] Handle attributes before case label.

curdeius added a comment. In D121450#3397861 , @jgorbe wrote: > Hi, > > We've observed that this patch introduces infinite loops in some cases. > Here's a reduced test case: > > export class Foo extends Bar { > get case(): Case { > return ( >

[PATCH] D121450: [clang-format] Handle attributes before case label.

curdeius added inline comments. Comment at: clang/lib/Format/UnwrappedLineParser.cpp:1826 + if (Style.isJavaScript() && Line->MustBeDeclaration) +// 'case: string' field declaration. +break; HazardyKnusperkeks wrote: > Here's the loop. In the

[PATCH] D122155: Add warning when eval-method is set in the presence of value unsafe floating-point calculations.

zahiraam updated this revision to Diff 417279. zahiraam marked 5 inline comments as done. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D122155/new/ https://reviews.llvm.org/D122155 Files: clang/include/clang/Basic/DiagnosticCommonKinds.td clang/lib/Sema/Sema.cpp clang/lib/Sema/Sema

[PATCH] D122102: [clangd] Introduce "add subclass" tweak

avogelsgesang added a comment. Thank for your comments, @adamcz and @njames93! I agree that a "Implement interface" tweak is probably more useful, and I can imagine to evolve this tweak in that direction. The main reason, I first went for the "create a new class from scratch" approach, was bec

[PATCH] D122227: Fix _BitInt suffix width calculation

aaron.ballman created this revision. aaron.ballman added reviewers: mgehre-amd, erichkeane. Herald added a project: All. aaron.ballman requested review of this revision. Herald added a project: clang. @mgehre-amd pointed out the following post-commit review feedback on the changes in 8cba72177dcd

[PATCH] D122102: [clangd] Introduce "add subclass" tweak

avogelsgesang added a comment. @adamcz > Ideally I'd like to see this code action show up as code completion option as > well. I think in the long-term such a "Implement methods" code action should also apply as a quickfix for class Base { virtual void foo() = 0; }; class Derive

[PATCH] D122227: Fix _BitInt suffix width calculation

mgehre-amd accepted this revision. mgehre-amd added a comment. Thanks a lot! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D17/new/ https://reviews.llvm.org/D17 ___ cfe-commits mailing list cfe-co

[clang] 9cf8f81 - Fix _BitInt suffix width calculation

Author: Aaron Ballman Date: 2022-03-22T10:00:05-04:00 New Revision: 9cf8f81ca45de198013f29442a7de6600b226d70 URL: https://github.com/llvm/llvm-project/commit/9cf8f81ca45de198013f29442a7de6600b226d70 DIFF: https://github.com/llvm/llvm-project/commit/9cf8f81ca45de198013f29442a7de6600b226d70.diff

[PATCH] D122227: Fix _BitInt suffix width calculation

aaron.ballman closed this revision. aaron.ballman added a comment. Thanks for the quick reviews, and thanks for catching the issue @mgehre-amd! I've committed in 9cf8f81ca45de198013f29442a7de6600b226d70 . Repository: rG LLV

[clang] 73c0d05 - [CGOpenMPRuntimeGPU] Remove uses of deprecated address constructor

Author: Nikita Popov Date: 2022-03-22T15:02:45+01:00 New Revision: 73c0d05e6a90612399de06a98201e9d6a9059797 URL: https://github.com/llvm/llvm-project/commit/73c0d05e6a90612399de06a98201e9d6a9059797 DIFF: https://github.com/llvm/llvm-project/commit/73c0d05e6a90612399de06a98201e9d6a9059797.diff

[PATCH] D122230: [clang-format] don't break up #-style comment sections

krasimir created this revision. Herald added a project: All. krasimir requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Follow-up from https://github.com/llvm/llvm-project/commit/36d13d3f8adb3d1a6bae71370afa23d11a94dc78. Restore the old beh

[PATCH] D122231: [clang][dataflow] Add support for `value_or` in a comparison.

ymandel created this revision. ymandel added reviewers: sgatev, xazax.hun. Herald added subscribers: tschuett, steakhal, rnkovacs. Herald added a project: All. ymandel requested review of this revision. Herald added a project: clang. This patch adds limited modeling of the `value_or` method. Speci

[PATCH] D122155: Add warning when eval-method is set in the presence of value unsafe floating-point calculations.

aaron.ballman requested changes to this revision. aaron.ballman added inline comments. This revision now requires changes to proceed. Comment at: clang/include/clang/Basic/DiagnosticCommonKinds.td:127-129 +def warn_eval_method_setting_is_meaningless_in_value_unsafe_context : Warn

[PATCH] D122230: [clang-format] don't break up #-style comment sections

MyDeveloperDay added a comment. I hit something like this today with some code which was //#undef I'm not sure I think that // #undef or //# undef is what I want either Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D122230/new/ https://r

[PATCH] D122230: [clang-format] don't break up #-style comment sections

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGeb35e0ecbe0a: [clang-format] don't break up #-style comment sections (authored by krasimir). Repository: rG LLVM Github Monorepo CHANGES SINCE LA

[clang] eb35e0e - [clang-format] don't break up #-style comment sections

Author: Krasimir Georgiev Date: 2022-03-22T15:29:02+01:00 New Revision: eb35e0ecbe0ae153481f1df16d91cc6001477d21 URL: https://github.com/llvm/llvm-project/commit/eb35e0ecbe0ae153481f1df16d91cc6001477d21 DIFF: https://github.com/llvm/llvm-project/commit/eb35e0ecbe0ae153481f1df16d91cc6001477d21.d

[clang] 4f5640c - [CGOpenMPRuntime] Remove some uses of deprecated Address ctor

Author: Nikita Popov Date: 2022-03-22T15:35:45+01:00 New Revision: 4f5640cad3e0cdff9ab8d6b63c9abd760c32832b URL: https://github.com/llvm/llvm-project/commit/4f5640cad3e0cdff9ab8d6b63c9abd760c32832b DIFF: https://github.com/llvm/llvm-project/commit/4f5640cad3e0cdff9ab8d6b63c9abd760c32832b.diff

[PATCH] D121201: [clang] Merge the SourceRange into ParsedAttributes

aaron.ballman added inline comments. Comment at: clang/include/clang/Sema/DeclSpec.h:2516-2521 + void takeAttributes(ParsedAttributes &attrs) { Attrs.takeAllFrom(attrs); -if (!lastLoc.isInvalid()) - SetRangeEnd(lastLoc); +if (attrs.Range.getEnd().isValid()) +

[PATCH] D122111: [clang-tidy] Fix false positives in `misc-redundant-expression` check

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. LGTM! Please also add a release note for the fix when you land it. Comment at: clang-tools-extra/clang-tidy/misc/RedundantExpressionCheck.cpp:605 + unl

[PATCH] D120228: [RISCV] Add policy operand for masked compare and vmsbf/vmsif/vmsof IR intrinsics.

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG10fd2822b77e: [RISCV] Add policy operand for masked compare and vmsbf/vmsif/vmsof IR (authored by khchen). Herald added a subscriber: StephenFan. Ch

[PATCH] D122232: [clang][NFC] Refactor logic for picking standard library on Apple

ldionne created this revision. ldionne added a reviewer: egorzhdan. Herald added a project: All. ldionne requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Flip the logic around: always default to libc++ except on older platforms, instead of d

[PATCH] D120134: [analyzer] refactor makeIntValWithPtrWidth, remove getZeroWithPtrWidth (NFC)

vabridgers updated this revision to Diff 417300. vabridgers added a comment. rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D120134/new/ https://reviews.llvm.org/D120134 Files: clang/include/clang/StaticAnalyzer/Core/PathSensitive/BasicValu

[PATCH] D120134: [analyzer] refactor makeIntValWithPtrWidth, remove getZeroWithPtrWidth (NFC)

vabridgers added a comment. ping! @steakhal accepted, should we wait for @NoQ before landing? Thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D120134/new/ https://reviews.llvm.org/D120134 ___ cfe-co

[PATCH] D121201: [clang] Merge the SourceRange into ParsedAttributes

tbaeder marked an inline comment as done. tbaeder added inline comments. Comment at: clang/include/clang/Sema/DeclSpec.h:2516-2521 + void takeAttributes(ParsedAttributes &attrs) { Attrs.takeAllFrom(attrs); -if (!lastLoc.isInvalid()) - SetRangeEnd(lastLoc); +i

[PATCH] D107141: [Inline-asm] Add diagnosts for unsupported inline assembly arguments

pengfei updated this revision to Diff 417303. pengfei added a comment. Address review comment. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D107141/new/ https://reviews.llvm.org/D107141 Files: clang/include/clang/Basic/DiagnosticSemaKinds.td c

[PATCH] D107141: [Inline-asm] Add diagnosts for unsupported inline assembly arguments

pengfei added inline comments. Comment at: clang/lib/Sema/SemaStmtAsm.cpp:622 +if (InTy->isIntegerType() || InTy->isPointerType() || +InTy->isStructureType() || InTy->isConstantArrayType()) InputDomain = AD_Int; jyu2 wrote: > pengfei wrote: > >

[PATCH] D121201: [clang] Merge the SourceRange into ParsedAttributes

aaron.ballman added inline comments. Comment at: clang/include/clang/Sema/DeclSpec.h:2516-2521 + void takeAttributes(ParsedAttributes &attrs) { Attrs.takeAllFrom(attrs); -if (!lastLoc.isInvalid()) - SetRangeEnd(lastLoc); +if (attrs.Range.getEnd().isValid()) +

[PATCH] D121201: [clang] Merge the SourceRange into ParsedAttributes

erichkeane added inline comments. Comment at: clang/include/clang/Sema/DeclSpec.h:2516-2521 + void takeAttributes(ParsedAttributes &attrs) { Attrs.takeAllFrom(attrs); -if (!lastLoc.isInvalid()) - SetRangeEnd(lastLoc); +if (attrs.Range.getEnd().isValid()) +

[PATCH] D119721: [clang][lex] Use `ConstSearchDirIterator` in lookup cache

sberg added subscribers: rnk, sberg. sberg added a comment. Herald added a project: All. I started to experience Clang crashing when building Firebird (as part of building LibreOffice) in clang-cl mode on Windows, and I think it is due to this change in combination with D2733

[PATCH] D122234: [clang] Link libbitint for large division of _BitInt; increase max _BitInt size

mgehre-amd created this revision. mgehre-amd added reviewers: aaron.ballman, erichkeane. Herald added subscribers: luke957, s.egerton, mstorsjo, simoncook, fedor.sergeev, dschuff. Herald added a project: All. mgehre-amd requested review of this revision. Herald added subscribers: pcwang-thead, ahe

[clang] cd6d9ae - [CGOpenMPRuntime] Remove some uses of deprecated Adddress ctor

Author: Nikita Popov Date: 2022-03-22T16:29:35+01:00 New Revision: cd6d9ae26313258d4dbf8a5db4d977434c03ed6a URL: https://github.com/llvm/llvm-project/commit/cd6d9ae26313258d4dbf8a5db4d977434c03ed6a DIFF: https://github.com/llvm/llvm-project/commit/cd6d9ae26313258d4dbf8a5db4d977434c03ed6a.diff

[PATCH] D122234: [clang] Link libbitint for large division of _BitInt; increase max _BitInt size

erichkeane added inline comments. Comment at: clang/include/clang/Basic/DiagnosticSemaKinds.td:8422 +def err_int_to_float_bit_int_max_size : Error< + "cannot convert '_BitInt' operands of more than %0 bits to floating point">; Can you explain the issue here?

[PATCH] D119063: [SemaCXX] Properly scope ArgumentPackSubstitutionIndex when expanding base types

aaron.ballman added a reviewer: erichkeane. aaron.ballman added a comment. Adding Erich as he's been staring at the template instantiation code recently and may have thoughts/opinions. To me, this seems like the correct approach though. Comment at: clang/lib/Sema/SemaTemplate

[PATCH] D121201: [clang] Merge the SourceRange into ParsedAttributes

tbaeder marked an inline comment as done. tbaeder added inline comments. Comment at: clang/include/clang/Sema/ParsedAttr.h:813 void takeAllFrom(AttributePool &pool) { takePool(pool); pool.Attrs.clear(); erichkeane wrote: > so: `assert(&pool != this &

[PATCH] D119063: [SemaCXX] Properly scope ArgumentPackSubstitutionIndex when expanding base types

erichkeane added a comment. I think this patch makes sense to me. I Do like the ideas of making sure these instantiate properly though. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D119063/new/ https://reviews.llvm.org/D119063 __

[PATCH] D121916: [clang-format] [doc] Add script to automatically update help output in ClangFormat.rst.

MyDeveloperDay added inline comments. Comment at: clang/docs/tools/dump_format_help.py:29 +def get_help_output(): +args = ["clang-format", "--help"] +cmd = subprocess.Popen(args, stdout=subprocess.PIPE, curdeius wrote: > sstwcw wrote: > > You intentionall

[PATCH] D111400: [Clang][C++2b] P2242R3: Non-literal variables [...] in constexpr

hubert.reinterpretcast added inline comments. Comment at: clang/include/clang/Basic/DiagnosticASTKinds.td:69 +def note_constexpr_static_local : Note< + "control flows through the declaration of a %select{static|thread_local}0 variable">; def note_constexpr_subobject_declared_h

[PATCH] D121927: [Clang] Work with multiple pragmas weak before definition

aaron.ballman added a comment. Can you also add a release note for the fix? Comment at: clang/include/clang/Sema/Sema.h:1075-1077 /// WeakUndeclaredIdentifiers - Identifiers contained in /// \#pragma weak before declared. rare. may alias another /// identifier, declare

[PATCH] D121560: [clang][Opt] Add NoArgUnusedWith to not warn for unused redundant options

abrachet updated this revision to Diff 417313. abrachet marked an inline comment as done. abrachet added a comment. Herald added subscribers: pmatos, asb, StephenFan. clang-format CHANGES SINCE LAST ACTION https://reviews.llvm.org/D121560/new/ https://reviews.llvm.org/D121560 Files: clang-

  1   2   3   >