[PATCH] D106577: [clang] Define __STDC_ISO_10646__

rsmith added a comment. In D106577#2905027 , @aaron.ballman wrote: > In D106577#2904960 , @rsmith wrote: > >> I'd expect we will break at least things like libc++ tests that build with >> `-Wsystem-headers` in t

[PATCH] D105695: [clang][tooling] Accept Clang invocations with multiple jobs

jansvoboda11 added a comment. In D105695#2905028 , @dexonsmith wrote: > Seeing the `-fembed-bitcode` case made me think of `-save-temps`. I think > this will work since `-x cpp-output` should return false for `isSrcFile()`... > but probably worth addin

[PATCH] D106849: [NFC][X86] add missing tests in clang/test/CodeGen/attr-target-mv.c

FreddyYe updated this revision to Diff 361919. FreddyYe added a comment. lowering pre-merge issues. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D106849/new/ https://reviews.llvm.org/D106849 Files: clang/test/CodeGen/attr-target-mv.c Index: cl

[clang] 60426f3 - [clang][driver] NFC: Move InputInfo.h from lib to include

Author: Jan Svoboda Date: 2021-07-27T09:17:39+02:00 New Revision: 60426f33b1d417763ca1954fba5293c959c9623d URL: https://github.com/llvm/llvm-project/commit/60426f33b1d417763ca1954fba5293c959c9623d DIFF: https://github.com/llvm/llvm-project/commit/60426f33b1d417763ca1954fba5293c959c9623d.diff L

[PATCH] D106787: [clang][driver] NFC: Move InputInfo.h from lib to include

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG60426f33b1d4: [clang][driver] NFC: Move InputInfo.h from lib to include (authored by jansvoboda11). Repository: rG LLVM Github Monorepo CHANGES S

[clang] b76c7c6 - [clang][driver] NFC: Expose InputInfo in Job instead of plain filenames

Author: Jan Svoboda Date: 2021-07-27T09:18:58+02:00 New Revision: b76c7c6faf06bb02b7b7b6bba3f6eb8a33edcdca URL: https://github.com/llvm/llvm-project/commit/b76c7c6faf06bb02b7b7b6bba3f6eb8a33edcdca DIFF: https://github.com/llvm/llvm-project/commit/b76c7c6faf06bb02b7b7b6bba3f6eb8a33edcdca.diff L

[PATCH] D106788: [clang][driver] NFC: Expose InputInfo in Job instead of plain filenames

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGb76c7c6faf06: [clang][driver] NFC: Expose InputInfo in Job instead of plain filenames (authored by jansvoboda11). Repository: rG LLVM Github Monor

[PATCH] D104601: [Preprocessor] Implement -fminimize-whitespace.

mstorsjo added a comment. This broke some cases for me, where the output is missing some newlines, breaking the output badly. I’ll try to provide a repro… Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D104601/new/ https://reviews.llvm.org/D104601

[PATCH] D106849: [NFC][X86] add missing tests in clang/test/CodeGen/attr-target-mv.c

FreddyYe updated this revision to Diff 361935. FreddyYe added a comment. rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D106849/new/ https://reviews.llvm.org/D106849 Files: clang/test/CodeGen/attr-target-mv.c Index: clang/test/CodeGen/att

[PATCH] D106785: [C++4OpenCL] Introduces __remove_address_space utility

Topotuna updated this revision to Diff 361937. Topotuna added a comment. Reference to C++ for OpenCL 1.0 specification removed. More elaborate code example added. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D106785/new/ https://reviews.llvm.org/D106785 Files: clang/docs/LanguageExt

[PATCH] D104601: [Preprocessor] Implement -fminimize-whitespace.

mstorsjo added a comment. In D104601#2906588 , @mstorsjo wrote: > This broke some cases for me, where the output is missing some newlines, > breaking the output badly. I’ll try to provide a repro… https://martin.st/temp/repro.tar.xz clang -target x86_6

[clang] 11ee699 - [clang][tooling] Accept Clang invocations with multiple jobs

Author: Jan Svoboda Date: 2021-07-27T10:47:55+02:00 New Revision: 11ee699b3c812ebe56ce5d3b14ab7ef16c1e8495 URL: https://github.com/llvm/llvm-project/commit/11ee699b3c812ebe56ce5d3b14ab7ef16c1e8495 DIFF: https://github.com/llvm/llvm-project/commit/11ee699b3c812ebe56ce5d3b14ab7ef16c1e8495.diff L

[PATCH] D105695: [clang][tooling] Accept Clang invocations with multiple jobs

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG11ee699b3c81: [clang][tooling] Accept Clang invocations with multiple jobs (authored by jansvoboda11). Changed prior to commit: https://reviews.ll

[clang] 5bcbb5e - [clang][tooling] Link clangDriver to ToolingTests

Author: Jan Svoboda Date: 2021-07-27T11:09:45+02:00 New Revision: 5bcbb5ec5f07e4ab0ec8f8941bb4a98cab44d169 URL: https://github.com/llvm/llvm-project/commit/5bcbb5ec5f07e4ab0ec8f8941bb4a98cab44d169 DIFF: https://github.com/llvm/llvm-project/commit/5bcbb5ec5f07e4ab0ec8f8941bb4a98cab44d169.diff L

[PATCH] D106854: Pass `--start-group` and `--end-group` to the linker when using the AVR toolchain

mhjacobson created this revision. mhjacobson added a reviewer: dylanmckay. mhjacobson added a project: clang. Herald added a subscriber: Jim. mhjacobson requested review of this revision. Herald added a subscriber: cfe-commits. The way the GNU linker deals with static archives is that it only load

[PATCH] D106785: [C++4OpenCL] Introduces __remove_address_space utility

svenvh added a comment. In D106785#2904619 , @Anastasia wrote: > I would like @svenvh to take a look from the clang header's design point. Looks okay to me. Comment at: clang/docs/LanguageExtensions.rst:1980 +__private T var2; //

[PATCH] D106790: prfchwintrin.h: Make _m_prefetchw take a pointer to volatile (PR49124)

hans added a comment. In D106790#2905110 , @rnk wrote: > Does this match GCC? They also provide this Intel intrinsic. No, they define it without volatile (and also without const): https://github.com/gcc-mirror/gcc/blob/releases/gcc-11.1.0/gcc/config/i38

[PATCH] D105555: [RISCV][Clang] Compute the default target-abi if it's empty.

asb accepted this revision. asb added a comment. This revision is now accepted and ready to land. This looks good to me, and as Jessica says this patch improves robustness and correctness so it would be great to land it for 13.x. @jrtc27 - I think @khchen has reflected all of your comments, but

[clang] a648f34 - [clang-cl] Expose -fmodules and related flags in the driver (PR43391)

Author: Hans Wennborg Date: 2021-07-27T11:27:16+02:00 New Revision: a648f34342740e3fe2ddf040d61909d53b09e323 URL: https://github.com/llvm/llvm-project/commit/a648f34342740e3fe2ddf040d61909d53b09e323 DIFF: https://github.com/llvm/llvm-project/commit/a648f34342740e3fe2ddf040d61909d53b09e323.diff

[PATCH] D106791: [clang-cl] Expose -fmodules and related flags in the driver (PR43391)

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGa648f3434274: [clang-cl] Expose -fmodules and related flags in the driver (PR43391) (authored by hans). Repository: rG LLVM Github Monorepo CHANG

[PATCH] D106858: [hwasan] Fix stack safety test for old PM.

fmayer created this revision. fmayer requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. With the old PM, the stub for __hwasan_generate_tag is still generated in the IR, but never called. Repository: rG LLVM Github Monorepo https://review

[PATCH] D106785: [C++4OpenCL] Introduces __remove_address_space utility

Topotuna updated this revision to Diff 361954. Topotuna added a comment. Additional tests added for `is_same` CHANGES SINCE LAST ACTION https://reviews.llvm.org/D106785/new/ https://reviews.llvm.org/D106785 Files: clang/docs/LanguageExtensions.rst clang/lib/Headers/opencl-c-base.h clan

[clang] 0f98e6e - [clang][tooling] Link LLVMOption to ToolingTests

Author: Jan Svoboda Date: 2021-07-27T11:48:44+02:00 New Revision: 0f98e6e87558b34cb00e2a043d471cb71466783a URL: https://github.com/llvm/llvm-project/commit/0f98e6e87558b34cb00e2a043d471cb71466783a DIFF: https://github.com/llvm/llvm-project/commit/0f98e6e87558b34cb00e2a043d471cb71466783a.diff L

[PATCH] D105495: [clang] Make negative getLocWithOffset widening-safe.

simon_tatham updated this revision to Diff 361957. simon_tatham edited the summary of this revision. simon_tatham added a comment. In D105495#2882628 , @tmatheson wrote: > I also think it's the caller's responsibility to make sure what they pass in > is

[PATCH] D105495: [clang] Make negative getLocWithOffset widening-safe.

simon_tatham added inline comments. Comment at: clang/lib/CodeGen/CoverageMappingGen.cpp:236 if (Loc.isMacroID()) - return Loc.getLocWithOffset(-SM.getFileOffset(Loc)); + return Loc.getLocWithOffset(0, SM.getFileOffset(Loc)); return SM.getLocForStartOfFile(SM.

[PATCH] D105981: [AMDGPU][OpenMP] Support linking of math libraries

pdhaliwal updated this revision to Diff 361967. pdhaliwal added a comment. Extract the options from HIP/OpenMP to a common method in base class. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D105981/new/ https://reviews.llvm.org/D105981 Files: cl

[PATCH] D105981: [AMDGPU][OpenMP] Support linking of math libraries

pdhaliwal added inline comments. Comment at: clang/lib/Driver/ToolChains/AMDGPU.cpp:923-924 + bool CorrectSqrt = DriverArgs.hasFlag( + options::OPT_fhip_fp32_correctly_rounded_divide_sqrt, + options::OPT_fno_hip_fp32_correctly_rounded_divide_sqrt); + bool Wave64 = isW

[PATCH] D106860: [clang][AArch64][SVE] Avoid going through memory for fixed/scalable predicate casts

bsmith created this revision. bsmith added reviewers: paulwalker-arm, peterwaller-arm, eli.friedman, junparser. Herald added subscribers: psnobl, kristof.beyls, tschuett. Herald added a reviewer: efriedma. bsmith requested review of this revision. Herald added a project: clang. Herald added a subs

[PATCH] D106785: [C++4OpenCL] Introduces __remove_address_space utility

Anastasia added inline comments. Comment at: clang/docs/LanguageExtensions.rst:1964 +Address space removal +- Maybe we could title it something like: `Address space removal utility` or `Address space removal trait` ? Comm

[PATCH] D106785: [C++4OpenCL] Introduces __remove_address_space utility

Anastasia added inline comments. Comment at: clang/docs/LanguageExtensions.rst:1964 +Address space removal +- Anastasia wrote: > Maybe we could title it something like: > > `Address space removal utility` > or > `Address space removal trait

[PATCH] D106785: [C++4OpenCL] Introduces __remove_address_space utility

Topotuna updated this revision to Diff 361975. Topotuna added a comment. Documentation rewording CHANGES SINCE LAST ACTION https://reviews.llvm.org/D106785/new/ https://reviews.llvm.org/D106785 Files: clang/docs/LanguageExtensions.rst clang/lib/Headers/opencl-c-base.h clang/test/CodeGe

[PATCH] D106785: [C++4OpenCL] Introduces __remove_address_space utility

Topotuna added inline comments. Comment at: clang/docs/LanguageExtensions.rst:1964 +Address space removal +- Anastasia wrote: > Anastasia wrote: > > Maybe we could title it something like: > > > > `Address space removal utility` > > or > >

[PATCH] D106733: [clang/darwin] Pass libclang_rt.profile last on linker command

thakis added a comment. @vsk, I'll go ahead and land this. If this does cause problems for you after all (on the bug you said it should be fine), please revert :) CHANGES SINCE LAST ACTION https://reviews.llvm.org/D106733/new/ https://reviews.llvm.org/D106733 ___

[PATCH] D105881: [flang][driver] Switch to `BoolFOption` for boolean options

awarzynski added a comment. Thank you for your detailed reply! In D105881#2904699 , @jansvoboda11 wrote: > Sorry, I'm not sure I follow. OK, let me try to clarify. I've tried to split this into threads. (flag == OptionFlag

[clang] 452095f - [clang/darwin] Pass libclang_rt.profile last on linker command

Author: Nico Weber Date: 2021-07-27T07:51:06-04:00 New Revision: 452095fe2f58528c174ca780265f227439e3e07e URL: https://github.com/llvm/llvm-project/commit/452095fe2f58528c174ca780265f227439e3e07e DIFF: https://github.com/llvm/llvm-project/commit/452095fe2f58528c174ca780265f227439e3e07e.diff LO

[PATCH] D106733: [clang/darwin] Pass libclang_rt.profile last on linker command

This revision was not accepted when it landed; it landed in state "Needs Review". This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG452095fe2f58: [clang/darwin] Pass libclang_rt.profile last on link

[PATCH] D106862: [clang][modules] Avoid creating partial FullSourceLoc for explicit modules imports

jansvoboda11 created this revision. jansvoboda11 added reviewers: Bigcheese, dexonsmith, arphaman, christof. jansvoboda11 requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Some parts of the codebase use `FullSourceLoc` -- a wrapper around reg

[PATCH] D106701: [clang] Add -falign-loops=N where N is a power of 2

asb added inline comments. Comment at: llvm/test/CodeGen/RISCV/loop-alignment.ll:3-4 +; RUN: llc < %s -mtriple=riscv64 | FileCheck %s +; RUN: llc < %s -mtriple=riscv64 -align-loops=16 | FileCheck %s -check-prefix=ALIGN_16 +; RUN: llc < %s -mtriple=riscv64 -align-loops=32 | FileC

[clang-tools-extra] ec1fb95 - [clangd] Use function pointer instead of function_ref to avoid GCC 5 bug

Author: Sam McCall Date: 2021-07-27T14:01:35+02:00 New Revision: ec1fb9533305e9bd69294ede7e5e7d9befbb2225 URL: https://github.com/llvm/llvm-project/commit/ec1fb9533305e9bd69294ede7e5e7d9befbb2225 DIFF: https://github.com/llvm/llvm-project/commit/ec1fb9533305e9bd69294ede7e5e7d9befbb2225.diff LO

[PATCH] D106863: Allow #pragma float_control(push|pop) within a language linkage specification

aaron.ballman created this revision. aaron.ballman added reviewers: mibintc, rjmccall, erichkeane, kbsmith1. aaron.ballman requested review of this revision. Herald added a project: clang. Currently, we prohibit this pragma from appearing within a language linkage specification, but this is usefu

[PATCH] D106431: [clang-tidy] Fix cppcoreguidelines-init-variables with enum judgement

Sockke added a comment. Any thoughts? : ) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D106431/new/ https://reviews.llvm.org/D106431 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists

[PATCH] D106789: [clang][Driver] Expose driver mode detection logic

sammccall accepted this revision. sammccall added inline comments. This revision is now accepted and ready to land. Comment at: clang/include/clang/Driver/Driver.h:643 +/// Returns the driver mode option's value, i.e. `X` in `--driver-mode=X`. If \p +/// Args doesn't mention o

[PATCH] D106864: [clang][cli] Expose -fno-cxx-modules in cc1

jansvoboda11 created this revision. jansvoboda11 added reviewers: Bigcheese, dexonsmith, arphaman. Herald added a subscriber: dang. jansvoboda11 requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. For some use-cases, it might be useful to be ab

[PATCH] D106864: [clang][cli] Expose -fno-cxx-modules in cc1

jansvoboda11 added inline comments. Comment at: clang/test/Modules/cxx20-disable.cpp:2 +// RUN: rm -rf %t && mkdir %t +// RUN: not %clang_cc1 -x objective-c++ -std=c++20 -fno-cxx-modules -I %t %s + I'm not sure how to best test this. Checking the error messages i

[PATCH] D106794: Revert "Revert "[clangd] Canonicalize compile flags before applying edits""

sammccall accepted this revision. sammccall added inline comments. This revision is now accepted and ready to land. Comment at: clang-tools-extra/clangd/CompileCommands.cpp:208 + !OriginalArgs.empty() && + driver::getDriverMode(OriginalArgs[0], OriginalArgs).equals("cl"

[clang-tools-extra] e2559e5 - [clangd] Add platform triple (host & target) to version info

Author: Sam McCall Date: 2021-07-27T14:25:17+02:00 New Revision: e2559e5dc62445a92a9a5344db79f78f735e1e61 URL: https://github.com/llvm/llvm-project/commit/e2559e5dc62445a92a9a5344db79f78f735e1e61 DIFF: https://github.com/llvm/llvm-project/commit/e2559e5dc62445a92a9a5344db79f78f735e1e61.diff LO

[PATCH] D105681: [clangd] Add platform triple (host & target) to version info

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGe2559e5dc624: [clangd] Add platform triple (host & target) to version info (authored by sammccall). Repository: rG LLVM Github Monorepo CHANGES S

[PATCH] D106867: [scan-build] Fix a typo in the manual page: s/contraint/constraint.

fcambus created this revision. fcambus added a reviewer: mgorny. fcambus requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Fix a typo in the scan-build manual page: s/contraint/constraint. While there, update hardcoded Clang version

[clang] ce90b60 - [clang][Driver] Expose driver mode detection logic

Author: Kadir Cetinkaya Date: 2021-07-27T14:49:53+02:00 New Revision: ce90b60bd09da41c52006374a4715425122572ab URL: https://github.com/llvm/llvm-project/commit/ce90b60bd09da41c52006374a4715425122572ab DIFF: https://github.com/llvm/llvm-project/commit/ce90b60bd09da41c52006374a4715425122572ab.dif

[clang-tools-extra] ab714ba - Revert "Revert "[clangd] Canonicalize compile flags before applying edits""

Author: Kadir Cetinkaya Date: 2021-07-27T14:49:53+02:00 New Revision: ab714ba056c14bce00ab67cc10e34678f9d77b5a URL: https://github.com/llvm/llvm-project/commit/ab714ba056c14bce00ab67cc10e34678f9d77b5a DIFF: https://github.com/llvm/llvm-project/commit/ab714ba056c14bce00ab67cc10e34678f9d77b5a.dif

[clang-tools-extra] 259e365 - Revert "Revert "[clangd] Adjust compile flags to contain only the requested file as input""

Author: Kadir Cetinkaya Date: 2021-07-27T14:49:53+02:00 New Revision: 259e365deaa3a6920b30f49e3d03d3508f1d4900 URL: https://github.com/llvm/llvm-project/commit/259e365deaa3a6920b30f49e3d03d3508f1d4900 DIFF: https://github.com/llvm/llvm-project/commit/259e365deaa3a6920b30f49e3d03d3508f1d4900.dif

[PATCH] D106789: [clang][Driver] Expose driver mode detection logic

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. kadircet marked 3 inline comments as done. Closed by commit rGce90b60bd09d: [clang][Driver] Expose driver mode detection logic (authored by kadircet). Herald added a re

[PATCH] D106794: Revert "Revert "[clangd] Canonicalize compile flags before applying edits""

This revision was automatically updated to reflect the committed changes. kadircet marked 3 inline comments as done. Closed by commit rGab714ba056c1: Revert "Revert "[clangd] Canonicalize compile flags before applying edits"" (authored by kadircet). Changed prior to commit: https://reviews.llv

[PATCH] D106870: [OpenMP] Multi architecture compilation support

saiislam created this revision. saiislam added reviewers: jdoerfert, yaxunl, JonChesterfield, RaviNarayanaswamy. Herald added subscribers: kerbowa, pengfei, guansong, nhaehnle, jvesely. saiislam requested review of this revision. Herald added subscribers: openmp-commits, cfe-commits, sstefan1. Hera

[PATCH] D106863: Allow #pragma float_control(push|pop) within a language linkage specification

erichkeane added a comment. Just one documentation change suggested. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D106863/new/ https://reviews.llvm.org/D106863 ___ cfe-commits mailing list cfe-commits@li

[PATCH] D106863: Allow #pragma float_control(push|pop) within a language linkage specification

erichkeane added a comment. Weird, phab didn't let me save the comment on the last one... done the right way this time :) Comment at: clang/docs/LanguageExtensions.rst:3549 +namespace scope, within a language linkage specification or at the start of a +compound statement (excl

[PATCH] D106863: Allow #pragma float_control(push|pop) within a language linkage specification

erichkeane accepted this revision. erichkeane added a comment. This revision is now accepted and ready to land. Doc change can be done as a part of the commit btw, otherwise this is fine to me. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D106863/n

[PATCH] D106701: [clang] Add -falign-loops=N where N is a power of 2

jrtc27 added inline comments. Comment at: llvm/test/CodeGen/RISCV/loop-alignment.ll:3-4 +; RUN: llc < %s -mtriple=riscv64 | FileCheck %s +; RUN: llc < %s -mtriple=riscv64 -align-loops=16 | FileCheck %s -check-prefix=ALIGN_16 +; RUN: llc < %s -mtriple=riscv64 -align-loops=32 | Fi

[PATCH] D105555: [RISCV][Clang] Compute the default target-abi if it's empty.

jrtc27 added a comment. Commit message needs rewriting still, but the patch looks good to me Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D10/new/ https://reviews.llvm.org/D10 ___ cfe-commits mai

[PATCH] D106664: [clang][docs] Fix typos in Options.td and regen ClangCommandLineReference.rst.

mgorny accepted this revision. mgorny added a comment. This revision is now accepted and ready to land. I suppose it's simple enough for me to count as second pair of eyes. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D106664/new/ https://reviews.l

[PATCH] D106867: [scan-build] Fix a typo in the manual page: s/contraint/constraint.

mgorny accepted this revision. mgorny added a comment. This revision is now accepted and ready to land. I suppose it's simple enough for me to count as second pair of eyes. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D106867/new/ https://reviews.l

[PATCH] D106860: [clang][AArch64][SVE] Avoid going through memory for fixed/scalable predicate casts

c-rhodes added inline comments. Comment at: clang/lib/CodeGen/CGExprScalar.cpp:2065 if (const auto *FixedSrc = dyn_cast(SrcTy)) { if (const auto *ScalableDst = dyn_cast(DstTy)) { +// If we are casting a fixed i8 vector to a scalable 16 x i1 predicate

[PATCH] D106870: [OpenMP] Multi architecture compilation support

ye-luo added a comment. `-fopenmp-targets=amdgcn-amd-amdhsa,amdgcn-amd-amdhsa` seems burdensome. Could you just count how many `-Xopenmp-target=amdgcn-amd-amdhsa` there are on the comand line and then count the unique ones? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION htt

[PATCH] D106870: [OpenMP] Multi architecture compilation support

saiislam added a comment. In D106870#2907252 , @ye-luo wrote: > `-fopenmp-targets=amdgcn-amd-amdhsa,amdgcn-amd-amdhsa` seems burdensome. > Could you just count how many `-Xopenmp-target=amdgcn-amd-amdhsa` there are > on the comand line and then count th

[PATCH] D106870: [OpenMP] Multi architecture compilation support

saiislam added inline comments. Comment at: openmp/libomptarget/src/rtl.cpp:306 + std::string cmd_bin; + cmd_bin.assign(libomptarget_dir_name).append("/../bin/amdgpu-arch"); + struct stat stat_buffer; Call to amdgpu-arch binary is going to be replaced with cal

[PATCH] D106870: [OpenMP] Multi architecture compilation support

ye-luo added a comment. In D106870#2907257 , @saiislam wrote: > In D106870#2907252 , @ye-luo wrote: > >> `-fopenmp-targets=amdgcn-amd-amdhsa,amdgcn-amd-amdhsa` seems burdensome. >> Could you just count how many `

[PATCH] D106748: [OpenCL] Add support of __opencl_c_pipes feature macro.

azabaznov updated this revision to Diff 362018. azabaznov added a comment. Herald added a subscriber: dexonsmith. Preserve existing diagnostic with `err_opencl_unknown_type_specifier`, fix comments for language option Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://re

[PATCH] D105168: [RISCV] Unify the arch string parsing logic to RISCVISAInfo.

jrtc27 added inline comments. Comment at: llvm/include/llvm/Support/RISCVISAInfo.h:31 +public: + RISCVISAInfo() : XLen(0), FLen(0) {} + Does Exts need initialising to be empty here? I can never remember Comment at: llvm/include/llvm/Support/RI

[PATCH] D106739: [analyzer] Add option to SATest.py for extra checkers

vsavchenko added a comment. Looks good! Thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D106739/new/ https://reviews.llvm.org/D106739 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https:/

[PATCH] D106277: [SVE] Remove the interface for getMaxVScale in favour of the IR attributes

DylanFleming-arm updated this revision to Diff 362020. DylanFleming-arm added a comment. Rebased onto main, updated newly added AArch64 getMaxVScale usages to use IR attribute instead Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D106277/new/ https

[clang] da58ca5 - [clang-repl] Build and install clang-repl by default.

Author: Vassil Vassilev Date: 2021-07-27T14:09:44Z New Revision: da58ca51f0cf4b415bbfc299ac7cef0666243c6c URL: https://github.com/llvm/llvm-project/commit/da58ca51f0cf4b415bbfc299ac7cef0666243c6c DIFF: https://github.com/llvm/llvm-project/commit/da58ca51f0cf4b415bbfc299ac7cef0666243c6c.diff LO

[PATCH] D106813: [clang-repl] Build and install clang-repl by default

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGda58ca51f0cf: [clang-repl] Build and install clang-repl by default. (authored by v.g.vassilev). Herald added a project: clang. Repository: rG LLVM

[PATCH] D105555: [RISCV][Clang] Compute the default target-abi if it's empty.

khchen added a comment. This patch depends on D105168 , Please help to review it if you have time. Thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D10/new/ https://reviews.llvm.org/D10 __

[PATCH] D106863: Allow #pragma float_control(push|pop) within a language linkage specification

mibintc accepted this revision. mibintc added a comment. Thanks for fixing this Aaron, just curious was there a bug report? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D106863/new/ https://reviews.llvm.org/D106863

[PATCH] D106876: Remove non-affecting module maps from PCM files.

ilyakuteev created this revision. ilyakuteev added reviewers: aprantl, dblaikie, rsmith, dexonsmith. ilyakuteev requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Problem: PCM file includes references to all module maps used in compilation whi

[PATCH] D106785: [C++4OpenCL] Introduces __remove_address_space utility

Topotuna updated this revision to Diff 362027. Topotuna added a comment. Test case added that checks if __remove_address_space modifies types without address space CHANGES SINCE LAST ACTION https://reviews.llvm.org/D106785/new/ https://reviews.llvm.org/D106785 Files: clang/docs/LanguageEx

[PATCH] D106732: Support macro deprecation #pragma clang deprecated

beanz updated this revision to Diff 362028. beanz marked 13 inline comments as done. beanz added a comment. Minor comment fix Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D106732/new/ https://reviews.llvm.org/D106732 Files: clang/docs/LanguageEx

[PATCH] D106732: Support macro deprecation #pragma clang deprecated

beanz added a comment. All feedback should be addressed Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D106732/new/ https://reviews.llvm.org/D106732 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D106870: [OpenMP] Multi architecture compilation support

JonChesterfield added a comment. There seems to be a bunch of different things in this patch. There's some driver plumbing to compile for more than one arch (presumably by calling the target compiler N times). That's a great feature, I want to build an application bthat can run on nvptx or amdg

[PATCH] D106577: [clang] Define __STDC_ISO_10646__

jyknight added a comment. BTW, looks like the standard wording came from: http://www.open-std.org/jtc1/sc22/wg14/www/docs/dr_273.htm which indeed seems to suggest that the intent was to: 1. ensure that WCHAR_MAX is at least the maximum character actually defined so far by the standard (which in

[PATCH] D106863: Allow #pragma float_control(push|pop) within a language linkage specification

mibintc added a reviewer: zahiraam. mibintc added a subscriber: zahiraam. mibintc added a comment. Adding @zahiraam FYI Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D106863/new/ https://reviews.llvm.org/D106863

[PATCH] D106748: [OpenCL] Add support of __opencl_c_pipes feature macro.

Anastasia accepted this revision. Anastasia added a comment. This revision is now accepted and ready to land. LGTM! Thanks Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D106748/new/ https://reviews.llvm.org/D106748 _

[clang] 973de71 - Revert "[clang][pp] adds '#pragma include_instead'"

Author: Hans Wennborg Date: 2021-07-27T17:29:48+02:00 New Revision: 973de7185606a21fd5e9d5e8c014fbf898c0e72f URL: https://github.com/llvm/llvm-project/commit/973de7185606a21fd5e9d5e8c014fbf898c0e72f DIFF: https://github.com/llvm/llvm-project/commit/973de7185606a21fd5e9d5e8c014fbf898c0e72f.diff

[PATCH] D106394: [clang][pp] adds '#pragma include_instead'

hans added a comment. This is causing the compiler to crash in Chromium builds, see https://bugs.chromium.org/p/chromium/issues/detail?id=1195353 I verified that replacing the use of getLiteralData() with OriginalFileName in HandleHeaderIncludeOrImport() fixes the crash, but the the other getL

[clang] e5f47ee - [OpenCL] NULL redefined as nullptr in C++ mode.

Author: Anastasia Stulova Date: 2021-07-27T16:33:50+01:00 New Revision: e5f47eedeb02595247e433ad756607e6c1397ae3 URL: https://github.com/llvm/llvm-project/commit/e5f47eedeb02595247e433ad756607e6c1397ae3 DIFF: https://github.com/llvm/llvm-project/commit/e5f47eedeb02595247e433ad756607e6c1397ae3.d

[PATCH] D105987: [C++4OpenCL] NULL redefined as nullptr

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGe5f47eedeb02: [OpenCL] NULL redefined as nullptr in C++ mode. (authored by Anastasia). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACT

[clang] 3378657 - [WebAssembly] Codegen for extmul SIMD instructions

Author: Thomas Lively Date: 2021-07-27T08:41:30-07:00 New Revision: 33786576fd3a7f79a6627a51386b173940bab0e9 URL: https://github.com/llvm/llvm-project/commit/33786576fd3a7f79a6627a51386b173940bab0e9 DIFF: https://github.com/llvm/llvm-project/commit/33786576fd3a7f79a6627a51386b173940bab0e9.diff

[PATCH] D106724: [WebAssembly] Codegen for extmul SIMD instructions

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG33786576fd3a: [WebAssembly] Codegen for extmul SIMD instructions (authored by tlively). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST AC

[PATCH] D106394: [clang][pp] adds '#pragma include_instead'

hans added a comment. In D106394#2907520 , @hans wrote: > This is causing the compiler to crash in Chromium builds, see > https://bugs.chromium.org/p/chromium/issues/detail?id=1195353 Durr, that should be https://bugs.chromium.org/p/chromium/issues/det

[PATCH] D106732: Support macro deprecation #pragma clang deprecated

beanz updated this revision to Diff 362049. beanz added a comment. Fix warning printing always having a `:` on the end. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D106732/new/ https://reviews.llvm.org/D106732 Files: clang/docs/LanguageExtensio

[PATCH] D106732: Support macro deprecation #pragma clang deprecated

beanz updated this revision to Diff 362052. beanz added a comment. Minor comment fixes... I swear, eventually I'll be done... Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D106732/new/ https://reviews.llvm.org/D106732 Files: clang/docs/LanguageEx

[PATCH] D106732: Support macro deprecation #pragma clang deprecated

beanz updated this revision to Diff 362053. beanz added a comment. Missed one Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D106732/new/ https://reviews.llvm.org/D106732 Files: clang/docs/LanguageExtensions.rst clang/include/clang/Basic/Diagnos

[PATCH] D106739: [analyzer] Add option to SATest.py for extra checkers

ASDenysPetrov added a comment. @RedDocMD Could you, please, explain the motivation and add at least one test to verify it works. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D106739/new/ https://reviews.llvm.org/D106739 __

[PATCH] D106137: [flang][driver] Add support for Frontend Plugins

awarzynski added a comment. I think that this is almost ready to be merged. Just a couple more comments. Comment at: flang/examples/CMakeLists.txt:1 # This test is not run by default as it requires input. add_executable(external-hello-world Could you add the

[PATCH] D106431: [clang-tidy] Fix cppcoreguidelines-init-variables with enum judgement

whisperity added a comment. In D106431#2907002 , @Sockke wrote: > Any thoughts? : ) First, let's first fix that we should still warn for the uninitialised `enum` case, without a FixIt. That's the issue at hand, right now, Clang-Tidy generates, as you

[PATCH] D106888: [RISC-V] Implement jump tables for CFI-icall

twd2 created this revision. twd2 added reviewers: MaskRay, asb, eugenis, pcc. twd2 created this object with edit policy "Administrators". twd2 added projects: LLVM, Sanitizers, clang. Herald added subscribers: ormris, vkmr, luismarques, sameer.abuasal, s.egerton, Jim, PkmX, rogfer01, shiva0217, ki

[PATCH] D106889: [examples] Fix the clang-interpreter example for changes in 2487db1f2862

rmansfield created this revision. rmansfield added a reviewer: lhames. rmansfield requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D106889 Files: clang/examples/clang-interpr

[PATCH] D105876: OMPIRBuilder for Interop directive

sriharikrishna updated this revision to Diff 362070. sriharikrishna added a comment. OMPIRBuilder for Interop directive Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D105876/new/ https://reviews.llvm.org/D105876 Files: clang/lib/CodeGen/CGStmt.cp

[PATCH] D106298: [OpenMP] Creating the `omp_target_num_teams` and `omp_target_thread_limit` attributes to outlined functions

josemonsalve2 updated this revision to Diff 362074. josemonsalve2 added a comment. Fixing tests Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D106298/new/ https://reviews.llvm.org/D106298 Files: clang/lib/CodeGen/CGOpenMPRuntime.cpp clang/lib/C

[PATCH] D106890: [z/OS] Make MinGlobalAlign consistent with SystemZ

fanbo-meng created this revision. fanbo-meng requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Remove overriding MinGlobalAlign to 0 for z/OS target to be consistent with SystemZ. Repository: rG LLVM Github Monorepo https://reviews.llvm

  1   2   >