[PATCH] D89935: [clangd] NFC: Update FIXME comment regarding lack of c/dtor support

kbobyrev created this revision. kbobyrev added a reviewer: kadircet. Herald added subscribers: cfe-commits, usaxena95, arphaman. Herald added a project: clang. kbobyrev requested review of this revision. Herald added subscribers: MaskRay, ilya-biryukov. Both `SymbolKind` and `indexSymbolKindToSymb

[PATCH] D89936: clang-tidy: adding "--clang-tidy-config=" to specify custom config file

Hiralo created this revision. Hiralo added reviewers: alexfh, njames93, hokein, DmitryPolukhin. Hiralo added a project: clang-tools-extra. Herald added a project: clang. Herald added a subscriber: cfe-commits. Hiralo requested review of this revision. commit 5c98467825b128aabd04a770ac26905d856a375

[PATCH] D89849: Add option 'exceptions' to pragma clang fp

sepavloff updated this revision to Diff 299887. sepavloff added a comment. Added ActOnPragmaFPExceptions Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D89849/new/ https://reviews.llvm.org/D89849 Files: clang/docs/LanguageExtensions.rst clang/in

[PATCH] D89849: Add option 'exceptions' to pragma clang fp

sepavloff added inline comments. Comment at: clang/lib/Parse/ParsePragma.cpp:3041 + if (AnnotValue->ExceptionsValue) +Actions.setExceptionMode(Tok.getLocation(), *AnnotValue->ExceptionsValue); ConsumeAnnotationToken(); mibintc wrote: > sepavloff wrote: >

[PATCH] D89920: Export TemplateArgumentMatcher so clients defining custom matchers don't need to use the internal namespace

klimek accepted this revision. klimek added a comment. This revision is now accepted and ready to land. lg Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D89920/new/ https://reviews.llvm.org/D89920 ___ cfe

[PATCH] D89935: [clangd] NFC: Update FIXME comment regarding lack of c/dtor support

njames93 added inline comments. Comment at: clang-tools-extra/clangd/FindSymbols.cpp:182 index::SymbolInfo SymInfo = index::getSymbolInfo(&ND); - // FIXME: this is not classifying constructors, destructors and operators - //correctly (they're all "methods"). + // FI

[PATCH] D89935: [clangd] NFC: Update FIXME comment regarding lack of c/dtor support

kbobyrev updated this revision to Diff 299891. kbobyrev marked an inline comment as done. kbobyrev added a comment. Fix typo. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D89935/new/ https://reviews.llvm.org/D89935 Files: clang-tools-extra/clang

[PATCH] D89935: [clangd] NFC: Update FIXME comment regarding lack of c/dtor support

kbobyrev added inline comments. Comment at: clang-tools-extra/clangd/FindSymbols.cpp:182 index::SymbolInfo SymInfo = index::getSymbolInfo(&ND); - // FIXME: this is not classifying constructors, destructors and operators - //correctly (they're all "methods"). + // FI

[PATCH] D89852: [clangd] Use SmallString instead of std::string in marshalling code; NFC

njames93 added a comment. I'm a little concerned by this, not sure if `Expected` and `Optional` play nicely with rvo. If the compiler can't optimise it's potentially a 256 byte memcpy in the return, granted that would still be cheaper than dynamic allocation. However it would most likely be fas

[PATCH] D89184: Support complex target features combinations

RKSimon added a comment. a few minor style comments that I noticed Comment at: clang/lib/CodeGen/CodeGenFunction.h:4705 +size_t SubexpressionStart = 0; +for (size_t i = 0; i < FeatureList.size(); ++i) { + char CurrentToken = FeatureList[i]; (style)

[PATCH] D89832: [CUDA] Extract CUDA version from cuda.h if version.txt is not found

emankov requested changes to this revision. emankov added inline comments. This revision now requires changes to proceed. Comment at: clang/lib/Driver/ToolChains/Cuda.cpp:76-77 +return CudaVersion::CUDA_102; + if (raw_version < 11010) +return CudaVersion::CUDA_110; + re

[PATCH] D89862: [clangd] Give the server information about client's remote index protocol version

kadircet added a comment. Regarding versioning of grpc layer. In addition to including a version number in every request, looks like there's the concept of "versioned-services". So we basically change the package name to be versioned, i.e. `package clang.clangd.remote.v1` and every time we make

[PATCH] D89935: [clangd] NFC: Update FIXME comment regarding lack of c/dtor support

kadircet added a comment. Am I missing something? We still have: case index::SymbolKind::Constructor: case index::SymbolKind::Destructor: return SymbolKind::Constructor; in Protocol.cpp. E.g. Constructors and Destructors are still classified badly. I suppose the bit around `they're all

[clang] be39a6f - [X86] Add User Interrupts(UINTR) instructions

Author: Tianqing Wang Date: 2020-10-22T17:33:07+08:00 New Revision: be39a6fe6fc6c30186152863a7fac624e22262f7 URL: https://github.com/llvm/llvm-project/commit/be39a6fe6fc6c30186152863a7fac624e22262f7 DIFF: https://github.com/llvm/llvm-project/commit/be39a6fe6fc6c30186152863a7fac624e22262f7.diff

[PATCH] D89301: [X86] Add User Interrupts(UINTR) instructions

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGbe39a6fe6fc6: [X86] Add User Interrupts(UINTR) instructions (authored by tianqing, committed by pengfei). Changed prior to commit: https://reviews

[PATCH] D89852: [clangd] Use SmallString instead of std::string in marshalling code; NFC

kadircet added a comment. Sorry I don't really follow what we are gaining by changes from string to SmallString. Could you explain if I am missing something? But I think it makes sense to get rid of Optionals in the Marshaller for `{Local,Remote}IndexRoot`, as there's no difference between `Non

[PATCH] D89862: [clangd] Give the server information about client's remote index protocol version

sammccall added a comment. What's the goal here? There are at least 3 mechanisms we can use to mitigate client/server skew: 1. extending payloads in compatible way, so mismatched versions result in correct behavior (switching from proto3 to proto2 gives us more options here if it's possible) 2

[PATCH] D89942: Disable LTO and LLD for bootstrap builds on systems unsupported by LLD

tbaeder created this revision. tbaeder added a reviewer: serge-sans-paille. Herald added subscribers: cfe-commits, pengfei, kristof.beyls, inglorion, mgorny. Herald added a project: clang. tbaeder requested review of this revision. I tried doing a stage3 build on SystemZ/s390 but ran into the unf

[PATCH] D89935: [clangd] NFC: Update FIXME comment regarding lack of c/dtor support

kbobyrev added a comment. In D89935#2346648 , @kadircet wrote: > Am I missing something? We still have: > > case index::SymbolKind::Constructor: > case index::SymbolKind::Destructor: > return SymbolKind::Constructor; > > in Protocol.cpp. E.g. Const

[PATCH] D89862: [clangd] Give the server information about client's remote index protocol version

sammccall added a comment. In D89862#2346714 , @sammccall wrote: > IME 1 is the most maintainable way to handle minor changes, while 3 is the > most maintainable way to handle dramatic changes. (I realize I haven't backed this up - it's basically about h

[PATCH] D89935: [clangd] NFC: Update FIXME comment regarding lack of c/dtor support

kadircet added a comment. > Yeah but the LSP SymbolKind which we are converting to does not have a > destructor type, same thing with CompletionItemKind, so I guess we really do > treat ctors and dtors the same way from the LSP perspective, aren't we? Yes, and that's what the previous fixme was

[PATCH] D89946: [clang] Suppress "follow-up" diagnostics on recovery call expressions.

hokein created this revision. hokein added reviewers: rsmith, sammccall. Herald added a subscriber: kristof.beyls. Herald added a project: clang. hokein requested review of this revision. Because of typo-correction, the AST can be transformed, and the transformed AST is marginally useful for diagn

[PATCH] D89946: [clang] Suppress "follow-up" diagnostics on recovery call expressions.

hokein added inline comments. Comment at: clang/test/Modules/submodules-merge-defs.cpp:21 extern class A pre_a2; -int pre_use_a = use_a(pre_a2); // expected-error 2{{'A' must be defined}} expected-error {{'use_a' must be declared}} +int pre_use_a = use_a(pre_a2); // expected-er

[PATCH] D87989: [Flang][Driver] Add infrastructure for basic frontend actions and file I/O

awarzynski added a comment. Ping Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D87989/new/ https://reviews.llvm.org/D87989 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cg

[PATCH] D89886: [clang-tidy] Fix redefinition of module in the same module.modulemap file

alexfh accepted this revision. alexfh added a comment. This revision is now accepted and ready to land. Looks good! Comment at: clang-tools-extra/clang-tidy/ExpandModularHeadersPPCallbacks.cpp:27 +// detection. +if (!File->getName().endswith("module.modulemap")) +

[PATCH] D89886: [clang-tidy] Fix redefinition of module in the same module.modulemap file

alexfh added a comment. Ah, btw, any chance of adding a test for this? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D89886/new/ https://reviews.llvm.org/D89886 ___ cfe-commits mailing list cfe-commits@li

[PATCH] D89380: [clang-tidy] Fix for cppcoreguidelines-prefer-member-initializer to handle classes declared in macros

alexfh added inline comments. Comment at: clang-tools-extra/test/clang-tidy/checkers/cppcoreguidelines-prefer-member-initializer.cpp:492 + +#define MACRO1 struct InMacro1 { int i; InMacro1() { i = 0; } }; +// CHECK-MESSAGES: :[[@LINE-1]]:54: warning: 'i' should be initialized in

[PATCH] D89935: [clangd] NFC: Update FIXME comment regarding lack of c/dtor support

kbobyrev added a comment. I thought the point of the comment was us not handling it properly rather than LSP not supporting it (e.g. LSP does support `Operator` but we do not). Then, the comment about ctor and dtor being indistinguishable probably belongs to `Protocol.h/cpp` and `SymbolKind` th

[clang-tools-extra] 37558fd - [clang-tidy] Add links to check docs in comments

Author: Alexander Kornienko Date: 2020-10-22T13:31:21+02:00 New Revision: 37558fd29ee0af2302c051b8e70543cfc3e7ca91 URL: https://github.com/llvm/llvm-project/commit/37558fd29ee0af2302c051b8e70543cfc3e7ca91 DIFF: https://github.com/llvm/llvm-project/commit/37558fd29ee0af2302c051b8e70543cfc3e7ca91

[PATCH] D89946: [clang] Suppress "follow-up" diagnostics on recovery call expressions.

sammccall added a comment. Cool, this makes sense to me. I hadn't realized this doesn't go through typoexpr, that's a bit unfortunate we can't address this just in one place. This is a change of behavior with recoveryAST off, but this change basically only affects C++ so that's not a widely-use

[PATCH] D89801: [SystemZ][z/OS] Set short-enums as the default for z/OS

abhina.sreeskantharajan accepted this revision. abhina.sreeskantharajan added a comment. This revision is now accepted and ready to land. LGTM CHANGES SINCE LAST ACTION https://reviews.llvm.org/D89801/new/ https://reviews.llvm.org/D89801 ___ cfe-co

[PATCH] D89862: [clangd] Give the server information about client's remote index protocol version

kbobyrev updated this revision to Diff 299932. kbobyrev marked an inline comment as done. kbobyrev added a comment. Use ClientContext::AddMetadata to propagate VCS version info. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D89862/new/ https://revie

[PATCH] D89862: [clangd] Give the server information about client's remote index protocol version

kbobyrev updated this revision to Diff 299933. kbobyrev added a comment. Remove formatting change. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D89862/new/ https://reviews.llvm.org/D89862 Files: clang-tools-extra/clangd/index/remote/Client.cpp

[PATCH] D89862: [clangd] Give the server information about client's remote index protocol version

kbobyrev added a comment. In D89862#2346645 , @kadircet wrote: > Regarding versioning of grpc layer. In addition to including a version number > in every request, looks like there's the concept of "versioned-services". > > So we basically change the packa

[PATCH] D89852: [clangd] Use SmallString instead of std::string in marshalling code; NFC

kbobyrev updated this revision to Diff 299934. kbobyrev marked 3 inline comments as done. kbobyrev added a comment. Get rid of llvm::Optional in local and remote paths. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D89852/new/ https://reviews.llvm.o

[PATCH] D85697: [clang-tidy] Add cppcoreguidelines-prefer-scoped-enums

aaron.ballman added inline comments. Comment at: clang-tools-extra/test/clang-tidy/checkers/cppcoreguidelines-prefer-scoped-enums.cpp:165 + +enum class OpaqueScopedEnumWithFixedUnderlyingType : unsigned; janosbenjaminantal wrote: > aaron.ballman wrote: > > njame

[PATCH] D88645: [Annotation] Allows annotation to carry some additional constant arguments.

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. LGTM aside from a request for a comment to be added. Thank you! Comment at: clang/lib/Sema/SemaDeclAttr.cpp:3706 + +if (!Result || !Notes.empty()) { +

[PATCH] D83088: Introduce CfgTraits abstraction

arsenm added a comment. In D83088#2346322 , @mehdi_amini wrote: > In D83088#2345540 , @nhaehnle wrote: > >> David, I don't think this is appropriate here. Let's take the discussion to >> llvm-dev. > > Seems like Da

[clang] e4b4543 - [Clang] [TableGen] Clean up !if(!eq(bool, 1) and related booleans

Author: Paul C. Anagnostopoulos Date: 2020-10-22T09:29:15-04:00 New Revision: e4b4543ff0c83b6f1d80064e2dcd22b2bb0bfab6 URL: https://github.com/llvm/llvm-project/commit/e4b4543ff0c83b6f1d80064e2dcd22b2bb0bfab6 DIFF: https://github.com/llvm/llvm-project/commit/e4b4543ff0c83b6f1d80064e2dcd22b2bb0b

[PATCH] D89893: [Clang] [TableGen] Clean up !if(!eq(boolean, 1) and related booleans

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGe4b4543ff0c8: [Clang] [TableGen] Clean up !if(!eq(bool, 1) and related booleans (authored by Paul-C-Anagnostopoulos). Repository: rG LLVM Github M

[PATCH] D89862: [clangd] Give the server information about client's remote index protocol version

sammccall accepted this revision. sammccall added a comment. This revision is now accepted and ready to land. In D89862#2346967 , @kbobyrev wrote: > In D89862#2346645 , @kadircet wrote: > >> Regarding versioning of

[PATCH] D89959: UBSAN: emit distinctive traps in trapping mode

lebedev.ri added a comment. Missing langref changes for new intrinsic. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D89959/new/ https://reviews.llvm.org/D89959 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi

[PATCH] D89785: [clangd] Add basic support for attributes (selection, hover)

sammccall updated this revision to Diff 299957. sammccall added a comment. Only deoptimize selection for *explicit* attributes Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D89785/new/ https://reviews.llvm.org/D89785 Files: clang-tools-extra/clan

[PATCH] D89960: Testing the use of arc.

zahiraam created this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. zahiraam requested review of this revision. Change-Id: I94cb7ac295acc8de9aa2c60bb31a1f5ee7d86fde Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D89960 Files: clang/lib/Parse

[PATCH] D89651: [clang-tidy] Add bugprone-suspicious-memory-comparison check

aaron.ballman added a comment. In D89651#2342367 , @gbencze wrote: > In D89651#2338266 , @njames93 wrote: > >> Should point out there is already a check for cert-oop57-cpp, added in >> D72488

[PATCH] D89961: [libTooling] Add function to Transformer to create a no-op edit.

ymandel created this revision. ymandel added reviewers: tdl-g, gribozavr2. Herald added a project: clang. ymandel requested review of this revision. This functionality is commonly needed in clang tidy checks (based on transformer) that only print warnings, without suggesting any edits. The no-op e

[PATCH] D72553: [clang-tidy] Add performance-prefer-preincrement check

aaron.ballman requested changes to this revision. aaron.ballman added a comment. This revision now requires changes to proceed. In D72553#1815497 , @njames93 wrote: > could this do with an alias into performance? If it was 1997, I'd say yes, but I am not

[PATCH] D89899: [CodeGen] Implement [[likely]] and [[unlikely]] for the iteration statements

aaron.ballman added a comment. Thank you for this! Comment at: clang/include/clang/Basic/AttrDocs.td:1773 -At the moment the attributes only have effect when used in an ``if``, ``else``, -or ``switch`` statement. +Below some usage examples likelihood attributes and their effe

[PATCH] D89910: [AIX] Let alloca return 16 bytes alignment

Xiangling_L updated this revision to Diff 299975. Xiangling_L marked 3 inline comments as done. Xiangling_L added a comment. Fixed the testcase formatting issues; Fixed the `BIGGEST_ALIGNMENT` value in testcases; CHANGES SINCE LAST ACTION https://reviews.llvm.org/D89910/new/ https://reviews.l

[PATCH] D89886: [clang-tidy] Fix redefinition of module in the same module.modulemap file

DmitryPolukhin updated this revision to Diff 299977. DmitryPolukhin added a comment. Added all module map file names Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D89886/new/ https://reviews.llvm.org/D89886 Files: clang-tools-extra/clang-tidy/Exp

[PATCH] D89886: [clang-tidy] Fix redefinition of module in the same module.modulemap file

DmitryPolukhin marked an inline comment as done. DmitryPolukhin added a comment. In D89886#2346851 , @alexfh wrote: > Ah, btw, any chance of adding a test for this? Oh, I was not able to create small reproducer that without including large Apple Framewor

[PATCH] D89184: Support complex target features combinations

dexonsmith added a comment. In D89184#2346453 , @pengfei wrote: > LGTM. But I suggest you waiting for 1 or 2 days to see if other reviewers > object. Given that @echristo marked this as needing changes I would suggest waiting / reaching out to confirm t

[PATCH] D86671: [clang-tidy] Add new case type to check variables with Hungarian notation

aaron.ballman added inline comments. Comment at: clang-tools-extra/clang-tidy/readability/IdentifierNamingCheck.cpp:237 +static void getHungarianNotationDefaultConfig( +std::shared_ptr HNOption) { + It seems like this function should take `HNOption` as a ref

[PATCH] D89920: Export TemplateArgumentMatcher so clients defining custom matchers don't need to use the internal namespace

davidvancleve added a comment. Hi klimek, any more action needed on my part to land this? This is my first LLVM change. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D89920/new/ https://reviews.llvm.org/D89920 _

[PATCH] D89903: [CodeGen] Crash instead of generating broken code with self-capturing __block var

ille added a comment. > We do not actually support allocation failure for a lot of things around > blocks. I don't think the copy-helper functions even have a way to propagate > out a failure in copying a field. I have never seen any code in the wild that > would handle Block_copy returning a n

[PATCH] D71726: Let clang atomic builtins fetch add/sub support floating point types

yaxunl added a comment. Herald added a subscriber: dexonsmith. ping CHANGES SINCE LAST ACTION https://reviews.llvm.org/D71726/new/ https://reviews.llvm.org/D71726 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bi

[PATCH] D89814: [TableGen] Change !getop and !setop to !getdagop and !setdagop

nhaehnle accepted this revision. nhaehnle added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D89814/new/ https://reviews.llvm.org/D89814 _

[PATCH] D89913: SourceManager: Encapsulate line number mapping into SrcMgr::LineOffsetMapping

dexonsmith updated this revision to Diff 299989. dexonsmith added a comment. Herald added a subscriber: mgorny. Fix an off-by-one bug in `LineOffsetMapping::LineOffsetMapping`, add unit tests, and clang-format. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D89913/new/ https://reviews.ll

[PATCH] D89897: [AIX] Emit error for -G option on AIX

Xiangling_L marked 3 inline comments as done. Xiangling_L added inline comments. Comment at: clang/test/Driver/aix-err-options.c:1 +// RUN: %clang -target powerpc32-ibm-aix-xcoff -### -S -emit-llvm -G 0 2>&1 %s | \ +// RUN: FileCheck -check-prefix=CHECK32 %s h

[PATCH] D89897: [AIX] Emit error for -G option on AIX

Xiangling_L updated this revision to Diff 21. Xiangling_L marked an inline comment as done. Xiangling_L added a comment. Fix the formatting issues; CHANGES SINCE LAST ACTION https://reviews.llvm.org/D89897/new/ https://reviews.llvm.org/D89897 Files: clang/lib/Driver/ToolChains/Clang.cp

[PATCH] D82756: Port some floating point options to new option marshalling infrastructure

jansvoboda11 updated this revision to Diff 26. jansvoboda11 added a comment. Rebase onto master. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D82756/new/ https://reviews.llvm.org/D82756 Files: clang/include/clang/Driver/Options.td clang/lib/Driver/ToolChains/Clang.cpp clang/l

[PATCH] D89913: SourceManager: Encapsulate line number mapping into SrcMgr::LineOffsetMapping

dexonsmith updated this revision to Diff 27. dexonsmith added a comment. Add the unittest (`constructTwo`) that caught the off-by-one bug, somehow missed in the last update. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D89913/new/ https://reviews.llvm.org/D89913 Files: clang/inc

[PATCH] D89903: [CodeGen] Crash instead of generating broken code with self-capturing __block var

ille updated this revision to Diff 28. ille added a comment. Move the check to cover the atomic case as well. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D89903/new/ https://reviews.llvm.org/D89903 Files: clang/lib/CodeGen/CGDecl.cpp clan

[PATCH] D89910: [AIX] Let alloca return 16 bytes alignment

hubert.reinterpretcast added inline comments. Comment at: clang/test/CodeGen/aix_alloca_align.c:11 +void foo() { + char *ptr1 = (char *)alloca(sizeof(char) * 9); +} I'm not entirely sure, but can we try for size 32 and see if we get 16? CHANGES SINCE LAST ACTI

[clang] b2524eb - [HIP] Fix HIP rounding math intrinsics

Author: Aaron En Ye Shi Date: 2020-10-22T15:57:09Z New Revision: b2524eb9445a4487115c8f94fd946d2c4c95f652 URL: https://github.com/llvm/llvm-project/commit/b2524eb9445a4487115c8f94fd946d2c4c95f652 DIFF: https://github.com/llvm/llvm-project/commit/b2524eb9445a4487115c8f94fd946d2c4c95f652.diff LO

[PATCH] D89559: PR47372: Fix Lambda invoker calling conventions

erichkeane added a comment. Hmm... so I got distracted the last few days with a handful of small SEMA issues that I believe to be solved, so I'm going back to my codegen issues. It seems that my problem is that we don't actually mangle calling-convention in a pointer types. The result is: 64 b

[PATCH] D89897: [AIX] Emit error for -G option on AIX

hubert.reinterpretcast accepted this revision. hubert.reinterpretcast added a comment. This revision is now accepted and ready to land. LGTM; thanks! Comment at: clang/test/Driver/aix-err-options.c:1 +// RUN: %clang -target powerpc32-ibm-aix-xcoff -### -S -emit-llvm -G 0 2>&1 %

[PATCH] D89372: [OpenCL] Remove unused extensions

This revision was not accepted when it landed; it landed in state "Needs Review". This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGa779a169931c: [OpenCL] Remove unused extensions (authored by manto

[clang] a779a16 - [OpenCL] Remove unused extensions

Author: Marco Antognini Date: 2020-10-22T17:01:31+01:00 New Revision: a779a169931c0738bf43dc50fc545c1e88597e92 URL: https://github.com/llvm/llvm-project/commit/a779a169931c0738bf43dc50fc545c1e88597e92 DIFF: https://github.com/llvm/llvm-project/commit/a779a169931c0738bf43dc50fc545c1e88597e92.dif

[PATCH] D89559: PR47372: Fix Lambda invoker calling conventions

rjmccall added a comment. Mangling more calling conventions when mangling function types in Itanium (except at the top level) is the right thing to do. There's already a place to do so in the mangling. We just haven't done this yet because a lot of those calling convention are supported by ot

[PATCH] D89559: PR47372: Fix Lambda invoker calling conventions

erichkeane added a comment. In D89559#2347642 , @rjmccall wrote: > Mangling more calling conventions when mangling function types in Itanium > (except at the top level) is the right thing to do. There's already a place > to do so in the mangling. We ju

[PATCH] D87989: [Flang][Driver] Add infrastructure for basic frontend actions and file I/O

SouraVX accepted this revision. SouraVX added a comment. This revision is now accepted and ready to land. Thanks for your patience. LGTM! at least the part I reviewed. Though I would vote for having another approval(From some senior folks in community) Repository: rG LLVM Github Monorepo CHA

[PATCH] D89971: [OpenMP][CUDA] Add missing overload for `remquo(float,float,int*)`

jdoerfert created this revision. jdoerfert added reviewers: JonChesterfield, ye-luo, tra, yaxunl. Herald added subscribers: guansong, bollu. Herald added a project: clang. jdoerfert requested review of this revision. Herald added a subscriber: sstefan1. Reported by Colleen Bertoni after running t

[PATCH] D88645: [Annotation] Allows annotation to carry some additional constant arguments.

Tyker added a comment. In D88645#2347050 , @aaron.ballman wrote: > LGTM aside from a request for a comment to be added. Thank you! do you mean an RFC on llvm-dev/cfe-dev ? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://revie

[PATCH] D89971: [OpenMP][CUDA] Add missing overload for `remquo(float,float,int*)`

jdoerfert added a comment. This should fix the last OvO math test (I think C++11) we fail. While those tests are "simple" they are fairly exhaustive and it's a good sign to pass them ;) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D89971/new/ htt

[PATCH] D88645: [Annotation] Allows annotation to carry some additional constant arguments.

aaron.ballman added a comment. In D88645#2347725 , @Tyker wrote: > In D88645#2347050 , @aaron.ballman > wrote: > >> LGTM aside from a request for a comment to be added. Thank you! > > do you mean an RFC on llvm-dev

[PATCH] D88645: [Annotation] Allows annotation to carry some additional constant arguments.

erichkeane added a comment. In D88645#2347725 , @Tyker wrote: > In D88645#2347050 , @aaron.ballman > wrote: > >> LGTM aside from a request for a comment to be added. Thank you! > > do you mean an RFC on llvm-dev/cf

[PATCH] D89971: [OpenMP][CUDA] Add missing overload for `remquo(float,float,int*)`

JonChesterfield accepted this revision. JonChesterfield added a comment. This revision is now accepted and ready to land. Change obviously good. Am I right in reading this as all of OvO then passes for trunk, nvptx? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://revi

[PATCH] D89832: [CUDA] Extract CUDA version from cuda.h if version.txt is not found

jlebar accepted this revision. jlebar added a comment. LGTM modulo emankov's comment. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D89832/new/ https://reviews.llvm.org/D89832 ___ cfe-commits mailing list

[PATCH] D89971: [OpenMP][CUDA] Add missing overload for `remquo(float,float,int*)`

jdoerfert added a comment. In D89971#2347762 , @JonChesterfield wrote: > Change obviously good. Am I right in reading this as all of OvO then passes > for trunk, nvptx? C++11 math tests on one system. These are system dependent to some degree so I woul

[PATCH] D89972: Add pipeline model for HiSilicon's TSV110

Elvina created this revision. Elvina added reviewers: bryanpkc, kristof.beyls, t.p.northover, SjoerdMeijer. Elvina added projects: LLVM, clang. Herald added subscribers: cfe-commits, jfb, hiraditya. Elvina requested review of this revision. This patch adds the scheduling and cost model for TSV110.

[PATCH] D89832: [CUDA] Extract CUDA version from cuda.h if version.txt is not found

tra added inline comments. Comment at: clang/lib/Driver/ToolChains/Cuda.cpp:76-77 +return CudaVersion::CUDA_102; + if (raw_version < 11010) +return CudaVersion::CUDA_110; + return CudaVersion::LATEST; emankov wrote: > Please, add `CudaVersion::CUDA_111`

[PATCH] D87989: [Flang][Driver] Add infrastructure for basic frontend actions and file I/O

richard.barton.arm accepted this revision. richard.barton.arm added a comment. I'm happy to accept this revision based on @SouraVX 's code review and the fact that Andrzej has sent multiple RFCs covering the clang-side changes, including the Options flags (latest here http://lists.llvm.org/pipe

[PATCH] D89974: [driver][CUDA] Use CMake's FindCUDA as default --cuda-path.

Meinersbur created this revision. Meinersbur added reviewers: jdoerfert, RaviNarayanaswamy, ye-luo, jhuber6, phosek, grokos, tambre, rnk, sylvestre.ledru, gtbercea, tra, yaxunl, Hahnfeld, jdenny. Meinersbur added a project: clang. Herald added subscribers: openmp-commits, dang, ormris, mgorny. He

[PATCH] D89971: [OpenMP][CUDA] Add missing overload for `remquo(float,float,int*)`

tra added a comment. > The template overload function overload. > is still hidden behind an ifdef for OpenMP. In the > future we probably want to remove the ifdef but that requires further > testing. I don't think it's the case. I've just ran `clang++ -x cuda /dev/null --cuda-host-only -dD -

[PATCH] D89974: [driver][CUDA] Use CMake's FindCUDA as default --cuda-path.

tra requested changes to this revision. tra added a comment. This revision now requires changes to proceed. One concern I have is that the path we configure during clang's build is not necessarily the right choice for the user of clang we build. It's likely that the clang in the end will be used

[PATCH] D82756: Port some floating point options to new option marshalling infrastructure

Anastasia added inline comments. Comment at: clang/test/CodeGen/fp-function-attrs.cpp:2 +// RUN: %clang_cc1 -triple x86_64-linux-gnu -ffast-math -ffinite-math-only -menable-unsafe-fp-math \ +// RUN: -menable-no-infs -menable-no-nans -fno-signed-zeros -freciprocal-math \ +// R

[PATCH] D89910: [AIX] Let alloca return 16 bytes alignment

Xiangling_L marked an inline comment as done. Xiangling_L added inline comments. Comment at: clang/test/CodeGen/aix_alloca_align.c:11 +void foo() { + char *ptr1 = (char *)alloca(sizeof(char) * 9); +} hubert.reinterpretcast wrote: > I'm not entirely sure, but can

[PATCH] D89910: [AIX] Let alloca return 16 bytes alignment

Xiangling_L updated this revision to Diff 300043. Xiangling_L marked an inline comment as done. Xiangling_L added a comment. Add one case to the test; CHANGES SINCE LAST ACTION https://reviews.llvm.org/D89910/new/ https://reviews.llvm.org/D89910 Files: clang/lib/Basic/Targets/PPC.h clang

[PATCH] D69903: [Basic] Introduce PODSourceLocation, NFCI

dexonsmith added a comment. In D69903#2342011 , @miyuki wrote: > In D69903#2340020 , @dexonsmith > wrote: > >> An alternative would be to update the unions to an `AlignedCharArrayUnion` >> and use `SourceLocation`

[PATCH] D89974: [driver][CUDA] Use CMake's FindCUDA as default --cuda-path.

Hahnfeld added a comment. In D89974#2347938 , @tra wrote: > One concern I have is that the path we configure during clang's build is not > necessarily the right choice for the user of clang we build. It's likely that > the clang in the end will be used o

[PATCH] D89974: [driver][CUDA] Use CMake's FindCUDA as default --cuda-path.

Hahnfeld added a comment. In D89974#2347979 , @Hahnfeld wrote: > In D89974#2347938 , @tra wrote: > >> I think the default should still let clang search for CUDA or require the >> user to provide correct CUDA path.

[PATCH] D89974: [driver][CUDA] Use CMake's FindCUDA as default --cuda-path.

tra added a comment. In D89974#2347979 , @Hahnfeld wrote: > In D89974#2347938 , @tra wrote: > >> One concern I have is that the path we configure during clang's build is not >> necessarily the right choice for the

[clang-tools-extra] 156e8b3 - clang/Basic: Remove ContentCache::getRawBuffer, NFC

Author: Duncan P. N. Exon Smith Date: 2020-10-22T14:00:44-04:00 New Revision: 156e8b37024abd8630666e0ae8a251b80299ed1d URL: https://github.com/llvm/llvm-project/commit/156e8b37024abd8630666e0ae8a251b80299ed1d DIFF: https://github.com/llvm/llvm-project/commit/156e8b37024abd8630666e0ae8a251b80299

[PATCH] D89974: [driver][CUDA] Use CMake's FindCUDA as default --cuda-path.

Meinersbur updated this revision to Diff 300046. Meinersbur edited the summary of this revision. Meinersbur added a comment. Re-add accidentally removed space Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D89974/new/ https://reviews.llvm.org/D89974

[PATCH] D89445: clang/Basic: Remove ContentCache::getRawBuffer, NFC

This revision was automatically updated to reflect the committed changes. Closed by commit rG156e8b37024a: clang/Basic: Remove ContentCache::getRawBuffer, NFC (authored by dexonsmith). Herald added a project: clang. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://review

[PATCH] D69844: [clang][Basic] Integrate SourceLocation with FoldingSet, NFCI

miyuki updated this revision to Diff 300044. miyuki retitled this revision from "[Basic] Integrate SourceLocation and SourceRange with FoldingSet, NFCI" to "[clang][Basic] Integrate SourceLocation with FoldingSet, NFCI". miyuki edited the summary of this revision. miyuki added a comment. Address

[PATCH] D89559: PR47372: Fix Lambda invoker calling conventions

erichkeane added a subscriber: majnemer. erichkeane added a comment. Turns out this patch: https://github.com/llvm/llvm-project/commit/2e1e0491b7098fcfe01945e8f62cafe1fcb3cf36 is my problem. The issue has to do deducing a 'local' type in the return type. As a result, we choose to mangle any ty

[PATCH] D82756: Port some floating point options to new option marshalling infrastructure

Anastasia resigned from this revision. Anastasia added a comment. Just to clarify aside from the concern I have raised regarding internal testing I am not in any strong opposition of this feature. So if the community decides that it is more important to have this feature than to keep the tests s

[PATCH] D89974: [driver][CUDA] Use CMake's FindCUDA as default --cuda-path.

tambre added a comment. I echo @tra's concerns. Having an option for a vendor to append/prepend a toolkit search location seems useful, but currently this seems more like a workaround for an explicit CUDA toolkit path not being passed to the testsuite. Shortcomings in the testrunner don't seem l

  1   2   >