[PATCH] D86047: [clangd] Target member of dependent base made visible via a using-decl

nridge updated this revision to Diff 285922. nridge added a comment. Update a comment Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D86047/new/ https://reviews.llvm.org/D86047 Files: clang-tools-extra/clangd/FindTarget.cpp clang-tools-extra/cla

[PATCH] D84415: [analyzer][StdLibraryFunctionsChecker] Add POSIX pthread handling functions

balazske added a comment. It is better now, but the refactoring change should be in a separate revision (it affects the other already added functions too). Comment at: clang/lib/StaticAnalyzer/Checkers/StdLibraryFunctionsChecker.cpp:350 + } else { +*this = Signatu

[PATCH] D86048: [AST][RecoveryExpr] Popagate the error-bit from a VarDecl's initializer to DeclRefExpr.

hokein created this revision. hokein added a reviewer: sammccall. Herald added a project: clang. hokein requested review of this revision. The error-bit was missing, if a DeclRefExpr (which refers to a VarDecl with a contains-errors initializer). It could cause different violations in clang -- th

[PATCH] D86049: RFC: Implement optional exportable wrapper function generation for objc_direct methods.

plotfi created this revision. plotfi added reviewers: rjmccall, manmanren, MadCoder. Herald added subscribers: cfe-commits, dang. Herald added a project: clang. plotfi requested review of this revision. Hi @rjmccall @MadCoder I'd like to preface this diff: I mostly want to discuss the prospects o

[PATCH] D86049: RFC: Implement optional exportable wrapper function generation for objc_direct methods.

plotfi updated this revision to Diff 285925. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D86049/new/ https://reviews.llvm.org/D86049 Files: clang/include/clang/Basic/CodeGenOptions.def clang/include/clang/Driver/Options.td clang/lib/CodeGen/C

[PATCH] D84136: [clang] Fix visitation of ConceptSpecializationExpr in constrained-parameter

hokein accepted this revision. hokein added a comment. This revision is now accepted and ready to land. Thanks! Comment at: clang/include/clang/AST/RecursiveASTVisitor.h:1781 + if (const auto *TC = D->getTypeConstraint()) { +Expr *IDC = TC->getImmediatelyDeclaredConstraint

[PATCH] D83536: [clangd] Index refs to main-file symbols as well

kadircet accepted this revision. kadircet added a comment. This revision is now accepted and ready to land. thanks, LGTM! Comment at: clang-tools-extra/clangd/unittests/SymbolCollectorTests.cpp:727 + // Run the collector again with CollectMainFileRefs = true. + InMemoryFileSy

[PATCH] D85826: [clang] Make signature help work with dependent args

hokein accepted this revision. hokein added a comment. This revision is now accepted and ready to land. thanks, looks better. Comment at: clang/lib/Sema/SemaCodeComplete.cpp:5513 for (OverloadCandidate &Candidate : CandidateSet) { -if (Candidate.Function && Candidate.Fun

[PATCH] D85826: [clang] Make signature help work with dependent args

kadircet added inline comments. Comment at: clang/lib/Sema/SemaCodeComplete.cpp:5513 for (OverloadCandidate &Candidate : CandidateSet) { -if (Candidate.Function && Candidate.Function->isDeleted()) - continue; +if (Candidate.Function) { + if (Candidate.Functio

[clang] 53c593c - [clang] Make signature help work with dependent args

Author: Kadir Cetinkaya Date: 2020-08-17T10:06:36+02:00 New Revision: 53c593c2c893a40083771789e3d3e164eea1892d URL: https://github.com/llvm/llvm-project/commit/53c593c2c893a40083771789e3d3e164eea1892d DIFF: https://github.com/llvm/llvm-project/commit/53c593c2c893a40083771789e3d3e164eea1892d.dif

[PATCH] D85826: [clang] Make signature help work with dependent args

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG53c593c2c893: [clang] Make signature help work with dependent args (authored by kadircet). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST

[PATCH] D31130: B32239 clang-tidy should not warn about array to pointer decay on system macros

fiesh added a comment. Ping everybody? This is a rather important issue I think since it makes clang-tidy not usable in a lot of cases, and the fix would be all done. Please let's get this merged! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D31130/new/ https://reviews.llvm.org/D311

[PATCH] D84387: [AST][RecoveryExpr] Suppress spurious "err_typecheck_expect_scalar_operand" diagnostic

sammccall added a comment. Sorry for losing track of this. Where is CDependence defined? Is this stacked on another patch? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D84387/new/ https://reviews.llvm.org/D84387 __

[PATCH] D86029: [analyzer] Add modeling for unque_ptr::get()

xazax.hun accepted this revision. xazax.hun added inline comments. Comment at: clang/lib/StaticAnalyzer/Checkers/SmartPtrModeling.cpp:362-363 + const auto *InnerPointVal = State->get(ThisRegion); + if (!InnerPointVal) +return; + NoQ wrote: > You'll have to

[PATCH] D84387: [AST][RecoveryExpr] Part4: Suppress spurious "err_typecheck_expect_scalar_operand" diagnostic

hokein added a comment. In D84387#2220845 , @sammccall wrote: > Sorry for losing track of this. Where is CDependence defined? Is this stacked > on another patch? yes. Sorry for not being clear here, this is stacked on another patch. I have renamed these

[PATCH] D86027: [analyzer] Add bool operator modeling for unque_ptr

xazax.hun added inline comments. Comment at: clang/lib/StaticAnalyzer/Checkers/SmartPtrModeling.cpp:147 -if (!move::isMovedFrom(State, ThisR)) { - // TODO: Model this case as well. At least, avoid invalidation of - // globals. - return false; +if (ModelSm

[PATCH] D85753: [clangd] Discard diagnostics from another SourceManager.

adamcz added inline comments. Comment at: clang-tools-extra/clangd/Diagnostics.cpp:568 + // If the diagnostic was generated for a different SourceManager, skip it. + // This can happen when using implicit modules. + if (OrigSrcMgr && Info.hasSourceManager() &&

[PATCH] D85753: [clangd] Discard diagnostics from another SourceManager.

adamcz updated this revision to Diff 285961. adamcz marked 3 inline comments as done. adamcz added a comment. addressed review comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D85753/new/ https://reviews.llvm.org/D85753 Files: clang-tools-e

[PATCH] D85796: [Analysis] Bug fix for exploded graph branching in evalCall for constructor

vrnithinkumar updated this revision to Diff 285969. vrnithinkumar added a comment. - Make exactly single NodeBuilder exists at any given time Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D85796/new/ https://reviews.llvm.org/D85796 Files: clang/l

[PATCH] D85796: [Analysis] Bug fix for exploded graph branching in evalCall for constructor

vrnithinkumar marked an inline comment as done. vrnithinkumar added inline comments. Comment at: clang/lib/StaticAnalyzer/Core/CheckerManager.cpp:682 anyEvaluated = true; +Dst.clear(); Dst.insert(checkDst); NoQ wrote: > vrnithinkumar wro

[PATCH] D86065: [SVE] Make ElementCount members private

david-arm created this revision. david-arm added reviewers: sdesmalen, ctetreau, efriedma, fpetrogalli, kmclaughlin, c-rhodes. Herald added subscribers: llvm-commits, cfe-commits, psnobl, hiraditya, tschuett. Herald added projects: clang, LLVM. david-arm requested review of this revision. This p

[clang] 687e7d3 - [NFC] Tweak a comment about the lock-free builtins

Author: Luís Marques Date: 2020-08-17T13:43:53+01:00 New Revision: 687e7d34253b283945bdf9892aa58fd167f9913d URL: https://github.com/llvm/llvm-project/commit/687e7d34253b283945bdf9892aa58fd167f9913d DIFF: https://github.com/llvm/llvm-project/commit/687e7d34253b283945bdf9892aa58fd167f9913d.diff

[PATCH] D86069: [clang] When loading preamble from AST file, re-export modules in Sema.

adamcz created this revision. Herald added subscribers: cfe-commits, usaxena95, kadircet, arphaman, jkorous. Herald added a project: clang. adamcz requested review of this revision. This addresses a FIXME in ASTReader. Modules were already re-exported for Preprocessor, but not for Sema. The resul

[PATCH] D85091: [Sema, CodeGen] Implement [[likely]] and [[unlikely]] in IfStmt

aaron.ballman added inline comments. Comment at: clang/include/clang/Basic/Attr.td:1288 +def Likely : StmtAttr { + let Spellings = [CXX11<"", "likely", 201803>]; + let Documentation = [LikelihoodDocs]; Mordante wrote: > Mordante wrote: > > aaron.ballman wrote:

[PATCH] D31130: B32239 clang-tidy should not warn about array to pointer decay on system macros

aaron.ballman added a comment. In D31130#2220729 , @fiesh wrote: > Ping everybody? This is a rather important issue I think since it makes > clang-tidy not usable in a lot of cases, and the fix would be all done. > Please let's get this merged! Sorry

[PATCH] D86047: [clangd] Target member of dependent base made visible via a using-decl

hokein added a comment. looks mostly good, just a few suggestions on the test. Comment at: clang-tools-extra/clangd/FindTarget.cpp:128 +const auto ValueFilter = [](const NamedDecl *D) { + return dyn_cast(D) != nullptr; +}; nit: use `isa`. Co

[PATCH] D85324: [SystemZ][z/OS] Add z/OS Target and define macros

abhina.sreeskantharajan added inline comments. Comment at: clang/lib/Basic/Targets/OSTargets.h:730 +MacroBuilder &Builder) const override { +Builder.defineMacro("_LONG_LONG"); +Builder.defineMacro("_OPEN_DEFAULT"); hubert.reinterpretca

[PATCH] D85324: [SystemZ][z/OS] Add z/OS Target and define macros

abhina.sreeskantharajan updated this revision to Diff 286014. abhina.sreeskantharajan added a comment. Addressed Hubert's comments, and removed some macros that are unnecessary with system header updates. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.or

[PATCH] D86077: [clangd] Add a way for exporting memory usage metrics

kadircet created this revision. kadircet added reviewers: sammccall, adamcz. Herald added subscribers: cfe-commits, usaxena95, arphaman, jkorous, javed.absar. Herald added a project: clang. kadircet requested review of this revision. Herald added subscribers: MaskRay, ilya-biryukov. Introduces a

[PATCH] D86077: [clangd] Add a way for exporting memory usage metrics

adamcz added inline comments. Comment at: clang-tools-extra/clangd/TUScheduler.cpp:172 +for (const auto &Elem : LRU) + TotalBytes += Elem.second->getUsedBytes(); +return TotalBytes; Any idea how expensive this is? I suppose TUScheduler::update() is r

[PATCH] D85091: [Sema, CodeGen] Implement [[likely]] and [[unlikely]] in IfStmt

Quuxplusone added inline comments. Comment at: clang/test/SemaCXX/attr-likelihood.cpp:101 +} +#endif aaron.ballman wrote: > Mordante wrote: > > aaron.ballman wrote: > > > Mordante wrote: > > > > Quuxplusone wrote: > > > > > I'd like to see a case like `if (x) [[l

[PATCH] D86077: [clangd] Add a way for exporting memory usage metrics

kadircet added inline comments. Comment at: clang-tools-extra/clangd/TUScheduler.cpp:172 +for (const auto &Elem : LRU) + TotalBytes += Elem.second->getUsedBytes(); +return TotalBytes; adamcz wrote: > Any idea how expensive this is? I suppose TUSchedu

[PATCH] D86077: [clangd] Add a way for exporting memory usage metrics

adamcz added inline comments. Comment at: clang-tools-extra/clangd/TUScheduler.cpp:168 + size_t getUsedBytes() { +size_t TotalBytes = 0; nit: This is the same name as getUsedBytes(Key K). Maybe rename to getTotalUsedBytes()? Comment at:

[PATCH] D85977: [release][docs] Update contributions to LLVM 11 for SVE.

david-arm added inline comments. Comment at: llvm/docs/ReleaseNotes.rst:70 + ``VFDatabase`` class. When scanning through the set of vector + functions associated to a scalar call, the loop vectorizer now + relies on ``VFDatabase``, instead of ``TargetLibraryInfo``. ---

[PATCH] D83536: [clangd] Index refs to main-file symbols as well

nridge added inline comments. Comment at: clang-tools-extra/clangd/unittests/SymbolCollectorTests.cpp:727 + // Run the collector again with CollectMainFileRefs = true. + InMemoryFileSystem = new llvm::vfs::InMemoryFileSystem(); + CollectorOpts.CollectMainFileRefs = true; -

[PATCH] D86065: [SVE] Make ElementCount members private

fpetrogalli added inline comments. Comment at: llvm/include/llvm/Support/TypeSize.h:56 + friend bool operator>(const ElementCount &LHS, const ElementCount &RHS) { +assert(LHS.Scalable == RHS.Scalable && I think that @ctetreau is right on https://reviews.l

[PATCH] D86020: [MemCpyOptimizer] Optimize passing byref function arguments down the stack

atrosinenko updated this revision to Diff 286037. atrosinenko added a comment. Restrict transformation to passing through `byref` arguments, not arbitrary pointers. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D86020/new/ https://reviews.llvm.org/

[PATCH] D85091: [Sema, CodeGen] Implement [[likely]] and [[unlikely]] in IfStmt

aaron.ballman added inline comments. Comment at: clang/test/SemaCXX/attr-likelihood.cpp:101 +} +#endif Quuxplusone wrote: > aaron.ballman wrote: > > Mordante wrote: > > > aaron.ballman wrote: > > > > Mordante wrote: > > > > > Quuxplusone wrote: > > > > > > I'd li

[PATCH] D85917: [MSP430] Fix passing C structs and unions as function arguments

atrosinenko updated this revision to Diff 286038. atrosinenko added a comment. Update with implicit pointers being passed through. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D85917/new/ https://reviews.llvm.org/D85917 Files: clang/lib/CodeGen/

[PATCH] D86020: [MemCpyOptimizer] Optimize passing byref function arguments down the stack

jdoerfert added a comment. This looks reasonable on first glance. @arsenm ? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D86020/new/ https://reviews.llvm.org/D86020 ___ cfe-commits mailing list cfe-commi

[PATCH] D86077: [clangd] Add a way for exporting memory usage metrics

kadircet marked 8 inline comments as done. kadircet added inline comments. Comment at: clang-tools-extra/clangd/TUScheduler.cpp:1309 +// fileStats results include ast cache sizes too, subtract them. +PreambleBytes -= ASTCacheBytes; + } adamcz wrote: > So

[PATCH] D86077: [clangd] Add a way for exporting memory usage metrics

kadircet updated this revision to Diff 286043. kadircet marked an inline comment as done. kadircet added a comment. - Rename the overload - Add comments around possible caveats that might result in inaccuracies. - Move the metric recording itself into another thread. - Keep the calculations in the

[PATCH] D86089: Add experimental flang driver and frontend with help screen

CarolineConcatto created this revision. Herald added subscribers: llvm-commits, cfe-commits, dang, usaxena95, kadircet, hiraditya, mgorny. Herald added a reviewer: DavidTruby. Herald added a reviewer: sscalpone. Herald added projects: clang, LLVM. CarolineConcatto requested review of this revision

[PATCH] D83536: [clangd] Index refs to main-file symbols as well

kadircet added inline comments. Comment at: clang-tools-extra/clangd/unittests/SymbolCollectorTests.cpp:727 + // Run the collector again with CollectMainFileRefs = true. + InMemoryFileSystem = new llvm::vfs::InMemoryFileSystem(); + CollectorOpts.CollectMainFileRefs = true; ---

[PATCH] D86020: [MemCpyOptimizer] Optimize passing byref function arguments down the stack

arsenm added inline comments. Comment at: llvm/test/Transforms/MemCpyOpt/byref-memcpy.ll:44 +} + +declare void @leaf(%struct.S* byref(%struct.S) align 4) I think this is missing an alignment check. Can you add a test where the callee requires a higher parameter

[PATCH] D86091: [cmake] Fix build of attribute plugin example on Windows

krisb created this revision. krisb added a reviewer: john.brawn. Herald added subscribers: cfe-commits, mgorny. Herald added a project: clang. krisb requested review of this revision. Seems '${cmake_2_8_12_PRIVATE}' was removed long time ago, so it should be just PRIVATE keyword here. Repository

[PATCH] D84988: WIP [Coverage] Add empty line regions to SkippedRegions

vsk added a comment. Hi @zequanwu, are you looking for review for this patch? I wasn't sure because of the WIP label. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D84988/new/ https://reviews.llvm.org/D84988 ___

[PATCH] D85977: [release][docs] Update contributions to LLVM 11 for SVE.

fpetrogalli updated this revision to Diff 286057. fpetrogalli marked 3 inline comments as done. fpetrogalli added a comment. Thank you for the review @david-arm. I have addressed all your comments, and I also have removed the additional unit tests that was checking that the example in the docs wa

[clang] a397319 - [test] Fix thinlto-debug-pm.c in preparation for -enable-npm-optnone

Author: Arthur Eubanks Date: 2020-08-17T10:06:15-07:00 New Revision: a3973195095ed918915213341c132b41fb269f4e URL: https://github.com/llvm/llvm-project/commit/a3973195095ed918915213341c132b41fb269f4e DIFF: https://github.com/llvm/llvm-project/commit/a3973195095ed918915213341c132b41fb269f4e.diff

[clang] b0ceff9 - [test] Fix aggregate-assign-call.c in preparation for -enable-npm-optnone

Author: Arthur Eubanks Date: 2020-08-17T10:06:40-07:00 New Revision: b0ceff94d66372fd88dcf924e1c6751ce5ab5ee4 URL: https://github.com/llvm/llvm-project/commit/b0ceff94d66372fd88dcf924e1c6751ce5ab5ee4 DIFF: https://github.com/llvm/llvm-project/commit/b0ceff94d66372fd88dcf924e1c6751ce5ab5ee4.diff

[PATCH] D86011: [test] Fix thinlto-debug-pm.c in preparation for -enable-npm-optnone

This revision was automatically updated to reflect the committed changes. Closed by commit rGa3973195095e: [test] Fix thinlto-debug-pm.c in preparation for -enable-npm-optnone (authored by aeubanks). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D8601

[PATCH] D86008: [test] Fix aggregate-assign-call.c in preparation for -enable-npm-optnone

This revision was automatically updated to reflect the committed changes. Closed by commit rGb0ceff94d663: [test] Fix aggregate-assign-call.c in preparation for -enable-npm-optnone (authored by aeubanks). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/

[PATCH] D84988: [Coverage] Add empty line regions to SkippedRegions

zequanwu added a comment. In D84988#2221805 , @vsk wrote: > Hi @zequanwu, are you looking for review for this patch? I wasn't sure > because of the WIP label. Yes, I removed the label. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D85796: [Analysis] Bug fix for exploded graph branching in evalCall for constructor

NoQ accepted this revision. NoQ added a comment. This revision is now accepted and ready to land. Thanks!~ Comment at: clang/test/Analysis/smart-ptr.cpp:44 std::unique_ptr P(new A()); + clang_analyzer_numTimesReached(); // expected-warning {{1}} P->foo(); // No warning.

[PATCH] D82756: Port some floating point options to new option marshalling infrastructure

dang added a comment. Ping? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D82756/new/ https://reviews.llvm.org/D82756 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin

[PATCH] D86020: [MemCpyOptimizer] Optimize passing byref function arguments down the stack

rjmccall added a comment. Sorry, I tried to say thiis more succinctly before, but what exactly is the semantic property of `byref` that allows this optimization? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D86020/new/ https://reviews.llvm.org/D86

[PATCH] D84988: [Coverage] Add empty line regions to SkippedRegions

vsk added inline comments. Comment at: clang/include/clang/Lex/Lexer.h:131 + const char *NewLinePtr; + Could you leave a comment describing what this is? Comment at: clang/include/clang/Lex/Preprocessor.h:960 + void setParsingFunctionBody(b

[PATCH] D80833: [CodeView] Add full repro to LF_BUILDINFO record

aeubanks added a comment. This seems to be breaking determinism on Windows builds, see https://crbug.com/1117026. Can this be reverted and fixed? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D80833/new/ https://reviews.llvm.org/D80833 ___

[PATCH] D86089: [flang][driver]Add experimental flang driver and frontend with help screen

tskeith requested changes to this revision. tskeith added inline comments. This revision now requires changes to proceed. Comment at: flang/include/flang/Frontend/CompilerInstance.h:11 + +#include "flang/Frontend/CompilerInvocation.h" + Why is this called "Fronte

[PATCH] D85324: [SystemZ][z/OS] Add z/OS Target and define macros

MaskRay added inline comments. Comment at: clang/test/Preprocessor/init.c:1041 // +// RUN: %clang_cc1 -E -dM -ffreestanding -triple=s390x-none-zos -fno-signed-char < /dev/null | FileCheck -match-full-lines -check-prefix S390X-ZOS %s +// RUN: %clang_cc1 -x c -E -dM -ffreestandi

[PATCH] D85324: [SystemZ][z/OS] Add z/OS Target and define macros

abhina.sreeskantharajan updated this revision to Diff 286092. abhina.sreeskantharajan added a comment. Thanks MaskRay. I moved the zos testcase to a new file called init-zos.c instead and reduced the number of RUN commands. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION http

[PATCH] D85324: [SystemZ][z/OS] Add z/OS Target and define macros

abhina.sreeskantharajan marked an inline comment as done. abhina.sreeskantharajan added inline comments. Comment at: clang/test/Preprocessor/init.c:1041 // +// RUN: %clang_cc1 -E -dM -ffreestanding -triple=s390x-none-zos -fno-signed-char < /dev/null | FileCheck -match-full-line

[PATCH] D80833: [CodeView] Add full repro to LF_BUILDINFO record

aganea added a comment. In D80833#2221866 , @aeubanks wrote: > This seems to be breaking determinism on Windows builds, see > https://crbug.com/1117026. Can this be reverted and fixed? Will do. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST

[PATCH] D86020: [MemCpyOptimizer] Optimize passing byref function arguments down the stack

atrosinenko updated this revision to Diff 286097. atrosinenko added a comment. Add a test for insufficiently aligned source. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D86020/new/ https://reviews.llvm.org/D86020 Files: llvm/include/llvm/IR/Ins

[PATCH] D86020: [MemCpyOptimizer] Optimize passing byref function arguments down the stack

atrosinenko added a comment. @rjmccall Maybe I overestimated similarity of `byval` and recently introduced `byref`... Looks like some aliasing restrictions are not mentioned in LLVM Language Reference . For example, the only way for Clan

[PATCH] D86097: [OpenMP][AMDGCN] Generate global variables and attributes for AMDGCN

saiislam created this revision. saiislam added reviewers: ABataev, jdoerfert, JonChesterfield. Herald added subscribers: cfe-commits, guansong, yaxunl, jvesely, jholewinski. Herald added a project: clang. saiislam requested review of this revision. Herald added a subscriber: sstefan1. Provide supp

[PATCH] D84375: [git-clang-format] Add --diffstat parameter

JakeMerdichAMD added reviewers: MyDeveloperDay, JakeMerdichAMD. JakeMerdichAMD added a comment. Reviving this since it looks perfectly fine to me (from my limited commit history in git-clang-format :P), is useful, and there's no good reason for it to be stalled. I'll wait a day or two to see if

[PATCH] D86097: [OpenMP][AMDGCN] Generate global variables and attributes for AMDGCN

ABataev added inline comments. Comment at: clang/lib/CodeGen/CGOpenMPRuntime.h:499 + + QualType TgtAttributeStructQTy; class OffloadEntriesInfoManagerTy { Cab this type and corresponding functions be made AMDGCN-specific only? Comment at: c

[PATCH] D85384: [X86] Add basic support for -mtune command line option in clang

craig.topper added a comment. Ping CHANGES SINCE LAST ACTION https://reviews.llvm.org/D85384/new/ https://reviews.llvm.org/D85384 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D85384: [X86] Add basic support for -mtune command line option in clang

erichkeane added a comment. 1 comment, otherwise seems alright to me. Comment at: clang/lib/CodeGen/CodeGenModule.cpp:1752 StringRef TargetCPU = getTarget().getTargetOpts().CPU; + StringRef TuneCPU = getTarget().getTargetOpts().TuneCPU; std::vector Features;

[PATCH] D85384: [X86] Add basic support for -mtune command line option in clang

craig.topper added inline comments. Comment at: clang/lib/CodeGen/CodeGenModule.cpp:1752 StringRef TargetCPU = getTarget().getTargetOpts().CPU; + StringRef TuneCPU = getTarget().getTargetOpts().TuneCPU; std::vector Features; erichkeane wrote: > Does this l

[PATCH] D85384: [X86] Add basic support for -mtune command line option in clang

erichkeane added inline comments. Comment at: clang/lib/CodeGen/CodeGenModule.cpp:1752 StringRef TargetCPU = getTarget().getTargetOpts().CPU; + StringRef TuneCPU = getTarget().getTargetOpts().TuneCPU; std::vector Features; craig.topper wrote: > erichkeane

[PATCH] D85920: [FPEnv][AST] WIP!!! For casts, keep FP options in trailing storage of CastExpr

kpn planned changes to this revision. kpn added a comment. It would be better to go with D85960 . I'll hedge and keep this open until that one gets pushed. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D85920/new/ h

[PATCH] D86100: [Clang][SVE] NFC: Move info about ACLE types into separate function.

sdesmalen created this revision. sdesmalen added reviewers: c-rhodes, efriedma. Herald added subscribers: psnobl, tschuett. Herald added a project: clang. sdesmalen requested review of this revision. This function returns a struct `BuiltinVectorTypeInfo` that contains the builtin vector's element

[clang] 98e01f5 - Revert "Re-Re-land: [CodeView] Add full repro to LF_BUILDINFO record"

Author: Alexandre Ganea Date: 2020-08-17T15:49:18-04:00 New Revision: 98e01f56b0a117f0f32ed2f9b7d61e85830c URL: https://github.com/llvm/llvm-project/commit/98e01f56b0a117f0f32ed2f9b7d61e85830c DIFF: https://github.com/llvm/llvm-project/commit/98e01f56b0a117f0f32ed2f9b7d61e85830c.dif

[PATCH] D86101: [AArch64][SVE] Add missing debug info for ACLE types.

sdesmalen created this revision. sdesmalen added reviewers: rsandifo-arm, efriedma, rjmccall. Herald added subscribers: llvm-commits, danielkiss, psnobl, hiraditya, kristof.beyls, tschuett, aprantl. Herald added a reviewer: rengolin. Herald added projects: clang, LLVM. sdesmalen requested review o

[PATCH] D84988: [Coverage] Add empty line regions to SkippedRegions

zequanwu updated this revision to Diff 286123. zequanwu marked 3 inline comments as done. zequanwu edited the summary of this revision. zequanwu added a comment. Address comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D84988/new/ https://rev

[PATCH] D84988: [Coverage] Add empty line regions to SkippedRegions

zequanwu added inline comments. Comment at: clang/lib/CodeGen/CoverageMappingGen.cpp:326 +if (PrevTokLoc.isValid()) { + unsigned PrevTokLine = SM.getSpellingLineNumber(PrevTokLoc); + if (SR.LineStart == PrevTokLine) { vsk wrote: > It looks like this

[PATCH] D84988: [Coverage] Add empty line regions to SkippedRegions

zequanwu added inline comments. Comment at: llvm/lib/ProfileData/Coverage/CoverageMapping.cpp:580 const auto &R = Segments[I]; - if (!(L.Line < R.Line) && !(L.Line == R.Line && L.Col < R.Col)) { + if (!(L.Line <= R.Line) && !(L.Line == R.Line && L.Col <= R.Col))

[PATCH] D85810: [clang] Pass-through remarks options to lld

weiwang updated this revision to Diff 286124. weiwang added a comment. Herald added subscribers: dang, arichardson, emaste. Herald added a reviewer: espindola. update: 1. add `--plugin-opt` alias for remarks in lld 2. handle both lld and ld.gold pass-through 3. simplify target checking logic 4. c

[PATCH] D84261: [PGO] Supporting code for always instrumenting entry block

kpdev42 added inline comments. Comment at: llvm/include/llvm/ProfileData/InstrProfData.inc:676 #define VARIANT_MASK_CSIR_PROF (0x1ULL << 57) +#define VARIANT_MASK_INSTR_ENTRY (0x1ULL << 58) #define INSTR_PROF_RAW_VERSION_VAR __llvm_profile_raw_version This revi

[PATCH] D86065: [SVE] Make ElementCount members private

ctetreau added a comment. Perhaps now would be a good time to combine TypeSize and ElementCount into a single Polynomial type? We don't have to implement the whole abstraction of `c*x^n` (since we currently don't use the exponent, and don't distinguish between X's) but if it's ever needed in th

[PATCH] D86105: [darwin] Disable the -Wpsabi warning

arphaman created this revision. arphaman added reviewers: ab, t.p.northover, erichkeane. Herald added subscribers: ributzka, dexonsmith, jkorous. arphaman requested review of this revision. The Darwin targets don't enable AVX/AVX512 by default to support Rosetta 2, so the new -Wpsabi warning adds

[PATCH] D82727: [PowerPC] Implement Vector Expand Mask builtins in LLVM/Clang

NeHuang added a comment. Overall LGTM. I only have some nits comment. Comment at: clang/test/CodeGen/builtins-ppc-p10vector.c:136 +vector unsigned char test_vexpandm_uc(void) { + // CHECK: @llvm.ppc.altivec.vexpandbm(<16 x i8> %{{.+}}) nit: can we change the

[PATCH] D85917: [MSP430] Fix passing C structs and unions as function arguments

rjmccall accepted this revision. rjmccall added a comment. This revision is now accepted and ready to land. LGTM Comment at: clang/lib/CodeGen/TargetInfo.cpp:7523 + return ABIArgInfo::getIndirectAliased( + getContext().getTypeAlignInChars(Ty), /*AddrSpace=*/0); +

[libclc] 3a7051d - libclc: Fix FP_ILOGBNAN definition

Author: Boris Brezillon Date: 2020-08-17T13:45:43-07:00 New Revision: 3a7051d9c28e3dd6da5048d91b74fad830728e93 URL: https://github.com/llvm/llvm-project/commit/3a7051d9c28e3dd6da5048d91b74fad830728e93 DIFF: https://github.com/llvm/llvm-project/commit/3a7051d9c28e3dd6da5048d91b74fad830728e93.dif

[PATCH] D82609: [PowerPC] Implement Vector Multiply High/Divide Extended Builtins in LLVM/Clang

NeHuang added inline comments. Comment at: llvm/test/CodeGen/PowerPC/p10-vector-divide.ll:59 + +define <4 x i32> @test_vdivesw(<4 x i32> %a, <4 x i32> %b) { +; CHECK-LABEL: test_vdivesw: nit: do we also need `_intrinsic` in the name as the test cases for the v

[libclc] 3d21fa5 - libclc: Make all built-ins overloadable

Author: Daniel Stone Date: 2020-08-17T13:55:48-07:00 New Revision: 3d21fa56f5f5afbbf16b35b199480af71e1189a3 URL: https://github.com/llvm/llvm-project/commit/3d21fa56f5f5afbbf16b35b199480af71e1189a3 DIFF: https://github.com/llvm/llvm-project/commit/3d21fa56f5f5afbbf16b35b199480af71e1189a3.diff

[PATCH] D86049: RFC: Implement optional exportable wrapper function generation for objc_direct methods.

plotfi updated this revision to Diff 286141. plotfi added a comment. change for clang-tidy and clang-format. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D86049/new/ https://reviews.llvm.org/D86049 Files: clang/include/clang/Basic/CodeGenOptions

[libclc] c37145c - libclc: Add Mesa/SPIR-V target

Author: Dave Airlie Date: 2020-08-17T14:01:46-07:00 New Revision: c37145cab12168798a603e22af6b6bf6f606b705 URL: https://github.com/llvm/llvm-project/commit/c37145cab12168798a603e22af6b6bf6f606b705 DIFF: https://github.com/llvm/llvm-project/commit/c37145cab12168798a603e22af6b6bf6f606b705.diff L

Re: [PATCH] D84261: [PGO] Supporting code for always instrumenting entry block

I think you are right -- the two files need to be in sync. On Mon, Aug 17, 2020 at 1:17 PM Pavel Kosov via Phabricator via llvm-commits wrote: > kpdev42 added inline comments. > > > > Comment at: llvm/include/llvm/ProfileData/InstrProfData.inc:676 > #define VARIANT_MASK_CSIR_PR

[libunwind] 4cd0937 - [libunwind] Remove compatibility support for macOS 10.6

Author: Steven Wu Date: 2020-08-17T14:09:03-07:00 New Revision: 4cd09374cdb163573007ccb402f5ba8970eb6134 URL: https://github.com/llvm/llvm-project/commit/4cd09374cdb163573007ccb402f5ba8970eb6134 DIFF: https://github.com/llvm/llvm-project/commit/4cd09374cdb163573007ccb402f5ba8970eb6134.diff LOG

[PATCH] D85810: [clang] Pass-through remarks options to linker

MaskRay added inline comments. Comment at: lld/ELF/Options.td:595 HelpText<"Alias for --lto-obj-path=">; +def: J<"plugin-opt=opt-remarks-filename=">, + Alias, The change should be moved to a previous patch which will add `--opt-remarks-*` options. Reposito

[clang] 790878f - [NFC][clang] Adjust test/CodeGenCXX/nrvo.cpp after 03127f795b8244c1039c18d4391374707a3dc75e

Author: Roman Lebedev Date: 2020-08-18T00:57:35+03:00 New Revision: 790878f291fa5dc58a1c560cb6cc76fd1bfd1c5a URL: https://github.com/llvm/llvm-project/commit/790878f291fa5dc58a1c560cb6cc76fd1bfd1c5a DIFF: https://github.com/llvm/llvm-project/commit/790878f291fa5dc58a1c560cb6cc76fd1bfd1c5a.diff

[PATCH] D83088: Introduce CfgTraits abstraction

dblaikie added a comment. In D83088#2218559 , @nhaehnle wrote: > In D83088#2213886 , @dblaikie wrote: > >> In D83088#2213864 , @nhaehnle wrote: >> >>> In D83088#2213802

[PATCH] D86116: [Coverage] Adjust skipped regions only if {Prev,Next}TokLoc is in the same file as regions' {start, end}Loc

zequanwu created this revision. zequanwu added reviewers: vsk, hans. Herald added a project: clang. Herald added a subscriber: cfe-commits. zequanwu requested review of this revision. Fix a bug if {Prev, Next}TokLoc is in different file from skipped regions' {start, end}Loc Repository: rG LLV

[PATCH] D86116: [Coverage] Adjust skipped regions only if {Prev,Next}TokLoc is in the same file as regions' {start, end}Loc

zequanwu updated this revision to Diff 286167. zequanwu added a comment. Update test. The bug is when start or end location skipped regions has the same spelling line number as PrevTokLoc or NextTokLoc but in different files. In the test case, end location of skipped regions is in line 6 and PreT

[PATCH] D86105: [darwin] Disable the -Wpsabi warning

arphaman updated this revision to Diff 286181. arphaman added a comment. add missing test fix CHANGES SINCE LAST ACTION https://reviews.llvm.org/D86105/new/ https://reviews.llvm.org/D86105 Files: clang/lib/CodeGen/TargetInfo.cpp clang/test/CodeGen/target-avx-abi-diag.c clang/test/CodeG

[clang] c7ec3a7 - [PowerPC] Implement Vector Extract Mask builtins in LLVM/Clang

Author: Amy Kwan Date: 2020-08-17T21:14:17-05:00 New Revision: c7ec3a7e338cd8e58424a66d29162e9b6a5847f7 URL: https://github.com/llvm/llvm-project/commit/c7ec3a7e338cd8e58424a66d29162e9b6a5847f7 DIFF: https://github.com/llvm/llvm-project/commit/c7ec3a7e338cd8e58424a66d29162e9b6a5847f7.diff LOG:

[PATCH] D82675: [PowerPC] Implement Vector Extract Mask builtins in LLVM/Clang

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGc7ec3a7e338c: [PowerPC] Implement Vector Extract Mask builtins in LLVM/Clang (authored by amyk). Changed prior to commit: https://reviews.llvm.org

  1   2   >