[PATCH] D85474: Add -fbinutils-version= to gate ELF features on the specified binutils version

jhenderson added a comment. Looks like there's only an `llc` test, but the option is in clang too? Should we have a test there? Is there any documentation for clang this option needs adding to? Also, this likely deserves a release note, I feel. Comment at: clang/include/clan

[PATCH] D77598: Integral template argument suffix and cast printing

reikdas updated this revision to Diff 285565. reikdas added a comment. Made some changes to SemaTemplate.cpp based on http://clang-developers.42468.n3.nabble.com/Using-clang-tool-to-Exact-type-names-in-template-specification-arguments-td4069210.html CHANGES SINCE LAST ACTION https://reviews.l

[PATCH] D85913: [SyntaxTree] Split `TreeTestBase` into header and source

eduucaldas updated this revision to Diff 285566. eduucaldas added a comment. remove static inside anonymous namespace Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D85913/new/ https://reviews.llvm.org/D85913 Files: clang/unittests/Tooling/Syntax/

[PATCH] D77229: [Analyzer] Avoid handling of LazyCompundVals in IteratorModeling

gamesh411 accepted this revision. gamesh411 added a comment. This revision is now accepted and ready to land. Thanks! LGTM now. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D77229/new/ https://reviews.llvm.org/D77229 ___ cfe-commits mailing l

[clang] 2e4a20f - [SyntaxTree] Split `TreeTestBase` into header and source

Author: Eduardo Caldas Date: 2020-08-14T07:29:07Z New Revision: 2e4a20fd7062f65c06b438953de3d340df00b7a7 URL: https://github.com/llvm/llvm-project/commit/2e4a20fd7062f65c06b438953de3d340df00b7a7 DIFF: https://github.com/llvm/llvm-project/commit/2e4a20fd7062f65c06b438953de3d340df00b7a7.diff LOG

[PATCH] D85913: [SyntaxTree] Split `TreeTestBase` into header and source

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG2e4a20fd7062: [SyntaxTree] Split `TreeTestBase` into header and source (authored by eduucaldas). Repository: rG LLVM Github Monorepo CHANGES SINC

[PATCH] D85573: [CGAtomic] Mark atomic libcall functions `nounwind`

This revision was automatically updated to reflect the committed changes. Closed by commit rG909a851dbffe: [CGAtomic] Mark atomic libcall functions `nounwind` (authored by guiand). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D85573/new/ https://rev

[clang] 909a851 - [CGAtomic] Mark atomic libcall functions `nounwind`

Author: Gui Andrade Date: 2020-08-14T07:46:43Z New Revision: 909a851dbffeb3637c19268e12e10fdf3dae2add URL: https://github.com/llvm/llvm-project/commit/909a851dbffeb3637c19268e12e10fdf3dae2add DIFF: https://github.com/llvm/llvm-project/commit/909a851dbffeb3637c19268e12e10fdf3dae2add.diff LOG: [

[PATCH] D85559: [MSAN] Reintroduce libatomic load/store instrumentation

guiand updated this revision to Diff 285572. guiand added a comment. Addressed comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D85559/new/ https://reviews.llvm.org/D85559 Files: compiler-rt/test/msan/libatomic.c compiler-rt/test/msan/lib

[PATCH] D85743: [CodeGen][AArch64] Support arm_sve_vector_bits attribute

c-rhodes marked 2 inline comments as done. c-rhodes added inline comments. Comment at: clang/lib/AST/ItaniumMangle.cpp:3330 +// appendices to the Procedure Call Standard for the Arm Architecture, see: +// https://github.com/ARM-software/abi-aa/blob/master/aapcs64/aapcs64.rst#app

[PATCH] D85960: [AST][FPEnv] Keep FP options in trailing storage of CastExpr

sepavloff created this revision. sepavloff added reviewers: rjmccall, mibintc, shafik, kpn. Herald added a subscriber: martong. Herald added a project: clang. sepavloff requested review of this revision. This change allow a CallExpr to have optional FPOptionsOverride object, stored in trailing sto

[PATCH] D85920: [FPEnv][AST] WIP!!! For casts, keep FP options in trailing storage of CastExpr

sepavloff added a comment. Unfortunately I also prepared similar patch: https://reviews.llvm.org/D85960. I didn't look into your patch in details yet, but I think they are close, as the implementation looks straightforward. We need to merge our patches. Repository: rG LLVM Github Monorepo CH

[PATCH] D85960: [AST][FPEnv] Keep FP options in trailing storage of CastExpr

sepavloff added a comment. Similar patch is here: https://reviews.llvm.org/D85920. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D85960/new/ https://reviews.llvm.org/D85960 ___ cfe-commits mailing list cf

[PATCH] D81272: [clang-tidy] New check `misc-redundant-condition`

baloghadamsoftware added inline comments. Comment at: clang-tools-extra/clang-tidy/misc/MiscTidyModule.cpp:46 +CheckFactories.registerCheck( +"misc-redundant-condition"); CheckFactories.registerCheck( aaron.ballman wrote: > baloghadamsoftware wro

[PATCH] D81272: [clang-tidy] New check `bugprone-redundant-branch-condition`

baloghadamsoftware updated this revision to Diff 285606. baloghadamsoftware retitled this revision from "[clang-tidy] New check `misc-redundant-condition`" to "[clang-tidy] New check `bugprone-redundant-branch-condition`". baloghadamsoftware edited the summary of this revision. baloghadamsoftware

[PATCH] D81272: [clang-tidy] New check `bugprone-redundant-branch-condition`

baloghadamsoftware updated this revision to Diff 285608. baloghadamsoftware added a comment. It seems that //release notes// were not renamed automatically. I updated it manually now. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D81272/new/ https://reviews.llvm.org/D81272 Files: cla

[PATCH] D85962: [SyntaxTree] Create annotations infrastructure and apply it in expression tests.

eduucaldas created this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. eduucaldas requested review of this revision. In this process we also create some other tests, in order to not lose coverage when focusing on the annotated code. Repository: rG LLVM Github

[PATCH] D85962: [SyntaxTree] Create annotations infrastructure and apply it in expression tests.

eduucaldas updated this revision to Diff 285613. eduucaldas added a comment. Previous diff had only the last commit Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D85962/new/ https://reviews.llvm.org/D85962 Files: clang/unittests/Tooling/Syntax/Bu

[PATCH] D84602: [MSP430] Expose msp430_builtin calling convention to C code

atrosinenko added a comment. In D84602#2206512 , @aaron.ballman wrote: > I still think this case needs some work to keep the bots happy. I would > probably go with: > > case CC_MSP430Builtin: > > // FIXME: Currently unsupported > break; > > But perha

[PATCH] D59615: [AArch64] When creating SISD intrinsic calls widen scalar args into a zero vectors, not undef

aemerson abandoned this revision. aemerson added a comment. Seems no one is enthusiastic about this change, so I'm going to drop it. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D59615/new/ https://reviews.llvm.org/D59615 _

[PATCH] D84415: [analyzer][StdLibraryFunctionsChecker] Add POSIX pthread handling functions

martong added a comment. In D84415#2215780 , @vsavchenko wrote: > Off-topic: I really think that we should have some sort of DSL for that kind > of stuff. In a sense the API provided in the Checker itself is an (embedded) DSL. Or do you think about bein

[PATCH] D84415: [analyzer][StdLibraryFunctionsChecker] Add POSIX pthread handling functions

martong updated this revision to Diff 285626. martong marked an inline comment as done. martong added a comment. - Use the shorter 'getPointerTy' Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D84415/new/ https://reviews.llvm.org/D84415 Files: cla

[PATCH] D85962: [SyntaxTree] Create annotations infrastructure and apply it in expression tests.

eduucaldas updated this revision to Diff 285629. eduucaldas added a comment. Move added Declaration tests to an appropriate place Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D85962/new/ https://reviews.llvm.org/D85962 Files: clang/unittests/Too

[PATCH] D85962: [SyntaxTree] Create annotations infrastructure and apply it in expression tests.

eduucaldas updated this revision to Diff 285632. eduucaldas added a comment. Add annotations to the last missing tests in expressions. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D85962/new/ https://reviews.llvm.org/D85962 Files: clang/unittest

[PATCH] D85962: [SyntaxTree] Create annotations infrastructure and apply it in expression tests.

gribozavr2 added inline comments. Comment at: clang/unittests/Tooling/Syntax/TreeTestBase.cpp:197 + + bool failed = false; + auto AnnotatedRanges = AnnotatedCode.ranges(); Comment at: clang/unittests/Tooling/Syntax/TreeTestBase.cpp:199 + au

[PATCH] D81272: [clang-tidy] New check `bugprone-redundant-branch-condition`

aaron.ballman added a comment. Thanks to the new info, I think the check basically LGTM. Can you add some negative tests and documentation wording to make it clear that the check doesn't currently handle all logically equivalent predicates, like: if (foo) { } else { if (!foo) { }

[PATCH] D84415: [analyzer][StdLibraryFunctionsChecker] Add POSIX pthread handling functions

balazske added a comment. Even some macro-like construct can improve readability. The current way of adding functions is source of copy-paste errors because more things are repeated, these should be written only once. And the `if`s for the existence of types can be eliminated (automated) someho

[PATCH] D85743: [CodeGen][AArch64] Support arm_sve_vector_bits attribute

david-arm added inline comments. Comment at: clang/lib/CodeGen/CGCall.cpp:1342 + if (SrcSize.getKnownMinSize() <= DstSize.getKnownMinSize() || + (isa(SrcTy) || + isa(DstTy))) { I think if you restructure the code here you could do: if (isa(SrcTy) ||

[PATCH] D81272: [clang-tidy] New check `bugprone-redundant-branch-condition`

baloghadamsoftware added a comment. In D81272#2218050 , @aaron.ballman wrote: > Thanks to the new info, I think the check basically LGTM. Can you add some > negative tests and documentation wording to make it clear that the check > doesn't currently han

[PATCH] D74361: [Clang] Undef attribute for global variables

erichkeane added a comment. In D74361#1927931 , @JonChesterfield wrote: > In D74361#1927863 , @thakis wrote: > >> This breaks tests on Windows: http://45.33.8.238/win/10664/step_7.txt >> >> Please take a look, and

[PATCH] D74361: [Clang] Undef attribute for global variables

erichkeane added a comment. Also, see this bug: This crashes immediately when used on a template instantiation: https://bugs.llvm.org/show_bug.cgi?id=47169 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D74361/new/ https://reviews.llvm.org/D74361

[PATCH] D85611: Improve dynamic AST matching diagnostics for conversion errors

aaron.ballman added a comment. Ping CHANGES SINCE LAST ACTION https://reviews.llvm.org/D85611/new/ https://reviews.llvm.org/D85611 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] 07c3348 - [OpenMP][NFC] Update test check lines with new script version

Author: Johannes Doerfert Date: 2020-08-14T08:59:25-05:00 New Revision: 07c33487faff3067953d61e5e968b6c3d1b845d6 URL: https://github.com/llvm/llvm-project/commit/07c33487faff3067953d61e5e968b6c3d1b845d6 DIFF: https://github.com/llvm/llvm-project/commit/07c33487faff3067953d61e5e968b6c3d1b845d6.d

[PATCH] D85938: [OpenMP][OMPIRBuilder] Use the source (=directory + filename) for locations

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG9240e48a588c: [OpenMP][OMPIRBuilder] Use the source (=directory + filename) for locations (authored by jdoerfert). Changed prior to commit: https:

[PATCH] D84415: [analyzer][StdLibraryFunctionsChecker] Add POSIX pthread handling functions

martong marked an inline comment as done. martong added a comment. In D84415#2218084 , @balazske wrote: > Even some macro-like construct can improve readability. The current way of > adding functions is source of copy-paste errors because more things are

[PATCH] D81272: [clang-tidy] New check `bugprone-redundant-branch-condition`

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. In D81272#2218090 , @baloghadamsoftware wrote: > In D81272#2218050 , @aaron.ballman > wrote: >

[PATCH] D80514: [clang-tidy] modernize-use-trailing-return-type support for C++20 concepts and decltype

bernhardmgruber marked 12 inline comments as done. bernhardmgruber added a comment. Thank you for the time to review this! Could you please also commit it for me? Thank you! Comment at: clang-tools-extra/clang-tidy/modernize/UseTrailingReturnTypeCheck.cpp:430 + AT->getKe

[PATCH] D81272: [clang-tidy] New check `bugprone-redundant-branch-condition`

whisperity added a comment. In D81272#2218050 , @aaron.ballman wrote: > Thanks to the new info, I think the check basically LGTM. Can you add some > negative tests and documentation wording to make it clear that the check > doesn't currently handle all

[PATCH] D81272: [clang-tidy] New check `bugprone-redundant-branch-condition`

aaron.ballman added a comment. In D81272#2218173 , @whisperity wrote: > In D81272#2218050 , @aaron.ballman > wrote: > >> Thanks to the new info, I think the check basically LGTM. Can you add some >> negative tests

[PATCH] D81254: [analyzer] Produce symbolic values for C-array elements

ASDenysPetrov added a comment. @steakhal > If index1 and index2 has the same value, we should not be confident that the > x == y holds. Thanks! Now I see. Shame on me =) > We know where it points to (aka. the pointer's value is conjured), but we > don't know what the value if there. Absolute

[PATCH] D74361: [Clang] Undef attribute for global variables

JonChesterfield added a comment. In D74361#2218143 , @erichkeane wrote: > Also, see this bug: This crashes immediately when used on a template > instantiation: https://bugs.llvm.org/show_bug.cgi?id=47169 Thanks for the bug report! Template instantiation

[PATCH] D82317: [Clang/Test]: Update tests where `noundef` attribute is necessary

eugenis added a comment. In D82317#2212145 , @jdoerfert wrote: > In D82317#2211643 , @guiand wrote: > >> After discussing with @eugenis, for the meantime it might be best to do the >> following: >> >> - Change the

[PATCH] D81272: [clang-tidy] New check `bugprone-redundant-branch-condition`

baloghadamsoftware updated this revision to Diff 285656. baloghadamsoftware added a comment. Tests andd for not yet handled cases. Known limiatations included in the docs. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D81272/new/ https://reviews.llvm.org/D81272 Files: clang-tools-extr

[PATCH] D71199: [clang-tidy] New check cppcoreguidelines-prefer-member-initializer

baloghadamsoftware updated this revision to Diff 285657. baloghadamsoftware added a comment. Updated according to a comment. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D71199/new/ https://reviews.llvm.org/D71199 Files: clang-tools-extra/clang-tidy/cppcoreguidelines/CMakeLists.txt

[PATCH] D81272: [clang-tidy] New check `bugprone-redundant-branch-condition`

whisperity added a comment. In D81272#2218175 , @aaron.ballman wrote: > While I agree with your observation about data and flow sensitivity, I > approved on the belief that the check as-is provides enough utility to > warrant adding it as-is. If someone

[PATCH] D74361: [Clang] Undef attribute for global variables

erichkeane added a comment. I did a little debugging, and the problem is the template itself isn't a complete type until you require it with RequireCompleteType. You have this same problem with incomplete types: https://godbolt.org/z/hvf3M4 I would suspect you either add a RequireCompleteType

[PATCH] D85810: [clang] Pass-through remarks options to lld

tejohnson added inline comments. Comment at: clang/lib/Driver/ToolChains/CommonArgs.cpp:71 + + bool isLLD = llvm::sys::path::filename(LinkerPath) == "ld.lld" || + llvm::sys::path::stem(LinkerPath) != "ld.lld"; MaskRay wrote: > Checking the path is

[PATCH] D74361: [Clang] Undef attribute for global variables

JonChesterfield added a comment. In D74361#2218258 , @erichkeane wrote: > I did a little debugging, and the problem is the template itself isn't a > complete type That's clear cut then, thanks. This patch was limited to trivially constructible types, an

[PATCH] D74361: [Clang] Undef attribute for global variables

erichkeane added a comment. Yep! Declaring a global variable that isn't 'extern' with an incomplete type is disallowed anyway, so if you call RequireCompleteType, you're likely just diagnosing that early. You MIGHT have to do some work to allow: struct S; extern S foo __attribute__((loade

[PATCH] D85798: Split Preprocessor/init.c test. NFC.

MaskRay added inline comments. Comment at: clang/test/Preprocessor/init-ppc.c:390 +// PPC:#define __ppc__ 1 +// +// RUN: %clang_cc1 -E -dM -ffreestanding -triple=powerpc-ibm-aix7.1.0.0 -fno-signed-char < /dev/null | FileCheck -match-full-lines -check-prefix PPC-AIX %s -

[PATCH] D85473: [Clang] Add option to allow marking pass-by-value args as noalias.

fhahn added a comment. ping Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D85473/new/ https://reviews.llvm.org/D85473 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin

[PATCH] D85977: [release][docs] Update contributions to LLVM 11 for SVE.

fpetrogalli created this revision. Herald added subscribers: llvm-commits, cfe-commits, tschuett. Herald added projects: clang, LLVM. fpetrogalli requested review of this revision. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D85977 Files: clang/test/CodeGen/aarch64-sve-acle-

[PATCH] D85978: [clang-tools-extra] Added missing comma

zacharyselk created this revision. Herald added subscribers: cfe-commits, usaxena95, kadircet, arphaman, jkorous. Herald added a project: clang. zacharyselk requested review of this revision. The new diagnostic tool (D85545 ) caught a missing comma, adding one to

[PATCH] D85612: [Sema] Use proper integral cast for an enumerate with a fixed bool type

Mordante marked 2 inline comments as done. Mordante added inline comments. Comment at: clang/test/AST/ast-dump-enum-bool.cpp:1 +// RUN: %clang_cc1 -std=c++20 -triple x86_64-unknown-unknown -fsyntax-only -ast-dump %s | FileCheck %s + rsmith wrote: > I don't think

[PATCH] D85977: [release][docs] Update contributions to LLVM 11 for SVE.

fpetrogalli updated this revision to Diff 285678. fpetrogalli added a comment. Added context to the diff. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D85977/new/ https://reviews.llvm.org/D85977 Files: clang/test/CodeGen/aarch64-sve-acle-example.cpp llvm/docs/ReleaseNotes.rst Inde

[PATCH] D85474: Add -fbinutils-version= to gate ELF features on the specified binutils version

MaskRay marked an inline comment as done. MaskRay added inline comments. Comment at: clang/include/clang/Driver/Options.td:3307-3310 +def fbinutils_version_EQ : Joined<["-"], "fbinutils-version=">, Group, + HelpText<"Produced object files can use ELF features only supported by l

[PATCH] D85474: Add -fbinutils-version= to gate ELF features on the specified binutils version

MaskRay added a comment. In D85474#2217598 , @jhenderson wrote: > Looks like there's only an `llc` test, but the option is in clang too? Should > we have a test there? There are generally some dotted edges in the testing of such MC level options. For op

[PATCH] D85977: [release][docs] Update contributions to LLVM 11 for SVE.

tschuett added inline comments. Comment at: llvm/docs/ReleaseNotes.rst:162 + svfloat64_t vout = svadd_x(Pg, vx, vy); +svst1(Pg, &out[i], vout); + } Nit: indentation? CHANGES SINCE LAST ACTION https://reviews.llvm.org/D85977/new/ https:/

[PATCH] D83071: Add support for options with two flags for controlling the same field.

Bigcheese accepted this revision. Bigcheese added a comment. lgtm Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D83071/new/ https://reviews.llvm.org/D83071 ___ cfe-commits mailing list cfe-commits@lists.l

[PATCH] D85474: Add -fbinutils-version= to gate ELF features on the specified binutils version

MaskRay updated this revision to Diff 285681. MaskRay edited the summary of this revision. MaskRay added a comment. Herald added a subscriber: kristof.beyls. Add release note Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D85474/new/ https://reviews.

[PATCH] D84415: [analyzer][StdLibraryFunctionsChecker] Add POSIX pthread handling functions

martong updated this revision to Diff 285682. martong added a comment. - Use Optionals through the Signature Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D84415/new/ https://reviews.llvm.org/D84415 Files: clang/lib/StaticAnalyzer/Checkers/StdLib

[PATCH] D84415: [analyzer][StdLibraryFunctionsChecker] Add POSIX pthread handling functions

martong added a comment. Now I've update the patch to remove all the `if`s. And the optional types are now implicitly handled, so no such mistakes can be done that I had done previously. However, the patch is getting to affect the core of this Checker, so, perhaps I should split this into two p

[PATCH] D85612: [Sema] Use proper integral cast for an enumerate with a fixed bool type

Mordante updated this revision to Diff 285685. Mordante added a comment. Addresses review comments. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D85612/new/ https://reviews.llvm.org/D85612 Files: clang/lib/Sema/SemaCast.cpp clang/test/CXX/drs/dr23xx.cpp clang/test/CodeGen/enum-bo

[PATCH] D85601: Fixes an assertion when IntRange processes a throw expression

Mordante marked 3 inline comments as done. Mordante added inline comments. Comment at: clang/lib/Sema/SemaChecking.cpp:10317-10320 IntRange L = GetExprRange(C, CO->getTrueExpr(), MaxWidth, InConstantContext); IntRange R = GetExprRange(C, CO->getFalseEx

[PATCH] D85879: [OpenMP] Overload `std::isnan` and friends multiple times for the GPU

tra accepted this revision. tra added inline comments. Comment at: clang/lib/Headers/__clang_cuda_cmath.h:85 +//(note that we do not create implicit base functions here). To avoid +//this clash we add a new trait to some of them that is always true +//(thi

[PATCH] D74361: [Clang] Undef attribute for global variables

JonChesterfield added a comment. In D74361#2218294 , @erichkeane wrote: > Yep! Declaring a global variable that isn't 'extern' with an incomplete type > is disallowed anyway, so if you call RequireCompleteType, you're likely just > diagnosing that early

[PATCH] D85978: [clang-tools-extra] Added missing comma

kamaub accepted this revision. kamaub added a comment. This revision is now accepted and ready to land. This LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D85978/new/ https://reviews.llvm.org/D85978

[PATCH] D85981: [clang][Modules] Use File Names Instead of inodes As Loaded Module Keys

CodaFi created this revision. CodaFi added reviewers: vsapsai, Bigcheese, doug.gregor. CodaFi added a project: clang. Herald added subscribers: cfe-commits, dexonsmith. CodaFi requested review of this revision. The ModuleManager's use of FileEntry nodes as the keys for its map of loaded modules is

[PATCH] D85706: [compiler-rt] Compile assembly files as ASM not C

tambre updated this revision to Diff 285692. tambre added a comment. Herald added a project: clang. Herald added a subscriber: cfe-commits. Pass CMAKE_ASM_COMPILER to compiler-rt in runtime build Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D85706/n

[PATCH] D85706: [compiler-rt] Compile assembly files as ASM not C

tambre added a comment. In D85706#2214009 , @phosek wrote: > One concern I have with this change is that we may not always consistently > update CMAKE_ASM_FLAGS or set CMAKE_ASM_COMPILER. This wouldn't make a > difference before, but it'll with this chan

[PATCH] D83088: Introduce CfgTraits abstraction

nhaehnle added a comment. In D83088#2213886 , @dblaikie wrote: > In D83088#2213864 , @nhaehnle wrote: > >> In D83088#2213802 , @dblaikie wrote: >> >>> In D83088#2213797

[PATCH] D85981: [clang][Modules] Use File Names Instead of inodes As Loaded Module Keys

vsapsai added a comment. Overall, looks like a reasonable approach to solve inode reuse. The problem with filenames is that they might not be canonicalized and the same file can be known by different filenames. I'm trying to think through the consequences in the following scenarios: - same nam

[PATCH] D85984: [analyzer] Add a new checker alpha.cplusplus.CPlusPlus11Lock

ASDenysPetrov created this revision. ASDenysPetrov added reviewers: NoQ, vsavchenko, xazax.hun, dcoughlin. ASDenysPetrov added a project: clang. Herald added subscribers: cfe-commits, steakhal, martong, Charusso, dkrupp, donat.nagy, Szelethus, mikhail.ramalho, a.sidorin, rnkovacs, szepet, balogha

[PATCH] D81254: [analyzer] Produce symbolic values for C-array elements

ASDenysPetrov added a comment. Hey, folk, welcome to https://reviews.llvm.org/D85984 I've moved the logic of this checker in `PthreadLockChecker` Should this revision be //closed //or //rejected //somehow? CHANGES SINCE LAST ACTION https://reviews.llvm.org/D81254/new/ https://reviews.llvm.or

[clang-tools-extra] caac40f - [clang-tools-extra] Added missing comma

Author: zacharyselk Date: 2020-08-14T12:27:30-06:00 New Revision: caac40fa5a6158aad93a20eb9aae82513fc5a368 URL: https://github.com/llvm/llvm-project/commit/caac40fa5a6158aad93a20eb9aae82513fc5a368 DIFF: https://github.com/llvm/llvm-project/commit/caac40fa5a6158aad93a20eb9aae82513fc5a368.diff L

[PATCH] D85978: [clang-tools-extra] Added missing comma

This revision was automatically updated to reflect the committed changes. Closed by commit rGcaac40fa5a61: [clang-tools-extra] Added missing comma (authored by zacharyselk). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D85978/new/ https://reviews.ll

[PATCH] D85601: Fixes an assertion when IntRange processes a throw expression

Mordante updated this revision to Diff 285704. Mordante marked an inline comment as done. Mordante added a comment. Addresses review comments. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D85601/new/ https://reviews.llvm.org/D85601 Files: clang/lib/Sema/SemaChecking.cpp clang/test/

[PATCH] D67422: [analyzer] NFC: Move path diagnostic consumer implementations to libAnalysis.

Szelethus accepted this revision. Szelethus added a comment. Unless anyone else objects, I'm happy to see this landed! Nice work! ^-^ CHANGES SINCE LAST ACTION https://reviews.llvm.org/D67422/new/ https://reviews.llvm.org/D67422 ___ cfe-commits mai

[PATCH] D67422: [analyzer] NFC: Move path diagnostic consumer implementations to libAnalysis.

Szelethus added a comment. In D67422#2216137 , @NoQ wrote: > I agree that there's something here and also that it's not that > urgent/critical to rename things at this point. It's not that people suffer > horribly from having to link to only some of thes

[PATCH] D85607: CfgTraits: add CfgInstructionRef

nhaehnle updated this revision to Diff 285711. nhaehnle added a comment. - use llvm_unreachable Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D85607/new/ https://reviews.llvm.org/D85607 Files: clang/include/clang/Analysis/Analyses/Dominators.h

[PATCH] D85607: CfgTraits: add CfgInstructionRef

nhaehnle marked an inline comment as done. nhaehnle added inline comments. Comment at: llvm/include/llvm/CodeGen/MachineCfgTraits.h:100 +// provide one at all. We don't want to lay a subtle performance trap here. +abort(); + } arsenm wrote: > llvm_unreac

[PATCH] D85933: Don't track consteval references for dependent members

Tyker added a comment. thanks for this, here is a few comments aside from that this seems fine. Comment at: clang/lib/Sema/SemaOverload.cpp:1761 + llvm::SaveAndRestore DisableIITracking( + S.RebuildingImmediateInvocation, true); + I don't think R

[PATCH] D85601: Fixes an assertion when IntRange processes a throw expression

rsmith accepted this revision. rsmith added a comment. This revision is now accepted and ready to land. Thanks! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D85601/new/ https://reviews.llvm.org/D85601 ___ cfe-commits mailing list cfe-commits@

[PATCH] D85948: [HeapProf] Clang and LLVM support for heap profiling instrumentation

tejohnson added a comment. Thanks for the comments @vitalybuka and @davidxl, will address those shortly. In D85948#2217476 , @davidxl wrote: > one nit: since the same instrumentation can be used to profiling global > variable accesses (especially those i

[PATCH] D85948: [HeapProf] Clang and LLVM support for heap profiling instrumentation

MaskRay added inline comments. Comment at: clang/include/clang/Driver/Options.td:995 +def fheapprof : Flag<["-"], "fheapprof">, Group, + Flags<[CoreOption, CC1Option]>, HelpText<"Enable heap profiling">; `OptInFFlag<"heapprof", "Enable", "Disable", " heap prof

[PATCH] D85960: [AST][FPEnv] Keep FP options in trailing storage of CastExpr

kpn added a comment. You mentioned in D85920 a need to merge this review with that review. I don't think that's needed. This code here is farther along. It does everything that D85920 does and has necessary pieces implemented a

[PATCH] D85977: [release][docs] Update contributions to LLVM 11 for SVE.

fpetrogalli updated this revision to Diff 285731. fpetrogalli added a comment. Fix indentation of the code exmaple. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D85977/new/ https://reviews.llvm.org/D85977 Files: clang/test/CodeGen/aarch64-sve-ac

[PATCH] D85948: [HeapProf] Clang and LLVM support for heap profiling instrumentation

davidxl added a comment. I think the user visible option needs to match the functionality. Internal naming just needs some comments to document. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D85948/new/ https://reviews.llvm.org/D85948

[PATCH] D85990: [Clang] Fix BZ47169, loader_uninitialized on incomplete types

JonChesterfield created this revision. JonChesterfield added reviewers: erichkeane, aaron.ballman, rjmccall. Herald added a project: clang. Herald added a subscriber: cfe-commits. JonChesterfield requested review of this revision. [Clang] Fix BZ47169, loader_uninitialized on incomplete types Repo

[PATCH] D74361: [Clang] Undef attribute for global variables

JonChesterfield added a comment. Fix proposed at D85990 . Thanks for the detailed bug report! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D74361/new/ https://reviews.llvm.org/D74361 __

[PATCH] D85990: [Clang] Fix BZ47169, loader_uninitialized on incomplete types

erichkeane added inline comments. Comment at: clang/test/Sema/attr-loader-uninitialized.cpp:14 +extern S incomplete_external_rejected __attribute__((loader_uninitialized)); +// expected-error@-1 {{variable has incomplete type 'S'}} +// expected-note@-3 {{forward declaration of 'S

[PATCH] D85559: [MSAN] Reintroduce libatomic load/store instrumentation

eugenis accepted this revision. eugenis added a comment. This revision is now accepted and ready to land. LGTM with 1 comment Comment at: llvm/lib/Transforms/Instrumentation/MemorySanitizer.cpp:3573 + case LibFunc_atomic_load: +if (!isa(CB)) { + llvm::errs

[PATCH] D85091: [Sema, CodeGen] Implement [[likely]] and [[unlikely]] in IfStmt

Mordante planned changes to this revision. Mordante marked 14 inline comments as done. Mordante added inline comments. Comment at: clang/include/clang/Basic/Attr.td:1288 +def Likely : StmtAttr { + let Spellings = [CXX11<"", "likely", 201803>]; + let Documentation = [LikelihoodD

[PATCH] D85559: [MSAN] Reintroduce libatomic load/store instrumentation

guiand added inline comments. Comment at: llvm/lib/Transforms/Instrumentation/MemorySanitizer.cpp:3573 + case LibFunc_atomic_load: +if (!isa(CB)) { + llvm::errs() << "MSAN -- cannot instrument invoke of libatomic load." eugenis wrote: > Prob

[PATCH] D85559: [MSAN] Reintroduce libatomic load/store instrumentation

eugenis added inline comments. Comment at: llvm/lib/Transforms/Instrumentation/MemorySanitizer.cpp:3573 + case LibFunc_atomic_load: +if (!isa(CB)) { + llvm::errs() << "MSAN -- cannot instrument invoke of libatomic load." guiand wrote: > euge

[PATCH] D85924: [clang][feature] Add cxx_abi_relative_vtable feature

mcgrathr accepted this revision. mcgrathr added a comment. This revision is now accepted and ready to land. LGTM but I'm not sure who should sign off on new `__has_feature` symbols. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D85924/new/ https://r

[PATCH] D85798: Split Preprocessor/init.c test. NFC.

tra updated this revision to Diff 285745. tra edited the summary of this revision. tra added a comment. Separated blocks of RUN commands with an empty line to make navigation easier. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D85798/new/ https://

[PATCH] D85798: Split Preprocessor/init.c test. NFC.

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG1689c36b1aeb: Split Preprocessor/init.c test (authored by tra). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.l

[PATCH] D85144: [clang] Improve Dumping of APValues

Tyker updated this revision to Diff 285747. Tyker added a comment. In D85144#2205461 , @riccibruno wrote: > I agree with you that it's fine to use `printPretty` for leaves (and > additionally it would be annoying to duplicate the `LValue` case); that's

[PATCH] D85933: Don't track consteval references for dependent members

wchilders added inline comments. Comment at: clang/lib/Sema/SemaOverload.cpp:1761 + llvm::SaveAndRestore DisableIITracking( + S.RebuildingImmediateInvocation, true); + Tyker wrote: > I don't think RebuildingImmediateInvocation should be used here si

  1   2   >