[PATCH] D70157: Align branches within 32-Byte boundary

annita.zhang added a comment. > > >>> Third, I have not see a justification for why complexity for instruction >>> prefix padding is necessary. All the effected CPUs support multi-byte >>> nops, so we're talking about a *single micro op* difference between the nop >>> form and prefix form.

[clang-tools-extra] 99768b2 - [clangd] (take 2) Try harder to find a plausible `clang` as argv0, particularly on Mac.

Author: Sam McCall Date: 2019-12-06T09:47:03+01:00 New Revision: 99768b243cd7afd312745da58b20ea067f39f89e URL: https://github.com/llvm/llvm-project/commit/99768b243cd7afd312745da58b20ea067f39f89e DIFF: https://github.com/llvm/llvm-project/commit/99768b243cd7afd312745da58b20ea067f39f89e.diff LO

[PATCH] D71029: [clangd] (take 2) Try harder to find a plausible `clang` as argv0, particularly on Mac.

This revision was automatically updated to reflect the committed changes. Closed by commit rG99768b243cd7: [clangd] (take 2) Try harder to find a plausible `clang` as argv0, particularly… (authored by sammccall). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.l

[clang-tools-extra] fac4e3c - [clang-tidy] Fix PR26274

Author: Alexander Kornienko Date: 2019-12-06T10:10:15+01:00 New Revision: fac4e3c5f8a018599cbd9363a735b1c13e8f8a05 URL: https://github.com/llvm/llvm-project/commit/fac4e3c5f8a018599cbd9363a735b1c13e8f8a05 DIFF: https://github.com/llvm/llvm-project/commit/fac4e3c5f8a018599cbd9363a735b1c13e8f8a05

[PATCH] D70974: [clang-tidy] Fix PR26274

This revision was automatically updated to reflect the committed changes. Closed by commit rGfac4e3c5f8a0: [clang-tidy] Fix PR26274 (authored by alexfh). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D70974/new/ https://reviews.llvm.org/D70974 Files:

[PATCH] D70157: Align branches within 32-Byte boundary

davezarzycki added a comment. In D70157#1772227 , @annita.zhang wrote: > > > > > >>> Third, I have not see a justification for why complexity for instruction > >>> prefix padding is necessary. All the effected CPUs support multi-byte > >>> nops, so w

[PATCH] D60499: [ASTImporter] Various source location and range import fixes.

balazske added a comment. The fix looks OK (other alternative is to remove the CHECK with CXXRecordDecl, or make a single line with regular expressions). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D60499/new/ https://reviews.llvm.org/D60499 _

[PATCH] D69778: Make -fmodules-codegen and -fmodules-debuginfo work also with precompiled headers

llunak added a comment. In D69778#1771799 , @rsmith wrote: > It's a bit weird for this to be controlled by a `-fmodules` flag, but it's > only a `-cc1` flag, so I'm OK with that; we can rename it if/when we expose > it from the driver. It's a bit weird

[PATCH] D70615: Add an -fno-temp-file flag for compilation

hans added a comment. > Our build system does not handle randomly named files created during the > build well. Can you share more details about why this is a problem? At least the build systems I work with would not even see the temporary files, as they're written to /tmp or similar, and inste

[clang-tools-extra] d8821ad - [clangd] Fix gcc warning about extra "; " [NFC]

Author: Mikael Holmen Date: 2019-12-06T11:22:48+01:00 New Revision: d8821adacbb02fe9f9707079087d35cb02ef4a6c URL: https://github.com/llvm/llvm-project/commit/d8821adacbb02fe9f9707079087d35cb02ef4a6c DIFF: https://github.com/llvm/llvm-project/commit/d8821adacbb02fe9f9707079087d35cb02ef4a6c.diff

[PATCH] D70073: [ConstExprPreter] Implemented function calls and if statements

nand added a comment. ping Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D70073/new/ https://reviews.llvm.org/D70073 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bi

[PATCH] D70723: [clangd] Store index::SymbolKind in HoverInfo

kadircet updated this revision to Diff 232519. kadircet marked an inline comment as done. kadircet added a comment. - Address comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D70723/new/ https://reviews.llvm.org/D70723 Files: clang-tools-ex

[PATCH] D71029: [clangd] (take 2) Try harder to find a plausible `clang` as argv0, particularly on Mac.

thakis added a comment. Breaks Win: http://45.33.8.238/win/3549/step_7.txt Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D71029/new/ https://reviews.llvm.org/D71029 ___ cfe-commits mailing list cfe-comm

[PATCH] D70723: [clangd] Store index::SymbolKind in HoverInfo

merge_guards_bot added a comment. Build result: pass - 60506 tests passed, 0 failed and 726 were skipped. Log files: console-log.txt , CMakeCache.txt

[clang-tools-extra] 6b11760 - [clangd] Try to fix CompileCommandsTests on windows. NFC

Author: Sam McCall Date: 2019-12-06T12:28:01+01:00 New Revision: 6b11760128751455a73d9f00a5f935d1f49fbd0f URL: https://github.com/llvm/llvm-project/commit/6b11760128751455a73d9f00a5f935d1f49fbd0f DIFF: https://github.com/llvm/llvm-project/commit/6b11760128751455a73d9f00a5f935d1f49fbd0f.diff LO

[PATCH] D71090: [clangd] Navigation from definition of template specialization to primary templateFixes https://github.com/clangd/clangd/issues/212.

sammccall accepted this revision. sammccall added a comment. This revision is now accepted and ready to land. Nice! Comment at: clang-tools-extra/clangd/XRefs.cpp:194 // As a consequence, there's no need to look them up in the index either. - SourceLocation MaybeMacroLocati

[PATCH] D71110: [clangd] A tool to evaluate cross-file rename.

hokein created this revision. Herald added subscribers: cfe-commits, usaxena95, kadircet, arphaman, jkorous, MaskRay, ilya-biryukov, mgorny. Herald added a project: clang. This is a tool that helps us to evaluate the rename results, we may not submit this tool to the code repository, but it has v

[PATCH] D71110: [clangd] A tool to evaluate cross-file rename.

merge_guards_bot added a comment. Build result: pass - 60496 tests passed, 0 failed and 726 were skipped. Log files: console-log.txt , CMakeCache.txt

[PATCH] D70849: [AST] Traverse the class type loc inside the member pointer type loc.

hokein marked an inline comment as done. hokein added inline comments. Comment at: clang/include/clang/AST/RecursiveASTVisitor.h:1169 DEF_TRAVERSE_TYPELOC(MemberPointerType, { - TRY_TO(TraverseType(QualType(TL.getTypePtr()->getClass(), 0))); + if (auto *TSI = TL.getClassTInfo(

[clang-tools-extra] c5adbac - [clangd] Switch Hover.All to structured tests

Author: Kadir Cetinkaya Date: 2019-12-06T13:40:22+01:00 New Revision: c5adbac9b85a53112a9fc9b72e64d2615e3e4df9 URL: https://github.com/llvm/llvm-project/commit/c5adbac9b85a53112a9fc9b72e64d2615e3e4df9 DIFF: https://github.com/llvm/llvm-project/commit/c5adbac9b85a53112a9fc9b72e64d2615e3e4df9.dif

[clang-tools-extra] 24439a7 - [clangd] Store index::SymbolKind in HoverInfo

Author: Kadir Cetinkaya Date: 2019-12-06T13:40:22+01:00 New Revision: 24439a761c5e21fda8f9410a5e80ff07b4ba03a2 URL: https://github.com/llvm/llvm-project/commit/24439a761c5e21fda8f9410a5e80ff07b4ba03a2 DIFF: https://github.com/llvm/llvm-project/commit/24439a761c5e21fda8f9410a5e80ff07b4ba03a2.dif

[PATCH] D70911: [clangd] Switch Hover.All to structured tests

This revision was automatically updated to reflect the committed changes. Closed by commit rGc5adbac9b85a: [clangd] Switch Hover.All to structured tests (authored by kadircet). Changed prior to commit: https://reviews.llvm.org/D70911?vs=231735&id=232537#toc Repository: rG LLVM Github Monorep

[PATCH] D70723: [clangd] Store index::SymbolKind in HoverInfo

This revision was automatically updated to reflect the committed changes. Closed by commit rG24439a761c5e: [clangd] Store index::SymbolKind in HoverInfo (authored by kadircet). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D70723/new/ https://reviews

[clang] a3b2552 - Fix for PR44000. Optimization record for bytecode input missing.

Author: Zahira Ammarguellat Date: 2019-12-06T07:48:42-05:00 New Revision: a3b2552575d3c333e928446fac10cc5b0b4092a9 URL: https://github.com/llvm/llvm-project/commit/a3b2552575d3c333e928446fac10cc5b0b4092a9 DIFF: https://github.com/llvm/llvm-project/commit/a3b2552575d3c333e928446fac10cc5b0b4092a9

[PATCH] D71111: [Sema] Improve diagnostic about addr spaces for overload candidates

Anastasia created this revision. Anastasia added a reviewer: rjmccall. Herald added a subscriber: ebevhan. As discussed in https://reviews.llvm.org/D69938#inline-629726 this commit improves the diagnostic of addr spaces. The approach is currently reusing diagnostic streaming of `Qualifiers`. Th

[PATCH] D71112: [ASTImporter] Implicitly declare parameters for imported ObjCMethodDecls

teemperor created this revision. teemperor added a reviewer: martong. Herald added subscribers: cfe-commits, rnkovacs. Herald added a reviewer: a.sidorin. Herald added a reviewer: shafik. Herald added a project: clang. When Sema encounters a ObjCMethodDecl definition it declares the implicit para

[PATCH] D71112: [ASTImporter] Implicitly declare parameters for imported ObjCMethodDecls

martong added a comment. Thanks for addressing this, I just have some minor comments. Comment at: clang/unittests/AST/ASTImporterTest.cpp:5603 +TEST_P(ASTImporterOptionSpecificTestBase, ImplicitlyDeclareSelf) { + Decl *FromTU = getTuDecl("__attribute__((objc_root_class))\n" +

[PATCH] D70439: [Analyzer][Docs][NFC] Add CodeChecker to the command line tools

martong updated this revision to Diff 232540. martong marked 3 inline comments as done. martong added a comment. Put back the menu, add "open source" property. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D70439/new/ https://reviews.llvm.org/D70439

[PATCH] D70439: [Analyzer][Docs][NFC] Add CodeChecker to the command line tools

martong marked 6 inline comments as done. martong added a comment. In D70439#1772168 , @Charusso wrote: > I would change the order of CCh and scan-build because we usually list stuff > in alphabetical order. Also the chronological order is that, the newes

[PATCH] D71112: [ASTImporter] Implicitly declare parameters for imported ObjCMethodDecls

teemperor updated this revision to Diff 232541. teemperor added a comment. - Put code in raw string (Thanks Gabor!) CHANGES SINCE LAST ACTION https://reviews.llvm.org/D71112/new/ https://reviews.llvm.org/D71112 Files: clang/lib/AST/ASTImporter.cpp clang/unittests/AST/ASTImporterTest.cpp

[PATCH] D71063: [clangd] New rendering structs

sammccall added inline comments. Comment at: clang-tools-extra/clangd/FormattedString.h:25 /// plaintext upon requrest. -class FormattedString { +class RenderableString { public: Naming: not sure "string" is the right name - it doesn't represent the things her

[PATCH] D58634: [PR40778] Generate address space conversion when binding reference to a temporary value in different address space

ebevhan added inline comments. Comment at: lib/Sema/SemaInit.cpp:4806-4808 + if ((RefRelationship == Sema::Ref_Related && + (T1CVRQuals | T2CVRQuals) != T1CVRQuals) || + !T1Quals.isAddressSpaceSupersetOf(T2Quals)) { Sorry for the really late comment o

[PATCH] D71112: [ASTImporter] Implicitly declare parameters for imported ObjCMethodDecls

martong added inline comments. Comment at: clang/unittests/AST/Language.cpp:44 + case Lang_OpenCL: +llvm_unreachable("-std=objc++"); } I think, we should keep the "Not implemented yet!" message here. Perhaps you wanted "-std=objc++" to put next to -x obj

[PATCH] D71112: [ASTImporter] Implicitly declare parameters for imported ObjCMethodDecls

teemperor marked an inline comment as done. teemperor added inline comments. Comment at: clang/unittests/AST/Language.cpp:44 + case Lang_OpenCL: +llvm_unreachable("-std=objc++"); } martong wrote: > I think, we should keep the "Not implemented yet!" messag

[PATCH] D71112: [ASTImporter] Implicitly declare parameters for imported ObjCMethodDecls

teemperor updated this revision to Diff 232547. teemperor added a comment. - Reverted unintentional change to unreachable error message. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D71112/new/ https://reviews.llvm.org/D71112 Files: clang/lib/AST/ASTImporter.cpp clang/unittests/AST

[PATCH] D70804: [Frontend] Allow OpenMP offloading to aarch64

ABataev added inline comments. Comment at: clang/test/OpenMP/openmp_offload_registration.cpp:3-5 +// RUN: %clang_cc1 -verify -fopenmp -x c -triple x86_64-unknown-linux-gnu -fopenmp-targets=aarch64-unknown-linux-gnu,powerpc64-ibm-linux-gnu -emit-llvm %s -o - | FileCheck %s +// R

[PATCH] D71110: [clangd] A tool to evaluate cross-file rename.

hokein updated this revision to Diff 232553. hokein added a comment. add more symbols. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D71110/new/ https://reviews.llvm.org/D71110 Files: clang-tools-extra/clangd/CMakeLists.txt clang-tools-extra/cl

[PATCH] D71110: [clangd] A tool to evaluate cross-file rename.

hokein updated this revision to Diff 232554. hokein added a comment. Fix empty lines. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D71110/new/ https://reviews.llvm.org/D71110 Files: clang-tools-extra/clangd/CMakeLists.txt clang-tools-extra/cla

[PATCH] D70524: Support DebugInfo generation for auto return type for C++ functions.

probinson added a comment. In D70524#1772117 , @dblaikie wrote: > In D70524#1771709 , @probinson wrote: > > > In D70524#1771522 , @shafik wrote: > > > > > @probinson I was re

[PATCH] D71103: [libomptarget][nfc] Move three more files to common

JonChesterfield updated this revision to Diff 232557. JonChesterfield added a comment. - update comment Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D71103/new/ https://reviews.llvm.org/D71103 Files: openmp/libomptarget/deviceRTLs/common/src/par

[PATCH] D71110: [clangd] A tool to evaluate cross-file rename.

merge_guards_bot added a comment. Build result: pass - 60496 tests passed, 0 failed and 726 were skipped. Log files: console-log.txt , CMakeCache.txt

[PATCH] D71110: [clangd] A tool to evaluate cross-file rename.

merge_guards_bot added a comment. Build result: pass - 60496 tests passed, 0 failed and 726 were skipped. Log files: console-log.txt , CMakeCache.txt

[PATCH] D70524: Support DebugInfo generation for auto return type for C++ functions.

dblaikie added a comment. In D70524#1772690 , @probinson wrote: > In D70524#1772117 , @dblaikie wrote: > > > In D70524#1771709 , @probinson > > wrote: > > > > > In D70524#17

[PATCH] D71001: [clang-tidy] New check: bugprone-misplaced-pointer-arithmetic-in-alloc

baloghadamsoftware updated this revision to Diff 232573. baloghadamsoftware added a comment. Updated according to the comments. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D71001/new/ https://reviews.llvm.org/D71001 Files: clang-tools-extra/clang-tidy/bugprone/BugproneTidyModule.cpp

[PATCH] D71001: [clang-tidy] New check: bugprone-misplaced-pointer-arithmetic-in-alloc

baloghadamsoftware marked 5 inline comments as done. baloghadamsoftware added inline comments. Comment at: clang-tools-extra/clang-tidy/bugprone/MisplacedPointerArithmeticInAllocCheck.cpp:81-82 + diag(PtrArith->getBeginLoc(), + "pointer arithmetic is applied to the result

[PATCH] D71124: [RISCV] support clang driver to select cpu

khchen created this revision. khchen added a project: clang. Herald added subscribers: cfe-commits, luismarques, apazos, sameer.abuasal, pzheng, s.egerton, lenary, Jim, benna, psnobl, jocewei, PkmX, rkruppe, the_o, brucehoult, MartinMosbeck, rogfer01, edward-jones, zzheng, MaskRay, jrtc27, shiva

[PATCH] D71091: Make sure that the implicit arguments for direct methods have been setup

jfb added a comment. You should upload patches with context :) Comment at: clang/lib/CodeGen/CGObjCMac.cpp:4030 const ObjCContainerDecl *CD) { - auto I = DirectMethodDefinitions.find(OMD); + auto I = DirectMethodDefinitions.find(OMD->get

[PATCH] D70926: [clang-format] Add option for not breaking line before ObjC params

MyDeveloperDay requested changes to this revision. MyDeveloperDay added inline comments. This revision now requires changes to proceed. Comment at: clang/unittests/Format/FormatTest.cpp:14468 + "NSNumber *v) {\n" \ + " u = v;\n" \"

[clang] b8e03ff - [clang-format] update trailing newline treatment in clang-format.py

Author: mydeveloperday Date: 2019-12-06T17:26:02Z New Revision: b8e03ff50389d83dabf800203f689e227697c996 URL: https://github.com/llvm/llvm-project/commit/b8e03ff50389d83dabf800203f689e227697c996 DIFF: https://github.com/llvm/llvm-project/commit/b8e03ff50389d83dabf800203f689e227697c996.diff LOG

[PATCH] D70864: [clang-format] update trailing newline treatment in clang-format.py

This revision was automatically updated to reflect the committed changes. Closed by commit rGb8e03ff50389: [clang-format] update trailing newline treatment in clang-format.py (authored by MyDeveloperDay). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/

[clang] 79f8c20 - update string comparison in clang-format.py

Author: mydeveloperday Date: 2019-12-06T17:36:56Z New Revision: 79f8c20e2cb634c1b8e42f01b42fc5ab2a512d60 URL: https://github.com/llvm/llvm-project/commit/79f8c20e2cb634c1b8e42f01b42fc5ab2a512d60 DIFF: https://github.com/llvm/llvm-project/commit/79f8c20e2cb634c1b8e42f01b42fc5ab2a512d60.diff LOG

[PATCH] D70664: [clang-format] update string comparison in clang-format.py

This revision was automatically updated to reflect the committed changes. Closed by commit rG79f8c20e2cb6: update string comparison in clang-format.py (authored by MyDeveloperDay). Changed prior to commit: https://reviews.llvm.org/D70664?vs=230873&id=232591#toc Repository: rG LLVM Github Mon

[PATCH] D71080: [NFC] Separate getLastArgIntValue to Basic

yaxunl updated this revision to Diff 232592. yaxunl marked 4 inline comments as done. yaxunl added a comment. revised by Artem's comments. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D71080/new/ https://reviews.llvm.org/D71080 Files: clang/include/clang/Basic/OptionUtils.h clang/i

[PATCH] D71091: Make sure that the implicit arguments for direct methods have been setup

arphaman accepted this revision. arphaman added a comment. This revision is now accepted and ready to land. LGTM, after fixing JF's comments. Please upload patches with full context as JF mentioned, as it helps with the review. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D71091/new/ h

[PATCH] D71080: [NFC] Separate getLastArgIntValue to Basic

yaxunl added inline comments. Comment at: clang/lib/Basic/OptionUtils.cpp:18 +template +static IntTy getLastArgIntValueImpl(const ArgList &Args, OptSpecifier Id, +IntTy Default, DiagnosticsEngine *Diags) { tra wrote: > I'd use

[PATCH] D70524: Support DebugInfo generation for auto return type for C++ functions.

probinson added a comment. > Perhaps we should implement this mode under -fno-standalone-debug (or > something more aggressive) since "standalone" is one of the only places I can > think of where having the full class definition would be handy You'd also want it for type units, so they deduplic

[clang] 164e0fc - [ASTImporter] Implicitly declare parameters for imported ObjCMethodDecls

Author: Raphael Isemann Date: 2019-12-06T18:50:32+01:00 New Revision: 164e0fc5c7f782b174db5c87b37725ea0e174853 URL: https://github.com/llvm/llvm-project/commit/164e0fc5c7f782b174db5c87b37725ea0e174853 DIFF: https://github.com/llvm/llvm-project/commit/164e0fc5c7f782b174db5c87b37725ea0e174853.dif

[PATCH] D71112: [ASTImporter] Implicitly declare parameters for imported ObjCMethodDecls

This revision was automatically updated to reflect the committed changes. Closed by commit rG164e0fc5c7f7: [ASTImporter] Implicitly declare parameters for imported ObjCMethodDecls (authored by teemperor). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/

[PATCH] D71065: [ARM][MVE] Add intrinsics for immediate shifts.

MarkMurrayARM accepted this revision. MarkMurrayARM added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D71065/new/ https://reviews.llvm.org/D71065 _

[PATCH] D70524: Support DebugInfo generation for auto return type for C++ functions.

dblaikie added a comment. In D70524#1772961 , @probinson wrote: > > Perhaps we should implement this mode under -fno-standalone-debug (or > > something more aggressive) since "standalone" is one of the only places I > > can think of where having the full

[PATCH] D71091: Make sure that the implicit arguments for direct methods have been setup

MadCoder updated this revision to Diff 232602. MadCoder marked 2 inline comments as done. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D71091/new/ https://reviews.llvm.org/D71091 Files: clang/lib/CodeGen/CGObjCMac.cpp clang/lib/Sema/SemaDeclObjC.cpp clang/test/CodeGenObjC/direct-me

[clang] f2ace9d - Add `QualType::hasAddressSpace`. NFC.

Author: Michael Liao Date: 2019-12-06T13:08:55-05:00 New Revision: f2ace9d6005b4ffc6f6fc068c1aac897d871df7a URL: https://github.com/llvm/llvm-project/commit/f2ace9d6005b4ffc6f6fc068c1aac897d871df7a DIFF: https://github.com/llvm/llvm-project/commit/f2ace9d6005b4ffc6f6fc068c1aac897d871df7a.diff

[PATCH] D71005: [AST] Enable expression of OpenCL language address spaces an attribute

bader added a comment. @aaron.ballman, thank you for fixing the problem with documentation generation. With regards to attributes naming question, let me check if I get it right. 1. You suggest checking with Khronos if they want to adopt `[[opencl::private]]` attribute names in OpenCL kernel la

[PATCH] D71091: Make sure that the implicit arguments for direct methods have been setup

MadCoder added a comment. just added all the context this time (-W) Comment at: clang/lib/CodeGen/CGObjCMac.cpp:4030 const ObjCContainerDecl *CD) { - auto I = DirectMethodDefinitions.find(OMD); + auto I = DirectMethodDefinitions.find(OMD

[PATCH] D70553: [clang-apply-replacements] Add command line option to overwrite readonly files.

zturner added a comment. In D70553#1757862 , @aaron.ballman wrote: > Can you add a test case for this functionality? The reason there's no test case is because it seems like that wouldn't really be any different than testing the functionality of `llvm:

[PATCH] D71091: Make sure that the implicit arguments for direct methods have been setup

liuliu added a comment. With this latest fix applied on top of b220662a45c8067a2ae485ae34c1138d93506df9 , in our company's internal code, I still encounter the crash. Showing All Messages /Users/liuliu/Snapchat/Dev/phantom

[PATCH] D70973: [OPENMP50]Treat context selectors as expressions, not just strings.

ABataev added a comment. Ping! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D70973/new/ https://reviews.llvm.org/D70973 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cg

[clang] 543ffb4 - [OPENMP]Reorganize OpenMP warning groups.

Author: Alexey Bataev Date: 2019-12-06T13:31:02-05:00 New Revision: 543ffb4a2d6435004f7e41f2b3d9040aeb3e78ef URL: https://github.com/llvm/llvm-project/commit/543ffb4a2d6435004f7e41f2b3d9040aeb3e78ef DIFF: https://github.com/llvm/llvm-project/commit/543ffb4a2d6435004f7e41f2b3d9040aeb3e78ef.diff

[clang] 2cc1194 - clang/AMDGPU: Fix default for frame-pointer attribute

Author: Matt Arsenault Date: 2019-12-07T00:09:10+05:30 New Revision: 2cc11941a2e88236e0b4842229454ae6d85142cd URL: https://github.com/llvm/llvm-project/commit/2cc11941a2e88236e0b4842229454ae6d85142cd DIFF: https://github.com/llvm/llvm-project/commit/2cc11941a2e88236e0b4842229454ae6d85142cd.diff

[PATCH] D70424: clang/AMDGPU: Fix default for frame-pointer attribute

arsenm accepted this revision. arsenm added a comment. This revision is now accepted and ready to land. 2cc11941a2e88236e0b4842229454ae6d85142cd CHANGES SINCE LAST ACTION https://reviews.llvm.org/D70424/new/ https://review

[PATCH] D71133: [OpenCL] Add ExtVectorElementExpr constant evaluation (PR42387)

svenvh created this revision. svenvh added a reviewer: Anastasia. Herald added a subscriber: yaxunl. Add constexpr evaluation for ExtVectorElementExpr nodes by evaluating the underlying vector expression. Add basic folding too, for the case that Evaluate does not return an LValue. https://revie

[PATCH] D71134: [OpenMP] Require trivially copyable type for mapping

Hahnfeld created this revision. Hahnfeld added reviewers: ABataev, jdoerfert. Herald added subscribers: cfe-commits, guansong. Herald added a project: clang. A trivially copyable type provides a trivial copy constructor and a trivial copy assignment operator. This is enough for the runtime to memc

[PATCH] D71080: [NFC] Separate getLastArgIntValue to Basic

tra added inline comments. Comment at: clang/include/clang/Basic/OptionUtils.h:24 + +class ArgList; + What are the rules on using LLVM headers here? Can we just include llvm/Option/ArgList.h instead? Comment at: clang/include/clang/Basic/Optio

[PATCH] D71134: [OpenMP] Require trivially copyable type for mapping

ABataev added inline comments. Comment at: clang/lib/Sema/SemaOpenMP.cpp:14917 if (FullCheck && !SemaRef.CurContext->isDependentContext() && - !QTy.isTrivialType(SemaRef.Context)) + !QTy.isTriviallyCopyableType(SemaRef.Context)) SemaRef.Diag(SL, diag::warn_omp_n

[PATCH] D70849: [AST] Traverse the class type loc inside the member pointer type loc.

rnk added a comment. We also hit this, and I have a repro here, but it depends on the Chromium Blink GC plugin: https://bugs.chromium.org/p/chromium/issues/detail?id=1031274#c4 I think you just need an RAV client that walks over some particular AST node to trigger the assert. I assume there is n

[PATCH] D70157: Align branches within 32-Byte boundary

reames added a comment. Recording something so I don't forget it when we get back to the prefix padding version. The write up on the bundle align mode stuff mentions a concerning memory overhead for the feature. Since the basic implementation techniques are similar, we need to make sure we as

[PATCH] D49091: Warn about usage of __has_include/__has_include_next in macro expansions

torarnv added a comment. I'm picking this up on the Qt side and removing our wrapper macro. Does this apply to other cases as well? The standard mentions `_­_­has_­cpp_­attribute`, but what about `__has_builtin`, `__has_attribute`, and `__has_include_next`? Repository: rC Clang CHANGES SIN

[clang] dbd1129 - Stop checking whether std::strong_* has ::equivalent members.

Author: Richard Smith Date: 2019-12-06T11:35:41-08:00 New Revision: dbd112972416f48f7e5b117e7a14b6e4b4d38146 URL: https://github.com/llvm/llvm-project/commit/dbd112972416f48f7e5b117e7a14b6e4b4d38146 DIFF: https://github.com/llvm/llvm-project/commit/dbd112972416f48f7e5b117e7a14b6e4b4d38146.diff

[PATCH] D71091: Make sure that the implicit arguments for direct methods have been setup

arphaman requested changes to this revision. arphaman added a comment. This revision now requires changes to proceed. @MadCoder unfortunately this change causes several test failures when `check-clang` runs: Clang :: Analysis/analyzeOneFunction.m Clang :: Index/c-index-api-loadTU-test.m Cl

[PATCH] D71091: Make sure that the implicit arguments for direct methods have been setup

MadCoder added a comment. In D71091#1773066 , @liuliu wrote: > With this latest fix applied on top of > b220662a45c8067a2ae485ae34c1138d93506df9 > , in our > company's internal code, I

[PATCH] D70804: [Frontend] Allow OpenMP offloading to aarch64

bryanpkc marked 6 inline comments as done. bryanpkc added inline comments. Comment at: clang/test/OpenMP/openmp_offload_registration.cpp:3-5 +// RUN: %clang_cc1 -verify -fopenmp -x c -triple x86_64-unknown-linux-gnu -fopenmp-targets=aarch64-unknown-linux-gnu,powerpc64-ibm-linux-

[PATCH] D71139: [Wdocumentation] Use the command marker

Mordante created this revision. Mordante added a reviewer: gribozavr2. Mordante added a project: clang. Use the proper marker for `-Wdocumentation-deprecated-sync` instead of hard-coded the backslash. Discovered while looking at https://bugs.llvm.org/show_bug.cgi?id=43753 Repository: rG LLVM

[PATCH] D71140: [Wdocumentation] Properly place deprecated attribute

Mordante created this revision. Mordante added a reviewer: gribozavr2. Mordante added a project: clang. It is now placed before the function: - allows to replace `__attribute__((deprecated))` with `[[deprecated]]`. - required for trailing returns. Fixes bug: https://bugs.llvm.org/show_bug.cgi?id

[PATCH] D71141: [Wdocumentation] Use C++14 deprecated attribute

Mordante created this revision. Mordante added a reviewer: gribozavr2. Mordante added a project: clang. This replaces the non-standard `__attribute__((deprecated))` with the standard `[[deprecated]]` when compiling in C++14 mode. Discovered while looking at https://bugs.llvm.org/show_bug.cgi?id=

[PATCH] D71091: Make sure that the implicit arguments for direct methods have been setup

liuliu marked an inline comment as done. liuliu added inline comments. Comment at: clang/lib/Sema/SemaDeclObjC.cpp:4839 + ObjCMethod->createImplicitParams(Context, ObjCMethod->getClassInterface()); + Yeah, I applied this change. As I said, for my trivial examp

[PATCH] D71134: [OpenMP] Require trivially copyable type for mapping

Hahnfeld marked 2 inline comments as done. Hahnfeld added inline comments. Comment at: clang/lib/Sema/SemaOpenMP.cpp:14917 if (FullCheck && !SemaRef.CurContext->isDependentContext() && - !QTy.isTrivialType(SemaRef.Context)) + !QTy.isTriviallyCopyableType(SemaRef.Cont

[PATCH] D71141: [Wdocumentation] Use C++14 deprecated attribute

aaron.ballman added inline comments. Comment at: clang/lib/AST/CommentSema.cpp:693 +StringRef AttributeSpelling = +CPlusPlus14 ? "[[deprecated]]" : "__attribute__((deprecated))"; if (PP) { This attribute also exists with this spelling in C2x, FWI

[PATCH] D71134: [OpenMP] Require trivially copyable type for mapping

ABataev accepted this revision. ABataev added a comment. This revision is now accepted and ready to land. LG Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D71134/new/ https://reviews.llvm.org/D71134 ___

[PATCH] D70804: [Frontend] Allow OpenMP offloading to aarch64

bryanpkc updated this revision to Diff 232627. bryanpkc marked 2 inline comments as done. bryanpkc added a comment. Removed unrelated changes from this patch. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D70804/new/ https://reviews.llvm.org/D70804

[clang] 779a180 - [OPENMP50]Add if clause in distribute simd directive.

Author: Alexey Bataev Date: 2019-12-06T14:49:49-05:00 New Revision: 779a180d964bf362f26f4c493db749cbbae550c5 URL: https://github.com/llvm/llvm-project/commit/779a180d964bf362f26f4c493db749cbbae550c5 DIFF: https://github.com/llvm/llvm-project/commit/779a180d964bf362f26f4c493db749cbbae550c5.diff

[PATCH] D71142: [Sema] Validate large bitfields

Mordante created this revision. Mordante added reviewers: rsmith, majnemer, aaron.ballman. Mordante added a project: clang. Note: I'm not entirely happy with the text of the diagnostics and I'm open to suggestions. Fixes PR23505: Large bitfield: Assertion `getActiveBits() <= 64 && "Too many bit

[PATCH] D71082: Allow system header to provide their own implementation of some builtin

efriedma added a comment. It looks like this patch accidentally suppresses certain warnings when _FORTIFY_SOURCE is enabled. For example, Sema::CheckMemaccessArguments only gets called for recognized builtin functions. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https:/

[PATCH] D71141: [Wdocumentation] Use C++14 deprecated attribute

Mordante marked an inline comment as done. Mordante added inline comments. Comment at: clang/lib/AST/CommentSema.cpp:693 +StringRef AttributeSpelling = +CPlusPlus14 ? "[[deprecated]]" : "__attribute__((deprecated))"; if (PP) { aaron.ballman wrote

[PATCH] D71091: Make sure that the implicit arguments for direct methods have been setup

MadCoder marked an inline comment as done. MadCoder added inline comments. Comment at: clang/lib/Sema/SemaDeclObjC.cpp:4839 + ObjCMethod->createImplicitParams(Context, ObjCMethod->getClassInterface()); + liuliu wrote: > Yeah, I applied this change. As I said,

[clang-tools-extra] a7bdab2 - [clang-tidy] Pass -faligned-allocation on the compiler command line to

Author: Akira Hatanaka Date: 2019-12-06T12:29:21-08:00 New Revision: a7bdab2e9d59ba0fdf06390f4ddadfd00fe50f2e URL: https://github.com/llvm/llvm-project/commit/a7bdab2e9d59ba0fdf06390f4ddadfd00fe50f2e DIFF: https://github.com/llvm/llvm-project/commit/a7bdab2e9d59ba0fdf06390f4ddadfd00fe50f2e.diff

[PATCH] D70973: [OPENMP50]Treat context selectors as expressions, not just strings.

jdoerfert added inline comments. Comment at: clang/include/clang/Basic/DiagnosticParseKinds.td:1230 - "unknown '%0' device kind trait in the 'device' context selector set, expected" - " one of 'host', 'nohost', 'cpu', 'gpu' or 'fpga'">; ABataev wrote: > jdoe

[PATCH] D71005: [AST] Enable expression of OpenCL language address spaces an attribute

aaron.ballman added a comment. In D71005#1773042 , @bader wrote: > @aaron.ballman, thank you for fixing the problem with documentation > generation. No problem! > With regards to attributes naming question, let me check if I get it right. > > 1. You s

[PATCH] D71141: [Wdocumentation] Use C++14 deprecated attribute

aaron.ballman added inline comments. Comment at: clang/lib/AST/CommentSema.cpp:693 +StringRef AttributeSpelling = +CPlusPlus14 ? "[[deprecated]]" : "__attribute__((deprecated))"; if (PP) { Mordante wrote: > aaron.ballman wrote: > > This attribute

[PATCH] D71049: Remove implicit conversion that promotes half to other larger precision types for fp classification builtins

aaron.ballman added a comment. Thank you for the patch -- can you add some test cases? Comment at: clang/lib/Sema/SemaChecking.cpp:5835-5836 +"is the only expected cast here"); +Cast->setSubExpr(nullptr); +TheCall->setArg(NumArgs-1, CastArg); +

[PATCH] D70973: [OPENMP50]Treat context selectors as expressions, not just strings.

ABataev marked an inline comment as done. ABataev added inline comments. Comment at: clang/include/clang/Basic/DiagnosticParseKinds.td:1230 - "unknown '%0' device kind trait in the 'device' context selector set, expected" - " one of 'host', 'nohost', 'cpu', 'gpu' or 'fpga'">;

  1   2   >