aaron.ballman added a comment.
Thank you for the patch -- can you add some test cases?
================
Comment at: clang/lib/Sema/SemaChecking.cpp:5835-5836
+ "is the only expected cast here");
+ Cast->setSubExpr(nullptr);
+ TheCall->setArg(NumArgs-1, CastArg);
+ }
----------------
I think this should be combined with the code above. Something like:
```
bool IgnoreCast = false;
if (CastArg-> is Float) {
assert(stuff);
IgnoreCast = true;
} else if (CastArg-> is Half) {
assert(stuff);
IgnoreCast = true;
}
if (IgnoreCast) {
Cast->setSubExpr(nullptr);
TheCall->setArg(NumArgs - 1, CastArg);
}
```
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D71049/new/
https://reviews.llvm.org/D71049
_______________________________________________
cfe-commits mailing list
[email protected]
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
