[PATCH] D69876: Allow output constraints on "asm goto"

void updated this revision to Diff 228595. void added a comment. Adjust the ASM so that it references labels. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D69876/new/ https://reviews.llvm.org/D69876 Files: clang/include/clang/AST/Stmt.h clang/

[PATCH] D69922: [OpenMP] Use the OpenMP-IR-Builder

JonChesterfield added inline comments. Comment at: clang/test/OpenMP/barrier_codegen.cpp:22 +// CLANGCG-NOT: readonly +// IRBUILDER: ; Function Attrs: nofree nosync nounwind readonly +// IRBUILDER-NEXT: declare i32 @__kmpc_global_thread_num(%struct.ident_t*)

[clang] 6c94068 - [Driver] Remove unused variable. NFC.

Author: Benjamin Kramer Date: 2019-11-10T12:53:19+01:00 New Revision: 6c94068da99ae694a14f2484a2c9ac74a22bf61a URL: https://github.com/llvm/llvm-project/commit/6c94068da99ae694a14f2484a2c9ac74a22bf61a DIFF: https://github.com/llvm/llvm-project/commit/6c94068da99ae694a14f2484a2c9ac74a22bf61a.dif

[PATCH] D70052: [clang-tidy] Add misc-mutating-copy check

gbencze created this revision. gbencze added reviewers: aaron.ballman, alexfh, JonasToth, Charusso. gbencze added a project: clang-tools-extra. Herald added subscribers: cfe-commits, mgehre, xazax.hun, mgorny. Herald added a project: clang. The check warns when (a member of) the copied object is a

[PATCH] D70052: [clang-tidy] Add misc-mutating-copy check

mgehre added a comment. Have you run your check over the LLVM/clang source base and seen true positives/false positives? Comment at: clang-tools-extra/docs/clang-tidy/checks/misc-mutating-copy.rst:6 + +Finds assignments to and to direct or indirect members of the copied object

[PATCH] D69935: [DeclCXX] Remove unknown external linkage specifications

rsmith added inline comments. Comment at: clang/include/clang/AST/DeclCXX.h:2762 /// ensure a stable ABI for this, we choose the DW_LANG_ encodings /// from the dwarf standard. enum LanguageIDs { Using DWARF encodings here does nothing for AST format sta

[PATCH] D70052: [clang-tidy] Add misc-mutating-copy check

gbencze added a comment. In D70052#1740075 , @mgehre wrote: > Have you run your check over the LLVM/clang source base and seen true > positives/false positives? I tested it on the Xerces and Bitcoin codebases and did not get any warnings. Repository:

[PATCH] D67545: [clang-tidy] Added DefaultOperatorNewCheck.

lebedev.ri added a comment. Land this? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D67545/new/ https://reviews.llvm.org/D67545 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llv

[PATCH] D70048: [LLD] Add NetBSD support as a new flavor of LLD (nb.lld)

krytarowski added a comment. Short summary: - FreeBSD/OpenBSD ship with mutations of the behavior of ELF/GNU/Linux in certain nits, we do the same with our driver. - MinGW ships with a frontend driver to COFF, we do the same with a driver to ELF/GNU/Linux. - Darwin ships with default search pat

[PATCH] D70052: [clang-tidy] Add misc-mutating-copy check

mgehre added a comment. Did you consider to warn on copy constructors/assignment operators take a their arguments by non-`const` reference, and suggest the user to turn them into const references? This seems like a more useful (and easier) check to me. The link above contains `Ideally, the copy

[clang] 8e9e433 - clang/Modules: Remove unused parameter from ModuleManager::removeModules

Author: Duncan P. N. Exon Smith Date: 2019-11-10T11:18:33-08:00 New Revision: 8e9e433a2af7c435923ba71ea7d75374408b0b32 URL: https://github.com/llvm/llvm-project/commit/8e9e433a2af7c435923ba71ea7d75374408b0b32 DIFF: https://github.com/llvm/llvm-project/commit/8e9e433a2af7c435923ba71ea7d75374408b

[PATCH] D70056: clang/Modules: Split loop in ReadAST between failable and not

dexonsmith created this revision. dexonsmith added reviewers: aprantl, bruno, Bigcheese. Herald added a subscriber: ributzka. Split a loop in ReadAST that visits the just-loaded module chain, between an initial loop that reads further from the ASTs (and can fail) and a second loop that does some p

[PATCH] D70058: clang/Modules: Delay err_module_file_conflict if a diagnostic is in flight

dexonsmith created this revision. dexonsmith added reviewers: aprantl, bruno, Bigcheese. Herald added a subscriber: ributzka. As part of an audit of whether all errors are being reported from the ASTReader, delay err_module_file_conflict if a diagnostic is already in flight when it is hit. This r

[PATCH] D70055: clang/Modules: Clean up modules on error in ReadAST

dexonsmith created this revision. dexonsmith added reviewers: bruno, aprantl, Bigcheese. Herald added a subscriber: ributzka. ReadASTBlock and ReadASTExtensions can both return failures. Be consistent and remove all the just-loaded modules, just like when ReadASTCore returns failures. https://r

[PATCH] D70058: clang/Modules: Delay err_module_file_conflict if a diagnostic is in flight

dexonsmith updated this revision to Diff 228618. dexonsmith added a comment. Updated header docs for the new delayed diagnostic parameter. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D70058/new/ https://reviews.llvm.org/D70058 Files: clang/include/clang/Basic/Diagnostic.h clang/in

[PATCH] D70057: clang/Modules: Add missing diagnostics for malformed AST files

dexonsmith created this revision. dexonsmith added reviewers: aprantl, bruno, Bigcheese. Herald added a subscriber: ributzka. These were found via an audit. In the case of `ParseLineTable` this is actually dead code, since parsing the line table always succeeds, but it's prudent to be defensive s

[PATCH] D70052: [clang-tidy] Add misc-mutating-copy check

gbencze added a comment. In D70052#1740142 , @mgehre wrote: > Did you consider to warn on copy constructors/assignment operators take a > their arguments by non-`const` reference, and suggest the user to turn them > into const references? This seems like

[PATCH] D70063: clang/Modules: Error if ReadASTBlock does not find the main module

dexonsmith created this revision. dexonsmith added reviewers: aprantl, bruno, Bigcheese. Herald added a subscriber: ributzka. dexonsmith added parent revisions: D70055: clang/Modules: Clean up modules on error in ReadAST, D70056: clang/Modules: Split loop in ReadAST between failable and not, D700

[PATCH] D70063: clang/Modules: Error if ReadASTBlock does not find the main module

dexonsmith updated this revision to Diff 228626. dexonsmith added a comment. Updated to use a new diagnostic (`err_module_file_missing_definition`) that includes the filename of the PCM. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D70063/new/ https://reviews.llvm.org/D70063 Files:

[PATCH] D70052: [clang-tidy] Add misc-mutating-copy check

Eugene.Zelenko added a comment. If this is CERT rule, why check is not placed in relevant module? Comment at: clang-tools-extra/docs/ReleaseNotes.rst:126 + + Finds copy operations that mutate the source object. + Please synchronize with first statement in docu

[PATCH] D69876: Allow output constraints on "asm goto"

jyknight added a comment. I think -Wuninitialized (UninitializedValues.cpp) should be taught how to detect the use of output variables in error blocks, at least for trivial cases. Actually, for some reason -- it looks like the warning is failing the wrong way right now, and emits an uninitializ

[PATCH] D69876: Allow output constraints on "asm goto"

void marked an inline comment as done. void added a comment. This change is ready for review. PTAL. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D69876/new/ https://reviews.llvm.org/D69876 ___ cfe-comm

[PATCH] D69876: Allow output constraints on "asm goto"

jyknight added a comment. Also, since this means we are no longer simply implementing according to GCC's documentation, I think this means we'll need a brand new section in the Clang docs for its inline-asm support. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://rev

[PATCH] D69979: clang: Guess at some platform FTZ/DAZ default settings

arsenm added a comment. In D69979#1738723 , @spatel wrote: > Also, I may have missed some discussions. Does this patch series replace the > proposal to add instruction-level FMF for denorms? > http://lists.llvm.org/pipermail/llvm-dev/2019-September/13518

[PATCH] D69979: clang: Guess at some platform FTZ/DAZ default settings

arsenm added a comment. In D69979#1738099 , @craig.topper wrote: > I checked Redhat 7.4 that's on the server I'm using for work. And I had a > coworker check his Ubuntu 18.04 system with this program. And both systems > printed 1f80 as the value of MXCS

[clang-tools-extra] b4f46a9 - [clangd] Fixes colon escaping on Windows

Author: Ilya Biryukov Date: 2019-11-11T09:21:25+01:00 New Revision: b4f46a9bb42972e663f8b7b4d15e4c8ed3fecef4 URL: https://github.com/llvm/llvm-project/commit/b4f46a9bb42972e663f8b7b4d15e4c8ed3fecef4 DIFF: https://github.com/llvm/llvm-project/commit/b4f46a9bb42972e663f8b7b4d15e4c8ed3fecef4.diff

[PATCH] D69996: [clangd] Fixes colon escaping on Windows

ilya-biryukov closed this revision. ilya-biryukov added a comment. Sorry for the delay, forgot to submit on Friday. Also updated `package-lock.json` before submitting. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D69996/new/ https://reviews.llvm.org/D69996 ___

[PATCH] D69996: [clangd] Fixes colon escaping on Windows

hokein added a comment. I believe this patch fixes the issue, but we need to update the file `test/semantic-highlighting.test.ts`), the test "Colorizer groups decorations correctly" is diverged from the actual code, although it is still passed (both `string` and `vscode.Uri` have the `toString

[PATCH] D69961: [clangd] Fix a regression of not showing documentation from forward declarations.

hokein updated this revision to Diff 228648. hokein marked an inline comment as done. hokein added a comment. test union and struct kinds. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D69961/new/ https://reviews.llvm.org/D69961 Files: clang-tool

[PATCH] D69961: [clangd] Fix a regression of not showing documentation from forward declarations.

This revision was automatically updated to reflect the committed changes. Closed by commit rG41104a9406dd: [clangd] Fix a regression of not showing documentation from forward… (authored by hokein). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D69961/

[clang] b1ac1f0 - Revert cdcf58e5af0 "[RISCV] enable LTO support, pass some options to linker."

Author: Hans Wennborg Date: 2019-11-11T10:58:39+01:00 New Revision: b1ac1f0071626e5cf7f2847484b5b7595253a295 URL: https://github.com/llvm/llvm-project/commit/b1ac1f0071626e5cf7f2847484b5b7595253a295 DIFF: https://github.com/llvm/llvm-project/commit/b1ac1f0071626e5cf7f2847484b5b7595253a295.diff

[clang-tools-extra] 41104a9 - [clangd] Fix a regression of not showing documentation from forward declarations.

Author: Haojian Wu Date: 2019-11-11T10:46:52+01:00 New Revision: 41104a9406dd284d984f7bee30c7756fcfe2b59e URL: https://github.com/llvm/llvm-project/commit/41104a9406dd284d984f7bee30c7756fcfe2b59e DIFF: https://github.com/llvm/llvm-project/commit/41104a9406dd284d984f7bee30c7756fcfe2b59e.diff LO

[PATCH] D67409: [RISCV] enable LTO support, pass some options to linker.

hans added a comment. I've reverted in b1ac1f00716 until it can be fixed properly. We noticed this in Chromium where we started seeing build spam like: '+soft-float-abi' is not a recognized feature for this target (ignoring

[PATCH] D69961: [clangd] Fix a regression of not showing documentation from forward declarations.

merge_guards_bot added a comment. Build result: pass - 59966 tests passed, 0 failed and 763 were skipped. Log files: console-log.txt , CMakeCache.txt

[PATCH] D70008: [clangd] Store xref for Macros in ParsedAST.

hokein added inline comments. Comment at: clang-tools-extra/clangd/CollectMacros.h:29 std::vector Ranges; + llvm::DenseMap> MacroRefs; }; I think the `Ranges` and `MacrosRefs` have a lot of duplications, it is wasteful to store a same range twice. We don't

[PATCH] D70071: [ConstExprPreter] Removed the flag forcing the use of the interpreter

nand created this revision. nand added reviewers: jfb, Bigcheese, rsmith, dexonsmith. Herald added a project: clang. Herald added a subscriber: cfe-commits. nand edited the summary of this revision. Removed the `-fforce-experimental-new-constant-interpreter flag`, leaving only the `-fexperimental-

[clang-tools-extra] 02ec6ff - [clangd] Use name of Macro to compute its SymbolID, NFC.

Author: Utkarsh Saxena Date: 2019-11-11T12:38:49+01:00 New Revision: 02ec6ff77eb718528138737c885e67c248ecae49 URL: https://github.com/llvm/llvm-project/commit/02ec6ff77eb718528138737c885e67c248ecae49 DIFF: https://github.com/llvm/llvm-project/commit/02ec6ff77eb718528138737c885e67c248ecae49.diff

[PATCH] D69707: [AArch64][SVE] Implement additional floating-point arithmetic intrinsics

kmclaughlin updated this revision to Diff 228660. kmclaughlin added a comment. - Changed target constant to MVT::i32 in complexrotateop & complexrotateopodd definitions CHANGES SINCE LAST ACTION https://reviews.llvm.org/D69707/new/ https://reviews.llvm.org/D69707 Files: llvm/include/llvm/

[PATCH] D69573: [clang-format] [PR36294] AlwaysBreakAfterReturnType works incorrectly for some operator functions

sammccall accepted this revision. sammccall added a comment. This revision is now accepted and ready to land. Thanks, looks great! Sorry for the delay, I was out last week. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D69573/new/ https://reviews.ll

[PATCH] D68407: [WIP][RISCV] Use compiler-rt if no GCC installation detected

lenary added a comment. LGTM. I looked at what `g++` and `gcc` do (my riscv64-unknown-elf toolchain): - `gcc`: Passes `-lgcc --start-group -lc -lgloss --end-group -lgcc` to the linker - `g++`: Passes `"-lstdc++" -lm -lgcc --start-group -lc -lgloss --end-group -lgcc` to the linker This patch:

[PATCH] D69937: [clangd] Use name of Macro to compute its SymbolID.

This revision was automatically updated to reflect the committed changes. Closed by commit rG02ec6ff77eb7: [clangd] Use name of Macro to compute its SymbolID, NFC. (authored by usaxena95, committed by hokein). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm

[PATCH] D69813: [analyzer] CERTStrChecker: Model gets()

Charusso updated this revision to Diff 228675. Charusso added a comment. - The packaging have not been addressed yet. - Inject the "zombie" size expression to the new function call (`fgets`) if none of the size expression's regions have been modified. The idea is that: When we set up a variable

[PATCH] D69764: [clang-format] Add Left/Right Const (East/West , Before/After) fixer capability

sammccall added a comment. (Sorry for arriving at this late) At a strategic level, I have some concerns here: the fact that clang-format generally doesn't touch the token sequence isn't an accident. e.g. formatting `int x;;` will insert a newline rather than deleting the redundant semicolon. Li

[PATCH] D69764: [clang-format] Add Left/Right Const (East/West , Before/After) fixer capability

MyDeveloperDay added a comment. In D69764#1740582 , @sammccall wrote: > (Sorry for arriving at this late) > > At a strategic level, I have some concerns here: the fact that clang-format > generally doesn't touch the token sequence isn't an accident. > e.

[PATCH] D69921: [clang-format] refactor the use of the SMDiagnostics in replacement warnings

MyDeveloperDay marked an inline comment as done. MyDeveloperDay added inline comments. Comment at: clang/tools/clang-format/ClangFormat.cpp:304 - StringRef Line(StartBuf, (EndBuf - StartBuf) - 1); + Mgr.AddNewSourceBuffer( + MemoryBuffer::getMemBuffer(StartBu

[PATCH] D70008: [clangd] Store xref for Macros in ParsedAST.

usaxena95 added inline comments. Comment at: clang-tools-extra/clangd/XRefs.cpp:898 + // Handle macros. + if (auto Macro = locateMacroAt(Loc, AST.getPreprocessor())) { +if (auto MacroSID = getSymbolID(Macro->Name, Macro->Info, SM)) { hokein wrote: > this is

[PATCH] D70008: [clangd] Store xref for Macros in ParsedAST.

usaxena95 updated this revision to Diff 228679. usaxena95 marked an inline comment as done. usaxena95 added a comment. Rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D70008/new/ https://reviews.llvm.org/D70008 Files: clang-tools-extra/clang

[PATCH] D69764: [clang-format] Add Left/Right Const (East/West , Before/After) fixer capability

sammccall added a comment. In D69764#1740594 , @MyDeveloperDay wrote: > In D69764#1740582 , @sammccall wrote: > > > (Sorry for arriving at this late) > > > > At a strategic level, I have some concerns here: the fac

[PATCH] D70008: [clangd] Store xref for Macros in ParsedAST.

merge_guards_bot added a comment. Build result: pass - 59967 tests passed, 0 failed and 763 were skipped. Log files: console-log.txt , CMakeCache.txt

[PATCH] D70078: [clangd] fixes semantic highlighting test

lh123 created this revision. lh123 added reviewers: ilya-biryukov, hokein, sammccall. lh123 added a project: clang-tools-extra. Herald added subscribers: cfe-commits, usaxena95, kadircet, arphaman, jkorous, MaskRay. Herald added a project: clang. fixes https://github.com/clangd/clangd/issues/176

[PATCH] D69996: [clangd] Fixes colon escaping on Windows

lh123 added a comment. In D69996#1740412 , @hokein wrote: > I believe this patch fixes the issue, but we need to update the file > `test/semantic-highlighting.test.ts`), the test "Colorizer groups decorations > correctly" is diverged from the actual cod

[PATCH] D69785: [OpenMP] Introduce the OpenMP-IR-Builder

JonChesterfield added inline comments. Comment at: llvm/include/llvm/IR/OpenMPKinds.def:186 +///{ + +#ifndef OMP_IDENT_FLAG jdoerfert wrote: > Meinersbur wrote: > > jdoerfert wrote: > > > JonChesterfield wrote: > > > > Sharing constants between the compiler and t

[PATCH] D70078: [clangd] fixes semantic highlighting test

hokein accepted this revision. hokein added a comment. This revision is now accepted and ready to land. Thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D70078/new/ https://reviews.llvm.org/D70078

[PATCH] D69952: [OPENMP50]Generalize handling of context matching/scoring.

ABataev updated this revision to Diff 228690. ABataev added a comment. Address comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D69952/new/ https://reviews.llvm.org/D69952 Files: clang/include/clang/Basic/Attr.td clang/include/clang/Basic

[PATCH] D70046: [OpenMP] Use an explicit copy in a range-based for

ABataev accepted this revision. ABataev added a comment. This revision is now accepted and ready to land. LG, thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D70046/new/ https://reviews.llvm.org/D70046 __

[clang] a7638d3 - clang-format: [JS] support null operators.

Author: Martin Probst Date: 2019-11-11T16:35:35+01:00 New Revision: a7638d384983e8e3eb44a2d8c757238efc7096dc URL: https://github.com/llvm/llvm-project/commit/a7638d384983e8e3eb44a2d8c757238efc7096dc DIFF: https://github.com/llvm/llvm-project/commit/a7638d384983e8e3eb44a2d8c757238efc7096dc.diff

[PATCH] D69764: [clang-format] Add Left/Right Const (East/West , Before/After) fixer capability

MyDeveloperDay added a comment. I definitely agree with the default being "do nothing", its not just google style, nearly everyone is using a style which is derived from one of these base styles, that said turning on a const style by default would IMHO be a mistake, the level of churn could be

[clang] 6bcd8d4 - clang-format: [JS] test declared fields.

Author: Martin Probst Date: 2019-11-11T16:36:00+01:00 New Revision: 6bcd8d4a18fc0604a2297a626c1fc808cbfb7b9b URL: https://github.com/llvm/llvm-project/commit/6bcd8d4a18fc0604a2297a626c1fc808cbfb7b9b DIFF: https://github.com/llvm/llvm-project/commit/6bcd8d4a18fc0604a2297a626c1fc808cbfb7b9b.diff

[PATCH] D69972: clang-format: [JS] test declared fields.

This revision was automatically updated to reflect the committed changes. Closed by commit rG6bcd8d4a18fc: clang-format: [JS] test declared fields. (authored by mprobst). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D69972/new/ https://reviews.llvm.

[PATCH] D69971: clang-format: [JS] support null operators.

This revision was automatically updated to reflect the committed changes. Closed by commit rGa7638d384983: clang-format: [JS] support null operators. (authored by mprobst). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D69971/new/ https://reviews.llv

[clang-tools-extra] f8c17fe - [clangd] fixes semantic highlighting test

Author: Haojian Wu Date: 2019-11-11T16:47:44+01:00 New Revision: f8c17fe1112009e793d6f9a261622423c2c62049 URL: https://github.com/llvm/llvm-project/commit/f8c17fe1112009e793d6f9a261622423c2c62049 DIFF: https://github.com/llvm/llvm-project/commit/f8c17fe1112009e793d6f9a261622423c2c62049.diff LO

[PATCH] D70078: [clangd] fixes semantic highlighting test

This revision was automatically updated to reflect the committed changes. Closed by commit rGf8c17fe11120: [clangd] fixes semantic highlighting test (authored by hokein). Changed prior to commit: https://reviews.llvm.org/D70078?vs=228681&id=228697#toc Repository: rG LLVM Github Monorepo CHA

[PATCH] D69204: [OpenMP 5.0] - Extend defaultmap

ABataev added inline comments. Comment at: clang/lib/Parse/ParseOpenMP.cpp:2343-2344 +// pointer +if (Arg.back() < OMPC_DEFAULTMAP_MODIFIER_unknown) + Arg.back() = OMPC_DEFAULTMAP_MODIFIER_unknown; KLoc.push_back(Tok.getLocation()); cchen wrote:

[PATCH] D67573: Fix __atomic_is_lock_free's return type.

jyknight added a comment. Ping! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D67573/new/ https://reviews.llvm.org/D67573 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/c

[clang-tools-extra] 4edf0cb - [clang-tidy] Add bugprone-bad-signal-to-kill-thread checker and alias cert-pos44-c

Author: Abel Kocsis Date: 2019-11-11T17:26:44+01:00 New Revision: 4edf0cb0e03e31d468979d0d7dec08bd9f4f8204 URL: https://github.com/llvm/llvm-project/commit/4edf0cb0e03e31d468979d0d7dec08bd9f4f8204 DIFF: https://github.com/llvm/llvm-project/commit/4edf0cb0e03e31d468979d0d7dec08bd9f4f8204.diff L

[PATCH] D70086: [ConstExprPreter] Implemented control flow statements

nand created this revision. nand added reviewers: Bigcheese, jfb, rsmith, dexonsmith. Herald added a project: clang. Herald added a subscriber: cfe-commits. Added support for: - for - switch - do-while - while Also implemented assignment to enable useful tests. The patch also includes range-bas

[PATCH] D64305: [clangd] Add path mappings functionality

sammccall added a comment. (also welcome back and thanks for picking this up!) CHANGES SINCE LAST ACTION https://reviews.llvm.org/D64305/new/ https://reviews.llvm.org/D64305 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.ll

[PATCH] D64305: [clangd] Add path mappings functionality

sammccall added a comment. Thanks, this looks a lot better. Main thing that was unclear to me is the fact that the paths in the mappings are now URI-paths, so "/C:/foo" on windows. This looks like the right idea as it ensures much of the path-mapping code gets to ignore slashes and such. Docs/n

[clang-tools-extra] 8cec7e0 - Revert "[clang-tidy] Add bugprone-bad-signal-to-kill-thread checker and alias cert-pos44-c"

Author: Abel Kocsis Date: 2019-11-11T17:34:04+01:00 New Revision: 8cec7e0208f5b65790fd5c73b90d6d35944b07b1 URL: https://github.com/llvm/llvm-project/commit/8cec7e0208f5b65790fd5c73b90d6d35944b07b1 DIFF: https://github.com/llvm/llvm-project/commit/8cec7e0208f5b65790fd5c73b90d6d35944b07b1.diff L

[PATCH] D70087: [ConstExprPreter] String and basic pointer arithmetic.

nand created this revision. nand added reviewers: rsmith, jfb, Bigcheese, dexonsmith. Herald added a project: clang. Herald added a subscriber: cfe-commits. Implemented string constants and the following pointer operations: - AddOffset - SubOffset - Narrow - Expand - LogicalNot To allow for sens

[PATCH] D69204: [OpenMP 5.0] - Extend defaultmap

cchen marked an inline comment as done. cchen added inline comments. Comment at: clang/lib/Sema/SemaOpenMP.cpp:4476 } -if (!ImplicitMaps.empty()) { - CXXScopeSpec MapperIdScopeSpec; - DeclarationNameInfo MapperId; - if (OMPClause *Implicit = ActOnOpenMPMap

[clang-tools-extra] 8d288a0 - [clang-tidy] Add bugprone-bad-signal-to-kill-thread check and its alias cert-pos44-c

Author: Abel Kocsis Date: 2019-11-11T17:47:14+01:00 New Revision: 8d288a0668a574863d52784084ff565c89f7366e URL: https://github.com/llvm/llvm-project/commit/8d288a0668a574863d52784084ff565c89f7366e DIFF: https://github.com/llvm/llvm-project/commit/8d288a0668a574863d52784084ff565c89f7366e.diff L

[PATCH] D68682: Clang-tidy fix removals removing all non-blank text from a line should remove the line

gribozavr2 added inline comments. Comment at: clang/include/clang/AST/CommentLexer.h:25 + +/// Requires that BufferPtr point to a newline character (/n or /r). +/// Returns a pointer past the end of any platform newline, i.e. past "\n" and "\r" (everywhere) ===

[PATCH] D69238: Fix clang-tidy readability-redundant-string-init for c++17/c++2a

gribozavr2 accepted this revision. gribozavr2 added a comment. This revision is now accepted and ready to land. Thanks! Do you have commit access or do you need me to commit for you? Repository: rCTE Clang Tools Extra CHANGES SINCE LAST ACTION https://reviews.llvm.org/D69238/new/ https://r

[PATCH] D69548: Give clang-tidy readability-redundant-string-init a customizable list of string types to fix

Eugene.Zelenko added inline comments. Comment at: clang-tools-extra/docs/clang-tidy/checks/readability-redundant-string-init.rst:30 +Semicolon-delimited list of base class names to apply this check to. +By default `::std::basic_string` applies to std::string and std::wst

[PATCH] D69548: Give clang-tidy readability-redundant-string-init a customizable list of string types to fix

gribozavr2 accepted this revision. gribozavr2 added inline comments. This revision is now accepted and ready to land. Comment at: clang-tools-extra/docs/clang-tidy/checks/readability-redundant-string-init.rst:29 + +Semicolon-delimited list of base class names to apply this c

[clang-tools-extra] b6cd799 - Fix filename typo in rG8d288a0668a5

Author: Simon Pilgrim Date: 2019-11-11T17:23:21Z New Revision: b6cd799e29a9a5cef4d1d722f267e3b59ef6aaca URL: https://github.com/llvm/llvm-project/commit/b6cd799e29a9a5cef4d1d722f267e3b59ef6aaca DIFF: https://github.com/llvm/llvm-project/commit/b6cd799e29a9a5cef4d1d722f267e3b59ef6aaca.diff LOG:

[PATCH] D69204: [OpenMP 5.0] - Extend defaultmap

ABataev added inline comments. Comment at: clang/lib/Sema/SemaOpenMP.cpp:4476 } -if (!ImplicitMaps.empty()) { - CXXScopeSpec MapperIdScopeSpec; - DeclarationNameInfo MapperId; - if (OMPClause *Implicit = ActOnOpenMPMapClause( - llvm::None, llv

[clang-tools-extra] 489449c - [libTooling] Further simplify `Stencil` type and introduce `MatchComputation`.

Author: Yitzhak Mandelbaum Date: 2019-11-11T12:44:15-05:00 New Revision: 489449c28aaa45086d507fbad96826420adf409d URL: https://github.com/llvm/llvm-project/commit/489449c28aaa45086d507fbad96826420adf409d DIFF: https://github.com/llvm/llvm-project/commit/489449c28aaa45086d507fbad96826420adf409d.

[PATCH] D69802: [libTooling] Further simplify `Stencil` type and introduce `MatchComputation`.

ymandel updated this revision to Diff 228720. ymandel added a comment. syntax fixes (to compile) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D69802/new/ https://reviews.llvm.org/D69802 Files: clang-tools-extra/clang-tidy/utils/TransformerClangT

[PATCH] D69802: [libTooling] Further simplify `Stencil` type and introduce `MatchComputation`.

This revision was automatically updated to reflect the committed changes. Closed by commit rG489449c28aaa: [libTooling] Further simplify `Stencil` type and introduce `MatchComputation`. (authored by ymandel). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.

[clang-tools-extra] b9213df - [clangd] Fix crash in DefineInline::prepare()

Author: Sam McCall Date: 2019-11-11T19:01:06+01:00 New Revision: b9213dfec4d8ce42d90507c25545564f4a0bbfb8 URL: https://github.com/llvm/llvm-project/commit/b9213dfec4d8ce42d90507c25545564f4a0bbfb8 DIFF: https://github.com/llvm/llvm-project/commit/b9213dfec4d8ce42d90507c25545564f4a0bbfb8.diff LO

[PATCH] D69383: [RISCV] Match GCC `-march`/`-mabi` driver defaults

lenary added a comment. I think this is just about ready to land, given our discussion on the RISC-V call on 7 November 2019. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D69383/new/ https://reviews.llvm.org/D69383 _

[PATCH] D69383: [RISCV] Match GCC `-march`/`-mabi` driver defaults

lenary updated this revision to Diff 228728. lenary added a comment. - Rebase - Update comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D69383/new/ https://reviews.llvm.org/D69383 Files: clang/docs/ReleaseNotes.rst clang/lib/Driver/ToolCh

[PATCH] D69938: [OpenCL] Use __generic addr space when generating internal representation of lambda

Anastasia marked an inline comment as done. Anastasia added a comment. In D69938#1737196 , @rjmccall wrote: > It does make logical sense to be able to qualify the call operator of a > lambda. The lambda always starts as a temporary, so presumably we want

[PATCH] D70094: [clang-tidy] new altera ID dependent backward branch check

ffrankies created this revision. ffrankies added reviewers: alexfh, jdoerfert, hokein, aaron.ballman. ffrankies added projects: clang-tools-extra, clang, LLVM. Herald added subscribers: mgehre, arphaman, xazax.hun, Anastasia, mgorny. This lint check is a part of the FLOCL (FPGA Linters for OpenCL)

[PATCH] D69825: [Clang][Driver] Bypass cc1 process and re-enter driver main

aganea updated this revision to Diff 228729. aganea marked 2 inline comments as done. aganea added a comment. Addressed comments & finished the Linux part. All tests pass. @Meinersbur : Just to show the difference between Windows & Linux, here's some timings for running the tests over the same `

[PATCH] D62731: Add support for options -frounding-math, -ftrapping-math, -ffp-model=, and -ffp-exception-behavior=, : Specify floating point behavior

mibintc closed this revision. mibintc added a comment. Don't know why the commit id didn't get linked when I pushed the change. Here's the closure info: commit af57dbf12e54f3a8ff48534bf1078f4de104c1cd Author: Melanie Blower

[PATCH] D70094: [clang-tidy] new altera ID dependent backward branch check

ffrankies updated this revision to Diff 228743. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D70094/new/ https://reviews.llvm.org/D70094 Files: clang-tidy/CMakeLists.txt clang-tidy/ClangTidyForceLinker.h clang-tidy/altera/AlteraTidyModule.cpp clang-tidy/altera/CMakeLists.txt cl

[PATCH] D69952: [OPENMP50]Generalize handling of context matching/scoring.

jdoerfert accepted this revision. jdoerfert added a comment. This revision is now accepted and ready to land. LGTM. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D69952/new/ https://reviews.llvm.org/D69952

[clang] f8c12ed - [OPENMP50]Add support for nested atomic and simd constructs in

Author: Alexey Bataev Date: 2019-11-11T14:28:28-05:00 New Revision: f8c12edd1a5200a2c8da754d6a3bfa7545a0 URL: https://github.com/llvm/llvm-project/commit/f8c12edd1a5200a2c8da754d6a3bfa7545a0 DIFF: https://github.com/llvm/llvm-project/commit/f8c12edd1a5200a2c8da754d6a3bfa7545a0.diff

[clang] fde11e9 - [OPENMP50]Generalize handling of context matching/scoring.

Author: Alexey Bataev Date: 2019-11-11T14:41:10-05:00 New Revision: fde11e9f23a3bf6c78ec0bcfa92e9759ee8b5054 URL: https://github.com/llvm/llvm-project/commit/fde11e9f23a3bf6c78ec0bcfa92e9759ee8b5054 DIFF: https://github.com/llvm/llvm-project/commit/fde11e9f23a3bf6c78ec0bcfa92e9759ee8b5054.diff

[PATCH] D69952: [OPENMP50]Generalize handling of context matching/scoring.

This revision was automatically updated to reflect the committed changes. Closed by commit rGfde11e9f23a3: [OPENMP50]Generalize handling of context matching/scoring. (authored by ABataev). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D69952/new/ htt

[PATCH] D69785: [OpenMP] Introduce the OpenMP-IR-Builder

jdoerfert updated this revision to Diff 228754. jdoerfert marked an inline comment as done. jdoerfert added a comment. Make attributes opt-in Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D69785/new/ https://reviews.llvm.org/D69785 Files: llvm/in

[PATCH] D69935: [DeclCXX] Remove unknown external linkage specifications

ekatz updated this revision to Diff 228755. ekatz added a comment. Removed DWARF reference from LinkageSpecDecl::LanguageIDs. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D69935/new/ https://reviews.llvm.org/D69935 Files: clang/include/clang/AST/DeclCXX.h clang/lib/AST/DeclPrinter.

[PATCH] D70052: [clang-tidy] Add misc-mutating-copy check

gbencze added a comment. In D70052#1740235 , @Eugene.Zelenko wrote: > If this is CERT rule, why check is not placed in relevant module? To be honest I was hoping for some feedback on this as I wasn't sure what the best place for this check would be. Qu

[PATCH] D69770: Add recoverable string parsing errors to APFloat

ekatz added a comment. Ping CHANGES SINCE LAST ACTION https://reviews.llvm.org/D69770/new/ https://reviews.llvm.org/D69770 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D70052: [clang-tidy] Add misc-mutating-copy check

gbencze updated this revision to Diff 228758. gbencze added a comment. Update documentation and release notes. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D70052/new/ https://reviews.llvm.org/D70052 Files: clang-tools-extra/clang-tidy/misc/CMakeLists.txt clang-tools-extra/clang-ti

[PATCH] D69935: [DeclCXX] Remove unknown external linkage specifications

dblaikie added a comment. In D69935#1739235 , @dblaikie wrote: > In D69935#1738273 , @uabelho wrote: > > > Don't you need to also remove > > > > case LinkageSpecDecl::lang_cxx_11: > > case LinkageSpecDecl::lang_

[clang] 152e83f - clang-format: fix a typo introduced by the previous change

Author: Sylvestre Ledru Date: 2019-11-11T21:52:08+01:00 New Revision: 152e83fc59af7d255df10c0f56c8fbb14dc1dea2 URL: https://github.com/llvm/llvm-project/commit/152e83fc59af7d255df10c0f56c8fbb14dc1dea2 DIFF: https://github.com/llvm/llvm-project/commit/152e83fc59af7d255df10c0f56c8fbb14dc1dea2.dif

  1   2   >