rsmith added inline comments.
================
Comment at: clang/include/clang/AST/DeclCXX.h:2762
/// ensure a stable ABI for this, we choose the DW_LANG_ encodings
/// from the dwarf standard.
enum LanguageIDs {
----------------
Using DWARF encodings here does nothing for AST format stability (compared to
using our own numbering system), and is clearly creating confusion. Please just
number these sequentially and remove the mention of DWARF here. We don't have a
stable AST format across major releases, so it's fine to change the numbers
(and hence the AST format) on master. (We don't even have working stability
across patch releases yet, but should change/fix that at some point.)
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D69935/new/
https://reviews.llvm.org/D69935
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
