[PATCH] D65382: [analyzer][NFC] Refactoring BugReporter.cpp P4.: If it can be const, make it const

baloghadamsoftware added a comment. In D65382#1605572 , @NoQ wrote: > It's counter-idiomatic to pass manager objects (`ProgramStateManager`, > `SValBuilder`, etc.) as const-references because it tells you pretty much > nothing about what you can or canno

[PATCH] D64475: [clangd] Duplicate lines of semantic highlightings sent removed.

hokein added a comment. a few more comments from my side. Comment at: clang-tools-extra/clangd/SemanticHighlighting.cpp:309 + // If the New file has fewer lines than the Old file we don't want to send + // highlightings beyond the end of the file. That might crash the client.

[PATCH] D65404: [AArch64] Disable __ARM_FEATURE_SVE without ACLE.

sdesmalen added a comment. Thanks, I see your argument for having the feature enabled even when the ACLE is still partially supported. At the moment however, LLVM still only support the assembler/disassembler and inline asm. We'll be working to add support for the ACLE soon, but for now having t

[PATCH] D64753: [CrossTU][NFCI] Refactor loadExternalAST function

gamesh411 updated this revision to Diff 212290. gamesh411 marked 5 inline comments as done. gamesh411 added a comment. - Merge RAII class - Update comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D64753/new/ https://reviews.llvm.org/D64753 Fi

[PATCH] D64753: [CrossTU][NFCI] Refactor loadExternalAST function

gamesh411 marked 2 inline comments as done. gamesh411 added a comment. Updated the revision. I find this solution definitely more compact with responsibilities more separated. One more thing that comes to mind is that maybe the whole explicit passing of CTUDir and IndexName arguments is a bit ve

[PATCH] D65234: [CodeGen]: don't treat structures returned in registers as memory inputs

glider updated this revision to Diff 212293. glider added a comment. Test for =X somehow sneaked in - drop it. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D65234/new/ https://reviews.llvm.org/D65234 Files: clang/lib/CodeGen/CGStmt.cpp clang/t

Re: r367008 - [OpenCL] Rename lang mode flag for C++ mode

Merged in r367300. Thanks, Hans On Mon, Jul 29, 2019 at 3:57 PM Anastasia Stulova wrote: > > Hi Hans, > > > I would like to ask you to merge this commit into the release 9.0 even though > it isn't really a bug fix. However it is a small rename in the command line > interface (unfortunately aff

[PATCH] D65433: [clangd] DefineInline action availability checks

kadircet created this revision. Herald added subscribers: cfe-commits, arphaman, jkorous, MaskRay, ilya-biryukov, mgorny. Herald added a project: clang. Introduces DefineInline action and initial version of availability checks. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D65

[PATCH] D65404: [AArch64] Disable __ARM_FEATURE_SVE without ACLE.

rengolin accepted this revision. rengolin added a comment. This revision is now accepted and ready to land. I see, makes sense. LGTM, thanks! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D65404/new/ https://reviews.llvm.org/D65404 ___ cfe-c

[PATCH] D65234: [CodeGen]: don't treat structures returned in registers as memory inputs

glider added a comment. +srhines Heads up: this patch reduces the size of the following Android kernel functions: _raw_spin_lock and _raw_spin_lock_bh: 132 bytes->68 bytes _raw_spin_lock_irq: 136 bytes->72 bytes _raw_spin_lock_irqsave: 144 bytes->80 bytes _raw_spin_trylock: 156 bytes->112

[PATCH] D61879: WIP: Prototype of DSE optimizations for -ftrivial-auto-var-init

glider added a comment. Vitaly, what's the current status of these patches? What's your plan on submitting them? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D61879/new/ https://reviews.llvm.org/D61879 __

[PATCH] D64475: [clangd] Duplicate lines of semantic highlightings sent removed.

jvikstrom updated this revision to Diff 212301. jvikstrom marked 14 inline comments as done. jvikstrom added a comment. Address comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D64475/new/ https://reviews.llvm.org/D64475 Files: clang-tools

[PATCH] D64922: [clangd] Added option to enable semantic highlighting via an experimental capability

jvikstrom abandoned this revision. jvikstrom added a comment. In D64922#1603759 , @nridge wrote: > I believe this is not necessary. You can add text document capabilities in > the vscode client extension like this: > > class SemanticHighlightingFeature

[PATCH] D64475: [clangd] Duplicate lines of semantic highlightings sent removed.

jvikstrom added inline comments. Comment at: clang-tools-extra/clangd/SemanticHighlighting.cpp:294 + // ArrayRefs to the current line in the highlights. + ArrayRef NewLine(New.begin(), + /*length*/0UL); ilya-biryukov wrote:

[PATCH] D65395: [clangd] Added a skeleton for a semantic highlighting feature to the vscode extension.

jvikstrom updated this revision to Diff 212302. jvikstrom added a comment. Removed the experimental capability and added it to the normal capabilites using type intersection. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D65395/new/ https://reviews

r367301 - [AArch64] Disable __ARM_FEATURE_SVE without ACLE.

Author: s.desmalen Date: Tue Jul 30 03:14:39 2019 New Revision: 367301 URL: http://llvm.org/viewvc/llvm-project?rev=367301&view=rev Log: [AArch64] Disable __ARM_FEATURE_SVE without ACLE. The Arm C Language Extensions for SVE document specifies that __ARM_FEATURE_SVE should be set when the compil

[PATCH] D65404: [AArch64] Disable __ARM_FEATURE_SVE without ACLE.

This revision was automatically updated to reflect the committed changes. Closed by commit rL367301: [AArch64] Disable __ARM_FEATURE_SVE without ACLE. (authored by s.desmalen, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior to commit: https:/

[PATCH] D64863: [clangd] Ignore diags from builtin files

kadircet updated this revision to Diff 212307. kadircet marked 3 inline comments as done. kadircet added a comment. - Address comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D64863/new/ https://reviews.llvm.org/D64863 Files: clang-tools-ex

[clang-tools-extra] r367303 - [clangd] Ignore diags from builtin files

Author: kadircet Date: Tue Jul 30 03:26:51 2019 New Revision: 367303 URL: http://llvm.org/viewvc/llvm-project?rev=367303&view=rev Log: [clangd] Ignore diags from builtin files Summary: This fixes a case where we show diagnostics on arbitrary lines, in an internal codebase. Open for ideas on unit

[PATCH] D64863: [clangd] Ignore diags from builtin files

This revision was automatically updated to reflect the committed changes. Closed by commit rL367303: [clangd] Ignore diags from builtin files (authored by kadircet, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior to commit: https://reviews.ll

r367305 - [Driver] Define _FILE_OFFSET_BITS=64 on Solaris

Author: ro Date: Tue Jul 30 03:38:41 2019 New Revision: 367305 URL: http://llvm.org/viewvc/llvm-project?rev=367305&view=rev Log: [Driver] Define _FILE_OFFSET_BITS=64 on Solaris make check-all currently fails on x86_64-pc-solaris2.11 when building with GCC 9: Undefined fi

[PATCH] D64482: [Driver] Define _FILE_OFFSET_BITS=64 on Solaris

This revision was automatically updated to reflect the committed changes. Closed by commit rL367305: [Driver] Define _FILE_OFFSET_BITS=64 on Solaris (authored by ro, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior to commit: https://reviews.l

[PATCH] D64475: [clangd] Duplicate lines of semantic highlightings sent removed.

hokein added inline comments. Comment at: clang-tools-extra/clangd/ClangdServer.cpp:81 +unsigned FileSize = SM.getFileEntryForID(MainFileID)->getSize(); +int NLines = AST.getSourceManager().getLineNumber(MainFileID, FileSize); + from the comment of the ge

[PATCH] D65050: [SemaTemplate] Mark a function type as dependent when its parameter list contains pack expansion

aaron.ballman added a comment. In D65050#1598057 , @cpplearner wrote: > In D65050#1596514 , @efriedma wrote: > > > Is this the only place where a compound type can contain a > > PackExpansionType? > > > Yes AFAIK.

[PATCH] D65287: [analyzer][CFG] Don't track the condition of asserts

baloghadamsoftware added inline comments. Comment at: clang/lib/StaticAnalyzer/Core/BugReporterVisitors.cpp:1743 + + if (Then->isInevitablySinking() || Else->isInevitablySinking()) +return true; xazax.hun wrote: > Do we consider a block assert like if both b

[PATCH] D63279: [Analyzer] Unroll for-loops where the upper boundary is a variable with know value

baloghadamsoftware marked an inline comment as not done. baloghadamsoftware added a comment. For me it is all the same whether to continue this patch or taking over Péter's. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D63279/new/ https://reviews.llvm.org/D63279 _

[PATCH] D62895: [Analyzer] Iterator Checkers - Check and simulate `std::advance`, `std::prev` and `std::next`

baloghadamsoftware added a comment. Gentle ping. Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D62895/new/ https://reviews.llvm.org/D62895 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org

[PATCH] D62893: [Analyzer] Iterator Checkers - Make range errors and invalidated access fatal

baloghadamsoftware added a comment. Gentle ping. Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D62893/new/ https://reviews.llvm.org/D62893 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org

[PATCH] D62724: [Analyzer] Iterator Checkers - Model `size()` method of containers

baloghadamsoftware added a comment. Gentle ping. Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D62724/new/ https://reviews.llvm.org/D62724 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org

[PATCH] D65286: [OpenCL] Allow OpenCL C style vector initialization in C++

mantognini added a comment. In `vector_literals_nested.cl`, we have tests for (global) constants. Do you think it would be worth testing those as well in C++ mode? Maybe the two files (`vector_literals_nested.cl` and `vector_literals_valid.cl`) should also be merged as most of their content see

[PATCH] D65206: [analyzer] Fix text range end columns in SARIF to be exclusive

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. This LGTM, but I'd appreciate a second reviewer chiming in only because Joe is a coworker. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llv

[PATCH] D65209: [analyzer] Fix a SARIF exporter crash with macro expansions

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. This LGTM, but I'd appreciate a second reviewer chiming in only because Joe is a coworker. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llv

[PATCH] D64671: [clang-tidy] New check: misc-init-local-variables

jpakkane marked 2 inline comments as done. jpakkane added a comment. In D64671#1603427 , @alexfh wrote: > A general comment: "misc" is a sort of a heap of checks that otherwise don't > have a good home. This one would probably better go to bugprone (or ma

[PATCH] D65211: [analyzer] Update the SARIF exporter to SARIF 2.1

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. This LGTM, but I'd appreciate a second reviewer chiming in only because Joe is a coworker. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llv

[PATCH] D62688: [Analyzer] Iterator Checkers - Model `empty()` method of containers

baloghadamsoftware marked 3 inline comments as done. baloghadamsoftware added a comment. In D62688#1549574 , @Szelethus wrote: > Hmm, an idea just popped into my head. I'm not sure whether we have a single > checker that does so much complicated (and tota

[PATCH] D62525: [Analyzer] Add new visitor to the iterator checkers

baloghadamsoftware added a comment. Gentle ping. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D62525/new/ https://reviews.llvm.org/D62525 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinf

[PATCH] D65443: [clangd] Fix a regression in rL366996.

hokein created this revision. hokein added a reviewer: jvikstrom. Herald added subscribers: kadircet, arphaman, jkorous, MaskRay, ilya-biryukov. Herald added a project: clang. That patch made the tweak always annotate the whole file by accident. Repository: rG LLVM Github Monorepo https://rev

[PATCH] D65445: [CrossTU] Handle case when no USR could be generated during Decl search.

balazske created this revision. Herald added subscribers: cfe-commits, gamesh411, Szelethus, dkrupp. Herald added a reviewer: martong. Herald added a project: clang. When searching for a declaration to be loaded the "lookup name" for every other Decl is computed. If the USR can not be determined h

[PATCH] D64671: [clang-tidy] New check: misc-init-local-variables

JonasToth added a comment. In D64671#1606084 , @jpakkane wrote: > In D64671#1603427 , @alexfh wrote: > > > A general comment: "misc" is a sort of a heap of checks that otherwise > > don't have a good home. This one

[PATCH] D65443: [clangd] Fix a regression in rL366996.

hokein updated this revision to Diff 212329. hokein added a comment. oops, forgot a change. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D65443/new/ https://reviews.llvm.org/D65443 Files: clang-tools-extra/clangd/refactor/tweaks/AnnotateHighligh

r367312 - Add typedef declaration information to the JSON AST dump.

Author: aaronballman Date: Tue Jul 30 06:42:19 2019 New Revision: 367312 URL: http://llvm.org/viewvc/llvm-project?rev=367312&view=rev Log: Add typedef declaration information to the JSON AST dump. When dumping a desugared QualType and the type is a type alias, also print out the id for the type

[PATCH] D64416: [AArch64] Add support for Transactional Memory Extension (TME)

chill updated this revision to Diff 212332. chill added a comment. Rebase on top of master. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D64416/new/ https://reviews.llvm.org/D64416 Files: clang/include/clang/Basic/BuiltinsAArch64.def clang/lib/Basic/Targets/AArch64.cpp clang/lib/

[PATCH] D65443: [clangd] Fix a regression in rL366996.

jvikstrom accepted this revision. jvikstrom added inline comments. This revision is now accepted and ready to land. Comment at: clang-tools-extra/clangd/refactor/tweaks/AnnotateHighlightings.cpp:43 + if (!CommonDecl) { +// Now we hit the TUDecl case where commonAncestor() r

[PATCH] D64742: Allow using -ftrivial-auto-var-init=zero in C mode without extra flags

glider added a comment. As a data point, Linus Torvalds suggested that we need a similar feature for GCC so that the "kernel C standard" mandates zero-initialization for locals: https://lkml.org/lkml/2019/7/28/206 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://revie

[PATCH] D63932: [GlobalDCE] Dead Virtual Function Elimination

ostannard added a comment. In that example, with everything having default ELF visibility, all of the vtables will get vcall_visibility public, which can't be optimised by VFE, and won't ever be relaxed to one of the tighter visibilities. The cases which can be optimised are (assuming "visibili

[PATCH] D65387: [clangd] Add a callback mechanism for handling responses from client.

hokein added a comment. In D65387#1604737 , @ilya-biryukov wrote: > Could you add a bit more context to the description of the change: why do we > need the callback and what is the problem with what we have now? > I'm sure this was discussed offline and

[PATCH] D64695: [clang-format] Added new style rule: SortNetBSDIncludes

rdwampler added a comment. In D64695#1605676 , @Manikishan wrote: > In D64695#1590948 , @Manikishan > wrote: > > > In D64695#1589818 , @lebedev.ri > > wrote: > > > > > In D

[clang-tools-extra] r367313 - [clangd] Fix a regression in rL366996.

Author: hokein Date: Tue Jul 30 07:17:45 2019 New Revision: 367313 URL: http://llvm.org/viewvc/llvm-project?rev=367313&view=rev Log: [clangd] Fix a regression in rL366996. Summary: That patch made the tweak always annotate the whole file by accident. Reviewers: jvikstrom Subscribers: ilya-biryu

[PATCH] D65443: [clangd] Fix a regression in rL366996.

hokein marked 2 inline comments as done. hokein added inline comments. Comment at: clang-tools-extra/clangd/refactor/tweaks/AnnotateHighlightings.cpp:43 + if (!CommonDecl) { +// Now we hit the TUDecl case where commonAncestor() returns null intently. +// We only annotat

[PATCH] D65443: [clangd] Fix a regression in rL366996.

This revision was automatically updated to reflect the committed changes. hokein marked an inline comment as done. Closed by commit rL367313: [clangd] Fix a regression in rL366996. (authored by hokein, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed

[PATCH] D65263: [clangd] a prototype for triggering rename after extracting.

hokein updated this revision to Diff 212345. hokein edited the summary of this revision. hokein added a comment. reimplement the mechanism based on the offline discussion. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D65263/new/ https://reviews.llv

[PATCH] D65263: [clangd] a prototype for triggering rename after extracting.

hokein updated this revision to Diff 212347. hokein added a comment. update the diff Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D65263/new/ https://reviews.llvm.org/D65263 Files: clang-tools-extra/clangd/ClangdLSPServer.cpp clang-tools-extra

[PATCH] D65445: [CrossTU] Handle case when no USR could be generated during Decl search.

martong added a comment. Thank you for this patch Balazs! Could you please elaborate in which cases we cannot generate the USR? Does it happen only if we have an anonymous union inside a function? Are there no other cases? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION http

[PATCH] D65286: [OpenCL] Allow OpenCL C style vector initialization in C++

Anastasia updated this revision to Diff 212350. Anastasia added a comment. - Merged test/CodeGenOpenCL/vector_literals_nested.cl into test/CodeGenOpenCL/vector_literals_valid.cl - Added negative test case for C++ CHANGES SINCE LAST ACTION https://reviews.llvm.org/D65286/new/ https://reviews.

[PATCH] D65263: [clangd] a prototype for triggering rename after extracting.

hokein added a comment. In D65263#1601036 , @ilya-biryukov wrote: > If we are going down that path, could we consider to pre-selecting a name of > the extract variable and its usage (using multi-select)? I agree that doing rename after extraction is no

[PATCH] D65263: [clangd] a prototype for triggering rename after extracting.

hokein added a comment. The patch is still missing tests, but should be good for early comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D65263/new/ https://reviews.llvm.org/D65263 ___ cfe-commits

r367323 - [COFF][ARM64] Reorder handling of aarch64 MSVC builtins

Author: dmajor Date: Tue Jul 30 08:32:49 2019 New Revision: 367323 URL: http://llvm.org/viewvc/llvm-project?rev=367323&view=rev Log: [COFF][ARM64] Reorder handling of aarch64 MSVC builtins In `CodeGenFunction::EmitAArch64BuiltinExpr()`, bulk move all of the aarch64 MSVC-builtin cases to an earli

[PATCH] D65453: Improve the accuracy of the Clang call graph analysis

jcranmer-intel created this revision. jcranmer-intel added a reviewer: dcoughlin. Herald added a project: clang. Herald added a subscriber: cfe-commits. This patch improves Clang call graph analysis by adding in expressions that are not found in regular function bodies, such as default arguments

[PATCH] D65403: [COFF, ARM64] Reorder handling of aarch64 MSVC builtins

This revision was automatically updated to reflect the committed changes. Closed by commit rL367323: [COFF][ARM64] Reorder handling of aarch64 MSVC builtins (authored by dmajor, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior to commit: https

[PATCH] D64564: Loop pragma parsing. NFC.

Meinersbur accepted this revision. Meinersbur added a comment. This revision is now accepted and ready to land. LGTM CHANGES SINCE LAST ACTION https://reviews.llvm.org/D64564/new/ https://reviews.llvm.org/D64564 ___ cfe-commits mailing list cfe-c

[PATCH] D64564: Loop pragma parsing. NFC.

Meinersbur requested changes to this revision. Meinersbur added inline comments. This revision now requires changes to proceed. Comment at: lib/Parse/ParsePragma.cpp:1011 + Str = llvm::StringSwitch(Str) + .Case("loop", "clang loop " + Str.str()) + .Ca

[PATCH] D65286: [OpenCL] Allow OpenCL C style vector initialization in C++

Anastasia added a comment. In D65286#1606071 , @mantognini wrote: > In `vector_literals_nested.cl`, we have tests for (global) constants. Do you > think it would be worth testing those as well in C++ mode? Maybe the two > files (`vector_literals_nested.c

[PATCH] D65286: [OpenCL] Allow OpenCL C style vector initialization in C++

Anastasia updated this revision to Diff 212358. Anastasia added a comment. - Removed another duplicate file and added testing of constant program scope initializers into vector_literals_nested.cl CHANGES SINCE LAST ACTION https://reviews.llvm.org/D65286/new/ https://reviews.llvm.org/D65286

[PATCH] D63907: [clang-scan-deps] Implementation of dependency scanner over minimized sources

aganea added subscribers: sammccall, JDevlieghere. aganea added inline comments. Comment at: clang/include/clang/Tooling/DependencyScanning/DependencyScanningFilesystem.h:1 +//===- DependencyScanningFilesystem.h - clang-scan-deps fs ===---*- C++ -*-===// +// Ge

[PATCH] D65454: AMDGPU: Add missing builtin declarations

arsenm created this revision. arsenm added reviewers: yaxunl, rampitec, b-sumner, kzhuravl. Herald added subscribers: t-tye, tpr, dstuttard, nhaehnle, wdng, jvesely. https://reviews.llvm.org/D65454 Files: include/clang/Basic/BuiltinsAMDGPU.def test/CodeGenOpenCL/builtins-amdgcn.cl Index: te

[PATCH] D64742: Allow using -ftrivial-auto-var-init=zero in C mode without extra flags

jfb added a comment. In D64742#1606244 , @glider wrote: > As a data point, Linus Torvalds suggested that we need a similar feature for > GCC so that the "kernel C standard" mandates zero-initialization for locals: > https://lkml.org/lkml/2019/7/28/206

[PATCH] D65286: [OpenCL] Allow OpenCL C style vector initialization in C++

mantognini accepted this revision. mantognini added a comment. This revision is now accepted and ready to land. LGTM, thanks for the update. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D65286/new/ https://reviews.llvm.org/D65286 ___ cfe-co

[PATCH] D65456: [OpenCL] Add generic type handling for builtin functions

svenvh created this revision. svenvh added a reviewer: Anastasia. Herald added subscribers: cfe-commits, kristina, yaxunl. Herald added a reviewer: rengolin. Herald added a project: clang. Generic types are an abstraction of type sets. It mimics the way functions are defined in the OpenCL specifi

[PATCH] D65454: AMDGPU: Add missing builtin declarations

rampitec accepted this revision. rampitec added a comment. This revision is now accepted and ready to land. LGTM CHANGES SINCE LAST ACTION https://reviews.llvm.org/D65454/new/ https://reviews.llvm.org/D65454 ___ cfe-commits mailing list cfe-commi

[PATCH] D65249: [NFC] use C++11 in AlignOf.h, remove AlignedCharArray

jfb closed this revision. jfb added a comment. https://reviews.llvm.org/rL367282 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D65249/new/ https://reviews.llvm.org/D65249 ___ cfe-commits mailing list cf

[PATCH] D65458: [NFC] Remove LLVM_ALIGNAS

jfb created this revision. jfb added a reviewer: rnk. Herald added subscribers: llvm-commits, cfe-commits, dexonsmith, jkorous, mgorny. Herald added projects: clang, LLVM. The minimum compilers support all have alignas, and we don't use LLVM_ALIGNAS anywhere anymore. This also removes an MSVC di

[PATCH] D65456: [OpenCL] Add generic type handling for builtin functions

svenvh added a comment. Main changes since D63434 : - Rename List* to Vec*. - Rename TLnn -> TLAll, TLInt, TLFloat. - Apply clang-format. - Improve/update documentation. - Factor out renaming of base types into separate commit. - Change return type of OCL2Qual. -

[PATCH] D63932: [GlobalDCE] Dead Virtual Function Elimination

ostannard updated this revision to Diff 212370. ostannard marked 2 inline comments as done. ostannard added a comment. - Rebase - Don't emit llvm.assume when not necessary (we already weren't checking for it's presence in GlobalDCE) - s/"public"/"default"/ in IR docs Repository: rG LLVM Githu

[clang-tools-extra] r367333 - [clang-tidy] Fix the documentation for linuxkernel-must-use-errs.

Author: tmroeder Date: Tue Jul 30 09:49:28 2019 New Revision: 367333 URL: http://llvm.org/viewvc/llvm-project?rev=367333&view=rev Log: [clang-tidy] Fix the documentation for linuxkernel-must-use-errs. Summary: This changes ReleaseNotes.txt to have the first sentence of the full documentation from

[PATCH] D65343: [clang-tidy] Fix the documentation for linuxkernel-must-use-errs.

This revision was automatically updated to reflect the committed changes. Closed by commit rL367333: [clang-tidy] Fix the documentation for linuxkernel-must-use-errs. (authored by tmroeder, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior to com

[PATCH] D62574: Initial draft of target-configurable address spaces.

Anastasia added inline comments. Comment at: include/clang/AST/ASTContext.h:2598 + /// Returns true if address space A overlaps with B. + bool isAddressSpaceOverlapping(LangAS A, LangAS B) const { +// A overlaps with B if either is a superset of the other.

[PATCH] D63932: [GlobalDCE] Dead Virtual Function Elimination

pcc added a comment. In D63932#1606248 , @ostannard wrote: > In that example, with everything having default ELF visibility, all of the > vtables will get vcall_visibility public, which can't be optimised by VFE, > and won't ever be relaxed to one of the

[PATCH] D65461: [OPENMP]Add support for analysis of linear variables and step.

ABataev created this revision. ABataev added a reviewer: NoQ. Herald added a subscriber: guansong. Herald added a project: clang. Added support for basic analysis of the linear variables and linear step expression. Linear loop iteration variables must be excluded from this analysis, only non-loop

[PATCH] D65428: Remove cache for macro arg stringization

vsk accepted this revision. vsk added a comment. This revision is now accepted and ready to land. Thanks, lgtm. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D65428/new/ https://reviews.llvm.org/D65428

[PATCH] D65458: [NFC] Remove LLVM_ALIGNAS

rnk accepted this revision. rnk added a comment. This revision is now accepted and ready to land. lgtm Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D65458/new/ https://reviews.llvm.org/D65458 ___ cfe-c

[PATCH] D65426: [Coverage] Hide coverage for regions with incorrect end locations (PR39942)

vsk abandoned this revision. vsk added a comment. Thanks Reid! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D65426/new/ https://reviews.llvm.org/D65426 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/m

r367337 - Remove cache for macro arg stringization

Author: rnk Date: Tue Jul 30 10:58:22 2019 New Revision: 367337 URL: http://llvm.org/viewvc/llvm-project?rev=367337&view=rev Log: Remove cache for macro arg stringization Summary: The cache recorded the wrong expansion location for all but the first stringization. It seems uncommon to stringize t

[PATCH] D65127: Even more warnings utilizing gsl::Owner/gsl::Pointer annotations

mgehre added inline comments. Comment at: clang/lib/Sema/SemaInit.cpp:6581 +if (!Callee->getIdentifier()) { + auto OO = Callee->getOverloadedOperator(); + return OO == OverloadedOperatorKind::OO_Subscript || xazax.hun wrote: > If we want to relax th

[PATCH] D65428: Remove cache for macro arg stringization

rnk added a comment. Thanks for looking into it as well, I would not have seen the issue without reviewing the test case again. :) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D65428/new/ https://reviews.llvm.org/D65428

[PATCH] D65428: Remove cache for macro arg stringization

This revision was automatically updated to reflect the committed changes. Closed by commit rL367337: Remove cache for macro arg stringization (authored by rnk, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior to commit: https://reviews.llvm.or

[PATCH] D64488: [Driver] Support -fsanitize=function on Solaris/x86

krytarowski added a comment. Something is broken between reviews. and my mailbox as I am not receiving any e-mails so pinging does not make any effect... no LLVM admin replied to my questions on this to validate whether my mail was blacklisted or similar. I have decided to change server of my

[PATCH] D65462: gn build: Fix check-clang-tools after r362702.

thakis created this revision. thakis added reviewers: hans, pcc, mbonadei. Herald added subscribers: llvm-commits, jfb. Herald added a reviewer: jdoerfert. Herald added a project: LLVM. r362702 added a test that requires clang-tidy to be linked into libclang, so add that to the gn build. https:/

[PATCH] D65462: gn build: Fix check-clang-tools after r362702.

hans accepted this revision. hans added a comment. This revision is now accepted and ready to land. Seems good to me CHANGES SINCE LAST ACTION https://reviews.llvm.org/D65462/new/ https://reviews.llvm.org/D65462 ___ cfe-commits mailing list cfe-c

[PATCH] D64666: [Sema] Enable -Wimplicit-float-conversion for integral to floating point precision loss

ziangwan marked an inline comment as done. ziangwan added inline comments. Comment at: clang/lib/Sema/SemaChecking.cpp:11656 + IsListInit = + IsListInit || (isa(OrigE) && S.getLangOpts().CPlusPlus); + aaron.ballman wrote: > ziangwan wrote: > > aaron.ballman

[PATCH] D64488: [Driver] Support -fsanitize=function on Solaris/x86

ro added a comment. In D64488#1606716 , @krytarowski wrote: > Something is broken between reviews. and my mailbox as I am not receiving any > e-mails so pinging does not make any effect... no LLVM admin replied to my > questions on this to validate wheth

[PATCH] D64564: Loop pragma parsing. NFC.

SjoerdMeijer marked an inline comment as done. SjoerdMeijer added inline comments. Comment at: lib/Parse/ParsePragma.cpp:1011 + Str = llvm::StringSwitch(Str) + .Case("loop", "clang loop " + Str.str()) + .Case("unroll_and_jam", Str) Me

[PATCH] D65462: gn build: Fix check-clang-tools after r362702.

This revision was automatically updated to reflect the committed changes. Closed by commit rL367340: gn build: Fix check-clang-tools after r362702. (authored by nico, committed by ). Changed prior to commit: https://reviews.llvm.org/D65462?vs=212387&id=212391#toc Repository: rL LLVM CHANGES

[PATCH] D65462: gn build: Fix check-clang-tools after r362702.

mbonadei added a comment. LGTM. Repository: rL LLVM CHANGES SINCE LAST ACTION https://reviews.llvm.org/D65462/new/ https://reviews.llvm.org/D65462 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/l

[PATCH] D65387: [clangd] Add a callback mechanism for handling responses from client.

jkorous added a comment. Hi @hokein, Do you have any thoughts on how to handle situation when client registers callback but doesn't send a request with registered ID later? Comment at: clang-tools-extra/clangd/ClangdLSPServer.cpp:317 +std::lock_guard Lock(ReplyCallbacksMut

[PATCH] D65184: [Sema] Thread Safety Analysis: Fix negative capability's LockKind representation.

ziangwan added a comment. The problem is: by the current state of the thread safety analysis, `ASSERT_SHARED_CAPABILTIY(!mu)` introduces a shared negative capability, whereas `RELEASE(mu)` **and `RELEASE_SHARED(mu)`** introduce an exclusive negative capability, and `UNLOCK_FUNCTION(mu)` introd

[PATCH] D65184: [Sema] Thread Safety Analysis: Fix negative capability's LockKind representation.

ziangwan marked an inline comment as done. ziangwan added inline comments. Comment at: clang/test/SemaCXX/thread-safety-annotations.h:47 +// Enable thread safety attributes only with clang. +// The attributes can be safely erased when compiling with other compilers. +#if defined(

[PATCH] D65184: [Sema] Thread Safety Analysis: Fix negative capability's LockKind representation.

ziangwan marked an inline comment as done. ziangwan added inline comments. Comment at: clang/test/SemaCXX/warn-thread-safety-negative.cpp:135-140 + if (condition) { +assertNotHeld(); // expected-warning {{mutex '!mu' is acquired exclusively and shared in the same scope}} +

[PATCH] D59474: [OpenMP 5.0] Codegen support for user-defined mappers

lildmh updated this revision to Diff 212399. lildmh marked an inline comment as done. lildmh added a comment. Change mapper function argument checking CHANGES SINCE LAST ACTION https://reviews.llvm.org/D59474/new/ https://reviews.llvm.org/D59474 Files: include/clang/AST/GlobalDecl.h lib/

[PATCH] D59474: [OpenMP 5.0] Codegen support for user-defined mappers

ABataev added a comment. Thanks, looks good. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D59474/new/ https://reviews.llvm.org/D59474 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cf

r367345 - [NFC][clang] Refactor getCompilationPhases()+Types.def step 3.

Author: zer0 Date: Tue Jul 30 12:03:17 2019 New Revision: 367345 URL: http://llvm.org/viewvc/llvm-project?rev=367345&view=rev Log: [NFC][clang] Refactor getCompilationPhases()+Types.def step 3. Dropping the 'u' entry and the entire Flags table from Types.def. Now it'll be a bit easier to tablegen

  1   2   >