ziangwan marked an inline comment as done. ziangwan added inline comments.
================ Comment at: clang/test/SemaCXX/thread-safety-annotations.h:47 +// Enable thread safety attributes only with clang. +// The attributes can be safely erased when compiling with other compilers. +#if defined(__clang__) && (!defined(SWIG)) ---------------- aaronpuchert wrote: > ziangwan wrote: > > nickdesaulniers wrote: > > > Is this test suite run with other compilers? If not, I think we can > > > remove the case? > > Yeah, you are right. I just copied the header definitions from clang thread > > safety analysis doc. > Why aren't you using the existing macros? The idea was to run the tests with > both old and new terminology, and for the time being, I think we should > maintain both. There are already tests on existing macros. I want to introduce tests about the new macros as well. Repository: rL LLVM CHANGES SINCE LAST ACTION https://reviews.llvm.org/D65184/new/ https://reviews.llvm.org/D65184 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
